Re: uhci_hcd: Possible corruption of DMA pool uhci-td_pool

2013-12-13 Thread Eugene Shatokhin
On 12/11/2013 08:41 PM, Alan Stern wrote: On Wed, 11 Dec 2013, Eugene Shatokhin wrote: Hi, On ROSA Linux with kernel 3.10.21 with DMA debug options enabled, the kernel sometimes issues a warning about DMA pool corruption (see the log below). That happens sometimes, when the system boots or

Re: [RFC/PATCH 3/3] usb/xhci-plat: remove unnecessary #ifdef checks for CONFIG_PM_SLEEP

2013-12-13 Thread Ulf Hansson
On 13 December 2013 06:18, David Cohen david.a.co...@linux.intel.com wrote: From: Santosh Shilimkar santosh.shilim...@ti.com Drivers using SET_*_PM_OPS() no longer need to #ifdef for CONFIG_PM_* So, let's remove the unnecessary #ifdef's. Signed-off-by: Santosh Shilimkar

Re: [PATCH v5 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls

2013-12-13 Thread Kishon Vijay Abraham I
On Thursday 12 December 2013 11:48 PM, Felipe Balbi wrote: Hi, On Thu, Dec 12, 2013 at 08:26:02AM -0500, Matt Porter wrote: This adds a pair of APIs that allows the generic PHY subsystem to provide information on the PHY bus width. The PHY provider driver may use phy_set_bus_width() to set

re: usb: musb: ux500: harden checks for platform data

2013-12-13 Thread Dan Carpenter
Hello Lee Jones, The patch 5f6091a023ca: usb: musb: ux500: harden checks for platform data from May 15, 2013, leads to the following static checker warning: drivers/usb/musb/ux500_dma.c:335 ux500_dma_controller_start() error: potential NULL dereference 'param_array'.

Re: [PATCH v2] USB: gadget: add maxpacket_limit field to struct usb_ep

2013-12-13 Thread Robert Baldyga
On 12/12/2013 08:14 PM, Paul Zimmerman wrote: From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Robert Baldyga Sent: Thursday, December 12, 2013 12:51 AM This patch adds maxpacket_limit to struct usb_ep. This field contains maximum value of

RE: [PATCH 1/1] AX88179_178A: Add FLAG_HW_IPALIGN to determine whether reserving NET_IP_ALIGN bytes for an SKB.

2013-12-13 Thread David Laight
From: fre...@asix.com.tw ... - skb = __netdev_alloc_skb_ip_align(dev-net, size, flags); + if (dev-driver_info-flags FLAG_HW_IPALIGN) + skb = __netdev_alloc_skb(dev-net, size, flags); + else + skb = __netdev_alloc_skb_ip_align(dev-net, size, flags); Given

[PATCH 1/1] usb: musb: ux500_dma: fix potential NULL dereference error

2013-12-13 Thread Lee Jones
static checker warning: drivers/usb/musb/ux500_dma.c:335 ux500_dma_controller_start() error: potential NULL dereference 'param_array'. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Lee Jones lee.jo...@linaro.org --- drivers/usb/musb/ux500_dma.c | 4 +++- 1 file

Re: [PATCH v5 5/9] usb: gadget: s3c-hsotg: use generic phy_init()/phy_exit() support

2013-12-13 Thread Kishon Vijay Abraham I
On Thursday 12 December 2013 06:56 PM, Matt Porter wrote: If a generic phy is present, call phy_init()/phy_exit(). This supports generic phys that must be soft reset before power on. Signed-off-by: Matt Porter mpor...@linaro.org Acked-by: Kishon Vijay Abraham I kis...@ti.com ---

Re: [PATCH v5 6/9] usb: gadget: s3c-hsotg: get phy bus width from phy subsystem

2013-12-13 Thread Kishon Vijay Abraham I
On Thursday 12 December 2013 06:56 PM, Matt Porter wrote: Adds support for querying the phy bus width from the generic phy subsystem. Configure UTMI bus width in GUSBCFG based on this value. Signed-off-by: Matt Porter mpor...@linaro.org Acked-by: Kishon Vijay Abraham I kis...@ti.com ---

re: usb: gadget: nokia: convert to new interface of f_phonet

2013-12-13 Thread Dan Carpenter
Hello Andrzej Pietrasiewicz, The patch 83167f12da05: usb: gadget: nokia: convert to new interface of f_phonet from May 23, 2013, leads to the following Smatch warnings: drivers/usb/gadget/nokia.c:209 nokia_bind_config() error: potential NULL dereference 'f_obex2'. drivers/usb/gadget/nokia.c:211

[PATCH v3] USB: gadget: add maxpacket_limit field to struct usb_ep

2013-12-13 Thread Robert Baldyga
This patch adds maxpacket_limit to struct usb_ep. This field contains maximum value of maxpacket supported by driver, and is set in driver probe. This value should be used by autoconfig() function, because value of field maxpacket is set to value from endpoint descriptor when endpoint becomes

Re: some question about period scheduleing

2013-12-13 Thread vichy
hi 2013/12/2 Alan Stern st...@rowland.harvard.edu: On Sun, 1 Dec 2013, vichy wrote: hi Alan: 2013/12/1 Alan Stern st...@rowland.harvard.edu: On Fri, 29 Nov 2013, vichy wrote: hi all: My connection like below ehci -- high speed hub - full speed device I have some questions about

Re: WG: [PATCH] usb: musb: omap2430: fix occasional musb breakage on boot

2013-12-13 Thread Grazvydas Ignotas
On Thu, Dec 12, 2013 at 11:29 PM, Andreas Naumann d...@andin.de wrote: Hi Grazvydas, Von: Grazvydas Ignotas [mailto:nota...@gmail.com] Gesendet: Donnerstag, 12. Dezember 2013 01:21 An: linux-usb@vger.kernel.org Cc: Felipe Balbi; linux-o...@vger.kernel.org; Naumann Andreas; Grazvydas

gadgetfs USB2.0 Chapter 9 Tests: Test after Addressed State fails

2013-12-13 Thread Marco Johannes
Hello! I am new to this group and hope you can help me out. I am on an embedded board with an ARM cortex a5 and using gadgetfs. An Application that is derived from the usb.c example is running on it while the board is connected to a PC with the USB 2.0 Command Verifier. I am quite new to

Re: usb: gadget: nokia: convert to new interface of f_phonet

2013-12-13 Thread Andrzej Pietrasiewicz
Hello Dan Carpenter, Thank you for your comments. W dniu 13.12.2013 12:22, Dan Carpenter pisze: Hello Andrzej Pietrasiewicz, The patch 83167f12da05: usb: gadget: nokia: convert to new interface of f_phonet from May 23, 2013, leads to the following Smatch warnings:

RE: gadgetfs USB2.0 Chapter 9 Tests: Test after Addressed State fails

2013-12-13 Thread roshan.jhalani
Hi Macro, We have observed same issue and reason for this issue is reset_config which triggers complete USB disconnect from F_FS. For SET_CONFIG(Config#0) there is no need to do USB Disconnect. This seems to be bottleneck issue for USB compliance. I believe this issue should be addressed by

Re: xhci_hcd debugging status, please?

2013-12-13 Thread Udo van den Heuvel
On 2013-12-10 16:03, Oliver Neukum wrote: Thanks, but some of the messages look quite hardcoded. Is there a patch to get rid of them? More patches concerning dynamic debugging are in the queue for 3.14 It looks like on your system it is by default switched on. You can switch it off at boot

next_string_id in Kernel 3.10

2013-12-13 Thread roshan.jhalani
Hi, Recently, we encountered one issue in Kernel 3.10(On Android 4.4) where USB enumeration is falling after many connect/disconnect. The reason for this issue is, we started using usb_gstrings_attach for string update in configuration and cdev-next_string_id is never set to 0 in disconnect

[PATCH] usb: gadget: nokia: fix error recovery path for optional functions

2013-12-13 Thread Andrzej Pietrasiewicz
In the nokia gadget some USB functions (obex 1 and 2, phonet) are optional. If at the start of nokia_bind_config e.g. fi_phonet is an error pointer, which can happen because we don't fail the bind process if usb_get_function_instance() fails for fi_phonet, then f_phonet is NULL, and phonet_stat

[PATCH v2 2/2] phy: core: Add devm_of_phy_get to phy-core

2013-12-13 Thread
From: Kamil Debski k.deb...@samsung.com Adding devm_of_phy_get will allow to get phys by supplying the device_node instead of by name. Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/phy/phy-core.c | 31 +++ include/linux/phy/phy.h |2 ++ 2 files

[PATCH v2 1/2] phy: core: Add an exported of_phy_get function

2013-12-13 Thread
From: Kamil Debski k.deb...@samsung.com Previously the of_phy_get function took a struct device * and was declared static. It was impossible to call it from another driver and thus it was impossible to get phy defined for a given node. The old function was renamed to _of_phy_get and was left for

[PATCH v2 2/2] phy: core: Add devm_of_phy_get to phy-core

2013-12-13 Thread Kamil Debski
Adding devm_of_phy_get will allow to get phys by supplying the device_node instead of by name. Signed-off-by: Kamil Debski k.deb...@samsung.com --- It seems that my git send-email is playing up and sent the previous emails without from. This is a resend. Sorry for any confusion. ---

[PATCH RESEND v2 1/2] phy: core: Add an exported of_phy_get function

2013-12-13 Thread Kamil Debski
Previously the of_phy_get function took a struct device * and was declared static. It was impossible to call it from another driver and thus it was impossible to get phy defined for a given node. The old function was renamed to _of_phy_get and was left for internal use. of_phy_get function was

RE: [PATCH 1/9] phy: core: Change the way of_phy_get is called

2013-12-13 Thread Kamil Debski
Hi, From: Kishon Vijay Abraham I [mailto:kis...@ti.com] Sent: Monday, December 09, 2013 8:23 AM On Friday 06 December 2013 04:22 PM, Kamil Debski wrote: Hi, From: Kishon Vijay Abraham I [mailto:kis...@ti.com] Sent: Friday, December 06, 2013 6:31 AM Hi, On Thursday 05

Re: [PATCH 1/1] hso: fix problem with wrong status code sent by OPTION GTM601 during RING indication

2013-12-13 Thread Dr. H. Nikolaus Schaller
Hi, Am 02.10.2013 um 09:00 schrieb Dr. H. Nikolaus Schaller: Hi Jan, we are using a GTM601 modem (Firmware 1.7) for a while and have spotted an issue that under some conditions the modem sends a packed wIndex over USB that is rejected by the hso driver making troubles afterwards. Not

Re: [PATCH RESEND v2 1/2] phy: core: Add an exported of_phy_get function

2013-12-13 Thread Kishon Vijay Abraham I
Hi, On Friday 13 December 2013 07:32 PM, Kamil Debski wrote: Previously the of_phy_get function took a struct device * and was declared static. It was impossible to call it from another driver and thus it was impossible to get phy defined for a given node. The old function was renamed to

Re: Bug#704242: Driver for PL-2303 HX not working

2013-12-13 Thread Karsten Malcher
Hello together, is there anything new for the PL-2303 HX? It would be fine if it could work like in the past. Of course for Linux there are good alternatives. Here is a new one with the CP2102 suffering easy supply voltage: http://www.ebay.de/itm/110954294607 Best regards Karsten Am

RE: [PATCH RESEND v2 1/2] phy: core: Add an exported of_phy_get function

2013-12-13 Thread Kamil Debski
Hi Kishon, From: Kishon Vijay Abraham I [mailto:kis...@ti.com] Sent: Friday, December 13, 2013 3:45 PM Hi, On Friday 13 December 2013 07:32 PM, Kamil Debski wrote: Previously the of_phy_get function took a struct device * and was declared static. It was impossible to call it from

Re: [RFC/PATCH 3/3] usb/xhci-plat: remove unnecessary #ifdef checks for CONFIG_PM_SLEEP

2013-12-13 Thread David Cohen
On Fri, Dec 13, 2013 at 09:19:34AM +0100, Ulf Hansson wrote: On 13 December 2013 06:18, David Cohen david.a.co...@linux.intel.com wrote: From: Santosh Shilimkar santosh.shilim...@ti.com Drivers using SET_*_PM_OPS() no longer need to #ifdef for CONFIG_PM_* So, let's remove the unnecessary

RE: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM support

2013-12-13 Thread Kwok, WingMan
Hello -Original Message- From: Shilimkar, Santosh Sent: Thursday, December 12, 2013 7:29 PM To: Balbi, Felipe Cc: Linux USB Mailing List; kgene@samsung.com; Linux ARM Kernel Mailing List; linux-samsung-...@vger.kernel.org; Linux OMAP Mailing List; Kwok, WingMan Subject: Re:

Re: WG: [PATCH] usb: musb: omap2430: fix occasional musb breakage on boot

2013-12-13 Thread Andreas Naumann
On 13.12.2013 13:34, Grazvydas Ignotas wrote: On Thu, Dec 12, 2013 at 11:29 PM, Andreas Naumann d...@andin.de wrote: Hi Grazvydas, Von: Grazvydas Ignotas [mailto:nota...@gmail.com] Gesendet: Donnerstag, 12. Dezember 2013 01:21 An: linux-usb@vger.kernel.org Cc: Felipe Balbi;

Re: XHCI - USB3 HDD not recognised

2013-12-13 Thread Sarah Sharp
On Fri, Dec 13, 2013 at 02:31:47PM +, Chris Clayton wrote: Hi, Hi Chris, Thanks for the bug report! Firstly, I'm not subscribed, so please cc me on any replies. I see the problem I describe below on 3.12.[0..5] and on the current 3.13 development kernel, including a kernel pulled

Re: usb mass storage bug

2013-12-13 Thread Alan Stern
On Thu, 12 Dec 2013, Felipe Balbi wrote: Felipe: Is the usb_enumerate_device_otg() routine really correct? It looks like it will try to enable HNP whenever CONFIG_USB_OTG is set, even if the root hub isn't OTG-capable. The routine does this: /*

[PATCH v6 6/9] usb: gadget: s3c-hsotg: get phy bus width from phy subsystem

2013-12-13 Thread Matt Porter
Adds support for querying the phy bus width from the generic phy subsystem. Configure UTMI bus width in GUSBCFG based on this value. Signed-off-by: Matt Porter mpor...@linaro.org Acked-by: Kishon Vijay Abraham I kis...@ti.com --- drivers/usb/gadget/s3c-hsotg.c | 14 +-

[PATCH v6 8/9] phy: add Broadcom Kona USB2 PHY driver

2013-12-13 Thread Matt Porter
Add a driver for the internal Broadcom Kona USB 2.0 PHY found on the BCM281xx family of SoCs. Signed-off-by: Matt Porter mpor...@linaro.org --- drivers/phy/Kconfig | 6 ++ drivers/phy/Makefile| 1 + drivers/phy/phy-bcm-kona-usb2.c | 158

Re: some question about period scheduleing

2013-12-13 Thread Alan Stern
On Fri, 13 Dec 2013, vichy wrote: hi 2013/12/2 Alan Stern st...@rowland.harvard.edu: On Sun, 1 Dec 2013, vichy wrote: hi Alan: 2013/12/1 Alan Stern st...@rowland.harvard.edu: On Fri, 29 Nov 2013, vichy wrote: hi all: My connection like below ehci -- high speed hub -

[PATCH v6 9/9] ARM: dts: add usb udc support to bcm281xx

2013-12-13 Thread Matt Porter
Adds USB OTG/PHY and clock support to BCM281xx and enables UDC support on the bcm11351-brt and bcm28155-ap boards. Signed-off-by: Matt Porter mpor...@linaro.org Reviewed-by: Markus Mayer markus.ma...@linaro.org Reviewed-by: Tim Kryger tim.kry...@linaro.org --- arch/arm/boot/dts/bcm11351-brt.dts

[PATCH v6 5/9] usb: gadget: s3c-hsotg: use generic phy_init()/phy_exit() support

2013-12-13 Thread Matt Porter
If a generic phy is present, call phy_init()/phy_exit(). This supports generic phys that must be soft reset before power on. Signed-off-by: Matt Porter mpor...@linaro.org Acked-by: Kishon Vijay Abraham I kis...@ti.com --- drivers/usb/gadget/s3c-hsotg.c | 5 + 1 file changed, 5 insertions(+)

[PATCH v6 7/9] phy: add Broadcom Kona USB2 PHY DT binding

2013-12-13 Thread Matt Porter
Add a binding that describes the Broadcom Kona USB2 PHY found on the BCM281xx family of SoCs. Signed-off-by: Matt Porter mpor...@linaro.org Acked-by: Kishon Vijay Abraham I kis...@ti.com --- Documentation/devicetree/bindings/phy/bcm-phy.txt | 15 +++ 1 file changed, 15 insertions(+)

[PATCH v6 0/9] USB Device Controller support for BCM281xx

2013-12-13 Thread Matt Porter
Changes since v5: - tweak s3c-hsotg Kconfig help message to be more generic Changes since v4: - phy_set/get_bus_width now use an int for bus_width Changes since v3: - Rebased on 3.13-rc3 - Move struct phy bus_width attribute back into struct phy_attrs -

[PATCH v6 3/9] usb: gadget: s3c-hsotg: enable build for other platforms

2013-12-13 Thread Matt Porter
Remove unused Samsung-specific machine include and Kconfig dependency on S3C. Signed-off-by: Matt Porter mpor...@linaro.org Reviewed-by: Markus Mayer markus.ma...@linaro.org Reviewed-by: Tim Kryger tim.kry...@linaro.org --- drivers/usb/gadget/Kconfig | 7 +++

[PATCH v6 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls

2013-12-13 Thread Matt Porter
This adds a pair of APIs that allows the generic PHY subsystem to provide information on the PHY bus width. The PHY provider driver may use phy_set_bus_width() to set the bus width that the PHY supports. The controller driver may then use phy_get_bus_width() to fetch the PHY bus width in order to

[PATCH v6 4/9] usb: gadget: s3c-hsotg: add snps,dwc2 compatible string

2013-12-13 Thread Matt Porter
Enable support for the dwc2 binding. Signed-off-by: Matt Porter mpor...@linaro.org --- drivers/usb/gadget/s3c-hsotg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c index 8ceb5ef..7c5d8bd 100644 ---

[PATCH v6 2/9] staging: dwc2: update DT binding to add generic clock/phy properties

2013-12-13 Thread Matt Porter
dwc2/s3c-hsotg require a single clock to be specified and optionally a generic phy. On the s3c-hsotg driver old style USB phy support is present as a fallback so the generic phy properties are optional. Signed-off-by: Matt Porter mpor...@linaro.org Acked-by: Kishon Vijay Abraham I kis...@ti.com

Re: xhci_hcd and Canon Lide 110 not playing well together

2013-12-13 Thread Holger Hans Peter Freyther
On Tue, May 28, 2013 at 07:40:57PM +0200, Holger Hans Peter Freyther wrote: Good Evening, Is there a timeline when you think this could be fixed? I tried with 3.10.x and 3.12.5 and the symptoms remain the same. The first time it is working, the second time the scanning does not start. The

Re: [PATCH] USB: core: Add warm reset while reset-resuming SuperSpeed HUBs

2013-12-13 Thread Sarah Sharp
On Thu, Dec 12, 2013 at 11:05:04AM -0500, Alan Stern wrote: On Wed, 11 Dec 2013, Julius Werner wrote: ...although, the spec says that it does not wait for the port resets to complete. As far as I can see re-issuing a warm reset and waiting is the only way to guarantee the core times

Re: [PATCH] USB: core: Add warm reset while reset-resuming SuperSpeed HUBs

2013-12-13 Thread David Cohen
Hi Sarah, On Fri, Dec 13, 2013 at 09:48:15AM -0800, Sarah Sharp wrote: On Thu, Dec 12, 2013 at 11:05:04AM -0500, Alan Stern wrote: On Wed, 11 Dec 2013, Julius Werner wrote: ...although, the spec says that it does not wait for the port resets to complete. As far as I can see

Re: [PATCH] USB: core: Add warm reset while reset-resuming SuperSpeed HUBs

2013-12-13 Thread Dan Williams
On Fri, Dec 13, 2013 at 9:48 AM, Sarah Sharp sarah.a.sh...@linux.intel.com wrote: On Thu, Dec 12, 2013 at 11:05:04AM -0500, Alan Stern wrote: On Wed, 11 Dec 2013, Julius Werner wrote: ...although, the spec says that it does not wait for the port resets to complete. As far as I can see

Re: [usb-storage] UAS hangs khubd on USB disconnect

2013-12-13 Thread Sarah Sharp
On Thu, Dec 12, 2013 at 05:04:31PM -0500, Alan Stern wrote: On Wed, 11 Dec 2013, Sarah Sharp wrote: Hi Hans, I've been testing the UAS code you sent a pull request for against 3.13-rc1, and I've run into a rather nasty issue with USB disconnect. I ran some tests with a USB 3.0

Re: [PATCH] USB: core: Add warm reset while reset-resuming SuperSpeed HUBs

2013-12-13 Thread Alan Stern
On Fri, 13 Dec 2013, Dan Williams wrote: I'm actually leaning towards enabling the check for warm reset broadly. It seems like it wouldn't hurt to issue a warm reset on the USB 3.0 ports if they're in compliance, poll, or rx.detect. So, let's enable this broadly in xhci_resume, mark the

Re: [usb-storage] UAS hangs khubd on USB disconnect

2013-12-13 Thread Alan Stern
On Fri, 13 Dec 2013, Sarah Sharp wrote: Given the way things work now, I suspect these warnings are truly harmless. We could simply get rid of the WARN in sysfs_remove_group. The alternative is to call device_del for SCSI targets earlier on, such as when their hosts are

Re: [PATCH] USB: core: Add warm reset while reset-resuming SuperSpeed HUBs

2013-12-13 Thread Dan Williams
On Fri, Dec 13, 2013 at 10:15 AM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 13 Dec 2013, Dan Williams wrote: I'm actually leaning towards enabling the check for warm reset broadly. It seems like it wouldn't hurt to issue a warm reset on the USB 3.0 ports if they're in compliance,

Re: [PATCH] USB: core: Add warm reset while reset-resuming SuperSpeed HUBs

2013-12-13 Thread David Cohen
On Fri, Dec 13, 2013 at 10:00:28AM -0800, David Cohen wrote: Hi Sarah, On Fri, Dec 13, 2013 at 09:48:15AM -0800, Sarah Sharp wrote: On Thu, Dec 12, 2013 at 11:05:04AM -0500, Alan Stern wrote: On Wed, 11 Dec 2013, Julius Werner wrote: ...although, the spec says that it does not

Re: [usb-storage] UAS hangs khubd on USB disconnect

2013-12-13 Thread Tejun Heo
Hello, guys. (cc'ing Greg) On Fri, Dec 13, 2013 at 01:19:36PM -0500, Alan Stern wrote: On Fri, 13 Dec 2013, Sarah Sharp wrote: Given the way things work now, I suspect these warnings are truly harmless. We could simply get rid of the WARN in sysfs_remove_group. The alternative

Re: [usb-storage] UAS hangs khubd on USB disconnect

2013-12-13 Thread Sarah Sharp
On Fri, Dec 13, 2013 at 01:19:36PM -0500, Alan Stern wrote: On Fri, 13 Dec 2013, Sarah Sharp wrote: Given the way things work now, I suspect these warnings are truly harmless. We could simply get rid of the WARN in sysfs_remove_group. The alternative is to call device_del for

Re: [usb-storage] UAS hangs khubd on USB disconnect

2013-12-13 Thread James Bottomley
On Fri, 2013-12-13 at 13:33 -0500, Tejun Heo wrote: Hello, guys. (cc'ing Greg) On Fri, Dec 13, 2013 at 01:19:36PM -0500, Alan Stern wrote: On Fri, 13 Dec 2013, Sarah Sharp wrote: Given the way things work now, I suspect these warnings are truly harmless. We could simply get

Re: [PATCH] xhci: Use TRB_CYCLE instead of the constant 0x1

2013-12-13 Thread Sarah Sharp
Hi David, All right, I'm finally starting to catch up on my patch queue. :) Sorry for the delay. In general this looks like a good patch, thanks for submitting it. However, there's a couple things I need you to fix. On Mon, Nov 04, 2013 at 11:36:00AM -, David Laight wrote: In many cases

Re: [PATCH] xhci: Use TRB_CYCLE instead of the constant 0x1

2013-12-13 Thread Sarah Sharp
On Fri, Dec 13, 2013 at 11:47:56AM -0800, Sarah Sharp wrote: Hi David, All right, I'm finally starting to catch up on my patch queue. :) Sorry for the delay. In general this looks like a good patch, thanks for submitting it. However, there's a couple things I need you to fix. Ah, I just

Re: [PATCH v3] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-12-13 Thread Felipe Balbi
Hi, On Fri, Dec 13, 2013 at 08:48:30AM +0100, Andreas Larsson wrote: On Wed, Dec 04, 2013 at 09:13:58AM +0100, Andreas Larsson wrote: +static void gr_finish_request(struct gr_ep *ep, struct gr_request *req, + int status) +{ + struct gr_udc *dev; + +

Re: [PATCH] xhci: Allocate the td array and urb_priv together.

2013-12-13 Thread Sarah Sharp
On Mon, Nov 04, 2013 at 11:32:41AM -, David Laight wrote: Replace the array of pointers to transfer descriptors with the transfer descriptors themselves. This saves a kzalloc() call on every transfer and some memory indirections. The only possible downside is for isochronous tranfers

Re: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM support

2013-12-13 Thread Felipe Balbi
On Fri, Dec 13, 2013 at 10:04:38AM -0600, Kwok, WingMan wrote: Hello -Original Message- From: Shilimkar, Santosh Sent: Thursday, December 12, 2013 7:29 PM To: Balbi, Felipe Cc: Linux USB Mailing List; kgene@samsung.com; Linux ARM Kernel Mailing List;

Re: [PATCH 7/7] usb: dwc3: exynos: add pm_runtime support

2013-12-13 Thread Felipe Balbi
On Fri, Dec 13, 2013 at 02:01:32PM +0900, Anton Tikhomirov wrote: Hi Felipe, -static int dwc3_exynos_suspend(struct device *dev) +static int __dwc3_exynos_suspend(struct dwc3_exynos *exynos) { - struct dwc3_exynos *exynos = dev_get_drvdata(dev); - clk_disable(exynos-clk);

Re: gadgetfs USB2.0 Chapter 9 Tests: Test after Addressed State fails

2013-12-13 Thread Felipe Balbi
hi, On Fri, Dec 13, 2013 at 01:36:03PM +, roshan.jhal...@broadcom.com wrote: Hi Macro, We have observed same issue and reason for this issue is reset_config which triggers complete USB disconnect from F_FS. For SET_CONFIG(Config#0) there is no need to do USB Disconnect. This seems to

Re: [usb-storage] UAS hangs khubd on USB disconnect

2013-12-13 Thread James Bottomley
On Fri, 2013-12-13 at 11:18 -0800, James Bottomley wrote: On Fri, 2013-12-13 at 13:33 -0500, Tejun Heo wrote: Hello, guys. (cc'ing Greg) On Fri, Dec 13, 2013 at 01:19:36PM -0500, Alan Stern wrote: On Fri, 13 Dec 2013, Sarah Sharp wrote: Given the way things work now, I

Re: [usb-storage] UAS hangs khubd on USB disconnect

2013-12-13 Thread Alan Stern
On Fri, 13 Dec 2013, James Bottomley wrote: I wasn't clear on the reason for that problem. Does it also arise from late device_del for scsi_target? I could try to change the way that works, if anybody (Hans?) would like to test it. While the recent sysfs changes made this issue

Re: [PATCH] usb: xhci: Add 2nd memory barrier to giveback_first_trb()

2013-12-13 Thread Sarah Sharp
On Wed, Nov 13, 2013 at 10:24:00AM -, David Laight wrote: Greg KH wrote: On Tue, Nov 12, 2013 at 01:58:05PM -, David Laight wrote: There needs to be a wmb() barrier between the write to the cycle bit in the first TRB and the write to the doorbell register. Since it isn't

Re: [PATCH v2] usb: xhci: Use TRB_CYCLE instead of the constant 0x1

2013-12-13 Thread Sarah Sharp
On Mon, Nov 11, 2013 at 04:15:26PM -, David Laight wrote: This makes it clear that the ring-cycle_state value is used when writing to the actual ring itself. Always use ^= TRB_CYCLE to invert the bit. Signed-off-by: David Laight david.lai...@aculab.com --- Changes for v2: 1

Re: [PATCH v6 08/15] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume

2013-12-13 Thread Felipe Balbi
On Fri, Dec 13, 2013 at 02:31:42PM +0800, Peter Chen wrote: On Fri, Dec 13, 2013 at 12:32 PM, Felipe Balbi ba...@ti.com wrote: On Fri, Dec 13, 2013 at 09:23:38AM +0800, Peter Chen wrote: Implementation of notify_suspend and notify_resume will be different according to mxs_phy_data-flags.

RE: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM support

2013-12-13 Thread Kwok, WingMan
-Original Message- From: Balbi, Felipe Sent: Friday, December 13, 2013 2:55 PM To: Kwok, WingMan Cc: Shilimkar, Santosh; Balbi, Felipe; Linux USB Mailing List; kgene@samsung.com; Linux ARM Kernel Mailing List; linux-samsung- s...@vger.kernel.org; Linux OMAP Mailing List

Re: [PATCH 7/7] usb: dwc3: exynos: add pm_runtime support

2013-12-13 Thread Felipe Balbi
On Fri, Dec 13, 2013 at 01:56:18PM -0600, Felipe Balbi wrote: On Fri, Dec 13, 2013 at 02:01:32PM +0900, Anton Tikhomirov wrote: Hi Felipe, -static int dwc3_exynos_suspend(struct device *dev) +static int __dwc3_exynos_suspend(struct dwc3_exynos *exynos) { - struct dwc3_exynos

Re: [usb-storage] UAS hangs khubd on USB disconnect

2013-12-13 Thread Hans de Goede
Hi James, On 12/13/2013 09:03 PM, James Bottomley wrote: On Fri, 2013-12-13 at 11:18 -0800, James Bottomley wrote: On Fri, 2013-12-13 at 13:33 -0500, Tejun Heo wrote: Hello, guys. (cc'ing Greg) On Fri, Dec 13, 2013 at 01:19:36PM -0500, Alan Stern wrote: On Fri, 13 Dec 2013, Sarah Sharp

Re: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM support

2013-12-13 Thread Felipe Balbi
On Fri, Dec 13, 2013 at 02:18:42PM -0600, Kwok, WingMan wrote: -Original Message- From: Balbi, Felipe Sent: Friday, December 13, 2013 2:55 PM To: Kwok, WingMan Cc: Shilimkar, Santosh; Balbi, Felipe; Linux USB Mailing List; kgene@samsung.com; Linux ARM Kernel Mailing List;

Re: [usb-storage] UAS hangs khubd on USB disconnect

2013-12-13 Thread Alan Stern
On Fri, 13 Dec 2013, James Bottomley wrote: Actually, I think I have this figured out. There's a thinko in one of the scsi_target_reap() cases. The original (and still existing) problem with targets is that nothing creates them and nothing destroys them, so, while we could rely on the

Re: [usb-storage] UAS hangs khubd on USB disconnect

2013-12-13 Thread Sarah Sharp
On Fri, Dec 13, 2013 at 12:03:19PM -0800, James Bottomley wrote: Actually, I think I have this figured out. There's a thinko in one of the scsi_target_reap() cases. The original (and still existing) problem with targets is that nothing creates them and nothing destroys them, so, while we

Re: [usb-storage] UAS hangs khubd on USB disconnect

2013-12-13 Thread James Bottomley
On Fri, 2013-12-13 at 16:06 -0500, Alan Stern wrote: On Fri, 13 Dec 2013, James Bottomley wrote: Actually, I think I have this figured out. There's a thinko in one of the scsi_target_reap() cases. The original (and still existing) problem with targets is that nothing creates them and

Re: [usb-storage] UAS hangs khubd on USB disconnect

2013-12-13 Thread Hans de Goede
Hi, On 12/13/2013 09:03 PM, James Bottomley wrote: snip Actually, I think I have this figured out. There's a thinko in one of the scsi_target_reap() cases. The original (and still existing) problem with targets is that nothing creates them and nothing destroys them, so, while we could rely

RE: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM support

2013-12-13 Thread Kwok, WingMan
-Original Message- From: Balbi, Felipe Sent: Friday, December 13, 2013 3:23 PM To: Kwok, WingMan Cc: Balbi, Felipe; Shilimkar, Santosh; Linux USB Mailing List; kgene@samsung.com; Linux ARM Kernel Mailing List; linux-samsung- s...@vger.kernel.org; Linux OMAP Mailing List

[PATCH] usbtest: Fix BOS control test for USB 2.01 devices.

2013-12-13 Thread Sarah Sharp
Commit c952a8ba7136505cd1ca01735cc748ddc08c7d2f usb: usbtest: add a test case to support bos for queue control will cause USB 2.01 and USB 2.10 devices with a BOS descriptor to fail case 15 of the control test. The Link PM errata (released in 2007, updated in 2011) says: The value of the bcdUSB

Re: [PATCH] usb: host: xhci: Move suspend ops under PM_SLEEP to avoid warning

2013-12-13 Thread Santosh Shilimkar
On Friday 13 December 2013 12:23 AM, David Cohen wrote: On Thu, Dec 12, 2013 at 07:25:55PM -0800, David Cohen wrote: On Thu, Dec 12, 2013 at 09:01:04PM -0500, Santosh Shilimkar wrote: On Thursday 12 December 2013 08:51 PM, David Cohen wrote: On Thu, Dec 12, 2013 at 08:06:24PM -0500, Santosh

Re: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM support

2013-12-13 Thread Santosh Shilimkar
On Thursday 12 December 2013 07:43 PM, Felipe Balbi wrote: On Thu, Dec 12, 2013 at 07:29:24PM -0500, Santosh Shilimkar wrote: On Thursday 12 December 2013 04:45 PM, Felipe Balbi wrote: A bare-minimum PM implementation which will server as building block for more complex s/server/serve ;-)

Re: [PATH] xhci: fix array index out of the bounds in function last_trb() and last_trb_on_last_seg().

2013-12-13 Thread Sarah Sharp
On Tue, Nov 12, 2013 at 08:46:27AM +, Wang, Lin X wrote: Hi Sarah, Hi Lin, Sorry for taking so long to respond to this patch. Yes, I think this is a bug, but the end result is harmless. Please send an updated version of the patch to me, and Cc the linux-usb mailing list. I found a

Re: UAS/xHC changes for streams

2013-12-13 Thread Sarah Sharp
On Thu, Dec 12, 2013 at 06:37:28PM +, Ashwini Pahuja wrote: Hi Sarah, I am planning to use the UAS/streams feature under Linux, I know there were a lot of patches submitted by Hans in the last few weeks. Do you have any git repository from where I can pull the latest kernel with these

Re: [usb-storage] UAS hangs khubd on USB disconnect

2013-12-13 Thread Alan Stern
On Fri, 13 Dec 2013, James Bottomley wrote: On Fri, 2013-12-13 at 16:06 -0500, Alan Stern wrote: On Fri, 13 Dec 2013, James Bottomley wrote: Actually, I think I have this figured out. There's a thinko in one of the scsi_target_reap() cases. The original (and still existing) problem

Re: [PATCH] usb: host: xhci: Move suspend ops under PM_SLEEP to avoid warning

2013-12-13 Thread David Cohen
On Fri, Dec 13, 2013 at 05:55:20PM -0500, Santosh Shilimkar wrote: On Friday 13 December 2013 12:23 AM, David Cohen wrote: On Thu, Dec 12, 2013 at 07:25:55PM -0800, David Cohen wrote: On Thu, Dec 12, 2013 at 09:01:04PM -0500, Santosh Shilimkar wrote: On Thursday 12 December 2013 08:51 PM,

Re: [usb-storage] UAS hangs khubd on USB disconnect

2013-12-13 Thread James Bottomley
On Fri, 2013-12-13 at 19:48 -0500, Alan Stern wrote: On Fri, 13 Dec 2013, James Bottomley wrote: On Fri, 2013-12-13 at 16:06 -0500, Alan Stern wrote: On Fri, 13 Dec 2013, James Bottomley wrote: Actually, I think I have this figured out. There's a thinko in one of the

Re: [usb-storage] UAS hangs khubd on USB disconnect

2013-12-13 Thread Alan Stern
On Fri, 13 Dec 2013, James Bottomley wrote: Sorry, but you're wrong. starget-reap_ref is _not_ incremented every time we add a device to the target. That's one of the things we need to fix. Well, then we would have a pretty astonishing cockup in the code. The found case of

[RFC] fix our current target reap infrastructure.

2013-12-13 Thread James Bottomley
This patch eliminates the reap_ref and replaces it with a proper kref. On last put of this kref, the target is removed from visibility in sysfs. The final call to scsi_target_reap() for the device is done from __scsi_remove_device() and only if the device was made visible. This ensures that the

Re: [RFC] fix our current target reap infrastructure.

2013-12-13 Thread Alan Stern
On Fri, 13 Dec 2013, James Bottomley wrote: This patch eliminates the reap_ref and replaces it with a proper kref. On last put of this kref, the target is removed from visibility in sysfs. The final call to scsi_target_reap() for the device is done from __scsi_remove_device() and only if the

[PATCH 3/3] usb: musb: fix setting JZ4740 gadget periphal mode on reset

2013-12-13 Thread Apelete Seketeli
JZ4740 USB Device Controller is not OTG compatible and does not have DEVCTL register in silicon. During ethernet-over-usb transactions, on reset, musb driver tries to read from DEVCTL and consequently sets device as host (A-Device) instead of peripheral (B-Device), which makes it a composite

[PATCH 0/3] Add USB support for Ingenic JZ4740

2013-12-13 Thread Apelete Seketeli
Hello, Following the fix I submitted a few weeks ago, here is a set of patches that add USB support for the Ingenic JZ4740 MIPS SoC. The JZ4740 is found in the Ben NanoNote handheld computer which is built by the Qi-Hardware community. Even though Ben NanoNote is already supported in the kernel,

[PATCH 1/3] mips: qi_lb60: add defconfig for Ben NanoNote

2013-12-13 Thread Apelete Seketeli
Add defconfig for the Ben NanoNote handheld computer which is built around QI_LB60 board and Ingenic JZ4740 MIPS SoC. Signed-off-by: Apelete Seketeli apel...@seketeli.net --- arch/mips/configs/qi_lb60_defconfig | 188 +++ 1 file changed, 188 insertions(+) create

[PATCH 2/3] usb: musb: add support for JZ4740 usb device controller

2013-12-13 Thread Apelete Seketeli
Add support for Ingenic JZ4740 USB Device Controller through a specific musb glue layer. The platform data already available in tree for that USB Device Controller was previously used by an out-of-tree USB gadget driver which was not relying on the musb driver and was written by Ingenic and the