Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-09 Thread Vivek Gautam
On Wed, Sep 10, 2014 at 10:23 AM, Felipe Balbi wrote: > On Wed, Sep 10, 2014 at 09:09:57AM +0530, Vivek Gautam wrote: >> On Wed, Sep 10, 2014 at 9:07 AM, Vivek Gautam >> wrote: >> > adding Julius here, >> >> i think i had missed adding Julius for this entire series :-( >> I should be more carefu

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-09 Thread Felipe Balbi
On Wed, Sep 10, 2014 at 09:09:57AM +0530, Vivek Gautam wrote: > On Wed, Sep 10, 2014 at 9:07 AM, Vivek Gautam > wrote: > > adding Julius here, > > i think i had missed adding Julius for this entire series :-( > I should be more careful with the CC list in future. > Added his chromium id, since t

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-09 Thread Vivek Gautam
On Wed, Sep 10, 2014 at 9:07 AM, Vivek Gautam wrote: > adding Julius here, i think i had missed adding Julius for this entire series :-( I should be more careful with the CC list in future. Added his chromium id, since that seems to be more active. > > > On Tue, Sep 9, 2014 at 8:12 PM, Felipe Ba

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-09 Thread Vivek Gautam
adding Julius here, On Tue, Sep 9, 2014 at 8:12 PM, Felipe Balbi wrote: > On Tue, Sep 09, 2014 at 07:19:50AM +0530, Vivek Gautam wrote: >> Hi, >> >> >> On Mon, Sep 8, 2014 at 7:14 PM, Felipe Balbi wrote: >> > Hi, >> > >> > On Mon, Sep 08, 2014 at 09:53:09AM +0530, Vivek Gautam wrote: >> >> On F

Re: [PATCH net-next] r8152: use usleep_range

2014-09-09 Thread David Miller
From: Hayes Wang Date: Tue, 9 Sep 2014 11:40:28 +0800 > Replace mdelay with usleep_range to avoid busy loop. > > Signed-off-by: Hayes Wang Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v8] usb:serial:pl2303: add GPIOs interface on PL2303

2014-09-09 Thread Wang YanQing
On Tue, Sep 09, 2014 at 04:02:04PM +0200, Johan Hovold wrote: > On Tue, Sep 09, 2014 at 12:43:56PM +0200, Johan Hovold wrote: > > On Tue, Sep 09, 2014 at 06:21:31PM +0800, Wang YanQing wrote: > > > On Tue, Sep 09, 2014 at 12:08:56PM +0200, Johan Hovold wrote: > > > > On Fri, Sep 05, 2014 at 09:30:1

Re: [PATCH v8] usb:serial:pl2303: add GPIOs interface on PL2303

2014-09-09 Thread Wang YanQing
On Tue, Sep 09, 2014 at 04:02:04PM +0200, Johan Hovold wrote: > On Tue, Sep 09, 2014 at 12:43:56PM +0200, Johan Hovold wrote: > > On Tue, Sep 09, 2014 at 06:21:31PM +0800, Wang YanQing wrote: > > > On Tue, Sep 09, 2014 at 12:08:56PM +0200, Johan Hovold wrote: > > > > On Fri, Sep 05, 2014 at 09:30:1

Re: [PATCHv4 03/12] usb: dwc2: Update the gadget driver to use common dwc2_hsotg structure

2014-09-09 Thread Dinh Nguyen
On 09/09/2014 02:56 PM, Paul Zimmerman wrote: >> From: Dinh Nguyen [mailto:dingu...@opensource.altera.com] >> Sent: Tuesday, September 09, 2014 12:13 PM >> >> On 09/09/2014 02:06 PM, Paul Zimmerman wrote: From: Dinh Nguyen [mailto:dingu...@opensource.altera.com] Sent: Tuesday, September 0

RE: [PATCHv4 03/12] usb: dwc2: Update the gadget driver to use common dwc2_hsotg structure

2014-09-09 Thread Paul Zimmerman
> From: Dinh Nguyen [mailto:dingu...@opensource.altera.com] > Sent: Tuesday, September 09, 2014 12:13 PM > > On 09/09/2014 02:06 PM, Paul Zimmerman wrote: > >> From: Dinh Nguyen [mailto:dingu...@opensource.altera.com] > >> Sent: Tuesday, September 09, 2014 9:26 AM > >> > >> On 09/08/2014 05:50 PM,

Re: [RFC]Johan's patch for touchscreens and port power off

2014-09-09 Thread Johan Hovold
On Tue, Sep 09, 2014 at 02:33:42PM -0400, Alan Stern wrote: > On Tue, 9 Sep 2014, Oliver Neukum wrote: > > > On Tue, 2014-09-09 at 13:25 -0400, Alan Stern wrote: > > > On Tue, 9 Sep 2014, Alan Stern wrote: > > > > > > > On Tue, 9 Sep 2014, Oliver Neukum wrote: > > > > > > > > > On Tue, 2014-09-0

[PATCH v4 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-09 Thread Octavian Purdila
This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO Master Adapter DLN-2. Details about the device can be found here: https://www.diolan.com/i2c/i2c_interface.html. Information about the USB protocol can be found in the Programmer's Reference Manual [1], see section 1.7. Because th

[PATCH v4 0/3] mfd: add support for Diolan DLN-2

2014-09-09 Thread Octavian Purdila
This patch series adds support for Diolan USB-I2C/GPIO Master Adapter DLN-2. Details about device can be found here: https://www.diolan.com/i2c/i2c_interface.html. Changes since v3: * Mostly addressing latest review comments from Johan * MFD driver: more message size checks for responses, swi

Re: Iomega SCSI-to-USB cable problem

2014-09-09 Thread Mark
On Mon, September 8, 2014 21:25, Alan Stern wrote: > On Mon, 8 Sep 2014, Mark wrote: > >> ... >> I managed to find an old Jaz drive and tested it with my cable. It seems >> to work fine, so the cable firmware does restrict itself to working with >> Jaz drives. I had the drive SCSI ID set to 4, so i

[PATCH v4 3/3] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-09 Thread Octavian Purdila
From: Daniel Baluta This patch adds GPIO and IRQ support for the Diolan DLN-2 GPIO module. Information about the USB protocol interface can be found in the Programmer's Reference Manual [1], see section 2.9 for the GPIO module commands and responses. [1] https://www.diolan.com/downloads/dln-api

[PATCH v4 2/3] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-09-09 Thread Octavian Purdila
From: Laurentiu Palcu This patch adds support for the Diolan DLN-2 I2C master module. Due to hardware limitations it does not support SMBUS quick commands. Information about the USB protocol interface can be found in the Programmer's Reference Manual [1], see section 6.2.2 for the I2C master mod

Re: [PATCH 1/2] uas: Set no_report_opcodes

2014-09-09 Thread Hans de Goede
Hi, On 09/09/2014 06:01 PM, Christoph Hellwig wrote: On Tue, Sep 09, 2014 at 04:59:59PM +0200, Hans de Goede wrote: asm1051e usb <-> sata bridges hang when receiving a report opcodes scsi cmnd. Take a page out of the usb-storage book, and simple disable no_report_opcodes outright. Given that

Re: [PATCHv4 12/12] usb: dwc2: pci: Update pci portion of the dwc2 driver

2014-09-09 Thread Felipe Balbi
On Tue, Aug 26, 2014 at 11:20:03AM -0500, dingu...@opensource.altera.com wrote: > From: Dinh Nguyen > > Initialize the spinlock here as the original spinlock in the host driver > has been removed. > > Signed-off-by: Dinh Nguyen looks like this fixes a bug introduced in patch 9/12. It's probabl

Re: [PATCHv4 03/12] usb: dwc2: Update the gadget driver to use common dwc2_hsotg structure

2014-09-09 Thread Dinh Nguyen
On 09/09/2014 02:06 PM, Paul Zimmerman wrote: >> From: Dinh Nguyen [mailto:dingu...@opensource.altera.com] >> Sent: Tuesday, September 09, 2014 9:26 AM >> >> On 09/08/2014 05:50 PM, Greg KH wrote: >>> On Tue, Aug 26, 2014 at 11:19:54AM -0500, dingu...@opensource.altera.com >>> wrote: From: Di

Re: [PATCH 2/2] uas: Disable uas on ASM1051 devices

2014-09-09 Thread Hans de Goede
Hi, On 09/09/2014 05:23 PM, Alan Stern wrote: On Tue, 9 Sep 2014, Hans de Goede wrote: Even with REPORT SUPPORTED OPERATION CODES blacklisted the ASM1051 chipset still does not work when combined with some disks, e.g. a Crucial M500 ssd. When used with a troublesome disk, the chipset throws a

RE: [PATCHv4 03/12] usb: dwc2: Update the gadget driver to use common dwc2_hsotg structure

2014-09-09 Thread Paul Zimmerman
> From: Dinh Nguyen [mailto:dingu...@opensource.altera.com] > Sent: Tuesday, September 09, 2014 9:26 AM > > On 09/08/2014 05:50 PM, Greg KH wrote: > > On Tue, Aug 26, 2014 at 11:19:54AM -0500, dingu...@opensource.altera.com > > wrote: > >> From: Dinh Nguyen > >> > >> Adds the gadget data structu

Re: [RFC]Johan's patch for touchscreens and port power off

2014-09-09 Thread Alan Stern
On Tue, 9 Sep 2014, Oliver Neukum wrote: > On Tue, 2014-09-09 at 13:25 -0400, Alan Stern wrote: > > On Tue, 9 Sep 2014, Alan Stern wrote: > > > > > On Tue, 9 Sep 2014, Oliver Neukum wrote: > > > > > > > On Tue, 2014-09-09 at 11:23 -0400, Alan Stern wrote: > > > > > On Tue, 9 Sep 2014, Oliver Neu

Re: crash in recursively_mark_NOTATTACHED

2014-09-09 Thread Alan Stern
On Tue, 9 Sep 2014, Joe Lawrence wrote: > On Tue, 9 Sep 2014 11:30:24 -0400 > Alan Stern wrote: > > > On Tue, 9 Sep 2014, Joe Lawrence wrote: > > > > In summary, khubd has initialized the usb_device maxchild to 8 and > > > provided backing-store for the usb_hub ports[] array. However, before >

Re: am335x musb_hdrc broken(?)

2014-09-09 Thread Felipe Balbi
Hi, On Tue, Sep 09, 2014 at 09:55:10PM +0400, Matwey V. Kornilov wrote: > 2014-09-09 21:49 GMT+04:00 Felipe Balbi : > > Hi, > > > > On Tue, Sep 09, 2014 at 09:16:50PM +0400, Matwey V. Kornilov wrote: > >> I am still running 3.16.1 no BeagleBone Black and after I sorted out > >> the configuration n

[RFC 02/10] fusbh200: Make Xen notificaiton consistent with EHCI

2014-09-09 Thread Chris Rorvick
If CONFIG_XEN_DOM0 is enabled, the ehci-dbgp driver notifies Xen of controller reset events via xen_dbgp_reset_prep() and xen_dbgp_external_startup() (via calls to xen_dbgp_op().) Otherwise defines them as no-ops to disable this logic. The fusbh200 driver copies much of the dbgp code from ehci_d

[RFC 00/10] Create separate header for ehci-dbgp driver

2014-09-09 Thread Chris Rorvick
The FUSBH200 and FOTG210 are not EHCI-compatible and require standalone drivers. See discussion at: http://comments.gmane.org/gmane.linux.usb.general/84169 But these controllers do implement an EHCI-compatible debug port and therefore leverage the ehci-dbgp driver. Rather than pulling in the

[RFC 01/10] usb: Create separate header for ehci-dbgp

2014-09-09 Thread Chris Rorvick
The FUSBH200 and FOTG210 controllers implement sufficiently EHCI- compatible debug ports to leverage ehci-dbgp from their respective drivers. Rather than including header, though, they replicate the necessary declarations in their own headers. Move the ehci-dbgp stuff into its own header as a fi

[RFC 05/10] fusbh200: Use ehci_dbg_port struct

2014-09-09 Thread Chris Rorvick
The FUSBH200 debug port has a EHCI-compatible register layout so there is no need to define a custom struct. Signed-off-by: Chris Rorvick --- drivers/usb/host/fusbh200.h | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/usb/host/fusbh200.h b/drivers/usb/ho

[RFC 06/10] fotg210: Make Xen notificaiton consistent with EHCI

2014-09-09 Thread Chris Rorvick
If CONFIG_XEN_DOM0 is enabled, the ehci-dbgp driver notifies Xen of controller reset events via xen_dbgp_reset_prep() and xen_dbgp_external_startup() (via calls to xen_dbgp_op().) Otherwise defines them as no-ops to disable this logic. The fotg210 driver copies much of the dbgp code from ehci_de

[RFC 03/10] fusbh200: Remove superfluous macro definitions

2014-09-09 Thread Chris Rorvick
The fusbh200_dbg_port struct is a copy of the ehci_dbg_port definition in the header. Embedded in this definition are a number of macros which came along for the ride. These macros are not used in the fusbh200 driver and will conflict those in the new header. Signed-off-by: Chris Rorvick ---

Re: crash in recursively_mark_NOTATTACHED

2014-09-09 Thread Joe Lawrence
On Tue, 9 Sep 2014 11:30:24 -0400 Alan Stern wrote: > On Tue, 9 Sep 2014, Joe Lawrence wrote: > > In summary, khubd has initialized the usb_device maxchild to 8 and > > provided backing-store for the usb_hub ports[] array. However, before > > it gets to fill in pointers for each port[] entry, t

[RFC 09/10] fotg210: Use ehci_dbg_port struct

2014-09-09 Thread Chris Rorvick
The FUSBH200 debug port has a EHCI-compatible register layout so there is no need to define a custom struct. Signed-off-by: Chris Rorvick --- drivers/usb/host/fotg210.h | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/usb/host/fotg210.h b/drivers/usb/host

[RFC 08/10] fotg210: Remove duplicate ehci-dbgp declarations

2014-09-09 Thread Chris Rorvick
Now that ehci-dbgp has its own header, use it rather than duplicating the declarations, etc. Signed-off-by: Chris Rorvick --- drivers/usb/host/fotg210.h | 40 ++-- 1 file changed, 2 insertions(+), 38 deletions(-) diff --git a/drivers/usb/host/fotg210.h b/driv

[RFC 07/10] fotg210: Remove superfluous macro definitions

2014-09-09 Thread Chris Rorvick
The fotg210_dbg_port struct is a copy of the ehci_dbg_port definition in the header. Embedded in this definition are a number of macros which came along for the ride. These macros are not used in the fotg210 driver and will conflict those in the new header. Signed-off-by: Chris Rorvick --- d

[RFC 04/10] fusbh200: Remove duplicate ehci-dbgp declarations

2014-09-09 Thread Chris Rorvick
Now that ehci-dbgp has its own header, use it rather than duplicating the declarations, etc. Signed-off-by: Chris Rorvick --- drivers/usb/host/fusbh200.h | 40 ++-- 1 file changed, 2 insertions(+), 38 deletions(-) diff --git a/drivers/usb/host/fusbh200.h b/dr

[RFC 10/10] usb: Remove __init from early_dbgp_init() prototype

2014-09-09 Thread Chris Rorvick
Specifying these attributes in both the prototype and the function definition is unnecessary and could cause confusion or bugs if they are inconsistent. As such, __init should only be specified at the function definition. Keith Owens suggested this as a janitorial task on LKML several years ago:

Re: [PATCHv4 03/12] usb: dwc2: Update the gadget driver to use common dwc2_hsotg structure

2014-09-09 Thread Dinh Nguyen
Hi Paul, On 09/08/2014 05:50 PM, Greg KH wrote: > On Tue, Aug 26, 2014 at 11:19:54AM -0500, dingu...@opensource.altera.com > wrote: >> From: Dinh Nguyen >> >> Adds the gadget data structure and appropriate data structure pointers >> to the common dwc2_hsotg data structure. To keep the driver dat

Re: am335x musb_hdrc broken(?)

2014-09-09 Thread Matwey V. Kornilov
2014-09-09 21:49 GMT+04:00 Felipe Balbi : > Hi, > > On Tue, Sep 09, 2014 at 09:16:50PM +0400, Matwey V. Kornilov wrote: >> I am still running 3.16.1 no BeagleBone Black and after I sorted out >> the configuration nothing oopses, but there is another problem. >> I can't attach any device (including

Re: am335x musb_hdrc broken(?)

2014-09-09 Thread Felipe Balbi
Hi, On Tue, Sep 09, 2014 at 09:16:50PM +0400, Matwey V. Kornilov wrote: > I am still running 3.16.1 no BeagleBone Black and after I sorted out > the configuration nothing oopses, but there is another problem. > I can't attach any device (including but not limited to USB-hub with > external power)

Re: [RFC]Johan's patch for touchscreens and port power off

2014-09-09 Thread Oliver Neukum
On Tue, 2014-09-09 at 13:25 -0400, Alan Stern wrote: > On Tue, 9 Sep 2014, Alan Stern wrote: > > > On Tue, 9 Sep 2014, Oliver Neukum wrote: > > > > > On Tue, 2014-09-09 at 11:23 -0400, Alan Stern wrote: > > > > On Tue, 9 Sep 2014, Oliver Neukum wrote: > > > > > > > > > Hi, > > > > > > > > > > J

Re: randconfig build error with next-20140909, in drivers/usb/dwc2/platform.c

2014-09-09 Thread Randy Dunlap
On 09/09/14 07:46, Jim Davis wrote: > Building with the attached random configuration file, > > drivers/usb/dwc2/platform.o: In function `dwc2_platform_driver_init': > platform.c:(.init.text+0x0): multiple definition of `init_module' > drivers/usb/dwc2/gadget.o:gadget.c:(.init.text+0x0): first def

Re: [RFC]Johan's patch for touchscreens and port power off

2014-09-09 Thread Oliver Neukum
On Tue, 2014-09-09 at 12:53 -0400, Alan Stern wrote: > On Tue, 9 Sep 2014, Oliver Neukum wrote: > > > On Tue, 2014-09-09 at 11:23 -0400, Alan Stern wrote: > > > On Tue, 9 Sep 2014, Oliver Neukum wrote: > > > > > > > Hi, > > > > > > > > Johan's patch means that for the affected touchscreen the po

Re: [RFC]Johan's patch for touchscreens and port power off

2014-09-09 Thread Alan Stern
On Tue, 9 Sep 2014, Alan Stern wrote: > On Tue, 9 Sep 2014, Oliver Neukum wrote: > > > On Tue, 2014-09-09 at 11:23 -0400, Alan Stern wrote: > > > On Tue, 9 Sep 2014, Oliver Neukum wrote: > > > > > > > Hi, > > > > > > > > Johan's patch means that for the affected touchscreen the port > > > > can

Re: [PATCH stable 0/6] usb: dwc2/gadget: fixes for gadget driver

2014-09-09 Thread Greg KH
On Tue, Sep 09, 2014 at 10:48:10AM +0200, Robert Baldyga wrote: > Hi, > > This patch series contains fixes for dwc2/gadget driver. It's intended > for 3.16-stable. That's not how stable patch submission works :( The patches need to be in Linus's tree first, then, if they don't apply to a stable

Re: [PATCH v3 0/9] Tegra xHCI support

2014-09-09 Thread Andrew Bresticker
On Tue, Sep 9, 2014 at 1:21 AM, Tomeu Vizoso wrote: > On 8 September 2014 18:22, Andrew Bresticker wrote: >> On Mon, Sep 8, 2014 at 8:34 AM, Tomeu Vizoso wrote: >>> On 2 September 2014 23:34, Andrew Bresticker wrote: Tested on Venice2, Jetson TK1, and Big with a variety of USB2.0 and

Re: [RFC]Johan's patch for touchscreens and port power off

2014-09-09 Thread Alan Stern
On Tue, 9 Sep 2014, Oliver Neukum wrote: > On Tue, 2014-09-09 at 11:23 -0400, Alan Stern wrote: > > On Tue, 9 Sep 2014, Oliver Neukum wrote: > > > > > Hi, > > > > > > Johan's patch means that for the affected touchscreen the port > > > can never be powered off. It seems to me that this needs a s

Re: [patch] usb: gadget: f_fs: signedness bug in __ffs_func_bind_do_descs()

2014-09-09 Thread Felipe Balbi
Hi, On Tue, Sep 09, 2014 at 06:37:02PM +0200, Michal Nazarewicz wrote: > On Tue, Sep 09 2014, Dan Carpenter wrote: > > On Tue, Sep 09, 2014 at 03:57:26PM +0200, Michal Nazarewicz wrote: > >> On Tue, Sep 09 2014, Dan Carpenter wrote: > >> > Btw, there is a sparse warning: > >> > > >> > drivers/us

Re: OOPS: musb_hdrc

2014-09-09 Thread Felipe Balbi
Hi, On Tue, Sep 09, 2014 at 08:17:32PM +0400, Matwey V. Kornilov wrote: > 2014-09-09 20:09 GMT+04:00 Felipe Balbi : > > On Tue, Sep 09, 2014 at 07:52:59PM +0400, Matwey V. Kornilov wrote: > >> 2014-09-09 19:11 GMT+04:00 Felipe Balbi : > >> > the proper way would be to move everything to dma_engine

Re: [patch] usb: gadget: f_fs: signedness bug in __ffs_func_bind_do_descs()

2014-09-09 Thread Michal Nazarewicz
On Tue, Sep 09 2014, Dan Carpenter wrote: > On Tue, Sep 09, 2014 at 03:57:26PM +0200, Michal Nazarewicz wrote: >> On Tue, Sep 09 2014, Dan Carpenter wrote: >> > Btw, there is a sparse warning: >> > >> > drivers/usb/gadget/function/f_fs.c:401:44: warning: Variable length array >> > is used. >> >

Re: OOPS: musb_hdrc

2014-09-09 Thread Matwey V. Kornilov
2014-09-09 20:09 GMT+04:00 Felipe Balbi : > On Tue, Sep 09, 2014 at 07:52:59PM +0400, Matwey V. Kornilov wrote: >> 2014-09-09 19:11 GMT+04:00 Felipe Balbi : >> > the proper way would be to move everything to dma_engine. OMAP already >> > has support for DMA engine and both CPPI and Ux500 are alread

Re: [RFC]Johan's patch for touchscreens and port power off

2014-09-09 Thread Oliver Neukum
On Tue, 2014-09-09 at 11:23 -0400, Alan Stern wrote: > On Tue, 9 Sep 2014, Oliver Neukum wrote: > > > Hi, > > > > Johan's patch means that for the affected touchscreen the port > > can never be powered off. It seems to me that this needs a special > > flag. What do you think? > > Why can't the p

Re: OOPS: musb_hdrc

2014-09-09 Thread Felipe Balbi
On Tue, Sep 09, 2014 at 07:52:59PM +0400, Matwey V. Kornilov wrote: > 2014-09-09 19:11 GMT+04:00 Felipe Balbi : > > the proper way would be to move everything to dma_engine. OMAP already > > has support for DMA engine and both CPPI and Ux500 are already using > > that. > > If so, ux500_dma.c and m

Re: [PATCH 1/2] uas: Set no_report_opcodes

2014-09-09 Thread Christoph Hellwig
On Tue, Sep 09, 2014 at 04:59:59PM +0200, Hans de Goede wrote: > asm1051e usb <-> sata bridges hang when receiving a report opcodes scsi cmnd. > Take a page out of the usb-storage book, and simple disable no_report_opcodes > outright. Given that this device also seems broken in other ways can we w

Re: OOPS: musb_hdrc

2014-09-09 Thread Matwey V. Kornilov
2014-09-09 19:11 GMT+04:00 Felipe Balbi : > the proper way would be to move everything to dma_engine. OMAP already > has support for DMA engine and both CPPI and Ux500 are already using > that. If so, ux500_dma.c and musb_cppi41.c should be almost identically wrapping dmaengine, but they aren't.

Re: use after free in hub_events

2014-09-09 Thread Alan Stern
On Tue, 9 Sep 2014, Alan Stern wrote: > The fix is almost correct. Take the reference when hub_events removes > the hub from hub_event_list, while the hub_event_lock is still held. > That way the get and put occur in the same subroutine, and there's > opportunity for them to become unbalanced

Re: use after free in hub_events

2014-09-09 Thread Alan Stern
On Tue, 9 Sep 2014, Joe Lawrence wrote: ... > hub_events does later go on to check for hub->disconnected, but that's > outside the hub_event_lock and *after* the call to usb_lock_device. In > my traces, that's too late as its already been freed and poisoned. > > There's probably a better way to

Re: crash in recursively_mark_NOTATTACHED

2014-09-09 Thread Alan Stern
On Tue, 9 Sep 2014, Joe Lawrence wrote: > Hello linux-usb, > > I've been testing surprise device hotlug removal with RHEL7 on Stratus > hardware (fully redundant PCI branches) and ran into a crashing NULL-ptr > bug during device initialization. The code looks the same upstream, so > I'm reportin

Re: [REGRESSION 3.17] scsi (uas) disks no longer using tagged command queuing

2014-09-09 Thread Christoph Hellwig
On Tue, Sep 09, 2014 at 11:15:24AM +0200, Hans de Goede wrote: > Taking the uas.c file from 3.17, and building it for 3.16 restores > the use of tcq (debugged by adding a printk blk_rq_tagged + request->tag). > > So either uas is doing something wrong which happened to work in > 3.16, or something

Re: [PATCH 2/2] uas: Disable uas on ASM1051 devices

2014-09-09 Thread Alan Stern
On Tue, 9 Sep 2014, Hans de Goede wrote: > Even with REPORT SUPPORTED OPERATION CODES blacklisted the ASM1051 chipset > still does not work when combined with some disks, e.g. a Crucial M500 ssd. > > When used with a troublesome disk, the chipset throws all kinds of USB errors, > and eventually h

Re: [RFC]Johan's patch for touchscreens and port power off

2014-09-09 Thread Alan Stern
On Tue, 9 Sep 2014, Oliver Neukum wrote: > Hi, > > Johan's patch means that for the affected touchscreen the port > can never be powered off. It seems to me that this needs a special > flag. What do you think? Why can't the port be powered off? Alan Stern -- To unsubscribe from this list: send

Re: OOPS: musb_hdrc

2014-09-09 Thread Felipe Balbi
On Tue, Sep 09, 2014 at 07:00:10PM +0400, Matwey V. Kornilov wrote: > 2014-09-09 18:45 GMT+04:00 Felipe Balbi : > > On Tue, Sep 09, 2014 at 01:28:55PM +0400, Matwey V. Kornilov wrote: > >> Hi George, > >> > >> Why dma_controller_create can not be set in struct musb_platform_ops? > >> Then each modu

Re: [PATCH v8 1/3] usb: gadget: f_fs: fix the redundant ep files problem

2014-09-09 Thread Felipe Balbi
On Tue, Sep 09, 2014 at 10:04:26AM -0500, Felipe Balbi wrote: > On Tue, Sep 09, 2014 at 08:23:15AM +0200, Robert Baldyga wrote: > > Up to now, when endpoint addresses in descriptors were non-consecutive, > > there were created redundant files, which could cause problems in kernel, > > when user tri

Re: [PATCH v8 1/3] usb: gadget: f_fs: fix the redundant ep files problem

2014-09-09 Thread Felipe Balbi
On Tue, Sep 09, 2014 at 08:23:15AM +0200, Robert Baldyga wrote: > Up to now, when endpoint addresses in descriptors were non-consecutive, > there were created redundant files, which could cause problems in kernel, > when user tried to read/write to them. It was result of fact that maximum > endpoin

use after free in hub_events

2014-09-09 Thread Joe Lawrence
Hello linux-usb, I'd like to report another USB bug that appeared during surprise hotplug device removal. With slub_debug=FZPU set, I would occasionally see the following writes to a poison pattern: = BUG kmalloc-2048 (T

[RFC]Johan's patch for touchscreens and port power off

2014-09-09 Thread Oliver Neukum
Hi, Johan's patch means that for the affected touchscreen the port can never be powered off. It seems to me that this needs a special flag. What do you think? Regards Oliver >From a4d154ead29c0c7d1e11d29d8202c33526e08558 Mon Sep 17 00:00:00 2001 From: Oliver Neukum Date:

Re: OOPS: musb_hdrc

2014-09-09 Thread Matwey V. Kornilov
2014-09-09 18:45 GMT+04:00 Felipe Balbi : > On Tue, Sep 09, 2014 at 01:28:55PM +0400, Matwey V. Kornilov wrote: >> Hi George, >> >> Why dma_controller_create can not be set in struct musb_platform_ops? >> Then each module would be able to set dma_controller_create it wants, >> and musb_init_control

[PATCH 2/2] uas: Disable uas on ASM1051 devices

2014-09-09 Thread Hans de Goede
Even with REPORT SUPPORTED OPERATION CODES blacklisted the ASM1051 chipset still does not work when combined with some disks, e.g. a Crucial M500 ssd. When used with a troublesome disk, the chipset throws all kinds of USB errors, and eventually hangs, where as in BOT mode it works fine. To make m

[PATCH 1/2] uas: Set no_report_opcodes

2014-09-09 Thread Hans de Goede
asm1051e usb <-> sata bridges hang when receiving a report opcodes scsi cmnd. Take a page out of the usb-storage book, and simple disable no_report_opcodes outright. Cc: sta...@vger.kernel.org # 3.16 Signed-off-by: Hans de Goede --- drivers/usb/storage/uas.c | 2 ++ 1 file changed, 2 insertions(

[PATCH fixes for 3.17 0/2] uas: Disable uas on ASM1051 devices

2014-09-09 Thread Hans de Goede
Hi Greg, I've received a number of bug-reports from users related to uas on ASM1051 chipset using devices. After some searching around I've managed to get myself an ASM1051 device. As a result I've spend the last 4 days trying to get the ASM1051 chipset to work. After some initial success which m

crash in recursively_mark_NOTATTACHED

2014-09-09 Thread Joe Lawrence
Hello linux-usb, I've been testing surprise device hotlug removal with RHEL7 on Stratus hardware (fully redundant PCI branches) and ran into a crashing NULL-ptr bug during device initialization. The code looks the same upstream, so I'm reporting it here. Trace 1 (khubd) === PID: 93

Re: Problem with commit usb: gadget: introduce gadget state tracking

2014-09-09 Thread Felipe Balbi
Hi, On Tue, Sep 09, 2014 at 03:20:58PM +0200, François MULLER wrote: > Hi all, > > I've backported some commits to my kernel (3.4) to get gadget state > tracking. > > I think that I missed something or there is a small error on this one that > hasn't been spotted: > > http://git.kernel.org/cgit

Re: usb: gadget: zero: Add support for interrupt EP

2014-09-09 Thread Felipe Balbi
On Tue, Sep 09, 2014 at 12:02:43PM +0300, Dan Carpenter wrote: > Hello Amit Virdi, > > The patch ef11982dd7a6: "usb: gadget: zero: Add support for interrupt > EP" from Aug 22, 2014, leads to the following static checker warning: > > drivers/usb/gadget/function/f_sourcesink.c:1498 > f_ss_op

randconfig build error with next-20140909, in drivers/usb/dwc2/platform.c

2014-09-09 Thread Jim Davis
Building with the attached random configuration file, drivers/usb/dwc2/platform.o: In function `dwc2_platform_driver_init': platform.c:(.init.text+0x0): multiple definition of `init_module' drivers/usb/dwc2/gadget.o:gadget.c:(.init.text+0x0): first defined here drivers/usb/dwc2/platform.o: In func

Re: OOPS: musb_hdrc

2014-09-09 Thread Felipe Balbi
On Tue, Sep 09, 2014 at 01:28:55PM +0400, Matwey V. Kornilov wrote: > Hi George, > > Why dma_controller_create can not be set in struct musb_platform_ops? > Then each module would be able to set dma_controller_create it wants, > and musb_init_controller would use musb->ops->dma_controller_create >

Re: [PATCH RESEND v7 2/2] usb: gadget: f_fs: virtual endpoint address mapping

2014-09-09 Thread Felipe Balbi
On Tue, Sep 09, 2014 at 08:02:16AM +0200, Robert Baldyga wrote: > On 09/08/2014 03:47 PM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Sep 08, 2014 at 09:57:00AM +0200, Robert Baldyga wrote: > >> This patch introduces virtual endpoint address mapping. It separates > >> function logic form physical

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-09 Thread Felipe Balbi
On Tue, Sep 09, 2014 at 07:19:50AM +0530, Vivek Gautam wrote: > Hi, > > > On Mon, Sep 8, 2014 at 7:14 PM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Sep 08, 2014 at 09:53:09AM +0530, Vivek Gautam wrote: > >> On Fri, Sep 5, 2014 at 11:26 PM, Felipe Balbi wrote: > >> > On Thu, Sep 04, 2014 at 12

Re: usb_acpi_set_power_state() and usb_queue_reset_device()

2014-09-09 Thread Alan Stern
On Tue, 9 Sep 2014, Oliver Neukum wrote: > On Mon, 2014-09-08 at 10:56 -0400, Alan Stern wrote: > > On Mon, 8 Sep 2014, Oliver Neukum wrote: > > > > > On Fri, 2014-09-05 at 10:15 -0400, Alan Stern wrote: > > > > > And even if there is a pending reset, all that will happen is the reset > > > > w

Re: [RFC PATCH 19/20] xhci: v1.0 scatterlist enqueue support (td-fragment rework)

2014-09-09 Thread Mathias Nyman
On 08/22/2014 08:16 PM, Dan Williams wrote: > v1.0 hosts require that TD-fragments (portions of a TD that do not end > on a MPB boundary) not cross a TRB segment boundary. This constraint is > in addition to the constraint that a TRB may not specify a transfer that > crosses a 64K boundary. This e

Re: [PATCH 0/5] Add reset API for usb_gadget_driver

2014-09-09 Thread Alan Stern
On Tue, 9 Sep 2014, Peter Chen wrote: > Hi Felipe & Alan, > > It is the first step for our discussion for adding reset, > vbus, activation handler for udc framework. This patchset > just adds .reset API at usb_gadget_driver, and the four > gadget drivers still call disconnect handler at .reset. >

Re: [patch] usb: gadget: f_fs: signedness bug in __ffs_func_bind_do_descs()

2014-09-09 Thread Dan Carpenter
On Tue, Sep 09, 2014 at 03:57:26PM +0200, Michal Nazarewicz wrote: > On Tue, Sep 09 2014, Dan Carpenter wrote: > > Btw, there is a sparse warning: > > > > drivers/usb/gadget/function/f_fs.c:401:44: warning: Variable length array > > is used. > > > > The risk here is that the array would be too la

Re: [PATCH v3 0/4] Allow xHCI drivers to be built as separate modules

2014-09-09 Thread Mathias Nyman
On 09/03/2014 10:51 PM, Andrew Bresticker wrote: > Mathias, > > On Tue, Aug 19, 2014 at 10:01 AM, Andrew Bresticker > wrote: >> It was suggested in the review of the Tegra xHCI driver [1] that we >> allow xHCI drivers to be built as individual modules (like EHCI) instead >> of building them all i

Re: [PATCH v8] usb:serial:pl2303: add GPIOs interface on PL2303

2014-09-09 Thread Johan Hovold
On Tue, Sep 09, 2014 at 12:43:56PM +0200, Johan Hovold wrote: > On Tue, Sep 09, 2014 at 06:21:31PM +0800, Wang YanQing wrote: > > On Tue, Sep 09, 2014 at 12:08:56PM +0200, Johan Hovold wrote: > > > On Fri, Sep 05, 2014 at 09:30:11AM +0800, Wang YanQing wrote: > > > > On Thu, Sep 04, 2014 at 06:44:3

Re: UAS errors with Jmicron

2014-09-09 Thread Hans de Goede
Hi, On 09/07/2014 04:36 PM, Laszlo T. wrote: > 2014-08-04 20:07 GMT+02:00 Hans de Goede : >> Hi Laszlo, >> >> On 08/03/2014 12:40 AM, Laszlo T. wrote: *) usb devices return different descriptors at different speeds >>> >>> All tests were on usb2. >>> I don't have usb3 ports bu

Re: [patch] usb: gadget: f_fs: signedness bug in __ffs_func_bind_do_descs()

2014-09-09 Thread Michal Nazarewicz
On Tue, Sep 09 2014, Dan Carpenter wrote: > We need "idx" to be signed for the error handling to work. > > Fixes: 6d5c1c77bbf9 ('usb: gadget: f_fs: fix the redundant ep files problem') > Signed-off-by: Dan Carpenter Acked-by: Michal Nazarewicz > --- > Btw, there is a sparse warning: > > drive

Problem with commit usb: gadget: introduce gadget state tracking

2014-09-09 Thread François MULLER
Hi all, I've backported some commits to my kernel (3.4) to get gadget state tracking. I think that I missed something or there is a small error on this one that hasn't been spotted: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=49401f4169c0e5a1b38f1a676d6f12eecaf

Re: [PATCH stable 3.12.y] usb: host: ohci-spear: fix ohci_dump parameters

2014-09-09 Thread Jiri Slaby
On 09/07/2014, 10:27 PM, Vincent Stehlé wrote: > Commit 6a04d05acfb51355 ("USB: OHCI: fix bugs in debug routines") has removed > the unused `verbose' argument of the debug function ohci_dump(); adapt > ohci-spear accordingly. > > This fixes the following compilation error: > > drivers/usb/host/

[patch] usb: gadget: f_fs: signedness bug in __ffs_func_bind_do_descs()

2014-09-09 Thread Dan Carpenter
We need "idx" to be signed for the error handling to work. Fixes: 6d5c1c77bbf9 ('usb: gadget: f_fs: fix the redundant ep files problem') Signed-off-by: Dan Carpenter --- Btw, there is a sparse warning: drivers/usb/gadget/function/f_fs.c:401:44: warning: Variable length array is used. The risk

Re: [PATCH v8] usb:serial:pl2303: add GPIOs interface on PL2303

2014-09-09 Thread Johan Hovold
On Tue, Sep 09, 2014 at 06:21:31PM +0800, Wang YanQing wrote: > On Tue, Sep 09, 2014 at 12:08:56PM +0200, Johan Hovold wrote: > > On Fri, Sep 05, 2014 at 09:30:11AM +0800, Wang YanQing wrote: > > > On Thu, Sep 04, 2014 at 06:44:31PM +0200, Benjamin Henrion wrote: > > > > On Thu, Sep 4, 2014 at 6:14

Re: [PATCH v3 3/3] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-09 Thread Octavian Purdila
On Tue, Sep 9, 2014 at 12:36 PM, Johan Hovold wrote: > On Fri, Sep 05, 2014 at 07:04:51PM +0300, Octavian Purdila wrote: >> On Fri, Sep 5, 2014 at 6:38 PM, Johan Hovold wrote: >> > On Fri, Sep 05, 2014 at 06:17:59PM +0300, Octavian Purdila wrote: > >> > In general, how well have these patches bee

Re: [PATCH 0/3] Add USBHS support to Lager

2014-09-09 Thread カオ ミン ヒェップ
On 09/09/2014 07:16 PM, カオ ミン ヒェップ wrote: Hello, Sorry for bother you! We are testing USB host 2.0 on Lager(R8a7790 SoC), We realize that there is only a master USB HOST configured on default config. Slave devices is not configured on default config. Could you please enable these CONFIGs? For

Re: [PATCH 0/3] Add USBHS support to Lager

2014-09-09 Thread カオ ミン ヒェップ
Hello, Sorry for bother you! We are testing USB host 2.0 on Lager(R8a7790 SoC), We realize that there is only a master USB HOST configured on default config. Slave devices is not configured on default config. Could you please enable these CONFIGs? For Hub: CONFIG_USB_EHCI_ROOT_HUB_TT=y For Usb

Re: usb_acpi_set_power_state() and usb_queue_reset_device()

2014-09-09 Thread Oliver Neukum
On Mon, 2014-09-08 at 10:56 -0400, Alan Stern wrote: > On Mon, 8 Sep 2014, Oliver Neukum wrote: > > > On Fri, 2014-09-05 at 10:15 -0400, Alan Stern wrote: > > > And even if there is a pending reset, all that will happen is the reset > > > will cause the port to power up again, and then the reset

Re: [PATCH v8] usb:serial:pl2303: add GPIOs interface on PL2303

2014-09-09 Thread Wang YanQing
On Tue, Sep 09, 2014 at 12:08:56PM +0200, Johan Hovold wrote: > On Fri, Sep 05, 2014 at 09:30:11AM +0800, Wang YanQing wrote: > > On Thu, Sep 04, 2014 at 06:44:31PM +0200, Benjamin Henrion wrote: > > > On Thu, Sep 4, 2014 at 6:14 PM, Benjamin Henrion wrote: > > > > I have subscribed to the lkml. >

Re: [PATCH v8] usb:serial:pl2303: add GPIOs interface on PL2303

2014-09-09 Thread Johan Hovold
On Fri, Sep 05, 2014 at 09:30:11AM +0800, Wang YanQing wrote: > On Thu, Sep 04, 2014 at 06:44:31PM +0200, Benjamin Henrion wrote: > > On Thu, Sep 4, 2014 at 6:14 PM, Benjamin Henrion wrote: > > > I have subscribed to the lkml. > > > > > > Can you make me a favour, send me your email as you posted

Re: [PATCH v3 3/3] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-09 Thread Johan Hovold
On Fri, Sep 05, 2014 at 07:04:51PM +0300, Octavian Purdila wrote: > On Fri, Sep 5, 2014 at 6:38 PM, Johan Hovold wrote: > > On Fri, Sep 05, 2014 at 06:17:59PM +0300, Octavian Purdila wrote: > > In general, how well have these patches been tested with disconnect > > events? At least gpiolib is kno

Re: OOPS: musb_hdrc

2014-09-09 Thread Matwey V. Kornilov
Hi George, Why dma_controller_create can not be set in struct musb_platform_ops? Then each module would be able to set dma_controller_create it wants, and musb_init_controller would use musb->ops->dma_controller_create instead of just dma_controller_create. 2014-09-09 13:15 GMT+04:00 Matwey V. K

[REGRESSION 3.17] scsi (uas) disks no longer using tagged command queuing

2014-09-09 Thread Hans de Goede
Hi All, While working on making error handling in the uas driver more robust, I noticed that all the commands being send to a sata ssd hooked up over uas were untagged, where I would expect tcq to be used, as that is the big advantage of uas over usb-storage / bot. Taking the uas.c file from 3.17

Re: OOPS: musb_hdrc

2014-09-09 Thread Matwey V. Kornilov
Hi George, Many thanks for the hint. Am I right that we can not have multiple MUSB DMA modes within the same kernel? It is a pity. 2014-09-09 12:40 GMT+04:00 George Cherian : > Hi Matwey, > > > On 09/09/2014 01:58 PM, Matwey V. Kornilov wrote: >> >> Hi, >> Can you add a few printks around d

re: usb: gadget: zero: Add support for interrupt EP

2014-09-09 Thread Dan Carpenter
Hello Amit Virdi, The patch ef11982dd7a6: "usb: gadget: zero: Add support for interrupt EP" from Aug 22, 2014, leads to the following static checker warning: drivers/usb/gadget/function/f_sourcesink.c:1498 f_ss_opts_int_interval_store() warn: impossible condition '(num > 4096) =>

[PATCH 3/6] usb: dwc2/gadget: break infinite loop in endpoint disable code

2014-09-09 Thread Robert Baldyga
From: Marek Szyprowski This patch fixes possible freeze caused by infinite loop in interrupt context. Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/ga

[PATCH 4/6] usb: dwc2/gadget: do not call disconnect method in pullup

2014-09-09 Thread Robert Baldyga
From: Marek Szyprowski This leads to potential spinlock recursion in composite framework, other udc drivers also don't call it directly from pullup method. Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 1 - 1 file changed, 1 deletion(-) diff --

  1   2   >