[PATCH] usb: gadget: function/f_hid: fix sparse warning

2015-02-04 Thread Lad Prabhakar
From: Lad, Prabhakar prabhakar.cse...@gmail.com this patch fixes following sparse warning: f_hid.c:572:30: warning: symbol 'f_hidg_fops' was not declared. Should it be static? Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- Found this issue on linux-next (gcc version 4.8.2,

Re: [PATCH v4 7/7] usb: serial: modify ioctl TIOCGSERIAL for F81232

2015-02-04 Thread Johan Hovold
On Fri, Jan 30, 2015 at 02:13:41PM +0800, Peter Hung wrote: Set correct product type from 16654 to 16550A and fix the ioctl TIOCGSERIAL return struct values. Signed-off-by: Peter Hung hpeter+linux_ker...@gmail.com --- drivers/usb/serial/f81232.c | 13 + 1 file changed, 9

Re: OOPS: musb_am335x: __device_attach

2015-02-04 Thread Matwey V. Kornilov
Hi, I was able to use some gdb to touch the issue: (gdb) monitor lsmod Module Size modstruct Used by musb_am335x 1431 0xbf0002781 (Loading) 0xbf00 [ ] (gdb) bt #0 0x73256020 in ?? () #1 0xc07a68f8 in driver_match_device (dev=optimized out,

[GIT PULL] USB changes for v3.20

2015-02-04 Thread Felipe Balbi
Hi Greg, Here's a big pull request for v3.20. All patches have been around for quite a while. I have tested everything on AM437x SK, AM437x IDK, AM335x BeagleBoneBlack and AM57x Beagleboard X15. Let me know if you want me to change anything. cheers The following changes since commit

Re: Control message failures kill entire XHCI stack

2015-02-04 Thread Mathias Nyman
On 27.01.2015 00:20, Alistair Grant wrote: I've come across what appears to be another xHCI issue - attempting to format a disk with gparted is causing a kernel Oops. This may not be related to the issue you're currently investigating, but wanted to pass it on in case it is (if it isn't let

Re: USB Gadgetfs

2015-02-04 Thread Alan Stern
On -1 xxx -1 ashwin.deshpa...@igate.com wrote: Hello Alern San, This is with reference to http://libusb.6.n5.nabble.com/How-to-send-receive-data-using-gadgetfs-bulk-endpoint-td5076584.html Questions like this should be sent to the linux-usb mailing list (CC'ed). I am trying to configure

[PATCH 1/2] usb: phy: load usb phy earlier

2015-02-04 Thread Zhangfei Gao
Since phy is definitely used usb controller, load the phy earlier rather than using defer probe to make boot time shorter. Signed-off-by: Zhangfei Gao zhangfei@linaro.org --- drivers/usb/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/Makefile

[PATCH 2/2] usb: dwc2: gadget reuse ahbcfg assigned from platform

2015-02-04 Thread Zhangfei Gao
Gadget directly set GAHBCFG_HBSTLEN_INCR4, reuse ahbcfg if assigned from platform Signed-off-by: Zhangfei Gao zhangfei@linaro.org --- drivers/usb/dwc2/core.c | 2 +- drivers/usb/dwc2/gadget.c | 8 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git

[PATCH 0/2] misc change

2015-02-04 Thread Zhangfei Gao
two misc changes, no function impact Zhangfei Gao (2): usb: phy: load usb phy earlier usb: dwc2: gadget reuse ahbcfg assigned from platform drivers/usb/Makefile | 2 +- drivers/usb/dwc2/core.c | 2 +- drivers/usb/dwc2/gadget.c | 8 ++-- 3 files changed, 8 insertions(+), 4

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-02-04 Thread Linus Walleij
On Wed, Jan 28, 2015 at 4:44 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Jan 28, 2015 at 01:40:59PM -0200, Fabio Estevam wrote: On Wed, Jan 28, 2015 at 12:04 PM, Felipe Balbi ba...@ti.com wrote: I don't want to change direction all the time, some controllers might not be glitch free, but I

RE: [PATCH 2/2] usb: dwc2: gadget reuse ahbcfg assigned from platform

2015-02-04 Thread Kaukab, Yousaf
-Original Message- From: Zhangfei Gao [mailto:zhangfei@linaro.org] Sent: Wednesday, February 4, 2015 9:01 AM To: Kaukab, Yousaf; ba...@ti.com; john.y...@synopsys.com Cc: linux-usb@vger.kernel.org; Zhangfei Gao Subject: [PATCH 2/2] usb: dwc2: gadget reuse ahbcfg assigned from

Re: [PATCH 3/5] fs: remove ki_nbytes

2015-02-04 Thread Al Viro
[USB folks Cc'd] On Mon, Feb 02, 2015 at 03:26:17PM +0100, Christoph Hellwig wrote: I would bet the behavior difference is a bug, might be worth to Cc the usb folks on this issue. I bet we'd want the more complex behavior for both variants. [Context for USB people: The difference in

Re: [PATCH 1/2] usb: phy: load usb phy earlier

2015-02-04 Thread zhangfei
On 02/04/2015 04:16 PM, Peter Chen wrote: On Wed, Feb 4, 2015 at 4:01 PM, Zhangfei Gao zhangfei@linaro.org wrote: Since phy is definitely used usb controller, load the phy earlier rather than using defer probe to make boot time shorter. Signed-off-by: Zhangfei Gao zhangfei@linaro.org

Re: intensive IO on usb-storage device causing system lock

2015-02-04 Thread Enrico Mioso
Hello guys! I was lucky! :) I was able to reproduce the crash in less time. So - a big blob of infos about my system: complete dmesg, lspci, lsusb, kernel config and so on is at http://www.gstorm.eu/info The trace is: http://cxg.de/_59153c.htm I wasn't able to get other infos, the system

Re: [PATCH v2 1/3] usb: XHCI: platform: Move the Marvell quirks after the enabling the clocks

2015-02-04 Thread Maxime Ripard
Hi Mathias, Greg, On Mon, Jan 19, 2015 at 02:01:12PM +0100, Maxime Ripard wrote: The commit 973747928514 (usb: host: xhci-plat: add support for the Armada 375/38x XHCI controllers) extended the xhci-plat driver to support the Armada 375/38x SoCs, mostly by adding a quirk configuring the MBUS

Re: [PATCH 1/2] usb: phy: load usb phy earlier

2015-02-04 Thread Peter Chen
On Wed, Feb 4, 2015 at 4:01 PM, Zhangfei Gao zhangfei@linaro.org wrote: Since phy is definitely used usb controller, load the phy earlier rather than using defer probe to make boot time shorter. Signed-off-by: Zhangfei Gao zhangfei@linaro.org --- drivers/usb/Makefile | 2 +- 1 file

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-04 Thread Pavel Machek
On Tue 2015-02-03 13:18:59, Felipe Balbi wrote: On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár wrote: On Tuesday 03 February 2015 16:43:45 Felipe Balbi wrote: Hi, On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Rohár wrote: On Tuesday 03 February 2015 00:15:19 Felipe Balbi

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-02-04 Thread Linus Walleij
On Wed, Jan 28, 2015 at 7:54 PM, Robert Jarzmik robert.jarz...@free.fr wrote: Felipe Balbi ba...@ti.com writes: nop-gpiod_reset = devm_gpiod_get_optional(dev, reset); if (gpiod_is_active_low(nop-gpiod_reset)) gpiod_direction_output(nop-gpiod_reset, GPIOD_OUT_LOW);

[PATCH] usb: gadget: function/f_uac2: fix sparse warnings

2015-02-04 Thread Lad Prabhakar
From: Lad, Prabhakar prabhakar.cse...@gmail.com this patch fixes following sparse warnings: f_uac2.c:57:12: warning: symbol 'uac2_name' was not declared. Should it be static? f_uac2.c:637:36: warning: symbol 'in_clk_src_desc' was not declared. Should it be static? f_uac2.c:649:36: warning:

[PATCH] usb: host/sl811-hcd: fix sparse warning

2015-02-04 Thread Lad Prabhakar
From: Lad, Prabhakar prabhakar.cse...@gmail.com this patch fixes following sparse warning: sl811-hcd.c:1804:24: warning: symbol 'sl811h_driver' was not declared. Should it be static? Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- drivers/usb/host/sl811-hcd.c | 2 +- 1 file

[PATCH] usb: gadget: function/f_sourcesink: fix sparse warning

2015-02-04 Thread Lad Prabhakar
From: Lad, Prabhakar prabhakar.cse...@gmail.com this patch fixes following sparse warnings: f_sourcesink.c:347:34: warning: symbol 'ss_int_source_comp_desc' was not declared. Should it be static? f_sourcesink.c:365:34: warning: symbol 'ss_int_sink_comp_desc' was not declared. Should it be

Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned

2015-02-04 Thread Tim Chen
On Mon, 2015-02-02 at 19:39 +0300, Sergei Shtylyov wrote: Hi, is this an open-coded version of PAGE_ALIGN? Yes, it appears so. :-) WBR, Sergei Thanks for the suggestion by Jiri. I updated the patch to use PAGE_ALIGN below. Regards, Tim ---8--- From: Tim Chen

Re: [PATCH 3/5] fs: remove ki_nbytes

2015-02-04 Thread Al Viro
On Wed, Feb 04, 2015 at 01:17:30PM -0500, Alan Stern wrote: On Wed, 4 Feb 2015, Al Viro wrote: [USB folks Cc'd] Incidentally, Al, have you seen this email? http://marc.info/?l=linux-usbm=142295011402339w=2 I encouraged the writer to send in a patch but so far there has been no

Re: [GIT PULL] USB changes for v3.20

2015-02-04 Thread Greg KH
On Wed, Feb 04, 2015 at 11:21:03AM -0600, Felipe Balbi wrote: Hi Greg, Here's a big pull request for v3.20. All patches have been around for quite a while. I have tested everything on AM437x SK, AM437x IDK, AM335x BeagleBoneBlack and AM57x Beagleboard X15. Let me know if you want me to

Re: [PATCH 3/5] fs: remove ki_nbytes

2015-02-04 Thread Alan Stern
On Wed, 4 Feb 2015, Al Viro wrote: [USB folks Cc'd] Incidentally, Al, have you seen this email? http://marc.info/?l=linux-usbm=142295011402339w=2 I encouraged the writer to send in a patch but so far there has been no reply. On Mon, Feb 02, 2015 at 03:26:17PM +0100, Christoph

Re: [PATCH v4] ehci-pci: disable for Intel MID platforms (update)

2015-02-04 Thread Sergei Shtylyov
Hello. On 02/04/2015 02:24 AM, Greg Kroah-Hartman wrote: This is a follow up to the previously submitted commit cefa9a31a5f0 (ehci-pci: disable for Intel MID platforms). It includes the following changes: - table and function are renamed to reflect this is not only about ChipIdea - ChipIdea

Re: [PATCH] net: usb: sr9700: Use 'SR_' prefix for the common register macros

2015-02-04 Thread David Miller
From: Chen Gang S gang.c...@sunrus.com.cn Date: Tue, 03 Feb 2015 05:00:40 +0800 The commone register macors (e.g. RSR) is too commont to drivers, it may be conflict with the architectures (e.g. xtensa, sh). The related warnings (with allmodconfig under xtensa): CC [M]

Re: Control message failures kill entire XHCI stack

2015-02-04 Thread Alistair Grant
Hi Mathias, On Wed, Feb 4, 2015 at 5:26 PM, Mathias Nyman mathias.ny...@linux.intel.com wrote: On 27.01.2015 00:20, Alistair Grant wrote: I've come across what appears to be another xHCI issue - attempting to format a disk with gparted is causing a kernel Oops. This may not be related to the

Re: [PATCH 3/5] fs: remove ki_nbytes

2015-02-04 Thread Alan Stern
On Wed, 4 Feb 2015, Al Viro wrote: On Wed, Feb 04, 2015 at 01:17:30PM -0500, Alan Stern wrote: On Wed, 4 Feb 2015, Al Viro wrote: [USB folks Cc'd] Incidentally, Al, have you seen this email? http://marc.info/?l=linux-usbm=142295011402339w=2 I encouraged the writer to

Re: [PATCH v4 6/7] usb: serial: implement MCR/MSR function for F81232

2015-02-04 Thread Johan Hovold
On Fri, Jan 30, 2015 at 02:13:40PM +0800, Peter Hung wrote: This patch implement relative MCR/MSR function, such like tiocmget()/tiocmset()/dtr_rts(). The update_mctrl() replace set_control_lines() to do MCR control so we clean-up the set_control_lines() function. Signed-off-by: Peter

Re: [PATCH 3/5] fs: remove ki_nbytes

2015-02-04 Thread Al Viro
On Wed, Feb 04, 2015 at 03:30:32PM -0500, Alan Stern wrote: * this one. Note that you are not guaranteed that ep_config() won't be called more than once - two threads might race in write(2), with the loser getting through mutex_lock_interruptible(data-lock); in ep_config() only

Re: [PATCH 2/2] usb: dwc2: gadget reuse ahbcfg assigned from platform

2015-02-04 Thread Zhangfei Gao
Hi Yousaf On 4 February 2015 at 17:41, Kaukab, Yousaf yousaf.kau...@intel.com wrote: diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c index d5197d4..8d388cc 100644 --- a/drivers/usb/dwc2/core.c +++ b/drivers/usb/dwc2/core.c @@ -2563,7 +2563,7 @@ void

RE: USB Gadgetfs

2015-02-04 Thread Ashwin A Deshpande
Hello Alern San, Thank you so much for your reply, I will make sure that I forward these questions to linux-usb mailing list (CC'ed). I successfully cross complied usb.c on my Ubuntu machine, also I changed my controller to the SabreSD specific (ci_hdrc_imx), after executing it on target, it

Re: [PATCH 2/2] usb: dwc2: gadget reuse ahbcfg assigned from platform

2015-02-04 Thread Zhangfei Gao
On 4 February 2015 at 21:51, Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 15aa578..20085de 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -2314,9 +2314,13 @@ void

RE: [PATCH v4] ehci-pci: disable for Intel MID platforms (update)

2015-02-04 Thread Peter Chen
On Wed, 2015-02-04 at 08:04 +0800, Peter Chen wrote: On Tue, Feb 03, 2015 at 06:08:39PM +0200, Andy Shevchenko wrote: + * + * Note: ehci-pci driver may try to probe the device first. You + have to add an + * ID to the bypass_pci_id_table in ehci-pci driver to prevent this.

[possible fix] HL-340 USB don't work correctly (ch340 based usb-rs232 adapter)

2015-02-04 Thread Eddi De Pieri
Hi list, I've got recently following device. Bus 003 Device 014: ID 1a86:7523 QinHeng Electronics HL-340 USB-Serial adapter ch431 kernel driver don't work correctly with this device, when URB_FUNCTION_BULK_OR_INTERRUPT_TRANSFER answer/send wrong character After some experiment by passing

Re: [PATCH v4 1/7] usb: serial: modify bulk-in/out size for F81232

2015-02-04 Thread Johan Hovold
On Fri, Jan 30, 2015 at 02:13:35PM +0800, Peter Hung wrote: The F81232 real bulk-in/out ep buffer size is 64Bytes Signed-off-by: Peter Hung hpeter+linux_ker...@gmail.com --- drivers/usb/serial/f81232.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v4 3/7] usb: serial: implement read IIR/MSR ep for F81232

2015-02-04 Thread Johan Hovold
On Fri, Jan 30, 2015 at 02:13:37PM +0800, Peter Hung wrote: The F81232 interrupt ep will continuously report IIR register value. We had implement the interrupt callback to read IIR, If noticed with MSR change, we will call worker to read MSR later. Signed-off-by: Peter Hung

Re: [PATCH v4 2/7] usb: serial: modify author for F81232

2015-02-04 Thread Johan Hovold
On Fri, Jan 30, 2015 at 02:13:36PM +0800, Peter Hung wrote: add co-author and fix no '' in greg kh's email This is trivial enough to be done in one patch I guess, but please put this one last in the series. Also for all your patches use a subject on the following format: USB: f81232:

Re: [PATCH v2 1/3] usb: XHCI: platform: Move the Marvell quirks after the enabling the clocks

2015-02-04 Thread Greg Kroah-Hartman
On Wed, Feb 04, 2015 at 10:35:22AM +0100, Maxime Ripard wrote: Hi Mathias, Greg, On Mon, Jan 19, 2015 at 02:01:12PM +0100, Maxime Ripard wrote: The commit 973747928514 (usb: host: xhci-plat: add support for the Armada 375/38x XHCI controllers) extended the xhci-plat driver to support the

Re: [PATCH v2] usb: gadget: OS desc type unicode multi

2015-02-04 Thread Andrzej Pietrasiewicz
Hi Mario, sorry about the delay but I was busy with other things yesterday. W dniu 02.02.2015 o 21:37, Mario Schuknecht pisze: Hi Andrzej, thank you for the comment. snip I'm not sure I understand the logic of the below function well. +static inline int

Re: intensive IO on usb-storage device causing system lock

2015-02-04 Thread Enrico Mioso
Another note - I noticed the load average doesn't go down 2.02; and top doesn't evidence any particularly CPU-hungry or memory-hungry process. However, dmesg and mpd processes are still stuck, the rest of the system runs normally apparently. The USB disk spinned down, like thhere is no process

Re: intensive IO on usb-storage device causing system lock

2015-02-04 Thread Enrico Mioso
The situation is unchanged, but I noticed there is a continous process of creating workers. They might die at some point, but I noticed them now. Sorry for the verbosity. Here's the last trace: http://cxg.de/_dedb43.htm And process list: PID TTY STAT TIME COMMAND 1 ?Ss

Re: [PATCH v4] ehci-pci: disable for Intel MID platforms (update)

2015-02-04 Thread Andy Shevchenko
On Wed, 2015-02-04 at 08:04 +0800, Peter Chen wrote: On Tue, Feb 03, 2015 at 06:08:39PM +0200, Andy Shevchenko wrote: + * + * Note: ehci-pci driver may try to probe the device first. You have to add an + * ID to the bypass_pci_id_table in ehci-pci driver to prevent this. */ This

Re: [PATCH v4 4/7] usb: serial: reimplement RX bulk-in ep for F81232

2015-02-04 Thread Johan Hovold
On Fri, Jan 30, 2015 at 02:13:38PM +0800, Peter Hung wrote: The F81232 bulk-in is RX data channel. Data format is [LSR+Data][LSR+Data]. , We had reimplemented in this patch. Signed-off-by: Peter Hung hpeter+linux_ker...@gmail.com --- drivers/usb/serial/f81232.c | 47

Re: intensive IO on usb-storage device causing system lock

2015-02-04 Thread Enrico Mioso
Hello guys. This time I am managing to use the system while in the middle of the problem. From the command: ps aux USER PID %CPU %MEMVSZ RSS TTY STAT START TIME COMMAND root 1 0.0 0.5 22852 2600 ?Ss 09:24 0:01 /sbin/init auto root 2 0.0 0.0

[PATCH] hso: Use static attribute groups for sysfs entry

2015-02-04 Thread Takashi Iwai
Pass the static attribute groups and the driver data via tty_port_register_device_attr() instead of manual device_create_file() and device_remove_file() calls. Signed-off-by: Takashi Iwai ti...@suse.de --- drivers/net/usb/hso.c | 17 ++--- 1 file changed, 10 insertions(+), 7

Re: [PATCH 2/2] usb: dwc2: gadget reuse ahbcfg assigned from platform

2015-02-04 Thread Sergei Shtylyov
Hello. On 02/04/2015 11:01 AM, Zhangfei Gao wrote: Gadget directly set GAHBCFG_HBSTLEN_INCR4, reuse ahbcfg if assigned from platform Signed-off-by: Zhangfei Gao zhangfei@linaro.org [...] diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 15aa578..20085de

Re: intensive IO on usb-storage device causing system lock

2015-02-04 Thread Enrico Mioso
Sorry guys - I was wrong: the process appears in the traces. And if I read the call trace correctly is's stuck in apic_write ? Enrico On Tue, 3 Feb 2015, Alan Stern wrote: Date: Tue, 3 Feb 2015 19:02:48 From: Alan Stern st...@rowland.harvard.edu To: Enrico Mioso mrkiko...@gmail.com Cc:

Re: f_hid, f_mass_storage, and f_rdnis via configfs on platform/intel-mid

2015-02-04 Thread Chris McClimans
Hi Andrzej, Thank you for your time. I'd like to take a stab at FunctionFS before I start looking at backporting hid and uvc from 3.19+ I found a lot of information (mainly from you [1] [2]) on gadget ConfigFS and hid, but I'm having less luck finding information on FunctionFS and the required

Re: [PATCH v4 5/7] usb: serial: implement set_termios for F81232

2015-02-04 Thread Johan Hovold
On Fri, Jan 30, 2015 at 02:13:39PM +0800, Peter Hung wrote: The original driver had do not any h/w change in driver. This patch implements with configure H/W for baud/parity/word length/stop bits functional. Signed-off-by: Peter Hung hpeter+linux_ker...@gmail.com ---