Hi,
On 04/29/2016 01:15 AM, Mark Brown wrote:
> On Thu, Apr 28, 2016 at 01:55:35PM +0800, Lu Baolu wrote:
>
>> How about below code?
>> + gpiod = gpiod_get(dev, "vbus_en", GPIOD_ASIS);
>> + if (IS_ERR(gpiod))
>> + return PTR_ERR(gpiod);
>> +
>> + config->gpio =
On 2016-04-15 23:14, Grigori Goronzy wrote:
Hi,
here's a hopefully final v4 of my ch341 patchset. Changelog below
this time, because it's cleary better this way. Please review.
Ping?
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to
On 4/28/2016 1:01 AM, Felipe Balbi wrote:
> NumP field of DCFG register is used on NumP field of
> ACK TP header and it tells the host how many packets
> an endpoint can receive before waiting for
> synchronization.
>
> Documentation says it should be set to anything
> <=bMaxBurst. Interestingly,
W dniu 28.04.2016 o 22:36, Greg KH pisze:
> On Thu, Apr 28, 2016 at 10:08:13PM +0200, Igor Kotrasinski wrote:
>> This follow-on patchset makes the dev_desc attribute binary, as it
>> should have been. Resent without duplicate patches in the previous
>> patchset.
>>
>> Igor Kotrasinski (1):
>>
On Thu, Apr 28, 2016 at 10:08:13PM +0200, Igor Kotrasinski wrote:
> This follow-on patchset makes the dev_desc attribute binary, as it
> should have been. Resent without duplicate patches in the previous
> patchset.
>
> Igor Kotrasinski (1):
> usbip: vudc: make dev_desc attribute binary
>
>
This follow-on patchset makes the dev_desc attribute binary, as it
should have been. Resent without duplicate patches in the previous
patchset.
Igor Kotrasinski (1):
usbip: vudc: make dev_desc attribute binary
drivers/usb/usbip/vudc_sysfs.c | 20 ++--
1 file changed, 14
On Fri, Apr 15, 2016 at 12:12:26PM -0400, Alan Stern wrote:
> The debugging facilities in ehci-dbg.c follow an uneven pattern. Some
> of them are protected by "#ifdef CONFIG_DYNAMIC_DEBUG" and some
> aren't, presumably in the hope of having some of the debugging output
> available in any
On Tue, Mar 22, 2016 at 04:31:03PM +0900, Nobuo Iwata wrote:
> Adding names database to port command.
>
> BEFORE) 'unknown' for vendor and product string.
>
> Imported USB devices
>
> Port 00: at Low Speed(1.5Mbps)
>unknown vendor : unknown product (03f0:0224)
>
On Thu, Apr 21, 2016 at 03:43:40PM +0300, Heikki Krogerus wrote:
> USB Type-C Connector System Software Interface (UCSI) is
> specification that defines the registers and data structures
> that can be used to control USB Type-C ports on a system.
> UCSI is used on several Intel Broxton SoC based
On 4/27/2016 11:48 PM, Felipe Balbi wrote:
>
> Hi,
>
> (we don't top-post on this forum ;-)
>
> "Du, Changbin" writes:
>> Hi, Balbi,
>>
>> The step to reproduce this issue is:
>> 1) connect device to a host and wait its enumeration.
>> 2) trigger software disconnect by
On Thu, Apr 28, 2016 at 08:44:14PM +0200, Igor Kotrasinski wrote:
> We read a struct usb_device_descriptor from it, so make it an actual
> binary attribute.
>
> Signed-off-by: Igor Kotrasinski
> ---
> drivers/usb/usbip/vudc_sysfs.c | 20 ++--
> 1 file
On Thu, Apr 28, 2016 at 09:01:01PM +0200, Krzysztof Opasiak wrote:
> Duplicated. Already fixed yesterday:
>
> http://marc.info/?l=linux-usb=146178014931956=2
I just applied this one.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a
On Thu, Apr 28, 2016 at 12:28:01PM -0700, Greg KH wrote:
> On Thu, Apr 28, 2016 at 08:44:12PM +0200, Igor Kotrasinski wrote:
> > These are follow-on patches to the series of patches adding the usbip-vudc
> > driver. They fix a namespace pollution issue, change one of the sysfs
> > attributes to
W dniu 28.04.2016 o 21:28, Greg KH pisze:
> On Thu, Apr 28, 2016 at 08:44:12PM +0200, Igor Kotrasinski wrote:
>> These are follow-on patches to the series of patches adding the usbip-vudc
>> driver. They fix a namespace pollution issue, change one of the sysfs
>> attributes to binary type and
W dniu 28.04.2016 o 20:44, Igor Kotrasinski pisze:
> These are follow-on patches to the series of patches adding the usbip-vudc
> driver. They fix a namespace pollution issue, change one of the sysfs
> attributes to binary type and provide documentation for attributes.
>
> Igor Kotrasinski (3):
>
On Thu, Apr 28, 2016 at 08:44:12PM +0200, Igor Kotrasinski wrote:
> These are follow-on patches to the series of patches adding the usbip-vudc
> driver. They fix a namespace pollution issue, change one of the sysfs
> attributes to binary type and provide documentation for attributes.
>
> Igor
Hello Igor Kotrasinski,
The patch 80fd9cd52de6: "usbip: vudc: Add VUDC main file" from Mar 8,
2016, leads to the following static checker warning:
drivers/usb/usbip/vudc_main.c:88 init()
warn: perhaps platform_device_put() was intended here?
drivers/usb/usbip/vudc_main.c
56
Duplicated. Already fixed yesterday:
http://marc.info/?l=linux-usb=146178014931956=2
Best regards,
Krzysztof Opasiak
On Thu, Apr 28, 2016 at 8:44 PM, Igor Kotrasinski wrote:
> Avoid namespace pollution.
>
> Signed-off-by: Igor Kotrasinski
> ---
We read a struct usb_device_descriptor from it, so make it an actual
binary attribute.
Signed-off-by: Igor Kotrasinski
---
drivers/usb/usbip/vudc_sysfs.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git
Avoid namespace pollution.
Signed-off-by: Igor Kotrasinski
---
drivers/usb/usbip/vudc.h | 2 +-
drivers/usb/usbip/vudc_dev.c | 2 +-
drivers/usb/usbip/vudc_rx.c | 2 +-
drivers/usb/usbip/vudc_transfer.c | 6 +++---
4 files changed, 6 insertions(+), 6
These are follow-on patches to the series of patches adding the usbip-vudc
driver. They fix a namespace pollution issue, change one of the sysfs
attributes to binary type and provide documentation for attributes.
Igor Kotrasinski (3):
usbip: vudc: rename find_endpoint to vep_find_endpoint
* Sergei Shtylyov [160428 10:55]:
> Hello.
>
> On 04/28/2016 08:33 PM, Tony Lindgren wrote:
>
> >We may have drivers loaded but no configured gadgets
> >and MUSB may be in host mode. If gadgets are configured
> >during host mode, PM runtime will get confused.
Propagate error from eprom_read and change the return type of
rtl8192_read_eeprom_info from void to int.
Signed-off-by: Salah Triki
---
drivers/staging/rtl8192u/r8192U_core.c | 37 +-
1 file changed, 19 insertions(+), 18 deletions(-)
diff
The call of rtl8192_read_eeprom_info may fail, therefore its return value must
be checked and propagated in the case of error.
Signed-off-by: Salah Triki
---
drivers/staging/rtl8192u/r8192U_core.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
Propagate errors from kzalloc and usb_control_msg and change the
return type of write_nic_byte_E from void to int.
Signed-off-by: Salah Triki
---
drivers/staging/rtl8192u/r8192U.h | 2 +-
drivers/staging/rtl8192u/r8192U_core.c | 9 ++---
2 files changed, 7
Propagate errors from kzalloc and usb_control_msg and change the
return type of write_nic_byte from void to int.
Signed-off-by: Salah Triki
---
drivers/staging/rtl8192u/r8192U.h | 2 +-
drivers/staging/rtl8192u/r8192U_core.c | 12 +++-
2 files changed, 8
The call of eprom_read may fail, therefore its return value must be
checked.
Signed-off-by: Salah Triki
---
drivers/staging/rtl8192u/r8192U_core.c | 147 +++--
1 file changed, 104 insertions(+), 43 deletions(-)
diff --git
Propagate errors from kzalloc and usb_control_msg and change the
return type of write_nic_word from void to int.
Signed-off-by: Salah Triki
---
drivers/staging/rtl8192u/r8192U.h | 2 +-
drivers/staging/rtl8192u/r8192U_core.c | 9 ++---
2 files changed, 7
These patchs check the return value/propagate error of the functions
read_nic_word_E, eprom_r, eprom_read, rtl8192_read_eeprom_info, write_nic_*.
Salah Triki (8):
staging: rtl8192u: check return value of read_nic_word_E
staging: rtl8192u: check return value eprom_read
staging: rtl8192u:
Propagate errors from kzalloc and usb_control_msg and change the
return type of write_nic_dword from void to int.
Signed-off-by: Salah Triki
---
drivers/staging/rtl8192u/r8192U.h | 2 +-
drivers/staging/rtl8192u/r8192U_core.c | 9 ++---
2 files changed, 7
The call of read_nic_word_E may fail, therefore its return value must be
checked and propagated in the case of error.
Signed-off-by: Salah Triki
---
drivers/staging/rtl8192u/r8180_93cx6.c | 30 --
drivers/staging/rtl8192u/r8180_93cx6.h | 2 +-
2
Hello.
On 04/28/2016 08:33 PM, Tony Lindgren wrote:
We may have drivers loaded but no configured gadgets
and MUSB may be in host mode. If gadgets are configured
during host mode, PM runtime will get confused.
Disconnect PM runtime from gadget state, and do it only
based on the cable.
Looks like at least 2430 glue won't idle reliably with the 200 ms
autosuspend delay. This causes deeper idle states being blocked for
the whole SoC when disconnecting OTG A cable.
Increasing the delay to 500 ms seems to idle both MUSB and the PHY
reliably. This is probably because of time needed
This is no longer needed with PM runtime at least for 2430 glue.
We can now rely only on PM runtime and cable detection.
The other glue layers can probably remove try_idle too, but that
needs to be tested for each platform before doing it.
Signed-off-by: Tony Lindgren
---
Let's make the PM runtime use the standard autosuspend calls.
Commit 5de85b9d57ab ("PM / runtime: Re-init runtime PM states at probe
error and driver unbind") means we must pair use_autosuspend with
dont_use_autosuspend and then use put_sync to properly idle the
device.
Note that we'll be
We have MUSB setting pm_runtime_irq_safe with the following
commits:
30a70b026b4c ("usb: musb: fix obex in g_nokia.ko causing kernel panic")
3e43a0725637 ("usb: musb: core: add pm_runtime_irq_safe()")
Let's fix things to use delayed work so we can remove the
pm_runtime_irq_safe.
Note that we
Hi all,
Here's a series of fixes to get MUSB PM runtime working again.
I can now test PM runtime with the 2430 glue layer with this set,
so adding PM runtime support for other glue layers should be
possible.
Regards,
Tony
Tony Lindgren (10):
usb: phy: Fix initial state for twl6030
usb:
We may have drivers loaded but no configured gadgets
and MUSB may be in host mode. If gadgets are configured
during host mode, PM runtime will get confused.
Disconnect PM runtime from gadget state, and do it only
based on the cable.
Signed-off-by: Tony Lindgren
---
Let's not tinker with the PM runtime of musb core from the omap2430
wrapper. This allows us to initialize PM runtime for musb core later
on instead of doing it in stages. And omap2430 wrapper has no need
to for accessing musb core at this point.
Note that this does not remove all the PM runtime
We need to check the state for the PHY with delayed_work so
as otherwise MUSB will get confused and idles immediately.
Signed-off-by: Tony Lindgren
---
drivers/usb/phy/phy-twl6030-usb.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git
We have remove() already calling shutdown(), so let's drop it
and move the code to remove().
Signed-off-by: Tony Lindgren
---
drivers/usb/musb/musb_core.c | 39 ++-
1 file changed, 14 insertions(+), 25 deletions(-)
diff --git
This simplifies things and allows idling both MUSB and PHY
when nothing is configured.
Let's also warn if PHY is not configured.
Signed-off-by: Tony Lindgren
---
drivers/usb/musb/omap2430.c | 35 +--
1 file changed, 21 insertions(+), 14
With the pull up being handled with delayed work, we can
now finally remove pm_runtime_set_irq_safe that blocks the
MUSB glue from idling.
Signed-off-by: Tony Lindgren
---
drivers/usb/musb/musb_core.c | 6 --
1 file changed, 6 deletions(-)
diff --git
On Thu, Apr 28, 2016 at 01:55:35PM +0800, Lu Baolu wrote:
> How about below code?
> + gpiod = gpiod_get(dev, "vbus_en", GPIOD_ASIS);
> + if (IS_ERR(gpiod))
> + return PTR_ERR(gpiod);
> +
> + config->gpio = desc_to_gpio(gpiod);
> + config->enable_high =
On Thu, Apr 28, 2016 at 06:20:29PM +0200, Igor Kotrasiński wrote:
> W dniu 27.04.2016 o 00:19, Greg KH pisze:
> > On Tue, Mar 08, 2016 at 09:49:03PM +0100, Krzysztof Opasiak wrote:
> >> From: Igor Kotrasinski
> >>
> >> Add sysfs attributes to allow controlling vudc from
On Thu, Apr 28, 2016 at 01:46:03PM +0300, Felipe Balbi wrote:
>
> Hi Greg,
>
> here's the gadget pull request for v4.7 merge window. It's mostly dwc3
> this time:
>
> $ git diff --dirstat v4.6-rc3
> 74.4% drivers/usb/dwc3/
> 13.9% drivers/usb/gadget/udc/
>5.2% drivers/usb/gadget/
>
W dniu 27.04.2016 o 00:19, Greg KH pisze:
> On Tue, Mar 08, 2016 at 09:49:03PM +0100, Krzysztof Opasiak wrote:
>> From: Igor Kotrasinski
>>
>> Add sysfs attributes to allow controlling vudc from usbip tools.
>>
>> dev_desc - device descriptor of current gadget. This is
Hi,
On Thu, Apr 28, 2016 at 09:51:37AM +0300, Maxim Uvarov wrote:
[snip]
> Hello Bin,
>
> yes, it also works with that reset and go to finish:
>
> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
> index c3d5fc9..8cd98e7 100644
> --- a/drivers/usb/musb/musb_host.c
>
Hi,
Arnd Bergmann writes:
> On Thursday 28 April 2016 15:16:12 Russell King - ARM Linux wrote:
>> On Thu, Apr 28, 2016 at 09:37:08AM +0300, Felipe Balbi wrote:
>> >
>> > Hi,
>> >
>> > Arnd Bergmann writes:
>> > >pointer and pass that in platform_data. This
On Thursday 28 April 2016 15:16:12 Russell King - ARM Linux wrote:
> On Thu, Apr 28, 2016 at 09:37:08AM +0300, Felipe Balbi wrote:
> >
> > Hi,
> >
> > Arnd Bergmann writes:
> > >pointer and pass that in platform_data. This is really easy, it's
> >
> > Sorry but passing a
On Thu, Apr 28, 2016 at 09:37:08AM +0300, Felipe Balbi wrote:
>
> Hi,
>
> Arnd Bergmann writes:
> >pointer and pass that in platform_data. This is really easy, it's
>
> Sorry but passing a struct device pointer in platform_data is
> ridiculous. Not to mention that, as I said
With the addition of VUDC, the USBIP stack can now be used on
configurations without USB host support, but trying to build
it with USB gadget support disabled fails with
drivers/usb/built-in.o: In function `vep_dequeue':
vudc_main.c:(.text+0xa6ddc): undefined reference to
On 28/04/16 13:23, Jun Li wrote:
> Hi
>
>> -Original Message-
>> From: Roger Quadros [mailto:rog...@ti.com]
>> Sent: Thursday, April 28, 2016 5:55 PM
>> To: Jun Li ; st...@rowland.harvard.edu; ba...@kernel.org;
>> gre...@linuxfoundation.org; peter.c...@freescale.com
>>
Hi,
Jim Lin writes:
> On 2016年04月25日 20:01, Felipe Balbi wrote:
Is this happening on set_config() ? If that's the case, why is
gadget->speed set to USB_SPEED_SUPER to start with ? Your controller
should already have negotiated highspeed which means
> From: Dinh Nguyen
>
> Allow for platforms that have a reset controller driver in place to bring
> the USB IP out of reset.
>
> Signed-off-by: Dinh Nguyen
Successful tested with Raspberry Pi B (without reset controller)
On 2016年04月26日 16:49, Jim Lin wrote:
On 2016年04月25日 20:01, Felipe Balbi wrote:
* PGP Signed by an unknown key
Is this happening on set_config() ? If that's the case, why is
gadget->speed set to USB_SPEED_SUPER to start with ? Your controller
should already have negotiated highspeed which
On Wed, Apr 27, 2016 at 08:06:32PM +, Konstantin Shkolnyy wrote:
> > -Original Message-
> > From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold
> > Sent: Tuesday, April 26, 2016 02:26
> > To: Konstantin Shkolnyy
> > Cc: Johan Hovold; Konstantin Shkolnyy;
Hi Greg,
here's the gadget pull request for v4.7 merge window. It's mostly dwc3
this time:
$ git diff --dirstat v4.6-rc3
74.4% drivers/usb/dwc3/
13.9% drivers/usb/gadget/udc/
5.2% drivers/usb/gadget/
3.6% drivers/usb/renesas_usbhs/
Patches have been tested on Intel platforms and have
Hi
> -Original Message-
> From: Roger Quadros [mailto:rog...@ti.com]
> Sent: Thursday, April 28, 2016 5:55 PM
> To: Jun Li ; st...@rowland.harvard.edu; ba...@kernel.org;
> gre...@linuxfoundation.org; peter.c...@freescale.com
> Cc: dan.j.willi...@intel.com;
Hi,
anyone has ever seen this?
[ 2477.001127] kmemleak: 8 new suspected memory leaks (see
/sys/kernel/debug/kmemleak)
[ 6249.251894] perf: interrupt took too long (2506 > 2500), lowering
kernel.perf_event_max_sample_rate to 79800
[ 9951.944091] perf: interrupt took too long (3136 > 3132),
Fix NULL pointer dereference and obsolete comments forgotten when
usbip server was converted from an interface driver to a device driver.
Signed-off-by: Alexander Popov
---
drivers/usb/usbip/stub.h | 1 -
drivers/usb/usbip/stub_dev.c | 4 ++--
Hi,
On 27/04/16 14:22, Roger Quadros wrote:
> On 26/04/16 03:07, Jun Li wrote:
>> Hi
>>
>>> -Original Message-
>>> From: Roger Quadros [mailto:rog...@ti.com]
>>> Sent: Monday, April 25, 2016 10:04 PM
>>> To: Jun Li ; st...@rowland.harvard.edu; ba...@kernel.org;
>>>
Mathias,
On 22/04/16 21:00, Gabriel Krisman Bertazi wrote:
> Mathias Nyman writes:
>
>> Nice catch, and moving xhci_mem_cleanup() until second hcd (primary) is
>> removed is one way to solve it.
>
> Thank you and Roger for your suggestions!
>
>> But I don't think we
Hi Joe,
On 27/04/16 23:41, Joe Lawrence wrote:
> Hello Mathias, Roger, Gabriel
>
> I've been chasing strange MSI / legacy IRQ behavior from xHCI for a
> couple days and wanted to report a few things that may be effected by
> Gabriel's recent "xhci: Cleanup only when releasing primary hcd" patch
On 28/04/16 04:54, Peter Chen wrote:
> On Wed, Apr 27, 2016 at 01:59:44PM +0300, Roger Quadros wrote:
>> Hi,
>>
>> On 27/04/16 06:15, Peter Chen wrote:
>>> On Tue, Apr 26, 2016 at 04:21:07PM +0800, Peter Chen wrote:
On Tue, Apr 26, 2016 at 07:00:22AM +, Jun Li wrote:
> Hi
>
>>
Now that we calculate DCFG.NUMP, we can disable
dwc3's automatic calculation so we maximize our
chances of very high throughtput through the use of
bursts.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/core.h | 5 +
drivers/usb/dwc3/gadget.c | 11
NumP field of DCFG register is used on NumP field of
ACK TP header and it tells the host how many packets
an endpoint can receive before waiting for
synchronization.
Documentation says it should be set to anything
<=bMaxBurst. Interestingly, however, this setting is
not per-endpoint how it should
2016-04-28 0:28 GMT+03:00 Bin Liu :
> Hi,
>
> On Wed, Apr 27, 2016 at 02:13:56PM -0500, Bin Liu wrote:
>> Hi,
>>
>> On Wed, Apr 27, 2016 at 09:26:10PM +0300, Maxim Uvarov wrote:
>> > 2016-04-27 18:46 GMT+03:00 Bin Liu :
>> > > Hi,
>> > >
>> > > On Wed, Apr 27, 2016 at
Hi,
(we don't top-post on this forum ;-)
"Du, Changbin" writes:
> Hi, Balbi,
>
> The step to reproduce this issue is:
> 1) connect device to a host and wait its enumeration.
> 2) trigger software disconnect by calling function
> usb_gadget_disconnect(), which finally
Hi,
Arnd Bergmann writes:
> On Wednesday 27 April 2016 23:05:42 Felipe Balbi wrote:
>> Arnd Bergmann writes:
>> > On Wednesday 27 April 2016 13:59:13 Alan Stern wrote:
>> >> On Wed, 27 Apr 2016, Arnd Bergmann wrote:
>> >>
>> >> > I've looked at the usb HCD code
70 matches
Mail list logo