Re: [PATCH] USB: update intro of documentation

2016-10-21 Thread Oliver Neukum
On Fri, 2016-10-21 at 15:17 -0600, Jonathan Corbet wrote: > On Thu, 20 Oct 2016 15:15:00 +0200 > Oliver Neukum wrote: > > > It does no good to mention The 2.4 kernel series and neglect > > USB 3.x and XHCI. Also with type C and micro/mini USB we better > > not talk about the

RE: [PATCH V2]usb: dwc2: Clear GUSBCFG.UsbTrdTim before setting

2016-10-21 Thread Lipengcheng
> -Original Message- > From: Felipe Balbi [mailto:felipe.ba...@linux.intel.com] > Sent: Monday, October 17, 2016 5:37 PM > To: Lipengcheng; johny...@synopsys.com > Cc: gre...@linuxfoundation.org; linux-usb@vger.kernel.org; > linux-ker...@vger.kernel.org; Xuejiancheng; Lidongpo;

Re: [RFC][PATCH 2/2] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220

2016-10-21 Thread Chen Yu
On 2016/10/22 4:00, John Youn wrote: > On 10/20/2016 5:43 PM, Chen Yu wrote: >> On 2016/10/19 6:21, John Youn wrote: >>> On 10/16/2016 7:42 PM, Chen Yu wrote: On 2016/10/15 3:37, John Youn wrote: > On 10/13/2016 4:36 PM, John Stultz wrote: >> From: Chen Yu

[PATCH v2 RESEND] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers

2016-10-21 Thread Babu Moger
Never seen XHCI auto handoff working on TI and RENESAS cards. Eventually, we force handoff. This code forces the handoff unconditionally. It saves 5 seconds boot time for each card. Signed-off-by: Babu Moger --- v2: Made changes per comments from Greg KH. Extra space

link state problem with dwc3 in supper-speed device mode

2016-10-21 Thread Bin Liu
Hi, I run into a link state problem when dwc3 is in supper-speed device mode. Modprobe g_zero, link state is U3 (checked in DSTS). After dwc3 is enumerated by the host, the trace on the bus is as: [both Device and Host are in U0 now] D->H: LGO_U1 H->D: LAU D->H: LPMA but actually dwc3 goes to

Re: [PATCH] USB: update intro of documentation

2016-10-21 Thread Jonathan Corbet
On Thu, 20 Oct 2016 15:15:00 +0200 Oliver Neukum wrote: > It does no good to mention The 2.4 kernel series and neglect > USB 3.x and XHCI. Also with type C and micro/mini USB we better > not talk about the shape of connectors. ...except that USB 2 connectors will be with us

Re: PROBLEM: OHCI watchdog timeouts inside VirtualBox, probably due to timer wheel rework

2016-10-21 Thread Alan Stern
On Fri, 21 Oct 2016, Michal Necasek wrote: >Alan, > > I'll get back to you on whether increasing the timeout helps, it'll > take a bit of testing. Does it actually sound plausible that some > controllers could not get things done in 250ms but could in 275ms? Not very, I admit. > I will

[PATCH 2/2] USB: UHCI: report non-PME wakeup signalling for Intel hardware

2016-10-21 Thread Alan Stern
The UHCI controllers in Intel chipsets rely on a platform-specific non-PME mechanism for wakeup signalling. They can generate wakeup signals even though they don't support PME. We need to let the USB core know this so that it will enable runtime suspend for UHCI controllers. Signed-off-by: Alan

Re: [PATCH 1/2] PCI: check for PME in targeted sleep state

2016-10-21 Thread Rafael J. Wysocki
On Friday, October 21, 2016 04:45:38 PM Alan Stern wrote: > One some systems, the firmware does not allow certain PCI devices to > be put in deep D-states. This can cause problems for wakeup > signalling, if the device does not support PME# in the deepest allowed > suspend state. For example,

[PATCH 1/2] PCI: check for PME in targeted sleep state

2016-10-21 Thread Alan Stern
One some systems, the firmware does not allow certain PCI devices to be put in deep D-states. This can cause problems for wakeup signalling, if the device does not support PME# in the deepest allowed suspend state. For example, Pierre reports that on his system, ACPI does not permit his xHCI

Re: [RFC][PATCH 2/2] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220

2016-10-21 Thread John Youn
On 10/20/2016 5:43 PM, Chen Yu wrote: > On 2016/10/19 6:21, John Youn wrote: >> On 10/16/2016 7:42 PM, Chen Yu wrote: >>> >>> >>> On 2016/10/15 3:37, John Youn wrote: On 10/13/2016 4:36 PM, John Stultz wrote: > From: Chen Yu > > The Hi6220's usb controller is

Re: [PATCH v9 1/2] usb: dwc2: assert phy reset when waking up in rk3288 platform

2016-10-21 Thread John Youn
On 10/20/2016 11:38 AM, Randy Li wrote: > On the rk3288 USB host-only port (the one that's not the OTG-enabled > port) the PHY can get into a bad state when a wakeup is asserted (not > just a wakeup from full system suspend but also a wakeup from > autosuspend). > > We can get the PHY out of its

Re: [RESEND PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-10-21 Thread Bjorn Andersson
On Fri 21 Oct 10:38 PDT 2016, Stephen Boyd wrote: > On 10/21, Bjorn Andersson wrote: > > hcd_alloc_coherent() and usb_alloc_coherent() ends up allocating coherent > > memory on behalf of ci_hdrc driver. But as the ci_hdrc is instantiated > > manually > > it will not have any dma_mem or dma_ops

Re: [RESEND PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-10-21 Thread Stephen Boyd
On 10/21, Bjorn Andersson wrote: > hcd_alloc_coherent() and usb_alloc_coherent() ends up allocating coherent > memory on behalf of ci_hdrc driver. But as the ci_hdrc is instantiated > manually > it will not have any dma_mem or dma_ops assigned, which makes the > dma_alloc_coherent() fail on some

[RESEND PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-10-21 Thread Bjorn Andersson
hcd_alloc_coherent() and usb_alloc_coherent() ends up allocating coherent memory on behalf of ci_hdrc driver. But as the ci_hdrc is instantiated manually it will not have any dma_mem or dma_ops assigned, which makes the dma_alloc_coherent() fail on some platforms (e.g. arm64). This patch solves

Re: [PATCH] usb: xhci: Workaround for erratum-A010129

2016-10-21 Thread Alan Stern
On Fri, 21 Oct 2016, Sriram Dash wrote: > For the USB3.0 controller, USB 2.0 reset not driven while > port is in Resume state. So, do not program the USB 2.0 reset > (PORTSC[PR]=1) while in Resume state. > > Signed-off-by: Rajat Srivastava > Signed-off-by: Sriram Dash

[PATCH] usb: xhci: Workaround for erratum-A010129

2016-10-21 Thread Sriram Dash
For the USB3.0 controller, USB 2.0 reset not driven while port is in Resume state. So, do not program the USB 2.0 reset (PORTSC[PR]=1) while in Resume state. Signed-off-by: Rajat Srivastava Signed-off-by: Sriram Dash Signed-off-by: Rajesh Bhagat

[GIT PULL] USB-serial fixes for v4.9-rc2

2016-10-21 Thread Johan Hovold
Hi Greg, Here are some fixes for 4.9-rc2. Details below. Thanks, Johan The following changes since commit 1001354ca34179f3db924eb66672442a173147dc: Linux 4.9-rc1 (2016-10-15 12:17:50 -0700) are available in the git repository at:

Re: [PATCH 1/2] usb: dwc3: st: add missing include

2016-10-21 Thread Felipe Balbi
Hi, Sergei Shtylyov writes: > Hello. > > On 10/21/2016 03:29 PM, Felipe Balbi wrote: > >> dwc3-st uses pinctrl_pm_select_*_state() however it >> doesn't include the necessary header. Fix the build >> break caused by that, by simply including the >> missing

Re: [PATCH 1/2] usb: dwc3: st: add missing include

2016-10-21 Thread Sergei Shtylyov
Hello. On 10/21/2016 03:29 PM, Felipe Balbi wrote: dwc3-st uses pinctrl_pm_select_*_state() however it doesn't include the necessary header. Fix the build break caused by that, by simply including the missing header. Signed-off-by: Felipe Balbi ---

Re: [balbi-usb:testing/next 57/84] drivers/usb/dwc3/dwc3-st.c:328:2: error: implicit declaration of function 'pinctrl_pm_select_sleep_state'

2016-10-21 Thread Felipe Balbi
Hi, Linus Walleij writes: > On Mon, Oct 17, 2016 at 1:50 PM, Felipe Balbi > wrote: > >> kbuild test robot writes: >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git >>> testing/next >>>

[PATCH 1/2] usb: dwc3: st: add missing include

2016-10-21 Thread Felipe Balbi
dwc3-st uses pinctrl_pm_select_*_state() however it doesn't include the necessary header. Fix the build break caused by that, by simply including the missing header. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/dwc3-st.c | 1 + 1 file changed, 1 insertion(+)

[PATCH 2/2] usb: dwc3: st: allow to build on COMPILE_TEST

2016-10-21 Thread Felipe Balbi
Every glue layer should be buildable on COMPILE_TEST Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig index b97cde76914d..66943106a69a

Re: [balbi-usb:testing/next 57/84] drivers/usb/dwc3/dwc3-st.c:328:2: error: implicit declaration of function 'pinctrl_pm_select_sleep_state'

2016-10-21 Thread Linus Walleij
On Mon, Oct 17, 2016 at 1:50 PM, Felipe Balbi wrote: > kbuild test robot writes: >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git >> testing/next >> head: 4281ef86fae986e0a9bb553fb311fe6d8e039118 >> commit:

Re: musb RPM sleep-while-atomic in 4.9-rc1

2016-10-21 Thread Tony Lindgren
* Johan Hovold [161021 04:08]: > On Fri, Oct 21, 2016 at 02:49:05AM -0700, Tony Lindgren wrote: > > * Johan Hovold [161021 02:26]: > > > On Fri, Oct 21, 2016 at 12:08:49AM -0700, Tony Lindgren wrote: > > > > * Johan Hovold [161020 08:38]: >

Re: musb RPM sleep-while-atomic in 4.9-rc1

2016-10-21 Thread Johan Hovold
On Fri, Oct 21, 2016 at 02:49:05AM -0700, Tony Lindgren wrote: > * Johan Hovold [161021 02:26]: > > On Fri, Oct 21, 2016 at 12:08:49AM -0700, Tony Lindgren wrote: > > > * Johan Hovold [161020 08:38]: > > > > Hi Tony, > > > > > > > > I'm getting the splat

Re: [PATCH v2 0/2] usb: host: xhci: plat: add support for Renesas r8a7796 SoC

2016-10-21 Thread Mathias Nyman
On 19.10.2016 11:50, Yoshihiro Shimoda wrote: This patch set is based on the latest Greg's usb.git / usb-next branch. (commit id = 1001354ca34179f3db924eb66672442a173147dc) Changes from v1: - Revise the comment in patch 1. - Don't add a new macro because the macro will be not used in the

[PATCH] USB: serial: fix potential NULL-dereference at probe

2016-10-21 Thread Johan Hovold
Make sure we have at least one port before attempting to register a console. Currently, at least one driver binds to a "dummy" interface and requests zero ports for it. Should such an interface also lack endpoints, we get a NULL-deref during probe. Fixes: e5b1e2062e05 ("USB: serial: make minor

[PATCH v2] usb: dwc3: Fix error handling for core init

2016-10-21 Thread Vivek Gautam
Fixing the sequence of events in dwc3_core_init() error exit path. dwc3_core_exit() call is also removed from the error path since, whatever it's doing is already done. Fixes: c499ff7 usb: dwc3: core: re-factor init and exit paths Cc: Felipe Balbi Cc: Greg KH

Re: [PATCH v2 1/1] usb: xhci: clean up error_bitmask usage

2016-10-21 Thread Mathias Nyman
On 21.10.2016 06:14, Lu Baolu wrote: In xhci_handle_event(), when errors are detected, driver always sets a bit in error_bitmask (one member of the xhci private driver data). That means users have to retrieve and decode the value of error_bitmask in xhci private driver data if they want to know

Re: [PATCH] usb: dwc3: Fix error handling for core init

2016-10-21 Thread Vivek Gautam
Hi, On Fri, Oct 21, 2016 at 3:45 PM, Felipe Balbi wrote: > > Hi, > > Vivek Gautam writes: >> Fixing the sequence of events in dwc3_core_init() error exit path. >> dwc3_core_exit() call is removed from the error path since, >> whatever it's doing

Re: [PATCH] usb: dwc3: Fix error handling for core init

2016-10-21 Thread Felipe Balbi
Hi, Vivek Gautam writes: > Fixing the sequence of events in dwc3_core_init() error exit path. > dwc3_core_exit() call is removed from the error path since, > whatever it's doing is already done. > > Signed-off-by: Vivek Gautam > Cc:

Re: musb RPM sleep-while-atomic in 4.9-rc1

2016-10-21 Thread Tony Lindgren
* Johan Hovold [161021 02:26]: > On Fri, Oct 21, 2016 at 12:08:49AM -0700, Tony Lindgren wrote: > > * Johan Hovold [161020 08:38]: > > > Hi Tony, > > > > > > I'm getting the splat below when booting 4.9-rc1 on a BBB and > > > tracked it down to 65b3f50ed6fa

Re: musb RPM sleep-while-atomic in 4.9-rc1

2016-10-21 Thread Johan Hovold
On Fri, Oct 21, 2016 at 12:08:49AM -0700, Tony Lindgren wrote: > * Johan Hovold [161020 08:38]: > > Hi Tony, > > > > I'm getting the splat below when booting 4.9-rc1 on a BBB and > > tracked it down to 65b3f50ed6fa ("usb: musb: Add PM runtime support for > > MUSB DSPS glue

Re: Interactive whiteboards

2016-10-21 Thread Greg KH
On Thu, Oct 20, 2016 at 10:46:11AM +0200, María Cano wrote: > >> HITACHI STARBOARD (DOESN’T WORK) > >> DIFF FOR cat /proc/bus/input/devices > >> > T: Bus=04 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 12 Spd=12 MxCh= 0 > >> > D: Ver= 1.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > >> > P:

Re: [PATCH 0/2] musb-fixes for v4.9-rc2

2016-10-21 Thread Tony Lindgren
* Ladislav Michl [161020 12:37]: > On Thu, Oct 20, 2016 at 05:35:24AM -0700, Tony Lindgren wrote: > > I don't think I've seen that error.. > > Comment in code reads: 'FIXME this is another "SHOULD NEVER HAPPEN"' Seems like it does though.. > > There are few patches that

Re: musb RPM sleep-while-atomic in 4.9-rc1

2016-10-21 Thread Tony Lindgren
* Johan Hovold [161020 08:38]: > Hi Tony, > > I'm getting the splat below when booting 4.9-rc1 on a BBB and > tracked it down to 65b3f50ed6fa ("usb: musb: Add PM runtime support for > MUSB DSPS glue layer") which added a synchronous RPM get in a timer > callback: OK, sorry to

[PATCH] usb: dwc3: Fix error handling for core init

2016-10-21 Thread Vivek Gautam
Fixing the sequence of events in dwc3_core_init() error exit path. dwc3_core_exit() call is removed from the error path since, whatever it's doing is already done. Signed-off-by: Vivek Gautam Cc: Felipe Balbi --- Based on usb-next.