Re: [PATCH v4 1/4] usb: dbc: early driver for xhci debug capability

2016-11-11 Thread Lu Baolu
Hi Peter, On 11/11/2016 08:28 PM, Peter Zijlstra wrote: > On Fri, Nov 11, 2016 at 12:33:29PM +0800, Lu Baolu wrote: > >> Things become complicated when it comes to USB debug port. >> But it's still addressable. >> >> At this time, we can do it like this. >> >> write() >> { >> if (in_nmi() &&

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

2016-11-11 Thread Laurent Pinchart
Hi Bin, On Friday 11 Nov 2016 17:06:02 Bin Liu wrote: > On Sat, Nov 12, 2016 at 12:11:04AM +0200, Laurent Pinchart wrote: > > On Friday 11 Nov 2016 08:53:22 Tony Lindgren wrote: > >> * Bin Liu [16 08:25]: > >>> On Fri, Nov 11, 2016 at 01:39:28AM +0200, Laurent Pinchart wrote: >

[PATCH] usb: gadget: Fix checkpatch error for braces

2016-11-11 Thread Anson Jacob
Fix error message by checkpath.pl open brace '{' following struct/enum go on the same line Patch applied by running fix inplace capability of checkpatch: checkpatch.pl -f *.[ch] --types OPEN_BRACE --fix-inplace Signed-off-by: Anson Jacob ---

Re: [PATCHv2 0/6] musb fixes for v4.9-rc cycle

2016-11-11 Thread Laurent Pinchart
Hi Tony, Thank you for the patches. On Friday 11 Nov 2016 10:42:56 Tony Lindgren wrote: > Hi all, > > Here are musb fixes for the issues that I've been able to track down. > > As many people depend on this driver I'd like to have these merged > for v4.9-rc cycle after review and testing. > >

Re: [PATCH 1/2] usb: dwc2: add amcc,dwc-otg support

2016-11-11 Thread Christian Lamparter
On Friday, November 11, 2016 2:20:42 PM CET John Youn wrote: > On 11/11/2016 2:05 PM, Christian Lamparter wrote: > > On Friday, November 11, 2016 1:22:16 PM CET John Youn wrote: > >> On 11/11/2016 12:59 PM, Christian Lamparter wrote: > >>> This patch adds support for the "amcc,usb-otg" device >

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

2016-11-11 Thread Bin Liu
On Sat, Nov 12, 2016 at 12:11:04AM +0200, Laurent Pinchart wrote: > Hello, > > On Friday 11 Nov 2016 08:53:22 Tony Lindgren wrote: > > * Bin Liu [16 08:25]: > > > On Fri, Nov 11, 2016 at 01:39:28AM +0200, Laurent Pinchart wrote: > > >> Hello, > > >> > > >> On Friday 11 Nov

Re: [PATCH 2/2] USB: UHCI: report non-PME wakeup signalling for Intel hardware

2016-11-11 Thread Bjorn Helgaas
On Sat, Oct 22, 2016 at 12:03:44PM +0200, Greg KH wrote: > On Fri, Oct 21, 2016 at 04:49:07PM -0400, Alan Stern wrote: > > The UHCI controllers in Intel chipsets rely on a platform-specific > > non-PME mechanism for wakeup signalling. They can generate wakeup > > signals even though they don't

Re: [PATCH 1/2] usb: dwc2: add amcc,dwc-otg support

2016-11-11 Thread John Youn
On 11/11/2016 2:05 PM, Christian Lamparter wrote: > Hello, > > On Friday, November 11, 2016 1:22:16 PM CET John Youn wrote: >> On 11/11/2016 12:59 PM, Christian Lamparter wrote: >>> This patch adds support for the "amcc,usb-otg" device >>> which is found in the PowerPC Canyonlands' dts. >>> >>>

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

2016-11-11 Thread Laurent Pinchart
Hello, On Friday 11 Nov 2016 08:53:22 Tony Lindgren wrote: > * Bin Liu [16 08:25]: > > On Fri, Nov 11, 2016 at 01:39:28AM +0200, Laurent Pinchart wrote: > >> Hello, > >> > >> On Friday 11 Nov 2016 00:27:52 Laurent Pinchart wrote: > >>> On Thursday 10 Nov 2016 13:42:34 Tony

Re: [PATCH 1/2] usb: dwc2: add amcc,dwc-otg support

2016-11-11 Thread Christian Lamparter
Hello, On Friday, November 11, 2016 1:22:16 PM CET John Youn wrote: > On 11/11/2016 12:59 PM, Christian Lamparter wrote: > > This patch adds support for the "amcc,usb-otg" device > > which is found in the PowerPC Canyonlands' dts. > > > > The device definition was added by: > > commit

Re: [PATCH v2 11/30] usb: dwc2: gadget: Add DDMA chain fill and parse functions

2016-11-11 Thread John Youn
On 11/11/2016 2:53 AM, Felipe Balbi wrote: > > Hi, > > John Youn writes: >> From: Vahram Aharonyan >> >> Add dwc2_gadget_get_desc_params() function to define descriptor entry >> parameters based on the endpoint type. >> >> Add

Re: [PATCH v3 3/5] usb: dwc3: gadget: Write GEVNTCOUNT in interrupt

2016-11-11 Thread John Youn
On 11/11/2016 3:10 AM, Felipe Balbi wrote: > > Hi, > > John Youn writes: >> Currently GEVNTCOUNT is written in the threaded interrupt handler while >> processing each event. This commit moves the GEVNTCOUNT write to the >> hard IRQ. We then copy the events to a separate

Re: [PATCH 1/2] usb: dwc2: add amcc,dwc-otg support

2016-11-11 Thread John Youn
On 11/11/2016 12:59 PM, Christian Lamparter wrote: > This patch adds support for the "amcc,usb-otg" device > which is found in the PowerPC Canyonlands' dts. > > The device definition was added by: > commit c89b3458d8cc ("powerpc/44x: Add USB DWC DTS entry to Canyonlands > board")' > but without

[PATCH 2/2] usb: dwc2: fixes host_dma logic

2016-11-11 Thread Christian Lamparter
This patch moves the the host_dma initialization before dwc2_set_param_dma_desc_enable and dwc2_set_param_dma_desc_fs_enable. The reason being that both function need it. Fixes: 1205489cee75bf39 ("usb: dwc2: Get host DMA device properties") Cc: John Youn Cc: Felipe Balbi

[PATCH 1/2] usb: dwc2: add amcc,dwc-otg support

2016-11-11 Thread Christian Lamparter
This patch adds support for the "amcc,usb-otg" device which is found in the PowerPC Canyonlands' dts. The device definition was added by: commit c89b3458d8cc ("powerpc/44x: Add USB DWC DTS entry to Canyonlands board")' but without any driver support as the dwc2 driver wasn't available at that

Re: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration

2016-11-11 Thread Arnd Bergmann
On Thursday, November 10, 2016 1:02:11 PM CET Felipe Balbi wrote: > > @@ -123,8 +119,8 @@ int dwc3_host_init(struct dwc3 *dwc) > > void dwc3_host_exit(struct dwc3 *dwc) > > { > > phy_remove_lookup(dwc->usb2_generic_phy, "usb2-phy", > > - dev_name(>xhci->dev)); > > +

Re: [PATCH 1/6] usb: musb: Fix broken use of static variable for multiple instances

2016-11-11 Thread Bin Liu
On Fri, Nov 11, 2016 at 12:05:19PM -0800, Tony Lindgren wrote: > * Bin Liu [16 11:15]: > > On Fri, Nov 11, 2016 at 10:42:57AM -0800, Tony Lindgren wrote: > > > --- a/drivers/usb/musb/musb_core.h > > > +++ b/drivers/usb/musb/musb_core.h > > > @@ -385,6 +385,8 @@ struct musb { > >

Re: [PATCH 1/6] usb: musb: Fix broken use of static variable for multiple instances

2016-11-11 Thread Tony Lindgren
* Bin Liu [16 11:15]: > On Fri, Nov 11, 2016 at 10:42:57AM -0800, Tony Lindgren wrote: > > --- a/drivers/usb/musb/musb_core.h > > +++ b/drivers/usb/musb/musb_core.h > > @@ -385,6 +385,8 @@ struct musb { > > int a_wait_bcon;/* VBUS timeout in msecs */

[PATCH] dma: cpp41: Fix handling of error path

2016-11-11 Thread Tony Lindgren
If we return early on pm_runtime_get() error, we need to also call pm_runtime_put_noidle() as pointed out in a musb related thread by Johan Hovold . This is to keep the PM runtime use counts happy. Fixes: fdea2d09b997 ("dmaengine: cppi41: Add basic PM runtime support") Cc: Johan

[PATCH 1/6] usb: musb: Fix broken use of static variable for multiple instances

2016-11-11 Thread Tony Lindgren
We can't use static variable first for checking when musb is initialized when we have multiple musb instances like on am335x. Tested-by: Ladislav Michl Reviewed-by: Johan Hovold Tested-by: Laurent Pinchart

[PATCH 2/6] usb: musb: Fix sleeping function called from invalid context for hdrc glue

2016-11-11 Thread Tony Lindgren
Commit 65b3f50ed6fa ("usb: musb: Add PM runtime support for MUSB DSPS glue layer") wrongly added a call for pm_runtime_get_sync to otg_timer that runs in softirq context. That causes a "BUG: sleeping function called from invalid context" every time when polling the cable status: []

[PATCH 4/6] phy: twl4030-usb: Fix for musb session bit based PM

2016-11-11 Thread Tony Lindgren
Now with musb driver implementing generic session bit based PM, we need to have the USB PHYs behaving in a sane way for platforms implementing PM. Currently twl4030-usb enables PM in twl4030_phy_power_on() and then disables it in twl4030_phy_power_off(). This will block PM runtime for the SoC

[PATCH 6/6] usb: musb: Drop pointless PM runtime code for dsps glue

2016-11-11 Thread Tony Lindgren
This already gets done automatically by PM runtime and we have a separate autosuspend timeout in musb_core.c. Signed-off-by: Tony Lindgren --- drivers/usb/musb/musb_dsps.c | 21 ++--- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git

[PATCH 5/6] usb: musb: Add missing pm_runtime_disable and drop 2430 PM timeout

2016-11-11 Thread Tony Lindgren
We are missing pm_runtime_disable() in 2430 glue layer. Further, we only need to enable PM runtime and disable it on exit. With musb_core.c doing PM, the glue layer as a parent will always be active when musb_core.c is active. This fixes host enumeration issues with some devices as reported by

[PATCHv2 0/6] musb fixes for v4.9-rc cycle

2016-11-11 Thread Tony Lindgren
Hi all, Here are musb fixes for the issues that I've been able to track down. As many people depend on this driver I'd like to have these merged for v4.9-rc cycle after review and testing. Please review and test. You need to use v4.9-rc3 or later for testing because of the earlier fixes.

[PATCH 3/6] usb: musb: Fix PM for hub disconnect

2016-11-11 Thread Tony Lindgren
With a USB hub disconnected, devctl can be 0x19 for about a second on am335x and will stay forever on at least omap3. And we get no further interrupts when devctl session bit clears. This keeps PM runtime active. Let's fix the issue by polling devctl until the session bit clears or times out. We

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

2016-11-11 Thread Tony Lindgren
* Bin Liu [16 08:25]: > On Fri, Nov 11, 2016 at 01:39:28AM +0200, Laurent Pinchart wrote: > > Hello, > > > > On Friday 11 Nov 2016 00:27:52 Laurent Pinchart wrote: > > > On Thursday 10 Nov 2016 13:42:34 Tony Lindgren wrote: > > > > * Laurent Pinchart

Re: [PATCH 2/4] usb: musb: Fix sleeping function called from invalid context for hdrc glue

2016-11-11 Thread Tony Lindgren
* Johan Hovold [16 08:40]: > On Fri, Nov 11, 2016 at 07:42:50AM -0800, Tony Lindgren wrote: > > Fixes: 65b3f50ed6fa ("usb: musb: Add PM runtime support for MUSB DSPS > > glue layer") > > Reported-by: Johan Hovold > > Signed-off-by: Tony Lindgren

Re: [PATCH 2/4] usb: musb: Fix sleeping function called from invalid context for hdrc glue

2016-11-11 Thread Johan Hovold
On Fri, Nov 11, 2016 at 07:42:50AM -0800, Tony Lindgren wrote: > * Johan Hovold [16 04:03]: > > On Thu, Nov 10, 2016 at 12:40:03PM -0700, Tony Lindgren wrote: > From tony Mon Sep 17 00:00:00 2001 > From: Tony Lindgren > Date: Wed, 2 Nov 2016 19:59:05

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

2016-11-11 Thread Bin Liu
On Fri, Nov 11, 2016 at 01:39:28AM +0200, Laurent Pinchart wrote: > Hello, > > On Friday 11 Nov 2016 00:27:52 Laurent Pinchart wrote: > > On Thursday 10 Nov 2016 13:42:34 Tony Lindgren wrote: > > > * Laurent Pinchart [161110 13:29]: > > >> I had to disable

Re: [PATCH 2/4] usb: musb: Fix sleeping function called from invalid context for hdrc glue

2016-11-11 Thread Tony Lindgren
* Johan Hovold [16 04:03]: > On Thu, Nov 10, 2016 at 12:40:03PM -0700, Tony Lindgren wrote: > > + * Called from musb_runtime_resume(), musb_resume(), and > > + * musb_queue_resume_work(). Callers must take musb->lock and must hold > > + * an RPM reference. > > The RPM

Re: [PATCH 1/1] usb: phy: phy-generic: add the implementation of .set_suspend

2016-11-11 Thread Roger Quadros
Hi, On 03/11/16 10:53, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: >> Add clock operation at .set_suspend if the PHY has >> suspend requirement, it can be benefit of power saving for >> phy and the whole system (parent clock may also be disabled). >> >>

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

2016-11-11 Thread Mathias Nyman
On 10.11.2016 13:22, Oliver Neukum wrote: On Thu, 2016-11-10 at 12:09 +0100, Bjørn Mork wrote: Kai-Heng Feng writes: On Wed, Nov 9, 2016 at 8:32 PM, Bjørn Mork wrote: Oliver Neukum writes: On Tue, 2016-11-08 at 13:44 -0500,

[PATCH 03/23] xhci: don't try to reset the host if it is unaccessible

2016-11-11 Thread Mathias Nyman
There is no point in trying to reset the host controller by writing to its registers if host is removed and registers just return 0x bail out and return -ENODEV instead Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci.c | 7 ++- 1 file changed,

[PATCH 23/23] usb: hub: Fix auto-remount of safely removed or ejected USB-3 devices

2016-11-11 Thread Mathias Nyman
USB-3 does not have any link state that will avoid negotiating a connection with a plugged-in cable but will signal the host when the cable is unplugged. For USB-3 we used to first set the link to Disabled, then to RxDdetect to be able to detect cable connects or disconnects. But in RxDetect the

[PATCH 07/23] xhci: cleanup and refactor process_ctrl_td()

2016-11-11 Thread Mathias Nyman
Refactor pricess_ctrl_tx() to make it more readable No functional changes Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c | 103 +++ 1 file changed, 45 insertions(+), 58 deletions(-) diff --git

[PATCH 05/23] xhci: add trb_is_noop() helper function

2016-11-11 Thread Mathias Nyman
replace the complex check for noop with a simple helper Improve code readability No functional changes Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git

[PATCH 18/23] usb: host: xhci: plat: add support for Renesas r8a7796 SoC

2016-11-11 Thread Mathias Nyman
From: Yoshihiro Shimoda This patch adds support for Renesas r8a7796 SoC. This SoC is not compatible with r8a7795 because using firmware version differs. Since the "V2" firmware can be used on both r8a7795 (es1.x) and r8a7796, the "renesas,rcar-gen3-xhci" keeps

[PATCH 19/23] xhci: add helper to get the endpoint state of a endpoint context

2016-11-11 Thread Mathias Nyman
define GET_EP_CTX_STATE() macro to get the endpoint state from a pointer to a le32 enpoint context structure No functional changes Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c | 18 ++ drivers/usb/host/xhci.c | 3 +--

[PATCH 01/23] xhci: remove unnecessary xhci_quiesce call before xhci_halt

2016-11-11 Thread Mathias Nyman
Fist function called in xhci_halt is xhci_quiesce, so no point in calling it twice Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index

[PATCH 12/23] xhci: fix non static symbol warning

2016-11-11 Thread Mathias Nyman
From: Wei Yongjun Fixes the following sparse warning: drivers/usb/host/xhci-ring.c:608:6: warning: symbol 'xhci_unmap_td_bounce_buffer' was not declared. Should it be static? Signed-off-by: Wei Yongjun Signed-off-by: Mathias Nyman

[PATCH 14/23] xhci: Giveback urb in finish_td directly

2016-11-11 Thread Mathias Nyman
mostly refactoring and code cleanup. while handling transfer events we used to check the return value of various functions to see if we can give back the URB. Turns out the only case when those return values are set are when finish_td() notices we are completing the last td in the URB. give back

[PATCH 20/23] usb: xhci: cleanup cmd_completion in xhci_virt_device

2016-11-11 Thread Mathias Nyman
From: Lu Baolu cmd_completion in struct xhci_virt_device is legacy. With command structure and command queue introduced in xhci, cmd_completion is not used any more. This patch removes it. Signed-off-by: Lu Baolu Signed-off-by: Mathias Nyman

[PATCH 08/23] xhci: cleanup and refactor process_bulk_intr_td()

2016-11-11 Thread Mathias Nyman
mostly refactoring, but does also change error message if we get a bad length in the event trb. Adds a helper function to sum trb lengths of partial TDs Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c | 108

[PATCH 02/23] xhci: cleanup error message if halting the host failed.

2016-11-11 Thread Mathias Nyman
The old error message always stated that host was not halted even after trying a certain time. Host may fail the halt immediately as well with -ENODEV if device is removed and returns 0x. Use a more generic error message and show return value to know if we failed with -ETIMEDOUT or

[PATCH 09/23] xhci: rename endpoint related trb variables

2016-11-11 Thread Mathias Nyman
Renaming variables, no functional changes Event trbs on the event ring cointain a pointer to the transfer trb on a endpoint ring that caused the event. The naming has been very confusing as the event trb was called "event" and the endpoint transfer trb was called "event_trb". rename all

[PATCH 00/23] xhci features for usb-next

2016-11-11 Thread Mathias Nyman
Hi Greg In addition to all the xhci cleanups, refactoring, and features for xhci, there's a patch for usb core hub driver that changes how usb3 devices are disabled. It fixes a automatic re-mount issue seen when users try to "safely remove" or eject a usb mass storage device. Also happy to

[PATCH 17/23] usb: host: xhci: rcar: add a new firmware version for r8a7796

2016-11-11 Thread Mathias Nyman
From: Yoshihiro Shimoda This patch adds a new firmware version "V3" for r8a7796. This patch also adds explanation of each version's information. Signed-off-by: Yoshihiro Shimoda Signed-off-by: Mathias Nyman

[PATCH 13/23] xhci: refactor handle_tx_event() urb giveback

2016-11-11 Thread Mathias Nyman
Move giving back the urb to a separate function No functional changes Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c | 61 +++- 1 file changed, 32 insertions(+), 29 deletions(-) diff --git

[PATCH 11/23] xhci: cleanup and refactor td_to_noop()

2016-11-11 Thread Mathias Nyman
No functional changes but a few debugging outputs removed Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c | 62 ++-- 1 file changed, 20 insertions(+), 42 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c

[PATCH 04/23] xhci: use trb helper functions when possible

2016-11-11 Thread Mathias Nyman
Use the trb_is_link() and link_trb_toggles_cycle() helpers to make the code more readable No functional changes Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git

[PATCH 22/23] usb: xhci: move slot_id from xhci_hcd to xhci_command structure

2016-11-11 Thread Mathias Nyman
From: Lu Baolu xhci->slot_id is used for providing a way to pass slot id from the command completion handler to the function waiting for completion. It's shared by enumerations of all USB devices connected to an xhci host. Hence, it's a source for possible races. Since

[PATCH 10/23] xhci: refactor and cleanup process_isoc_td()

2016-11-11 Thread Mathias Nyman
No functional changes Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c | 69 1 file changed, 32 insertions(+), 37 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index

[PATCH 15/23] xhci: Remove duplicate xhci urb giveback functions

2016-11-11 Thread Mathias Nyman
We want one function that gives back urb in interrupt that can be used in both normal cases and when killing off urbs. Add small helpers that check if td is last_td_in_urb() and that increase the td count of a urb inc_td_cnt() Signed-off-by: Mathias Nyman ---

[PATCH 06/23] xhci: remove extra URB_SHORT_NOT_OK checks in xhci, core handles most cases

2016-11-11 Thread Mathias Nyman
We only check for the URB_SHORT_NOT_OK urb flag to set the urb status to -EREMOTEIO for transfers that didn't transfer all data. This will be done in __usb_hcd_giveback() for other than isoc tranfers, so remove the redundant check from xhci. Also fix a couple split lines in debug messages to

[PATCH 16/23] usb: xhci: clean up error_bitmask usage

2016-11-11 Thread Mathias Nyman
From: Lu Baolu In xhci_handle_event(), when errors are detected, driver always sets a bit in error_bitmask (one member of the xhci private driver data). That means users have to retrieve and decode the value of error_bitmask in xhci private driver data if they want to

[PATCH 21/23] usb: xhci: remove the use of xhci->addr_dev

2016-11-11 Thread Mathias Nyman
From: Lu Baolu xhci->addr_dev is used for the completion of both address device and enable slot commands. It's shared by enumerations of all USB devices connected to an xhci host. Hence, it's just a source for possible races. Since we've introduced command structure and

Re: [PATCH v4 1/4] usb: dbc: early driver for xhci debug capability

2016-11-11 Thread Peter Zijlstra
On Fri, Nov 11, 2016 at 12:33:29PM +0800, Lu Baolu wrote: > Things become complicated when it comes to USB debug port. > But it's still addressable. > > At this time, we can do it like this. > > write() > { > if (in_nmi() && raw_spin_is_locked()) > return; > >

Re: [PATCH net 2/2] r8152: rx descriptor check

2016-11-11 Thread Francois Romieu
Hayes Wang : > For some platforms, the data in memory is not the same with the one > from the device. That is, the data of memory is unbelievable. The > check is used to find out this situation. Invalid packet size corrupted receive descriptors in Realtek's device reminds

RE: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration

2016-11-11 Thread Sriram Dash
>From: Baolin Wang [mailto:baolin.w...@linaro.org] > >Hi, > >On 10 November 2016 at 16:20, Sriram Dash wrote: >> From: Arnd Bergmann >> >> The dma ops for dwc3 devices are not set properly. So, use a physical >> device sysdev, which will be inherited from

Re: [PATCH 2/4] usb: musb: Fix sleeping function called from invalid context for hdrc glue

2016-11-11 Thread Johan Hovold
On Thu, Nov 10, 2016 at 12:40:03PM -0700, Tony Lindgren wrote: > * Johan Hovold [161110 11:43]: > > On Thu, Nov 10, 2016 at 10:41:50AM -0700, Tony Lindgren wrote: > > > * Johan Hovold [161110 09:04]: > > > > I'm afraid that won't work as pm_runtime_get() would

RE: [PATCH v2 03/30] usb: dwc2: Make the DMA descriptor structure packed

2016-11-11 Thread David Laight
From: Felipe Balbi > Sent: 11 November 2016 10:45 > Hi, > > John Youn writes: > > On 11/10/2016 4:28 AM, David Laight wrote: > >> From: John Youn > >>> Sent: 10 November 2016 03:28 > >>> From: Vahram Aharonyan > >>> > >>> Make the DMA descriptor

Re: [PATCH v3 4/5] usb: dwc3: Implement interrupt moderation

2016-11-11 Thread Felipe Balbi
Hi, John Youn writes: > Implement interrupt moderation which allows the interrupt rate to be > throttled. To enable this feature the dwc->imod_interval must be set to > 1 or greater. This value specifies the minimum inter-interrupt interval, > in 250 ns increments. A

Re: [PATCH v3 3/5] usb: dwc3: gadget: Write GEVNTCOUNT in interrupt

2016-11-11 Thread Felipe Balbi
Hi, John Youn writes: > Currently GEVNTCOUNT is written in the threaded interrupt handler while > processing each event. This commit moves the GEVNTCOUNT write to the > hard IRQ. We then copy the events to a separate buffer for the event > handler to read from. > > This

Re: [PATHCv10 0/2] USB Type-C Connector class

2016-11-11 Thread Heikki Krogerus
On Thu, Nov 10, 2016 at 01:36:09PM -0800, Guenter Roeck wrote: > On Mon, Sep 19, 2016 at 02:16:55PM +0300, Heikki Krogerus wrote: > > The USB Type-C class is meant to provide unified interface to the > > userspace to present the USB Type-C ports in a system. > > > Any idea what is happening with

Re: [PATCH v5 03/23] usb: ulpi: Support device discovery via DT

2016-11-11 Thread Heikki Krogerus
On Mon, Oct 17, 2016 at 06:56:16PM -0700, Stephen Boyd wrote: > The qcom HSIC ULPI phy doesn't have any bits set in the vendor or > product ID registers. This makes it impossible to make a ULPI > driver match against the ID registers. Add support to discover > the ULPI phys via DT help alleviate

RE: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration

2016-11-11 Thread Felipe Balbi
Hi, Sriram Dash writes: >>From: Felipe Balbi [mailto:felipe.ba...@linux.intel.com] >> >> >>Hi, > > Hello Felipe, > >> >>Sriram Dash writes: >>> From: Arnd Bergmann >>> >>> The dma ops for dwc3 devices are not set properly. So, use a

Re: [PATCH v2 11/30] usb: dwc2: gadget: Add DDMA chain fill and parse functions

2016-11-11 Thread Felipe Balbi
Hi, John Youn writes: > From: Vahram Aharonyan > > Add dwc2_gadget_get_desc_params() function to define descriptor entry > parameters based on the endpoint type. > > Add dwc2_gadget_config_nonisoc_xfer_ddma() function, which programs DDMA > chain

Re: [PATCH v2 03/30] usb: dwc2: Make the DMA descriptor structure packed

2016-11-11 Thread Felipe Balbi
Hi, John Youn writes: > On 11/10/2016 4:28 AM, David Laight wrote: >> From: John Youn >>> Sent: 10 November 2016 03:28 >>> From: Vahram Aharonyan >>> >>> Make the DMA descriptor structure packed to guarantee alignment and size >>> in memory. >>>

RE: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration

2016-11-11 Thread Sriram Dash
>From: Felipe Balbi [mailto:felipe.ba...@linux.intel.com] > > >Hi, Hello Felipe, > >Sriram Dash writes: >> From: Arnd Bergmann >> >> The dma ops for dwc3 devices are not set properly. So, use a physical >> device sysdev, which will be inherited from parent,

Re: [patch] usb: xhci-mem: use passed in GFP flags instead of GFP_KERNEL

2016-11-11 Thread Sebastian Andrzej Siewior
On 2016-11-10 22:33:17 [+0300], Dan Carpenter wrote: > We normally use the passed in gfp flags for allocations, it's just these > two which were missed. You seem to be right. xhci_mem_init() has only one caller with GFP_KERNEL as argument. You could unwind it. Acked-by: Sebastian Andrzej Siewior