Rework smelling code (goto inside compound statement). Perhaps this is
legacy. Anyway such code is not appropriate for Linux kernel.
Signed-off-by: Eugene Korenevsky
---
Changes in v6: more pedantic conversion from `int` to `bool`; fix comment
Changes in v5: make `bool` a
> Ok, I'm going to be really pedantic here and ask that you spell this
> last statement out:
>if (usb...)
> return true;
>return false;
>
> Also, the comment should say:
> /* If the first endpoint is not interrupt IN, we... */
>
It's better to inverse the
On Friday 23 September 2016 07:10 PM, Hans de Goede wrote:
> The sunxi musb has a bug where sometimes it will generate a babble
> error on device disconnect instead of a disconnect irq. When this
> happens the musb-controller switches from host mode to device mode
> (it clears
On Thursday, November 17, 2016 12:52:14 PM CET John Youn wrote:
> This series adds a binding for AHB burst, reads it in, and configures
> the controller for the specified burst type.
>
> Tested on HAPS platform with DWC_hsotg IP version 3.30a.
>
> v3:
> * Split out binding documentation
> *
On Friday, November 18, 2016 8:16:08 AM CET Rob Herring wrote:
> On Thu, Nov 17, 2016 at 04:35:10PM +0100, Stefan Wahren wrote:
> > Hi John,
> >
> > Am 17.11.2016 um 00:47 schrieb John Youn:
> > > Add the "snps,ahb-burst" binding and read it in.
> > >
> > > This property controls which burst type
Hi linux-usb,
Quite simply, I would like to get into kernel development. I figured that I
could jumpstart this by writing a driver for this device:
http://www.gamestop.com/wii-u/accessories/wii-u-gamecube-adapter/115426
A while ago I figured that I could potentially work through this userland
On Tue, Nov 15, 2016 at 06:42:45PM +0100, Alexandre Bailon wrote:
> This series require the following patch to build:
> [PATCH 1/6] usb: musb: Fix broken use of static variable for multiple
> instances
>
> Currently, the USB OTG of the da8xx doesn't work.
> This series intend to fix them.
>
>
Read urbs are submitted back only on success, causing read pipe
running out of urbs after few errors. No more characters can
be read from tty device then until it is reopened and no errors
are reported.
Fix that by always submitting urbs back and clearing stall on
-EPIPE.
Signed-off-by: Ladislav
is_int_ep is used only in acm_probe, no need to store it in device data.
Signed-off-by: Ladislav Michl
---
Changes:
- v3: new patch in the serie
drivers/usb/class/cdc-acm.c | 5 ++---
drivers/usb/class/cdc-acm.h | 1 -
2 files changed, 2 insertions(+), 4 deletions(-)
Clearing stall needs pipe descriptor, store it in acm structure.
Signed-off-by: Ladislav Michl
---
Changes:
- v2: none
- v3: follow CodingStyle
drivers/usb/class/cdc-acm.c | 33 +
drivers/usb/class/cdc-acm.h | 1 +
2 files changed, 18
Move urb killing code into separate function and use it
instead of copying that code pattern over.
Signed-off-by: Ladislav Michl
---
Changes:
- v2: none
- v3: none
drivers/usb/class/cdc-acm.c | 43 ---
1 file changed, 16
Pointer to usb_device is already stored in acm structure.
Signed-off-by: Ladislav Michl
---
Changes:
- v2: none
- v3: none
drivers/usb/class/cdc-acm.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/class/cdc-acm.c
Use only one tab to indent dev_{(v)dbg,err} parameters.
Signed-off-by: Ladislav Michl
Acked-by: Oliver Neukum
---
Changes:
- v2: add changelog text
- v3: none
drivers/usb/class/cdc-acm.c | 35 +--
1 file changed, 17
On 11/18/2016 08:40 PM, Sergei Shtylyov wrote:
This is a note to let you know that I've just added the patch titled
usb: gadget: udc: dummy: make use of new usb_endpoint_maxp_mult()
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
On 11/18/2016 06:10 PM, gre...@linuxfoundation.org wrote:
This is a note to let you know that I've just added the patch titled
usb: gadget: udc: dummy: make use of new usb_endpoint_maxp_mult()
to my usb git tree which can be found at
On Wed, Nov 16, 2016 at 11:52:22AM +0100, Alexandre Bailon wrote:
> Changes in v2:
> * Remove unrelated changes in patch 3
> * Rename the device node in patch 4
>
> Changes in v3:
> * Fix few mistakes in DT binding sample
> * Only build the device table if DT is enabled
>
> Change in v4:
> * Fix
Hello.
On 11/18/2016 06:06 PM, gre...@linuxfoundation.org wrote:
This is a note to let you know that I've just added the patch titled
usb: gadget: udc: dummy: make use of new usb_endpoint_maxp_mult()
to my usb git tree which can be found at
The issue did not appear for a day with 4.9-rc5. Will check for a
couple more days and get back.
Thanks,
PrasannaKumar
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Fri, 18 Nov 2016 gre...@linuxfoundation.org wrote:
> This is a note to let you know that I've just added the patch titled
>
> usb: gadget: udc: dummy: make use of new usb_endpoint_maxp_mult()
>
> to my usb git tree which can be found at
>
This is a note to let you know that I've just added the patch titled
usb: ip: remove unnecessary & operation
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-next branch.
The patch will show up in the next release of the
This is a note to let you know that I've just added the patch titled
usb: gadget: udc: bdc: remove unnecessary & operation
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-next branch.
The patch will show up in the next
This is a note to let you know that I've just added the patch titled
usb: core: devices: remove unnecessary & operation
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-next branch.
The patch will show up in the next
This is a note to let you know that I've just added the patch titled
usb: host: ehci: remove unnecessary max_packet() macro
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-next branch.
The patch will show up in the next
This is a note to let you know that I've just added the patch titled
usb: gadget: udc: atmel: remove unnecessary & operation
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-next branch.
The patch will show up in the next
This is a note to let you know that I've just added the patch titled
usb: gadget: udc: dummy: remove unnecessary & operation
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-next branch.
The patch will show up in the next
This is a note to let you know that I've just added the patch titled
usb: host: xhci: make use of new usb_endpoint_maxp_mult()
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-next branch.
The patch will show up in the
This is a note to let you know that I've just added the patch titled
usb: chipidea: udc: remove unnecessary & operation
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-next branch.
The patch will show up in the next
This is a note to let you know that I've just added the patch titled
usb: gadget: udc: atmel: make use of new usb_endpoint_maxp_mult()
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-next branch.
The patch will show up in
This is a note to let you know that I've just added the patch titled
usb: core: devices: make use of new usb_endpoint_maxp_mult()
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-next branch.
The patch will show up in the
This is a note to let you know that I've just added the patch titled
usb: gadget: udc: bdc: make use of new usb_endpoint_maxp_mult()
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-next branch.
The patch will show up in
This is a note to let you know that I've just added the patch titled
usb: host: ehci: make use of new usb_endpoint_maxp_mult()
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-next branch.
The patch will show up in the
This is a note to let you know that I've just added the patch titled
usb: gadget: udc: dummy: make use of new usb_endpoint_maxp_mult()
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-next branch.
The patch will show up in
This is a note to let you know that I've just added the patch titled
usb: chipidea: udc: make use of new usb_endpoint_maxp_mult()
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-next branch.
The patch will show up in the
Hi Allan,
On 14/11/16 09:45, ASIX_Allan [Office] wrote:
> Hi Jon,
>
> Please help to double check if the USB host controller of your Terga
> platform had been powered OFF while running the ax88772_suspend() routine or
> not?
Sorry for the delay. Today I set up a local board to reproduce this
This is a note to let you know that I've just added the patch titled
usb: host: ehci: remove unnecessary max_packet() macro
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-testing branch.
The patch will show up in the
On Fri, Nov 18, 2016 at 02:27:18PM +0200, Felipe Balbi wrote:
>
> Hi Greg,
>
> Here's the giant pull request for all things Gadget and the
> like. Patches have been soaking in next for a while. I have tested them
> for several days with a SKL box.
>
> Let me know if you want anything to be
This is a note to let you know that I've just added the patch titled
usb: gadget: udc: dummy: remove unnecessary & operation
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-testing branch.
The patch will show up in the
This is a note to let you know that I've just added the patch titled
usb: ip: remove unnecessary & operation
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-testing branch.
The patch will show up in the next release of
This is a note to let you know that I've just added the patch titled
usb: core: devices: remove unnecessary & operation
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-testing branch.
The patch will show up in the next
This is a note to let you know that I've just added the patch titled
usb: gadget: udc: bdc: remove unnecessary & operation
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-testing branch.
The patch will show up in the next
This is a note to let you know that I've just added the patch titled
usb: gadget: udc: atmel: remove unnecessary & operation
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-testing branch.
The patch will show up in the
This is a note to let you know that I've just added the patch titled
usb: chipidea: udc: remove unnecessary & operation
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-testing branch.
The patch will show up in the next
This is a note to let you know that I've just added the patch titled
usb: host: xhci: make use of new usb_endpoint_maxp_mult()
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-testing branch.
The patch will show up in the
This is a note to let you know that I've just added the patch titled
usb: host: ehci: make use of new usb_endpoint_maxp_mult()
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-testing branch.
The patch will show up in the
This is a note to let you know that I've just added the patch titled
usb: gadget: udc: dummy: make use of new usb_endpoint_maxp_mult()
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-testing branch.
The patch will show up
This is a note to let you know that I've just added the patch titled
usb: gadget: udc: atmel: make use of new usb_endpoint_maxp_mult()
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-testing branch.
The patch will show up
This is a note to let you know that I've just added the patch titled
usb: core: devices: make use of new usb_endpoint_maxp_mult()
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-testing branch.
The patch will show up in
This is a note to let you know that I've just added the patch titled
usb: gadget: udc: bdc: make use of new usb_endpoint_maxp_mult()
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-testing branch.
The patch will show up
This is a note to let you know that I've just added the patch titled
usb: chipidea: udc: make use of new usb_endpoint_maxp_mult()
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-testing branch.
The patch will show up in
On Fri, Nov 18, 2016 at 03:22:13PM +0100, Johan Hovold wrote:
> Hi Greg,
>
> Here are some more device ids that could go into 4.9-rc.
>
> Thanks,
> Johan
>
>
> The following changes since commit bc33b0ca11e3df46a4fa7639ba488c9d4911:
>
> Linux 4.9-rc4 (2016-11-05 16:23:36 -0700)
>
> are
On Fri, Nov 18, 2016 at 01:53:43PM +0200, Felipe Balbi wrote:
>
> Hi Greg,
>
> here's one important fix for v4.9-final on functionFS. It's small and
> simple and all it does is make sure we check for ffs_func_req_match()'s
> return code properly.
>
> let me know if you want me to change this
Hi Greg,
Here are some more device ids that could go into 4.9-rc.
Thanks,
Johan
The following changes since commit bc33b0ca11e3df46a4fa7639ba488c9d4911:
Linux 4.9-rc4 (2016-11-05 16:23:36 -0700)
are available in the git repository at:
On Thu, Nov 17, 2016 at 04:35:10PM +0100, Stefan Wahren wrote:
> Hi John,
>
> Am 17.11.2016 um 00:47 schrieb John Youn:
> > Add the "snps,ahb-burst" binding and read it in.
> >
> > This property controls which burst type to perform on the AHB bus as a
> > master in internal DMA mode. This
On Wed, Nov 16, 2016 at 03:47:18PM -0800, John Youn wrote:
> Add the "snps,ahb-burst" binding and read it in.
>
> This property controls which burst type to perform on the AHB bus as a
> master in internal DMA mode. This overrides the legacy param value,
> which we need to keep around for now
On Tue, Nov 15, 2016 at 03:03:40PM -0800, John Youn wrote:
> From: Christian Lamparter
>
> This patch adds support for the "amcc,usb-otg" device
> which is found in the PowerPC Canyonlands' dts.
>
> The device definition was added by:
>
> commit c89b3458d8cc
-Wang/usb-host-plat-Enable-xhci-plat-runtime-PM/20161118-202029
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
d
Hi Greg,
Here's the giant pull request for all things Gadget and the
like. Patches have been soaking in next for a while. I have tested them
for several days with a SKL box.
Let me know if you want anything to be changed.
cheers
The following changes since commit
Currently, each hub class request constant is defined by a line like:
#define ClearHubFeature (0x2000 | USB_REQ_CLEAR_FEATURE)
The "magic" number for the high byte is one of 0x20, 0xa0, 0x23, 0xa3.
The 0x80 bit that changes inditace USB_DIR_IN, and the 0x03 that
pops up is the difference
On 16-11-18 02:57 AM, Hayes Wang wrote:
..
> Besides, the maximum data length which the RTL8152 would send to
> the host is 16KB. That is, if the agg_buf_sz is 16KB, the host
> wouldn't split it. However, you still see problems for it.
How does the RTL8152 know that the limit is 16KB,
rather than
For some mobile devices with strict power management, we also want to suspend
the host when the slave is detached for power saving. Thus we add the host
suspend/resume functions to support this requirement.
Signed-off-by: Baolin Wang
---
drivers/usb/dwc3/Kconfig |7
Enable the xhci plat runtime PM for parent device to suspend/resume xhci.
Signed-off-by: Baolin Wang
---
drivers/usb/host/xhci-plat.c | 37 -
1 file changed, 32 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/host/xhci-plat.c
Hi Greg,
here's one important fix for v4.9-final on functionFS. It's small and
simple and all it does is make sure we check for ffs_func_req_match()'s
return code properly.
let me know if you want me to change this pull request in any way.
cheers
The following changes since commit
Hi,
Felix Hädicke writes:
> Hello,
>> Properly check the return code of ffs_func_revmap_intf() and
>> ffs_func_revmap_ep() for a non-negative value.
>>
>> Instead of checking the return code, the comparison was performed for the
>> last
>> parameter of the function calls,
On Fri, Nov 18, 2016 at 01:18:19PM +0200, Tal Shorer wrote:
> Currently, each hub class request constant is defined by a line like:
>
> The "magic" number for the high byte is one of 0x20, 0xa0, 0x23, 0xa3.
> The 0x80 bit that changes inditace USB_DIR_IN, and the 0x03 that
> pops up is the
On Fri, Nov 18, 2016 at 01:18:19PM +0200, Tal Shorer wrote:
> Currently, each hub class request constant is defined by a line like:
>
> The "magic" number for the high byte is one of 0x20, 0xa0, 0x23, 0xa3.
Again, shouldn't there be something after your ":"?
--
To unsubscribe from this list:
Currently, each hub class request constant is defined by a line like:
The "magic" number for the high byte is one of 0x20, 0xa0, 0x23, 0xa3.
The 0x80 bit that changes inditace USB_DIR_IN, and the 0x03 that
pops up is the difference between USB_RECIP_DEVICE (0x00) and
USB_RECIP_OTHER (0x03). The
Hello.
On 11/18/2016 2:03 AM, Ladislav Michl wrote:
Clearing stall needs pipe descriptor, store it in acm structure.
Signed-off-by: Ladislav Michl
---
Changes:
- v2: None
drivers/usb/class/cdc-acm.c | 27 ++-
drivers/usb/class/cdc-acm.h | 1 +
Hello.
On 11/17/2016 6:01 PM, Roger Quadros wrote:
From: Felipe Balbi
Some devices from Texas Instruments [1] suffer from
a silicon bug where Port Enabled/Disabled bit
should not be used to silence an erroneous device.
The bug is so that if port is disabled with PED
bit, an
On Thu, 2016-11-17 at 23:56 +0100, Ladislav Michl wrote:
> Use only one tab to indent dev_{(v)dbg,err} parameters.
>
> Signed-off-by: Ladislav Michl
Acked-by: Oliver Neukum
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the
Currently, each hub class request constant is defined by a line like:
Where the "magic" number for the high byte is one of 0x20, 0xa0, 0x23,
0xa3.
The 0x80 bit that changes inditace USB_DIR_IN, and the 0x03 that
pops up is the difference between USB_RECIP_DEVICE (0x00) and
USB_RECIP_OTHER (0x03).
70 matches
Mail list logo