Hi Todd,
[auto build test ERROR on linus/master]
[also build test ERROR on next-20161214]
[cannot apply to usb/usb-testing balbi-usb/next v4.9]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
On Tue, Dec 13, 2016 at 06:53:03PM -0800, Andy Lutomirski wrote:
> On Tue, Dec 13, 2016 at 6:48 PM, Andy Lutomirski wrote:
> > The driver put a constant buffer of all zeros on the stack and
> > pointed a scatterlist entry at it in two places. This doesn't work
> > with virtual
Add a kernel parameter that replaces the USB_RESUME_TIMEOUT
and other hardcoded delay numbers with the USB spec minimums.
The USB subsystem currently uses heavily padded values for TDRSMDN
and TRSTRCY. This patch keeps the current values by default, but if
the kernel is booted with
add debugfs support for experimenting with USB timing delay
values on the fly. Values are read/written from debugfs at
/sys/kernel/debug/usb/timing.
Signed-off-by: Todd Brandt
---
drivers/usb/core/usb.c | 55 ++
1
The USB resume code in the kernel currently uses a set of hard coded
delay values that are defined in the USB 2.0 spec. Specifically these
three have the most effect on resume time:
- tdrsmdn: resume signal time (20ms - infinity) usb 2.0 spec 7.1.7.7
- trsmrcy: resume recovery time (10ms) usb
Hi Todd,
[auto build test ERROR on linus/master]
[also build test ERROR on next-20161213]
[cannot apply to usb/usb-testing balbi-usb/next v4.9]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits
Promote a variable keeping track of USB transfer memory usage to a
wider data type and allow for higher bandwidth transfers from a large
number of USB devices connected to a single host.
Signed-off-by: Mateusz Berezecki
---
drivers/usb/core/devio.c | 48
On Tue, Dec 13, 2016 at 6:48 PM, Andy Lutomirski wrote:
> The driver put a constant buffer of all zeros on the stack and
> pointed a scatterlist entry at it in two places. This doesn't work
> with virtual stacks. Use ZERO_PAGE instead.
Wait a second...
> -
The driver put a constant buffer of all zeros on the stack and
pointed a scatterlist entry at it. This doesn't work with virtual
stacks. Use ZERO_PAGE instead.
Cc: sta...@vger.kernel.org # 4.9 only
Reported-by: Eric Biggers
Signed-off-by: Andy Lutomirski
The driver put a constant buffer of all zeros on the stack and
pointed a scatterlist entry at it in two places. This doesn't work
with virtual stacks. Use ZERO_PAGE instead.
Cc: sta...@vger.kernel.org # 4.9 only
Reported-by: Eric Biggers
Signed-off-by: Andy Lutomirski
There's an issue with this one so I need to add a fix and resubmit (it
fails when USB is configured as a module), so please don't accept this
yet.
However I would like to get feedback on whether or not this new approach
looks ok (it includes fixes based on v1 feedback). Thanks.
On Tue,
On Tue, Dec 13, 2016 at 3:51 PM, John Youn wrote:
> On 12/13/2016 3:23 PM, John Stultz wrote:
>> I've found trying to boot Linus' HEAD today on HiKey, I'm hitting the
>> following WARNINGS/panics, which I bisected down to being introduced
>> with 5f54c54b0ba8 ("Add DDMA
The USB resume code in the kernel currently uses a set of hard coded
delay values that are defined in the USB 2.0 spec. Specifically these
three have the most effect on resume time:
- tdrsmdn: resume signal time (20ms - infinity) usb 2.0 spec 7.1.7.7
- trsmrcy: resume recovery time (10ms) usb
add debugfs support for experimenting with USB timing delay
values on the fly. Values are read/written from debugfs at
/sys/kernel/debug/usb/timing.
Signed-off-by: Todd Brandt
---
v2 changes:
- moved the debug code from hub.c to usb.c
- use debugfs instead of
Add a kernel parameter that replaces the USB_RESUME_TIMEOUT
and other hardcoded delay numbers with the USB spec minimums.
The USB subsystem currently uses heavily padded values for TDRSMDN
and TRSTRCY. This patch keeps the current values by default, but if
the kernel is booted with
On Mon, 2016-12-05 at 12:06 +0200, Felipe Balbi wrote:
> Hi,
>
> Todd Brandt writes:
> > Add a module parameter that replaces the USB_RESUME_TIMEOUT
> > and other hardcoded delay numbers with the USB spec minimums.
> > By default the patch retains the current
On Tue, Dec 13, 2016 at 3:51 PM, John Youn wrote:
> On 12/13/2016 3:23 PM, John Stultz wrote:
>> I've found trying to boot Linus' HEAD today on HiKey, I'm hitting the
>> following WARNINGS/panics, which I bisected down to being introduced
>> with 5f54c54b0ba8 ("Add DDMA
Hi!
On 17/11/16 12:43, Sriram Dash wrote:
> From: Arnd Bergmann
>
> The dma ops for dwc3 devices are not set properly. So, use a
> physical device sysdev, which will be inherited from parent,
> to set the hardware / firmware parameters like dma.
>
> Signed-off-by: Arnd Bergmann
On 12/13/2016 3:23 PM, John Stultz wrote:
> I've found trying to boot Linus' HEAD today on HiKey, I'm hitting the
> following WARNINGS/panics, which I bisected down to being introduced
> with 5f54c54b0ba8 ("Add DDMA chain pointers to dwc2_hsotg_ep
> structure").
>
> It seems the issue is calling
Hey John,
Wanted to let you know I'm seeing a new WARNING with HiKey as of
05ee799f2021 ("dwc2: Move gadget settings into core_params").
It doesn't seem to kill the system, but seems odd since that patch
seems to be just moving code around and not changing logic.
Any thoughts?
thanks
-john
[
ping about [PATCH 1/3, 2/3, 3/3]?
OGAWA Hirofumi writes:
> Mathias Nyman writes:
>
>>> - Add xhci_handshake_sleep(), and use it.
>>
>> This seems a but overkill, I'd rather don't have xhci_handshake(),
>> xhci_handshake_sleep() and
I've found trying to boot Linus' HEAD today on HiKey, I'm hitting the
following WARNINGS/panics, which I bisected down to being introduced
with 5f54c54b0ba8 ("Add DDMA chain pointers to dwc2_hsotg_ep
structure").
It seems the issue is calling dma_alloc_coherent() in
dwc2_hsotg_ep_enable() isn't
Hi!
On 17/11/16 12:43, Sriram Dash wrote:
> From: Arnd Bergmann
>
> For xhci-hcd platform device, all the DMA parameters are not
> configured properly, notably dma ops for dwc3 devices. So, set
> the dma for xhci from sysdev. sysdev is pointing to device that
> is known to the
On Tue, Dec 13, 2016 at 4:28 AM, Vardan Mikayelyan
wrote:
> On 12/13/2016 11:12 AM, John Stultz wrote:
>> When removing a USB-A to USB-otg adapter cable, we get a change
>> status irq, and then in dwc2_conn_id_status_change, we
>> erroniously see the
Besiyata Dishmaya,
Iv'e downloaded the specified kernel version, and I confirm that the
bug was fixed... and I managed to complete the file transfer...
thank you Alan and thank you Greg
On Tue, Dec 13, 2016 at 9:55 PM, Alan Stern wrote:
> On Tue, 13 Dec 2016, or dv
Hi!
On 17/11/16 12:43, Sriram Dash wrote:
> From: Arnd Bergmann
>
> The dma mask is correctly set up by the DT probe function, no
> need to override it any more.
>
> Signed-off-by: Arnd Bergmann
> Signed-off-by: Sriram Dash
Successfully
"On Tue, Dec 13, 2016 at 9:09 PM, Alan Stern wrote:
> On Tue, 13 Dec 2016, Dmitry Vyukov wrote:
>
>> On Tue, Dec 13, 2016 at 7:38 PM, Alan Stern
>> wrote:
>> > On Tue, 13 Dec 2016, Dmitry Vyukov wrote:
>> >
>> >> On Tue, Dec 13, 2016 at 4:52
On Tue, 13 Dec 2016, or dv wrote:
> kernel version:
> Linux version 4.8.0-30-generic (buildd@lcy01-08) (gcc version 6.2.0
> 20161005 (Ubuntu 6.2.0-5ubuntu12) ) #32-Ubuntu SMP Fri Dec 2 03:43:27
> UTC 2016
>
> kernel log shows:
> Dec 13 21:31:27 merits kernel: [ 5835.972008] ohci-pci
On Tue, 13 Dec 2016, Dmitry Vyukov wrote:
> On Tue, Dec 13, 2016 at 7:38 PM, Alan Stern wrote:
> > On Tue, 13 Dec 2016, Dmitry Vyukov wrote:
> >
> >> On Tue, Dec 13, 2016 at 4:52 PM, Alan Stern
> >> wrote:
> >> > On Tue, 13 Dec 2016, Dmitry
Andy Lutomirski wrote:
> I don't know whether you're right, but that sounds a bit silly to me.
> This is a *tiny* amount of memory.
Assuming a 1MiB kernel image in 4K pages, that gets you back a couple of pages
I think - useful if you've only got a few MiB of RAM.
David
--
Update README file:
- remove outdated parts
- clarify terminology and general structure
- add some description of vUDC
Signed-off-by: Krzysztof Opasiak
---
tools/usb/usbip/README | 56 +-
1 file changed, 55 insertions(+), 1
kernel version:
Linux version 4.8.0-30-generic (buildd@lcy01-08) (gcc version 6.2.0
20161005 (Ubuntu 6.2.0-5ubuntu12) ) #32-Ubuntu SMP Fri Dec 2 03:43:27
UTC 2016
kernel log shows:
Dec 13 21:31:07 merits kernel: [ 5815.576016] usb 2-9: new full-speed
USB device number 4 using ohci-pci
Dec 13
On Tue, Dec 13, 2016 at 5:24 AM, Alan Stern wrote:
> On Mon, 12 Dec 2016, John Stultz wrote:
>
>> From: Chen Yu
>>
>> The Hi6220's usb controller is limited in that it does not
>> support "Split Transactions", so it does not support communicating
On Fri, Dec 09, 2016 at 05:06:39PM -0200, Sergio Prado wrote:
> Adds the device tree bindings description for Samsung S3C2410 and
> compatible USB device controller.
>
> Signed-off-by: Sergio Prado
> ---
> .../devicetree/bindings/usb/s3c2410-usb.txt| 28
>
On Tue, Dec 13, 2016 at 7:38 PM, Alan Stern wrote:
> On Tue, 13 Dec 2016, Dmitry Vyukov wrote:
>
>> On Tue, Dec 13, 2016 at 4:52 PM, Alan Stern
>> wrote:
>> > On Tue, 13 Dec 2016, Dmitry Vyukov wrote:
>> >
>> >> >> > If it is
>> >> >> > not
On Tue, 13 Dec 2016, Dmitry Vyukov wrote:
> On Tue, Dec 13, 2016 at 4:52 PM, Alan Stern wrote:
> > On Tue, 13 Dec 2016, Dmitry Vyukov wrote:
> >
> >> >> > If it is
> >> >> > not a bug in kernel source code, then it must not produce a WARNING.
> >> >
> >> > What about
On Tue, Dec 13, 2016 at 08:20:56PM +0200, or dv wrote:
> I have a nokia C2 cellphone. when I connect it with a micro usb cable,
> and then try to move a file to the memory card that resides in my cellphone,
> in the middle of the file transfer the device disconnects,
> and then I can't move my
I have a nokia C2 cellphone. when I connect it with a micro usb cable,
and then try to move a file to the memory card that resides in my cellphone,
in the middle of the file transfer the device disconnects,
and then I can't move my mouse,
and the device can't be mounted anymore until reboot...
The following changes since commit e5517c2a5a49ed5e99047008629f1cd60246ea0e:
Linux 4.9-rc7 (2016-11-27 13:08:04 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/
tags/usb-4.10-rc1
for you to fetch changes up to
On Tue, Dec 13, 2016 at 8:45 AM, David Howells wrote:
> Andy Lutomirski wrote:
>
>> After all, rodata is ordinary memory, is backed by struct page, etc.
>
> Is that actually true? I thought some arches excluded the kernel image from
> the page struct
Andy Lutomirski writes:
> On Tue, Dec 13, 2016 at 3:35 AM, Kalle Valo wrote:
>> Andy Lutomirski writes:
>>
>>> Eric Biggers pointed out that the orinoco driver pointed scatterlists
>>> at the stack.
>>>
>>> Fix it by switching from
Andy Lutomirski wrote:
> After all, rodata is ordinary memory, is backed by struct page, etc.
Is that actually true? I thought some arches excluded the kernel image from
the page struct array to make the array consume less memory.
David
--
To unsubscribe from this list:
On Tue, Dec 13, 2016 at 3:35 AM, Kalle Valo wrote:
> Andy Lutomirski writes:
>
>> Eric Biggers pointed out that the orinoco driver pointed scatterlists
>> at the stack.
>>
>> Fix it by switching from ahash to shash. The result should be
>> simpler, faster,
[add some people who might know]
On Tue, Dec 13, 2016 at 4:20 AM, David Laight wrote:
> From: Andy Lutomirski
>> Sent: 12 December 2016 20:53
>> The driver put a constant buffer of all zeros on the stack and
>> pointed a scatterlist entry at it in two places. This
On Tue, Dec 13, 2016 at 4:52 PM, Alan Stern wrote:
> On Tue, 13 Dec 2016, Dmitry Vyukov wrote:
>
>> >> > If it is
>> >> > not a bug in kernel source code, then it must not produce a WARNING.
>> >
>> > What about a memory allocation failure? The memory management part
On Tue, 13 Dec 2016, Dmitry Vyukov wrote:
> >> > If it is
> >> > not a bug in kernel source code, then it must not produce a WARNING.
> >
> > What about a memory allocation failure? The memory management part of
> > the kernel produces a WARNING message if an allocation fails and the
> > caller
On Tue, Dec 13, 2016 at 02:03:08PM +0900, Kim Jaejoong wrote:
> Hi Oliver and Greg
>
> 2016-12-12 19:45 GMT+09:00 Oliver Neukum :
> > On Thu, 2016-12-08 at 16:16 +0100, Greg KH wrote:
> >> On Fri, Dec 09, 2016 at 12:09:46AM +0900, Jae Joong Kim wrote:
> >> > > Do you have a
> Il giorno 13 dic 2016, alle ore 05:22, Alan Stern
> ha scritto:
>
>> On Mon, 12 Dec 2016, Mateusz Berezecki wrote:
>>
>> Promote a variable keeping track of USB transfer memory usage to a
>> wider data type and allow for higher bandwidth transfers from a large
>>
On Mon, Dec 12, 2016 at 11:04 PM, Alan Stern wrote:
> On Mon, 12 Dec 2016, Alan Stern wrote:
>
>> On Mon, 12 Dec 2016, Dmitry Vyukov wrote:
>>
>> > On Mon, Dec 12, 2016 at 10:05 PM, Alan Stern
>> > wrote:
>> > > On Mon, 12 Dec 2016, Andrey
On Tue, Dec 13, 2016 at 2:34 PM, Hans Verkuil wrote:
> Try again, this time with Krzysztof's new email address...
>
>
> On 13/12/16 13:20, Hans Verkuil wrote:
>>
>> Hi Krzysztof,
>>
>> This still seems to be broken with the latest 4.9 kernel, right?
>>
>> Has there been any
On Tue, 13 Dec 2016, Michal Hocko wrote:
> > > That being said, what ep_write_iter does sounds quite stupit. It just
> > > allocates a large continuous buffer which seems to be under user
> > > control... Aka no good! It should do that per pages or something like
> > > that. Something worth
Please do not drop the linux-usb list from CC.
Resending my reply to the list and dropping that (private) sourceforge
list you added from CC.
On Tue, Dec 13, 2016 at 01:47:45PM +0100, Sylvain LG wrote:
> Hello Johan,
>
> I am using the 4.9 kernel provided by Robert C Nelson, from
> Beagleboard
On Mon, 12 Dec 2016, John Stultz wrote:
> From: Chen Yu
>
> The Hi6220's usb controller is limited in that it does not
> support "Split Transactions", so it does not support communicating
> with low-speed and full-speed devices behind a high-speed hub.
>
> Thus it requires
On Mon, 12 Dec 2016, Mateusz Berezecki wrote:
> Promote a variable keeping track of USB transfer memory usage to a
> wider data type and allow for higher bandwidth transfers from a large
> number of USB devices connected to a single host.
> ---
> drivers/usb/core/devio.c | 34
On Mon, 2016-12-12 at 12:54 -0800, Andy Lutomirski wrote:
> smbencrypt() points a scatterlist to the stack, which is breaks if
> CONFIG_VMAP_STACK=y.
>
> Fix it by switching to crypto_cipher_encrypt_one(). The new code
> should be considerably faster as an added benefit.
>
> This code is nearly
Hi,
kbuild test robot <l...@intel.com> writes:
> Hi Felipe,
>
> [auto build test ERROR on usb/usb-testing]
> [also build test ERROR on v4.9 next-20161213]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
>
>
Try again, this time with Krzysztof's new email address...
On 13/12/16 13:20, Hans Verkuil wrote:
Hi Krzysztof,
This still seems to be broken with the latest 4.9 kernel, right?
Has there been any progress on this? Do you have an updated patch series
for me to use?
Regards,
Hans
On
On 12/13/2016 11:12 AM, John Stultz wrote:
> When removing a USB-A to USB-otg adapter cable, we get a change
> status irq, and then in dwc2_conn_id_status_change, we
> erroniously see the GOTGCTL_CONID_B flag set. This causes us to
> get stuck in the "while (!dwc2_is_device_mode(hsotg))" loop,
>
Hi Krzysztof,
This still seems to be broken with the latest 4.9 kernel, right?
Has there been any progress on this? Do you have an updated patch series
for me to use?
Regards,
Hans
On 05/05/16 14:34, Krzysztof Kozlowski wrote:
Hi,
This is a different, second try to fix usb3503+lan
From: Andy Lutomirski
> Sent: 12 December 2016 20:53
> The driver put a constant buffer of all zeros on the stack and
> pointed a scatterlist entry at it in two places. This doesn't work
> with virtual stacks. Use a static 16-byte buffer of zeros instead.
...
I didn't think you could dma from
Hi Felipe,
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.9 next-20161213]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Felipe-Balbi/usb-host-xhci-refactor
Hello!
On 12/12/2016 11:54 PM, Andy Lutomirski wrote:
smbencrypt() points a scatterlist to the stack, which is breaks if
s/is//.
CONFIG_VMAP_STACK=y.
Fix it by switching to crypto_cipher_encrypt_one(). The new code
should be considerably faster as an added benefit.
This code is
Andy Lutomirski writes:
> Eric Biggers pointed out that the orinoco driver pointed scatterlists
> at the stack.
>
> Fix it by switching from ahash to shash. The result should be
> simpler, faster, and more correct.
>
> Cc: sta...@vger.kernel.org # 4.9 only
> Reported-by: Eric
In order to make xhci_hub_control() easier to read,
let's break it into smaller functions. This will aid
maintainability and readability of the code. There
are no functional changes here, just shuffling code
around.
Signed-off-by: Felipe Balbi
---
Hi,
Felipe Balbi writes:
> when getting endpoint type a switch statement looks
> better than a series of if () branches. There are no
> functional changes with this patch, cleanup only.
>
> Signed-off-by: Felipe Balbi
ping here too.
Hi,
Felipe Balbi writes:
> It's unlikely that we will ever know the avg so
> instead of assuming it'll be something really large,
> we will calculate the avg as we go as mentioned in
> XHCI specification section 4.14.1.1.
>
> Signed-off-by: Felipe Balbi
On Mon, 2016-12-12 at 10:55 -0800, Alex Ruiz wrote:
> I noticed it as being an issue when trying to run "rsync" local to
> local. But it effected everything including long times to mount,
> partitioning, ddrescue, and etc.
>
>
> This is the hardware:
While enabling undefined length INCR burst type and INCR16 burst type,
get better write performance on NXP Layerscape platform:
around 3% improvement (from 364MB/s to 375MB/s).
Signed-off-by: Changming Huang
Signed-off-by: Rajesh Bhagat
---
Since the stop endpoint command is timeout, we will halt the xHCI
controller and issuing the usb_hc_died() to report abnormal shutdown
of a host controller, but before that, we should clean up the command
queue to free commands memory and complete the pending commands.
Signed-off-by: Baolin Wang
On Mon 12-12-16 16:12:16, Alan Stern wrote:
> On Mon, 12 Dec 2016, Michal Hocko wrote:
>
> > On Mon 12-12-16 21:32:35, Andrey Konovalov wrote:
> > > On Mon, Dec 12, 2016 at 9:31 PM, Andrey Konovalov
> > > wrote:
> > > > Hi!
> > > >
> > > > While running the syzkaller
70 matches
Mail list logo