Re: [PATCH v3 1/2] USB: add switch to turn off padding of resume time delays

2016-12-13 Thread kbuild test robot
Hi Todd, [auto build test ERROR on linus/master] [also build test ERROR on next-20161214] [cannot apply to usb/usb-testing balbi-usb/next v4.9] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2] keys/encrypted: Fix two crypto-on-the-stack bugs

2016-12-13 Thread Herbert Xu
On Tue, Dec 13, 2016 at 06:53:03PM -0800, Andy Lutomirski wrote: > On Tue, Dec 13, 2016 at 6:48 PM, Andy Lutomirski wrote: > > The driver put a constant buffer of all zeros on the stack and > > pointed a scatterlist entry at it in two places. This doesn't work > > with virtual

[PATCH v3 1/2] USB: add switch to turn off padding of resume time delays

2016-12-13 Thread Todd Brandt
Add a kernel parameter that replaces the USB_RESUME_TIMEOUT and other hardcoded delay numbers with the USB spec minimums. The USB subsystem currently uses heavily padded values for TDRSMDN and TRSTRCY. This patch keeps the current values by default, but if the kernel is booted with

[PATCH v3 2/2] USB: usb resume time delay debug

2016-12-13 Thread Todd Brandt
add debugfs support for experimenting with USB timing delay values on the fly. Values are read/written from debugfs at /sys/kernel/debug/usb/timing. Signed-off-by: Todd Brandt --- drivers/usb/core/usb.c | 55 ++ 1

[PATCH v3 0/2] USB: resume time optimization by using spec minimums

2016-12-13 Thread Todd Brandt
The USB resume code in the kernel currently uses a set of hard coded delay values that are defined in the USB 2.0 spec. Specifically these three have the most effect on resume time: - tdrsmdn: resume signal time (20ms - infinity) usb 2.0 spec 7.1.7.7 - trsmrcy: resume recovery time (10ms) usb

Re: [PATCH v2 1/2] USB: add switch to turn off padding of resume time delays

2016-12-13 Thread kbuild test robot
Hi Todd, [auto build test ERROR on linus/master] [also build test ERROR on next-20161213] [cannot apply to usb/usb-testing balbi-usb/next v4.9] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

[PATCH v2 1/1] Increase USB transfer limit

2016-12-13 Thread Mateusz Berezecki
Promote a variable keeping track of USB transfer memory usage to a wider data type and allow for higher bandwidth transfers from a large number of USB devices connected to a single host. Signed-off-by: Mateusz Berezecki --- drivers/usb/core/devio.c | 48

Re: [PATCH v2] keys/encrypted: Fix two crypto-on-the-stack bugs

2016-12-13 Thread Andy Lutomirski
On Tue, Dec 13, 2016 at 6:48 PM, Andy Lutomirski wrote: > The driver put a constant buffer of all zeros on the stack and > pointed a scatterlist entry at it in two places. This doesn't work > with virtual stacks. Use ZERO_PAGE instead. Wait a second... > -

[PATCH v2] wusbcore: Fix one more crypto-on-the-stack bug

2016-12-13 Thread Andy Lutomirski
The driver put a constant buffer of all zeros on the stack and pointed a scatterlist entry at it. This doesn't work with virtual stacks. Use ZERO_PAGE instead. Cc: sta...@vger.kernel.org # 4.9 only Reported-by: Eric Biggers Signed-off-by: Andy Lutomirski

[PATCH v2] keys/encrypted: Fix two crypto-on-the-stack bugs

2016-12-13 Thread Andy Lutomirski
The driver put a constant buffer of all zeros on the stack and pointed a scatterlist entry at it in two places. This doesn't work with virtual stacks. Use ZERO_PAGE instead. Cc: sta...@vger.kernel.org # 4.9 only Reported-by: Eric Biggers Signed-off-by: Andy Lutomirski

Re: [PATCH v2 0/2] USB: resume time optimization by using spec minimums

2016-12-13 Thread Todd Brandt
There's an issue with this one so I need to add a fix and resubmit (it fails when USB is configured as a module), so please don't accept this yet. However I would like to get feedback on whether or not this new approach looks ok (it includes fixes based on v1 feedback). Thanks. On Tue,

Re: [REGRESSION] dwc2: 5f54c54b0ba8 Add DDMA chain pointers to dwc2_hsotg_ep structure

2016-12-13 Thread John Stultz
On Tue, Dec 13, 2016 at 3:51 PM, John Youn wrote: > On 12/13/2016 3:23 PM, John Stultz wrote: >> I've found trying to boot Linus' HEAD today on HiKey, I'm hitting the >> following WARNINGS/panics, which I bisected down to being introduced >> with 5f54c54b0ba8 ("Add DDMA

[PATCH v2 0/2] USB: resume time optimization by using spec minimums

2016-12-13 Thread Todd Brandt
The USB resume code in the kernel currently uses a set of hard coded delay values that are defined in the USB 2.0 spec. Specifically these three have the most effect on resume time: - tdrsmdn: resume signal time (20ms - infinity) usb 2.0 spec 7.1.7.7 - trsmrcy: resume recovery time (10ms) usb

[PATCH v2 2/2] USB: usb resume time delay debug

2016-12-13 Thread Todd Brandt
add debugfs support for experimenting with USB timing delay values on the fly. Values are read/written from debugfs at /sys/kernel/debug/usb/timing. Signed-off-by: Todd Brandt --- v2 changes: - moved the debug code from hub.c to usb.c - use debugfs instead of

[PATCH v2 1/2] USB: add switch to turn off padding of resume time delays

2016-12-13 Thread Todd Brandt
Add a kernel parameter that replaces the USB_RESUME_TIMEOUT and other hardcoded delay numbers with the USB spec minimums. The USB subsystem currently uses heavily padded values for TDRSMDN and TRSTRCY. This patch keeps the current values by default, but if the kernel is booted with

Re: [PATCH 1/2] USB: turn off padding of resume time delays

2016-12-13 Thread Todd Brandt
On Mon, 2016-12-05 at 12:06 +0200, Felipe Balbi wrote: > Hi, > > Todd Brandt writes: > > Add a module parameter that replaces the USB_RESUME_TIMEOUT > > and other hardcoded delay numbers with the USB spec minimums. > > By default the patch retains the current

Re: [REGRESSION] dwc2: 5f54c54b0ba8 Add DDMA chain pointers to dwc2_hsotg_ep structure

2016-12-13 Thread John Stultz
On Tue, Dec 13, 2016 at 3:51 PM, John Youn wrote: > On 12/13/2016 3:23 PM, John Stultz wrote: >> I've found trying to boot Linus' HEAD today on HiKey, I'm hitting the >> following WARNINGS/panics, which I bisected down to being introduced >> with 5f54c54b0ba8 ("Add DDMA

Re: [v5,5/6] usb: dwc3: use bus->sysdev for DMA configuration

2016-12-13 Thread Alexander Sverdlin
Hi! On 17/11/16 12:43, Sriram Dash wrote: > From: Arnd Bergmann > > The dma ops for dwc3 devices are not set properly. So, use a > physical device sysdev, which will be inherited from parent, > to set the hardware / firmware parameters like dma. > > Signed-off-by: Arnd Bergmann

Re: [REGRESSION] dwc2: 5f54c54b0ba8 Add DDMA chain pointers to dwc2_hsotg_ep structure

2016-12-13 Thread John Youn
On 12/13/2016 3:23 PM, John Stultz wrote: > I've found trying to boot Linus' HEAD today on HiKey, I'm hitting the > following WARNINGS/panics, which I bisected down to being introduced > with 5f54c54b0ba8 ("Add DDMA chain pointers to dwc2_hsotg_ep > structure"). > > It seems the issue is calling

[REGRESSION?] 05ee799f2021 dwc2: Move gadget settings into core_params

2016-12-13 Thread John Stultz
Hey John, Wanted to let you know I'm seeing a new WARNING with HiKey as of 05ee799f2021 ("dwc2: Move gadget settings into core_params"). It doesn't seem to kill the system, but seems odd since that patch seems to be just moving code around and not changing logic. Any thoughts? thanks -john [

Re: [PATCH 3/3] xhci: Remove busy loop from xhci_abort_cmd_ring()

2016-12-13 Thread OGAWA Hirofumi
ping about [PATCH 1/3, 2/3, 3/3]? OGAWA Hirofumi writes: > Mathias Nyman writes: > >>> - Add xhci_handshake_sleep(), and use it. >> >> This seems a but overkill, I'd rather don't have xhci_handshake(), >> xhci_handshake_sleep() and

[REGRESSION] dwc2: 5f54c54b0ba8 Add DDMA chain pointers to dwc2_hsotg_ep structure

2016-12-13 Thread John Stultz
I've found trying to boot Linus' HEAD today on HiKey, I'm hitting the following WARNINGS/panics, which I bisected down to being introduced with 5f54c54b0ba8 ("Add DDMA chain pointers to dwc2_hsotg_ep structure"). It seems the issue is calling dma_alloc_coherent() in dwc2_hsotg_ep_enable() isn't

Re: [v5,4/6] usb: xhci: use bus->sysdev for DMA configuration

2016-12-13 Thread Alexander Sverdlin
Hi! On 17/11/16 12:43, Sriram Dash wrote: > From: Arnd Bergmann > > For xhci-hcd platform device, all the DMA parameters are not > configured properly, notably dma ops for dwc3 devices. So, set > the dma for xhci from sysdev. sysdev is pointing to device that > is known to the

Re: [RFC][PATCH 2/5] usb: dwc2: Workaround case where GOTGCTL state is wrong

2016-12-13 Thread John Stultz
On Tue, Dec 13, 2016 at 4:28 AM, Vardan Mikayelyan wrote: > On 12/13/2016 11:12 AM, John Stultz wrote: >> When removing a USB-A to USB-otg adapter cable, we get a change >> status irq, and then in dwc2_conn_id_status_change, we >> erroniously see the

Re: Fwd: usb cellphone storage device disconnection causes my usb mouse to be disconnected

2016-12-13 Thread or dv
Besiyata Dishmaya, Iv'e downloaded the specified kernel version, and I confirm that the bug was fixed... and I managed to complete the file transfer... thank you Alan and thank you Greg On Tue, Dec 13, 2016 at 9:55 PM, Alan Stern wrote: > On Tue, 13 Dec 2016, or dv

Re: [v5,6/6] usb: dwc3: Do not set dma coherent mask

2016-12-13 Thread Alexander Sverdlin
Hi! On 17/11/16 12:43, Sriram Dash wrote: > From: Arnd Bergmann > > The dma mask is correctly set up by the DT probe function, no > need to override it any more. > > Signed-off-by: Arnd Bergmann > Signed-off-by: Sriram Dash Successfully

Re: usb/core: warning in usb_create_ep_devs/sysfs_create_dir_ns

2016-12-13 Thread Dmitry Vyukov
"On Tue, Dec 13, 2016 at 9:09 PM, Alan Stern wrote: > On Tue, 13 Dec 2016, Dmitry Vyukov wrote: > >> On Tue, Dec 13, 2016 at 7:38 PM, Alan Stern >> wrote: >> > On Tue, 13 Dec 2016, Dmitry Vyukov wrote: >> > >> >> On Tue, Dec 13, 2016 at 4:52

Re: Fwd: usb cellphone storage device disconnection causes my usb mouse to be disconnected

2016-12-13 Thread Alan Stern
On Tue, 13 Dec 2016, or dv wrote: > kernel version: > Linux version 4.8.0-30-generic (buildd@lcy01-08) (gcc version 6.2.0 > 20161005 (Ubuntu 6.2.0-5ubuntu12) ) #32-Ubuntu SMP Fri Dec 2 03:43:27 > UTC 2016 > > kernel log shows: > Dec 13 21:31:27 merits kernel: [ 5835.972008] ohci-pci

Re: usb/core: warning in usb_create_ep_devs/sysfs_create_dir_ns

2016-12-13 Thread Alan Stern
On Tue, 13 Dec 2016, Dmitry Vyukov wrote: > On Tue, Dec 13, 2016 at 7:38 PM, Alan Stern wrote: > > On Tue, 13 Dec 2016, Dmitry Vyukov wrote: > > > >> On Tue, Dec 13, 2016 at 4:52 PM, Alan Stern > >> wrote: > >> > On Tue, 13 Dec 2016, Dmitry

Re: [PATCH] keys/encrypted: Fix two crypto-on-the-stack bugs

2016-12-13 Thread David Howells
Andy Lutomirski wrote: > I don't know whether you're right, but that sounds a bit silly to me. > This is a *tiny* amount of memory. Assuming a 1MiB kernel image in 4K pages, that gets you back a couple of pages I think - useful if you've only got a few MiB of RAM. David --

[PATCH] tools: usb: usbip: Update README

2016-12-13 Thread Krzysztof Opasiak
Update README file: - remove outdated parts - clarify terminology and general structure - add some description of vUDC Signed-off-by: Krzysztof Opasiak --- tools/usb/usbip/README | 56 +- 1 file changed, 55 insertions(+), 1

Re: Fwd: usb cellphone storage device disconnection causes my usb mouse to be disconnected

2016-12-13 Thread or dv
kernel version: Linux version 4.8.0-30-generic (buildd@lcy01-08) (gcc version 6.2.0 20161005 (Ubuntu 6.2.0-5ubuntu12) ) #32-Ubuntu SMP Fri Dec 2 03:43:27 UTC 2016 kernel log shows: Dec 13 21:31:07 merits kernel: [ 5815.576016] usb 2-9: new full-speed USB device number 4 using ohci-pci Dec 13

Re: [RFC][PATCH 5/5] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220

2016-12-13 Thread John Stultz
On Tue, Dec 13, 2016 at 5:24 AM, Alan Stern wrote: > On Mon, 12 Dec 2016, John Stultz wrote: > >> From: Chen Yu >> >> The Hi6220's usb controller is limited in that it does not >> support "Split Transactions", so it does not support communicating

Re: [PATCH 1/2] dt-bindings: usb: add DT binding for s3c2410 USB device controller

2016-12-13 Thread Rob Herring
On Fri, Dec 09, 2016 at 05:06:39PM -0200, Sergio Prado wrote: > Adds the device tree bindings description for Samsung S3C2410 and > compatible USB device controller. > > Signed-off-by: Sergio Prado > --- > .../devicetree/bindings/usb/s3c2410-usb.txt| 28 >

Re: usb/core: warning in usb_create_ep_devs/sysfs_create_dir_ns

2016-12-13 Thread Dmitry Vyukov
On Tue, Dec 13, 2016 at 7:38 PM, Alan Stern wrote: > On Tue, 13 Dec 2016, Dmitry Vyukov wrote: > >> On Tue, Dec 13, 2016 at 4:52 PM, Alan Stern >> wrote: >> > On Tue, 13 Dec 2016, Dmitry Vyukov wrote: >> > >> >> >> > If it is >> >> >> > not

Re: usb/core: warning in usb_create_ep_devs/sysfs_create_dir_ns

2016-12-13 Thread Alan Stern
On Tue, 13 Dec 2016, Dmitry Vyukov wrote: > On Tue, Dec 13, 2016 at 4:52 PM, Alan Stern wrote: > > On Tue, 13 Dec 2016, Dmitry Vyukov wrote: > > > >> >> > If it is > >> >> > not a bug in kernel source code, then it must not produce a WARNING. > >> > > >> > What about

Re: Fwd: usb cellphone storage device disconnection causes my usb mouse to be disconnected

2016-12-13 Thread Greg KH
On Tue, Dec 13, 2016 at 08:20:56PM +0200, or dv wrote: > I have a nokia C2 cellphone. when I connect it with a micro usb cable, > and then try to move a file to the memory card that resides in my cellphone, > in the middle of the file transfer the device disconnects, > and then I can't move my

Fwd: usb cellphone storage device disconnection causes my usb mouse to be disconnected

2016-12-13 Thread or dv
I have a nokia C2 cellphone. when I connect it with a micro usb cable, and then try to move a file to the memory card that resides in my cellphone, in the middle of the file transfer the device disconnects, and then I can't move my mouse, and the device can't be mounted anymore until reboot...

[GIT PULL] USB/PHY driver changes patches for 4.10-rc1

2016-12-13 Thread Greg KH
The following changes since commit e5517c2a5a49ed5e99047008629f1cd60246ea0e: Linux 4.9-rc7 (2016-11-27 13:08:04 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.10-rc1 for you to fetch changes up to

Re: [PATCH] keys/encrypted: Fix two crypto-on-the-stack bugs

2016-12-13 Thread Andy Lutomirski
On Tue, Dec 13, 2016 at 8:45 AM, David Howells wrote: > Andy Lutomirski wrote: > >> After all, rodata is ordinary memory, is backed by struct page, etc. > > Is that actually true? I thought some arches excluded the kernel image from > the page struct

Re: [PATCH] orinoco: Use shash instead of ahash for MIC calculations

2016-12-13 Thread Kalle Valo
Andy Lutomirski writes: > On Tue, Dec 13, 2016 at 3:35 AM, Kalle Valo wrote: >> Andy Lutomirski writes: >> >>> Eric Biggers pointed out that the orinoco driver pointed scatterlists >>> at the stack. >>> >>> Fix it by switching from

Re: [PATCH] keys/encrypted: Fix two crypto-on-the-stack bugs

2016-12-13 Thread David Howells
Andy Lutomirski wrote: > After all, rodata is ordinary memory, is backed by struct page, etc. Is that actually true? I thought some arches excluded the kernel image from the page struct array to make the array consume less memory. David -- To unsubscribe from this list:

Re: [PATCH] orinoco: Use shash instead of ahash for MIC calculations

2016-12-13 Thread Andy Lutomirski
On Tue, Dec 13, 2016 at 3:35 AM, Kalle Valo wrote: > Andy Lutomirski writes: > >> Eric Biggers pointed out that the orinoco driver pointed scatterlists >> at the stack. >> >> Fix it by switching from ahash to shash. The result should be >> simpler, faster,

Re: [PATCH] keys/encrypted: Fix two crypto-on-the-stack bugs

2016-12-13 Thread Andy Lutomirski
[add some people who might know] On Tue, Dec 13, 2016 at 4:20 AM, David Laight wrote: > From: Andy Lutomirski >> Sent: 12 December 2016 20:53 >> The driver put a constant buffer of all zeros on the stack and >> pointed a scatterlist entry at it in two places. This

Re: usb/core: warning in usb_create_ep_devs/sysfs_create_dir_ns

2016-12-13 Thread Dmitry Vyukov
On Tue, Dec 13, 2016 at 4:52 PM, Alan Stern wrote: > On Tue, 13 Dec 2016, Dmitry Vyukov wrote: > >> >> > If it is >> >> > not a bug in kernel source code, then it must not produce a WARNING. >> > >> > What about a memory allocation failure? The memory management part

Re: usb/core: warning in usb_create_ep_devs/sysfs_create_dir_ns

2016-12-13 Thread Alan Stern
On Tue, 13 Dec 2016, Dmitry Vyukov wrote: > >> > If it is > >> > not a bug in kernel source code, then it must not produce a WARNING. > > > > What about a memory allocation failure? The memory management part of > > the kernel produces a WARNING message if an allocation fails and the > > caller

Re: add URB_ZERO_PACKET in transfer_flags for usb-skeleton.c

2016-12-13 Thread Greg KH
On Tue, Dec 13, 2016 at 02:03:08PM +0900, Kim Jaejoong wrote: > Hi Oliver and Greg > > 2016-12-12 19:45 GMT+09:00 Oliver Neukum : > > On Thu, 2016-12-08 at 16:16 +0100, Greg KH wrote: > >> On Fri, Dec 09, 2016 at 12:09:46AM +0900, Jae Joong Kim wrote: > >> > > Do you have a

Re: [PATCH v2 1/1] Increase USB transfer limit

2016-12-13 Thread Mateusz Berezecki
> Il giorno 13 dic 2016, alle ore 05:22, Alan Stern > ha scritto: > >> On Mon, 12 Dec 2016, Mateusz Berezecki wrote: >> >> Promote a variable keeping track of USB transfer memory usage to a >> wider data type and allow for higher bandwidth transfers from a large >>

Re: usb/core: warning in usb_create_ep_devs/sysfs_create_dir_ns

2016-12-13 Thread Dmitry Vyukov
On Mon, Dec 12, 2016 at 11:04 PM, Alan Stern wrote: > On Mon, 12 Dec 2016, Alan Stern wrote: > >> On Mon, 12 Dec 2016, Dmitry Vyukov wrote: >> >> > On Mon, Dec 12, 2016 at 10:05 PM, Alan Stern >> > wrote: >> > > On Mon, 12 Dec 2016, Andrey

Re: [RFC v2 00/13] usb/mmc/power: Fix USB/LAN when TFTP booting

2016-12-13 Thread Krzysztof Kozlowski
On Tue, Dec 13, 2016 at 2:34 PM, Hans Verkuil wrote: > Try again, this time with Krzysztof's new email address... > > > On 13/12/16 13:20, Hans Verkuil wrote: >> >> Hi Krzysztof, >> >> This still seems to be broken with the latest 4.9 kernel, right? >> >> Has there been any

Re: usb/gadget: warning in ep_write_iter/__alloc_pages_nodemask

2016-12-13 Thread Alan Stern
On Tue, 13 Dec 2016, Michal Hocko wrote: > > > That being said, what ep_write_iter does sounds quite stupit. It just > > > allocates a large continuous buffer which seems to be under user > > > control... Aka no good! It should do that per pages or something like > > > that. Something worth

Re: FTD driverI issue?

2016-12-13 Thread Johan Hovold
Please do not drop the linux-usb list from CC. Resending my reply to the list and dropping that (private) sourceforge list you added from CC. On Tue, Dec 13, 2016 at 01:47:45PM +0100, Sylvain LG wrote: > Hello Johan, > > I am using the 4.9 kernel provided by Robert C Nelson, from > Beagleboard

Re: [RFC][PATCH 5/5] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220

2016-12-13 Thread Alan Stern
On Mon, 12 Dec 2016, John Stultz wrote: > From: Chen Yu > > The Hi6220's usb controller is limited in that it does not > support "Split Transactions", so it does not support communicating > with low-speed and full-speed devices behind a high-speed hub. > > Thus it requires

Re: [PATCH v2 1/1] Increase USB transfer limit

2016-12-13 Thread Alan Stern
On Mon, 12 Dec 2016, Mateusz Berezecki wrote: > Promote a variable keeping track of USB transfer memory usage to a > wider data type and allow for higher bandwidth transfers from a large > number of USB devices connected to a single host. > --- > drivers/usb/core/devio.c | 34

Re: [PATCH] cifs: Fix smbencrypt() to stop pointing a scatterlist at the stack

2016-12-13 Thread Jeff Layton
On Mon, 2016-12-12 at 12:54 -0800, Andy Lutomirski wrote: > smbencrypt() points a scatterlist to the stack, which is breaks if > CONFIG_VMAP_STACK=y. > > Fix it by switching to crypto_cipher_encrypt_one(). The new code > should be considerably faster as an added benefit. > > This code is nearly

Re: [PATCH] usb: host: xhci: refactor xhci_hub_control()

2016-12-13 Thread Felipe Balbi
Hi, kbuild test robot <l...@intel.com> writes: > Hi Felipe, > > [auto build test ERROR on usb/usb-testing] > [also build test ERROR on v4.9 next-20161213] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > >

Re: [RFC v2 00/13] usb/mmc/power: Fix USB/LAN when TFTP booting

2016-12-13 Thread Hans Verkuil
Try again, this time with Krzysztof's new email address... On 13/12/16 13:20, Hans Verkuil wrote: Hi Krzysztof, This still seems to be broken with the latest 4.9 kernel, right? Has there been any progress on this? Do you have an updated patch series for me to use? Regards, Hans On

Re: [RFC][PATCH 2/5] usb: dwc2: Workaround case where GOTGCTL state is wrong

2016-12-13 Thread Vardan Mikayelyan
On 12/13/2016 11:12 AM, John Stultz wrote: > When removing a USB-A to USB-otg adapter cable, we get a change > status irq, and then in dwc2_conn_id_status_change, we > erroniously see the GOTGCTL_CONID_B flag set. This causes us to > get stuck in the "while (!dwc2_is_device_mode(hsotg))" loop, >

Re: [RFC v2 00/13] usb/mmc/power: Fix USB/LAN when TFTP booting

2016-12-13 Thread Hans Verkuil
Hi Krzysztof, This still seems to be broken with the latest 4.9 kernel, right? Has there been any progress on this? Do you have an updated patch series for me to use? Regards, Hans On 05/05/16 14:34, Krzysztof Kozlowski wrote: Hi, This is a different, second try to fix usb3503+lan

RE: [PATCH] keys/encrypted: Fix two crypto-on-the-stack bugs

2016-12-13 Thread David Laight
From: Andy Lutomirski > Sent: 12 December 2016 20:53 > The driver put a constant buffer of all zeros on the stack and > pointed a scatterlist entry at it in two places. This doesn't work > with virtual stacks. Use a static 16-byte buffer of zeros instead. ... I didn't think you could dma from

Re: [PATCH] usb: host: xhci: refactor xhci_hub_control()

2016-12-13 Thread kbuild test robot
Hi Felipe, [auto build test ERROR on usb/usb-testing] [also build test ERROR on v4.9 next-20161213] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Felipe-Balbi/usb-host-xhci-refactor

Re: [PATCH] cifs: Fix smbencrypt() to stop pointing a scatterlist at the stack

2016-12-13 Thread Sergei Shtylyov
Hello! On 12/12/2016 11:54 PM, Andy Lutomirski wrote: smbencrypt() points a scatterlist to the stack, which is breaks if s/is//. CONFIG_VMAP_STACK=y. Fix it by switching to crypto_cipher_encrypt_one(). The new code should be considerably faster as an added benefit. This code is

Re: [PATCH] orinoco: Use shash instead of ahash for MIC calculations

2016-12-13 Thread Kalle Valo
Andy Lutomirski writes: > Eric Biggers pointed out that the orinoco driver pointed scatterlists > at the stack. > > Fix it by switching from ahash to shash. The result should be > simpler, faster, and more correct. > > Cc: sta...@vger.kernel.org # 4.9 only > Reported-by: Eric

[PATCH] usb: host: xhci: refactor xhci_hub_control()

2016-12-13 Thread Felipe Balbi
In order to make xhci_hub_control() easier to read, let's break it into smaller functions. This will aid maintainability and readability of the code. There are no functional changes here, just shuffling code around. Signed-off-by: Felipe Balbi ---

Re: [PATCH 2/2] usb: xhci: mem: convert to a switch statement

2016-12-13 Thread Felipe Balbi
Hi, Felipe Balbi writes: > when getting endpoint type a switch statement looks > better than a series of if () branches. There are no > functional changes with this patch, cleanup only. > > Signed-off-by: Felipe Balbi ping here too.

Re: [PATCH 1/2] usb: xhci: switch to running avg trb length

2016-12-13 Thread Felipe Balbi
Hi, Felipe Balbi writes: > It's unlikely that we will ever know the avg so > instead of assuming it'll be something really large, > we will calculate the avg as we go as mentioned in > XHCI specification section 4.14.1.1. > > Signed-off-by: Felipe Balbi

Re: Fwd: UAS erorrs

2016-12-13 Thread Oliver Neukum
On Mon, 2016-12-12 at 10:55 -0800, Alex Ruiz wrote: > I noticed it as being an issue when trying to run "rsync" local to > local. But it effected everything including long times to mount, > partitioning, ddrescue, and etc. > > > This is the hardware:

[PATCH] USB3/DWC3: Enable undefined length INCR burst type

2016-12-13 Thread Changming Huang
While enabling undefined length INCR burst type and INCR16 burst type, get better write performance on NXP Layerscape platform: around 3% improvement (from 364MB/s to 375MB/s). Signed-off-by: Changming Huang Signed-off-by: Rajesh Bhagat ---

[PATCH] usb: host: xhci: Clean up commands when stop endpoint command is timeout

2016-12-13 Thread Baolin Wang
Since the stop endpoint command is timeout, we will halt the xHCI controller and issuing the usb_hc_died() to report abnormal shutdown of a host controller, but before that, we should clean up the command queue to free commands memory and complete the pending commands. Signed-off-by: Baolin Wang

Re: usb/gadget: warning in ep_write_iter/__alloc_pages_nodemask

2016-12-13 Thread Michal Hocko
On Mon 12-12-16 16:12:16, Alan Stern wrote: > On Mon, 12 Dec 2016, Michal Hocko wrote: > > > On Mon 12-12-16 21:32:35, Andrey Konovalov wrote: > > > On Mon, Dec 12, 2016 at 9:31 PM, Andrey Konovalov > > > wrote: > > > > Hi! > > > > > > > > While running the syzkaller