Re: [RFC PATCH] staging: typec: Intel WhiskeyCove PMIC USB Type-C PHY driver

2017-05-26 Thread Guenter Roeck
On 05/26/2017 11:39 AM, Greg Kroah-Hartman wrote: On Fri, May 26, 2017 at 03:53:49PM +0300, Heikki Krogerus wrote: Hi, My two cents. On Thu, May 25, 2017 at 10:12:27AM -0700, Guenter Roeck wrote: What is keeping this code in staging at the moment? Who isn't agreeing on the existing apis we

Re: [PATCHv4] usb: typec: Add a sysfs node to manage port type

2017-05-26 Thread Greg Kroah-Hartman
On Fri, May 26, 2017 at 01:42:57PM -0700, Badhri Jagan Sridharan wrote: > User space applications in some cases have the need to enforce a > specific port type(DFP/UFP/DRP). This change allows userspace to > attempt setting the desired port type. Low level drivers can > however reject the request

[PATCH] usb: dwc2: resume root hub to handle disconnect of device

2017-05-26 Thread William Wu
When handle disconnect of the hcd during bus_suspend, hcd needs to resume its root hub, otherwise the root hub will not disconnect the existing devices under its port. This issue always happens when connecting with usb devices which support auto-suspend function (e.g. usb hub). Signed-off-by:

Re: [PATCH v4] usb: typec: Add a sysfs node to manage port type

2017-05-26 Thread Guenter Roeck
On 05/26/2017 04:07 PM, Badhri Jagan Sridharan wrote: User space applications in some cases have the need to enforce a specific port type(DFP/UFP/DRP). This change allows userspace to attempt setting the desired port type. Low level drivers can however reject the request if the specific port

[PATCHv4] usb: typec: Add a sysfs node to manage port type

2017-05-26 Thread Badhri Jagan Sridharan
User space applications in some cases have the need to enforce a specific port type(DFP/UFP/DRP). This change allows userspace to attempt setting the desired port type. Low level drivers can however reject the request if the specific port type is not supported. Signed-off-by: Badhri Jagan

Re: [PATCHv3] usb: typec: Add a sysfs node to manage port type

2017-05-26 Thread Badhri Jagan Sridharan
On Fri, May 26, 2017 at 11:31 AM, Greg Kroah-Hartman wrote: > On Fri, May 26, 2017 at 10:45:59AM -0700, Badhri Jagan Sridharan wrote: >> User space applications in some cases have the need to enforce a >> specific port type(DFP/UFP/DRP). This change allows userspace to

[PATCH v4] usb: typec: Add a sysfs node to manage port type

2017-05-26 Thread Badhri Jagan Sridharan
User space applications in some cases have the need to enforce a specific port type(DFP/UFP/DRP). This change allows userspace to attempt setting the desired port type. Low level drivers can however reject the request if the specific port type is not supported. Signed-off-by: Badhri Jagan

Re: [PATCHv3] usb: typec: Add a sysfs node to manage port type

2017-05-26 Thread Badhri Jagan Sridharan
On Fri, May 26, 2017 at 11:00 AM, Guenter Roeck wrote: > On Fri, May 26, 2017 at 10:45:59AM -0700, Badhri Jagan Sridharan wrote: >> User space applications in some cases have the need to enforce a >> specific port type(DFP/UFP/DRP). This change allows userspace to >> attempt

[PATCH v1] usb: host: xhci: reliable endpoint reset after halt

2017-05-26 Thread gavinli
From: Gavin Li If a stalling TRB is cancelled and NOOP'ed in xhci_handle_cmd_stop_ep(), finish_td() never gets called to reset the halted endpoint and the endpoint remains indefinitely stalled. This patch ensures that xhci_cleanup_halted_endpoint() is called after a TRB

Re: [PATCH 3/3] usb: max3421-hcd: Remove function name from dev_dbg calls

2017-05-26 Thread Greg Kroah-Hartman
On Fri, May 26, 2017 at 02:32:42PM +0300, Alexander Amelkin wrote: > NOTE: > Please don't use the plain text here as a patch because it most probably is > corrupted by my webmail client. > Attached is a copy of the following text guaranteed to have correct > tabs/spaces. Why is this here

Re: [GIT][PULL] Improvements to max3421-hcd driver

2017-05-26 Thread Greg Kroah-Hartman
On Fri, May 26, 2017 at 02:22:47PM +0300, Alexander Amelkin wrote: > The following changes since commit 08332893e37af6ae779367e78e444f8f9571511d: > > Linux 4.12-rc2 (2017-05-21 19:30:23 -0700) > > are available in the git repository at: > >

Re: [RFC PATCH] staging: typec: Intel WhiskeyCove PMIC USB Type-C PHY driver

2017-05-26 Thread Greg Kroah-Hartman
On Fri, May 26, 2017 at 03:53:49PM +0300, Heikki Krogerus wrote: > Hi, > > My two cents. > > On Thu, May 25, 2017 at 10:12:27AM -0700, Guenter Roeck wrote: > > > What is keeping this code in staging at the moment? Who isn't agreeing > > > on the existing apis we have there? > > > > > > > I

Re: [PATCHv3] usb: typec: Add a sysfs node to manage port type

2017-05-26 Thread Greg Kroah-Hartman
On Fri, May 26, 2017 at 10:45:59AM -0700, Badhri Jagan Sridharan wrote: > User space applications in some cases have the need to enforce a > specific port type(DFP/UFP/DRP). This change allows userspace to > attempt setting the desired port type. Low level drivers can > however reject the request

Re: [PATCHv3] usb: typec: Add a sysfs node to manage port type

2017-05-26 Thread Guenter Roeck
On Fri, May 26, 2017 at 10:45:59AM -0700, Badhri Jagan Sridharan wrote: > User space applications in some cases have the need to enforce a > specific port type(DFP/UFP/DRP). This change allows userspace to > attempt setting the desired port type. Low level drivers can > however reject the request

[PATCHv3] usb: typec: Add a sysfs node to manage port type

2017-05-26 Thread Badhri Jagan Sridharan
User space applications in some cases have the need to enforce a specific port type(DFP/UFP/DRP). This change allows userspace to attempt setting the desired port type. Low level drivers can however reject the request if the specific port type is not supported. Signed-off-by: Badhri Jagan

Re: [PATCH v4 3/3] usb: gadget: add f_uac1 variant based on a new u_audio api

2017-05-26 Thread Julian Scheel
On 18.05.2017 00:37, Ruslan Bilovol wrote: This patch adds a new function 'f_uac1_acard' (f_uac1 with virtual "ALSA card") that uses recently created u_audio API. Comparing to legacy f_uac1 function implementation it doesn't require any real Audio codec to be present on the device. In

Re: [PATCH] usb: Make use of ktime_* comparison functions

2017-05-26 Thread Alan Stern
On Fri, 26 May 2017, Mariusz Skamra wrote: > Start using ktime_* compare functions to make the code backportable. > Now that may be a bit tricky due to recent change of ktime_t. > > Signed-off-by: Mariusz Skamra > Acked-by: Kuppuswamy Sathyanarayanan

Re: [PATCH 3/3] usb: typec: ucsi: Add ACPI driver

2017-05-26 Thread Guenter Roeck
On 05/26/2017 04:08 AM, Heikki Krogerus wrote: Hi, On Thu, May 25, 2017 at 06:23:30AM -0700, Guenter Roeck wrote: + /* +* NOTE: The memory region for the data structures is used also in an +* operation region, which means ACPI has already reserved it. Therefore +*

Re: [PATCH 2/3] usb: typec: Add support for UCSI interface

2017-05-26 Thread Guenter Roeck
On 05/26/2017 04:02 AM, Heikki Krogerus wrote: Hi, On Thu, May 25, 2017 at 06:20:16AM -0700, Guenter Roeck wrote: On 05/16/2017 05:26 AM, Heikki Krogerus wrote: UCSI - USB Type-C Connector System Software Interface - is a specification that defines set of registers and data structures for

Re: [RFC PATCH] staging: typec: Intel WhiskeyCove PMIC USB Type-C PHY driver

2017-05-26 Thread Heikki Krogerus
Hi, My two cents. On Thu, May 25, 2017 at 10:12:27AM -0700, Guenter Roeck wrote: > > What is keeping this code in staging at the moment? Who isn't agreeing > > on the existing apis we have there? > > > > I don't think the APIs are at issue; I would not expect any substantial > (if any)

Re: [PATCH] usb: xhci: add quirk flag for broken stop command on AMD platforms

2017-05-26 Thread Mathias Nyman
On 25.05.2017 16:17, Shyam Sundar S K wrote: On 5/22/2017 8:26 PM, Shyam Sundar S K wrote: On 5/22/2017 6:49 PM, Mathias Nyman wrote: On 22.05.2017 11:56, Shyam Sundar S K wrote: Hi Mathias, On 5/19/2017 12:43 PM, Mathias Nyman wrote: On 18.05.2017 16:46, Alan Stern wrote: On Thu, 18

[GIT][PULL] Improvements to max3421-hcd driver

2017-05-26 Thread Alexander Amelkin
The following changes since commit 08332893e37af6ae779367e78e444f8f9571511d: Linux 4.12-rc2 (2017-05-21 19:30:23 -0700) are available in the git repository at: https://github.com/AlexanderAmelkin/linux-wandboard.git tags/max3421-improvements-1 for you to fetch changes up to

[PATCH 3/3] usb: max3421-hcd: Remove function name from dev_dbg calls

2017-05-26 Thread Alexander Amelkin
NOTE: Please don't use the plain text here as a patch because it most probably is corrupted by my webmail client. Attached is a copy of the following text guaranteed to have correct tabs/spaces. - From b9a7559d24c0b2cb6e69124d861a943f79272681 Mon Sep 17 00:00:00 2001

[PATCH 2/3] usb: max3421-hcd: Fix crash on the driver removal

2017-05-26 Thread Alexander Amelkin
NOTE: Please don't use the plain text here as a patch because it most probably is corrupted by my webmail client. Attached is a copy of the following text guaranteed to have correct tabs/spaces. - From 8c4c65d3892df3721474023836216a02e03fb23e Mon Sep 17 00:00:00 2001

[PATCH 1/3] usb: max3421-hcd: Add devicetree support to the driver

2017-05-26 Thread Alexander Amelkin
NOTE: Please don't use the plain text here as a patch because it most probably is corrupted by my webmail client. Attached is a copy of the following text guaranteed to have correct tabs/spaces. - Before this patch the max3421-hcd driver could only use statically

RE: [PATCH v4] usb:host:xhci:USB 3.1 speed

2017-05-26 Thread yd_tseng
Thanks for the hand:) Thanks, YD > -Original Message- > From: Mathias Nyman [mailto:mathias.ny...@linux.intel.com] > Sent: Friday, May 26, 2017 6:50 PM > To: YD; gre...@linuxfoundation.org; mathias.ny...@intel.com; linux- > u...@vger.kernel.org > Cc: yd_ts...@asmedia.com.tw > Subject:

Re: [PATCH 3/3] usb: typec: ucsi: Add ACPI driver

2017-05-26 Thread Heikki Krogerus
Hi, On Thu, May 25, 2017 at 06:23:30AM -0700, Guenter Roeck wrote: > > + /* > > +* NOTE: The memory region for the data structures is used also in an > > +* operation region, which means ACPI has already reserved it. Therefore > > +* it can not be requested here. > > +*/ > > +

Re: [PATCH 2/3] usb: typec: Add support for UCSI interface

2017-05-26 Thread Heikki Krogerus
Hi, On Thu, May 25, 2017 at 06:20:16AM -0700, Guenter Roeck wrote: > On 05/16/2017 05:26 AM, Heikki Krogerus wrote: > > UCSI - USB Type-C Connector System Software Interface - is a > > specification that defines set of registers and data > > structures for controlling the USB Type-C ports. It's >

Re: [PATCH v4] usb:host:xhci:USB 3.1 speed

2017-05-26 Thread Mathias Nyman
On 26.05.2017 13:27, YD wrote: From: YD Tseng One of the xHCI host controllers supports both USB 3.1/3.0 extended speed protocol lists. The content of the lists is shown as below. In xhci-mem.c, the USB 3.1 speed is parsed first, the min_rev of usb3_rhub is set as

RE: [PATCH v3] usb:host:xhci:USB 3.1 speed

2017-05-26 Thread yd_tseng
Update V4 Remove whitespace > -Original Message- > From: YD [mailto:yuhdar.ts...@gmail.com] > Sent: Thursday, May 25, 2017 5:38 PM > To: gre...@linuxfoundation.org; mathias.ny...@intel.com; linux- > u...@vger.kernel.org > Cc: yd_ts...@asmedia.com.tw > Subject: [PATCH v3]

[PATCH v4] usb:host:xhci:USB 3.1 speed

2017-05-26 Thread YD
From: YD Tseng One of the xHCI host controllers supports both USB 3.1/3.0 extended speed protocol lists. The content of the lists is shown as below. In xhci-mem.c, the USB 3.1 speed is parsed first, the min_rev of usb3_rhub is set as 0x10. And then USB 3.0 is parsed.

[PATCH] usb: Make use of ktime_* comparison functions

2017-05-26 Thread Mariusz Skamra
Start using ktime_* compare functions to make the code backportable. Now that may be a bit tricky due to recent change of ktime_t. Signed-off-by: Mariusz Skamra Acked-by: Kuppuswamy Sathyanarayanan ---

Re: [PATCH v2] usb:host:xhci AMD Promontory USB disable port support

2017-05-26 Thread Greg KH
On Fri, May 26, 2017 at 05:35:24PM +0800, Jiahau Chang wrote: > There is some limitation for AMD Promontory xHCI host to disable USB port > function. It will enable USB wake-up function then cause USB disable port > feature to fail. Workaround this issue on Promontory xHCI host is clear >

Re: [PATCH v2] usb:host:xhci AMD Promontory USB disable port support

2017-05-26 Thread Sergei Shtylyov
Hello! On 5/26/2017 12:35 PM, Jiahau Chang wrote: There is some limitation for AMD Promontory xHCI host to disable USB port function. It will enable USB wake-up function then cause USB disable port feature to fail. Workaround this issue on Promontory xHCI host is clear PORT_WAKE_BITS.

[PATCH v2] usb:host:xhci AMD Promontory USB disable port support

2017-05-26 Thread Jiahau Chang
There is some limitation for AMD Promontory xHCI host to disable USB port function. It will enable USB wake-up function then cause USB disable port feature to fail. Workaround this issue on Promontory xHCI host is clear PORT_WAKE_BITS. Signed-off-by: Jiahau Chang

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-05-26 Thread Fabien Lahoudere
Hello I modify ci_hrdc_imx_probe to bypass "data->phy = devm_usb_get_phy_by_phandle(>dev, "fsl,usbphy", 0);". Everything works as expected and call ci_ulpi_init. The problem is that in ci_ulpi_init, before calling "ci->ulpi = ulpi_register_interface(ci->dev, >ulpi_ops);" (to initialize our

Re: [PATCH 1/3] usb: host: ohci-platform: Add basic runtime PM support

2017-05-26 Thread Roger Quadros
On 25/05/17 19:13, Tony Lindgren wrote: > This is needed in preparation of adding support for omap3 and > later OHCI. The runtime PM will only do something on platforms > that implement it. > > Cc: devicet...@vger.kernel.org > Cc: Hans de Goede > Cc: Rob Herring

Re: [PATCH]usb:host:xhci AMD Promontory USB disable port support

2017-05-26 Thread Greg KH
On Fri, May 26, 2017 at 09:44:17AM +0800, Jiahau Chang wrote: > There is some limitation for AMD Promontory xHCI host to > disable USB port function. It will enable USB wake-up function then cause USB > disable port feature to fail. > Workaround this issue on Promontory xHCI host > is clear