[PATCH v2] usb: host: ohci-pxa27x: Handle return value of clk_prepare_enable

clk_prepare_enable() can fail here and we must check its return value. Signed-off-by: Arvind Yadav Changes in v2: Remove useless initialization of retval. --- drivers/usb/host/ohci-pxa27x.c | 10 +++--- 1 file changed, 7 insertions(+), 3

Re: Gadget driver ->disconnect callback during unbinding

On Wed, Jun 14, 2017 at 10:26:29AM -0400, Alan Stern wrote: > On Wed, 14 Jun 2017, Peter Chen wrote: > > > On Tue, Jun 13, 2017 at 10:22:26AM -0400, Alan Stern wrote: > > > On Tue, 13 Jun 2017, Felipe Balbi wrote: > > > > > > > > > > > Hi Alan, > > > > > > > > Alan Stern

June 14, 2017

Attn, My name is Johnson King, the principal attorney of my law firm., Johnson King & Co. A deceased client Mr. Henry died in 2010 and left a sum little above US$ 28 million in his account here in Unity Bank Plc. Normally banking procedures requires that the bank declares the account

Re: cdc_mbim problems with Fibocom L831-EAU

> But for the above stuff, note that MBIM modems often (always?) do *not* > support DHCP on the net interface. You'll get best results by reading > the IP configuration using the MBIM protocol and assigning those > details to the device. ModemManager will retrieve those for you, but > it does

Re: [PATCH v2 1/8] ACPI / PM: Run wakeup notify handlers synchronously

On Wed, Jun 14, 2017 at 8:09 PM, Bjorn Helgaas wrote: > On Mon, Jun 12, 2017 at 10:48:41PM +0200, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki >> >> The work functions provided by the users of acpi_add_pm_notifier() >> should be run

Re: cdc_mbim problems with Fibocom L831-EAU

Dan Williams writes: >> The problems seem to be accompanied by `cdc_mbim 1-6:1.0: nonzero urb >> status received: -EPIPE` in dmesg. > > I'll let Bjorn address this specific EPIPE issue. Thanks, but I'm a bit lost here. I guess it means that we try to read from the device

Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller

On Tue, 13 Jun 2017, Bjorn Helgaas wrote: > [+cc Rafael, linux-pm] > > On Tue, Jun 13, 2017 at 12:21:15PM +0800, Kai-Heng Feng wrote: > > On Mon, Jun 12, 2017 at 10:18 PM, Alan Stern > > wrote: > > > Let's get some help from people who understand PCI well. > > > > >

Re: [PATCH v2 6/8] PCI / PM: Restore PME Enable if skipping wakeup setup

On Mon, Jun 12, 2017 at 10:53:36PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The wakeup_prepared PCI device flag is used for preventing subsequent > changes of PCI device wakeup settings in the same way (e.g. enabling > device wakeup twice in a

Re: [PATCH v2 1/8] ACPI / PM: Run wakeup notify handlers synchronously

On Mon, Jun 12, 2017 at 10:48:41PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The work functions provided by the users of acpi_add_pm_notifier() > should be run synchronously before re-enabling the wakeup GPE in > case they are used to clear the

Re: possible xhci bug on linux-next

Hi, (Carlos, please Cc linux-omap on things related to OMAP :-) Mathias Nyman writes: > Adding Felipe, > > First warning is when dwc3_omap requests threaded irq > > On 14.06.2017 16:03, Carlos Hernandez wrote: >> linux-next fails to boot due to what appears to be a

Re: [PATCH V5 1/2] dt-bindings: leds: document new trigger-sources property

On Thu, Jun 08, 2017 at 06:08:31PM +0200, Rafał Miłecki wrote: > From: Rafał Miłecki > > Some LEDs can be related to a specific device(s) described in the DT. > This property allows specifying such relations. E.g. USB LED should > usually be used to indicate some USB port(s)

Re: Oddity with EP configuration

On Thu, 15 Jun 2017, Benjamin Herrenschmidt wrote: > On Wed, 2017-06-14 at 10:19 -0400, Alan Stern wrote: > > I think the problem is that you misunderstand how epautoconf is > > intended to work. > > > > I'm not the expert on this stuff -- Felipe is.  Still, as best I > > understand, the idea

Re: [PATCH] usb: host: ohci-pxa27x: Handle return value of clk_prepare_enable

On Wed, 14 Jun 2017, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > drivers/usb/host/ohci-pxa27x.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git

Re: Oddity with EP configuration

On Wed, 2017-06-14 at 10:19 -0400, Alan Stern wrote: > I think the problem is that you misunderstand how epautoconf is > intended to work. > > I'm not the expert on this stuff -- Felipe is.  Still, as best I > understand, the idea is that a gadget driver or the composite core will > attempt to

Re: Gadget driver ->disconnect callback during unbinding

On Wed, 14 Jun 2017, Peter Chen wrote: > On Tue, Jun 13, 2017 at 10:22:26AM -0400, Alan Stern wrote: > > On Tue, 13 Jun 2017, Felipe Balbi wrote: > > > > > > > > Hi Alan, > > > > > > Alan Stern writes: > > > > Felipe: > > > > > > > > A UDC driver will invoke the

Re: possible xhci bug on linux-next

Adding Felipe, First warning is when dwc3_omap requests threaded irq On 14.06.2017 16:03, Carlos Hernandez wrote: linux-next fails to boot due to what appears to be a xhci bug. Problem observed at least on am57xx-evm, dra72x-evm and dra7xx-evm. According to Tony Lindgren the issue is marking

possible xhci bug on linux-next

linux-next fails to boot due to what appears to be a xhci bug. Problem observed at least on am57xx-evm, dra72x-evm and dra7xx-evm. According to Tony Lindgren the issue is marking a shared interrupt disabled on start-up. [0.00] Booting Linux on physical CPU 0x0 [0.00] Linux

Re: Oddity with EP configuration

On Wed, 14 Jun 2017, Benjamin Herrenschmidt wrote: > On Wed, 2017-06-14 at 10:33 +1000, Benjamin Herrenschmidt wrote: > > On Tue, 2017-06-13 at 15:08 +1000, Benjamin Herrenschmidt wrote: > > > Now, what I observe is that when the mass storage gets bound to the > > > UDC driver: > > > > > >  -

cdc_mbim problems with Fibocom L831-EAU

I've bought a ThinkPad T470 with a Fibocom L831-EAU WWAN module, which appears to be an MBIM device. It works fine on Windows, but if I try it on Linux, it doesn't work. I've tried it on NixOS (kernel 4.11.4, libmbim 1.14.0) and Ubuntu 16.04. * NetworkManager can't connect. * If I do `rmmod

Re: [PATCH v2 1/8] tty: add a poll() callback in struct tty_operations

> That would cut it, but TIOCPKT is too coupled with having a linked tty. > I could make acm behave like a pty (accept TIOCPKT and issue the > ctrl_status bits), but for that I need n_tty to know that packet does > not always mean a linked tty is present, and that in case it isn't we > take our

Re: [v2 1/1] usb:host:xhci support option to disable xHCI 1.0 USB2 HW LPM

On Tue, Jun 13, 2017 at 8:12 PM, Mathias Nyman wrote: > On 06.06.2017 09:33, Thang Q. Nguyen wrote: >> >> On Mon, Jun 5, 2017 at 9:33 PM, Mathias Nyman >> wrote: >>> >>> On 05.06.2017 15:57, Thang Q. Nguyen wrote: On Mon, Jun

[PATCH Resent 1/3] HID: core: move the dynamic quirks handling in core

usbhid has a list of dynamic quirks in addition to a list of static quirks. There is not much USB specific in that, so move this part of the module in core so we can have one central place for quirks. Signed-off-by: Benjamin Tissoires --- Resent with -M1 -C1 in

Re: [PATCH 1/3] HID: core: move the dynamic quirks handling in core

On Jun 14 2017 or thereabouts, Andy Shevchenko wrote: > On Wed, Jun 14, 2017 at 11:24 AM, Benjamin Tissoires > wrote: > > usbhid has a list of dynamic quirks in addition to a list of static quirks. > > There is not much USB specific in that, so move this part of the

Re: [PATCH 0/3] Proposal for making hid_have_special_driver obsolete

On Jun 14 2017 or thereabouts, Bastien Nocera wrote: > > > > On 14 Jun 2017, at 10:24, Benjamin Tissoires > > wrote: > > > > Hi, > > > > As mentioned by Jiri, I found a way to have this horrible list a thing from > > the past (to some extends). > > > > The

Re: [PATCH v3 1/2] usb: typec: Add support for UCSI interface

On Wed, Jun 14, 2017 at 12:50:38PM +0200, Greg Kroah-Hartman wrote: > On Wed, Jun 14, 2017 at 09:45:46AM +0300, Heikki Krogerus wrote: > > Hi Guenter, > > > > Gentle ping. > > After less than 2 days? Relax please... OK, Sorry for the noise. -- heikki -- To unsubscribe from this list: send

Re: [PATCH] USB: gadgetfs, dummy-hcd, net2280: fix locking for callbacks

Hi, Greg KH writes: > On Tue, Jun 13, 2017 at 03:23:42PM -0400, Alan Stern wrote: >> Using the syzkaller kernel fuzzer, Andrey Konovalov generated the >> following error in gadgetfs: >> >> > BUG: KASAN: use-after-free in __lock_acquire+0x3069/0x3690 >> >

Re: [PATCH] USB: gadgetfs, dummy-hcd, net2280: fix locking for callbacks

On Tue, Jun 13, 2017 at 03:23:42PM -0400, Alan Stern wrote: > Using the syzkaller kernel fuzzer, Andrey Konovalov generated the > following error in gadgetfs: > > > BUG: KASAN: use-after-free in __lock_acquire+0x3069/0x3690 > > kernel/locking/lockdep.c:3246 > > Read of size 8 at addr

Re: [PATCH v3 1/2] usb: typec: Add support for UCSI interface

On Wed, Jun 14, 2017 at 09:45:46AM +0300, Heikki Krogerus wrote: > Hi Guenter, > > Gentle ping. After less than 2 days? Relax please... -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 0/3] Proposal for making hid_have_special_driver obsolete

> On 14 Jun 2017, at 10:24, Benjamin Tissoires > wrote: > > Hi, > > As mentioned by Jiri, I found a way to have this horrible list a thing from > the past (to some extends). > > The basic observation is that now, since v4.12, hid-generic should not be an >

Re: [PATCH 1/3] HID: core: move the dynamic quirks handling in core

On Wed, Jun 14, 2017 at 11:24 AM, Benjamin Tissoires wrote: > usbhid has a list of dynamic quirks in addition to a list of static quirks. > There is not much USB specific in that, so move this part of the module > in core so we can have one central place for quirks.

[PATCH 0/3] Proposal for making hid_have_special_driver obsolete

Hi, As mentioned by Jiri, I found a way to have this horrible list a thing from the past (to some extends). The basic observation is that now, since v4.12, hid-generic should not be an issue for any device, given that all it does is parsing the report descriptor and starting the IRQs/URBs. So

[PATCH 1/3] HID: core: move the dynamic quirks handling in core

usbhid has a list of dynamic quirks in addition to a list of static quirks. There is not much USB specific in that, so move this part of the module in core so we can have one central place for quirks. Signed-off-by: Benjamin Tissoires --- drivers/hid/Makefile

[PATCH] usb: gadget: mv_udc: Handle return value of clk_prepare_enable.

clk_prepare_enable() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/usb/gadget/udc/mv_udc_core.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/mv_udc_core.c

[RFC/PATCH] usb/gadget: Add an EP dispose() callback for EP lifetime tracking

Some UDC may want to allocate endpoints dynamically, either because the HW supports an arbitrary large number or because (like the Aspeed BMC SoCs), the pool of HW endpoints is shared between multiple gadgets. The allocation side can be done rather easily using the existing match_ep() UDC hook.

Re: [PATCH v15 2/7] power: add power sequence library

On 14 June 2017 at 03:53, Peter Chen wrote: > On Tue, Jun 13, 2017 at 12:24:42PM +0200, Ulf Hansson wrote: >> [...] >> >> > + >> > +/** >> > + * of_pwrseq_on - Carry out power sequence on for device node >> > + * >> > + * @np: the device node would like to power on >> > + *

[PATCH 3/3] HID: core: remove the absolute need of hid_have_special_driver[]

Most HID devices behave properly when they are used with hid-generic. Since kernel v4.12, we do not poll for input reports at plug in, so hid-generic should behave properly with all HID devices. There has been a long standing list of HID devices that have a special driver. It used to be just a

Re: [PATCH v2 1/8] tty: add a poll() callback in struct tty_operations

On Wed, Jun 14, 2017 at 11:20 AM, Tal Shorer wrote: > On Wed, Jun 14, 2017 at 4:15 AM, Alan Cox wrote: >> On Tue, 13 Jun 2017 09:52:07 +0300 >> Tal Shorer wrote: >> >>> If a tty driver wants to notify the user of some

[PATCH 2/3] HID: quirks: move the list of special devices into a quirk

It is better to centralize the information of special devices in one single file. Instead of manually parsing the list of devices that have a special driver or those that need to be ignored, introduce HID_QUIRK_HAVE_SPECIAL_DRIVER and set the correct quirks while fetching those quirks.

Re: [PATCH v2 1/8] tty: add a poll() callback in struct tty_operations

On Wed, Jun 14, 2017 at 4:15 AM, Alan Cox wrote: > On Tue, 13 Jun 2017 09:52:07 +0300 > Tal Shorer wrote: > >> If a tty driver wants to notify the user of some exceptional event, >> such as a usb cdc acm device set_line_coding event, it needs a

Re: [PATCH] USB: qcserial: new Sierra Wireless EM7305 device ID

On Tue, Jun 13, 2017 at 07:11:42PM +0200, Bjørn Mork wrote: > A new Sierra Wireless EM7305 device ID used in a Toshiba laptop. > > Reported-by: Petr Kloc > Cc: > Signed-off-by: Bjørn Mork Now applied, thanks. Johan -- To unsubscribe

Re: [PATCH v4] xhci: AMD Promontory USB disable port support

2017-06-13 20:33 GMT+08:00 Mathias Nyman : > On 13.06.2017 14:26, Jiahau Chang wrote: >> >> 2017-06-07 16:02 GMT+08:00 Mathias Nyman : >>> >>> On 06.06.2017 13:13, Jiahau Chang wrote: v4: Remove the patch code in case

Re: [PATCH v2] USB: serial: option: add two Longcheer device ids

On Mon, Jun 12, 2017 at 06:14:59PM +0300, Teemu Likonen wrote: > Johan Hovold [2017-06-12 16:30:16+02] wrote: > > > Add two Longcheer device-id entries which specifically enables the > > Telewell TW-3G HSPA+ branded modem. > > > > Reported-by: Teemu Likonen > > Cc: stable

Re: [PATCH v3 1/2] usb: typec: Add support for UCSI interface

Hi Guenter, Gentle ping. I'm sorry to bother you with this, I know you are busy. On Mon, Jun 12, 2017 at 05:40:08PM +0300, Heikki Krogerus wrote: > UCSI - USB Type-C Connector System Software Interface - is a > specification that defines set of registers and data > structures for controlling

[PATCH] usb: host: ohci-pxa27x: Handle return value of clk_prepare_enable

clk_prepare_enable() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/usb/host/ohci-pxa27x.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ohci-pxa27x.c