RE: [PATCH] usb: gadget: udc: fix the kernel NULL pointer in composite_setup

Hi, Balbi: 1. the issue reproduced very rarely, we run reboot test reproduce the issue, it reproduced two times on two board after more than 1500 cycles reboot. 2. the kernel version is 4.4, the test case is cold reboot, I think it's not android patches cause it, it's the

Re: [PATCH v16 2/7] power: add power sequence library

On Tue, Jul 18, 2017 at 07:06:05PM +0200, Rafael J. Wysocki wrote: > On Tue, Jul 18, 2017 at 6:29 AM, Peter Chen wrote: > > On Mon, Jul 17, 2017 at 03:39:07PM +0200, Rafael J. Wysocki wrote: > >> > Sorry, I should describe more. > >> > > >> > Let's take USB bus as an

Re: [PATCH v2 1/3] mux: Add mux_control_get_optional() API

Quoting Peter Rosin (2017-07-17 01:20:14) > On 2017-07-14 23:40, Stephen Boyd wrote: > > diff --git a/drivers/mux/mux-core.c b/drivers/mux/mux-core.c > > index 90b8995f07cb..a0e5bf16f02f 100644 > > --- a/drivers/mux/mux-core.c > > +++ b/drivers/mux/mux-core.c > > @@ -289,6 +289,9 @@

Re: [PATCH v2 2/3] usb: chipidea: Hook into mux framework to toggle usb switch

On Tue, Jul 18, 2017 at 06:47:02PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2017-07-17 21:41:11) > > On Fri, Jul 14, 2017 at 02:40:04PM -0700, Stephen Boyd wrote: > > > > > > @@ -175,6 +176,10 @@ static int host_start(struct ci_hdrc *ci) > > > if (ci_otg_is_fsm_mode(ci)) {

Re: [PATCH] usb: chipidea: msm: ci_hdrc_msm_probe() missing of_node_get()

On Tue, Jul 18, 2017 at 04:31:28PM -0700, frowand.l...@gmail.com wrote: > From: Frank Rowand > > Boot fails for qcom-apq8074-dragonboard on 4.13-rc1 with error: > OF: ERROR: Bad of_node_put() on /soc/usb@f9a55000 > > The error will occur if the configuration is set to: >

Re: [PATCH v2 2/3] usb: chipidea: Hook into mux framework to toggle usb switch

Quoting Peter Chen (2017-07-17 21:41:11) > On Fri, Jul 14, 2017 at 02:40:04PM -0700, Stephen Boyd wrote: > > > > @@ -175,6 +176,10 @@ static int host_start(struct ci_hdrc *ci) > > if (ci_otg_is_fsm_mode(ci)) { > > otg->host = >self; > >

[PATCH] usb: chipidea: msm: ci_hdrc_msm_probe() missing of_node_get()

From: Frank Rowand Boot fails for qcom-apq8074-dragonboard on 4.13-rc1 with error: OF: ERROR: Bad of_node_put() on /soc/usb@f9a55000 The error will occur if the configuration is set to: CONFIG_OF_OVERLAY y CONFIG_OF_UNITTEST y CONFIG_OF_DYNAMIC y

xhci bandwidth problem with isochronous endpoints

Hello, I have a new USB3 camera that can only operate in isochronous mode. I can open and stream data from the camera using guvcview. The camera has 3 interfaces, two show up as uvc video devices. The interface I open claims a maximum bandwidth dwMaxBitRate=73728000, I should be able to open

[PATCH] usb: Convert to using %pOF instead of full_name

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node. Signed-off-by: Rob Herring Cc: Greg Kroah-Hartman Cc: Felipe Balbi

Re: [PATCH v2 RESEND] usb:gadget:hid: {GET,SET} PROCOTOL Support

On Tue, Jul 18, 2017 at 10:17:24PM +0200, Greg KH wrote: > On Tue, Jul 18, 2017 at 08:47:58PM +0100, Abdulhadi Mohamed wrote: > > The current HID function driver doesn't support GET_PROCOTOL and > > SET_PROCOTOL commands, which are required to operate the HID gadgets in > > BOOT mode. This patch

Re: [PATCH v2 RESEND] usb:gadget:hid: {GET,SET} PROCOTOL Support

On Tue, Jul 18, 2017 at 08:47:58PM +0100, Abdulhadi Mohamed wrote: > The current HID function driver doesn't support GET_PROCOTOL and > SET_PROCOTOL commands, which are required to operate the HID gadgets in > BOOT mode. This patch implements this feature for devices that have > the same

[PATCH v2 RESEND] usb:gadget:hid: {GET,SET} PROCOTOL Support

The current HID function driver doesn't support GET_PROCOTOL and SET_PROCOTOL commands, which are required to operate the HID gadgets in BOOT mode. This patch implements this feature for devices that have the same implementation for REPORT and BOOT mode so that these devices are recognized by

Re: [PATCH v3 00/10] constify net attribute_group structures.

From: Arvind Yadav Date: Tue, 18 Jul 2017 15:13:44 +0530 > attribute_group are not supposed to change at runtime. All functions > working with attribute_group provided by work with const > attribute_group. So mark the non-const structs as const. Series applied,

Re: [PATCH v16 2/7] power: add power sequence library

On Tue, Jul 18, 2017 at 6:29 AM, Peter Chen wrote: > On Mon, Jul 17, 2017 at 03:39:07PM +0200, Rafael J. Wysocki wrote: >> > Sorry, I should describe more. >> > >> > Let's take USB bus as an example, when the new USB device is at the >> > host port, the device structure at

Re: [PATCH 1/4] usb: musb: add helper function musb_ep_xfertype_string

Hello! On 07/18/2017 06:13 PM, Bin Liu wrote: Add helper function musb_ep_xfertype_string() to return the ep transfer type string. Signed-off-by: Bin Liu Doesn't this belong to USB core? What's MUSB specific about it? --- drivers/usb/musb/musb_core.h | 24

[PATCH 2/4] usb: musb: print an error message when hwep alloc failed

Print an error message with qh maxpacket size and hb_mult when hwep allocation failed, so we have a better idea why it is failed. Signed-off-by: Bin Liu --- drivers/usb/musb/musb_host.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/musb/musb_host.c

[PATCH 4/4] usb: musb: fix endpoint fifo allocation for 4KB fifo memory

The fifo memory allocation in mode_2_cfg[] doesn't utilize all the 4KB memory. Increse some endpoint fifo buffers to fully use all the 4KB memory. Now we can support more webcam usecases on DA8xx. Signed-off-by: Bin Liu --- drivers/usb/musb/musb_core.c | 4 ++-- 1 file changed, 2

[PATCH 3/4] usb: musb: print an error message when high bandwidth is unsupported

There are multiple places in usb core or controller driver which returns -EMSGSIZE when a class driver queueing urb failed, so the "Message too long" log doesn't help much for understanding the error. Let the musb driver to specifically print a error message when musb_urb_enqueue() returns

[PATCH 1/4] usb: musb: add helper function musb_ep_xfertype_string

Add helper function musb_ep_xfertype_string() to return the ep transfer type string. Signed-off-by: Bin Liu --- drivers/usb/musb/musb_core.h | 24 drivers/usb/musb/musb_gadget.c | 6 +- 2 files changed, 25 insertions(+), 5 deletions(-) diff --git

Re: Dell DA200 adapter errors

A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Tue, Jul 18, 2017 at

Re: Dell DA200 adapter errors

Ok, I have last revision of dell bios (Dell 9560 1.1.4). I will try to upgrade the kernel to last version. So you have same errors? Today I have been working with the adapter without any problem but I think that the problems will come again. I don't know if the debug information attached to

Attention To me and get back to me urgent

Attention:Beneficiary I am Meliana Trump, and I am writing to inform you about your Bank Check Draft brought back 16/07/2017 by the United Embassy Mr John Moore from the government of Benin Republic in the white house Washington DC been mandated to be deliver to your home address once you

Re: [PATCH 1/1] usb: core: hub: controller driver name may be NULL

On Tue, 18 Jul 2017, Peter Chen wrote: > The controller driver may be NULL if the controller device > is the middle device between platform device and roothub. > This middle device may not need a device driver due to all > hardware control can be at platform device driver, this > platform device

Re: [PATCH 3/3] usb: gadget: udc: renesas_usb3: protect usb3_ep->started in usb3_start_pipen()

On Tue, Jul 18, 2017 at 2:26 PM, Yoshihiro Shimoda wrote: > This patch fixes an issue that unexpected behavior happens when > both the interrupt handler and renesas_usb3_ep_enable() are called. > In this case, since usb3_start_pipen() checked the

Re: [PATCH 1/3] usb: gadget: udc: renesas_usb3: fix free size in renesas_usb3_dma_free_prd()

Hi Shimoda-san, On Tue, Jul 18, 2017 at 2:26 PM, Yoshihiro Shimoda wrote: > The commit 2d4aa21a73ba ("usb: gadget: udc: renesas_usb3: add support > for dedicated DMAC") has a bug in the renesas_usb3_dma_free_prd(). > The size of dma_free_coherent() should be the

[PATCH 3/3] usb: gadget: udc: renesas_usb3: protect usb3_ep->started in usb3_start_pipen()

This patch fixes an issue that unexpected behavior happens when both the interrupt handler and renesas_usb3_ep_enable() are called. In this case, since usb3_start_pipen() checked the usb3_ep->started, but the flags was not protected. So, this patch protects the flag by usb3->lock. Since

[PATCH 1/3] usb: gadget: udc: renesas_usb3: fix free size in renesas_usb3_dma_free_prd()

The commit 2d4aa21a73ba ("usb: gadget: udc: renesas_usb3: add support for dedicated DMAC") has a bug in the renesas_usb3_dma_free_prd(). The size of dma_free_coherent() should be the same with dma_alloc_coherent() Otherwise, this code causes a WARNING by mm/page_alloc.c when

[PATCH 2/3] usb: gadget: udc: renesas_usb3: fix zlp transfer by the dmac

The dedicated dmac can transfer a zero-length-packet (zlp) if some bits of the USB_COM_CON register. However, the commit 2d4aa21a73ba ("usb: gadget: udc: renesas_usb3: add support for dedicated DMAC") didn't set the bits to 1. So, this patch fixes it. Fixes: 2d4aa21a73b ("usb: gadget: udc:

[PATCH 0/3] usb: gadget: udc: renesas_usb3: fixes for v4.13-rc1

This patch is based on the latest Felipe's usb.git / testing/fixes branch (The commit id = 4a71fcb8ac5f94c07bf47a43b13258a52e4fe3ad). Yoshihiro Shimoda (3): usb: gadget: udc: renesas_usb3: fix free size in renesas_usb3_dma_free_prd() usb: gadget: udc: renesas_usb3: fix zlp transfer by the

Re: [PATCH v10 00/15] Replace PCI pool by DMA pool API

Hello, Le 09/07/2017 à 23:30, Doug Ledford a écrit : > On Thu, 2017-07-06 at 10:12 +0200, Romain Perier wrote: >> The current PCI pool API are simple macro functions direct expanded >> to >> the appropriate dma pool functions. The prototypes are almost the >> same >> and semantically, they are

Re: [PATCH] usb: dwc3: gadget: Correct ISOC DATA PIDs for short packets

Hi, Manu Gautam writes: >> Manu Gautam writes: >>> The PIDs for Isochronous data transfers are incorrect >>> for high bandwidth IN endpoints when the request length >>> is less than EP wMaxPacketSize. >>> As per spec correct PIDs for ISOC data

Re: [PATCH] usb: gadget: udc: fix the kernel NULL pointer in composite_setup

Hi, "He, Bo" writes: > the patch is for fix the below kernel panic: > BUG: unable to handle kernel NULL pointer dereference at 002a > IP: [] composite_setup+0x3d/0x1830 > PGD 27525b067 PUD 27525a067 PMD 0 > Oops: 0002 [#1] PREEMPT SMP > Call Trace: > [] ?

Re: [RFCv2 usb-next 0/3] initialize (multiple) PHYs in xhci-plat

On Tue, 2017-07-18 at 10:19 +0200, Martin Blumenstingl wrote: > Hi, > > On Tue, Jul 18, 2017 at 3:40 AM, Chunfeng Yun > wrote: > > Hi, > > On Mon, 2017-07-17 at 11:27 +0200, Martin Blumenstingl wrote: > >> Hi, > >> > >> On Mon, Jul 17, 2017 at 9:21 AM, Chunfeng Yun

[PATCH v3 01/10] net: cdc_ncm: constify attribute_group structures.

attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by work with const attribute_group. So mark the non-const structs as const. File size before: textdata bss dec hex filename 13275 928 1 14204377c

[PATCH v3 00/10] constify net attribute_group structures.

attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by work with const attribute_group. So mark the non-const structs as const. Arvind Yadav (10): [PATCH v3 01/10] net: cdc_ncm: constify attribute_group structures. [PATCH v3 02/10] net:

[PATCH 1/1] usb: core: hub: controller driver name may be NULL

The controller driver may be NULL if the controller device is the middle device between platform device and roothub. This middle device may not need a device driver due to all hardware control can be at platform device driver, this platform device is usually a dual-role USB controller device. The

[PATCH] usb: gadget: udc: fix the kernel NULL pointer in composite_setup

the patch is for fix the below kernel panic: BUG: unable to handle kernel NULL pointer dereference at 002a IP: [] composite_setup+0x3d/0x1830 PGD 27525b067 PUD 27525a067 PMD 0 Oops: 0002 [#1] PREEMPT SMP Call Trace: [] ? dwc3_trace+0x52/0x60 [] ? get_parent_ip+0xd/0x50 []

Re: [RFCv2 usb-next 0/3] initialize (multiple) PHYs in xhci-plat

Hi, On Tue, Jul 18, 2017 at 3:40 AM, Chunfeng Yun wrote: > Hi, > On Mon, 2017-07-17 at 11:27 +0200, Martin Blumenstingl wrote: >> Hi, >> >> On Mon, Jul 17, 2017 at 9:21 AM, Chunfeng Yun >> wrote: >> > Hi, >> > On Sat, 2017-07-15 at 14:11

Re: [PATCH v2 0/3] Introduce USB charger support in USB phy

Hi, On 3 July 2017 at 14:07, Baolin Wang wrote: > Currently the Linux kernel does not provide any standard integration of this > feature that integrates the USB subsystem with the system power regulation > provided by PMICs meaning that either vendors must add this in

Re: [PATCH] usb: dwc3: gadget: Correct ISOC DATA PIDs for short packets

On 7/18/2017 11:53 AM, Felipe Balbi wrote: > Hi, > > Manu Gautam writes: >> The PIDs for Isochronous data transfers are incorrect >> for high bandwidth IN endpoints when the request length >> is less than EP wMaxPacketSize. >> As per spec correct PIDs for ISOC data

Re: [PATCH] usb: dwc3: gadget: Correct ISOC DATA PIDs for short packets

Hi, Manu Gautam writes: > The PIDs for Isochronous data transfers are incorrect > for high bandwidth IN endpoints when the request length > is less than EP wMaxPacketSize. > As per spec correct PIDs for ISOC data transfers are: > ->For request length < maxPayloadSize >

Re: [USB] f16443a034: EIP:arch_local_irq_restore

Hi, Alan Stern writes: >> Alan Stern writes: >> >> >> > On Thu, 29 Jun 2017, kernel test robot wrote: >> >> >> > >> >> >> >> FYI, we noticed the following commit: >> >> >> >> >> >> >> >> commit: f16443a034c7aa359ddf6f0f9bc40d01ca31faea