Re: usbip port number limits

2017-11-21 Thread Yuyang Du
Hi Juan, On Tue, Nov 21, 2017 at 12:24:01PM +0100, Juan Zea wrote: > Please excuse me... I have reported two different problems in this post, > and I think things are mixing up a bit. My bad. I've found two different > problems: > > 1.- When compiling vhci driver with multiple hubs (in

Re: usbip port number limits

2017-11-21 Thread Yuyang Du
Hi Shuah, On Tue, Nov 21, 2017 at 07:33:41AM -0700, Shuah Khan wrote: > > Thanks for finding the problem. usb2 devices don't work at all with the > offending commit: 03cd00d538a6feb0492cd153edf256ef7d7bd95e > > I have been debugging on 4.12 and this bad commit. Low speed devices can be >

Re: [PATCH 1/2] usb: xhci: add relaxed timing quirk bit

2017-11-21 Thread Adam Wallis
On 11/21/2017 3:06 PM, Rob Herring wrote: [..] >> I like where you are going with this. Are you saying that I could read for a >> device property read from firmware (for DTB or ACPI) like DWC3 does for >> "snps,hird-threshold"? > > Is that for the same thing? If so, drop the vendor prefix and

Re: [PATCH 1/2] usb: xhci: add relaxed timing quirk bit

2017-11-21 Thread Rob Herring
On Tue, Nov 21, 2017 at 1:49 PM, Adam Wallis wrote: > On 11/21/2017 2:11 PM, Rob Herring wrote: >> On Tue, Nov 21, 2017 at 12:18:09PM -0500, Adam Wallis wrote: >>> Certain systems may run with CPUs at a very slow frequency. This >>> patch adds a quirk bit that can be used

Re: [PATCH 1/2] usb: xhci: add relaxed timing quirk bit

2017-11-21 Thread Adam Wallis
On 11/21/2017 2:11 PM, Rob Herring wrote: > On Tue, Nov 21, 2017 at 12:18:09PM -0500, Adam Wallis wrote: >> Certain systems may run with CPUs at a very slow frequency. This >> patch adds a quirk bit that can be used to relax certain timings, etc. >> >> This quirk might be needed for other fields

Re: [PATCH 1/2] usb: xhci: add relaxed timing quirk bit

2017-11-21 Thread Rob Herring
On Tue, Nov 21, 2017 at 12:18:09PM -0500, Adam Wallis wrote: > Certain systems may run with CPUs at a very slow frequency. This > patch adds a quirk bit that can be used to relax certain timings, etc. > > This quirk might be needed for other fields in the future, but > initially, it will be used

Re: [PATCH v3] typec: tcpm: fusb302: Resolve out of order messaging events

2017-11-21 Thread Guenter Roeck
On Tue, Nov 21, 2017 at 02:12:12PM +, Adam Thomson wrote: > The expectation in the FUSB302 driver is that a TX_SUCCESS event > should occur after a message has been sent, but before a GCRCSENT > event is raised to indicate successful receipt of a message from > the partner. However in some

[PATCH 0/2] usb: xhci: addition of timing quirk

2017-11-21 Thread Adam Wallis
On systems that allow CPUs to run at an extremely reduced frequency, it is possible to create an "interrupt" storm by USB settings that are not ideal at these speeds. This patch series introduces a quirk bit that currently only touches the Interrupt Control register but might be used in the future

[PATCH 1/2] usb: xhci: add relaxed timing quirk bit

2017-11-21 Thread Adam Wallis
Certain systems may run with CPUs at a very slow frequency. This patch adds a quirk bit that can be used to relax certain timings, etc. This quirk might be needed for other fields in the future, but initially, it will be used only on the IRQ control register to allow firmare to control the value

[PATCH 2/2] usb: host: xhci-plat: check relaxed timing quirk bit

2017-11-21 Thread Adam Wallis
Check sysdev to see if the relaxed timing quirk ("quirk-relaxed-timing") is set. Signed-off-by: Adam Wallis --- drivers/usb/host/xhci-plat.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c index

RE: xhci_hcd HC died; cleaning up with TUSB7340 and µPD720201

2017-11-21 Thread Chris Welch
> -Original Message- > From: Vignesh R [mailto:vigne...@ti.com] > Sent: Tuesday, November 21, 2017 12:48 AM > To: Roger Quadros > Cc: Chris Welch ; linux-usb@vger.kernel.org; > linux-...@vger.kernel.org; Joao Pinto ;

Re: usbip port number limits

2017-11-21 Thread Shuah Khan
On 11/21/2017 04:24 AM, Juan Zea wrote: >> - Mensaje original - >> De: "Yuyang Du" >> Para: "Shuah Khan" >> CC: "Juan Zea" , sh...@kernel.org, "Bjørn Mork" >> , linux-usb@vger.kernel.org, "Valentina

RE: [RFC PATCH v2 0/7] typec: tcpm: Add sink side support for PPS

2017-11-21 Thread Adam Thomson
On 21 November 2017 14:18, Heikki Krogerus wrote: > On Tue, Nov 21, 2017 at 01:51:41PM +, Adam Thomson wrote: > > > These don't apply on top of Badhri's series: > > > http://www.spinics.net/lists/kernel/msg2649921.html > > > > Hi Heikki, > > > > When I submitted these I was aware of Badhri's

Re: [RFC PATCH v2 0/7] typec: tcpm: Add sink side support for PPS

2017-11-21 Thread Heikki Krogerus
On Tue, Nov 21, 2017 at 01:51:41PM +, Adam Thomson wrote: > > These don't apply on top of Badhri's series: > > http://www.spinics.net/lists/kernel/msg2649921.html > > Hi Heikki, > > When I submitted these I was aware of Badhri's patch set but at the time they > hadn't been approved or

[PATCH v3] typec: tcpm: fusb302: Resolve out of order messaging events

2017-11-21 Thread Adam Thomson
The expectation in the FUSB302 driver is that a TX_SUCCESS event should occur after a message has been sent, but before a GCRCSENT event is raised to indicate successful receipt of a message from the partner. However in some circumstances it is possible to see the hardware raise a GCRCSENT event

RE: [PATCH] typec: tcpm: fusb302: Resolve out of order messaging events

2017-11-21 Thread Adam Thomson
On 21 November 2017 14:08, Adam Thomson wrote: > Subject: [PATCH] typec: tcpm: fusb302: Resolve out of order messaging events Sorry. Finger trouble. Will resend with correct 'v3' title > The expectation in the FUSB302 driver is that a TX_SUCCESS event > should occur after a message has been

[PATCH] typec: tcpm: fusb302: Resolve out of order messaging events

2017-11-21 Thread Adam Thomson
The expectation in the FUSB302 driver is that a TX_SUCCESS event should occur after a message has been sent, but before a GCRCSENT event is raised to indicate successful receipt of a message from the partner. However in some circumstances it is possible to see the hardware raise a GCRCSENT event

RE: [RFC PATCH v2 0/7] typec: tcpm: Add sink side support for PPS

2017-11-21 Thread Adam Thomson
On 21 November 2017 13:36, Heikki Krogerus write: > Hi Adam, > > On Tue, Nov 14, 2017 at 11:44:41AM +, Adam Thomson wrote: > > This patch set adds sink side support for the PPS feature introduced in the > > USB PD 3.0 specification. > > > > The source PPS supply is represented using the

Re: [RFC PATCH v2 0/7] typec: tcpm: Add sink side support for PPS

2017-11-21 Thread Heikki Krogerus
Hi Adam, On Tue, Nov 14, 2017 at 11:44:41AM +, Adam Thomson wrote: > This patch set adds sink side support for the PPS feature introduced in the > USB PD 3.0 specification. > > The source PPS supply is represented using the Power Supply framework to > provide > access and control APIs for

Re: [PATCH] ARM: dts: bcm283x: Fix fifo size for EP 6,7

2017-11-21 Thread Minas Harutyunyan
On 11/20/2017 4:48 PM, Stefan Wahren wrote: > Hi Minas, > > Am 20.11.2017 um 12:59 schrieb Minas Harutyunyan: >> Hi Stefan, >> Looks like I know cause of issue... but I'm overloaded today and will able >> to check it tomorrow. Sorry for delay. > > thanks for your reply. There is no need to

Re: usbip port number limits

2017-11-21 Thread Juan Zea
> - Mensaje original - > De: "Yuyang Du" > Para: "Shuah Khan" > CC: "Juan Zea" , sh...@kernel.org, "Bjørn Mork" > , linux-usb@vger.kernel.org, "Valentina Manea" > >

Re: [PATCH net,stable] net: qmi_wwan: add Quectel BG96 2c7c:0296

2017-11-21 Thread David Miller
From: Sebastian Sjoholm Date: Mon, 20 Nov 2017 19:05:17 +0100 > Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both > CAT-M and NB-IoT. Tested hardware is BG96 mounted on Quectel development > board (EVB). The USB id is added to qmi_wwan.c to allow QMI >

[PATCH v3 01/16] phy: qcom-qmp: Fix phy pipe clock gating

2017-11-21 Thread Manu Gautam
From: Vivek Gautam Pipe clock comes out of the phy and is available as long as the phy is turned on. Clock controller fails to gate this clock after the phy is turned off and generates a warning. / # [ 33.048561] gcc_usb3_phy_pipe_clk status stuck at 'on' [

[PATCH v3 02/16] phy: qcom-qmp: Adapt to clk_bulk_* APIs

2017-11-21 Thread Manu Gautam
From: Vivek Gautam Move from using array of clocks to clk_bulk_* APIs that are available now. Signed-off-by: Vivek Gautam Signed-off-by: Manu Gautam --- drivers/phy/qualcomm/phy-qcom-qmp.c | 50

[PATCH v3 05/16] phy: qcom-qmp: Fix PHY block reset sequence

2017-11-21 Thread Manu Gautam
PHY block or asynchronous reset requires signal to be asserted before de-asserting. Driver is only de-asserting signal which is already low, hence reset operation is a no-op. Fix this by asserting signal first. Also, resetting requires PHY clocks to be turned ON only after reset is finished. Fix

[PATCH v3 03/16] phy: qcom-qmp: Power-on PHY before initialization

2017-11-21 Thread Manu Gautam
PHY must be powered on before turning ON clocks and attempting to initialize it. Driver is exposing separate init and power_on routines for this. Apparently USB dwc3 core driver performs power-on after init. Also, poweron and init for QMP PHY need to be executed together always, hence remove

[PATCH v3 04/16] phy: qcom-qusb2: Power-on PHY before initialization

2017-11-21 Thread Manu Gautam
PHY must be powered on before turning ON clocks and attempting to initialize it. Driver is exposing separate init and power_on routines for this. Apparently USB dwc3 core driver performs power-on after init. Also, poweron and init for QUSB2 PHY need to be executed together always, hence remove

[PATCH v3 06/16] phy: qcom-qmp: Move SERDES/PCS START after PHY reset

2017-11-21 Thread Manu Gautam
Driver is currently performing PHY reset after starting SERDES/PCS. As per hardware datasheet reset must be done before starting PHY. Hence, update the sequence. Signed-off-by: Manu Gautam --- drivers/phy/qualcomm/phy-qcom-qmp.c | 6 +++--- 1 file changed, 3

[PATCH v3 07/16] phy: qcom-qusb2: Add support for different register layouts

2017-11-21 Thread Manu Gautam
New version of QUSB2 PHY has some registers offset changed. Add support to have register layout for a target and update the same in phy_configuration. Signed-off-by: Manu Gautam --- drivers/phy/qualcomm/phy-qcom-qusb2.c | 131 -- 1 file

[PATCH v3 08/16] dt-bindings: phy-qcom-qusb2: Update binding for QUSB2 V2 version

2017-11-21 Thread Manu Gautam
Update generic compatible string for QUSB2 V2 PHY. This will allow all targets using QUSB2 V2 use same string. Acked-by: Rob Herring Signed-off-by: Manu Gautam --- Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt | 5 - 1 file changed, 4

[PATCH v3 10/16] phy: qcom-qmp: Move register offsets to header file

2017-11-21 Thread Manu Gautam
New revision (v3) of QMP PHY uses different offsets for almost all of the registers. Hence, move these definitions to header file so that updated offsets can be added for QMP v3. Signed-off-by: Manu Gautam --- drivers/phy/qualcomm/phy-qcom-qmp.c | 119

[PATCH v3 11/16] phy: qcom-qmp: Add register offsets for QMP V3 PHY

2017-11-21 Thread Manu Gautam
Registers offsets for QMP V3 PHY are changed from previous versions (1/2), update same in header file. Signed-off-by: Manu Gautam --- drivers/phy/qualcomm/phy-qcom-qmp.h | 149 1 file changed, 149 insertions(+) diff --git

[PATCH v3 12/16] dt-bindings: phy-qcom-qmp: Update bindings for QMP V3 USB PHY

2017-11-21 Thread Manu Gautam
Update compatible string and clock names for QMP version V3 USB PHY. Acked-by: Rob Herring Signed-off-by: Manu Gautam --- Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH v3 14/16] phy: Add notify_speed callback

2017-11-21 Thread Manu Gautam
QCOM USB PHYs can monitor resume/remote-wakeup event in suspended state. However PHY driver must know current operational speed of PHY in order to set correct polarity of wakeup events for detection. E.g. QUSB2 PHY monitors DP/DM signals depending on speed is LS or FS/HS to detect resume.

[PATCH v3 13/16] phy: qcom-qmp: Add support for QMP V3 USB3 PHY

2017-11-21 Thread Manu Gautam
QMP V3 USB3 PHY is a DisplayPort (DP) and USB combo PHY with dual RX/TX lanes to support type-c. There is a separate block DP_COM for configuration related to type-c or DP. Add support for dp_com region and secondary rx/tx lanes initialization. Signed-off-by: Manu Gautam

[PATCH v3 15/16] phy: qcom-qusb2: Add support for runtime PM

2017-11-21 Thread Manu Gautam
Disable clocks and enable DP/DM wakeup interrupts when suspending PHY. Core driver should notify speed to PHY driver to enable appropriate DP/DM wakeup interrupts polarity in suspend state. Signed-off-by: Manu Gautam --- drivers/phy/qualcomm/phy-qcom-qusb2.c | 181

[PATCH v3 16/16] phy: qcom-qmp: Add support for runtime PM

2017-11-21 Thread Manu Gautam
Disable clocks and enable PHY autonomous mode to detect wakeup events when PHY is suspended. Core driver should notify speed to PHY driver to enable LFPS and/or RX_DET interrupts. Signed-off-by: Manu Gautam --- drivers/phy/qualcomm/phy-qcom-qmp.c | 185

[PATCH v3 09/16] phy: qcom-qusb2: Add support for QUSB2 V2 version

2017-11-21 Thread Manu Gautam
Use register layout to add additional registers present on QUSB2 PHY V2 version for PHY initialization. Other than new registers on V2, following two register's offset and bit definitions are different: POWERDOWN control and PLL_STATUS. Signed-off-by: Manu Gautam ---

[PATCH v3 00/16] Support for Qualcomm QUSBv2 and QMPv3 USB PHYs

2017-11-21 Thread Manu Gautam
QUSB-v2 and QMP-v3 USB PHYs are present on Qualcomm's 14nm and 10nm SOCs. This patch series adds support for runtime PM for these USB PHYs and adds fixes in drivers to follow PHY reset and initialization sequence as per hardware programming manual. Changes since v2: - Drop sw-vbus override