[PATCH v8] xhci : AMD Promontory USB disable port support

2017-11-30 Thread Joe Lee
Signed-off-by: Joe Lee --- drivers/usb/host/pci-quirks.c | 128 ++ drivers/usb/host/pci-quirks.h | 5 ++ drivers/usb/host/xhci-hub.c | 7 +++ drivers/usb/host/xhci-pci.c | 11 drivers/usb/host/xhci.h | 2 +- 5

Re: [PATCH v2] usb: xhci: allow imod-interval to be configurable

2017-11-30 Thread Chunfeng Yun
Hi, On Wed, 2017-11-29 at 10:52 -0500, Adam Wallis wrote: > The xHCI driver currently has the IMOD set to 160, which > translates to an IMOD interval of 40,000ns (160 * 250)ns > > Commit 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host controller") > introduced a QUIRK for the MTK platform to

Re: [PATCH v1] usb: xhci: allow imod-interval to be configurable

2017-11-30 Thread Rob Herring
On Tue, Nov 28, 2017 at 12:11:46PM -0500, Adam Wallis wrote: > The xHCI driver currently has the IMOD set to 160, which > translates to an IMOD interval of 40,000ns (160 * 250)ns > > Commit 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host controller") > introduced a QUIRK for the MTK platform

Re: [PATCH v1] usb: xhci: allow imod-interval to be configurable

2017-11-30 Thread Rob Herring
On Wed, Nov 29, 2017 at 09:09:41AM +0100, Greg Kroah-Hartman wrote: > On Tue, Nov 28, 2017 at 03:32:29PM -0500, Adam Wallis wrote: > > On 11/28/2017 2:35 PM, Greg Kroah-Hartman wrote: > > > On Tue, Nov 28, 2017 at 12:11:46PM -0500, Adam Wallis wrote: > > >> The xHCI driver currently has the IMOD

usb: dwc3: Make sparse a bit happier.

2017-11-30 Thread Vincent Pelletier
Fixes the following warnings: drivers/usb/dwc3/io.h:43:31: warning: incorrect type in argument 1 (different address spaces) drivers/usb/dwc3/io.h:43:31:expected void *base drivers/usb/dwc3/io.h:43:31:got void [noderef] * drivers/usb/dwc3/io.h:62:32: warning: incorrect type in argument 1

Re: [RFC] Re: usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

2017-11-30 Thread Vincent Pelletier
Hello, On Thu, 30 Nov 2017 13:59:30 -0500 (EST), Alan Stern wrote: > This is a little misleading. The req->complete callback will be called > whether the request is dequeued or not. The real race is between > usb_ep_dequeue and completion of the transfer. Actually,

[PATCH] usb: host: fotg210: Use dma_pool_zalloc

2017-11-30 Thread Vasyl Gomonovych
Replacing dma_pool_alloc and memset with a single call to dma_pool_zalloc Signed-off-by: Vasyl Gomonovych --- drivers/usb/host/fotg210-hcd.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/fotg210-hcd.c

Re: [RFC] Re: usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

2017-11-30 Thread Alan Stern
On Thu, 30 Nov 2017, Vincent Pelletier wrote: > (tagging subject more ostensibly as RFC) > > On Tue, 28 Nov 2017 16:18:36 +, Vincent Pelletier > wrote: > > - This change should have no effect on existing cancel/complete race > > condition, which I expect is already

Re: [PATCH v2] usb: xhci: allow imod-interval to be configurable

2017-11-30 Thread Adam Wallis
On 11/30/2017 3:41 AM, Mathias Nyman wrote: [..] > I do however mind that I don't get any default imod interval value for my > pci based xhci host after this patch. > That needs to be fixed > Thanks Mathias, good catch. Where do you think I should initialize imod default in PCI subsytem? I was

[RFC] Re: usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

2017-11-30 Thread Vincent Pelletier
(tagging subject more ostensibly as RFC) On Tue, 28 Nov 2017 16:18:36 +, Vincent Pelletier wrote: > - This change should have no effect on existing cancel/complete race > condition, which I expect is already handled in AIO. If not, then it's > yet another

Re: [GIT PULL] USB fixes for v4.15-rc2

2017-11-30 Thread Greg Kroah-Hartman
On Thu, Nov 30, 2017 at 01:50:08PM +0200, Felipe Balbi wrote: > > Hi Greg, > > Here's the first set of fixes for this -rc cycle. It's small this time > around. Either folks are holding back or maybe the gadget framework is > getting closer to being ready :-p > > Anyway, let me know if you want

Re: [GIT PULL] USB-serial fixes for v4.15-rc2

2017-11-30 Thread Greg Kroah-Hartman
On Thu, Nov 30, 2017 at 12:32:26PM +0100, Johan Hovold wrote: > The following changes since commit 4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323: > > Linux 4.15-rc1 (2017-11-26 16:01:47 -0800) > > are available in the Git repository at: > >

Re: [PATCH v1] USB: storage: Remove obsolete "FIXME"

2017-11-30 Thread Alan Stern
On Thu, 30 Nov 2017, Mikhail Zaytsev wrote: > The fix of "FIXME: Notify the subdrivers..." doesn't actually have any > real effect. The "FIXME" changed to simple comment. > > Signed-off-by: Mikhail Zaytsev > --- > drivers/usb/storage/usb.c | 8 > 1 file changed, 4

Re: drivers/net/usb/r8152.c USB net driver outdated

2017-11-30 Thread Cameron Seader
On 11/29/2017 08:27 PM, Hayes Wang wrote: Cameron Seader [mailto:csea...@suse.com] Sent: Wednesday, November 29, 2017 10:51 AM [...] The upstream kernel seems to be outdated with version 1.09.9 of the drivers/net/usb/r8152.c driver. There is newer hardware now which requires the newer version

usb: dwc3: gadget: Wait longer for controller to end command processing

2017-11-30 Thread Vincent Pelletier
DWC3_DEPCMD_ENDTRANSFER has been witnessed to require around 600 iterations before controller would become idle again after unplugging the USB cable with AIO reads submitted. Bump timeout from 500 iterations to 1000 so dwc3_stop_active_transfer does not receive -ETIMEDOUT and does not WARN: [

[PATCH v2] usb: dwc3: gadget: Wait longer for controller to end command processing

2017-11-30 Thread Vincent Pelletier
Changes: - Added Signed-off-by. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

usb: dwc3: gadget: Wait longer for controller to end command processing

2017-11-30 Thread Vincent Pelletier
DWC3_DEPCMD_ENDTRANSFER has been witnessed to require around 600 iterations before controller would become idle again after unplugging the USB cable with AIO reads submitted. Bump timeout from 500 iterations to 1000 so dwc3_stop_active_transfer does not receive -ETIMEDOUT and does not WARN: [

Re: [PATCH] usbip: Fix USB device hang due to wrong enabling of scatter-gather

2017-11-30 Thread Shuah Khan
On 11/29/2017 07:22 PM, Yuyang Du wrote: > The previous USB3 SuperSpeed enabling patches mistakenly enabled > URB scatter-gather chaining, which is actually not supported by > the VHCI HCD. This patch fixes that. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197867 > Fixes:

Re: [PATCH] usbip: fix usbip attach to find a port that matches the requested speed

2017-11-30 Thread Shuah Khan
On 11/30/2017 01:20 AM, Greg KH wrote: > On Wed, Nov 29, 2017 at 03:24:22PM -0700, Shuah Khan wrote: >> usbip attach fails to find a free port when the device on the first port >> is a USB_SPEED_SUPER device and non-super speed device is being attached. >> It keeps checking the first port and

Re: 4.14 dwc3 gadget mode WARNING on unplug

2017-11-30 Thread Felipe Balbi
Hi, Vincent Pelletier writes: > On Tue, 28 Nov 2017 16:31:48 +, Vincent Pelletier > wrote: >> [ 81.326172] dwc3_send_gadget_ep_cmd -> -110 > > I increased "timeout" to 1000 and added this line: > printk( >

Re: [PATCH] usb: dwc2: gadget: fix dwc2_check_param_tx_fifo_sizes

2017-11-30 Thread Amelie DELAUNAY
Hi Minas, On 11/30/2017 10:43 AM, Minas Harutyunyan wrote: > Hi Amelie, > > On 11/27/2017 6:42 PM, Amelie Delaunay wrote: >> In case of OTG mode, with an OTG adapter plugged, the >> dwc2_check_param_tx_fifo_sizes function reads DPTXFSIZN registers while >> the controller is in Host mode, and,

RE: [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status()

2017-11-30 Thread Yoshihiro Shimoda
Hi, > From: Ulf Hansson, Sent: Wednesday, November 29, 2017 6:59 PM > > On 29 November 2017 at 10:43, Geert Uytterhoeven wrote: > > Hi Ulf, > Okay, so the problem remains no matter which solution for wakeup you > pick in genpd. Yes. Today I could reproduce this issue

[GIT PULL] USB fixes for v4.15-rc2

2017-11-30 Thread Felipe Balbi
Hi Greg, Here's the first set of fixes for this -rc cycle. It's small this time around. Either folks are holding back or maybe the gadget framework is getting closer to being ready :-p Anyway, let me know if you want anything to be changed. cheers The following changes since commit

[GIT PULL] USB-serial fixes for v4.15-rc2

2017-11-30 Thread Johan Hovold
The following changes since commit 4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323: Linux 4.15-rc1 (2017-11-26 16:01:47 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git tags/usb-serial-4.15-rc2 for you to fetch changes up to

Re: [PATCH] usb: dwc2: gadget: fix dwc2_check_param_tx_fifo_sizes

2017-11-30 Thread Minas Harutyunyan
Hi Amelie, On 11/27/2017 6:42 PM, Amelie Delaunay wrote: > In case of OTG mode, with an OTG adapter plugged, the > dwc2_check_param_tx_fifo_sizes function reads DPTXFSIZN registers while > the controller is in Host mode, and, because DPTXFSIZN registers are > Device specific registers, the values

[PATCH v1] USB: storage: Remove obsolete "FIXME"

2017-11-30 Thread Mikhail Zaytsev
The fix of "FIXME: Notify the subdrivers..." doesn't actually have any real effect. The "FIXME" changed to simple comment. Signed-off-by: Mikhail Zaytsev --- drivers/usb/storage/usb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: VL805 xHCI DMA read faults

2017-11-30 Thread Hao Wei Tee
On 16/10/2017 20:23, Robin Murphy wrote: > On 16/10/17 12:54, Hao Wei Tee wrote: >> On 12/10/2017 21:36, Mathias Nyman wrote: >>> You could try booting with xhci_hcd.dyndbg=+p added to the kernel command >>> line. >> >> I can't find anything relevant... Hmm. > > Is your VL805 on the motherboard

Re: [PATCH v2] usb: xhci: allow imod-interval to be configurable

2017-11-30 Thread Mathias Nyman
On 29.11.2017 19:46, Greg Kroah-Hartman wrote: On Wed, Nov 29, 2017 at 10:52:55AM -0500, Adam Wallis wrote: The xHCI driver currently has the IMOD set to 160, which translates to an IMOD interval of 40,000ns (160 * 250)ns Commit 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host controller")

Re: [PATCH] usbip: fix usbip attach to find a port that matches the requested speed

2017-11-30 Thread Greg KH
On Wed, Nov 29, 2017 at 03:24:22PM -0700, Shuah Khan wrote: > usbip attach fails to find a free port when the device on the first port > is a USB_SPEED_SUPER device and non-super speed device is being attached. > It keeps checking the first port and returns without a match getting stuck > in a

[PATCH] usb: dwc2: Fix TxFIFOn sizes and total TxFIFO size issues

2017-11-30 Thread Minas Harutyunyan
In host mode reading from DPTXSIZn returning invalid value in dwc2_check_param_tx_fifo_sizes function. In total TxFIFO size calculations unnecessarily reducing by ep_info. hw->total_fifo_size can be fully allocated for FIFO's. Added num_dev_in_eps member in dwc2_hw_params structure to save