Re: [PATCH 2/2] arm64: dts: exynos: add OF graph between USB-PHY and MUIC

2018-01-31 Thread Krzysztof Kozlowski
On Wed, Jan 31, 2018 at 4:57 PM, Andrzej Hajda wrote: > OF graph describes USB data lanes between USB-PHY and respective MUIC. > Since graph is present and DWC driver can use it to get extcon, obsolete > extcon property can be removed. > > Signed-off-by: Andrzej Hajda

Re: [PATCH 5/5] USB: serial: f81232: fix bulk_in/out size

2018-01-31 Thread Ji-Ze Hong (Peter Hong)
Hi Johan, Johan Hovold 於 2018/1/30 下午 12:11 寫道: On Mon, Jan 22, 2018 at 03:58:47PM +0800, Ji-Ze Hong (Peter Hong) wrote: diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c index a054f69446fd..f3ee537d643c 100644 --- a/drivers/usb/serial/f81232.c +++

Re: [PATCH] ohci-hcd: Fix race condition caused by ohci_urb_enqueue() and io_watchdog_func()

2018-01-31 Thread Yoshida, Shigeru
Hi Alan, Thank you for your commenting. On Wed, 31 Jan 2018 11:02:47 -0500, Alan Stern wrote: >> To address above scenario, this patch introduces timer_running flag to >> ohci_hcd structure. Setting true to ohci->timer_running indicates >> io_watchdog_func() is scheduled or is running.

[no subject]

2018-01-31 Thread Sally Davidson
-- Guten Tag: Sind Sie in finanziellen Schwierigkeiten? Benötigen Sie ein Darlehen mit niedrigem Zinssatz? Wenn ja, kontaktieren Sie uns jetzt mit Ihr Name: Land: Darlehensbetrag: Telefonnummer: Darlehens Dauer: Staat: Sex: Beruf: Monatliches Einkommen: Alter: Privatadresse: -- To unsubscribe

[PATCH 1/1] usb: host: ehci: use correct device pointer for dma ops

2018-01-31 Thread Peter Chen
commit a8c06e407ef9 ("usb: separate out sysdev pointer from usb_bus") converted to use hcd->self.sysdev for DMA operations instead of hcd->self.controller, but forgot to do it for hcd test mode. Replace the correct one in this commit. Fixes: a8c06e407ef9 ("usb: separate out sysdev pointer from

RE: [resend] Questions about "usb usb8-port1: cannot disable (err = -32)"

2018-01-31 Thread Yoshihiro Shimoda
Hi Mathias, > From: Mathias Nyman, Sent: Wednesday, January 31, 2018 9:25 PM > > On 30.01.2018 17:54, Alan Stern wrote: > > On Tue, 30 Jan 2018, Mathias Nyman wrote: > > > >>> Question 2: > >>>- How do I resolve the issue? (I don't have any idea for now...) > >> > >> Is there any other

Re: [PATCH 2/2] sparc,leon: Select USB_UHCI_BIG_ENDIAN_{MMIO,DESC}

2018-01-31 Thread David Miller
From: James Hogan Date: Wed, 31 Jan 2018 22:24:46 + > Now that USB_UHCI_BIG_ENDIAN_MMIO and USB_UHCI_BIG_ENDIAN_DESC are moved > outside of the USB_SUPPORT conditional, simply select them from > SPARC_LEON rather than by the symbol's defaults in drivers/usb/Kconfig, >

Re: [PATCH 3/5] USB: serial: f81232: enable remote wakeup via RX/RI pin

2018-01-31 Thread Ji-Ze Hong (Peter Hong)
Hi Johan, Johan Hovold 於 2018/1/30 上午 11:57 寫道: On Mon, Jan 22, 2018 at 03:58:45PM +0800, Ji-Ze Hong (Peter Hong) wrote: The F81232 can do remote wakeup via RX/RI pin with pulse. This patch will use device_set_wakeup_enable to enable this feature. This is a policy decision that should be

[PATCH 1/1] usb: host: ehci: always enable interrupt for qtd completion at test mode

2018-01-31 Thread Peter Chen
At former code, the SETUP stage does not enable interrupt for qtd completion, it relies on IAA watchdog to complete interrupt, then the transcation would be considered timeout if the flag need_io_watchdog is cleared by platform code. In this commit, we always add enable interrupt for qtd

RE: [PATCH] usb: host: xhci-hub: avoid xhci_warn() when PORT_PE was clear.

2018-01-31 Thread Yoshihiro Shimoda
Hi, > From: Mathias Nyman, Sent: Wednesday, January 31, 2018 9:29 PM > > On 31.01.2018 13:58, Yoshihiro Shimoda wrote: > > The commit 37be66767e3c ("usb: hub: Fix auto-remount of safely removed > > or ejected USB-3 devices") causes the following error when we > > disconnected a usb 3.0 device on

Re: Problem with xhci_hcd on Gigabyte Z170X Gaming 7-EK

2018-01-31 Thread Herbert Poetzl
On Wed, Jan 31, 2018 at 04:58:58PM +0200, Mathias Nyman wrote: > On 30.01.2018 08:06, Herbert Poetzl wrote: >> On Mon, Jan 29, 2018 at 02:26:52PM +0200, Mathias Nyman wrote: >>> On 20.01.2018 06:20, Herbert Poetzl wrote: I've recently acquired a Gigabyte Z170X Gaming 7-EK motherboard

Re: [PATCH] option: Add support for Quectel EP06

2018-01-31 Thread Dan Williams
On Wed, 2018-01-31 at 16:32 -0600, Dan Williams wrote: > On Thu, 2018-02-01 at 09:17 +1100, Johan Hovold wrote: > > On Wed, Jan 31, 2018 at 09:56:01AM +0100, Kristian Evensen wrote: > > > Hi Johan, > > > > > > On Wed, Jan 31, 2018 at 7:38 AM, Johan Hovold > > > wrote: > > > >

Re: [PATCH] option: Add support for Quectel EP06

2018-01-31 Thread Dan Williams
On Thu, 2018-02-01 at 09:17 +1100, Johan Hovold wrote: > On Wed, Jan 31, 2018 at 09:56:01AM +0100, Kristian Evensen wrote: > > Hi Johan, > > > > On Wed, Jan 31, 2018 at 7:38 AM, Johan Hovold > > wrote: > > > This will probably have to do for now, but we already have > > >

[PATCH 1/2] usb: Move USB_UHCI_BIG_ENDIAN_* out of USB_SUPPORT

2018-01-31 Thread James Hogan
Move the Kconfig symbols USB_UHCI_BIG_ENDIAN_MMIO and USB_UHCI_BIG_ENDIAN_DESC out of drivers/usb/host/Kconfig, which is conditional upon USB && USB_SUPPORT, so that it can be freely selected by platform Kconfig symbols in architecture code. For example once the MIPS_GENERIC platform selects are

[PATCH 2/2] sparc,leon: Select USB_UHCI_BIG_ENDIAN_{MMIO,DESC}

2018-01-31 Thread James Hogan
Now that USB_UHCI_BIG_ENDIAN_MMIO and USB_UHCI_BIG_ENDIAN_DESC are moved outside of the USB_SUPPORT conditional, simply select them from SPARC_LEON rather than by the symbol's defaults in drivers/usb/Kconfig, similar to how it is done for USB_EHCI_BIG_ENDIAN_MMIO and USB_EHCI_BIG_ENDIAN_DESC.

[PATCH 0/2] usb: Move USB_UHCI_BIG_ENDIAN_* and select from SPARC_LEON

2018-01-31 Thread James Hogan
This series moves USB_UHCI_BIG_ENDIAN_MMIO and USB_UHCI_BIG_ENDIAN_DESC to a place where they can be easily selected from architecture code, like USB_EHCI_BIG_ENDIAN_* are. Patch 1 is primarily to fix MIPS generic platform warnings when this patch ("MIPS: fix typo BIG_ENDIAN to CPU_BIG_ENDIAN")

Re: [PATCH] option: Add support for Quectel EP06

2018-01-31 Thread Johan Hovold
On Wed, Jan 31, 2018 at 09:56:01AM +0100, Kristian Evensen wrote: > Hi Johan, > > On Wed, Jan 31, 2018 at 7:38 AM, Johan Hovold wrote: > > This will probably have to do for now, but we already have another > > blacklist struct with the same content which we could rename and > >

[PATCH v4 15/15] usb: gadget: mass_storage: Set max_speed to SSP

2018-01-31 Thread Thinh Nguyen
Increase max_speed of the mass_storage driver for UDCs that support SuperSpeed Plus. The composite driver will pass this value to UDC core to set the device speed on probe (actual speed may be different depending on whether the USB controller supports it or other external factors). Signed-off-by:

[PATCH v4 13/15] usb: dwc3: Add workaround for isoc start transfer failure

2018-01-31 Thread Thinh Nguyen
In DWC_usb31 version 1.70a-ea06 and prior, for highspeed and fullspeed isochronous IN, BIT[15:14] of the 16-bit microframe number reported by the XferNotReady event are invalid. The driver uses this number to schedule the isochronous transfer and passes it to the START TRANSFER command. Because

[PATCH v4 14/15] usb: dwc3: Check controller type before setting speed

2018-01-31 Thread Thinh Nguyen
DWC_usb3 speed can only be set up to SuperSpeed. Limit the setting to SuperSpeed only should the value be higher. Otherwise, the controller will read an invalid speed value and set the device to an incorrect speed. Signed-off-by: Thinh Nguyen --- drivers/usb/dwc3/gadget.c |

[PATCH v4 11/15] usb: dwc3: Track DWC_usb31 VERSIONTYPE

2018-01-31 Thread Thinh Nguyen
Add a new field to dwc3 structure to track VERSIONTYPE. The VERSIONTYPE is represented in ASCII in the 32-bit VERSIONTYPE register. In DWC_usb31, sub releases for each version are tracked with VERSIONTYPE such as "ea01" and "ea02". Signed-off-by: Thinh Nguyen ---

[PATCH v4 12/15] usb: dwc3: Add disabling of start_transfer failure quirk

2018-01-31 Thread Thinh Nguyen
In DWC_usb31 version 1.70a-ea06 and prior needs a SW workaround for isoc START TRANSFER command failure. However, some affected versions may have RTL patches to fix this without a SW workaround. Add this quirk to disable the SW workaround when it is not needed. Synopsys STAR 9001202023: Wrong

[PATCH v4 10/15] usb: dwc3: Dump LSP and BMU debug info

2018-01-31 Thread Thinh Nguyen
Dump LSP and BMU debug info. Signed-off-by: Thinh Nguyen --- drivers/usb/dwc3/core.h| 5 + drivers/usb/dwc3/debugfs.c | 5 + 2 files changed, 10 insertions(+) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index e53ae6038bbe..fd794972802d 100644

[PATCH v4 09/15] usb: dwc3: Check for ESS TX/RX threshold config

2018-01-31 Thread Thinh Nguyen
Check and configure TX/RX threshold for DWC_usb31. Update dwc3 structure with new fields to store these threshold configurations. Signed-off-by: Thinh Nguyen --- drivers/usb/dwc3/core.c | 55 + drivers/usb/dwc3/core.h | 8

[PATCH v4 08/15] usb: dwc3: Make TX/RX threshold configurable

2018-01-31 Thread Thinh Nguyen
DWC_usb31 periodic transfer at 48K+ bytes per interval may need modification to the TX/RX packet threshold to achieve optimal result. Add properties to make it configurable. By default, periodic ESS TX and RX threshold are not enabled. To enable TX or RX threshold (host mode only), both packet

[PATCH v4 05/15] usb: dwc3: Add DWC_usb31 GRXTHRCFG bit fields

2018-01-31 Thread Thinh Nguyen
Add new GRXTHRCFG bit field macros for DWC_usb31. The GRXTHRCFG register fields for DWC_usb31 is as follows: +---+--+--+ | BITS | Name | Description |

[PATCH v4 06/15] usb: dwc3: gadget: Check IP revision for GRXTHRCFG

2018-01-31 Thread Thinh Nguyen
DWC_usb31 controller has a different UsbRxPktCnt bit fields from GRXTHRCFG register. Check for DWC_usb31 IP revision to read the appropriate value. Signed-off-by: Thinh Nguyen --- drivers/usb/dwc3/gadget.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

[PATCH v4 07/15] usb: dwc3: Add DWC_usb31 GTXTHRCFG reg fields

2018-01-31 Thread Thinh Nguyen
Add new GTXTHRCFG bit field macros for DWC_usb31. The GTXTHRCFG register fields for DWC_usb31 is as follows: +---+--+---+ | BITS | Name | Description |

[PATCH v4 04/15] usb: dwc3: Check IP revision for GTXFIFOSIZ

2018-01-31 Thread Thinh Nguyen
DWC_usb31 controller has different GTXFIFOSIZE bit field for TXFDEF. Check for DWC_usb31 IP revision to read the appropriate bit fields. Signed-off-by: Thinh Nguyen --- drivers/usb/dwc3/gadget.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v4 03/15] usb: dwc3: Update DWC_usb31 GTXFIFOSIZ reg fields

2018-01-31 Thread Thinh Nguyen
Update two GTXFIFOSIZ bit fields for the DWC_usb31 controller. TXFDEP is a 15-bit value instead of 16-bit value, and bit 15 is TXFRAMNUM. The GTXFIFOSIZ register for DWC_usb31 is as follows: +---+---+--+ | BITS | Name | Description

[PATCH v4 02/15] usb: core: urb: Check SSP isoc ep comp descriptor

2018-01-31 Thread Thinh Nguyen
The maximum bytes per interval for USB SuperSpeed Plus can be set by isoc endpoint companion descriptor when it is above 48K. If the descriptor is provided, then use its value. USB 3.1 spec 9.6.8 Signed-off-by: Thinh Nguyen --- drivers/usb/core/urb.c | 8 1 file

[PATCH v4 00/15] usb: dwc3: Add new updates for DWC_usb31

2018-01-31 Thread Thinh Nguyen
This patch series adds new updates and some fixes for DWC_usb31. Changes in v4: - Correctly refer "databook" as "programming guide" - Document more detail about enabling of ESS periodic tx/rx threshold Changes in v3: - Add "usb: dwc3: Check controller type before setting speed" to series

[PATCH v4 01/15] usb: dwc3: Add SoftReset PHY synchonization delay

2018-01-31 Thread Thinh Nguyen
>From DWC_usb31 programming guide section 1.3.2, once DWC3_DCTL_CSFTRST bit is cleared, we must wait at least 50ms before accessing the PHY domain (synchronization delay). Signed-off-by: Thinh Nguyen --- drivers/usb/dwc3/core.c | 13 - 1 file changed, 12

Re: [PATCH] ohci-hcd: Fix race condition caused by ohci_urb_enqueue() and io_watchdog_func()

2018-01-31 Thread Alan Stern
On Wed, 31 Jan 2018, Haiqing Bai wrote: > Running io_watchdog_func() while ohci_urb_enqueue() is running can > cause a race condition where ohci->prev_frame_no is corrupted and the > watchdog can mis-detect following error: > > ohci-platform 664a0800.usb: frame counter not updating; disabled >

[PATCH 0/2] USB: dwc3: get extcon device by OF graph bindings

2018-01-31 Thread Andrzej Hajda
Hi, This small patchset tries to address issue with broken DT extcon property in case of USB controller - DWC3. It exposes similar problem as in proposed USB connector bindings[1] - extcon device is required by devices not always connected directly to extcon device. Here we have: DWC3 -> USB-PHY

[PATCH 1/2] USB: dwc3: get extcon device by OF graph bindings

2018-01-31 Thread Andrzej Hajda
extcon device is used to detect host/device connection. Since extcon OF property is deprecated, alternative method should be added. This method uses OF graph bindings to locate extcon. Signed-off-by: Andrzej Hajda --- Hi all, This patch implements alternative method to get

[PATCH 2/2] arm64: dts: exynos: add OF graph between USB-PHY and MUIC

2018-01-31 Thread Andrzej Hajda
OF graph describes USB data lanes between USB-PHY and respective MUIC. Since graph is present and DWC driver can use it to get extcon, obsolete extcon property can be removed. Signed-off-by: Andrzej Hajda --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 18

Re: Problem with xhci_hcd on Gigabyte Z170X Gaming 7-EK

2018-01-31 Thread Mathias Nyman
On 30.01.2018 08:06, Herbert Poetzl wrote: On Mon, Jan 29, 2018 at 02:26:52PM +0200, Mathias Nyman wrote: On 20.01.2018 06:20, Herbert Poetzl wrote: I've recently acquired a Gigabyte Z170X Gaming 7-EK motherboard with the Intel Z170 chipset and Sunrise Point-H USB 3.0 xHCI Controller for

[RFC PATCH v2 0/5] dt-bindings: add bindings for USB physical connector

2018-01-31 Thread Andrzej Hajda
Hi, This patchset introduces USB physical connector bindings, together with working example. I have added comments in relevant patches to describe possible issues. In v2 I have addressed comments by Rob and Laurent, thanks Changes are described in patches. Regards Andrzej Andrzej Hajda (4):

[RFC PATCH v2 3/5] arm64: dts: exynos: add OF graph between MHL and USB connector

2018-01-31 Thread Andrzej Hajda
OF graph describes MHL data lanes between MHL and respective USB connector. Signed-off-by: Andrzej Hajda --- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 31 +++--- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git

[RFC PATCH v2 5/5] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

2018-01-31 Thread Andrzej Hajda
From: Maciej Purski Currently MHL chip must be turned on permanently to detect MHL cable. It duplicates micro-USB controller's (MUIC) functionality and consumes unnecessary power. Lets use extcon attached to MUIC to enable MHL chip only if it detects MHL cable.

[RFC PATCH v2 4/5] extcon: add possibility to get extcon device by OF node

2018-01-31 Thread Andrzej Hajda
Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda Acked-by: Chanwoo Choi --- v2: changed label to follow local

[RFC PATCH v2 1/5] dt-bindings: add bindings for USB physical connector

2018-01-31 Thread Andrzej Hajda
These bindings allow to describe most known standard USB connectors and it should be possible to extend it if necessary. USB connectors, beside USB can be used to route other protocols, for example UART, Audio, MHL. In such case every device passing data through the connector should have

[RFC PATCH v2 2/5] arm64: dts: exynos: add micro-USB connector node to TM2 platforms

2018-01-31 Thread Andrzej Hajda
Since USB connector bindings are available we can describe it on TM2(e). Signed-off-by: Andrzej Hajda --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi

Re: [PATCH] usb: host: xhci-hub: avoid xhci_warn() when PORT_PE was clear.

2018-01-31 Thread Mathias Nyman
On 31.01.2018 13:58, Yoshihiro Shimoda wrote: The commit 37be66767e3c ("usb: hub: Fix auto-remount of safely removed or ejected USB-3 devices") causes the following error when we disconnected a usb 3.0 device on some environment (e.g. R-Car H3): xhci-hcd ee00.usb: Cannot set link state.

Re: [resend] Questions about "usb usb8-port1: cannot disable (err = -32)"

2018-01-31 Thread Mathias Nyman
On 30.01.2018 17:54, Alan Stern wrote: On Tue, 30 Jan 2018, Mathias Nyman wrote: On 26.01.2018 03:47, Yoshihiro Shimoda wrote: I resent this email with adding Mathias, Alan and Greg as CC. -Original Message- From: Yoshihiro Shimoda, Sent: Thursday, January 18, 2018 6:03 PM To:

[PATCH] usb: host: xhci-hub: avoid xhci_warn() when PORT_PE was clear.

2018-01-31 Thread Yoshihiro Shimoda
The commit 37be66767e3c ("usb: hub: Fix auto-remount of safely removed or ejected USB-3 devices") causes the following error when we disconnected a usb 3.0 device on some environment (e.g. R-Car H3): xhci-hcd ee00.usb: Cannot set link state. usb usb8-port1: cannot disable (err = -32)

RE: [resend] Questions about "usb usb8-port1: cannot disable (err = -32)"

2018-01-31 Thread Yoshihiro Shimoda
Hi Mathias, Alan, > -Original Message- > From: Alan Stern, Sent: Wednesday, January 31, 2018 12:54 AM > > On Tue, 30 Jan 2018, Mathias Nyman wrote: > > > On 26.01.2018 03:47, Yoshihiro Shimoda wrote: > > > I resent this email with adding Mathias, Alan and Greg as CC. > > > > > >

Re: uas failing on multiple disk access on a jmicron JMS567 bridge

2018-01-31 Thread Menion
Hello Actually the mentioned ones are the very first synthomps that something is going wrong: Jan 27 08:56:06 Menionubuntu systemd[1]: dev-disk-by\x2duuid-ba1e0d88\x2d2e26\x2d499d\x2d8fe3\x2d458b9c53349a.device: Dev dev-disk-by\x2duuid-ba1e0d88\x2d2e26\x2d499d\x2d8fe3\x2d458b9c53349a.device

[PATCH] ohci-hcd: Fix race condition caused by ohci_urb_enqueue() and io_watchdog_func()

2018-01-31 Thread Haiqing Bai
Running io_watchdog_func() while ohci_urb_enqueue() is running can cause a race condition where ohci->prev_frame_no is corrupted and the watchdog can mis-detect following error: ohci-platform 664a0800.usb: frame counter not updating; disabled ohci-platform 664a0800.usb: HC died; cleaning up

Re: [PATCH] option: Add support for Quectel EP06

2018-01-31 Thread Kristian Evensen
Hi Johan, On Wed, Jan 31, 2018 at 7:38 AM, Johan Hovold wrote: > This will probably have to do for now, but we already have another > blacklist struct with the same content which we could rename and > reuse. I noticed the same, but wasn't quite sure about the policy on