[PATCH] usb: hub: Per-port setting to use old enumeration scheme

2018-05-22 Thread Nicolas Boichat
The "old" enumeration scheme is considerably faster (it takes ~294ms instead of ~439ms to get the descriptor). It is currently only possible to use the old scheme globally (/sys/module/usbcore/parameters/old_scheme_first), which is not desirable as the new scheme was introduced to increase

Re: [PATCH v1 2/4] usb: dwc2: Modify dwc2_readl/writel functions prototype

2018-05-22 Thread kbuild test robot
Hi Gevorg, Thank you for the patch! Yet something to improve: [auto build test ERROR on usb/usb-testing] [also build test ERROR on v4.17-rc6] [cannot apply to balbi-usb/next next-20180517] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2] usb: xhci: force all memory allocations to node

2018-05-22 Thread Adam Wallis
On 5/22/2018 6:46 PM, Timur Tabi wrote: > On 5/22/18 1:55 PM, Adam Wallis wrote: >> +    struct device *dev = xhci_to_hcd(xhci)->self.sysdev; > > Since you only use 'dev' to get the NUMA node, you might want to consider this > instead: > > int node =

Re: [PATCH v2] usbip: dynamically allocate idev by nports found in sysfs

2018-05-22 Thread Shuah Khan
On 05/22/2018 11:04 AM, Michael Grzeschik wrote: > As the amount of available ports varies by the kernels build > configuration. To remove the limitation of the fixed 128 ports > we allocate the amount of idevs by using the number we get > from the kernel. > > Signed-off-by: Michael Grzeschik

Re: [PATCH v2] usb: xhci: force all memory allocations to node

2018-05-22 Thread Timur Tabi
On 5/22/18 1:55 PM, Adam Wallis wrote: + struct device *dev = xhci_to_hcd(xhci)->self.sysdev; Since you only use 'dev' to get the NUMA node, you might want to consider this instead: int node = dev_to_node(xhci_to_hcd(xhci)->self.sysdev); -- Qualcomm Datacenter Technologies,

Re: [PATCH 02/18] dt-bindings: usb: add bindings doc for HiSilicon STB xHCI host controller

2018-05-22 Thread Rob Herring
On Tue, May 22, 2018 at 8:31 AM, Mathias Nyman wrote: > On 22.05.2018 13:06, Greg KH wrote: >> >> On Mon, May 21, 2018 at 04:39:50PM +0300, Mathias Nyman wrote: >>> >>> From: Jianguo Sun >>> >>> This commit adds bindings doc for HiSilicon

Re: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down feature

2018-05-22 Thread John Stultz
On Tue, May 22, 2018 at 7:24 AM, Minas Harutyunyan wrote: > Hi John, > > Please provide log with debug enabled configuration. Ok. Attached. For dmesg-broken.log: OTG removed at 77, and OTG plugged in at 82 For dmesg-with-patch.log: OTG removed at 31, OTG plugged

Re: [PATCH 1/5] phy: allwinner: add phy driver for USB3 PHY on Allwinner H6 SoC

2018-05-22 Thread Rob Herring
On Mon, May 07, 2018 at 11:18:13PM +0800, Icenowy Zheng wrote: > Allwinner H6 SoC contains a USB3 PHY (with USB2 DP/DM lines also > controlled). > > Add a driver for it. > > The register operations in this driver is mainly extracted from the BSP > USB3 driver. > > Signed-off-by: Icenowy Zheng

Re: [PATCH 4/5] arm64: allwinner: h6: add USB3 device nodes

2018-05-22 Thread Rob Herring
On Tue, May 08, 2018 at 11:31:27AM +0300, Sergei Shtylyov wrote: > Hello! > > On 5/7/2018 6:18 PM, Icenowy Zheng wrote: > > > Allwinner H6 SoC features USB3 functionality, with a DWC3 controller and > > a custom PHY. > > > > Add device tree nodes for them. > > > > Signed-off-by: Icenowy Zheng

Re: Threaded interrupts for USB HCD instead of tasklets

2018-05-22 Thread Alan Stern
On Tue, 22 May 2018, Sebastian Andrzej Siewior wrote: > On 2018-05-07 11:37:29 [-0400], Alan Stern wrote: > > > As far as I understand it there should be no deadlock. Without the > > > local_irq_save() things should not deadlock because the HCD invokes USB > > > driver's (usb-storage for

Re: [PATCH] usb: gadget: uvc: Utilise instance name in video name

2018-05-22 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 22 May 2018 18:29:49 EEST Kieran Bingham wrote: > From: Kieran Bingham > > With multiple UVC gadgets on a composite device, the device names become > indistinguishable from one another. > > Extend the gadget

[PATCH v2] usb: xhci: force all memory allocations to node

2018-05-22 Thread Adam Wallis
The xhci driver forces DMA memory to be node aware, however, there are several ring-related memory allocations that are not memory node aware. This patch resolves those *alloc functions to be allocated on the proper memory node. Signed-off-by: Adam Wallis --- changes from

Re: dwc2: Regression on 96Boards Hikey due to enabling power down

2018-05-22 Thread Manivannan Sadhasivam
+ John Stultz. John submitted a patch recently to temporarily fix the issue by disabling the power down feature in Hikey. https://lkml.org/lkml/2018/5/21/730 John, I have listed some of my findings to this thread which will help debugging the issue. Thanks, Mani On Thu, May 17, 2018 at

Re: Threaded interrupts for USB HCD instead of tasklets

2018-05-22 Thread Sebastian Andrzej Siewior
On 2018-05-07 11:37:29 [-0400], Alan Stern wrote: > > As far as I understand it there should be no deadlock. Without the > > local_irq_save() things should not deadlock because the HCD invokes USB > > driver's (usb-storage for instance) ->complete callback always in the > > same way. If you mix

Re: [PATCH v2 11/11] docs: fix broken references with multiple hints

2018-05-22 Thread Rob Herring
On Wed, May 09, 2018 at 10:18:54AM -0300, Mauro Carvalho Chehab wrote: > The script: > ./scripts/documentation-file-ref-check --fix-rst > > Gives multiple hints for broken references on some files. > Manually use the one that applies for some files. > > Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH/RFC v4 2/4] usb: gadget: udc: renesas_usb3: Add register of usb role switch

2018-05-22 Thread Rob Herring
On Tue, May 22, 2018 at 09:01:07PM +0900, Yoshihiro Shimoda wrote: > This patch adds role switch support for R-Car SoCs into the USB 3.0 > peripheral driver. Some R-Car SoCs (e.g. R-Car H3) have USB 3.0 > dual-role device controller which has the USB 3.0 xHCI host and > Renesas USB 3.0 peripheral.

Re: [RFC] driver core: don't hold dev's parent lock when using async probe

2018-05-22 Thread Alan Stern
On Tue, 22 May 2018, martin_liu wrote: > SOC have internal I/O buses that can't be probed for devices. The > devices on the buses can be accessed directly without additinal > configuration required. This type of bus is represented as > "simple-bus". In some platforms, we name "soc" with

[PATCH v2] usbip: dynamically allocate idev by nports found in sysfs

2018-05-22 Thread Michael Grzeschik
As the amount of available ports varies by the kernels build configuration. To remove the limitation of the fixed 128 ports we allocate the amount of idevs by using the number we get from the kernel. Signed-off-by: Michael Grzeschik --- v1 -> v2: - reworked memory

Re: [PATCH 1/2] power: supply: Add fwnode pointer to power_supply_config struct

2018-05-22 Thread Sebastian Reichel
Hi, On Tue, May 22, 2018 at 04:16:23PM +0100, Adam Thomson wrote: > To allow users of the power supply framework to be hw description > agnostic, this commit adds the ability to pass a fwnode pointer, > via the power_supply_config structure, to the initialisation code > of the core, instead of

Re: [PATCH v3] usbip: vhci_sysfs: fix potential Spectre v1

2018-05-22 Thread Gustavo A. R. Silva
On 05/22/2018 10:56 AM, Shuah Khan wrote: On 05/18/2018 07:13 PM, Gustavo A. R. Silva wrote: pdev_nr and rhport can be controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. This issue was detected with the help of Smatch:

Re: [PATCH 2/2] typec: tcpm: Provide fwnode pointer as part of psy_cfg

2018-05-22 Thread Guenter Roeck
On Tue, May 22, 2018 at 04:16:24PM +0100, Adam Thomson wrote: > For supply registration, provide fwnode pointer of the port device, > via the power_supply_config structure, to allow other psy drivers > to add us as a supplier. At present this only applies to DT > based platforms using the

Re: [PATCH] usbip: dynamically allocate idev by nports found in sysfs

2018-05-22 Thread Shuah Khan
Hi Michael, Thanks for the patch. Couple of comments below: On 05/18/2018 08:39 AM, Michael Grzeschik wrote: > As the amount of available ports varies by the kernels build > configuration. To remove the limitation of the fixed 128 ports > we allocate the amount of idevs by using the number we

Re: [PATCH v3] usbip: vhci_sysfs: fix potential Spectre v1

2018-05-22 Thread Shuah Khan
On 05/18/2018 07:13 PM, Gustavo A. R. Silva wrote: > pdev_nr and rhport can be controlled by user-space, hence leading to > a potential exploitation of the Spectre variant 1 vulnerability. > > This issue was detected with the help of Smatch: > drivers/usb/usbip/vhci_sysfs.c:238 detach_store()

Re: [Query] checking hub port status while USB 2.0 port is resuming.

2018-05-22 Thread Alan Stern
On Tue, 22 May 2018, Anshuman Gupta wrote: > On Tue, May 22, 2018 at 09:53:09AM -0400, Alan Stern wrote: > > On Tue, 22 May 2018, Anshuman Gupta wrote: > > > Thanks Alan for your quick response. > > > Hi, > > > > > > When a xhci USB2.0 port is resuming and waiting for resume signaling, > > >

spende

2018-05-22 Thread Richard wahl
Hallo, Sie haben eine Spende von 2.800.000,00 Euro, ich habe die Amerikanische Lotterie in Amerika im Wert von 533 Millionen Dollar gewonnen, und ich gebe einen Teil davon als Teil einer Wohltätigkeitsorganisation. Kontaktieren Sie mich für weitere Informationen: richardwahl.donati...@gmail.com

[PATCH] usb: gadget: uvc: Utilise instance name in video name

2018-05-22 Thread Kieran Bingham
From: Kieran Bingham With multiple UVC gadgets on a composite device, the device names become indistinguishable from one another. Extend the gadget video name to incorporate the function instance name, along side the existing UDC controller name. Signed-off-by:

[PATCH 2/2] typec: tcpm: Provide fwnode pointer as part of psy_cfg

2018-05-22 Thread Adam Thomson
For supply registration, provide fwnode pointer of the port device, via the power_supply_config structure, to allow other psy drivers to add us as a supplier. At present this only applies to DT based platforms using the 'power-supplies' DT property, but in the future should also work for ACPI

[PATCH 0/2] typec: tcpm: Populate fwnode for use in power_supply core

2018-05-22 Thread Adam Thomson
This patch set adds support for passing a fwnode pointer as part of the psy config structure, when intialising the psy core, so that calling code can be written to be agnostic of the HW description required for the platform. The TCPM code is updated subsequently to make use of this new field. For

[PATCH 1/2] power: supply: Add fwnode pointer to power_supply_config struct

2018-05-22 Thread Adam Thomson
To allow users of the power supply framework to be hw description agnostic, this commit adds the ability to pass a fwnode pointer, via the power_supply_config structure, to the initialisation code of the core, instead of explicitly specifying of_ndoe. If that fwnode pointer is provided then it

Re: [PATCH v2 0/3] Revised Renesas uPD72020x workaround for 32bit DMA issue

2018-05-22 Thread Christian Brauns
Hi, thanks a lot. In 4.16.9 that renesas USB3 controller is working again. So the positive, it did work for some time - hours, and reading from the attached harddisk was all right. Don't know if I'm allowed or requested to mention the remaining problems. The first thing I want to mention is,

Re: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down feature

2018-05-22 Thread Minas Harutyunyan
Hi John, Please provide log with debug enabled configuration. On 5/21/2018 11:41 PM, John Stultz wrote: > On Mon, May 21, 2018 at 1:45 AM, Minas Harutyunyan > wrote: >> Hi John, >> >> On 5/19/2018 4:49 AM, John Stultz wrote: >>> In 4.17-rc, commit 03ea6d6e9e1f

RE: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-22 Thread Jun Li
Hi Heikki, > -Original Message- > From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > Sent: 2018年5月21日 21:13 > To: Jun Li > Cc: Mats Karrman ; robh...@kernel.org; > gre...@linuxfoundation.org; li...@roeck-us.net; a.ha...@samsung.com;

[RFC] driver core: don't hold dev's parent lock when using async probe

2018-05-22 Thread martin_liu
SOC have internal I/O buses that can't be probed for devices. The devices on the buses can be accessed directly without additinal configuration required. This type of bus is represented as "simple-bus". In some platforms, we name "soc" with "simple-bus" attribute and many devices are hooked under

Re: [Query] checking hub port status while USB 2.0 port is resuming.

2018-05-22 Thread Alan Stern
On Tue, 22 May 2018, Anshuman Gupta wrote: > Hi, > > When a xhci USB2.0 port is resuming and waiting for resume signaling, > completion of > USB_RESUME_TIMEOUT, it just reports the port status as USB_PORT_STAT_SUSPEND, > and let the usbcore to check the port status again. > >

Re: [PATCH 06/12] usb: usbtmc: Add vendor specific/asynchronous read/write ioctls

2018-05-22 Thread Greg KH
On Tue, May 22, 2018 at 11:36:13AM +, gu...@kiener-muenchen.de wrote: > > Zitat von Greg KH : > > > On Mon, May 21, 2018 at 08:41:22PM +, gu...@kiener-muenchen.de wrote: > > > > > > Zitat von Greg KH : > > > > > > > On Fri, May

Re: [PATCH 02/18] dt-bindings: usb: add bindings doc for HiSilicon STB xHCI host controller

2018-05-22 Thread Mathias Nyman
On 22.05.2018 13:06, Greg KH wrote: On Mon, May 21, 2018 at 04:39:50PM +0300, Mathias Nyman wrote: From: Jianguo Sun This commit adds bindings doc for HiSilicon STB xHCI host controller. Signed-off-by: Jianguo Sun Signed-off-by: Mathias Nyman

[PATCH/RFC v4 2/4] usb: gadget: udc: renesas_usb3: Add register of usb role switch

2018-05-22 Thread Yoshihiro Shimoda
This patch adds role switch support for R-Car SoCs into the USB 3.0 peripheral driver. Some R-Car SoCs (e.g. R-Car H3) have USB 3.0 dual-role device controller which has the USB 3.0 xHCI host and Renesas USB 3.0 peripheral. Unfortunately, the mode change register contains the USB 3.0 peripheral

[PATCH/RFC v4 1/4] base: devcon: add graph parse in device_connection_find_match()

2018-05-22 Thread Yoshihiro Shimoda
This patch adds graph parsing in device_connection_find_match(). The match function will be called with fwnode pointer in struct device_connection. So, a caller can check the matching by using it. Signed-off-by: Yoshihiro Shimoda ---

[PATCH/RFC v4 3/4] usb: gadget: udc: renesas_usb3: use usb role switch API

2018-05-22 Thread Yoshihiro Shimoda
This patch uses usb role switch APIs if the register suceeeded. Signed-off-by: Yoshihiro Shimoda --- drivers/usb/gadget/udc/renesas_usb3.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git

[PATCH/RFC v4 4/4] arm64: dts: renesas: r8a7795: add OF graph for usb role switch

2018-05-22 Thread Yoshihiro Shimoda
This patch adds OF graph properties for usb role switch in r8a7795 into USB3.0 host/peripheral nodes. TODO: - need patches for other SoCs. Signed-off-by: Yoshihiro Shimoda --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12 1 file changed, 12

[PATCH/RFC v4 0/4] usb: role: rcar-usb3-role-switch: add support for R-Car SoCs

2018-05-22 Thread Yoshihiro Shimoda
This patch set is based on Felipe's usb.git / testing/next branch (commit id = 47265c067c0d129f3a0e94bc221293a780af9d78). I still marked this patch set as "RFC". I would like to know whether this way is good or not. About last discusstion with Heikki: https://patchwork.kernel.org/patch/10397635/

[PATCH -next] USB: dwc3: make function dwc3_get_extcon() static

2018-05-22 Thread Wei Yongjun
Fixes the following sparse warnings: drivers/usb/dwc3/drd.c:443:19: warning: symbol 'dwc3_get_extcon' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/usb/dwc3/drd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 06/12] usb: usbtmc: Add vendor specific/asynchronous read/write ioctls

2018-05-22 Thread guido
Zitat von Greg KH : On Mon, May 21, 2018 at 08:41:22PM +, gu...@kiener-muenchen.de wrote: Zitat von Greg KH : > On Fri, May 18, 2018 at 02:48:11PM +, gu...@kiener-muenchen.de wrote: > > > > Zitat von Greg KH

Re: [PATCH 01/33] usb: phy: use match_string() helper

2018-05-22 Thread Yisheng Xie
Hi, On 2018/5/22 18:02, Greg Kroah-Hartman wrote: > On Tue, May 22, 2018 at 01:20:01AM +0300, Andy Shevchenko wrote: >> On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie wrote: >>> match_string() returns the index of an array for a matching string, >>> which can be used intead

[Query] checking hub port status while USB 2.0 port is resuming.

2018-05-22 Thread Anshuman Gupta
Hi, When a xhci USB2.0 port is resuming and waiting for resume signaling, completion of USB_RESUME_TIMEOUT, it just reports the port status as USB_PORT_STAT_SUSPEND, and let the usbcore to check the port status again.

Re: [PATCH 02/18] dt-bindings: usb: add bindings doc for HiSilicon STB xHCI host controller

2018-05-22 Thread Greg KH
On Mon, May 21, 2018 at 04:39:50PM +0300, Mathias Nyman wrote: > From: Jianguo Sun > > This commit adds bindings doc for HiSilicon STB xHCI host controller. > > Signed-off-by: Jianguo Sun > Signed-off-by: Mathias Nyman

Re: [PATCH 01/33] usb: phy: use match_string() helper

2018-05-22 Thread Greg Kroah-Hartman
On Tue, May 22, 2018 at 01:20:01AM +0300, Andy Shevchenko wrote: > On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie wrote: > > match_string() returns the index of an array for a matching string, > > which can be used intead of open coded variant. > > > - int err, i; > >

Re: [PATCH 06/12] usb: usbtmc: Add vendor specific/asynchronous read/write ioctls

2018-05-22 Thread Greg KH
On Mon, May 21, 2018 at 08:41:22PM +, gu...@kiener-muenchen.de wrote: > > Zitat von Greg KH : > > > On Fri, May 18, 2018 at 02:48:11PM +, gu...@kiener-muenchen.de wrote: > > > > > > Zitat von Greg KH : > > > > > > > On Thu, May

Re: [PATCH 05/12] usb: usbtmc: Add ioctl for generic requests on control pipe

2018-05-22 Thread Greg KH
On Mon, May 21, 2018 at 10:06:57PM +, gu...@kiener-muenchen.de wrote: > > Zitat von Greg KH : > > > On Fri, May 18, 2018 at 01:32:51PM +, gu...@kiener-muenchen.de wrote: > > > > > > Zitat von Greg KH : > > > > > > > On Thu, May

Re: [PATCH] typec: tcpm: Provide of_node pointer as part of psy_cfg

2018-05-22 Thread Heikki Krogerus
On Mon, May 21, 2018 at 03:34:53PM +, Adam Thomson wrote: > On 21 May 2018 15:56, Heikki Krogerus wrote: > > > On Mon, May 21, 2018 at 01:58:16PM +, Adam Thomson wrote: > > > Hi Heikki, > > > > > > On 21 May 2018 14:20, Heikki Krogerus wrote: > > > > > > > On Wed, May 16, 2018 at

[PATCH] usb: gadget: tcm: fix spelling mistake: "Manufactor" -> "Manufacturer"

2018-05-22 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in usbg_us_strings array Signed-off-by: Colin Ian King --- drivers/usb/gadget/legacy/tcm_usb_gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2 1/2] [usb-storage] Add support for FL_ALWAYS_SYNC flag in the UAS driver

2018-05-22 Thread Oliver Neukum
Am Freitag, den 18.05.2018, 21:50 -0700 schrieb Alexander Kappner: > The ALWAYS_SYNC flag is currently honored by the usb-storage driver but not > UAS > and is required to work around devices that become unstable upon being > queried for cache. This code is taken straight from: >

Re: [usb-storage] Re: [PATCH v2 0/2] Re: usb-storage: Add quirks to make G-Technology "G-Drive" work

2018-05-22 Thread Oliver Neukum
Am Montag, den 21.05.2018, 13:47 -0400 schrieb Alan Stern: > On Fri, 18 May 2018, Alexander Kappner wrote: > > > v2 of this patch implements the FL_ALWAYS_SYNC flag in the UAS driver, and > > then > > adds the flag as quirks for the device at issue. This allows the G-Drive to > > work > > under

Re: [PATCH] tty: add missing const to termios hw-change helper

2018-05-22 Thread Johan Hovold
On Mon, May 21, 2018 at 06:41:30PM +0200, Greg Kroah-Hartman wrote: > On Mon, May 21, 2018 at 01:08:44PM +0200, Johan Hovold wrote: > > Add missing const qualifiers to the termios hw-change helper parameters, > > which is used by few USB serial drivers. This specifically allows the > > pl2303

Re: [PATCH] usb: xhci: force all memory allocations to node

2018-05-22 Thread Mathias Nyman
On 21.05.2018 19:42, Adam Wallis wrote: On 5/21/2018 9:53 AM, Mathias Nyman wrote: On 21.05.2018 15:56, Adam Wallis wrote: Not sure if if there's any benefit in allocating the scratchpad structures from a closer node, or any harm? xhci driver doesn't really access scratchpad that frequently.