Re: [PATCH v3 1/2] usb: dwc3: refactor gadget endpoint count calculation

2017-04-06 Thread Bryan O'Donoghue
On 06/04/17 09:59, Roger Quadros wrote: Hi, On 31/01/17 22:58, Bryan O'Donoghue wrote: - DWC_USB3_NUM indicates the number of Device mode single directional endpoints, including OUT and IN endpoint 0. - DWC_USB3_NUM_IN_EPS indicates the maximum number of Device mode IN endpoints active

Re: [PATCH v3 1/2] usb: dwc3: refactor gadget endpoint count calculation

2017-03-13 Thread Bryan O'Donoghue
On 13/03/17 11:56, Felipe Balbi wrote: Bryan O'Donoghue <pure.lo...@nexus-software.ie> writes: On 10/03/17 12:14, Felipe Balbi wrote: return 0; I can change your patch locally, if you want. I can also drop your patches and wait for replacements. No strong feelings. I'll

Re: [PATCH v3 1/2] usb: dwc3: refactor gadget endpoint count calculation

2017-03-13 Thread Bryan O'Donoghue
On 10/03/17 12:14, Felipe Balbi wrote: return 0; I can change your patch locally, if you want. I can also drop your patches and wait for replacements. No strong feelings. I'll resend Felipe. Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the

[PATCH v3 0/2] Work-around for DWC_USB3_NUM_EPS = DWC_USB3_NUM_IN_EPS

2017-01-31 Thread Bryan O'Donoghue
Felipe Reworded commit log - Felipe Removed DT bindings no long necessary Bryan O'Donoghue (2): usb: dwc3: refactor gadget endpoint count calculation usb: dwc3: remove dwc3_gadget_init_hw_endpoints drivers/usb/dwc3/core.c| 3 +-- drivers/usb/dwc3/core.h| 6 ++ drivers/us

[PATCH v3 1/2] usb: dwc3: refactor gadget endpoint count calculation

2017-01-31 Thread Bryan O'Donoghue
60a of the DWC USB3 databook. The endpoint mapping will then be EP-OUT, EP-IN etc, up to DWC_USB3_NUM. If DWC_USB3_NUM is odd then OUT will take the extra endpoint. Suggested-by: Felipe Balbi <ba...@kernel.org> Signed-off-by: Bryan O'Donoghue <pure.lo...@nexus-software.ie> --- drivers/

[PATCH v3 2/2] usb: dwc3: remove dwc3_gadget_init_hw_endpoints

2017-01-31 Thread Bryan O'Donoghue
initialization of dwc->gadet.ep_list. Signed-off-by: Bryan O'Donoghue <pure.lo...@nexus-software.ie> --- drivers/usb/dwc3/gadget.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index ef86ab6..574d7

Re: [PATCH v3 0/2] Work-around for DWC_USB3_NUM_EPS = DWC_USB3_NUM_IN_EPS

2017-01-31 Thread Bryan O'Donoghue
On 31/01/17 20:58, Bryan O'Donoghue wrote: This is V3 of the previous patchset. This version implements the suggested change from Felipe to rationalise num_in_eps and num_out_eps down to num_eps directly. The old mapping of OUT/IN endpoint pairs is maintained to ensure that fixed-mapped

Re: [PATCH v2] usb: dwc3: handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

2017-01-24 Thread Bryan O'Donoghue
On 24/01/17 19:25, John Youn wrote: On 1/24/2017 3:05 AM, Bryan O'Donoghue wrote: On 23/01/17 22:34, John Youn wrote: On 1/23/2017 2:10 PM, Alan Stern wrote: On Mon, 23 Jan 2017, John Youn wrote: On 1/22/2017 5:29 PM, Bryan O'Donoghue wrote: - DWC_USB3_NUM indicates the number of Device

Re: [PATCH v2] usb: dwc3: handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

2017-01-24 Thread Bryan O'Donoghue
On 23/01/17 22:34, John Youn wrote: > On 1/23/2017 2:10 PM, Alan Stern wrote: >> On Mon, 23 Jan 2017, John Youn wrote: >> >>> On 1/22/2017 5:29 PM, Bryan O'Donoghue wrote: >>>> - DWC_USB3_NUM indicates the number of Device mode single directional >>>&

Re: [PATCH] usb: dwc3: add quirk to handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

2017-01-23 Thread Bryan O'Donoghue
On 23/01/17 15:38, Rob Herring wrote: >> - tx-fifo-resize: determines if the FIFO *has* to be >> reallocated. >> + - snps,num_in_eps_quirk: when set core will over-ride the num_in_eps value. >> + - snps,num_in_eps_override: the value that will be used for num_in_eps when >> +

Re: [PATCH v2] usb: dwc3: handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

2017-01-23 Thread Bryan O'Donoghue
On 23/01/17 12:08, Felipe Balbi wrote: > > Hi, > > Bryan O'Donoghue <pure.lo...@nexus-software.ie> writes: >> - DWC_USB3_NUM indicates the number of Device mode single directional >> endpoints, including OUT and IN endpoint 0. >> >> - DWC_USB3_NUM_IN_

[PATCH v2] usb: dwc3: handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

2017-01-22 Thread Bryan O'Donoghue
alf DWC_USB3_NUM_EPS. If DWC_USB3_NUM_EPS is equal to DWC3_USB3_NUM_IN_EPS and the endpoint count is an odd number then dwc->num_out_eps will be assigned the extra endpoint. Suggested-by: Felipe Balbi <ba...@kernel.org> Signed-off-by: Bryan O'Donoghue <pure.lo...@nexus-software.ie> ---

[PATCH v2] Work-around for DWC_USB3_NUM_EPS = DWC_USB3_NUM_IN_EPS

2017-01-22 Thread Bryan O'Donoghue
DT bindings no long necessary Bryan O'Donoghue (1): usb: dwc3: handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS drivers/usb/dwc3/core.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body

Re: [PATCH] usb: dwc3: add quirk to handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

2017-01-20 Thread Bryan O'Donoghue
On 20/01/17 12:10, Felipe Balbi wrote: >>> And unfortunately, whether this is set or not is not visible to the >>> software so it will require a quirk. >> >> but arrived at this conclusion because I couldn't think of a reasonable >> guess value for IN/OUT endpoint numbers that would work if >>

Re: [PATCH] usb: dwc3: add quirk to handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

2017-01-20 Thread Bryan O'Donoghue
On 19/01/17 22:49, John Youn wrote: > So it is valid to have say, DWC_USB3_NUM_EPS=8 and > DWC_USB3_NUM_IN_EPS=8. Even though it is not possible to use all 8 EPs > as IN since you need at least one of them to be a control OUT. So you > could have a configuration of EP0 IN and OUT plus 6 IN EPs

Re: [PATCH] usb: dwc3: add quirk to handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

2017-01-19 Thread Bryan O'Donoghue
Thanks for the quick feedback Felipe, appreciated, I'll take on-board those changes. --- bod -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] usb: dwc3: add quirk to handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

2017-01-19 Thread Bryan O'Donoghue
-by: Bryan O'Donoghue <pure.lo...@nexus-software.ie> --- Documentation/devicetree/bindings/usb/dwc3.txt | 3 +++ drivers/usb/dwc3/core.c| 11 +++ drivers/usb/dwc3/core.h| 6 ++ 3 files changed, 20 insertions(+) diff