Re: [PATCH] usb: dwc2: host: use hrtimer for NAK retries

Hi, On Tue, Aug 28, 2018 at 11:04 AM, Terin Stock wrote: >> It would also be good to document what device you were plugging in >> that you were having problems with and what system you were running >> on. That would help someone else if they ever wanted to modify the >> same area of code and

Re: [PATCH] usb: dwc2: host: use hrtimer for NAK retries

Hi, On Sat, Aug 25, 2018 at 8:45 PM, Terin Stock wrote: > Upon upgrading a Raspberry Pi 3B-based project from vanilla 4.14, > attempts to mount a floppy disk in a generic USB floppy drive would hang > until the floppy drive was removed from the system. > > Tracing shows that during mounting the

Re: [PATCH 2/2] usb: dwc2: Fix inefficient copy of unaligned buffers

Hi, On Thu, Jul 5, 2018 at 7:31 AM, Antti Seppälä wrote: > Make sure only to copy any actual data rather than the whole buffer, > when releasing the temporary buffer used for unaligned non-isochronous > transfers. > > Taken directly from commit 0efd937e27d5e ("USB: ehci-tegra: fix inefficient >

Re: [PATCH 1/2] usb: dwc2: Fix DMA alignment to start at allocated boundary

Hi, On Thu, Jul 5, 2018 at 7:31 AM, Antti Seppälä wrote: > The commit 3bc04e28a030 ("usb: dwc2: host: Get aligned DMA in a more > supported way") introduced a common way to align DMA allocations. > The code in the commit aligns the struct dma_aligned_buffer but the > actual DMA address pointed

Re: usb: dwc2: crash regression in commit 3bc04e28a030 (bisected)

Hi, On Sun, Jul 1, 2018 at 11:30 PM, Antti Seppälä wrote: > On 30 June 2018 at 02:57, Doug Anderson wrote: >> Hi, >> >> On Fri, Jun 29, 2018 at 11:29 AM, Antti Seppälä wrote: >>> Hi Doug, John and linux-usb. >>> >>> I'd like to report a regres

Re: usb: dwc2: crash regression in commit 3bc04e28a030 (bisected)

Hi, On Fri, Jun 29, 2018 at 11:29 AM, Antti Seppälä wrote: > Hi Doug, John and linux-usb. > > I'd like to report a regression in commit 3bc04e28a030 (usb: dwc2: > host: Get aligned DMA in a more supported way) Seems unlikely, but any chance that

Re: [PATCH] arm64: dts: msm8996: Use dwc3-qcom glue driver for USB

Hi, On Wed, May 30, 2018 at 4:04 AM, Manu Gautam wrote: > Move from dwc3-of-simple to dwc3-qcom glue driver to > support peripheral mode which requires qscratch wrapper > programming on VBUS event. Fixes: a4333c3a6ba9 ("usb: dwc3: Add Qualcomm DWC3 glue driver") > Signed-off-by: Manu Gautam >

Re: [PATCH] usb: dwc2: fix the incorrect bitmaps for the ports of multi_tt hub

Hi, On Mon, May 21, 2018 at 3:12 AM, William Wu wrote: > The dwc2_get_ls_map() use ttport to reference into the > bitmap if we're on a multi_tt hub. But the bitmaps index > from 0 to (hub->maxchild - 1), while the ttport index from > 1 to hub->maxchild. This will cause

Re: [PATCH v4 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

Hi, On Wed, May 9, 2018 at 3:11 AM, William Wu wrote: > The commit 3bc04e28a030 ("usb: dwc2: host: Get aligned DMA in > a more supported way") rips out a lot of code to simply the > allocation of aligned DMA. However, it also introduces a new > issue when use isoc

Re: [PATCH v3 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

Hi, On Wed, May 9, 2018 at 1:55 AM, wlf wrote: > + } else if (hsotg->params.host_dma) { Are you sure this is "else if"? Can't you have descriptor DMA enabled in the controller and still need to do a normal DMA transfer if you plug in a hub?

Re: [PATCH v3 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

Hi, On Tue, May 8, 2018 at 12:43 AM, wlf <w...@rock-chips.com> wrote: > Dear Doug, > > 在 2018年05月08日 13:11, Doug Anderson 写道: >> >> Hi, >> >> On Mon, May 7, 2018 at 8:07 PM, William Wu <william...@rock-chips.com> >> wrote: >>> >&g

Re: [PATCH v3 2/2] usb: dwc2: fix isoc split in transfer with no data

Hi, On Mon, May 7, 2018 at 8:07 PM, William Wu wrote: > If isoc split in transfer with no data (the length of DATA0 > packet is zero), we can't simply return immediately. Because > the DATA0 can be the first transaction or the second transaction > for the isoc split in

Re: [PATCH v3 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

Hi, On Mon, May 7, 2018 at 8:07 PM, William Wu wrote: > +static int dwc2_alloc_split_dma_aligned_buf(struct dwc2_hsotg *hsotg, > + struct dwc2_qh *qh, > + struct dwc2_host_chan *chan) >

Re: [PATCH v5 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values

Rob, On Mon, May 7, 2018 at 8:53 AM, Rob Herring wrote: > On Thu, May 03, 2018 at 02:36:13AM +0530, Manu Gautam wrote: >> To improve eye diagram for PHYs on different boards of same SOC, >> some parameters may need to be changed. Provide device tree >> properties to override

Re: [PATCH v5 1/7] clk: msm8996-gcc: Mark halt check as no-op for USB/PCIE pipe_clk

Hi, On Wed, May 2, 2018 at 2:06 PM, Manu Gautam wrote: > The USB and PCIE pipe clocks are sourced from external clocks > inside the QMP USB/PCIE PHYs. Enabling or disabling of PIPE RCG > clocks is dependent on PHY initialization sequence hence > update halt_check to

Re: [PATCH v5 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values

Hi, On Wed, May 2, 2018 at 2:06 PM, Manu Gautam wrote: > To improve eye diagram for PHYs on different boards of same SOC, > some parameters may need to be changed. Provide device tree > properties to override these from board specific device tree > files. While at it,

Re: [PATCH v5 7/7] phy: qcom-qusb2: Add QUSB2 PHYs support for sdm845

Hi, On Wed, May 2, 2018 at 2:06 PM, Manu Gautam wrote: > There are two QUSB2 PHYs present on sdm845. In order > to improve eye diagram for both the PHYs some parameters > need to be changed. Provide device tree properties to > override these from board specific device

Re: [PATCH v2 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

Hi, On Wed, May 2, 2018 at 10:14 AM, wlf wrote: > It's a good way to allocate an extra 3 bytes in the original bounce buffer > for this unaligned > issue， it's similar to the tailroom of sk_buff. However, just as you said, > we'd better find > the special cases where we need

Re: [PATCH v2 2/2] usb: dwc2: fix isoc split in transfer with no data

Hi, On Tue, May 1, 2018 at 8:04 PM, William Wu wrote: > If isoc split in transfer with no data (the length of DATA0 > packet is zero), we can't simply return immediately. Because > the DATA0 can be the first transaction or the second transaction > for the isoc split in

Re: [PATCH v2 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

Hi, On Tue, May 1, 2018 at 8:04 PM, William Wu wrote: > The commit 3bc04e28a030 ("usb: dwc2: host: Get aligned DMA in > a more supported way") rips out a lot of code to simply the > allocation of aligned DMA. However, it also introduces a new > issue when use isoc

Re: [PATCH v5 00/17] Support for Qualcomm QUSBv2 and QMPv3 USB PHYs

Manu, On Mon, Feb 19, 2018 at 9:21 PM, Manu Gautam wrote: > Hi Kishon, > > > On 2/16/2018 5:19 PM, Kishon Vijay Abraham I wrote: >> >> On Thursday 01 February 2018 06:08 PM, Kishon Vijay Abraham I wrote: >>> >>> The series looks good. I'll start merging once -rc1 is

Re: [PATCH v4] usb: dwc2: host: Don't retry NAKed transactions right away

Hi, On Tue, Dec 19, 2017 at 8:56 AM, Stefan Wahren <stefan.wah...@i2se.com> wrote: > Hi Doug, > >> Doug Anderson <diand...@chromium.org> hat am 19. Dezember 2017 um 16:57 >> geschrieben: >> >> >> Felipe, >> >> On Tue, Dec 12, 2017 at

Re: [PATCH v4] usb: dwc2: host: Don't retry NAKed transactions right away

Felipe, On Tue, Dec 12, 2017 at 10:30 AM, Douglas Anderson wrote: > On rk3288-veyron devices on Chrome OS it was found that plugging in an > Arduino-based USB device could cause the system to lockup, especially > if the CPU Frequency was at one of the slower operating

Re: [PATCH] phy: rockchip-typec: Try to turn the PHY on several times

Hi, On Wed, Dec 13, 2017 at 4:41 AM, Enric Balletbo Serra wrote: > Hi Doug, > > 2017-12-11 22:45 GMT+01:00 Douglas Anderson : >> Bind / unbind stress testing of the USB controller on rk3399 found >> that we'd often end up with lots of failures that

Re: [PATCH v3 1/2] usb: dwc2: host: Don't retry NAKed transactions right away

Hi, On Tue, Dec 12, 2017 at 3:06 AM, Felipe Balbi wrote: > > Hi, > > Douglas Anderson writes: >> On rk3288-veyron devices on Chrome OS it was found that plugging in an >> Arduino-based USB device could cause the system to lockup, especially >> if the CPU

Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

Hi, On Tue, Nov 28, 2017 at 6:37 AM, Stefan Wahren <stefan.wah...@i2se.com> wrote: > Hi Doug, > > Doug Anderson <diand...@chromium.org> hat am 30. Oktober 2017 um 18:14 > geschrieben: > > Hi, > > On Mon, Oct 30, 2017 at 1:32 AM, Felipe Balbi <ba...@kernel.o

Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

Hi, On Mon, Oct 30, 2017 at 1:32 AM, Felipe Balbi <ba...@kernel.org> wrote: > > Hi, > > Doug Anderson <diand...@chromium.org> writes: >> Hi, >> >> On Sat, Oct 28, 2017 at 8:51 AM, Stefan Wahren <stefan.wah...@i2se.com> >> wrote: >>>

Re: [PATCH] usb: dwc2: host: Don't retry NAKed transactions right away

Hi, On Wed, Oct 25, 2017 at 2:08 PM, Douglas Anderson wrote: > On rk3288-veyron devices on Chrome OS it was found that plugging in an > Arduino-based USB device could cause the system to lockup, especially > if the CPU Frequency was at one of the slower operating points

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

Hi, On Mon, Oct 16, 2017 at 1:49 PM, Julius Werner wrote: >> d9a14b00 339317035 C Ii:1:004:1 -32:1 0 >> d9a14b00 339317049 S Ii:1:004:1 -115:1 10 < >> d9a14b00 339318040 C Ii:1:004:1 -32:1 0 >> d9a14b00 339318057 S Ii:1:004:1 -115:1 10 < >> d9a14b00 339319042 C Ii:1:004:1

Re: [PATCH V4] r8152: add Linksys USB3GIGV1 id

Grant, On Thu, Sep 28, 2017 at 11:35 AM, Grant Grundler wrote: > This linksys dongle by default comes up in cdc_ether mode. > This patch allows r8152 to claim the device: >Bus 002 Device 002: ID 13b1:0041 Linksys > > Signed-off-by: Grant Grundler

Re: [PATCH V2] r8152: add Linksys USB3GIGV1 id

Am Dienstag, den 26.09.2017, 08:19 -0700 schrieb Doug Anderson: >>>> >>>> I know that for at least some of the adapters in the CDC Ethernet >>>> blacklist it was claimed that the CDC Ethernet support in the adapter >>>> was kinda broken anyway so the

Re: [PATCH V3] r8152: add Linksys USB3GIGV1 id

Hi, On Wed, Sep 27, 2017 at 5:07 PM, Grant Grundler wrote: >>> #define DELL_VENDOR_ID 0x413C >>> #define REALTEK_VENDOR_ID 0x0bda >>> #define SAMSUNG_VENDOR_ID 0x04e8 >>> +#define LINKSYS_VENDOR_ID 0x13b1 >>> #define LENOVO_VENDOR_ID 0x17ef

Re: [PATCH V3] r8152: add Linksys USB3GIGV1 id

Hi, On Wed, Sep 27, 2017 at 10:28 AM, Grant Grundler wrote: > This linksys dongle by default comes up in cdc_ether mode. > This patch allows r8152 to claim the device: >Bus 002 Device 002: ID 13b1:0041 Linksys > > Signed-off-by: Grant Grundler >

Re: [PATCH V2] r8152: add Linksys USB3GIGV1 id

Hi On Mon, Sep 25, 2017 at 6:09 PM, Grant Grundler wrote: > This linksys dongle by default comes up in cdc_ether mode. > This patch allows r8152 to claim the device: >Bus 002 Device 002: ID 13b1:0041 Linksys > > Signed-off-by: Grant Grundler >

Re: [RFC PATCH 2/3] usbnet: Avoid potential races in usbnet_deferred_kevent()

Hi, On Tue, Sep 19, 2017 at 1:37 PM, Oliver Neukum wrote: > Am Dienstag, den 19.09.2017, 09:15 -0700 schrieb Douglas Anderson: >> In general when you've got a flag communicating that "something needs >> to be done" you want to clear that flag _before_ doing the task. If >> you

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

t; > >> > > Stefan Wahren <stefan.wah...@i2se.com> hat am 22. April 2017 um 22:50 >> > > geschrieben: >> > > >> > > >> > > Hi, >> > > >> > > > Eric Anholt <e...@anholt.net> hat am 20. April 2017 u

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

Hi, On Thu, Apr 20, 2017 at 12:57 PM, Eric Anholt <e...@anholt.net> wrote: > Doug Anderson <diand...@chromium.org> writes: > >> Hi, >> >> On Thu, Apr 20, 2017 at 11:54 AM, Eric Anholt <e...@anholt.net> wrote: >>> Stefan Wahren <stefan.wah...@i

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

Hi, On Thu, Apr 20, 2017 at 11:54 AM, Eric Anholt <e...@anholt.net> wrote: > Stefan Wahren <stefan.wah...@i2se.com> writes: > >> Hi, >> >>> Doug Anderson <diand...@chromium.org> hat am 18. April 2017 um 22:41 >>> geschrieben: >>> >

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

Hi, On Thu, Apr 20, 2017 at 12:46 AM, Stefan Wahren <stefan.wah...@i2se.com> wrote: > Am 19.04.2017 um 23:47 schrieb Doug Anderson: >> Hi, >> >> On Wed, Apr 19, 2017 at 1:25 PM, Stefan Wahren <stefan.wah...@i2se.com> >> wrote: >>> Hi, >>

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

Hi, On Wed, Apr 19, 2017 at 1:25 PM, Stefan Wahren <stefan.wah...@i2se.com> wrote: > Hi, > >> Doug Anderson <diand...@chromium.org> hat am 18. April 2017 um 22:41 >> geschrieben: >> >> >> It's hard to know for sure that all of this time is really i

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

Stefan, On Tue, Apr 18, 2017 at 1:25 PM, Stefan Wahren <stefan.wah...@i2se.com> wrote: > Hi, > > [add Johan] > >> Stefan Wahren <stefan.wah...@i2se.com> hat am 18. April 2017 um 10:07 >> geschrieben: >> >> >> Am 18.04.2017 um 00:37 schrieb

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

Hi, On Tue, Apr 18, 2017 at 1:07 AM, Stefan Wahren wrote: >> 1. With dwc2 you often end up in the situation where you need to >> service an interrupt every 125 uS. If servicing that interrupt takes >> anywhere near 125 uS in the common case then you'll be in trouble. > >

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

Hi, On Mon, Apr 17, 2017 at 4:05 AM, Stefan Wahren wrote: > Hi, > >> Stefan Wahren hat am 31. Oktober 2016 um 21:34 >> geschrieben: >> >> >> I inspired by this issue [1] i build up a slightly modified setup with a >> Raspberry Pi B (mainline

Re: [PATCH v3] usb: hub: Fix error loop seen after hub communication errors

Hi, On Thu, Mar 16, 2017 at 12:24 PM, Guenter Roeck wrote: > @@ -1198,7 +1201,7 @@ static void hub_activate(struct usb_hub *hub, enum > hub_activation_type type) > > /* Scan all ports that need attention */ > kick_hub_wq(hub); > - > +abort: One tiny nit that

Re: [PATCH v8 3/3] arm64: dts: rockchip: add usb2-phy support for rk3399

Hi, On Tue, Jul 19, 2016 at 12:28 AM, Frank Wang wrote: You need a patch description here, even for simple patches. All you have now is a subject. > Signed-off-by: Frank Wang > --- > arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 19

Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip

William, On Mon, May 9, 2016 at 4:46 AM, William Wu wrote: > Signed-off-by: William Wu > --- > drivers/usb/dwc3/dwc3-of-simple.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/dwc3/dwc3-of-simple.c >

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

John, On Tue, Mar 22, 2016 at 12:26 PM, John Youn wrote: > Thanks for the debug logs and everyones help. > > After reviewing with our hardware engineers, it seems this is likely > to do with the IDDIG debounce filtering when switching between > modes. You can see if this

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

Hi, On Wed, Mar 16, 2016 at 11:28 AM, John Youn <john.y...@synopsys.com> wrote: > On 3/10/2016 11:14 AM, John Youn wrote: >> On 3/9/2016 11:06 AM, Doug Anderson wrote: >>> Stefan, >>> >>> On Wed, Mar 9, 2016 at 11:01 AM, Stefan Wahren <stefan.wah...@i

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

Stefan, On Wed, Mar 9, 2016 at 11:01 AM, Stefan Wahren <stefan.wah...@i2se.com> wrote: > >> Doug Anderson <diand...@chromium.org> hat am 7. März 2016 um 22:30 >> geschrieben: >> >> >> Stefan, >> >> On Mon, Mar 7, 2016 at 10:40 AM, Stefa

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

Stefan, On Mon, Mar 7, 2016 at 10:40 AM, Stefan Wahren wrote: > Hi Doug, > >> Douglas Anderson hat am 4. März 2016 um 19:23 >> geschrieben: >> >> >> This reverts commit 192cb07f7928 ("usb: dwc2: Fix probe problem on >> bcm2835") now that we've

Re: [RFT PATCH 1/2] usb: dwc2: Add a 10 ms delay to dwc2_core_reset()

Hi, On Sat, Mar 5, 2016 at 12:41 PM, Michael Niewoehner <li...@mniewoehner.de> wrote: > Hi Douglas, > Hi John, > > Am 05.03.2016 um 01:33 schrieb Doug Anderson <diand...@chromium.org>: > >> Michael, >> >> On Fri, Mar 4, 2016 at 4:09 PM, Michae

Re: Odd merge 3b30be3b6487 ("Merge tag 'v4.5-rc6' into next")

Hi, On Fri, Mar 4, 2016 at 5:56 PM, John Youn <john.y...@synopsys.com> wrote: > On 3/4/2016 5:04 PM, Doug Anderson wrote: >> Felipe, >> >> Michael pointed out that there's an odd merge that happened. >> Specifically it looks like commit bd84f4ae9986 ("usb:

Re: [RFT PATCH 1/2] usb: dwc2: Add a 10 ms delay to dwc2_core_reset()

Hi, On Fri, Mar 4, 2016 at 4:33 PM, Doug Anderson <diand...@chromium.org> wrote: > Michael, > > On Fri, Mar 4, 2016 at 4:09 PM, Michael Niewoehner <li...@mniewoehner.de> > wrote: >>>> From testing and trying to make sense of the documentation, it appears >

Odd merge 3b30be3b6487 ("Merge tag 'v4.5-rc6' into next")

Felipe, Michael pointed out that there's an odd merge that happened. Specifically it looks like commit bd84f4ae9986 ("usb: dwc2: Add extra delay when forcing dr_mode") got lost somehow in the merge commit 3b30be3b6487 ("Merge tag 'v4.5-rc6' into next") Specifically: $ git blame 3b30be3b6487 --

Re: [RFT PATCH 1/2] usb: dwc2: Add a 10 ms delay to dwc2_core_reset()

Hi, On Fri, Mar 4, 2016 at 3:46 PM, Karl Palsson wrote: >> + /* >> + * Sleep for 10-15 ms after the reset to let it finish. >> + * >> + * It's been confirmed on at least one version of the controller >> + * that this is a requirement that this is a

Re: [RFT PATCH 1/2] usb: dwc2: Add a 10 ms delay to dwc2_core_reset()

Michael, On Fri, Mar 4, 2016 at 4:09 PM, Michael Niewoehner wrote: >>> From testing and trying to make sense of the documentation, it appears >>> that a 10 ms delay is needed after resetting the core to make sure that >>> everything is stable and consistent. Let's add it.

Re: [PATCH] usb: move usb_calc_bus_time into common code

John, On Fri, Feb 19, 2016 at 6:55 PM, John Youn <john.y...@synopsys.com> wrote: > On 2/19/2016 2:48 PM, Doug Anderson wrote: >> Hi, >> >> On Fri, Feb 19, 2016 at 1:52 PM, Alan Stern <st...@rowland.harvard.edu> >> wrote: >>> On Fri, 19 Feb 2016,

Re: [PATCH] usb: move usb_calc_bus_time into common code

Hi, On Fri, Feb 19, 2016 at 1:52 PM, Alan Stern wrote: > On Fri, 19 Feb 2016, Arnd Bergmann wrote: > >> The dwc2 dual-role USB controller driver has started calling >> usb_calc_bus_time, and does so regardless of whether it is >> being built as a host controller or

Re: [PATCH v6 17/22] usb: dwc2: host: Manage frame nums better in scheduler

Hi, On Thu, Jan 28, 2016 at 6:20 PM, Douglas Anderson wrote: > static void dwc2_qh_init(struct dwc2_hsotg *hsotg, struct dwc2_qh *qh, > struct dwc2_hcd_urb *urb) > { > @@ -569,11 +655,6 @@ static void dwc2_qh_init(struct dwc2_hsotg *hsotg, >

Re: [PATCH v6 18/22] usb: dwc2: host: Schedule periodic right away if it's time

Kever, On Mon, Feb 1, 2016 at 11:04 PM, Kever Yang wrote: >>> Oh, now I get what you're saying! >>> >>> A) You've got dwc2_release_channel() -> dwc2_deactivate_qh() -> >>> dwc2_hcd_qh_deactivate() >>> ...and always in that case we'll do a select / queue, so we don't

Re: [PATCH v6 20/22] usb: dwc2: host: Properly set even/odd frame

Kever, On Mon, Feb 1, 2016 at 11:46 PM, Kever Yang wrote: > Doug, > > > On 01/29/2016 10:20 AM, Douglas Anderson wrote: >> >> When setting up ISO and INT transfers dwc2 needs to specify whether the >> transfer is for an even or an odd frame (or microframe if the

Re: [PATCH v6 18/22] usb: dwc2: host: Schedule periodic right away if it's time

Kever, On Sun, Jan 31, 2016 at 8:36 PM, Doug Anderson <diand...@chromium.org> wrote: > Kever, > > On Sun, Jan 31, 2016 at 7:32 PM, Kever Yang <kever.y...@rock-chips.com> wrote: >> Doug, >> >> >> On 02/01/2016 06:09 AM, Doug Anderson wrote: >>&

Re: [PATCH v6 10/22] usb: dwc2: host: Properly set the HFIR

Kever, On Sun, Jan 31, 2016 at 1:23 AM, Kever Yang wrote: > Doug, > > On 01/29/2016 10:20 AM, Douglas Anderson wrote: >> >> According to the most up to date version of the dwc2 databook, the FRINT >> field of the HFIR register should be programmed to: >> * 125 us *

Re: [PATCH v6 18/22] usb: dwc2: host: Schedule periodic right away if it's time

Kever, On Sun, Jan 31, 2016 at 1:36 AM, Kever Yang wrote: > Doug, > > > On 01/29/2016 10:20 AM, Douglas Anderson wrote: >> >> In dwc2_hcd_qh_deactivate() we will put some things on the >> periodic_sched_ready list. These things won't be taken off the ready >> list

Re: [PATCH v6 18/22] usb: dwc2: host: Schedule periodic right away if it's time

Kever, On Sun, Jan 31, 2016 at 7:32 PM, Kever Yang <kever.y...@rock-chips.com> wrote: > Doug, > > > On 02/01/2016 06:09 AM, Doug Anderson wrote: >> >> Kever, >> >> On Sun, Jan 31, 2016 at 1:36 AM, Kever Yang <kever.y...@rock-chips.com> >> w

Re: [PATCH v5 0/21] usb: dwc2: host: Fix and speed up all the stuff, especially with splits

Stefan, On Fri, Jan 29, 2016 at 7:28 AM, Stefan Wahren <stefan.wah...@i2se.com> wrote: > Hi Doug, > > Am 27.01.2016 um 21:43 schrieb Doug Anderson: >> Stefan, >> >> On Wed, Jan 27, 2016 at 12:36 PM, Stefan Wahren <stefan.wah...@i2se.com> >> wrote:

Re: [PATCH v5 04/21] usb: dwc2: host: Set host_perio_tx_fifo_size to 304 for rk3066

Kever, On Wed, Jan 27, 2016 at 10:41 PM, Kever Yang wrote: > Hi Doug, > > We are in HOST mode, we only need to receive data from USB camera > with RX FIFO, and no need to use TX FIFO for USB webcam, right? :) > > Any way, I think we need to NAK this patch after look

Re: [PATCH v5 04/21] usb: dwc2: host: Set host_perio_tx_fifo_size to 304 for rk3066

Hi, On Thu, Jan 28, 2016 at 10:16 AM, Doug Anderson <diand...@chromium.org> wrote: > Kever, > > > On Wed, Jan 27, 2016 at 10:41 PM, Kever Yang <kever.y...@rock-chips.com> > wrote: >> Hi Doug, >> >> We are in HOST mode, we only need to receive data

Re: [PATCH v5 05/21] usb: dwc2: host: Avoid use of chan->qh after qh freed

Hi, On Wed, Jan 27, 2016 at 7:25 PM, Kever Yang wrote: > Hi Doug, > > The NULL pointer bug is one of the most frequent issue we met > during hot plug stress test, thanks for this bug fix. > > Reviewed-by: Kever Yang > > Thanks, > - Kever

Re: Bug in split transactions on Raspberry Pi

Hi, On Wed, Jan 27, 2016 at 2:03 PM, Alan Stern <st...@rowland.harvard.edu> wrote: > On Wed, 27 Jan 2016, Doug Anderson wrote: > >> Alan, >> >> On Wed, Jan 27, 2016 at 1:34 PM, Alan Stern <st...@rowland.harvard.edu> >> wrote: >> > On Wed, 27 J

Re: [PATCH v5 04/21] usb: dwc2: host: Set host_perio_tx_fifo_size to 304 for rk3066

Kever, On Wed, Jan 27, 2016 at 7:10 PM, Kever Yang wrote: > Hi Doug, > > We are using the minimum FIFO size mode for TX now, which only > equal to one max packet size. > > The addition FIFO size may help shorten the inter-packet data > prepare latency when the bus/DRAM

Re: [PATCH v5 0/21] usb: dwc2: host: Fix and speed up all the stuff, especially with splits

Stefan, On Wed, Jan 27, 2016 at 9:33 AM, Stefan Wahren wrote: > Hi Doug, > >> Douglas Anderson (21): >> usb: dwc2: rockchip: Make the max_transfer_size automatic >> usb: dwc2: host: Get aligned DMA in a more supported way >> usb: dwc2: host: Set host_rx_fifo_size to

Re: Bug in split transactions on Raspberry Pi

Alan, On Wed, Jan 27, 2016 at 11:03 AM, Alan Stern <st...@rowland.harvard.edu> wrote: > On Tue, 26 Jan 2016, Doug Anderson wrote: > >> > This probably indicates that the list of patches was incomplete (i.e., >> > some other patches were applied before these). Also,

Re: usb: dwc2: Disconnecting hub from rpi leads to errors

Stefan, On Sat, Jan 23, 2016 at 9:08 AM, Stefan Wahren wrote: > Hi, > >> Stefan Wahren hat am 17. Januar 2016 um 04:36 >> geschrieben: >> >> >> Hi, >> >> i have a Cherry G83 USB Keyboard connected to external 4 Port USB hub and >> this >> is

Re: [PATCH v5 03/21] usb: dwc2: host: Set host_rx_fifo_size to 528 for rk3066

Kever, On Wed, Jan 27, 2016 at 2:13 AM, Kever Yang wrote: > Hi Doug, > > On 01/23/2016 02:18 AM, Douglas Anderson wrote: >> >> As documented in dwc2_calculate_dynamic_fifo(), host_rx_fifo_size should >> really be: >> 2 * ((Largest Packet size / 4) + 1 + 1) + n >>

Re: Bug in split transactions on Raspberry Pi

Hi, On Wed, Jan 27, 2016 at 12:59 PM, Alan Stern <st...@rowland.harvard.edu> wrote: > On Wed, 27 Jan 2016, Doug Anderson wrote: > >> > In the end I just used the contents of the dwc2 directory from Linus's >> > current tree -- I don't think it has changed since 4.5-r

Re: [PATCH v5 0/21] usb: dwc2: host: Fix and speed up all the stuff, especially with splits

Stefan, On Wed, Jan 27, 2016 at 12:36 PM, Stefan Wahren wrote: > i can only give you feedback from a user perspective. My keyboard and C-Media > USB Audio still works as expected. OK, thanks! So you had no problems before my patches and you still have no problems after

Re: Bug in split transactions on Raspberry Pi

Alan, On Wed, Jan 27, 2016 at 11:21 AM, Doug Anderson <diand...@chromium.org> wrote: > Alan, > > On Wed, Jan 27, 2016 at 11:03 AM, Alan Stern <st...@rowland.harvard.edu> > wrote: >> On Tue, 26 Jan 2016, Doug Anderson wrote: >> >>> > This probably i

Re: [PATCH v5 16/21] usb: dwc2: host: Manage frame nums better in scheduler

Hi, On Fri, Jan 22, 2016 at 10:18 AM, Douglas Anderson wrote: > The dwc2 scheduler (contained in hcd_queue.c) was a bit confusing in the > way it initted / kept track of which frames a QH was going to be active > in. Let's clean things up a little bit in preparation for a

Re: Bug in split transactions on Raspberry Pi

Alan, On Wed, Jan 27, 2016 at 1:34 PM, Alan Stern <st...@rowland.harvard.edu> wrote: > On Wed, 27 Jan 2016, Doug Anderson wrote: > >> This patch should fix ya. >> >> FIXUP: FROMLIST: usb: dwc2: host: Manage frame nums better in scheduler >> https://chromium-rev

Re: [PATCH v2 0/2] usb: dwc2: Fix regressions on bcm2835

Hi, On Thu, Jan 21, 2016 at 3:28 PM, Heiko Stuebner wrote: > Am Montag, 11. Januar 2016, 16:32:00 schrieb John Youn: >> This series fixes a couple regressions reported on Raspberry Pi. > > same regressions (Isaw strange usb resets) seem to affect Rockchip as well > and these two

Re: Bug in split transactions on Raspberry Pi

Hi, On Tue, Jan 26, 2016 at 7:08 AM, Alan Stern <st...@rowland.harvard.edu> wrote: > On Mon, 25 Jan 2016, Doug Anderson wrote: > >> Hi, >> >> On Mon, Jan 25, 2016 at 1:51 PM, Alan Stern <st...@rowland.harvard.edu> >> wrote: >> > On Mon, 25 Jan 2

Re: Bug in split transactions on Raspberry Pi

Hi, On Tue, Jan 26, 2016 at 10:22 AM, Alan Stern wrote: > On Tue, 26 Jan 2016, Noralf Trønnes wrote: > >> > I installed the rpi-4.4.y branch from the >> > https://github.com/raspberrypi/linux repository. As is, it generated a >> > working kernel. Then I tried editing

Re: Bug in split transactions on Raspberry Pi

Hi, On Tue, Jan 26, 2016 at 10:26 AM, Doug Anderson <diand...@chromium.org> wrote: > Hi, > > On Tue, Jan 26, 2016 at 10:22 AM, Alan Stern <st...@rowland.harvard.edu> > wrote: >> On Tue, 26 Jan 2016, Noralf Trønnes wrote: >> >>> > I installed the rp

Re: Bug in split transactions on Raspberry Pi

Alan, On Tue, Jan 26, 2016 at 12:29 PM, Alan Stern <st...@rowland.harvard.edu> wrote: > On Tue, 26 Jan 2016, Doug Anderson wrote: > >> >> Doug, do you have a list of patches you'd like me to try on top of the >> >> rpi-4.4.y branch? >> > >>

Re: Bug in split transactions on Raspberry Pi

Hi, On Mon, Jan 25, 2016 at 1:51 PM, Alan Stern wrote: > On Mon, 25 Jan 2016, Peter Stuge wrote: > >> Alan Stern wrote: >> > the device's embedded hub ACKs the packets from the PC and not the >> > packets from the RPi. >> > >> > What other differences could there be?

Re: Bug in split transactions on Raspberry Pi

Alan, On Mon, Jan 25, 2016 at 1:04 PM, Alan Stern <st...@rowland.harvard.edu> wrote: > On Mon, 25 Jan 2016, Doug Anderson wrote: > >> > Okay, I checked it. Oddly enough, even though the SPLIT packet's >> > contents are now correct, the device still doesn't respon

Re: Bug in split transactions on Raspberry Pi

Hi, On Mon, Jan 25, 2016 at 12:05 PM, Alan Stern <st...@rowland.harvard.edu> wrote: > On Fri, 22 Jan 2016, Doug Anderson wrote: > >> > The corresponding line in the dwc2_host_hub_info() routine simply does: >> > >> > *hub_port = urb->dev->

Re: [PATCH v5 0/21] usb: dwc2: host: Fix and speed up all the stuff, especially with splits

Heiko, On Sat, Jan 23, 2016 at 9:52 AM, Heiko Stuebner wrote: > Hi, > > Am Freitag, 22. Januar 2016, 10:18:35 schrieb Douglas Anderson: >> This is a bit of catchall series for all the bug fix and performance >> patches I've been working on over the last few months. Note that

Re: [PATCH v5 20/21] usb: dwc2: host: Totally redo the microframe scheduler

Hi, On Fri, Jan 22, 2016 at 10:18 AM, Douglas Anderson wrote: > This totally reimplements the microframe scheduler in dwc2 to attempt to > handle periodic splits properly. The old code didn't even try, so this > was a significant effort since periodic splits are one of

Re: usb: dwc2: Disconnecting hub from rpi leads to errors

Hi, On Sat, Jan 23, 2016 at 9:08 AM, Stefan Wahren wrote: > Hi, > >> Stefan Wahren hat am 17. Januar 2016 um 04:36 >> geschrieben: >> >> >> Hi, >> >> i have a Cherry G83 USB Keyboard connected to external 4 Port USB hub and >> this >> is

Re: [PATCH v5 0/21] usb: dwc2: host: Fix and speed up all the stuff, especially with splits

Hi, On Sat, Jan 23, 2016 at 3:09 PM, Doug Anderson <diand...@chromium.org> wrote: > Heiko, > > On Sat, Jan 23, 2016 at 9:52 AM, Heiko Stuebner <he...@sntech.de> wrote: >> Hi, >> >> Am Freitag, 22. Januar 2016, 10:18:35 schrieb Douglas Anderson: >>>

Re: Bug in split transactions on Raspberry Pi

Alan, On Fri, Jan 22, 2016 at 11:48 AM, Alan Stern <st...@rowland.harvard.edu> wrote: > On Thu, 21 Jan 2016, Doug Anderson wrote: > >> This doesn't sound familiar to me, but as far as I know all the >> official Raspberry Pi kernels use a pretty different dwc2 driver.

Re: Bug in split transactions on Raspberry Pi

Hi, On Thu, Jan 21, 2016 at 1:28 PM, Alan Stern wrote: > John, Doug, or anyone else: > > I've got a Raspberry Pi 2B and I'm trying to use it with a compound > device. The device has a High-Speed hub with a Full-Speed function > permanently attached to port 4. > > The

Re: [PATCH v4 07/21] usb: dwc2: hcd: fix split transfer schedule sequence

Hi, On Wed, Jan 20, 2016 at 9:24 PM, kbuild test robot wrote: > Hi Douglas, > > [auto build test ERROR on next-20160120] > [cannot apply to v4.4-rc8 v4.4-rc7 v4.4-rc6 v4.4] > [if your patch is applied to the wrong git tree, please drop us a note to > help improving the system] >

Re: [PATCH] usb: dwc2: hcd: fix periodic transfer schedule sequence

John, On Mon, Nov 16, 2015 at 2:41 PM, Caesar Wang wrote: > Hi, > > 在 2015年11月16日 23:25, Yunzhi Li 写道: >> >> When checking dwc2 host channel interrupts, handle qh in >> periodic_sched_queued list at first, then we could make sure CSPLIT >> packets scheduled in the same

Re: [PATCH] usb: dwc2: add shutdown callback to platform variant

Heiko, On Fri, Dec 18, 2015 at 3:17 PM, Heiko Stübner <heiko.stueb...@collabora.com> wrote: > Hi Doug, > > Am Freitag, 18. Dezember 2015, 14:50:14 schrieb Doug Anderson: >> On Fri, Dec 18, 2015 at 10:30 AM, Heiko Stübner >> <heiko.stueb...@collabora.com> w

Re: [PATCH] usb: dwc2: add shutdown callback to platform variant

Heiko, On Fri, Dec 18, 2015 at 10:30 AM, Heiko Stübner wrote: > In specific conditions (involving usb hubs) dwc2 devices can create a > lot of interrupts, even to the point of overwhelming devices running > at low frequencies. Some devices need to do special clock

Re: poweroff-issue with dwc2 on Felipe's testing/next branch

Hi, On Wed, Dec 16, 2015 at 9:36 AM, Doug Anderson <diand...@chromium.org> wrote: > Hi, > > On Wed, Dec 16, 2015 at 7:35 AM, Felipe Balbi <ba...@ti.com> wrote: >> >> Hi, >> >> John Youn <john.y...@synopsys.com> writes: >>> On 12/15/20

Re: poweroff-issue with dwc2 on Felipe's testing/next branch

Hi, On Wed, Dec 16, 2015 at 7:35 AM, Felipe Balbi wrote: > > Hi, > > John Youn writes: >> On 12/15/2015 3:49 PM, Heiko Stübner wrote: >>> Hi, >>> >>> it seems the recent dwc2 additions to the testing/next branch [0] caused >>> some interesting issue for me.

  1   2   3   >