Re: [PATCH stable v4.4+] r8152: add Linksys USB3GIGV1 id

On Thu, Apr 26, 2018 at 12:56 AM, Krzysztof Kozlowski <k...@kernel.org> wrote: > On Thu, Apr 26, 2018 at 2:40 AM, Grant Grundler <grund...@chromium.org> wrote: >> On Wed, Apr 25, 2018 at 2:54 AM, Krzysztof Kozlowski <k...@kernel.org&g

Re: [PATCH stable v4.4+] r8152: add Linksys USB3GIGV1 id

ID 13b1:0041 Linksys > > Signed-off-by: Grant Grundler <grund...@chromium.org> > Reviewed-by: Douglas Anderson <diand...@chromium.org> > Signed-off-by: David S. Miller <da...@davemloft.net> > [krzk: Rebase on v4.4] > Signed-off-by: Krzysztof Kozlowski <k...@kerne

Re: [PATCH V4] r8152: add Linksys USB3GIGV1 id

On Sun, Oct 1, 2017 at 10:39 PM, David Miller <da...@davemloft.net> wrote: > From: Grant Grundler <grund...@chromium.org> > Date: Thu, 28 Sep 2017 11:35:00 -0700 > >> This linksys dongle by default comes up in cdc_ether mode. >> This patch allows r8152 to claim the

[PATCH V4] r8152: add Linksys USB3GIGV1 id

This linksys dongle by default comes up in cdc_ether mode. This patch allows r8152 to claim the device: Bus 002 Device 002: ID 13b1:0041 Linksys Signed-off-by: Grant Grundler <grund...@chromium.org> --- drivers/net/usb/cdc_ether.c | 10 ++ drivers/net/usb/r8152.c | 2 ++ 2

Re: [PATCH V3] r8152: add Linksys USB3GIGV1 id

Hi Doug! On Wed, Sep 27, 2017 at 4:47 PM, Doug Anderson <diand...@chromium.org> wrote: > Hi, > > On Wed, Sep 27, 2017 at 10:28 AM, Grant Grundler <grund...@chromium.org> > wrote: >> This linksys dongle by default comes up in cdc_ether mode. >> This pa

[PATCH V3] r8152: add Linksys USB3GIGV1 id

This linksys dongle by default comes up in cdc_ether mode. This patch allows r8152 to claim the device: Bus 002 Device 002: ID 13b1:0041 Linksys Signed-off-by: Grant Grundler <grund...@chromium.org> --- drivers/net/usb/cdc_ether.c | 10 ++ drivers/net/usb/r8152.c | 2 ++ 2

Re: [PATCH V2] r8152: add Linksys USB3GIGV1 id

On Wed, Sep 27, 2017 at 12:15 AM, Oliver Neukum wrote: > Am Dienstag, den 26.09.2017, 08:19 -0700 schrieb Doug Anderson: >> >> I know that for at least some of the adapters in the CDC Ethernet >> blacklist it was claimed that the CDC Ethernet support in the adapter >> was kinda

Re: [PATCH] r8152: add Linksys USB3GIGV1 id

On Mon, Sep 25, 2017 at 1:17 PM, Grant Grundler <grund...@chromium.org> wrote: ... > I didn't realize cdc_ether has a blacklist to make sure > RTL8152|RTL8153 devices are not picked up by cdc_ether. Would you > prefer I add this device to the blacklist in the same patch? I've sent

[PATCH V2] r8152: add Linksys USB3GIGV1 id

This linksys dongle by default comes up in cdc_ether mode. This patch allows r8152 to claim the device: Bus 002 Device 002: ID 13b1:0041 Linksys Signed-off-by: Grant Grundler <grund...@chromium.org> --- drivers/net/usb/cdc_ether.c | 8 drivers/net/usb/r8152.c | 2 ++ 2

Re: [PATCH] r8152: add Linksys USB3GIGV1 id

[grrhmail...sorry! resending as plain text] Hallo Oliver! On Mon, Sep 25, 2017 at 7:51 AM, Oliver Neukum <oneu...@suse.com> wrote: > Am Freitag, den 22.09.2017, 12:06 -0700 schrieb Grant Grundler: > > This Linksys dongle by default comes up in cdc_ether mode. > > This patch

[PATCH] r8152: add Linksys USB3GIGV1 id

This Linksys dongle by default comes up in cdc_ether mode. This patch allows r8152 to claim the device: Bus 002 Device 002: ID 13b1:0041 Linksys Signed-off-by: Grant Grundler <grund...@chromium.org> --- drivers/net/usb/r8152.c | 2 ++ 1 file changed, 2 insertions(+) This was

[PATCH] HID: remove use of DRIVER_LICENSE

Local "#define DRIVER_LICENSE" obfuscates which license is used in MODULE_LICENSE(). "fgrep -R MODULE_LICENSE" is more informative when the string is hard coded in MODULE_LICENSE. Signed-off-by: Grant Grundler <grund...@google.com> --- Most of the kernel already uses h

Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg

On Thu, Sep 1, 2016 at 10:02 AM, Eric Dumazet <eric.duma...@gmail.com> wrote: > On Thu, 2016-09-01 at 12:47 -0400, Robert Foss wrote: > >> I'm not quite sure how the first From line was added, it >> should not have been. >> Grant Grundler is most definitely the a

Re: [PATCH 1/3] net: asix: Add in_pm parameter

On Tue, Jul 26, 2016 at 2:14 PM, Robert Foss wrote: ... > Thanks for the feedback (for this patch and the other ones)! > I'm preparing a v2 and will submit it withing a day or two. Excellent! very welcome and thanks again for picking this up. ... >> FTR, current

Re: [PATCH 3/3] net: asix: Fix AX88772x resume failures

igned-off-by: Allan Chou <al...@asix.com.tw> Signed-off-by: WK Tsai <wk.t...@nvidia.com> Tested-by: Grant Grundler <grund...@chromium.org> Reviewed-by: Wang-Kai Tsai <gis5...@gmail.com> Reviewed-by: Mark Kuo <m...@nvidia.com> Reviewed-by: Grant Grundler <grund...@chro

Re: [PATCH 2/3] net: asix: Avoid looping when the device is disconnected

On Mon, Jul 25, 2016 at 10:40 AM, wrote: > From: Vincent Palatin > > Check the answers from the USB stack and avoid re-sending multiple times > the request if the device has disappeared. > > Signed-off-by: Vincent Palatin

Re: [PATCH 1/3] net: asix: Add in_pm parameter

[as plain text this time...] Robert, On Mon, Jul 25, 2016 at 10:40 AM, <robert.f...@collabora.com> wrote: > From: Grant Grundler <grund...@chromium.org> For the record, I believe I am not the author of these patches. I believe the original author is Signed-off-by:

Re: [PATCH] r8152: add MODULE_VERSION

On Fri, Jul 15, 2016 at 2:25 PM, David Miller <da...@davemloft.net> wrote: > From: Grant Grundler <grund...@chromium.org> > Date: Thu, 14 Jul 2016 11:27:16 -0700 > >> ethtool -i provides a driver version that is hard coded. >> Export the same value via &quo

[PATCH] r8152: add MODULE_VERSION

ethtool -i provides a driver version that is hard coded. Export the same value via "modinfo". Signed-off-by: Grant Grundler <grund...@chromium.org> --- drivers/net/usb/r8152.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152

Re: [PATCH net-next 12/12] r8152: modify the tx timeout funcfion

On Tue, Mar 4, 2014 at 4:01 AM, Hayes Wang hayesw...@realtek.com wrote: Reset and reinitialize the device when the tx timeout occurs. Hayes, I believe this patch was dropped after the series was split. Can you please repost this patch by itself? (and fix the function typo in the patch header)

Re: usbnet: driver_info-stop required to stop USB interrupts?

On Fri, Mar 21, 2014 at 1:33 AM, Oliver Neukum oneu...@suse.de wrote: ... Very well. Thorough testing is good. I'll wait for the result. Could you notify me of the final outcome? Ship it. :) The testing so far has completed over 15K iterations of unload/reload of the asix driver on the

Re: usbnet: driver_info-stop required to stop USB interrupts?

On Fri, Mar 21, 2014 at 1:33 AM, Oliver Neukum oneu...@suse.de wrote: ... Very well. Thorough testing is good. I'll wait for the result. Could you notify me of the final outcome? Ceratinly. Bad news is I had to restart my workstation that was driving the test due to completely different issue

Re: usbnet: driver_info-stop required to stop USB interrupts?

On Thu, Mar 20, 2014 at 12:15 AM, Oliver Neukum oneu...@suse.de wrote: ... I have an idea. Could you test this patch? ... - if (dev-wait) { .. + if (waitqueue_active(dev-wait)) { Yes - building new image now (and transfer to USB and boot from USB). Should know in an hour or so

Re: usbnet: driver_info-stop required to stop USB interrupts?

On Thu, Mar 20, 2014 at 9:35 AM, Grant Grundler grund...@google.com wrote: On Thu, Mar 20, 2014 at 12:15 AM, Oliver Neukum oneu...@suse.de wrote: ... I have an idea. Could you test this patch? ... - if (dev-wait) { .. + if (waitqueue_active(dev-wait)) { Yes - building new

Re: usbnet: driver_info-stop required to stop USB interrupts?

On Tue, Mar 18, 2014 at 6:40 PM, Grant Grundler grund...@google.com wrote: On Tue, Mar 18, 2014 at 6:09 PM, Julius Werner jwer...@chromium.org wrote: I think a better place for this would be in usbnet_probe() (together with all the other dev-xxx initialization). Definitely better

Re: usbnet: driver_info-stop required to stop USB interrupts?

On Mon, Mar 17, 2014 at 2:55 PM, Oliver Neukum oneu...@suse.de wrote: I am hping for the reporter of the original bug to test it. Oliver, on a haswell system running ChromeOS-3.8 kernel, this patch as-is resulted in a Bad Spinlock Magic error and subsequent pagefault. I believe the sequence was:

Re: usbnet: driver_info-stop required to stop USB interrupts?

On Tue, Mar 18, 2014 at 1:51 PM, Grant Grundler grund...@google.com wrote: On Mon, Mar 17, 2014 at 2:55 PM, Oliver Neukum oneu...@suse.de wrote: I am hping for the reporter of the original bug to test it. Oliver, on a haswell system running ChromeOS-3.8 kernel, this patch as-is resulted

Re: usbnet: driver_info-stop required to stop USB interrupts?

On Tue, Mar 18, 2014 at 6:09 PM, Julius Werner jwer...@chromium.org wrote: I think a better place for this would be in usbnet_probe() (together with all the other dev-xxx initialization). Definitely better. @@ -1536,6 +1536,7 @@ usbnet_probe (struct usb_interface *udev, const struct usb

Re: usbnet: driver_info-stop required to stop USB interrupts?

On Mon, Mar 17, 2014 at 2:55 PM, Oliver Neukum oneu...@suse.de wrote: On Mon, 2014-03-17 at 14:53 -0700, Julius Werner wrote: Hi Oliver, Any update on the state of this patch? Did it get picked up for merge somewhere? Do you agree with my suggestion of sticking closer to the original logic

Re: usbnet: driver_info-stop required to stop USB interrupts?

On Mon, Mar 10, 2014 at 7:53 PM, Julius Werner jwer...@chromium.org wrote: I think usbnet_stop() raced with the dev-bh tasklet, which by itself might not be a problem (usbnet_stop() later kills the tasklet itself, so it should expect that it can be running before that). The issue is that it

Re: usbnet: driver_info-stop required to stop USB interrupts?

On Tue, Mar 11, 2014 at 10:31 AM, Grant Grundler grund...@google.com wrote: ... FWIW, I've reproduced this on Samsung Chromebook (Exynos 5250) with AX88772 USB dongle using the instructions I posted before (ie bouncing the USB port with reload_asix script). Sorry - with AX88178 dongle

Re: usbnet: driver_info-stop required to stop USB interrupts?

On Tue, Mar 11, 2014 at 10:31 AM, Grant Grundler grund...@google.com wrote: FWIW, I've reproduced this on Samsung Chromebook (Exynos 5250) with FYA - I just noticed the system crashed on the 2048th iteration :) ... RELOAD 2046 20140310202523 LINK 1000_full (3 sec) IP 192.168.1.116 (1 Sec

usbnet: driver_info-stop required to stop USB interrupts?

I've trying to unravel a page fault panic I've run into a few times while testing load/unload of asix driver with ChromeOS 3.8.11 based kernel. I'm running into this crash on both ARM and X86. Panic output below is from Exynos 5422 system. Test script attached. My _guess_ is usbnet_stop() is

Re: usbnet: driver_info-stop required to stop USB interrupts?

On Mon, Mar 10, 2014 at 11:33 AM, Grant Grundler grund...@google.com wrote: I've trying to unravel a page fault panic I've run into a few times while testing load/unload of asix driver with ChromeOS 3.8.11 based kernel. I'm running into this crash on both ARM and X86. Correction - I can only

Re: [PATCH 1/1] Workaround for Suspend/Resume issue of AX88772B under ChromeOS

that REMOTE_WAKEUP feature doesn't be set when system suspend. In this case, the PHY power will not be turned on again when system resume, so the HW reset must be added in the resume function. Signed-off-by: Freddy Xin fre...@asix.com.tw Tested-by: Grant Grundler grund...@chromium.org Like

Re: [PATCH 1/1] Workaround for Suspend/Resume issue of AX88772B under ChromeOS

On Wed, Nov 20, 2013 at 10:54 AM, David Miller da...@davemloft.net wrote: From: Grant Grundler grund...@google.com Date: Wed, 20 Nov 2013 09:42:42 -0800 While this patch raises a new issue, can you apply this patch anyway since in most cases (default settings) it improves the user experience

Re: [PATCH v3 4/4] USBNET: ax88179_178a: enable tso if usb host supports sg dma

Ming, We are splitting hairs now. :) I want to be clear I think your changes are good and the rest of this conversation is just to learn something new. On Thu, Aug 8, 2013 at 4:48 PM, Ming Lei ming@canonical.com wrote: On Fri, Aug 9, 2013 at 1:25 AM, Grant Grundler grund...@google.com wrote

Re: [PATCH v3 4/4] USBNET: ax88179_178a: enable tso if usb host supports sg dma

On Tue, Aug 6, 2013 at 5:22 AM, Eric Dumazet eric.duma...@gmail.com wrote: ... @@ -1310,6 +1318,10 @@ static int ax88179_reset(struct usbnet *dev) dev-net-hw_features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM; + if (dev-can_dma_sg) { +

Re: [PATCH 4/4] USBNET: ax88179_178a: enable tso if host supports sg dma

On Wed, Jul 31, 2013 at 3:51 AM, Ming Lei ming@canonical.com wrote: This patch enables 'can_dma_sg' flag for ax88179_178a device if the attached host controller supports building packet from discontinuous buffers(DMA SG is possible), so both frame header and skb data buffers can be passed

Re: [PATCH 1/1] TX throttling bug-fixing patch of AX88179_178A

On Tue, Jul 23, 2013 at 4:46 PM, David Miller da...@davemloft.net wrote: ... A quick scan shows that smsc75xx, smsc95xx, and ax88179_178a all have this problem. Instead of the patch starting this thread, I'd like to see one that hits all three drivers and removes all SG and TSO features bits

Re: [PATCH 1/1] TX throttling bug-fixing patch of AX88179_178A

On Tue, Jul 23, 2013 at 7:29 PM, Grant Grundler grund...@google.com wrote: On Tue, Jul 23, 2013 at 4:46 PM, David Miller da...@davemloft.net wrote: ... A quick scan shows that smsc75xx, smsc95xx, and ax88179_178a all have this problem. Instead of the patch starting this thread, I'd like

Re: [PATCH 1/1] TX throttling bug-fixing patch of AX88179_178A

On Mon, Jul 22, 2013 at 10:07 AM, Eric Dumazet eric.duma...@gmail.com wrote: ... I guess that if a driver does not advertise NETIF_F_SG, this skb_linearize() call is not needed : All frames reaching your xmit function should already be linear As Ben Hutchings pointed out, hw_features is still

Re: [linux-usb-devel] [PATCH] [2.6.23.13] udev hangs USB-storage (HP r707 camera)

On Tue, Jan 22, 2008 at 11:55:56PM -0700, Grant Grundler wrote: ... http://www.phildev.net/linux/usb-unusualdevs-notes.html In general, a very helpful document! Thanks! ... I read the rest of the document and explains exactly my confusion. Can you please include that document

Re: USB_SC_* vs USB_PR_* in unusual_dev.h

On Sat, Jan 19, 2008 at 10:09:47PM -0800, Matthew Dharm wrote: On Sat, Jan 19, 2008 at 09:25:57PM -0700, Grant Grundler wrote: Hi, I'm slightly confused by this declaration in drivers/usb/storage/usb.c: #define UNUSUAL_DEV(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax

Re: udev hangs USB-storage (HP r707 camera)

On Sat, Jan 19, 2008 at 08:10:08PM -0700, Grant Grundler wrote: [EMAIL PROTECTED]:~ # strace -o strace-dd-HPr707.out dd if=/dev/sda of=/dev/null skip=60800 count=1 dd: reading `/dev/sda': Input/output error 0+0 records in 0+0 records out 0 bytes (0 B) copied, 55.7303 seconds, 0.0 kB/s BTW

USB_SC_* vs USB_PR_* in unusual_dev.h

Hi, I'm slightly confused by this declaration in drivers/usb/storage/usb.c: #define UNUSUAL_DEV(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax, \ vendorName, productName,useProtocol, useTransport, \ initFunction, flags) \ ... and in unusual.h: UAL_DEV(

[PATCH] [2.6.23.13] udev hangs USB-storage (HP r707 camera)

: http://marc.info/?t=12007648332r=1w=2 Signed-off-by: Grant Grundler [EMAIL PROTECTED] --- linux-2.6.23.13/drivers/usb/storage/unusual_devs.h 2008-01-19 19:59:15.0 -0800 +++ linux-2.6.23-GGG/drivers/usb/storage/unusual_devs.h 2008-01-19 20:40:40.0 -0800 @@ -86,6 +86,14