Re: Null pointer deference in function stk_camera_probe and s2255_probe

2019-04-16 Thread Greg KH
On Thu, Apr 11, 2019 at 10:51:47AM +0800, Yang Xiao wrote: > Hi, > > There are NULL pointer deferences in the function stk_camera_probe in > drivers/media/usb/stkwebcam/stk-webcam.c and function s2255_probe in > drivers/media/usb/s2255/s2255drv.c, which allows proximate attackers > to cause a deni

Re: USB keyboard and mouse non responsive at login

2019-04-05 Thread Greg KH
On Fri, Apr 05, 2019 at 09:38:58AM +0100, John Travell wrote: > Greg, > While I fully appreciate that the origins of 3.13 are steeped in history, > the three versions mentioned were released this year. > All came from the ubuntu repositories, not via any paid support. Sorry, you are going to have

Re: USB keyboard and mouse non responsive at login

2019-04-04 Thread Greg KH
On Thu, Apr 04, 2019 at 10:16:36PM +0100, John Travell wrote: > Summary: USB keyboard and mouse non responsive at login > Product: Drivers > Version: 2.5 > Kernel Version: 3.13.0-166-generic > Kernel Version: 3.13.0-167-generic > Kernel Version: 3.13.0-168-generic 3.13 was released back in January

Re: [PATCH 1/2] USB: serial: pl2303: fix non-supported xon/xoff

2019-04-02 Thread Greg KH
On Tue, Apr 02, 2019 at 10:19:30AM +0200, Johan Hovold wrote: > Older pl2303 devices do not support automatic xon/xoff flow control, so > add add a flag to prevent trying to enable it for legacy device types. > > Refactor the IXON test into a helper function to improve readability. > > Fixes: 704

Re: [PATCH 2/2] USB: serial: pl2303: fix tranceiver suspend mode

2019-04-02 Thread Greg KH
On Tue, Apr 02, 2019 at 10:22:06AM +0200, Johan Hovold wrote: > On Tue, Apr 02, 2019 at 10:19:31AM +0200, Johan Hovold wrote: > > Add helper function to update register bits instead of overwriting the > > entire control register when updating the flow-control settings. > > > > This specifically av

Re: [PATCH 1/3] xhci: Fix port resume done detection for SS ports with LPM enabled

2019-04-01 Thread Greg KH
On Mon, Apr 01, 2019 at 01:42:00PM +0300, Mathias Nyman wrote: > On 27.3.2019 16.00, Sasha Levin wrote: > > Hi, > > > > [This is an automated email] > > > > This commit has been processed because it contains a -stable tag. > > The stable tag indicates that it's relevant for the following trees: a

Re: [PATCH] usb: typec: Registering real device entries for the muxes

2019-04-01 Thread Greg KH
On Mon, Apr 01, 2019 at 01:15:53PM +0300, Heikki Krogerus wrote: > Registering real device entries (struct device) for the mode > muxes as well as for the orientation switches. > > The Type-C mux code was deliberately attempting to avoid > creation of separate device entries for the orientation >

Re: External USB touchpad (vendor/product 1357:1000) not recognized as touchpad

2019-03-28 Thread Greg KH
On Thu, Mar 28, 2019 at 08:03:47AM +0100, Tassilo Horn wrote: > Hi all, > > I've got this touchpad: > > https://www.amazon.com/Wireless-VOGEK-Rechargeable-Multi-Touch-Navigation/dp/B07NMTV9S8/ > > It's not recognized as a touchpad but as four /dev/input/event* devices, You might want to bring

Re: [PATCH] usb: typec: mux: Store module handle

2019-03-28 Thread Greg KH
On Thu, Mar 28, 2019 at 02:52:08PM +0300, Heikki Krogerus wrote: > It is possible that the driver of the mux device has been > unbind by the time typec_mux_put() or typec_switch_put() is > called. > > To prevent the NULL Pointer Dereference from happening in > this case when decrementing the refer

Re: External USB touchpad (vendor/product 1357:1000) not recognized as touchpad

2019-03-27 Thread Greg KH
On Tue, Mar 26, 2019 at 09:10:15AM +0100, Tassilo Horn wrote: > Hi all, > > I've submitted this already at > https://bugzilla.kernel.org/show_bug.cgi?id=203049 but Greg > Kroah-Hartman told me that this is the right place. > > I've got this touchpad: > > https://www.amazon.com/Wireless-VOGEK-Rec

[PATCH] USB: cp210x: add new device id

2019-03-25 Thread Greg KH
Lorenz Messtechnik has a device that is controlled by the cp210x driver, so add the device id to the driver. The device id was provided by Silicon-Labs for the devices from this vendor. Reported-by: Uli Signed-off-by: Greg Kroah-Hartman Cc: stable diff --git a/drivers/usb/serial/cp210x.c b/dr

Re: FTDI Serial shutdown

2019-03-21 Thread Greg KH
On Fri, Mar 22, 2019 at 08:50:09AM +0900, Leonardo, Sionzon wrote: > Hi Felipe, > > I am using 3.14.52 version from NXP codeline. I haven't tried the > latest codeline We have no idea what that refers to, sorry. Please try the in-kernel driver. If you have problems with an out-of-tree driver, p

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

2019-03-21 Thread Greg KH
On Thu, Mar 21, 2019 at 11:50:04AM +0200, Felipe Balbi wrote: > > +static struct usb_interface_descriptor ftrace_intf_desc = { > > + .bLength= USB_DT_INTERFACE_SIZE, > > + .bDescriptorType= USB_DT_INTERFACE, > > + > > + .bAlternateSetting = 0, > > + .bNumEndpoin

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

2019-03-21 Thread Greg KH
On Thu, Mar 21, 2019 at 11:47:48AM +0200, Felipe Balbi wrote: > Allow for ftrace data to be exported over a USB Gadget > Controller. With this, we have a potentially very fast pipe for > transmitting ftrace data to a Host PC for further analysis. > > Note that in order to decode the data, one need

Re: [PATCH] usb: gadget: Don't allocate zero-length buffers

2019-03-20 Thread Greg KH
On Wed, Mar 20, 2019 at 01:56:41PM +0100, Andrzej Pietrasiewicz wrote: > Don't actually allocate anything if userspace enqueues a zero-length > buffer. Otherwise vmalloc of zero-sized area will be attempted in > ffs_build_sg_list(). > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/usb/ga

Re: [PATCH] usb-serial: fix mos_parport refcount imbalance on error path

2019-03-20 Thread Greg KH
On Wed, Mar 20, 2019 at 04:59:02PM +0800, Jian Liu/Gmail wrote: > Hi all, > > We might find a security issue in function > 'write_parport_reg_nonbloc'(for source codes, please refer to > https://github.com/torvalds/linux/blob/master/drivers/usb/serial/mos7720.c), > which is logically an unbalanced

Re: [PATCH 1/4] usb: Convert xhci-mem to XArray

2019-03-19 Thread Greg KH
On Mon, Mar 18, 2019 at 02:17:10PM -0700, Matthew Wilcox wrote: > The XArray API is a better fit for xhci than the radix tree API was, > to the point where we can remove the wrappers around the radix tree > and just call the XArray APIs directly. > > Signed-off-by: Matthew Wilcox > --- > drivers

Re: [PATCH 2/4] cdc-acm: Convert acm_minors to XArray

2019-03-19 Thread Greg KH
On Mon, Mar 18, 2019 at 02:17:11PM -0700, Matthew Wilcox wrote: > Signed-off-by: Matthew Wilcox Also something here saying acm_minors was an idr structure that is being converted to xarray. > --- > drivers/usb/class/cdc-acm.c | 33 ++--- > 1 file changed, 14 insertio

Re: [PATCH 4/4] usb/serial: Convert serial_minors to XArray

2019-03-19 Thread Greg KH
On Tue, Mar 19, 2019 at 12:36:21PM +0100, Oliver Neukum wrote: > On Di, 2019-03-19 at 04:35 -0700, Matthew Wilcox wrote: > > On Tue, Mar 19, 2019 at 07:14:09AM +0100, Greg KH wrote: > > > On Mon, Mar 18, 2019 at 02:17:13PM -0700, Matthew Wilcox wrote: > > > >

Re: [PATCH 4/4] usb/serial: Convert serial_minors to XArray

2019-03-18 Thread Greg KH
On Mon, Mar 18, 2019 at 02:17:13PM -0700, Matthew Wilcox wrote: > Signed-off-by: Matthew Wilcox > --- > drivers/usb/serial/usb-serial.c | 21 ++--- > 1 file changed, 10 insertions(+), 11 deletions(-) I really do not like taking patches without any changelog text at all :(

Re: Need a pairing decrement for mos_parport's refcount if write_parport_reg_nonblock fails?

2019-03-14 Thread Greg KH
On Fri, Mar 15, 2019 at 12:28:53PM +0800, 易林 wrote: > > Hi all, > > While analyzing the v5.0 source, I notice that when > write_parport_reg_nonblock failed and return -ENOMEN, > > the refcount of mos_parport increased by kref_get didn't decreased even after > return to the caller write_parpor

Re: Missing Thunderbolt 3 PCI-E atomics support

2019-03-13 Thread Greg KH
On Wed, Mar 13, 2019 at 03:38:44PM +0100, Timur Kristóf wrote: > On Wed, 2019-03-13 at 07:34 -0700, Greg KH wrote: > > On Wed, Mar 13, 2019 at 02:16:47PM +0100, Timur Kristóf wrote: > > > Hi, > > > > > > PCI-E atomics don't work for me with a Thunde

Re: Missing Thunderbolt 3 PCI-E atomics support

2019-03-13 Thread Greg KH
On Wed, Mar 13, 2019 at 02:16:47PM +0100, Timur Kristóf wrote: > Hi, > > PCI-E atomics don't work for me with a Thunderbolt 3 bridge. > I see the following message from my Thunderbolt 3 eGPU in dmesg: > > kfd: skipped device 1002:67df, PCI rejects atomics > > Hardware is a Dell XPS 13 9370 (with

Re: Using EHSET module

2019-03-07 Thread Greg KH
On Thu, Mar 07, 2019 at 03:24:29PM +0100, rchmielarz wrote: > Hi, > > I'm trying to certify USB on our device that is running Linux 4.14. > For windows systems we were using https://www.usb.org/usb2tools. For > linux the only option I have found is a kernel module called EHSET. > Unfortunately I c

Re: [PATCH] drivers: uwb: Kconfig: pedantic cleanups

2019-03-06 Thread Greg KH
On Wed, Mar 06, 2019 at 07:51:46PM +0100, Enrico Weigelt, metux IT consult wrote: > Signed-off-by: Enrico Weigelt, metux IT consult > --- > drivers/uwb/Kconfig | 42 +- > 1 file changed, 21 insertions(+), 21 deletions(-) I do not take patches without any

[GIT PULL] USB/PHY driver patches for 5.1-rc1

2019-03-06 Thread Greg KH
The following changes since commit d13937116f1e82bf508a6325111b322c30c85eb9: Linux 5.0-rc6 (2019-02-10 14:42:20 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git tags/usb-5.1-rc1 for you to fetch changes up to 1c7cf3d5e1c181caca75012

Re: [PATCH] [v2]USB:serial:pl2303:add new Pull-Up mode to support PL2303HXD (TYPE_HX)

2019-03-05 Thread Greg KH
On Wed, Mar 06, 2019 at 12:42:29PM +0800, Charles Yeh wrote: > Hi Johan / Greg, > > Do you have time to review the patch? > If there is no time.. Who else can review this patch? > Because my boss has been asking me to update the Linux patch... It is the middle of the merge window and we can not a

Re: [PATCH] usb: uas: fix usb subsystem hang after power off hub port

2019-03-03 Thread Greg KH
On Mon, Mar 04, 2019 at 02:08:54AM +, jacky@sony.com wrote: > > > This email is confidential and intended only for the use of the individual or > entity named above and may contain information that is privileged. If you are > not the intended recipient, y

Re: [xhci-hcd][linux 4.20.13] autosuspend on causes a single cpu core to stay in kernel mode using 100% of said cpu core.

2019-03-03 Thread Greg KH
On Sun, Mar 03, 2019 at 03:15:27PM +0100, Farelka kek wrote: > usbcore.autosuspend higher than -1, causes 1 cpu core to never step > down from kernel mode. Some hardware does not aupport autosuspend, so leaving it at -1 is good. > It happens on a core i5-7200U laptop, an acer f5-573g-50ec > Disab

Re: [PATCH] wusb: Remove unnecessary static function ckhdid_printf

2019-03-01 Thread Greg KH
On Fri, Mar 01, 2019 at 10:18:32AM -0800, Nick Desaulniers wrote: > On Thu, Feb 28, 2019 at 8:38 PM Joe Perches wrote: > > > > This static inline is unnecessary and can be removed > > by using the vsprintf %ph extension. > > > > This reduces overall object size by more than 2K. > > > > Signed-off-

Re: [PATCH] wusb: use correct format characters

2019-02-28 Thread Greg KH
On Thu, Feb 28, 2019 at 11:52:56AM +, Louis Taylor wrote: > When compiling with -Wformat, clang warns: > > ./include/linux/usb/wusb.h:245:5: warning: format specifies type > 'unsigned short' but the argument has type 'u8' (aka 'unsigned char') > [-Wformat] > ckhdid->data[0], ckhdid->data[1]

Re: Do usb_submit_urb() memory allocation errors really exist in the wild?

2019-02-26 Thread Greg KH
On Tue, Feb 26, 2019 at 01:09:30PM +0100, Nicolas Saenz Julienne wrote: > Hi, > as I'm sure most of you are aware of, every URB submission triggers a small > memory allocation in the host controller. For every host controller driver? I thought we had some that did not do that. > On top of that i

Re: [PATCH] usb: ehci: Cleanup itd/sidt_complete()

2019-02-25 Thread Greg KH
On Tue, Feb 26, 2019 at 12:51:44AM +0900, Suwan Kim wrote: > This patch makes itd/sitd_complete() use *bus instead of referening > ehci_to_hcd(ehci)->self. And remove unnecessary "urb = NULL" lines. That is two different things to do in the same patch, please break this up into different patches.

Re: Bus noise periodically causes ci_hdrc IRQ lockup

2019-02-23 Thread Greg KH
On Fri, Feb 22, 2019 at 10:43:17AM -0500, Chandler Griscom wrote: > Hello, > > I am encountering an issue where noise on USB devices is causing the > host ci_hdrc driver to stall. The system contains an i.MX6 board > (UDOO) connected to a USB touchscreen, SMSC95xx hub, an FTDI device, > and a hi-

Re: [PATCH 2/4] usb: xhci: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI

2019-02-21 Thread Greg KH
On Thu, Feb 21, 2019 at 10:56:18AM +0200, Mathias Nyman wrote: > On 20.2.2019 21.17, Greg KH wrote: > > On Wed, Feb 20, 2019 at 07:50:53PM +0200, Mathias Nyman wrote: > > > From: Balaji Manoharan > > > > > > This fix enables USB role feature on intel commerci

Re: [PATCH 1/4] usb: xhci: fix build warning - missing prototype

2019-02-21 Thread Greg KH
On Thu, Feb 21, 2019 at 10:39:46AM +0100, Jean-Philippe Menil wrote: > On Thu, 21 Feb 2019, Greg KH wrote: > > > On Wed, Feb 20, 2019 at 09:54:12PM +0100, Jean-Philippe Menil wrote: > > > On Wed, 20 Feb 2019, Greg KH wrote: > > > > > > > On Wed, Feb 2

Re: [PATCH 1/4] usb: xhci: fix build warning - missing prototype

2019-02-21 Thread Greg KH
On Wed, Feb 20, 2019 at 09:54:12PM +0100, Jean-Philippe Menil wrote: > On Wed, 20 Feb 2019, Greg KH wrote: > > > On Wed, Feb 20, 2019 at 07:50:52PM +0200, Mathias Nyman wrote: > > > From: Jean-Philippe Menil > > > > > > Fix build warning when building dri

Re: [PATCH 1/4] usb: xhci: fix build warning - missing prototype

2019-02-20 Thread Greg KH
On Wed, Feb 20, 2019 at 07:50:52PM +0200, Mathias Nyman wrote: > From: Jean-Philippe Menil > > Fix build warning when building drivers/usb/host/xhci-mem.o due to missing > prototype for xhci_free_virt_devices_depth_first. There is no normal "build warning", this is a sparse fixup, right?

Re: [PATCH 2/4] usb: xhci: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI

2019-02-20 Thread Greg KH
On Wed, Feb 20, 2019 at 07:50:53PM +0200, Mathias Nyman wrote: > From: Balaji Manoharan > > This fix enables USB role feature on intel commercial nuc > platform which is based on Kabylake chipset. > > Signed-off-by: Balaji Manoharan > Reviewed-by: Hans de Goede > Reviewed-by: Heikki Krogerus

Re: [PATCH 1/4] usb: xhci: fix build warning - missing prototype

2019-02-20 Thread Greg KH
On Wed, Feb 20, 2019 at 08:01:08PM +0200, Mathias Nyman wrote: > On 20.2.2019 19.50, Mathias Nyman wrote: > > From: Jean-Philippe Menil > > > > Fix build warning when building drivers/usb/host/xhci-mem.o due to missing > > prototype for xhci_free_virt_devices_depth_first. > > > > This function i

Re: usb: over-current condition

2019-02-19 Thread Greg KH
On Tue, Feb 19, 2019 at 08:00:11PM +0530, Subhashini Rao Beerisetty wrote: > Hi All, > > [ Please keep me in CC as I'm not subscribed to the list] > > > I’m using an Ubuntu 16.04.4 LTS PC and when I connect an USB device to > my Ubuntu PC, I see the below mentioned messages in dmesg. That's a v

Re: [PATCH v4 5/6] usb:cdns3 Add Cadence USB3 DRD Driver

2019-02-19 Thread Greg KH
On Thu, Feb 14, 2019 at 07:45:13PM +, Pawel Laszczak wrote: > This patch introduce new Cadence USBSS DRD driver to linux kernel. Nit, "Linux" :) > The Cadence USBSS DRD Driver is a highly configurable IP Core whichi "whichi"? > can be instantiated as Dual-Role Device (DRD), Peripheral Only

Re: [PATCH v4 2/6] usb:common Separated decoding functions from dwc3 driver.

2019-02-19 Thread Greg KH
On Thu, Feb 14, 2019 at 07:45:10PM +, Pawel Laszczak wrote: > Patch moves some decoding functions from driver/usb/dwc3/debug.h driver > to driver/usb/common/debug.c file. These moved functions include: > dwc3_decode_get_status > dwc3_decode_set_clear_feature > dwc3_decode_set_addres

Re: USB 3.0 device next to USB 2.0 receiver result in dysfunctional mouse

2019-02-19 Thread Greg KH
On Mon, Feb 18, 2019 at 10:59:43AM +0100, usbu...@mailbox.org wrote: > Hello, > > I build a new pc with the B450-I motherboard from Asus. My issue is the > following: When I plug-in a USB 3.0 device next to the unifying receiver from > logitech the mouse stops working. Meaning no movement, click

Re: 4.20.7: pl2303 not working (post-4.19 regression) (limited info so far, not yet bisected)

2019-02-16 Thread Greg KH
On Sat, Feb 16, 2019 at 04:26:30PM +, Nix wrote: > So I just tried to connect up to my ancient Soekris firewall's serial > console to try to bisect a problem where it stopped booting in 4.20, and > found I couldn't. > > minicom says: > > minicom: cannot open /dev/ttyUSB0: Input/output error >

Re: Location of HUB USB Report Descriptors?

2019-02-14 Thread Greg KH
On Thu, Feb 14, 2019 at 09:03:43AM -0700, Simon Wood wrote: > I am attempted to debug an android problem related to USB hubs. > > On desktop Linux 'lsusb -vv' details the HUB description, but 'lsusb' on > Android is the simple cousin and does not know this information. That's because Android is u

Re: [PATCH] usb: typec: tcpm: Export partner Source Capabilities

2019-02-14 Thread Greg KH
On Thu, Feb 14, 2019 at 02:17:14PM +, Adam Thomson wrote: > On 12 February 2019 16:20, Guenter Roeck wrote: > > > On 2/12/19 2:54 AM, Greg KH wrote: > > > On Tue, Feb 12, 2019 at 06:29:39PM +0800, Kyle Tso wrote: > > >> On Thu, Jan 31, 2019 at 3:02 PM Greg KH

Re: XHCI ISSUE: xhci_hcd: disabling already-disabled device

2019-02-12 Thread Greg KH
On Fri, Jan 25, 2019 at 02:45:05PM -0800, Todd Brandt wrote: > Hi Greg, we run weekly 48-hour S3/S2idle stress tests on each release > candidate, and I found a single instance (out of 2794 runs) of this > warning on the Lenovo Yoga 920 with linux 5.0.0-rc2 running S3 > suspend/resume. > > I notice

Re: [PATCH] usb: typec: tcpm: Export partner Source Capabilities

2019-02-12 Thread Greg KH
On Tue, Feb 12, 2019 at 06:29:39PM +0800, Kyle Tso wrote: > On Thu, Jan 31, 2019 at 3:02 PM Greg KH wrote: > > > On Thu, Jan 31, 2019 at 11:54:11AM +0800, Kyle Tso wrote: > > > Provide a function to get the partner Source Capabilities. > > >

Re: [PATCH] USB: serial: pl2303: add Delock Infrared device id

2019-02-09 Thread Greg KH
On Sat, Feb 09, 2019 at 12:18:40PM +0330, ebra...@gnu.org wrote: > From: Ebrahim Byagowi > > This makes Delock Infrared adapter to work as a USB to Serial device. > --- > drivers/usb/serial/pl2303.c | 1 + > drivers/usb/serial/pl2303.h | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git

[GIT PULL] USB driver fixes for 5.0-rc6

2019-02-08 Thread Greg KH
The following changes since commit f17b5f06cb92ef2250513a1e154c47b78df07d40: Linux 5.0-rc4 (2019-01-27 15:18:05 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git tags/usb-5.0-rc6 for you to fetch changes up to a07ddce4df807e41a85245e

Re: [PATCH v3 2/6] usb:common Separated decoding functions from dwc3 driver.

2019-02-04 Thread Greg KH
On Mon, Feb 04, 2019 at 04:17:00PM +0200, Felipe Balbi wrote: > > Hi, > > Greg KH writes: > > On Thu, Jan 31, 2019 at 11:52:29AM +, Pawel Laszczak wrote: > >> Patch moves some decoding functions from driver/usb/dwc3/debug.h driver > >> to driver/

Re: [PATCH v3 5/6] usb:cdns3 Add Cadence USB3 DRD Driver

2019-02-04 Thread Greg KH
On Thu, Jan 31, 2019 at 11:52:32AM +, Pawel Laszczak wrote: > This patch introduce new Cadence USBSS DRD driver > to linux kernel. > > The Cadence USBSS DRD Driver is a highly > configurable IP Core which can be > instantiated as Dual-Role Device (DRD), > Peripheral Only and Host Only (XHCI) >

Re: [PATCH v3 4/6] usb:common Simplify usb_decode_get_set_descriptor function.

2019-02-04 Thread Greg KH
On Thu, Jan 31, 2019 at 11:52:31AM +, Pawel Laszczak wrote: > Patch moves switch responsible for decoding descriptor type > outside snprintf. It's little improves code readability. Should that last sentence read: "It improves code readability a little"? thanks, greg k-h

Re: [PATCH v3 2/6] usb:common Separated decoding functions from dwc3 driver.

2019-02-04 Thread Greg KH
On Thu, Jan 31, 2019 at 11:52:29AM +, Pawel Laszczak wrote: > Patch moves some decoding functions from driver/usb/dwc3/debug.h driver > to driver/usb/common/debug.c file. These moved functions include: > dwc3_decode_get_status > dwc3_decode_set_clear_feature > dwc3_decode_set_addres

Re: [PATCH v3 2/6] usb:common Separated decoding functions from dwc3 driver.

2019-02-04 Thread Greg KH
On Thu, Jan 31, 2019 at 11:52:29AM +, Pawel Laszczak wrote: > Patch moves some decoding functions from driver/usb/dwc3/debug.h driver > to driver/usb/common/debug.c file. These moved functions include: > dwc3_decode_get_status > dwc3_decode_set_clear_feature > dwc3_decode_set_addres

Re: NEC/Renesas µPD720201

2019-02-03 Thread Greg KH
On Sun, Feb 03, 2019 at 12:07:28PM +0100, Stefan Kalis wrote: > I got a Renkforce 986823-card with the mentioned chipset that became > unusable with kernel 4.9 - most likely due to a patch that introduced > firmware loading for cards without firmware-ROM. The patch was written > by Christian Lampar

Re: [PATCH] usb: typec: tcpm: Correct the PPS out_volt calculation

2019-01-31 Thread Greg KH
On Thu, Jan 31, 2019 at 09:31:25AM +0200, Heikki Krogerus wrote: > On Wed, Jan 30, 2019 at 11:13:53AM +0800, Kyle Tso wrote: > > When Sink negotiates PPS, the voltage range of selected PPS APDO might > > not cover the previous voltage (out_volt). If the previous out_volt is > > lower than the new m

Re: [PATCH] usb: typec: tcpm: Export partner Source Capabilities

2019-01-30 Thread Greg KH
On Thu, Jan 31, 2019 at 11:54:11AM +0800, Kyle Tso wrote: > Provide a function to get the partner Source Capabilities. > > Signed-off-by: Kyle Tso > --- > drivers/usb/typec/tcpm/tcpm.c | 23 +++ > include/linux/usb/tcpm.h | 1 + > 2 files changed, 24 insertions(+) > >

Re: [PATCH v2] USB: Disable USB2 LPM at shutdown

2019-01-30 Thread Greg KH
On Thu, Jan 24, 2019 at 02:16:43PM +0800, Kai-Heng Feng wrote: > The QCA Rome USB Bluetooth controller has several issues once LPM gets > enabled: > - Fails to get enumerated in coldboot. [1] > - Drains more power (~ 0.2W) when the system is in S5. [2] > - Disappears after a warmboot. [2] > > The

Re: [PATCH v2 6/6] usb: typec: ucsi: add firmware flashing support

2019-01-29 Thread Greg KH
On Mon, Jan 28, 2019 at 12:37:31PM -0800, Ajay Gupta wrote: > + /* > + * CCG firmware image (.cyacd) file line format > + * > + * :00[dd]cc/r/n > + * > + * :00 header > + * is row nu

Re: [PATCH v2 1/6] usb: typec: ucsi: add get_fw_info function

2019-01-29 Thread Greg KH
On Mon, Jan 28, 2019 at 12:37:26PM -0800, Ajay Gupta wrote: > Function is to get the details of ccg firmware and device version. > It will be useful in debugging and also during firmware update. > > Signed-off-by: Ajay Gupta Your "From:" and Signed-off-by: lines do not match :(

Re: [PATCH v2 6/6] usb: typec: ucsi: add firmware flashing support

2019-01-29 Thread Greg KH
On Mon, Jan 28, 2019 at 12:37:31PM -0800, Ajay Gupta wrote: > +static int ccg_restart(struct ucsi_ccg *uc) > +{ > + struct device *dev = uc->dev; > + int status; > + > + status = ucsi_ccg_init(uc); > + if (status < 0) { > + dev_err(dev, "ucsi_ccg_start fail, err=%d\n", s

Re: [PATCH v2 1/6] usb: typec: ucsi: add get_fw_info function

2019-01-29 Thread Greg KH
On Mon, Jan 28, 2019 at 12:37:26PM -0800, Ajay Gupta wrote: > Function is to get the details of ccg firmware and device version. > It will be useful in debugging and also during firmware update. > > Signed-off-by: Ajay Gupta > --- > Changes from v1: > - Updated commit message > - Drop

Re: XHCI ISSUE: xhci_hcd: disabling already-disabled device

2019-01-26 Thread Greg KH
On Sat, Jan 26, 2019 at 02:56:24PM +0100, Greg KH wrote: > On Fri, Jan 25, 2019 at 03:02:11PM -0800, Todd Brandt wrote: > > Hi Greg, we run weekly 48-hour S3/S2idle stress tests on each release > > candidate, and I found a single instance (out of 2794 runs) of this > > warni

Re: XHCI ISSUE: xhci_hcd: disabling already-disabled device

2019-01-26 Thread Greg KH
On Fri, Jan 25, 2019 at 03:02:11PM -0800, Todd Brandt wrote: > Hi Greg, we run weekly 48-hour S3/S2idle stress tests on each release > candidate, and I found a single instance (out of 2794 runs) of this > warning on the Lenovo Yoga 920 with linux 5.0.0-rc2 running S3 > suspend/resume. > > I notice

[GIT PULL] USB driver fixes for 5.0-rc4

2019-01-25 Thread Greg KH
The following changes since commit 1c7fc5cbc33980acd13d668f1c8f0313d6ae9fd8: Linux 5.0-rc2 (2019-01-14 10:41:12 +1200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git tags/usb-5.0-rc4 for you to fetch changes up to 4f9b838927812b5949a9899

Re: [PATCH 1/4] tty: sisusb_con, convert addr macros to functions

2019-01-25 Thread Greg KH
On Tue, Jan 22, 2019 at 04:26:12PM +0100, Jiri Slaby wrote: > On 22. 01. 19, 16:23, Greg KH wrote: > > On Tue, Jan 22, 2019 at 04:11:59PM +0100, Jiri Slaby wrote: > >> Convert SISUSB_VADDR and SISUSB_HADDR to inline functions. Now, there > >> are no more hidden accesses

Re: [PATCH] usbip: Fix vep_free_request() null pointer checks on input args

2019-01-25 Thread Greg KH
On Tue, Jan 22, 2019 at 04:05:28PM -0700, shuah wrote: > On 1/19/19 1:17 AM, Greg KH wrote: > > On Fri, Jan 18, 2019 at 02:29:30PM -0700, Shuah Khan wrote: > > > From: Shuah Khan > > > > > > Fix vep_free_request() to return when usb_ep and usb_request are n

Re: MUSB interrupt storm on device removal

2019-01-24 Thread Greg KH
On Wed, Jan 23, 2019 at 02:12:38PM -0600, Bin Liu wrote: > > > > > Thanks for the info. > > > > > I will handle this case in musb driver. > > > > > > > > Why doesn't the same problem occur with other types of host controller? > > > > > > Not sure, I am on musb for most of the times. Maybe other H

Re: [Intel-gfx] [PATCH 1/3] treewide: Lift switch variables out of switches

2019-01-24 Thread Greg KH
On Thu, Jan 24, 2019 at 07:55:51AM +1300, Kees Cook wrote: > On Thu, Jan 24, 2019 at 4:44 AM Jani Nikula > wrote: > > > > On Wed, 23 Jan 2019, Edwin Zimmerman wrote: > > > On Wed, 23 Jan 2019, Jani Nikula wrote: > > >> On Wed, 23 Jan 2019, Greg KH wrote:

Re: [PATCH -next] usb: ftdi-elan: Fix if == else warnings in ftdi_elan_respond_engine

2019-01-23 Thread Greg KH
On Wed, Jan 23, 2019 at 09:17:38PM +0800, YueHaibing wrote: > On 2019/1/23 20:43, Greg KH wrote: > > On Wed, Jan 23, 2019 at 08:34:42PM +0800, YueHaibing wrote: > >> ./drivers/usb/misc/ftdi-elan.c:972:10-12: WARNING: possible condition with > >> no effect (if == else) &

Re: [PATCH -next] usb: ftdi-elan: Fix if == else warnings in ftdi_elan_respond_engine

2019-01-23 Thread Greg KH
On Wed, Jan 23, 2019 at 08:34:42PM +0800, YueHaibing wrote: > ./drivers/usb/misc/ftdi-elan.c:972:10-12: WARNING: possible condition with no > effect (if == else) > ./drivers/usb/misc/ftdi-elan.c:983:9-11: WARNING: possible condition with no > effect (if == else) > ./drivers/usb/misc/ftdi-elan.c:2

Re: [PATCH 1/3] treewide: Lift switch variables out of switches

2019-01-23 Thread Greg KH
On Wed, Jan 23, 2019 at 03:03:47AM -0800, Kees Cook wrote: > Variables declared in a switch statement before any case statements > cannot be initialized, so move all instances out of the switches. > After this, future always-initialized stack variables will work > and not throw warnings like this:

Re: usb: dwc2: usb data transmitted to incorrect usb endpoint

2019-01-22 Thread Greg KH
On Wed, Jan 23, 2019 at 06:52:00AM +, Maynard CABIENTE wrote: > This e-mail, and any document attached hereby, may contain confidential > and/or privileged information. If you are not the intended recipient (or have > received this e-mail in error) please notify the sender immediately and >

Re: MUSB interrupt storm on device removal

2019-01-22 Thread Greg KH
On Tue, Jan 22, 2019 at 02:52:44PM -0600, Bin Liu wrote: > Hi Johan, > > On Tue, Jan 22, 2019 at 02:16:30PM -0600, Bin Liu wrote: > > On Tue, Jan 22, 2019 at 05:19:39PM +, Måns Rullgård wrote: > > > Bin Liu writes: > > > > > > > On Mon, Jan 21, 2019 at 09:20:52PM +, Måns Rullgård wrote:

Re: [PATCH 1/4] tty: sisusb_con, convert addr macros to functions

2019-01-22 Thread Greg KH
On Tue, Jan 22, 2019 at 04:11:59PM +0100, Jiri Slaby wrote: > Convert SISUSB_VADDR and SISUSB_HADDR to inline functions. Now, there > are no more hidden accesses to local variables (vc_data and > sisusb_usb_data). > > sisusb_haddr returns unsigned long from now on, not u16 *, as ulong is > what ev

Re: [PATCH] usb: core: endpoint: Add error messages for usb_create_ep_devs()

2019-01-21 Thread Greg KH
On Mon, Jan 21, 2019 at 11:30:55PM +0900, Suwan Kim wrote: > usb_create_ep_devs() returns error code if an error occurs. But > usb_new_device() and create_intf_ep_devs() which use usb_create_ep_devs() > to create endpoint devices ignore the error and cut the propagation > of the error when usb_crea

Re: [PATCH] usbip: Fix vhci_urb_enqueue() URB null transfer buffer error path

2019-01-19 Thread Greg KH
On Fri, Jan 18, 2019 at 02:29:31PM -0700, Shuah Khan wrote: > From: Shuah Khan > > Fix vhci_urb_enqueue() to print error and return error instead of > failing with WARN_ON. > > Signed-off-by: Shuah Khan > --- > drivers/usb/usbip/vhci_hcd.c | 6 -- > 1 file changed, 4 insertions(+), 2 delet

Re: [PATCH] usbip: Fix vep_free_request() null pointer checks on input args

2019-01-19 Thread Greg KH
On Fri, Jan 18, 2019 at 02:29:30PM -0700, Shuah Khan wrote: > From: Shuah Khan > > Fix vep_free_request() to return when usb_ep and usb_request are null > instead of calling WARN_ON. > > Signed-off-by: Shuah Khan > --- > drivers/usb/usbip/vudc_dev.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH 5/7] usb: typec: ucsi: add fw update needed check

2019-01-17 Thread Greg KH
On Thu, Jan 17, 2019 at 05:12:38PM -0800, Ajay Gupta wrote: > This will be needed to check if latest fw is already flashed. > > Signed-off-by: Ajay Gupta > --- > drivers/usb/typec/ucsi/ucsi_ccg.c | 139 ++ > 1 file changed, 139 insertions(+) > > diff --git a/drivers/

Re: [PATCH 1/7] usb: typec: ucsi: add get_fw_info function

2019-01-17 Thread Greg KH
On Thu, Jan 17, 2019 at 05:09:03PM -0800, Ajay Gupta wrote: > Function is to get the details of ccg firmware and device version. > > Signed-off-by: Ajay Gupta > --- > drivers/usb/typec/ucsi/ucsi_ccg.c | 76 ++- > 1 file changed, 74 insertions(+), 2 deletions(-) > > d

Re: [PATCH 2/7] usb: typec: ucsi: add ccg command framework

2019-01-17 Thread Greg KH
On Thu, Jan 17, 2019 at 05:09:04PM -0800, Ajay Gupta wrote: > Used to send command to ccg controller Writing changelog comments is hard, but please do more than just tiny snippets like this. Explain _why_ this change is needed in detail please. Same for all of these patches, you are adding new f

Re: [PATCH 5/7] usb: typec: ucsi: add fw update needed check

2019-01-17 Thread Greg KH
On Thu, Jan 17, 2019 at 05:12:38PM -0800, Ajay Gupta wrote: > This will be needed to check if latest fw is already flashed. Very odd changelog text, please make this more detailed. And your email threading broke here, did your email client change? thanks, greg k-h

Re: [PATCH v2] usb: warm-reset ports on hub resume, if requested

2019-01-16 Thread Greg KH
On Wed, Jan 16, 2019 at 05:06:33PM +0100, Jan-Marek Glogowski wrote: > On plug-in of my USB-C device, its USB_SS_PORT_LS_SS_INACTIVE > link state bit is set. Greping all the kernel for this bit shows > that the port status requests a warm-reset this way. > > This just happens, if its the only devi

[GIT PULL] USB driver fixes for 5.0-rc2

2019-01-13 Thread Greg KH
The following changes since commit bfeffd155283772bbe78c6a05dec7c0128ee500c: Linux 5.0-rc1 (2019-01-06 17:08:20 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git tags/usb-5.0-rc2 for you to fetch changes up to b9fcb0e6b7052b7e2d18fed

Re: [PATCH v4] USB: Don't enable LPM if it's already enabled

2019-01-11 Thread Greg KH
On Tue, Jan 08, 2019 at 12:34:17PM -0500, Alan Stern wrote: > On Wed, 9 Jan 2019, Kai Heng Feng wrote: > > > > On Jan 8, 2019, at 11:41 PM, Greg KH wrote: > > > > > > On Mon, Dec 03, 2018 at 06:26:43PM +0800, Kai-Heng Feng wrote: > > >> USB Blueto

Re: [PATCH] drivers/usb/storage/cypress_atacb.c: Remove duplicate header

2019-01-11 Thread Greg KH
On Thu, Jan 10, 2019 at 12:19:36PM +0530, Sabyasachi Gupta wrote: > Remove unusual_cypress.h which is included more than once. > > Signed-off-by: Sabyasachi Gupta > --- > drivers/usb/storage/cypress_atacb.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/storage/cypress_atac

Re: [PATCH] drivers/usb/storage: Remove duplicate headers

2019-01-11 Thread Greg KH
On Thu, Jan 10, 2019 at 12:40:07PM +0530, Sabyasachi Gupta wrote: > Remove duplicate headers which are included more than once. > > Signed-off-by: Sabyasachi Gupta > --- > drivers/usb/storage/datafab.c| 1 - > drivers/usb/storage/ene_ub6250.c | 1 - > 2 files changed, 2 deletions(-) > > dif

Re: [PATCH] drivers/usb/storage/sddr55.c: Remove duplicate header

2019-01-11 Thread Greg KH
On Thu, Jan 10, 2019 at 01:10:25PM +0530, Sabyasachi Gupta wrote: > Remove unusual_sddr55.h which is included more than once > > Signed-off-by: Sabyasachi Gupta > --- > drivers/usb/storage/sddr55.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/storage/sddr55.c b/drivers/us

Re: [PATCH v4] USB: Don't enable LPM if it's already enabled

2019-01-08 Thread Greg KH
On Mon, Dec 03, 2018 at 06:26:43PM +0800, Kai-Heng Feng wrote: > USB Bluetooth controller QCA ROME (0cf3:e007) sometimes stops working > after S3: > [ 165.110742] Bluetooth: hci0: using NVM file: qca/nvm_usb_0302.bin > [ 168.432065] Bluetooth: hci0: Failed to send body at 4 of 1953 (-110) > >

Re: [PATCH V2] usb:xhci: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI

2019-01-07 Thread Greg KH
On Tue, Jan 08, 2019 at 11:31:53AM -0500, m.bal...@intel.com wrote: > From: M, Balaji We need a "full" name, "M," is probably not your first name :) thanks, greg k-h

Re: [PATCH v3] usb: hub: add retry routine after intr URB submit error

2019-01-07 Thread Greg KH
On Tue, Nov 20, 2018 at 03:34:38PM +0100, Nicolas Saenz Julienne wrote: > The hub sends hot-plug events to the host trough it's interrupt URB. The > driver takes care of completing the URB and re-submitting it. Completion > errors are handled in the hub_event() work, yet submission errors are > ign

Re: [PATCH V2] roles: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI

2019-01-07 Thread Greg KH
On Tue, Jan 08, 2019 at 05:04:20AM -0500, m.bal...@intel.com wrote: > From: M, Balaji > > This fix enables USB role feature on intel commercial nuc > platform which is based on Kabylake chipset. Your subject prefix is a bit odd "roles" is not a global thing, it should look something like:

Re: [PATCH] USB: host: ehci: allow tine of highspeed nak-count

2019-01-07 Thread Greg KH
On Wed, Nov 14, 2018 at 05:13:15PM +, Ben Dooks wrote: > From: Ben Dooks > > At least some systems benefit with less scheduling if the NAK count > value is set higher than the default 4. For instance a Tegra3 with > an SMSC9512 showed less interrupt load when this was changed to 14. > > To a

Re: [PATCH v4] USB: Don't enable LPM if it's already enabled

2019-01-07 Thread Greg KH
On Mon, Dec 03, 2018 at 06:26:43PM +0800, Kai-Heng Feng wrote: > USB Bluetooth controller QCA ROME (0cf3:e007) sometimes stops working > after S3: > [ 165.110742] Bluetooth: hci0: using NVM file: qca/nvm_usb_0302.bin > [ 168.432065] Bluetooth: hci0: Failed to send body at 4 of 1953 (-110) > >

Re: [PATCH] usbcore: Select only first configuration for non-UAC3 compliant devices

2019-01-05 Thread Greg KH
On Sat, Jan 05, 2019 at 07:32:37PM +0530, saranya.go...@intel.com wrote: > From: Saranya Gopal > > In most of the UAC1 and UAC2 audio devices, the first > configuration is most often the best configuration. > However, with recent patch to support UAC3 configuration, > second configuration was uni

[GIT PULL] USB/PHY driver patches for 4.21-rc1

2018-12-28 Thread Greg KH
The following changes since commit 177c459b08a34dcf004aa9a4c1f1d8be682ff3af: Merge tag 'usb-4.20-rc8' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb (2018-12-20 07:27:39 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git

Re: SHANWAN pad rumbling not working on USB

2018-12-27 Thread Greg KH
On Thu, Dec 27, 2018 at 07:34:25PM +0800, liquid wrote: > It's a PS3 "clone" joystick. Everything works fine EXCEPT rumbling. > > I think it's related to commit > 492ca83c3d19fba1622164f07cd7b775596a7db2 (HID: sony: Fix SHANWAN pad > rumbling on USB ) . If I revert this commit, the controller star

Re: SHANWAN pad rumbling not working on USB

2018-12-27 Thread Greg KH
Adding linux-input which is the best list for this... On Thu, Dec 27, 2018 at 09:17:22AM +0800, liquid wrote: > Rumbling function on SHANWAN DS3 clone joystick doesn't work. > Meanwhile it can work fine on Windows ScpToolkit v1.7.277.16103-BETA. > (Tested with PCSX2 lilypad Win32 build). > > SDL2

<    1   2   3   4   5   6   7   8   9   10   >