-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/function/f_uvc.c | 26 +-
drivers/usb/gadget/function/f_uvc.h | 6 +-
drivers/usb/gadget/legacy/webcam.c | 27 ---
3 files changed, 38 insertions(+), 21 deletions
Simplify ioctl handling by using video_ioctl2.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Acked-by: Andrzej Pietrasiewicz andrze...@samsung.com
---
drivers/usb/gadget/function/f_uvc.c| 2 +
drivers/usb/gadget/function/uvc_v4l2.c | 298
From: Andrzej Pietrasiewicz andrze...@samsung.com
There are no users of the old interface left. Remove it.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Tested-by: Michael Grzeschik m.grzesc...@pengutronix.de
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
From: Andrzej Pietrasiewicz andrze...@samsung.com
There are no users of the old interface left. Remove it.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Tested-by: Michael Grzeschik m.grzesc...@pengutronix.de
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
uvc_v4l2_ioctl_ops non-static]
[Rename __UVC__V4L2__H__ and __UVC__VIDEO__H__]
[Update MAINTAINERS]
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Acked-by: Andrzej Pietrasiewicz andrze...@samsung.com
---
MAINTAINERS | 2 +-
drivers/usb/gadget/function
From: Andrzej Pietrasiewicz andrze...@samsung.com
Use the new function interface of f_uvc.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Tested-by: Michael Grzeschik m.grzesc...@pengutronix.de
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget
-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Tested-by: Michael Grzeschik m.grzesc...@pengutronix.de
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/function/f_uvc.c | 28 +++-
1 file changed, 11 insertions(+), 17 deletions
-by: Michael Grzeschik m.grzesc...@pengutronix.de
[Rename uvc_video_pump and uvc_queue_head as well]
[Rename forgotten uvc_queue_cancel instance in a comment]
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Acked-by: Andrzej Pietrasiewicz andrze...@samsung.com
---
drivers/usb/gadget
, 338 insertions(+), 226 deletions(-)
create mode 100644 drivers/usb/gadget/function/u_uvc.h
create mode 100644 drivers/usb/gadget/function/uvc_v4l2.h
create mode 100644 drivers/usb/gadget/function/uvc_video.h
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line
]
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Acked-by: Andrzej Pietrasiewicz andrze...@samsung.com
---
drivers/usb/gadget/Kconfig | 3 +
drivers/usb/gadget/function/Makefile | 2 +
drivers/usb/gadget/function/f_uvc.c | 204 +--
drivers
Hi Andrzej,
On Wednesday 27 August 2014 17:33:16 Andrzej Pietrasiewicz wrote:
W dniu 18.08.2014 o 21:45, Laurent Pinchart pisze:
Hi Andrzej,
Thank you for the patches. The series looks good, I only had a few
comments.
I have rebased the patches on top of my UVC gadget branch
= VFL_DIR_TX;
Do you have any objection against squashing this patch into usb: gadget:
f_uvc: Move to video_ioctl2 ?
strlcpy(video-name, cdev-gadget-name, sizeof(video-name));
uvc-vdev = video;
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe
.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Michael,
On Monday 25 August 2014 15:59:57 Michael Grzeschik wrote:
On Wed, Aug 20, 2014 at 07:05:30PM +0200, Laurent Pinchart wrote:
On Wednesday 20 August 2014 02:06:54 Hans Verkuil wrote:
On 08/19/2014 05:01 PM, Laurent Pinchart wrote:
Hi Michael,
Thank you for the patch
.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Acked-by: Sebastian Andrzej Siewior bige...@linutronix.de
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/function/f_uvc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
-off-by: Philipp Zabel p.za...@pengutronix.de
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/function/uvc_queue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/uvc_queue.c
b/drivers/usb/gadget/function
From: Michael Grzeschik m.grzesc...@pengutronix.de
As the driver is mainline we can remove the version numbers.
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/function/uvc.h | 3
/uvc_queue.c | 2 +-
drivers/usb/gadget/function/uvc_v4l2.c | 2 +-
drivers/usb/gadget/function/uvc_video.c | 2 +-
5 files changed, 5 insertions(+), 9 deletions(-)
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
m.grzesc...@pengutronix.de
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/function/uvc_video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/uvc_video.c
b/drivers/usb/gadget/function/uvc_video.c
index
Hi Felipe,
On Wednesday 20 August 2014 10:39:43 Felipe Balbi wrote:
On Mon, Aug 18, 2014 at 09:45:08PM +0200, Laurent Pinchart wrote:
Hi Andrzej,
Thank you for the patches. The series looks good, I only had a few
comments.
I have rebased the patches on top of my UVC gadget branch
Hi Michael,
On Wednesday 20 August 2014 09:55:10 Michael Grzeschik wrote:
On Mon, Aug 18, 2014 at 11:16:36PM +0200, Laurent Pinchart wrote:
On Monday 18 August 2014 18:24:26 Hans Verkuil wrote:
On 08/18/2014 05:06 PM, Laurent Pinchart wrote:
Simplify ioctl handling by using video_ioctl2
Hi Hans and Michael,
On Wednesday 20 August 2014 02:06:54 Hans Verkuil wrote:
On 08/19/2014 05:01 PM, Laurent Pinchart wrote:
Hi Michael,
Thank you for the patch.
(CC'ing Hans Verkuil and the linux-media mailing list)
On Friday 08 August 2014 17:38:58 Michael Grzeschik wrote
doesn't introduce a
regression in that area. Thus,
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Felipe, do you plan to push the patch as a fix for v3.17 ?
--
Regards,
Laurent Pinchart
signature.asc
Description: This is a digitally signed message part.
is already used
in several places in this function.
break;
}
spin_unlock_irqrestore(video-queue.irqlock, flags);
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message
*/
case VIDIOC_G_FMT:
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
UVC_NUM_REQUESTS 4
+#define UVC_NUM_REQUESTS 16
#define UVC_MAX_REQUEST_SIZE 64
#define UVC_MAX_EVENTS 4
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb
On Tuesday 19 August 2014 11:35:12 Felipe Balbi wrote:
On Tue, Aug 19, 2014 at 06:33:07PM +0200, Laurent Pinchart wrote:
On Tuesday 19 August 2014 09:11:57 Felipe Balbi wrote:
On Fri, Aug 08, 2014 at 05:38:57PM +0200, Michael Grzeschik wrote:
If the pending buffers in the queue could
Simplify ioctl handling by using video_ioctl2.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/function/f_uvc.c| 1 +
drivers/usb/gadget/function/uvc_v4l2.c | 298 +
2 files changed, 158 insertions(+), 141 deletions
DRIVER_VERSION{,_NUMBER} patch. The result can be found at
git://linuxtv.org/pinchartl/media.git uvc/gadget
The patches have been compile-tested only so far. I'd appreciate if someone
could test them on real hardware.
Laurent Pinchart (2):
usb: gadget: f_uvc: Store EP0 control request state
is dequeued.
This two-steps approach isn't necessary. Simplify the driver by storing
the needed information in the driver internal state structure directly
during the setup stage.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/function/f_uvc.c| 6
++---
4 files changed, 45 insertions(+), 44 deletions(-)
[snip]
The patch looks good. For coherency reasons, could you please also rename
uvc_video_pump and uvc_queue_head ?
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body
-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/function/f_uvc.c | 26 +-
drivers/usb/gadget/function/f_uvc.h | 6 +-
drivers/usb/gadget/legacy/webcam.c | 27 ---
3 files changed, 38 insertions(+), 21
/usb/gadget/function/uvc_v4l2.h new file mode 100644
index 000..ebcb1d1
--- /dev/null
+++ b/drivers/usb/gadget/function/uvc_v4l2.h
@@ -0,0 +1,21 @@
+/*
+ * uvc_v4l2.h -- USB Video Class Gadget driver
+ *
+ * Copyright (C) 2009-2010
+ * Laurent Pinchart (laurent.pinch
+ *
+ * Utility definitions for the uvc function
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ * http://www.samsung.com
2013-2014 ?
Apart from that,
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
+ *
+ * Author: Andrzej Pietrasiewicz andrze...@samsung.com
specific copy is created with usb_gstrings_attach.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/function/f_uvc.c | 28 +++-
1 file changed, 11 insertions(+), 17 deletions
files changed, 344 insertions(+), 216 deletions(-)
create mode 100644 drivers/usb/gadget/function/u_uvc.h
create mode 100644 drivers/usb/gadget/function/uvc_v4l2.h
create mode 100644 drivers/usb/gadget/function/uvc_video.h
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send
Hi Hans,
On Monday 18 August 2014 18:24:26 Hans Verkuil wrote:
On 08/18/2014 05:06 PM, Laurent Pinchart wrote:
Simplify ioctl handling by using video_ioctl2.
Are you able to test this on actual hardware? And if so, can you run
v4l2-compliance?
I'm afraid not. I don't have a platform
. Michael, could you please update your patch ?
--
Regards,
Laurent Pinchart
signature.asc
Description: This is a digitally signed message part.
Hi Michael,
Thank you for the patch.
On Thursday 14 August 2014 13:09:44 Michael Grzeschik wrote:
As the driver is mainline we can remove the version numbers.
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Hi Hans,
On Tuesday 12 August 2014 17:38:55 Hans Verkuil wrote:
On 08/12/2014 05:07 PM, Hans de Goede wrote:
On 08/07/2014 04:49 PM, Udo van den Heuvel wrote:
On 2014-08-04 11:17, Laurent Pinchart wrote:
(CC'ing Hans de Goede, the pwc maintainer, and the linux-media mailing
list
On Tuesday 12 August 2014 18:27:03 Hans Verkuil wrote:
On 08/12/2014 06:21 PM, Laurent Pinchart wrote:
Hi Hans,
On Tuesday 12 August 2014 17:38:55 Hans Verkuil wrote:
On 08/12/2014 05:07 PM, Hans de Goede wrote:
On 08/07/2014 04:49 PM, Udo van den Heuvel wrote:
On 2014-08-04 11:17
.
What went wrong?
How to fix?
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
15 files changed, 61 insertions(+), 15 deletions(-)
--
Regards,
Laurent Pinchart
signature.asc
Description: This is a digitally signed message part.
) {
+ schedule_work(musb-irq_work);
+ }
return handled;
}
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
time to give this a quick look ?
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Felipe and Adam,
On Monday 21 July 2014 10:40:52 Felipe Balbi wrote:
On Mon, Jul 21, 2014 at 05:28:58PM +0200, Laurent Pinchart wrote:
On Wednesday 29 January 2014 08:44:57 Adam Wozniak wrote:
With a USB 2.0 webcam attached to the OTG port on an OMAP3 (applies to
overo gumstix
be replaced with IS_ERR().
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
Acked-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
---
drivers/usb/gadget/udc/r8a66597-udc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/r8a66597
yongjun_...@trendmicro.com.cn
Acked-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
---
drivers/usb/gadget/udc/r8a66597-udc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/udc/r8a66597-udc.c
b/drivers/usb/gadget/udc/r8a66597-udc.c
:
{
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
;
video-bpp = format-bpp;
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
= uvc_function_disable;
+ uvc-func.resume = uvc_function_resume;
uvc-func.setup = uvc_function_setup;
ret = usb_add_function(c, uvc-func);
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
-memory == V4L2_MEMORY_MMAP) ? video-imagesize : 0;
return 0;
}
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
);
queue-queue.ops = uvc_queue_qops;
queue-queue.mem_ops = vb2_vmalloc_memops;
+ queue-queue.timestamp_type = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
ret = vb2_queue_init(queue-queue);
if (ret)
return ret;
--
Regards,
Laurent Pinchart
--
To unsubscribe from
-off-by: Philipp Zabel p.za...@pengutronix.de
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
and applied to my tree. I'll push it to v3.17.
---
drivers/usb/gadget/uvc_queue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/uvc_queue.c b
this to KERN_DEBUG.
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
and applied to my tree. I'll push it to v3.17.
---
drivers/usb/gadget/uvc_video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
;
}
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Andrzej,
Thank you for the patch.
On Friday 28 February 2014 10:32:27 Andrzej Pietrasiewicz wrote:
Use the new function interface of f_uvc.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget
;
+ uvc-func.setup = uvc_function_setup;
+ uvc-func.free_func = uvc_free;
+
+ return uvc-func;
+}
+
+DECLARE_USB_FUNCTION_INIT(uvc, uvc_alloc_inst, uvc_alloc);
+MODULE_LICENSE(GPL);
+MODULE_AUTHOR(Laurent Pinchart);
+
+#endif
+
diff --git a/drivers/usb/gadget/u_uvc.h b
+ * Laurent Pinchart (laurent.pinch...@ideasonboard.com)
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
2014 ?
+ * http://www.samsung.com
+ * Author: Andrzej Pietrasiewicz andrze...@samsung.com
+ *
+ * This program is free software; you can redistribute
unconditionally;
if it happens to be NULL kfree on it is safe anyway.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
and applied to my tree. I'll push it to v3.17.
---
drivers/usb/gadget/f_uvc.c | 5 ++---
1 file changed, 2
,
+ streaming_maxburst_webcam, uvc_gadget_trace_param_webcam);
}
static struct usb_configuration webcam_config_driver = {
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Hi Andrzej,
Thank you for the patch.
On Friday 28 February 2014 10:32:28 Andrzej Pietrasiewicz wrote:
There are no users of the old interface left. Remove it.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
_UVC_CONFIGFS_H_
_UVC_QUEUE_H_
_UVC_V4L2_H_
_UVC_VIDEO_H_
+
+#include linux/kernel.h
+#include linux/slab.h
+#include linux/configfs.h
+#include linux/usb/video.h
Usual comment :-)
[snip]
+
+#endif /* UVC_CONFIGFS_H */
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line
,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
be tempted to classify this as an XHCI controller issue. linux-
usb should be the right list to get help. I've CC'ed Mathias Nyman, the XHCI
maintainer.
Johannes, could you enable USB debugging in the linus/master kernel and
provide a kernel log ?
--
Regards,
Laurent Pinchart
--
To unsubscribe
bNumConfigurations 1
Device Status: 0x
(Bus Powered)
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
: Greg Kroah-Hartman gre...@linuxfoundation.org
Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com
Could you please CC the linux-sh mailing list for similar patches in the
future ?
Sergei, any opinion on this ?
---
drivers/usb/phy/Kconfig |1 +
1 file changed, 1 insertion
Hi Sergei,
On Monday 26 May 2014 17:55:49 Sergei Shtylyov wrote:
On 05/26/2014 04:50 PM, Laurent Pinchart wrote:
The Renesas R-Car USB PHY driver only supports the R8A7778 and
R8A7779, it isn't useful on other systems unless build testing.
Signed-off-by: Jean Delvare jdelv...@suse.de
Hi Felipe,
On Thursday 15 May 2014 10:39:45 Felipe Balbi wrote:
On Fri, May 09, 2014 at 02:27:34PM +0200, Laurent Pinchart wrote:
Hi Felipe,
Could you please pull the following three patches for v3.16 ? They've
been reviewed on the linux-media and linux-usb mailing list.
ok
)
Laurent Pinchart (3):
usb: gadget: uvc: Switch to monotonic clock for buffer timestamps
usb: gadget: uvc: Set the V4L2 buffer field to V4L2_FIELD_NONE
usb: gadget: uvc: Set the vb2 queue timestamp flags
drivers/usb/gadget/uvc_queue.c | 12 +---
1 file changed, 5 insertions
Hi Thomas,
On Wednesday 16 April 2014 12:29:22 Thomas Pugliese wrote:
On Wed, 16 Apr 2014, Laurent Pinchart wrote:
Hi Thomas,
(CC'ing the linux-usb mailing list)
On Tuesday 15 April 2014 16:45:28 Thomas Pugliese wrote:
On Tue, 15 Apr 2014, Laurent Pinchart wrote:
Hi Thomas
Hi Thomas,
On Thursday 17 April 2014 09:53:32 Thomas Pugliese wrote:
On Thu, 17 Apr 2014, Laurent Pinchart wrote:
On Wednesday 16 April 2014 12:29:22 Thomas Pugliese wrote:
[snip]
As you had mentioned previously, it should be possible to support both
formats by ignoring the endpoint
Hi Thomas,
(CC'ing the linux-usb mailing list)
On Tuesday 15 April 2014 16:45:28 Thomas Pugliese wrote:
On Tue, 15 Apr 2014, Laurent Pinchart wrote:
Hi Thomas,
Could you please send me a proper revert patch with the above description
in the commit message and CC Mauro Carvalho Chehab
Override the hub control operation to enable and disable external
regulators for the ports vbus power supply in response to clear/set
USB_PORT_FEAT_POWER requests.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/host/ohci-pxa27x.c | 67
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
arch/arm/mach-pxa/zeus.c | 89 ++--
1 file changed, 48 insertions(+), 41 deletions(-)
diff --git a/arch/arm/mach-pxa/zeus.c b/arch/arm/mach-pxa/zeus.c
index b19d1c3..205f9bf 100644
()
- Call ohci_hub_status_data() directly from ohci-at91 and ohci-s3c2410
Changes compared to v1:
- Export ehci_hub_control()
- Call ehci_hub_control() directly from ehci-tegra
- Call ohci_hub_control() directly from ohci-at91
Laurent Pinchart (4):
USB: OHCI: Export the OHCI hub control
Platform drivers sometimes need to perform specific handling of hub
control requests. Make this possible by exporting the ehci_hub_control()
function which can then be called from a custom hub control handler in
the default case.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Platform drivers sometimes need to perform specific handling of hub
control requests and status data. Make this possible by exporting the
ohci_hub_control() and ohci_hub_status_data() functions which can then
be called from custom hub operations in the default case.
Signed-off-by: Laurent
Hi Alan,
On Wednesday 16 April 2014 11:07:34 Alan Stern wrote:
On Wed, 16 Apr 2014, Laurent Pinchart wrote:
Override the hub control operation to enable and disable external
regulators for the ports vbus power supply in response to clear/set
USB_PORT_FEAT_POWER requests.
Signed-off
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
arch/arm/mach-pxa/zeus.c | 89 ++--
1 file changed, 48 insertions(+), 41 deletions(-)
diff --git a/arch/arm/mach-pxa/zeus.c b/arch/arm/mach-pxa/zeus.c
index b19d1c3..205f9bf 100644
Override the hub control operation to enable and disable external
regulators for the ports vbus power supply in response to clear/set
USB_PORT_FEAT_POWER requests.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Acked-by: Alan Stern st...@rowland.harvard.edu
---
drivers/usb
Platform drivers sometimes need to perform specific handling of hub
control requests and status data. Make this possible by exporting the
ohci_hub_control() and ohci_hub_status_data() functions which can then
be called from custom hub operations in the default case.
Signed-off-by: Laurent
Platform drivers sometimes need to perform specific handling of hub
control requests. Make this possible by exporting the ehci_hub_control()
function which can then be called from a custom hub control handler in
the default case.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
ehci-tegra
- Call ohci_hub_control() directly from ohci-at91
Laurent Pinchart (4):
USB: OHCI: Export the OHCI hub control and status_data functions
USB: EHCI: Export the ehci_hub_control function
USB: ohci-pxa27x: Add support for external vbus regulators
ARM: pxa: zeus: Replace OHCI init/exit
Hi Alan,
Thank you for your comments.
On Monday 14 April 2014 10:35:43 Alan Stern wrote:
On Mon, 14 Apr 2014, Laurent Pinchart wrote:
Hello,
The PXA27x OHCI implementation doesn't perform automatic control of port
power supplies for all ports. While the PPS and LSDA bits
not that I haven't been able to test the third and fourth patches due
to lack of hardware. I've however tested a similar implementation for OHCI on
an out of tree PXA270 board.
Laurent Pinchart (4):
USB: OHCI: Export the ohci_hub_control function
USB: EHCI: Export the ehci_hub_control function
Override the hub control operation to enable and disable external
regulators for the ports vbus power supply in response to clear/set
USB_PORT_FEAT_POWER requests.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/host/ohci-pxa27x.c | 67
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
arch/arm/mach-pxa/zeus.c | 89 ++--
1 file changed, 48 insertions(+), 41 deletions(-)
diff --git a/arch/arm/mach-pxa/zeus.c b/arch/arm/mach-pxa/zeus.c
index b19d1c3..205f9bf 100644
Platform drivers sometimes need to perform specific handling of hub
control requests. Make this possible by exporting the ohci_hub_control()
function which can then be called from a custom hub control handler in
the default case.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Platform drivers sometimes need to perform specific handling of hub
control requests. Make this possible by exporting the ehci_hub_control()
function which can then be called from a custom hub control handler in
the default case.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Hi Alan,
On Tuesday 15 April 2014 14:01:54 Alan Stern wrote:
On Tue, 15 Apr 2014, Laurent Pinchart wrote:
Platform drivers sometimes need to perform specific handling of hub
control requests. Make this possible by exporting the ohci_hub_control()
function which can then be called from
Hi Alan,
On Tuesday 15 April 2014 14:05:14 Alan Stern wrote:
On Tue, 15 Apr 2014, Laurent Pinchart wrote:
I'm open to the idea of exporting the hub functions. In the end, it
doesn't make all that much difference (it would save a little object
code).
I would have agreed to keep
The ret variable is not initialized in all code paths of the
ohci_jz4740_hub_control function. Fix it.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/host/ohci-jz4740.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ohci
Power control of hub ports target the CLEAR_FEATURE and SET_FEATURE
requests to ports, not to the hub. Fix the hub control function to
detect the request correctly.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/host/ohci-jz4740.c | 4 ++--
1 file changed, 2
Hello,
I've noticed two issues with teh ohci-jz4740 driver while reading the source
code. Here are two patches to fix them. Both are untested as I don't have
access to the hardware.
Laurent Pinchart (2):
USB: ohci-jz4740: Fix uninitialized variable warning
USB: ohci-jz4740: FEAT_POWER
Platform drivers sometimes need to perform specific handling of hub
control requests. Make this possible by exporting the ohci_hub_control()
function which can then be called from a custom hub control handler in
the default case.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
:-)) will be appreciated.
Please not that I haven't been able to test the third patch due to lack of
hardware. I've however tested a similar implementation on an out of tree
PXA270 board.
Laurent Pinchart (3):
USB: OHCI: Export the ohci_hub_control function
USB: ohci-pxa27x: Add support for external vbus
Override the hub control operation to enable and disable external
regulators for the ports vbus power supply in response to clear/set
USB_PORT_FEAT_POWER requests.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/host/ohci-pxa27x.c | 67
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
arch/arm/mach-pxa/zeus.c | 89 ++--
1 file changed, 48 insertions(+), 41 deletions(-)
diff --git a/arch/arm/mach-pxa/zeus.c b/arch/arm/mach-pxa/zeus.c
index b19d1c3..205f9bf 100644
Hi Hans,
On Friday 28 March 2014 09:50:42 Hans Verkuil wrote:
On 03/23/2014 04:32 PM, Laurent Pinchart wrote:
The wall time clock isn't useful for applications as it can jump around
due to time adjustement. Switch to the monotonic clock.
Signed-off-by: Laurent Pinchart laurent.pinch
301 - 400 of 552 matches
Mail list logo
