Re: [PATCH] usb: dwc3: of-simple: use managed and shared reset control

2018-04-04 Thread Philipp Zabel
On Wed, 2018-04-04 at 10:25 +0900, Masahiro Yamada wrote: > 2018-04-03 19:35 GMT+09:00 Vivek Gautam <vivek.gau...@codeaurora.org>: > > > > > > On 4/3/2018 3:49 PM, Masahiro Yamada wrote: > > > > > > 2018-04-03 17:46 GMT+09:00 Philipp Zabel <p.za..

Re: [PATCH] usb: dwc3: of-simple: use managed and shared reset control

2018-04-03 Thread Philipp Zabel
On Tue, 2018-04-03 at 17:30 +0900, Masahiro Yamada wrote: > 2018-04-03 17:00 GMT+09:00 Philipp Zabel <p.za...@pengutronix.de>: > > On Thu, 2018-03-29 at 15:07 +0900, Masahiro Yamada wrote: > > > This driver handles the reset control in a common manner; deassert > > &g

Re: [PATCH] usb: dwc3: of-simple: use managed and shared reset control

2018-04-03 Thread Philipp Zabel
e horizon that shares these reset lines with other peripherals? > Also, use devm_ for clean-up. > > Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> > --- > > CCing Philipp Zabel. > I see his sob in commit 06c47e6286d5. At the time I was concerned with the res

Re: Not enough bandwidth with Magewell XI100DUSB-HDMI

2018-01-19 Thread Philipp Zabel
Hi, On Fri, Jan 19, 2018 at 2:10 PM, Michael Tretter wrote: > I found the old thread and it sounds exactly like my issue. Different > camera, but same xHCI controller. I have exactly the same issue with the xHCI controller of my laptop and "Oculus Sensor" USB3

Re: [PATCH v7 1/4] reset: Add APIs to manage array of resets

2017-11-02 Thread Philipp Zabel
Hi Bjorn, On Wed, 2017-11-01 at 15:24 -0700, Bjorn Andersson wrote: [...] > > > This looks more or less identical to how regulators and clocks already > > > deals with resources in bulk; see regulator_bulk_data and clk_bulk_data > > > and their associated functions. > > > > > > I would really

Re: [PATCH v7 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers

2017-10-23 Thread Philipp Zabel
On Fri, Oct 20, 2017 at 04:51:24PM +0100, Jon Hunter wrote: > Hi Philipp, > > On 19/10/17 16:17, Philipp Zabel wrote: > > Hi Jon, Thierry, > > > > On Wed, 2017-07-19 at 17:59 +0200, Philipp Zabel wrote: > >> From: Vivek Gautam <vivek.ga

Re: [PATCH v7 1/4] reset: Add APIs to manage array of resets

2017-10-20 Thread Philipp Zabel
Hi, On Thu, 2017-10-19 at 11:54 -0700, Bjorn Andersson wrote: > On Wed 19 Jul 08:59 PDT 2017, Philipp Zabel wrote: > > > From: Vivek Gautam <vivek.gau...@codeaurora.org> > > > > Many devices may want to request a bunch of resets and control them. So > > it

Re: [PATCH v8] usb: dwc3: of-simple: Add support to get resets for the device

2017-10-20 Thread Philipp Zabel
On Fri, 2017-10-20 at 17:10 +0530, Manu Gautam wrote: > Hi, > > > On 10/19/2017 5:17 PM, Philipp Zabel wrote: > > From: Vivek Gautam <vivek.gau...@codeaurora.org> > > > > Add support to get a list of resets available for the device. > > These resets

Re: [PATCH v7 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers

2017-10-19 Thread Philipp Zabel
Hi Jon, Thierry, On Wed, 2017-07-19 at 17:59 +0200, Philipp Zabel wrote: > From: Vivek Gautam <vivek.gau...@codeaurora.org> > > Make use of of_reset_control_array_get_exclusive() to manage > an array of reset controllers available with the device. > > Cc: Jon Hunter <

Re: [PATCH v7 3/4] usb: dwc3: of-simple: Add support to get resets for the device

2017-10-19 Thread Philipp Zabel
On Thu, 2017-10-19 at 14:31 +0300, Felipe Balbi wrote: > Hi, > > Philipp Zabel <p.za...@pengutronix.de> writes: > > Hi Felipe, > > > > On Thu, 2017-10-19 at 12:38 +0300, Felipe Balbi wrote: > > > Philipp Zabel <p.za...@pengutronix.de> writ

[PATCH v8] usb: dwc3: of-simple: Add support to get resets for the device

2017-10-19 Thread Philipp Zabel
ontrol array] Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- v7: Rebased onto git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next --- drivers/usb/dwc3/dwc3-of-simple.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff -

Re: [PATCH v7 3/4] usb: dwc3: of-simple: Add support to get resets for the device

2017-10-19 Thread Philipp Zabel
Hi Felipe, On Thu, 2017-10-19 at 12:38 +0300, Felipe Balbi wrote: > Philipp Zabel <p.za...@pengutronix.de> writes: > > > From: Vivek Gautam <vivek.gau...@codeaurora.org> > > > > Add support to get a list of resets available for the device. > > T

[PATCH v7 0/4] reset: APIs to manage a list of resets

2017-07-19 Thread Philipp Zabel
A set of patches to allow consumers to get and de/assert or trigger a number of resets at the same time. A patch on top of Vivek's original API extension is added to hide the reset_control_array behind a struct reset_control so that the consumer doesn't have to care about the difference between a

[PATCH v7 3/4] usb: dwc3: of-simple: Add support to get resets for the device

2017-07-19 Thread Philipp Zabel
...@pengutronix.de: switch to hidden reset control array] Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- No changes since v6. --- drivers/usb/dwc3/dwc3-of-simple.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/dwc

[PATCH v7 2/4] usb: dwc3: of-simple: Re-order resource handling in remove

2017-07-19 Thread Philipp Zabel
From: Vivek Gautam Move clock handling after of_platform_depopulate to achieve a sequence that is reverse of the probe sequence. Cc: Felipe Balbi Signed-off-by: Vivek Gautam --- No changes since v6. ---

[PATCH v7 1/4] reset: Add APIs to manage array of resets

2017-07-19 Thread Philipp Zabel
order. Cc: Felipe Balbi <ba...@kernel.org> Cc: Jon Hunter <jonath...@nvidia.com> Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> [p.za...@pengutronix.de: changed API to hide reset control arrays behind struct reset_control] Signed-off-by: Philipp Zabel <p.za...@pengut

[PATCH v7 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers

2017-07-19 Thread Philipp Zabel
Gautam <vivek.gau...@codeaurora.org> [p.za...@pengutronix.de: switch to hidden reset control array] Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- No changes since v6. --- drivers/soc/tegra/pmc.c | 82 - 1 file changed, 20 insertions(+

[PATCH 086/102] usb: chipidea: msm: explicitly request exclusive reset control

2017-07-19 Thread Philipp Zabel
e explicit API call so the temporary transition helpers can be removed. No functional changes. Cc: Peter Chen <peter.c...@nxp.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- driver

[PATCH 092/102] usb: phy: qcom-8x16-usb: explicitly request exclusive reset control

2017-07-19 Thread Philipp Zabel
e explicit API call so the temporary transition helpers can be removed. No functional changes. Cc: Felipe Balbi <ba...@kernel.org> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- drivers

[PATCH 087/102] usb: dwc2: explicitly request exclusive reset control

2017-07-19 Thread Philipp Zabel
e explicit API call so the temporary transition helpers can be removed. No functional changes. Cc: John Youn <johny...@synopsys.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- dri

[PATCH 089/102] usb: host: xhci-tegra: explicitly request exclusive reset control

2017-07-19 Thread Philipp Zabel
> Cc: linux-usb@vger.kernel.org Cc: linux-te...@vger.kernel.org Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- drivers/usb/host/xhci-tegra.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c i

[PATCH 088/102] usb: host: ehci-tegra: explicitly request exclusive reset control

2017-07-19 Thread Philipp Zabel
> Cc: linux-usb@vger.kernel.org Cc: linux-te...@vger.kernel.org Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- drivers/usb/host/ehci-tegra.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c i

[PATCH 091/102] usb: phy: msm: explicitly request exclusive reset control

2017-07-19 Thread Philipp Zabel
e explicit API call so the temporary transition helpers can be removed. No functional changes. Cc: Felipe Balbi <ba...@kernel.org> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- drive

[PATCH 090/102] usb: musb: sunxi: explicitly request exclusive reset control

2017-07-19 Thread Philipp Zabel
nux-usb@vger.kernel.org Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- drivers/usb/musb/sunxi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c index c9a09b5bb6e59..7eec1acbc729a 100644 --- a/drivers/usb/musb/sunxi.c

Re: [PATCH v6 1/4] reset: Add APIs to manage array of resets

2017-06-20 Thread Philipp Zabel
a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Philipp-Zabel/reset-Add-APIs-to-manage-array-of-resets/20170620-021320 > base: git://git.pengutronix.de/git/pza/linux reset/next > config: i386-randconfig-c0-06200218 (attached as .config)

[PATCH v6 0/4] reset: APIs to manage a list of resets

2017-06-19 Thread Philipp Zabel
A set of patches to allow consumers to get and de/assert or trigger a number of resets at the same time. A patch on top of Vivek's original API extension is added to hide the reset_control_array behind a struct reset_control so that the consumer doesn't have to care about the difference between a

[PATCH v6 1/4] reset: Add APIs to manage array of resets

2017-06-19 Thread Philipp Zabel
order. Cc: Felipe Balbi <ba...@kernel.org> Cc: Jon Hunter <jonath...@nvidia.com> Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> [p.za...@pengutronix.de: changed API to hide reset control arrays behind struct reset_control] Signed-off-by: Philipp Zabel <p.za...@pengut

[PATCH v6 3/4] usb: dwc3: of-simple: Add support to get resets for the device

2017-06-19 Thread Philipp Zabel
...@pengutronix.de: switch to hidden reset control array] Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- No changes since v5. --- drivers/usb/dwc3/dwc3-of-simple.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/dwc

[PATCH v6 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers

2017-06-19 Thread Philipp Zabel
Gautam <vivek.gau...@codeaurora.org> [p.za...@pengutronix.de: switch to hidden reset control array] Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- Changes since v5: updated commit message, added missing SoB --- drivers/soc/tegra/pmc.c | 82 ---

[PATCH v6 2/4] usb: dwc3: of-simple: Re-order resource handling in remove

2017-06-19 Thread Philipp Zabel
From: Vivek Gautam Move clock handling after of_platform_depopulate to achieve a sequence that is reverse of the probe sequence. Cc: Felipe Balbi Signed-off-by: Vivek Gautam --- No changes since v5. ---

Re: [PATCH v5 6/6] soc/tegra: pmc: Use the new reset APIs to manage reset controllers

2017-06-19 Thread Philipp Zabel
On Thu, 2017-06-01 at 18:52 +0200, Philipp Zabel wrote: > From: Vivek Gautam <vivek.gau...@codeaurora.org> > > Make use of reset_control_array_*() set of APIs to manage > an array of reset controllers available with the device. > > Cc: Jon Hunter <jonath...@nvidia.com&

Re: [PATCH v5 3/6] reset: hide reset control arrays behind struct reset_control

2017-06-19 Thread Philipp Zabel
Hi Vivek, On Tue, 2017-06-13 at 12:16 +0530, Vivek Gautam wrote: [...] > > @@ -102,18 +94,6 @@ static inline struct reset_control > > *__devm_reset_control_get( > > return optional ? NULL : ERR_PTR(-ENOTSUPP); > > } > > > > -static inline > > -int reset_control_array_assert(struct

Re: [PATCH 2/2] HID: usbhid: Add HID_QUIRK_NO_INIT_REPORTS for Oculus Rift CV1

2017-06-08 Thread Philipp Zabel
Hi Benjamin, On Wed, Jun 7, 2017 at 9:11 AM, Benjamin Tissoires <benjamin.tissoi...@redhat.com> wrote: > Hi Philip, > > On Jun 07 2017 or thereabouts, Philipp Zabel wrote: [...] > 2 things: > - the 2 patches should be squashed together. There is no point having a >

[PATCH 2/2] HID: usbhid: Add HID_QUIRK_NO_INIT_REPORTS for Oculus Rift CV1

2017-06-06 Thread Philipp Zabel
ift] on usb-:00:14.0-3.1/input1 usbcore: registered new interface driver usbhid usbhid: USB HID core driver These timeouts disappear when setting HID_QUIRK_NO_INIT_REPORTS. The hidraw devices appear quickly and are functional. Signed-off-by: Philipp Zabel <philipp.za...@gma

[PATCH 1/2] HID: Add Oculus Rift CV1 id

2017-06-06 Thread Philipp Zabel
Add VID/PID for Oculus Rift CV1. Signed-off-by: Philipp Zabel <philipp.za...@gmail.com> --- drivers/hid/hid-ids.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 8ca1e8ce0af2..2953d53a8cc9 100644 --- a/drivers/hid/hid-ids.h +++ b/d

[PATCH v5 4/6] usb: dwc3: of-simple: Re-order resource handling in remove

2017-06-01 Thread Philipp Zabel
From: Vivek Gautam Move clock handling after of_platform_depopulate to achieve a sequence that is reverse of the probe sequence. Cc: Felipe Balbi Signed-off-by: Vivek Gautam --- drivers/usb/dwc3/dwc3-of-simple.c | 4

[PATCH v5 2/6] reset: Add APIs to manage array of resets

2017-06-01 Thread Philipp Zabel
lines managed in the array are handled in any particular order. Cc: Felipe Balbi <ba...@kernel.org> Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Acked-by: Jon Hunter <jonath...@nvidia.com> Tested-by: Jon Hunter <jonath...@nvidia.com> Signed-off-by: Philipp

[PATCH v5 6/6] soc/tegra: pmc: Use the new reset APIs to manage reset controllers

2017-06-01 Thread Philipp Zabel
From: Vivek Gautam <vivek.gau...@codeaurora.org> Make use of reset_control_array_*() set of APIs to manage an array of reset controllers available with the device. Cc: Jon Hunter <jonath...@nvidia.com> Cc: Thierry Reding <tred...@nvidia.com> Cc: Philipp Zabel <p.za...@pengu

[PATCH v5 5/6] usb: dwc3: of-simple: Add support to get resets for the device

2017-06-01 Thread Philipp Zabel
...@pengutronix.de: switch to hidden reset control array] Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- drivers/usb/dwc3/dwc3-of-simple.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/u

[PATCH v5 3/6] reset: hide reset control arrays behind struct reset_control

2017-06-01 Thread Philipp Zabel
functions for array (de)assert/reset. Cc: Vivek Gautam <vivek.gau...@codeaurora.org> Cc: Jon Hunter <jonath...@nvidia.com> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- drivers/reset/core.c | 225 ++ include/linux/reset.h |

[PATCH v5 1/6] reset: use kref for reference counting

2017-06-01 Thread Philipp Zabel
Use kref for reference counting and enjoy the advantages of refcount_t. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- drivers/reset/core.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/reset/core.c b/drivers/reset/core.c

[PATCH v5 0/6] reset: APIs to manage a list of resets

2017-06-01 Thread Philipp Zabel
ing in of_reset_control_get_count() - Added patch to manage reset controller array. - Rebased dwc3-of-simple changes based on the new set of APIs for reset control array. - Added a patch for soc/tegra/pmc driver to use the new set of reset control array APIs. Philipp Zabel (2): reset: use k

Re: [PATCH v4 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers

2017-06-01 Thread Philipp Zabel
> > > Cc: Thierry Reding <tred...@nvidia.com> > > Cc: Philipp Zabel <p.za...@pengutronix.de> > > Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> > > --- > > drivers/soc/tegra/pmc.c | 91 > > +

Re: [PATCH V3 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers

2017-04-25 Thread Philipp Zabel
On Tue, 2017-04-25 at 11:05 +0100, Jon Hunter wrote: > On 25/04/17 05:15, Vivek Gautam wrote: > > On 04/24/2017 06:15 PM, Jon Hunter wrote: > >> On 18/04/17 12:21, Vivek Gautam wrote: > >>> Make use of reset_control_array_*() set of APIs to manage > >>> an array of reset controllers available with

Re: [PATCH V3 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers

2017-04-19 Thread Philipp Zabel
On Tue, 2017-04-18 at 16:51 +0530, Vivek Gautam wrote: > Make use of reset_control_array_*() set of APIs to manage > an array of reset controllers available with the device. > > Cc: Thierry Reding <tred...@nvidia.com> > Cc: Philipp Zabel <p.za...@pengutronix.de> &g

Re: [PATCH V3 3/4] usb: dwc3: of-simple: Add support to get resets for the device

2017-04-19 Thread Philipp Zabel
On Tue, 2017-04-18 at 16:51 +0530, Vivek Gautam wrote: > Add support to get a list of resets available for the device. > These resets must be kept de-asserted until the device is > in use. > > Cc: Felipe Balbi <ba...@kernel.org> > Cc: Philipp Zabel <p.za...@pengutronix

Re: [PATCH V3 2/4] reset: Add APIs to manage array of resets

2017-04-19 Thread Philipp Zabel
small issue below. > Cc: Philipp Zabel <p.za...@pengutronix.de> > Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> > --- > drivers/reset/core.c | 177 > ++ > include/linux/reset.h | 93 +++

Re: [PATCH V3 1/4] reset: Add API to count number of reset available with device

2017-04-19 Thread Philipp Zabel
On Tue, 2017-04-18 at 16:51 +0530, Vivek Gautam wrote: > Count number of reset phandles available with the device node > to know the resets a given device has. > > Cc: Philipp Zabel <p.za...@pengutronix.de> > Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> &g

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-04 Thread Philipp Zabel
Hi Vivek, On Tue, 2017-04-04 at 16:09 +0530, Vivek Gautam wrote: [...] > > I'd prefer to mirror the gpiod API a little, and to have the number > > contained in the array structure, similar to struct gpio_descs: [...] > Alright, i can update this. > I took regulator_bulk interface as the

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-03 Thread Philipp Zabel
ets > and control them. So it's better to manage them as an > array. Add APIs to _get(), _assert(), and _deassert() > an array of reset_control. > > Cc: Philipp Zabel <p.za...@pengutronix.de> > Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> > --- > &

Re: [PATCH v2 13/14] usb: host: ehci-st: simplify optional reset handling

2017-03-15 Thread Philipp Zabel
Hi Alan, On Wed, 2017-03-15 at 10:35 -0400, Alan Stern wrote: > On Wed, 15 Mar 2017, Philipp Zabel wrote: > > > As of commit bb475230b8e5 ("reset: make optional functions really > > optional"), the reset framework API calls use NULL pointers to describe > > op

[PATCH v2 12/14] usb: dwc2: simplify optional reset handling

2017-03-15 Thread Philipp Zabel
ditionally. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Acked-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/platform.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform

[PATCH v2 13/14] usb: host: ehci-st: simplify optional reset handling

2017-03-15 Thread Philipp Zabel
As of commit bb475230b8e5 ("reset: make optional functions really optional"), the reset framework API calls use NULL pointers to describe optional, non-present reset controls. This allows to return errors from devm_reset_control_get_optional_shared unconditionally. Signed-off-by: Phi

Re: [PATCH 2/2] usb; dwc3: of-simple: Add support to get resets for the device

2017-03-15 Thread Philipp Zabel
On Wed, 2017-02-22 at 10:54 +0530, Vivek Gautam wrote: > Add support to get a list of resets available for the device. > These resets must be kept de-asserted until the device is > in use. > > Cc: Felipe Balbi > Signed-off-by: Vivek Gautam > --- >

Re: [PATCH 1/2] reset: Add API to count number of reset available with device

2017-03-15 Thread Philipp Zabel
ts a given device has. > > > > Cc: Philipp Zabel <p.za...@pengutronix.de> > > Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> > > --- > > Any thoughts on this change? > A small addition that seems useful. Sorry I missed this one earlier.

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-15 Thread Philipp Zabel
Hi Martin, Am Mittwoch, den 14.09.2016, 23:23 +0200 schrieb Martin Blumenstingl: [...] > > We could add a triggered flag or a counter to struct reset_control, and > > have reset_control_reset_once do nothing if it is already set / > > incremented. Since the reset_control goes away with the last

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-14 Thread Philipp Zabel
Am Dienstag, den 13.09.2016, 20:38 +0200 schrieb Martin Blumenstingl: > Hi Philipp, > > On Tue, Sep 13, 2016 at 5:28 PM, Philipp Zabel <p.za...@pengutronix.de> wrote: > > Hi Martin, > > > > Am Freitag, den 09.09.2016, 22:36 +0200 schrieb Martin Blumenstingl: &g

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-14 Thread Philipp Zabel
Am Dienstag, den 13.09.2016, 17:59 -0700 schrieb Kevin Hilman: > Martin Blumenstingl <martin.blumensti...@googlemail.com> writes: > > > On Tue, Sep 13, 2016 at 5:28 PM, Philipp Zabel <p.za...@pengutronix.de> > > wrote: > > [...] > > >>> I add

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-14 Thread Philipp Zabel
Am Dienstag, den 13.09.2016, 17:59 -0700 schrieb Kevin Hilman: > Martin Blumenstingl <martin.blumensti...@googlemail.com> writes: > > > On Tue, Sep 13, 2016 at 5:28 PM, Philipp Zabel <p.za...@pengutronix.de> > > wrote: > > [...] > > >>> I add

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-13 Thread Philipp Zabel
Hi Martin, Am Freitag, den 09.09.2016, 22:36 +0200 schrieb Martin Blumenstingl: > On Fri, Sep 9, 2016 at 5:33 PM, Kevin Hilman wrote: > > Martin Blumenstingl writes: > > > >> On Thu, Sep 8, 2016 at 10:53 PM, Ben Dooks

Re: [PATCH v2 1/6] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

2016-07-13 Thread Philipp Zabel
> +- power-sequence: this device needs to do power sequence before enumeration As Joshua pointed out, is this even needed at all? > +Optional properties: > +- clocks: the input clock for device. > +- reset-gpios: Should specify the GPIO for reset. > +- reset-duration-us: the duration

Re: [PATCH 1/6] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

2016-07-07 Thread Philipp Zabel
Am Donnerstag, den 07.07.2016, 17:14 +0800 schrieb Peter Chen: > Add binding doc for generic power sequence library. > > Signed-off-by: Peter Chen > --- > .../bindings/power/pwrseq/pwrseq-generic.txt | 56 > ++ > 1 file changed, 56 insertions(+) >

Re: [PATCH 4/7] reset: Supply *_shared variant calls when using *_optional APIs

2016-06-29 Thread Philipp Zabel
Hi Lee, On Wed, Jun 29, 2016 at 10:37:34AM +0100, Lee Jones wrote: [...] > > > > If that is not the case, go ahead. Otherwise I could provide > > > > a tag at commit 2485394d9e0b ("reset: TRIVIAL: Add line break at same > > > > place for similar APIs") for you to merge. > > > > > > Yes please.

Re: [PATCH 4/7] reset: Supply *_shared variant calls when using *_optional APIs

2016-06-29 Thread Philipp Zabel
Am Mittwoch, den 29.06.2016, 09:06 +0100 schrieb Lee Jones: > On Wed, 29 Jun 2016, Philipp Zabel wrote: > > Am Dienstag, den 28.06.2016, 09:56 +0100 schrieb Lee Jones: > > > Philipp, > > > > > > I need this to go into the -rcs too. > > > > > &

Re: [PATCH 4/7] reset: Supply *_shared variant calls when using *_optional APIs

2016-06-29 Thread Philipp Zabel
Hi Lee, Am Dienstag, den 28.06.2016, 09:56 +0100 schrieb Lee Jones: > Philipp, > > I need this to go into the -rcs too. > > Can I add it with your Ack please? I have already added your patches to my branch, and I intend to send a pull request for it tomorrow. I am afraid applying this patch in

Re: [PATCH 1/7] reset: Reorder inline reset_control_get*() wrappers

2016-06-20 Thread Philipp Zabel
Am Montag, den 06.06.2016, 16:56 +0100 schrieb Lee Jones: > We're about to split the current API into two, where consumers will > be forced to be explicit when requesting reset lines. The choice > will be to either the call the *_exclusive or *_shared variant > depending on whether they can

Re: [PATCH 7/7] usb: dwc3: st: Inform the reset framework that our reset line may be shared

2016-06-16 Thread Philipp Zabel
Am Montag, den 06.06.2016, 16:56 +0100 schrieb Lee Jones: > On the STiH410 B2120 development board the MiPHY28lp shares its reset > line with the Synopsys DWC3 SuperSpeed (SS) USB 3.0 Dual-Role-Device > (DRD). New functionality in the reset subsystems forces consumers to > be explicit when

Re: [STLinux Kernel] [PATCH 0/7] reset: Consumers to explicitly request 'exclusive' or 'shared' lines

2016-06-16 Thread Philipp Zabel
Hi Lee, Am Dienstag, den 07.06.2016, 10:24 +0100 schrieb Lee Jones: [...] > I guess it should really go into the -rcs, yes. Since Hans' patch > actually breaks a lot of devices. I'm pretty surprised a patch > capable of this much damage was actually accepted to be honest. I wasn't aware there

Re: [PATCH v2] reset: Return -ENOTSUPP when not configured

2016-06-01 Thread Philipp Zabel
Hi John, Am Dienstag, den 31.05.2016, 16:55 -0700 schrieb John Youn: > Prior to commit 6c96f05c8bb8 ("reset: Make [of_]reset_control_get[_foo] > functions wrappers"), the "optional" functions returned -ENOTSUPP when > CONFIG_RESET_CONTROLLER was not set. > > Revert back to the old behavior by

Re: [PATCH] reset: Put back *_optional variants

2016-05-30 Thread Philipp Zabel
Am Montag, den 30.05.2016, 13:32 +0200 schrieb Hans de Goede: > Hi, > > On 30-05-16 12:18, Philipp Zabel wrote: > > Hi, > > > > Am Freitag, den 27.05.2016, 09:06 +0200 schrieb Hans de Goede: > > [...] > >>>> So IMHO t

Re: [PATCH] reset: Put back *_optional variants

2016-05-30 Thread Philipp Zabel
Hi, Am Freitag, den 27.05.2016, 09:06 +0200 schrieb Hans de Goede: [...] > >> So IMHO the following change would be a better way to fix this: > >> > >> --- a/include/linux/reset.h > >> +++ b/include/linux/reset.h > >> @@ -65,14 +65,14 @@ static inline struct reset_control > >>

Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-04 Thread Philipp Zabel
t. > This used to work fine before the above-mentioned commit, but now > triggers the new WARN. > > Work around this by making sure we reuse the controller's reset if the > controller happens to be the first controller. > > Cc: Philipp Zabel <p.za...@pengutronix.de> > Cc:

Re: [PATCHv6 2/2] usb: dwc2: Add reset control to dwc2

2016-04-25 Thread Philipp Zabel
Hi John, Am Freitag, den 22.04.2016, 20:31 -0700 schrieb John Youn: > On 4/20/2016 2:31 PM, dingu...@opensource.altera.com wrote: > > From: Dinh Nguyen > > > > Allow for platforms that have a reset controller driver in place to bring > > the USB IP out of reset.

Re: [PATCH v5 0/2] ?hci-platform: Add support for controllers with more then one reset line

2016-04-11 Thread Philipp Zabel
not make it into 4.6. Philipp Zabel, the reset maintainer (in the Cc) > has put these patches in a stable branch / tag here: > > git://git.pengutronix.de/git/pza/linux.git tags/reset-for-4.7 > > Can you please merge in this tag and then these 2 patches for 4.7 ? Acked-by: Philipp

Re: [PATCH v5 1/1] USB: core: let USB device know device node

2016-02-19 Thread Philipp Zabel
s connecting to, the range > + is 1-31. > + > +Example: > + > + { > + status = "okay"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + hub: genesys@1 { > + compatible = "usb05e3,0608"; This should be: compatible = "usb5e3,608"; After those two issues are fixed, Acked-by: Philipp Zabel <p.za...@pengutronix.de> best regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 1/1] USB: core: let USB device know device node

2016-02-05 Thread Philipp Zabel
Am Freitag, den 05.02.2016, 14:11 +0800 schrieb Peter Chen: [...] > > The reference recommendation states that for single-configuration USB > > devices the compatible should contain all of the applicable strings from > > the list starting with 2) "usbVID,PID.REV" and ending with 11) > >

Re: [PATCH v4 1/1] USB: core: let USB device know device node

2016-02-04 Thread Philipp Zabel
Hi Peter, Am Montag, den 25.01.2016, 15:24 +0800 schrieb Peter Chen: > Although most of USB devices are hot-plug's, there are still some devices > are hard wired on the board, eg, for HSIC and SSIC interface USB devices. > If these kinds of USB devices are multiple functions, and they can supply

Re: [linux-sunxi] Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

2016-01-04 Thread Philipp Zabel
Am Samstag, den 19.12.2015, 11:55 +0100 schrieb Hans de Goede: > On 18-12-15 12:08, Maxime Ripard wrote: [...] > > I guess we could also have something like this: > > > >* The driver gets the reference to the reset line using > > reset_control_get or its shared variant. > > > > - If

Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

2015-12-16 Thread Philipp Zabel
Hi Maxime, Am Mittwoch, den 16.12.2015, 11:29 +0100 schrieb Maxime Ripard: > On Mon, Dec 14, 2015 at 10:50:55AM +0100, Philipp Zabel wrote: > > Am Montag, den 14.12.2015, 10:36 +0100 schrieb Maxime Ripard: > > > Hi, > > > > > > On Fri, Dec 11, 2015 at 0

Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

2015-12-14 Thread Philipp Zabel
Hi Hans, Am Freitag, den 11.12.2015, 19:21 +0100 schrieb Hans de Goede: [...] > >> @@ -119,13 +134,55 @@ EXPORT_SYMBOL_GPL(reset_control_assert); > >> int reset_control_deassert(struct reset_control *rstc) > >> { > > > > Maybe WARN_ON(rstc->line->refcnt > 1) ? > > I assume you mean

Re: [PATCH v2 2/3] ehci-platform: Add support for controllers with multiple reset lines

2015-12-14 Thread Philipp Zabel
> The 2 controllers are supposed to be 100% independent but on the H3 > Allwinner has done something (not documented) which requires one to > deassert reset on both before you can talk to either one. ... so thank you for the explanation. Acked-by: Philipp Zabel <p.za...@pengutronix.d

Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

2015-12-14 Thread Philipp Zabel
Am Montag, den 14.12.2015, 10:36 +0100 schrieb Maxime Ripard: > Hi, > > On Fri, Dec 11, 2015 at 04:41:58PM +0100, Hans de Goede wrote: > > diff --git a/include/linux/reset.h b/include/linux/reset.h > > index c4c097d..1cca8ce 100644 > > --- a/include/linux/reset.h > > +++ b/include/linux/reset.h >

Re: [PATCH v2 2/3] ehci-platform: Add support for controllers with multiple reset lines

2015-12-11 Thread Philipp Zabel
Am Freitag, den 11.12.2015, 16:41 +0100 schrieb Hans de Goede: > From: Reinder de Haan > > At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple > reset lines, the controller will not initialize while the reset for > its companion is still asserted, which

Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

2015-12-11 Thread Philipp Zabel
Hi Hans, thanks for moving this forward. Am Freitag, den 11.12.2015, 16:41 +0100 schrieb Hans de Goede: > Add reset_control_deassert_shared / reset_control_assert_shared > functions which are intended for use by drivers for hw blocks which > (may) share a reset line with another driver / hw

Re: [PATCH 2/3] doc: dt-binding: generic onboard USB HUB

2015-12-08 Thread Philipp Zabel
Hi Peter, Am Dienstag, den 08.12.2015, 09:37 +0800 schrieb Peter Chen: > Add dt-binding documentation for generic onboard USB HUB. > > Signed-off-by: Peter Chen > --- > .../bindings/usb/generic-onboard-hub.txt | 28 > ++ > 1 file

Re: Udoo support for chipidea

2015-11-20 Thread Philipp Zabel
Am Freitag, den 20.11.2015, 16:05 +0800 schrieb Peter Chen: > On Thu, Nov 19, 2015 at 11:26:50AM -0500, Alan Stern wrote: > > On Thu, 19 Nov 2015, Philipp Zabel wrote: > > > > > On Wed, Oct 21, 2015 at 10:39:00AM +0800, Peter Chen wrote: > > > > On Tue, Oct

Re: [linux-sunxi] Re: [PATCH 2/2] ehci-platform: Add support for controllers with multiple reset lines

2015-11-18 Thread Philipp Zabel
Am Mittwoch, den 18.11.2015, 21:20 +1100 schrieb Julian Calaby: > Hi All, > > On Wed, Nov 18, 2015 at 9:18 PM, Maxime Ripard > <maxime.rip...@free-electrons.com> wrote: > > On Wed, Nov 18, 2015 at 10:46:52AM +0100, Philipp Zabel wrote: > >> Hi Hans, > >

Re: [linux-sunxi] Re: [PATCH 2/2] ehci-platform: Add support for controllers with multiple reset lines

2015-11-18 Thread Philipp Zabel
Hi Julian, Am Mittwoch, den 18.11.2015, 23:32 +1100 schrieb Julian Calaby: [...] > Assuming board designers are sufficiently ... stupid, won't most > drivers eventually need to use the _shared variants? Wouldn't it be > (horrifically more complicated and) better to just build this into the >

Re: [linux-sunxi] Re: [PATCH 2/2] ehci-platform: Add support for controllers with multiple reset lines

2015-11-18 Thread Philipp Zabel
Hi Hans, Am Mittwoch, den 18.11.2015, 11:38 +0100 schrieb Hans de Goede: > Hi, > > On 18-11-15 10:46, Philipp Zabel wrote: > > Hi Hans, > > > > Am Montag, den 16.11.2015, 18:13 +0100 schrieb Hans de Goede: > >> On 16-11-15 18:01, Philipp Zabel wrote: &g

Re: [linux-sunxi] Re: [PATCH 2/2] ehci-platform: Add support for controllers with multiple reset lines

2015-11-18 Thread Philipp Zabel
Hi Hans, Am Montag, den 16.11.2015, 18:13 +0100 schrieb Hans de Goede: > On 16-11-15 18:01, Philipp Zabel wrote: > > If there are two devices sharing the same reset line that is initially > > held asserted, do the two drivers somehow have to synchronize before > > releasi

Re: Udoo support for chipidea

2015-11-18 Thread Philipp Zabel
On Wed, Oct 21, 2015 at 10:39:00AM +0800, Peter Chen wrote: > On Tue, Oct 20, 2015 at 02:09:38PM -0200, Fabio Estevam wrote: > > Hi Peter, > > > > On Mon, Oct 19, 2015 at 12:50 AM, Peter Chen > > wrote: > > > > > Add linux-usb. > > > > > > Patryk, your problem is you

Re: [linux-sunxi] Re: [PATCH 2/2] ehci-platform: Add support for controllers with multiple reset lines

2015-11-16 Thread Philipp Zabel
Am Montag, den 16.11.2015, 17:49 +0100 schrieb Hans de Goede: > Hi, > > On 16-11-15 17:04, Chen-Yu Tsai wrote: > > On Mon, Nov 16, 2015 at 11:42 PM, Alan Stern > > wrote: > >> On Sun, 15 Nov 2015, Hans de Goede wrote: > >> > >>> From: Reinder de Haan

Re: [PATCH 1/2] reset: Add of_reset_control_get_by_index

2015-11-16 Thread Philipp Zabel
Hi Hans, Am Sonntag, den 15.11.2015, 20:44 +0100 schrieb Hans de Goede: > From: Reinder de Haan > > In some cases it is useful to be able to get a reset-controller by > index rather then by name. E.g. for a generic ip-block driver such > as the ehci-platform drivers which

Re: [PATCH 2/3] usb: chipidea: usbmisc_imx: delete clock information

2014-12-12 Thread Philipp Zabel
instead. regards Philipp Philipp Zabel also verifies it at imx6q platform, see http://www.spinics.net/lists/linux-usb/msg118491.html Cc: Philipp Zabel p.za...@pengutronix.de Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/usbmisc_imx.c | 19 --- 1

Re: [PATCH 1/2] usb: chipidea: usbmisc: skip clocks on i.MX6

2014-12-10 Thread Philipp Zabel
Hi Peter, Am Mittwoch, den 10.12.2014, 13:09 +0800 schrieb Peter Chen: On Tue, Dec 09, 2014 at 05:13:35PM +0100, Philipp Zabel wrote: On i.MX6Q, the USBMISC registers are clocked by the IPG clock, so there is no need to enable USBOH3 for the USBMISC driver. Access the registers at usbmisc

[PATCH 1/2] usb: chipidea: usbmisc: skip clocks on i.MX6

2014-12-09 Thread Philipp Zabel
On i.MX6Q, the USBMISC registers are clocked by the IPG clock, so there is no need to enable USBOH3 for the USBMISC driver. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/usb/chipidea/usbmisc_imx.c | 32 ++-- 1 file changed, 18 insertions(+), 14

[PATCH 2/2] ARM: dts: imx6qdl: remove USBOH3 clock from usbmisc, it is clocked by IPG

2014-12-09 Thread Philipp Zabel
On i.MX6Q, the USBMISC registers are clocked by the IPG clock, so there is no need to enable USBOH3 for the USBMISC driver. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- arch/arm/boot/dts/imx6qdl.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b

Re: [PATCH v1] usb: phy: generic: add vbus support

2014-11-21 Thread Philipp Zabel
On Fri, Nov 21, 2014 at 6:24 PM, Robert Jarzmik robert.jarz...@free.fr wrote: Felipe Balbi ba...@ti.com writes: On Sun, Nov 09, 2014 at 03:58:14PM +0100, Robert Jarzmik wrote: +if (!enabled) { +ret = regulator_enable(vbus_draw); +if (ret

Re: [PATCH v1 2/3] usb: phy: convert gpio-vbus to gpio_desc

2014-11-04 Thread Philipp Zabel
On Sun, Nov 2, 2014 at 7:11 PM, Robert Jarzmik robert.jarz...@free.fr wrote: In order to prepare device-tree conversion, port gpio_vbus to use gpio_desc. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr Acked-by: Philipp Zabel philipp.za...@gmail.com regards Philipp -- To unsubscribe

Re: [PATCH v1 1/3] usb: phy: device-tree documentation for gpio-vbus

2014-11-04 Thread Philipp Zabel
Hi Robert, On Sun, Nov 2, 2014 at 7:11 PM, Robert Jarzmik robert.jarz...@free.fr wrote: Add documentation for device-tree binding of the generic gpio-vbus phy controller. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr Cc: devicet...@vger.kernel.org ---

  1   2   >