Re: [PATCH 2/2] USB: gadget: pxa25x: Add DT probing

2019-02-06 Thread Robert Jarzmik
Linus Walleij writes: > This makes it possible to instantiate the PXA25x UDC > driver from the device tree. > > Cc: Robert Jarzmik > Signed-off-by: Linus Walleij > --- > drivers/usb/gadget/udc/pxa25x_udc.c | 11 +++ > 1 file changed, 11 insertions(+) Mmmh

I have you not received the first message I sent you this morning. We need to talk about something and I'm sure you would like to hear this information.

2018-08-01 Thread Robert Wilson

Re: [PATCH 20/22] USB: gadget: udc: pxa27x_udc: no need to check return value of debugfs_create functions

2018-05-29 Thread Robert Jarzmik
all, so remove > those variables from the device structure. > > Cc: Daniel Mack > Cc: Haojian Zhuang > Cc: Robert Jarzmik > Cc: Felipe Balbi > Signed-off-by: Greg Kroah-Hartman Acked-by: Robert Jarzmik Cheers. -- Robert -- To unsubscribe from this list: send the line &quo

Re: [PATCH v1 07/14] USB: gadget: pxa27x: Re-use DEFINE_SHOW_ATTRIBUTE() macro

2018-02-17 Thread Robert Jarzmik
Andy Shevchenko writes: > ...instead of open coding file operations followed by custom ->open() > callbacks per each attribute. > > Cc: Daniel Mack > Cc: Haojian Zhuang > Cc: Robert Jarzmik > Signed-off-by: Andy Shevchenko Acked-by: Robert Jarzmik Cheers. -- Rober

Re: [PATCH v1 06/14] USB: gadget: pxa25x: Re-use DEFINE_SHOW_ATTRIBUTE() macro

2018-02-17 Thread Robert Jarzmik
Andy Shevchenko writes: > ...instead of open coding file operations followed by custom ->open() > callbacks per each attribute. > > Cc: Daniel Mack > Cc: Haojian Zhuang > Cc: Robert Jarzmik > Signed-off-by: Andy Shevchenko Acked-by: Robert Jarzmik Cheers. -- Rober

RE: UAC2 gadget not recognized on Windows 10

2018-02-13 Thread Robert Bielik
for the SOF timestamps, whereas for my proposal they would be needed. And what kind of CPU overhead are we talking about ? The IRQs shouldn't come more often than every 125 us, and all that is needed is to take a timestamp value 😊 But I'm probably overlooking a lot of stuff... Regards /Robert

RE: UAC2 gadget not recognized on Windows 10

2018-02-13 Thread Robert Bielik
amps to be able to calculate the feedback value. Regards /Robert -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: UAC2 gadget not recognized on Windows 10

2018-02-13 Thread Robert Bielik
> I guess UAC1 doesn't need feedback endpoints, right? Seems like that > should be something specific to UAC2. At least for now. It seems like it is needed there aswell, see http://www.usb.org/developers/docs/devclass_docs/audio10.pdf (3.7.2.2) (Feedback endpoint == Synch Endpoint) Regards /R

RE: UAC2 gadget not recognized on Windows 10

2018-02-13 Thread Robert Bielik
struct should be extended with a feedback_ep ? Learning as I go along... Regards /Robert

RE: UAC2 gadget not recognized on Windows 10

2018-02-12 Thread Robert Bielik
change. Device is still not recognized, and having the same error code. So, a real feedback IN endpoint is needed ☹ Regards /Robert

RE: UAC2 gadget not recognized on Windows 10

2018-02-12 Thread Robert Bielik
data is enough? Thanks Felipe, I have all setup so I can try this. Regards /Robert -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: UAC2 gadget not recognized on Windows 10

2018-02-12 Thread Robert Bielik
eedback IN ep, to be able to report to the host the rate so no under- or overrun condition occurs. Regards /Robert N�r��yb�X��ǧv�^�)Þº{.n�+{��^n�r���z���h�&���G���h�(�階�ݢj"���m��z�ޖ���f���h���~�m�

UAC2 audio gadget queries

2018-02-12 Thread Robert Bielik
eeds. Please let me know if I'm missing something. All the best, /Robert -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: UAC2 gadget not recognized on Windows 10

2018-02-10 Thread Robert Bielik
> > > > 4.9 is over a year old, can you try 4.14, or even better yet, 4.15? Just to confirm, I've tried with 4.14.18 (latest from https://github.com/raspberrypi/firmware), and the problem remains. Regards /R N�r��yb�X��ǧv�^�)Þº{.n�+{��^n�r���z���h�&���G���h�(�階�ݢj"���m��

RE: UAC2 gadget not recognized on Windows 10

2018-02-10 Thread Robert Bielik
> "Wait, never mind – I recognize that failing status code. usbaudio2.sys is > complaining that you have an asynchronous data OUT endpoint but it can’t > find a corresponding feedback endpoint." > > Unfortunately I have no idea what that means. Yet 😊 , but putting it out there > in case someone el

RE: UAC2 gadget not recognized on Windows 10

2018-02-10 Thread Robert Bielik
complaining that you have an asynchronous data OUT endpoint but it can’t find a corresponding feedback endpoint." Unfortunately I have no idea what that means. Yet 😊 , but putting it out there in case someone else does. Regards /Robert N�r��yb�X��ǧv�^�)޺{.n�+{��^n�r�

RE: UAC2 gadget not recognized on Windows 10

2018-02-09 Thread Robert Bielik
ROB_FAILED_START), problem status: 0xc0440025. Using the TDD tool (http://www.thesycon.de/eng/usb_descriptordumper.shtml) I can see that the patch fixed the problem with wTotalLength, and now I can't see anything that looks suspicious. Regards /Robert

UAC2 gadget not recognized on Windows 10

2018-02-09 Thread Robert Bielik
ign ln -s configs/c.1 os_desc #udevadm settle -t 5 || : ls /sys/class/udc/ > UDC - Best regards /Robert Bielik Ps. Apologies if this isn't the correct forum for these kinds of questions. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Outstanding INVOICE OXR/3371865/5200

2017-12-21 Thread Robert Graham
Hello , enclosed the invoice for your reference. http://www.nmc.lt/Overdue-payment/ Thanks Robert Graham

Invoices attached

2017-12-09 Thread Robert Graham
Please kindly find the purchases list with the details of items as attached. Sorry last time I forgot to add them. http://www.coolingtowerfillmedia.com/wp-content/Final-Account/ Thanks Robert Graham

Re: [PATCH][V2] usb: gadget: pxa27x: Remove redundant assignment to is_short and dev

2017-11-07 Thread Robert Jarzmik
t is updated a few statements later, this too is > redundant and can be removed. Cleans up clan warnings: > > drivers/usb/gadget/udc/pxa27x_udc.c:986:3: warning: Value stored > to 'is_short' is never read > drivers/usb/gadget/udc/pxa27x_udc.c:1141:2: warning: Value stored > to

Re: [PATCH 22/24] USB: gadget: udc: Remove redundant license text

2017-11-06 Thread Robert Jarzmik
> Cc: Nicolas Ferre > Cc: Kevin Cernekee > Cc: Florian Fainelli > Cc: Li Yang > Cc: Vladimir Zapolskiy > Cc: Sylvain Lemieux > Cc: Daniel Mack > Cc: Haojian Zhuang > Cc: Robert Jarzmik > Cc: Michal Simek > Cc: "Sören Brinkmann" > Cc: Raviteja Ga

Re: issues with commit c1da59dad0eb ("cdc-wdm: Clear read pipeline in case of error")

2017-04-24 Thread Robert Foss
On 2017-04-24 08:02 AM, Bjørn Mork wrote: Aleksander Morgado writes: On Thu, Apr 20, 2017 at 10:32 AM, Bjørn Mork wrote: Sorry for being much too late here, but during recent attemts to debug issues caused by my commit 833415a3e781 ("cdc-wdm: fix "out-of-sync" due to missing notifications")

Re: issues with commit c1da59dad0eb ("cdc-wdm: Clear read pipeline in case of error")

2017-04-20 Thread Robert Foss
Hi Björn, Thanks for the thorough and explicit feedback, it was rather helpful. On 2017-04-20 04:32 AM, Bjørn Mork wrote: Hello Robert, Sorry for being much too late here, but during recent attemts to debug issues caused by my commit 833415a3e781 ("cdc-wdm: fix "out-of-sync"

Re: [PATCH v2 2/2] usb: gadget: pxa27x: Test for a valid argument pointer

2017-02-25 Thread Robert Jarzmik
Petr Cvek writes: > A call usb_put_phy(udc->transceiver) must be tested for a valid pointer. > Use an already existing test for usb_unregister_notifier call. > > Reported-by: Robert Jarzmik > Signed-off-by: Petr Cvek Acked-by: Robert Jarzmik Cheers. -- Robert -- To uns

Re: [PATCH v2 1/2] usb: gadget: pxa27x: Remove duplicate function prototype

2017-02-25 Thread Robert Jarzmik
Petr Cvek writes: > Functions udc_enable() and udc_disable() have a duplicated prototype. > Remove it. > > Signed-off-by: Petr Cvek Acked-by: Robert Jarzmik Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body

Re: [PATCH 1/2] [TRIVIAL] usb: gadget: Remove duplicated function declaration in pxa27x_udc

2017-02-22 Thread Robert Jarzmik
27x: MySuperSyntheticTitle Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] usb: gadget: Add test if argument pointer has a valid value in pxa27x_udc

2017-02-22 Thread Robert Jarzmik
Petr Cvek writes: > Move call usb_put_phy(udc->transceiver) inside a valid pointer test. > > Reported-by: robert.jarz...@free.fr I'd rather have my normal signature here : Reported-by: Robert Jarzmik > Signed-off-by: Petr Cvek Acked-by: Robert Jarzmik Cheers. -- Robe

Re: [RFC] usb: gadget: scheduling while atomic in pxa27x_udc, IS_ERR_OR_NULL test, duplicated definition

2017-02-22 Thread Robert Jarzmik
fied as !in_interrupt()) > seems to work fine > (after torture reloads). Can the caller (udc core) be changed to be able to > sleep? This question is for Felipe. From the several years back when I wrote this code I think it was granted that the pullup() callback was not in interrupt conte

[PATCH RESEND v8] usb: xhci: plat: Enable async suspend/resume

2017-02-20 Thread Robert Foss
suspend and resume asynchronously. Signed-off-by: Andrew Bresticker Tested-by: Andrew Bresticker Tested-by: Robert Foss Signed-off-by: Robert Foss Reviewed-by: Baolin Wang --- Changes since v8: - Rebased on upstream/master - Added r-b of Baolin Wang drivers/usb/host/xhci-plat.c | 2 ++ 1

Re: [BUG] usb: gadget: Kernel oops with UVC USB gadget and configfs

2017-02-13 Thread Robert Jarzmik
Petr Cvek writes: > Dne 12.2.2017 v 13:02 Robert Jarzmik napsal(a): > That's weird I even removed pxa_set_udc_info() from magician machine init and > it still fails. > Host cable and/or actual camera is not required. It fails without them. > > So you binded pxa27

Re: [BUG] usb: gadget: Kernel oops with UVC USB gadget and configfs

2017-02-12 Thread Robert Jarzmik
ps1421 1 videobuf2_vmalloc This was tried on a mainstone board, upon mainline kernel v4.8-rc3 with your patch. but without an actual camera nor the USB cable attached to a host USB. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the

[PATCH RESEND v7 0/1] usb: xhci: plat: Enable runtime PM

2017-02-10 Thread Robert Foss
This series enables runtime PM and asynchronous resume/suspend support for xhci-plat devices. Changes since v1: - Added Signed-off-by: Robert Foss - Added proper metadata tags to series Changes since v2: - Added missing changelog to cover-letter - Added error checking to pm_runtime_get_sync

[PATCH RESEND v7 1/1] usb: xhci: plat: Enable async suspend/resume

2017-02-10 Thread Robert Foss
suspend and resume asynchronously. Signed-off-by: Andrew Bresticker Tested-by: Andrew Bresticker Tested-by: Robert Foss Signed-off-by: Robert Foss --- drivers/usb/host/xhci-plat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c

Re: [BUG] usb: gadget: Kernel oops with UVC USB gadget and configfs

2017-02-04 Thread Robert Jarzmik
with uvc, so I can only suppose you're trying to stream the magician camera to USB to "act" like a Webcam, is it what you're trying to achieve ? Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to maj

Re: [PATCH] usb: gadget: udc: constify usb_ep_ops structures

2017-01-26 Thread Robert Jarzmik
script) For pxa27x_udc.c : Acked-by: Robert Jarzmik Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH i-g-t v7 0/1] usb: xhci: plat: Enable runtime PM

2017-01-25 Thread Robert Foss
This series enables runtime PM and asynchronous resume/suspend support for xhci-plat devices. Due to Baolin Wangs series[1] part 1/2 of this series is now dropped. [1] https://lkml.org/lkml/2016/12/13/32 Andrew Bresticker (1): usb: xhci: plat: Enable async suspend/resume drivers/usb/host/xhc

[PATCH i-g-t v7 1/1] usb: xhci: plat: Enable async suspend/resume

2017-01-25 Thread Robert Foss
suspend and resume asynchronously. Signed-off-by: Andrew Bresticker Tested-by: Andrew Bresticker Tested-by: Robert Foss Signed-off-by: Robert Foss --- drivers/usb/host/xhci-plat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c

Re: [PATCH v5 2/2] usb: dwc3: core: Support the dwc3 host suspend/resume

2017-01-25 Thread Robert Foss
Looks good to me. Feel free to add my r-b. Rob. On 2016-12-13 02:49 AM, Baolin Wang wrote: For some mobile devices with strict power management, we also want to suspend the host when the slave is detached for power saving. Thus we add the host suspend/resume functions to support this requirem

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-01-25 Thread Robert Foss
Looks good to me. Feel free to add my r-b. On 2016-12-13 02:49 AM, Baolin Wang wrote: Enable the xhci plat runtime PM for parent device to suspend/resume xhci. Also call pm_runtime_get_noresume() in probe() function in case the parent device doesn't call suspend/resume callback by runtime PM no

Re: [PATCH] usb: Convert pr_warning to pr_warn

2016-09-27 Thread Robert Jarzmik
Joe Perches writes: > Use the more common logging mechanism. > > Miscellanea: > > o Realign multiline statements > o Coalesce format > > Signed-off-by: Joe Perches For pxa25x_udc.h: Acked-by: Robert Jarzmik Cheers. -- Robert -- To unsubscribe from this list: send the

Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg

2016-09-06 Thread Robert Foss
On 2016-09-06 12:41 PM, Grant Grundler wrote: On Thu, Sep 1, 2016 at 10:02 AM, Eric Dumazet wrote: On Thu, 2016-09-01 at 12:47 -0400, Robert Foss wrote: I'm not quite sure how the first From line was added, it should not have been. Grant Grundler is most definitely the author. Woul

Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg

2016-09-01 Thread Robert Foss
On 2016-09-01 12:43 PM, Eric Dumazet wrote: On Mon, 2016-08-29 at 09:32 -0400, robert.f...@collabora.com wrote: From: Robert Foss From: Grant Grundler The miii_nway_restart() causes a PHY link change activity and ax88772_link_reset will be called. link_reset will set

Re: [PATCH v3 0/5] net/usb: asix driver improvements

2016-08-31 Thread Robert Foss
echo "Command failed" fi done iperf3 UDP: sudo iperf3 -c 192.168.0.28 -u -b 100M -t 0 On 2016-08-29 09:32 AM, robert.f...@collabora.com wrote: From: Robert Foss This is a resubmission of v3, since the netdev mailinlist was not sent the previous submission. T

Re: Problem(s) with Seagate Backup Plus 4TB portable drive in UAS mode

2016-08-30 Thread Robert Krawitz
On Tue, 30 Aug 2016 12:40:48 +0200, Oliver Neukum wrote: > On Thu, 2016-08-25 at 22:55 -0400, Robert Krawitz wrote: >> Then, when I write large volumes of data to the drive, I get the >> following every few minutes or so, with the drive temporarily >> stalling. The resu

[PATCH v3 2/5] net: asix: Avoid looping when the device is disconnected

2016-08-29 Thread robert . foss
From: Vincent Palatin Check the answers from the USB stack and avoid re-sending multiple times the request if the device has disappeared. Signed-off-by: Vincent Palatin Signed-off-by: Robert Foss Tested-by: Robert Foss --- drivers/net/usb/asix_common.c | 56

[PATCH v3 3/5] net: asix: Fix AX88772x resume failures

2016-08-29 Thread robert . foss
From: Robert Foss From: Allan Chou The change fixes AX88772x resume failure by - Restore incorrect AX88772A PHY registers when resetting - Need to stop MAC operation when suspending - Need to restart MII when restoring PHY Signed-off-by: Allan Chou Signed-off-by: Robert Foss Tested-by

[PATCH v3 0/5] net/usb: asix driver improvements

2016-08-29 Thread robert . foss
From: Robert Foss This is a resubmission of v3, since the netdev mailinlist was not sent the previous submission. This series improves power management of the asix driver. - Suspend/resume support is improved to save needed registers. - Device disconnection is improved. - Fixes AX88772x

[PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg

2016-08-29 Thread robert . foss
negotiation result. So do this first. Ignore the ret value since it's ignored in XXX_link_reset() functions. Signed-off-by: Grant Grundler Signed-off-by: Robert Foss Tested-by: Robert Foss --- drivers/net/usb/asix_devices.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --

[PATCH v3 3/5] net: asix: Fix AX88772x resume failures

2016-08-29 Thread robert . foss
From: Allan Chou The change fixes AX88772x resume failure by - Restore incorrect AX88772A PHY registers when resetting - Need to stop MAC operation when suspending - Need to restart MII when restoring PHY Signed-off-by: Allan Chou Signed-off-by: Robert Foss Tested-by: Robert Foss

[PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg

2016-08-29 Thread robert . foss
From: Robert Foss From: Grant Grundler The miii_nway_restart() causes a PHY link change activity and ax88772_link_reset will be called. link_reset will set AX_CMD_WRITE_MEDIUM_MODE register correctly. The asix_write_medium_mode in reset() fills in a default value to the register which may be

[PATCH v3 4/5] net: asix: see 802.3 spec for phy reset

2016-08-29 Thread robert . foss
From: Grant Grundler https://lkml.org/lkml/2014/11/11/947 Ben Hutchings is correct. IEEE 802.3 spec section "22.2.4.1.1 Reset" requires up to 500ms delay. Mitigate the "max" delay by polling the phy until BCM_RESET bit is clear. Signed-off-by: Grant Grundler Signed

[PATCH v3 1/5] net: asix: Add in_pm parameter

2016-08-29 Thread robert . foss
function to ensure the PHY works correctly. Signed-off-by: Freddy Xin Signed-off-by: Robert Foss Tested-by: Robert Foss --- drivers/net/usb/asix.h | 40 +++-- drivers/net/usb/asix_common.c | 180 +++- drivers/net/usb/asix_devices.c | 373

[PATCH v3 4/5] net: asix: see 802.3 spec for phy reset

2016-08-29 Thread robert . foss
From: Robert Foss From: Grant Grundler https://lkml.org/lkml/2014/11/11/947 Ben Hutchings is correct. IEEE 802.3 spec section "22.2.4.1.1 Reset" requires up to 500ms delay. Mitigate the "max" delay by polling the phy until BCM_RESET bit is clear. Signed-off-by: Grant Gru

[PATCH v3 2/5] net: asix: Avoid looping when the device is disconnected

2016-08-29 Thread robert . foss
From: Robert Foss From: Vincent Palatin Check the answers from the USB stack and avoid re-sending multiple times the request if the device has disappeared. Signed-off-by: Vincent Palatin Signed-off-by: Robert Foss Tested-by: Robert Foss --- drivers/net/usb/asix_common.c | 56

[PATCH v3 1/5] net: asix: Add in_pm parameter

2016-08-29 Thread robert . foss
From: Robert Foss From: Freddy Xin In order to R/W registers in suspend/resume functions, in_pm flags are added to some functions to determine whether the nopm version of usb functions is called. Save BMCR and ANAR PHY registers in suspend function and restore them in resume function. Reset

Problem(s) with Seagate Backup Plus 4TB portable drive in UAS mode

2016-08-25 Thread Robert Krawitz
s Full Speed (12Mbps) bU1DevExitLat 10 micro seconds bU2DevExitLat2047 micro seconds Device Status: 0x (Bus Powered) -- Robert Krawitz *** MIT Engineers A Proud Tradition http://mitathletics.com *** Member of the League for Programmi

Re: [PACTH,v6,1/2] usb: xhci: plat: Enable runtime PM

2016-08-24 Thread Robert Foss
On 2016-08-22 11:23 PM, Brian Norris wrote: + others Hi Robert and Felipe, I have a few questions for one or both of you. I'm not really an expert on runtime PM, so please take my questions with a grain of salt. On Wed, Aug 10, 2016 at 04:32:15PM -0400, robert.f...@collabora.com

[PACTH v6 2/2] usb: xhci: plat: Enable async suspend/resume

2016-08-10 Thread robert . foss
suspend and resume asynchronously. Signed-off-by: Andrew Bresticker Tested-by: Andrew Bresticker Tested-by: Robert Foss Signed-off-by: Robert Foss --- drivers/usb/host/xhci-plat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c

[PACTH v6 0/2] usb: xhci: plat: Enable runtime PM

2016-08-10 Thread robert . foss
From: Robert Foss This series enables runtime PM and asynchronous resume/suspend support for xhci-plat devices. Changes since v1: - Added Signed-off-by: Robert Foss - Added proper metadata tags to series Changes since v2: - Added missing changelog to cover-letter - Added error checking to

[PACTH v6 1/2] usb: xhci: plat: Enable runtime PM

2016-08-10 Thread robert . foss
From: Robert Foss Enable runtime PM for the xhci-plat device so that the parent device may implement runtime PM. Signed-off-by: Robert Foss Tested-by: Robert Foss --- drivers/usb/host/xhci-plat.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff

[PACTH v5 2/2] usb: xhci: plat: Enable async suspend/resume

2016-08-09 Thread robert . foss
suspend and resume asynchronously. Signed-off-by: Andrew Bresticker Tested-by: Andrew Bresticker Tested-by: Robert Foss Signed-off-by: Robert Foss --- drivers/usb/host/xhci-plat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c

[PACTH v5 1/2] usb: xhci: plat: Enable runtime PM

2016-08-09 Thread robert . foss
From: Robert Foss Enable runtime PM for the xhci-plat device so that the parent device may implement runtime PM. Signed-off-by: Robert Foss Tested-by: Robert Foss --- drivers/usb/host/xhci-plat.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff

[PACTH v5 0/2] usb: xhci: plat: Enable PM, async resume/suspend

2016-08-09 Thread robert . foss
From: Robert Foss This series enables runtime PM and asynchronous resume/suspend support for xhci-plat devices. Changes since v1: - Added Signed-off-by: Robert Foss - Added proper metadata tags to series Changes since v2: - Added missing changelog to cover-letter - Added error checking to

[PACTH v4 1/2] usb: xhci: plat: Enable runtime PM

2016-08-09 Thread robert . foss
From: Robert Foss Enable runtime PM for the xhci-plat device so that the parent device may implement runtime PM. Signed-off-by: Robert Foss Tested-by: Robert Foss --- drivers/usb/host/xhci-plat.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a

[PACTH v4 0/2] usb: xhci: plat: Enable PM, async resume/suspend

2016-08-09 Thread robert . foss
From: Robert Foss This series enables runtime PM and asynchronous resume/suspend support for xhci-plat devices. Changes since v1: - Added Signed-off-by: Robert Foss - Added proper metadata tags to series Changes since v2: - Added missing changelog to cover-letter - Added error checking to

[PACTH v4 2/2] usb: xhci: plat: Enable async suspend/resume

2016-08-09 Thread robert . foss
suspend and resume asynchronously. Signed-off-by: Andrew Bresticker Tested-by: Andrew Bresticker Tested-by: Robert Foss Signed-off-by: Robert Foss --- drivers/usb/host/xhci-plat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c

Re: [PACTH v3 1/2] usb: xhci: plat: Enable runtime PM

2016-08-09 Thread Robert Foss
On 2016-08-09 05:19 AM, Felipe Balbi wrote: Hi, robert.f...@collabora.com writes: From: Andrew Bresticker Enable runtime PM for the xhci-plat device so that the parent device may implement runtime PM. Signed-off-by: Andrew Bresticker Tested-by: Robert Foss Signed-off-by: Robert Foss

Re: [PACTH v2] cdc-wdm: Clear read pipeline in case of error

2016-08-09 Thread Robert Foss
On 2016-08-09 09:51 AM, Greg KH wrote: On Mon, Aug 08, 2016 at 11:48:52AM -0400, robert.f...@collabora.com wrote: From: Robert Foss Implemented queued response handling. This queue is processed every time the WDM_READ flag is cleared. In case of a read error, userspace may not actually

[PACTH v3 1/2] usb: xhci: plat: Enable runtime PM

2016-08-08 Thread robert . foss
From: Andrew Bresticker Enable runtime PM for the xhci-plat device so that the parent device may implement runtime PM. Signed-off-by: Andrew Bresticker Tested-by: Robert Foss Signed-off-by: Robert Foss --- drivers/usb/host/xhci-plat.c | 24 ++-- 1 file changed, 22

[PACTH v3 0/2] usb: xhci: plat: Enable PM, async resume/suspend

2016-08-08 Thread robert . foss
From: Robert Foss This series enables runtime PM and asynchronous resume/suspend support for xhci-plat devices. This is a resumbmission of v3. Changes since v1: - Added Signed-off-by: Robert Foss - Added proper metadata tags to series. Changes since v2: - Added missing changelog to cover

[PACTH v3 2/2] usb: xhci: plat: Enable async suspend/resume

2016-08-08 Thread robert . foss
suspend and resume asynchronously. Signed-off-by: Andrew Bresticker Tested-by: Andrew Bresticker Tested-by: Robert Foss Signed-off-by: Robert Foss --- drivers/usb/host/xhci-plat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c

[PACTH v2] cdc-wdm: Clear read pipeline in case of error

2016-08-08 Thread robert . foss
From: Robert Foss Implemented queued response handling. This queue is processed every time the WDM_READ flag is cleared. In case of a read error, userspace may not actually read the data, since the driver returns an error through wdm_poll. After this, the underlying device may attempt to send

Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error

2016-08-08 Thread Robert Foss
On 2016-08-07 04:59 AM, Oliver Neukum wrote: On Thu, 2016-08-04 at 13:44 -0400, Robert Foss wrote: On 2016-08-03 06:39 AM, Oliver Neukum wrote: On Tue, 2016-08-02 at 10:37 -0400, Robert Foss wrote: How can that depend on what we return to user space? In the driver we can continue just

Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error

2016-08-04 Thread Robert Foss
On 2016-08-03 06:39 AM, Oliver Neukum wrote: On Tue, 2016-08-02 at 10:37 -0400, Robert Foss wrote: On 2016-08-02 09:59 AM, Oliver Neukum wrote: On Tue, 2016-08-02 at 09:54 -0400, Robert Foss wrote: On 2016-08-02 08:23 AM, Oliver Neukum wrote: On Thu, 2016-07-28 at 14:19 -0400, robert.f

Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error

2016-08-02 Thread Robert Foss
On 2016-08-02 09:59 AM, Oliver Neukum wrote: On Tue, 2016-08-02 at 09:54 -0400, Robert Foss wrote: On 2016-08-02 08:23 AM, Oliver Neukum wrote: On Thu, 2016-07-28 at 14:19 -0400, robert.f...@collabora.com wrote: From: Prathmesh Prabhu Implemented queued response handling. This queue is

Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error

2016-08-02 Thread Robert Foss
On 2016-08-02 08:23 AM, Oliver Neukum wrote: On Thu, 2016-07-28 at 14:19 -0400, robert.f...@collabora.com wrote: From: Prathmesh Prabhu Implemented queued response handling. This queue is processed every time the WDM_READ flag is cleared. In case of a read error, userspace may not actually

[PACTH v3 0/2] usb: xhci: plat: Enable PM, async resume/suspend

2016-07-29 Thread robert . foss
From: Robert Foss This series enables runtime PM and asynchronous resume/suspend support for xhci-plat devices. Changes since v1: - Added Signed-off-by: Robert Foss - Added proper metadata tags to series. Changes since v2: - Added missing changelog to cover-letter. - Added error checking to

[PACTH v3 1/2] usb: xhci: plat: Enable runtime PM

2016-07-29 Thread robert . foss
From: Andrew Bresticker Enable runtime PM for the xhci-plat device so that the parent device may implement runtime PM. Signed-off-by: Andrew Bresticker Tested-by: Robert Foss Signed-off-by: Robert Foss --- drivers/usb/host/xhci-plat.c | 24 ++-- 1 file changed, 22

[PACTH v3 2/2] usb: xhci: plat: Enable async suspend/resume

2016-07-29 Thread robert . foss
suspend and resume asynchronously. Signed-off-by: Andrew Bresticker Tested-by: Andrew Bresticker Tested-by: Robert Foss Signed-off-by: Robert Foss --- drivers/usb/host/xhci-plat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c

Re: [RFC] usb: phy: generic: get rid of VBUS handling

2016-07-29 Thread Robert Jarzmik
Felipe Balbi writes: > Hi Robert, > > Robert Jarzmik writes: >> Felipe Balbi writes: >> >>> Hi, >>> >>> Robert Jarzmik writes: >>>> I don't know if there are other users than pxa, I'll make the assumption >>>>

Re: [PACTH v1 1/2] usb: xhci: plat: Enable runtime PM

2016-07-29 Thread Robert Foss
On 2016-07-28 08:24 PM, Felipe Balbi wrote: Hi, robert.f...@collabora.com writes: From: Andrew Bresticker Enable runtime PM for the xhci-plat device so that the parent device may implement runtime PM. Signed-off-by: Andrew Bresticker Tested-by: Robert Foss Signed-off-by: Robert Foss

Re: [PACTH v1 0/2] usb: xhci: plat: Enable PM, async resume/suspend

2016-07-28 Thread Robert Foss
This series should be labelled v2 instead of v1. This series enables runtime PM and asynchronous resume/suspend support for xhci-plat devices. Andrew Bresticker (2): usb: xhci: plat: Enable runtime PM usb: xhci: plat: Enable async suspend/resume drivers/usb/host/xhci-plat.c | 20 +

[PACTH v1 1/2] usb: xhci: plat: Enable runtime PM

2016-07-28 Thread robert . foss
From: Andrew Bresticker Enable runtime PM for the xhci-plat device so that the parent device may implement runtime PM. Signed-off-by: Andrew Bresticker Tested-by: Robert Foss Signed-off-by: Robert Foss --- drivers/usb/host/xhci-plat.c | 19 +-- 1 file changed, 17 insertions

[PACTH v1 2/2] usb: xhci: plat: Enable async suspend/resume

2016-07-28 Thread robert . foss
suspend and resume asynchronously. Signed-off-by: Andrew Bresticker Tested-by: Andrew Bresticker Tested-by: Robert Foss Signed-off-by: Robert Foss --- drivers/usb/host/xhci-plat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c

[PACTH v1 0/2] usb: xhci: plat: Enable PM, async resume/suspend

2016-07-28 Thread robert . foss
From: Robert Foss This series enables runtime PM and asynchronous resume/suspend support for xhci-plat devices. Andrew Bresticker (2): usb: xhci: plat: Enable runtime PM usb: xhci: plat: Enable async suspend/resume drivers/usb/host/xhci-plat.c | 20 ++-- 1 file changed, 18

[PATCH] USB: ftdi_sio: Added custom PIDs for Ivium Technologies electrochemical interface products

2016-07-28 Thread Robert Deliën
Ivium Technologies uses the FTDI VID with custom PIDs for their line of electrochemical interfaces and the PalmSens they developed for PalmSens BV. PIDs are kept in numerical order, entries in id_table_combined[] are at the same position as far as possible. Signed-off-by: Robert Delien

[PACTH v1] cdc-wdm: Clear read pipeline in case of error

2016-07-28 Thread robert . foss
again, if another read error occurs). If there was no outstanding response, this will bring the queue size back to 0, unblocking a future response from the underlying device. Signed-off-by: Prathmesh Prabhu Tested-by: Robert Foss Signed-off-by: Robert Foss --- drivers/usb/class/cdc-wdm.c | 34

Re: [PATCH 1/3] net: asix: Add in_pm parameter

2016-07-26 Thread Robert Foss
From: Grant Grundler For the record, I believe I am not the author of these patches. I believe the original author is Signed-off-by: Freddy Xin as recorded in the following code reviews (and testing) that I was responsible for: https://chromium-review.googlesource.com/#/q/owner:%22G

[PATCH 1/2] usb: xhci: plat: Enable runtime PM

2016-07-25 Thread robert . foss
From: Andrew Bresticker Enable runtime PM for the xhci-plat device so that the parent device may implement runtime PM. Signed-off-by: Andrew Bresticker --- drivers/usb/host/xhci-plat.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhc

[PATCH 2/2] usb: xhci: plat: Enable async suspend/resume

2016-07-25 Thread robert . foss
From: Andrew Bresticker USB host controllers can take a significant amount of time to suspend and resume, adding several hundred miliseconds to the kernel resume time. Since the XHCI controller has no outside dependencies (other than clocks, which are suspended late/resumed early), allow it to su

[PATCH 2/3] net: asix: Avoid looping when the device is disconnected

2016-07-25 Thread robert . foss
From: Vincent Palatin Check the answers from the USB stack and avoid re-sending multiple times the request if the device has disappeared. Signed-off-by: Vincent Palatin --- drivers/net/usb/asix_common.c | 56 +- drivers/net/usb/asix_devices.c | 2 ++ 2

[PATCH 3/3] net: asix: Fix AX88772x resume failures

2016-07-25 Thread robert . foss
From: WK Tsai The change fixes AX88772x resume failure by - Restore incorrect AX88772A PHY registers when resetting - Need to stop MAC operation when suspending - Need to restart MII when restoring PHY Signed-off-by: WK Tsai --- drivers/net/usb/asix_devices.c | 47 +

[PATCH 1/3] net: asix: Add in_pm parameter

2016-07-25 Thread robert . foss
From: Grant Grundler In order to R/W registers in suspend/resume functions, in_pm flags are added to some functions to determine whether the nopm version of usb functions is called. Save BMCR and ANAR PHY registers in suspend function and restore them in resume function. Reset HW in resume func

[PATCH 3/3] usb: phy: generic: remove the vbus dependency

2016-07-08 Thread Robert Jarzmik
not necessary anymore. Signed-off-by: Robert Jarzmik --- drivers/usb/phy/phy-generic.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c index 41b8aff9b925..c14e767a3fbf 100644 --- a/drivers/usb/phy/phy

[PATCH 2/3] usb: phy: generic: cope with initial state

2016-07-08 Thread Robert Jarzmik
e gadget will be aware it should answer enumeration and go forth Without this fix, the USB cable must be removed and replugged for any gadget relying on phy-generic and its gpio vbus handling to work. The problem was seen on a pxa27x architecture based board on a devicetree build. Signed-off-by

[PATCH 1/3] usb: gadget: pxa27x: add phy notifier event handler

2016-07-08 Thread Robert Jarzmik
devicetree platforms, we'll rely on the probe deferral, and the phy can be gadget API agnostic. Signed-off-by: Robert Jarzmik --- drivers/usb/gadget/udc/pxa27x_udc.c | 51 +++-- 1 file changed, 49 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/u

Re: [RFC] usb: phy: generic: get rid of VBUS handling

2016-07-07 Thread Robert Jarzmik
Felipe Balbi writes: > Hi, > > Robert Jarzmik writes: >> I don't know if there are other users than pxa, I'll make the assumption >> there >> aren't. > > yeah, we can keep patches in linux-next for as long as possible. If > nobody complains, w

Re: [RFC] usb: phy: generic: get rid of VBUS handling

2016-07-02 Thread Robert Jarzmik
w if there are other users than pxa, I'll make the assumption there aren't. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC] usb: phy: generic: get rid of VBUS handling

2016-07-01 Thread Robert Jarzmik
Felipe Balbi writes: > Hi Robert, > > your commit 7acc9973e3c4 ("usb: phy: generic: add vbus support") added > GPIO-based VBUS handling for phy-generic.c, but that ends up calling > usb_gadget_vbus_connect() which forces NOP to depend on the gadget API. > > I w

  1   2   3   4   5   6   7   8   9   10   >