Re: [PATCH v3 1/3] usb: chipidea: imx: support configuring for active low oc signal

2018-12-04 Thread Stefan Wahren
Am 04.12.18 um 09:52 schrieb Uwe Kleine-König: > Hello Stefan, > > On Tue, Dec 04, 2018 at 09:40:26AM +0100, Stefan Wahren wrote: >> Am 04.12.18 um 09:31 schrieb Uwe Kleine-König: >>> The status quo on i.MX6 is that if "over-current-active-high" i

Re: [PATCH v3 1/3] usb: chipidea: imx: support configuring for active low oc signal

2018-12-04 Thread Stefan Wahren
Hi Uwe, Am 04.12.18 um 09:31 schrieb Uwe Kleine-König: > The status quo on i.MX6 is that if "over-current-active-high" is > specified in the device tree this is configured as expected. If > the property is missing polarity isn't changed and so the > polarity is kept as setup by the bootloader.

dwc2: scatter-gather support?

2018-07-29 Thread Stefan Wahren
Hi, if i connect a UAS capable storage device to the Raspberry Pi, i'm getting the following output on 4.18rc: The driver for the USB controller dwc2_hsotg does not support scatter-gather which is required by the UAS driver. Please try an other USB controller if you wish to use

Re: dwc2: enumeration issue with audio dongle connected to USB hub

2018-06-16 Thread Stefan Wahren
Hi, > Stefan Wahren hat am 2. Mai 2018 um 18:49 > geschrieben: > > > Hi Minas, > > > Minas Harutyunyan hat am 2. Mai 2018 um > > 10:54 geschrieben: > > > > > > Hi, > > > > On 4/27/2018 10:03 AM, Stefan Wahren wrote: > > &

Re: [PATCH] usb: gadget: dwc2: fix memory leak in gadget_init()

2018-05-25 Thread Stefan Wahren
Hi Grigor, > Grigor Tovmasyan <grigor.tovmas...@synopsys.com> hat am 24. Mai 2018 um 16:22 > geschrieben: > > > Freed allocated request for ep0 to prevent memory leak in case when > dwc2_driver_probe() failed. > > Signed-off-by: Grigor Tovmasyan <tovma...@

Re: [PATCH v1 0/2] usb: dwc2: gadget: Fixes for LPM

2018-05-07 Thread Stefan Wahren
:31 PM, Simon Shields wrote: Hi all, On 10/04/2018 10:21 PM, Grigor Tovmasyan wrote: Here are two little fixes for LPM feature. First one is coverity warning fix. The Second one was asserted by Stefan Wahren. Changes from version 0: 1/2: - Instead of converting parameter

[PATCH] usb: dwc2: debugfs: Don't touch RX FIFO during register dump

2018-05-04 Thread Stefan Wahren
saf Kaukab <yousaf.kau...@intel.com> Fixes: 563cf017c443 ("usb: dwc2: debugfs: add support for complete register dump") Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/usb/dwc2/debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/d

Re: dwc2: enumeration issue with audio dongle connected to USB hub

2018-05-02 Thread Stefan Wahren
Hi Minas, > Minas Harutyunyan <minas.harutyun...@synopsys.com> hat am 2. Mai 2018 um > 10:54 geschrieben: > > > Hi, > > On 4/27/2018 10:03 AM, Stefan Wahren wrote: > > Hi, > > during my tests with a Raspberry Pi 2 B with an C-Media audio dongle > &

net: smsc95xx: aligment issues

2018-04-28 Thread Stefan Wahren
Hi, after connecting a Raspberry Pi 1 B to my local network i'm seeing aligment issues under /proc/cpu/alignment: User: 0 System: 142 (_decode_session4+0x12c/0x3c8) Skipped:0 Half: 0 Word: 0 DWord: 127 Multi: 15 User faults:2

dwc2: enumeration issue with audio dongle connected to USB hub

2018-04-27 Thread Stefan Wahren
Hi, during my tests with a Raspberry Pi 2 B with an C-Media audio dongle connected to a powered USB hub, i noticed the enumeration errors below (the device gets finally ernumerated). I tested yesterdays linux-next, 4.17-rc2 and 4.14 but all of them show this behavior, if i plugin the audio

Re: [PATCH] usb: dwc2: gadget: Fix memory leak in dwc2_gadget_init()

2018-04-23 Thread Stefan Wahren
Am 23.04.2018 um 09:05 schrieb Grigor Tovmasyan: Hi Stefan, On 4/18/2018 1:11 AM, Stefan Wahren wrote: Hi Grigor, Grigor Tovmasyan <grigor.tovmas...@synopsys.com> hat am 16. April 2018 um 12:16 geschrieben: In dwc2_gadget_init() we allocate EP0 request via dwc2_hsotg_ep_alloc_r

Re: [PATCH] usb: dwc2: gadget: Fix memory leak in dwc2_gadget_init()

2018-04-17 Thread Stefan Wahren
Hi Grigor, > Grigor Tovmasyan hat am 16. April 2018 um > 12:16 geschrieben: > > > In dwc2_gadget_init() we allocate EP0 request via > dwc2_hsotg_ep_alloc_request(). After that there are > usb_add_gadget_udc() call and if it failed, then > ctrl_req will not be

Re: dwc2: Memory leak in dwc2_gadget_init

2018-04-09 Thread Stefan Wahren
Hi Grigor, > Grigor Tovmasyan <grigor.tovmas...@synopsys.com> hat am 9. April 2018 um > 18:42 geschrieben: > > > Hi Stefan, > > On 4/2/2018 12:59 PM, Stefan Wahren wrote: > > Hi Minas, > > > > i noticed that in opposite to all alloca

Re: [PATCH 0/2] usb: dwc2: gadget: Fixes for LPM

2018-04-03 Thread Stefan Wahren
Hi Grigor, Am 03.04.2018 um 13:21 schrieb Grigor Tovmasyan: Here are two little fixes for LPM feature. First one is coverity warning fix. The Second one was asserted by Stefan Wahren. AFAIK Minas Harutyunyan is the new maintainer of dwc2. So this series should go to him. Regards Stefan

Re: [PATCH] usb: core: phy: Fix usb_phy_roothub_add_phy if GENERIC_PHY=n

2018-04-02 Thread Stefan Wahren
Hi Martin, > Martin Blumenstingl <martin.blumensti...@googlemail.com> hat am 31. März 2018 > um 22:12 geschrieben: > > > Hello Stefan, > > On Sat, Mar 31, 2018 at 9:28 PM, Stefan Wahren <stefan.wah...@i2se.com> wrote: > > If the g

Re: dwc2: Confusing warnings in next-20180327 on Raspberry Pi

2018-04-02 Thread Stefan Wahren
Hi Grigor, > Grigor Tovmasyan <grigor.tovmas...@synopsys.com> hat am 2. April 2018 um > 18:00 geschrieben: > > > Hi Stefan, > > On 4/2/2018 7:47 PM, Stefan Wahren wrote: > > Hi Minas, > > > > in linux-next-20180327 i will get the followin

dwc2: Confusing warnings in next-20180327 on Raspberry Pi

2018-04-02 Thread Stefan Wahren
Hi Minas, in linux-next-20180327 i will get the following confusing warnings on the Raspberry Pi: Linux raspberrypi 4.16.0-rc7-next-20180327+ #2 SMP PREEMPT Sat Mar 31 13:24:47 CEST 2018 armv6l GNU/Linux [6.809185] dwc2 2098.usb: dwc2_check_params: Invalid parameter lpm=1 [

dwc2: Memory leak in dwc2_gadget_init

2018-04-02 Thread Stefan Wahren
Hi Minas, i noticed that in opposite to all allocations in dwc2_gadget_init() the function dwc2_hsotg_ep_alloc_request() uses kzalloc. So in case usb_add_gadget_udc() would fail, the memory of the USB request would be leaked: Linux raspberrypi 4.16.0-rc7-next-20180327+ #2 SMP PREEMPT Sat Mar

[PATCH] usb: core: phy: Fix usb_phy_roothub_add_phy if GENERIC_PHY=n

2018-03-31 Thread Stefan Wahren
: probe of 2098.usb failed with error -38 Fixes: 07dbff0ddbd8 ("usb: core: add a wrapper for the USB PHYs on the HCD") Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/usb/core/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

Re: [PATCH] usb: dwc2: Print error if unable to set DMA coherent mask

2018-03-08 Thread Stefan Wahren
> Stefan Wahren <stefan.wah...@i2se.com> hat am 12. Februar 2018 um 21:20 > geschrieben: > > > We better print an error in case probing of dwc2 fails on > setting the DMA coherent mask. > > Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> >

Re: Continuous USB resets on NXP i.MX 6ULL device

2018-03-02 Thread Stefan Wahren
Am 02.03.2018 um 04:03 schrieb Peter Chen: For non-core registers, i.mx6ull can use i.mx6q as its base setting, the bits you mentioned may also be reserved at imx6qdl RM. just for my understanding: MX6_BM_NON_BURST_SETTING is a no-op on i.MX6ULL or not properly documented in reference

Re: Continuous USB resets on NXP i.MX 6ULL device

2018-03-01 Thread Stefan Wahren
Hi Peter, Am 01.03.2018 um 03:00 schrieb Peter Chen: > On Wed, Feb 28, 2018 at 06:08:20PM +0100, Stefan Wahren wrote: >> Hi, >> >> i'm not sure this is related, but i noticed something ugly in >> driver/usb/chipidea/usbmisc_imx.c. >> >> The compatible "

Re: Continuous USB resets on NXP i.MX 6ULL device

2018-02-28 Thread Stefan Wahren
Hi, i'm not sure this is related, but i noticed something ugly in driver/usb/chipidea/usbmisc_imx.c. The compatible "fsl,imx6ul-usbmisc" uses imx6sx_usbmisc_ops, which uses usbmisc_imx6sx_init (which also calls usbmisc_imx6q_init). Within usbmisc_imx6q_init the flag MX6_BM_NON_BURST_SETTING is

[PATCH] usb: dwc2: Print error if unable to set DMA coherent mask

2018-02-12 Thread Stefan Wahren
We better print an error in case probing of dwc2 fails on setting the DMA coherent mask. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/usb/dwc2/platform.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/platform.c b/drivers/us

Re: [PATCH] usb: dwc2: Fix endless deferral probe

2018-01-12 Thread Stefan Wahren
Am 12.01.2018 um 00:32 schrieb Arnd Bergmann: On Wed, Jan 10, 2018 at 1:15 PM, Stefan Wahren <stefan.wah...@i2se.com> wrote: Hi Arnd, Am 09.01.2018 um 22:33 schrieb Arnd Bergmann: On Tue, Jan 9, 2018 at 8:28 PM, Stefan Wahren <stefan.wah...@i2se.com> wrote: The dwc2 USB

Re: [PATCH] usb: dwc2: Fix endless deferral probe

2018-01-10 Thread Stefan Wahren
Hi Arnd, Am 09.01.2018 um 22:33 schrieb Arnd Bergmann: On Tue, Jan 9, 2018 at 8:28 PM, Stefan Wahren <stefan.wah...@i2se.com> wrote: The dwc2 USB driver tries to find a generic PHY first and then look for an old style USB PHY. In case of a valid generic PHY node without a PHY driver, t

Re: [PATCH v3 00/49] usb: dwc2: fixes, enhancements and new features

2018-01-09 Thread Stefan Wahren
Hi Razmik, > Razmik Karapetyan <razmik.karapet...@synopsys.com> hat am 8. Januar 2018 um > 13:40 geschrieben: > > > On 12/31/2017 9:19 PM, Stefan Wahren wrote: > > Hi Stefan, > > >> > >> Razmik Karapetyan (10): > >>usb:

[PATCH] usb: dwc2: Fix endless deferral probe

2018-01-09 Thread Stefan Wahren
style USB PHY at once. Fixes: 6c2dad69163f ("usb: dwc2: Return errors from PHY") Link: https://marc.info/?l=linux-usb=151518314314753=2 Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/usb/dwc2/platform.c | 42 -- 1 file change

[Bug] Endless deferred probe of dwc2 on RPi 3

2018-01-05 Thread Stefan Wahren
Hi, i noticed on my Raspberry Pi 3 (Linux 4.15rc6, ARM64, defconfig) that probing of dwc2 driver is deferred endlessly. This issue is triggered by a recent DT clean up 014d6da6cb25 ("ARM: dts: bcm283x: Fix DTC warnings about missing phy-cells") which is correct according to

Re: [PATCH v3 00/49] usb: dwc2: fixes, enhancements and new features

2017-12-31 Thread Stefan Wahren
Hi Grigor, sorry for misusing the cover letter for my comments, but i didn't received all patches. > Grigor Tovmasyan hat am 26. Dezember 2017 um > 12:21 geschrieben: > > > ... > > Gevorg Sahakyan (1): > usb: dwc2: Remove version check in GSNPSID > >

Re: [PATCH v3 00/49] usb: dwc2: fixes, enhancements and new features

2017-12-26 Thread Stefan Wahren
Hi Grigor, > Grigor Tovmasyan hat am 26. Dezember 2017 um > 12:21 geschrieben: > > > This patch series includes new features such us Active Clock Gating(ACG), > LPM and Hibernation, enhancements and fixes for already existing features. > All this patches were

Re: [PATCH v4] usb: dwc2: host: Don't retry NAKed transactions right away

2017-12-19 Thread Stefan Wahren
Hi Doug, > Doug Anderson hat am 19. Dezember 2017 um 16:57 > geschrieben: > > > Felipe, > > On Tue, Dec 12, 2017 at 10:30 AM, Douglas Anderson > wrote: > ... > > I don't mean to be a pest, but I'm hoping that we can land this > somewhere (if

Re: [PATCH] usb: dwc2: Change TxFIFO and RxFIFO flushing flow

2017-12-11 Thread Stefan Wahren
Hi Minas, Am 11.12.2017 um 11:45 schrieb Minas Harutyunyan: > Hi Stefan, > On 12/8/2017 8:25 PM, Stefan Wahren wrote: >> Hi Minas, >> >> Am 07.12.2017 um 17:51 schrieb Stefan Wahren: >>> Hi Minas, >>> >>> Am 07.12.2017 um 09:40 schrieb Stefan W

Re: [PATCH] usb: dwc2: Change TxFIFO and RxFIFO flushing flow

2017-12-08 Thread Stefan Wahren
Hi Minas, Am 07.12.2017 um 17:51 schrieb Stefan Wahren: Hi Minas, Am 07.12.2017 um 09:40 schrieb Stefan Wahren: Before flushing fifos required to check AHB master state and flush when AHB master is in IDLE state. Signed-off-by: Minas Harutyunyan <hmi...@synopsys.com> --- drivers/us

Re: [PATCH] usb: dwc2: hcd: Fix host channel halt flow

2017-12-07 Thread Stefan Wahren
Hi Minas, Am 07.12.2017 um 18:08 schrieb Stefan Wahren: > According databook in Buffer and External DMA mode > non-split periodic channels can't be halted. do you know of any consequences not having this patch applied? > > Signed-off-by: Minas Harutyunyan <hmi...@synopsys.c

Re: [PATCH] usb: dwc2: host: Setting TOUTCAL and USBTRDTIM fields in host mode

2017-12-07 Thread Stefan Wahren
Hi Minas, Am 07.12.2017 um 17:56 schrieb Stefan Wahren: > Added missing GUSBCFG programming in host mode. > > These fields even if was programmed in device mode (in function > dwc2_hsotg_core_init_disconnected()) will be resetting to POR values > after core soft reset applied.

Re: [PATCH] usb: dwc2: Change TxFIFO and RxFIFO flushing flow

2017-12-07 Thread Stefan Wahren
Hi Minas, Am 07.12.2017 um 09:40 schrieb Stefan Wahren: > Before flushing fifos required to check AHB master state and > flush when AHB master is in IDLE state. > > Signed-off-by: Minas Harutyunyan <hmi...@synopsys.com> > --- > drivers/usb/dwc2/core.c | 27 +

Re: [PATCH v3 1/2] usb: dwc2: host: Don't retry NAKed transactions right away

2017-12-05 Thread Stefan Wahren
with a NAK when they have nothing to say and thus we end with this same sequence. Signed-off-by: Douglas Anderson <diand...@chromium.org> Cc: sta...@vger.kernel.org Reviewed-by: Julius Werner <jwer...@chromium.org> Tested-by: Stefan Wahren <stefan.wah...@i2se.com> --- Changes i

Re: [PATCH] ARM: dts: bcm283x: Fix fifo size for EP 6,7

2017-11-23 Thread Stefan Wahren
Hi Minas, > Minas Harutyunyan hat am 23. November 2017 > um 11:00 geschrieben: > > > Hi Stefan, > > ... > > In addition to above patches please apply this one: > > diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c > index

Re: [PATCH] ARM: dts: bcm283x: Fix fifo size for EP 6,7

2017-11-22 Thread Stefan Wahren
Hi Minas, > Stefan Wahren <stefan.wah...@i2se.com> hat am 22. November 2017 um 12:21 > geschrieben: > > > Hi Minas, > > > Minas Harutyunyan <minas.harutyun...@synopsys.com> hat am 21. November 2017 > > um 13:02 geschrieben: > > > > Hi

Re: [PATCH] ARM: dts: bcm283x: Fix fifo size for EP 6,7

2017-11-22 Thread Stefan Wahren
dwc2_check_param_tx_fifo_sizes function accordingly. Change-Id: I61d3db753b1bc06f0f2caf40df350a09655f18fd Signed-off-by: Gevorg Sahakyan <sahak...@synopsys.com> Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/usb/dwc2/core.h | 1 + drivers/usb/dwc2/params.c | 11

Re: [PATCH] ARM: dts: bcm283x: Fix fifo size for EP 6,7

2017-11-20 Thread Stefan Wahren
Hi Minas, Am 20.11.2017 um 12:59 schrieb Minas Harutyunyan: > Hi Stefan, > Looks like I know cause of issue... but I'm overloaded today and will able to > check it tomorrow. Sorry for delay. thanks for your reply. There is no need to hurry, because the merge window isn't open yet, but i like to

Re: [PATCH] ARM: dts: bcm283x: Fix fifo size for EP 6,7

2017-11-18 Thread Stefan Wahren
Hi Minas, > Minas Harutyunyan <minas.harutyun...@synopsys.com> hat am 17. November 2017 > um 08:48 geschrieben: > > > On 11/17/2017 2:35 AM, Stefan Wahren wrote: > > Hi Eric, > > > >> Stefan Wahren <stefan.wah...@i2se.com> hat am 31. Oktober 20

Re: [PATCH] ARM: dts: bcm283x: Fix fifo size for EP 6,7

2017-11-16 Thread Stefan Wahren
Hi Eric, > Stefan Wahren <stefan.wah...@i2se.com> hat am 31. Oktober 2017 um 09:43 > geschrieben: > > > Hi Eric, > > > Eric Anholt <e...@anholt.net> hat am 31. Oktober 2017 um 01:40 geschrieben: > > > > > > Stefan Wahren <stefan.wah..

Re: [1/2] mm: drop migrate type checks from has_unmovable_pages

2017-11-06 Thread Stefan Wahren
Am 06.11.2017 um 09:14 schrieb Michal Hocko: > On Sun 05-11-17 22:56:32, Stefan Wahren wrote: >> Hi Michal, >> >> the dwc2 USB driver on BCM2835 in linux-next is affected by the CMA >> allocation issue. A quick web search guide me to your patch, which >> avoid the

Re: [1/2] mm: drop migrate type checks from has_unmovable_pages

2017-11-05 Thread Stefan Wahren
Hi Michal, the dwc2 USB driver on BCM2835 in linux-next is affected by the CMA allocation issue. A quick web search guide me to your patch, which avoid the issue. Since the patch wasn't accepted, i want to know is there another solution? Is this an issue in dwc2? Best regards Stefan -- To

Re: [PATCH] ARM: dts: bcm283x: Fix fifo size for EP 6,7

2017-10-31 Thread Stefan Wahren
Hi Eric, > Eric Anholt <e...@anholt.net> hat am 31. Oktober 2017 um 01:40 geschrieben: > > > Stefan Wahren <stefan.wah...@i2se.com> writes: > > >> Stefan Wahren <stefan.wah...@i2se.com> hat am 7. Oktober 2017 um 12:16 > >> geschrieben:

Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

2017-10-28 Thread Stefan Wahren
the > pl2303 serial adapters tend to respond with a NAK when they have > nothing to say and thus we end with this same sequence. This patch fixes "dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s" on bcm2835. After applying your patch on linux-next plus "mm: dr

Re: [PATCH v3] dma-mapping: skip USB devices when configuring DMA during probe

2017-08-11 Thread Stefan Wahren
Hi Robin, Am 08.08.2017 um 20:03 schrieb Johan Hovold: > On Sat, Aug 05, 2017 at 10:38:07AM +0200, Christoph Hellwig wrote: >> I think the root problem is that the code added by >> " of/acpi: Configure dma operations at probe time for platform/amba/pci bus >> devices" >> >> is completely bogus

Re: Rpi3: no ethernet in 4.13: bisected to patch 'USB: of: fix root-hub device-tree node handling'

2017-08-02 Thread Stefan Wahren
> Johan Hovold <jo...@kernel.org> hat am 2. August 2017 um 13:45 geschrieben: > > > On Wed, Aug 02, 2017 at 01:10:33PM +0200, Stefan Wahren wrote: > > Am 02.08.2017 um 09:03 schrieb Hans Verkuil: > > > When testing with my Raspberry Pi 3 and the 4.13-rcX m

Re: Rpi3: no ethernet in 4.13: bisected to patch 'USB: of: fix root-hub device-tree node handling'

2017-08-02 Thread Stefan Wahren
Am 02.08.2017 um 09:03 schrieb Hans Verkuil: > When testing with my Raspberry Pi 3 and the 4.13-rcX mainline kernel > I discovered that there was no ethernet. After bisecting I got to commit > 2bf69867 ('USB: of: fix root-hub device-tree node handling'). > > With that commit lsusb outputs: > >

Re: No Ethernet on Raspberry Pi 3 in v4.13-rc1

2017-07-25 Thread Stefan Wahren
> Robin Murphy <robin.mur...@arm.com> hat am 25. Juli 2017 um 15:21 geschrieben: > > > Hi Stefan, > > On 25/07/17 06:19, Stefan Wahren wrote: > >>> With arm64 4.13-rc1 I get no eth0 device on Pi3 (openSUSE Tumbleweed). > >>> The v4.13-rc1 DT wor

Re: No Ethernet on Raspberry Pi 3 in v4.13-rc1

2017-07-25 Thread Stefan Wahren
> Robin Murphy hat am 25. Juli 2017 um 15:21 geschrieben: > > From the subsequent fallout (which on closer inspection looks more to do > with calling into uninitialised SWIOTLB state than the arm64 DMA code > actually doing anything wrong), I'd guess dev->dma_pfn_offset is

Re: No Ethernet on Raspberry Pi 3 in v4.13-rc1

2017-07-24 Thread Stefan Wahren
Hi Robin, > Robin Murphy hat am 24. Juli 2017 um 13:22 geschrieben: > > > Hi Andreas, > > On 22/07/17 13:29, Andreas Färber wrote: > > Hello, > > > > With arm64 4.13-rc1 I get no eth0 device on Pi3 (openSUSE Tumbleweed). > > The v4.13-rc1 DT works okay with a 4.12

dwc2: g-tx-fifo-size configuration on bcm2835

2017-05-18 Thread Stefan Wahren
Hi, since the dwc2 should be able to properly setup its fifos, i want to enable otg mode for Raspberry Pi Zero (BCM2835). According to the BCM2835 datasheet [1] it has 7 device EPs with a max FIFO depth for EP1..5 = 512 and EP6,7 = 768. This makes in sum 4096, which also seems to be okay

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

2017-05-13 Thread Stefan Wahren
> Doug Anderson <diand...@chromium.org> hat am 11. Mai 2017 um 01:50 > geschrieben: > > > Hi, > > On Wed, May 10, 2017 at 9:31 AM, Johan Hovold <jo...@kernel.org> wrote: > > On Mon, May 08, 2017 at 10:22:08PM +0200, Stefan Wahren wrote: > >> @Dou

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

2017-05-08 Thread Stefan Wahren
> Stefan Wahren <stefan.wah...@i2se.com> hat am 25. April 2017 um 20:11 > geschrieben: > > > > Stefan Wahren <stefan.wah...@i2se.com> hat am 22. April 2017 um 22:50 > > geschrieben: > > > > > > Hi, > > > > > Eri

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

2017-04-25 Thread Stefan Wahren
> Stefan Wahren <stefan.wah...@i2se.com> hat am 22. April 2017 um 22:50 > geschrieben: > > > Hi, > > > Eric Anholt <e...@anholt.net> hat am 20. April 2017 um 20:54 geschrieben: > > > > > > Stefan Wahren <stefan.wah...@i2se.com&

Re: [PATCH] usb: chipidea: udc: fix NULL pointer dereference if udc_start failed

2017-04-25 Thread Stefan Wahren
Am 25.04.2017 um 11:20 schrieb Peter Chen: > diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index f88e9157fad0..60a786c87c06 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c @@ -1984,6 +1984,7 @@ static void

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

2017-04-22 Thread Stefan Wahren
Hi, > Eric Anholt <e...@anholt.net> hat am 20. April 2017 um 20:54 geschrieben: > > > Stefan Wahren <stefan.wah...@i2se.com> writes: > > > Hi, > > > >> Doug Anderson <diand...@chromium.org> hat am 18. April 2017 um 22:41 > >> ge

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

2017-04-20 Thread Stefan Wahren
Am 19.04.2017 um 23:47 schrieb Doug Anderson: > Hi, > > On Wed, Apr 19, 2017 at 1:25 PM, Stefan Wahren <stefan.wah...@i2se.com> wrote: >> Hi, >> >>> Doug Anderson <diand...@chromium.org> hat am 18. April 2017 um 22:41 >>> geschrieben: >>&

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

2017-04-19 Thread Stefan Wahren
Hi, > Doug Anderson hat am 18. April 2017 um 22:41 > geschrieben: > > > It's hard to know for sure that all of this time is really in > urb_enqueue(). Possible we could have task switched out and been > blocked elsewhere. Using ftrace to get more fine-grained timings

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

2017-04-19 Thread Stefan Wahren
Am 19.04.2017 um 10:56 schrieb Johan Hovold: > On Tue, Apr 18, 2017 at 10:25:06PM +0200, Stefan Wahren wrote: >> Hi, >> >> [add Johan] >> >>> Stefan Wahren <stefan.wah...@i2se.com> hat am 18. April 2017 um 10:07 >>> geschrieben: >>> &

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

2017-04-18 Thread Stefan Wahren
> Doug Anderson <diand...@chromium.org> hat am 18. April 2017 um 22:41 > geschrieben: > > > Stefan, > > On Tue, Apr 18, 2017 at 1:25 PM, Stefan Wahren <stefan.wah...@i2se.com> wrote: > > Hi, > > > > [add Johan] > > > >> Ste

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

2017-04-18 Thread Stefan Wahren
Hi, [add Johan] > Stefan Wahren <stefan.wah...@i2se.com> hat am 18. April 2017 um 10:07 > geschrieben: > > > Am 18.04.2017 um 00:37 schrieb Doug Anderson: > > Hi, > > > > On Mon, Apr 17, 2017 at 4:05 AM, Stefan Wahren <stefan.wah...@i2se.com>

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

2017-04-18 Thread Stefan Wahren
Am 18.04.2017 um 00:37 schrieb Doug Anderson: > Hi, > > On Mon, Apr 17, 2017 at 4:05 AM, Stefan Wahren <stefan.wah...@i2se.com> wrote: >> Hi, >> >>> Stefan Wahren <stefan.wah...@i2se.com> hat am 31. Oktober 2016 um 21:34 >>> geschrieben:

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

2017-04-17 Thread Stefan Wahren
Hi, > Stefan Wahren <stefan.wah...@i2se.com> hat am 31. Oktober 2016 um 21:34 > geschrieben: > > > I inspired by this issue [1] i build up a slightly modified setup with a > Raspberry Pi B (mainline kernel 4.9rc3), a powered 7 port USB hub and 5 > Prolific > PL23

dwc2: g_serial doesn't enumerate when builtin

2017-04-15 Thread Stefan Wahren
Hi, this seems like a newbie question, but shouldn't g_serial also work in case it's builtin? I tested g_serial with a Raspberry Pi Zero (OTG mode, Linux 4.11-rc1) as gadget and a Linux Laptop as host (Linux 4.10.9). In case g_serial is build as a kernel module the RPi gets enumerated on the

Re: usb/net/hso: WARNING: ungligned urb->setup_dma

2017-03-03 Thread Stefan Wahren
Hi Baruch, Am 01.03.2017 um 11:54 schrieb Baruch Siach: > Hi Stefan, > > On Tue, Feb 28, 2017 at 07:32:09PM +0100, Stefan Wahren wrote: >>> Baruch Siach <bar...@tkos.co.il> hat am 28. Februar 2017 um 19:07 >>> geschrieben: >>> On Tue, Feb 28, 201

Re: usb/net/hso: WARNING: ungligned urb->setup_dma

2017-02-28 Thread Stefan Wahren
Hi Baruch, > Baruch Siach <bar...@tkos.co.il> hat am 28. Februar 2017 um 19:07 geschrieben: > > > Hi Stefan, > > On Tue, Feb 28, 2017 at 05:21:18PM +0100, Stefan Wahren wrote: > > Am 28.02.2017 um 13:01 schrieb Baruch Siach: > > > On Tue, Feb 28, 2017

Re: usb/net/hso: WARNING: ungligned urb->setup_dma

2017-02-28 Thread Stefan Wahren
Hi Baruch, Am 28.02.2017 um 13:01 schrieb Baruch Siach: Hi linux-usb list, (Dropped Jan's bouncing address, added Rpi3 platform lists) On Tue, Feb 28, 2017 at 10:28:10AM +0200, Baruch Siach wrote: Hi linux-usb list, I'm hitting this warning consistently on my Raspberry Pi 3 running kernel

Re: USB/swiotlb failure on arm64/RPi3

2017-01-25 Thread Stefan Wahren
[Add John and linux-usb] Am 24.01.2017 um 23:52 schrieb Aaro Koskinen: > Hi, > > Booting Debian rootfs from USB hard disk (ext4) using 64-bit 4.9 kernel > on Raspberry Pi 3 fails early in the boot as follows: > > [ 15.162466] systemd[1]: Detected architecture arm64. > > Welcome to Debian

Re: [PATCH v3 24/24] usb: dwc2: gadget: Add checking for g-tx-fifo-size parameter

2017-01-24 Thread Stefan Wahren
Hi John, could you please push this series to the github synopsys-usb repo? I didn't have the chance to test combination of your last series. Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v2 25/28] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220

2017-01-17 Thread Stefan Wahren
Hi John, is there a public git repo where this series is already applied? Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RFT] usb: dwc2: gadget: Fix fifo size configuration

2016-12-20 Thread Stefan Wahren
Hi Sevak, > Sevak Arakelyan <sevak.arakel...@synopsys.com> hat am 20. Dezember 2016 um > 13:57 geschrieben: > > > On 12/19/2016 8:39 PM, Stefan Wahren wrote: > > Currently the upper limit for the endpoint index during fifo size > > config was always 16 inste

[PATCH RFT] usb: dwc2: gadget: Fix fifo size configuration

2016-12-19 Thread Stefan Wahren
Currently the upper limit for the endpoint index during fifo size config was always 16 instead of the available endpoints. So fix this by using the determined amount of endpoints and avoid a warning about "insufficient fifo memory" on bcm2835 which has only 8 endpoints. Signed-off-

[PATCH] usb: dwc2: gadget: Fix fifo size configuration

2016-12-19 Thread Stefan Wahren
Currently the upper limit for the endpoint index during fifo size config was always 16 instead of the available endpoints. So fix this by using the determined amount of endpoints and avoid a warning about "insufficient fifo memory" on bcm2835 which has only 8 endpoints. Signed-off-

Re: [PATCH v2 2/3] Revert "usb: dwc2: gadget: fix TX FIFO size and address initialization"

2016-11-24 Thread Stefan Wahren
Hi John, > John Youn hat am 18. Oktober 2016 um 02:36 > geschrieben: > > > This reverts commit aa381a7259c3 ("usb: dwc2: gadget: fix TX FIFO size > and address initialization"). > > The original commit removed the FIFO size programming per endpoint. The > DPTXFSIZn

Re: [PATCH 5/5] usb: dwc2: fix kernel-doc for dwc2_set_param

2016-11-22 Thread Stefan Wahren
Hi Felipe, Am 22.11.2016 um 13:23 schrieb Felipe Balbi: > Hi, > > Stefan Wahren <stefan.wah...@i2se.com> writes: >> Since there is no parameter @value replace it with @legacy. >> >> Fixes: 05ee799f202 ("usb: dwc2: Move gadget settings into core_params")

[PATCH 5/5] usb: dwc2: fix kernel-doc for dwc2_set_param

2016-11-20 Thread Stefan Wahren
Since there is no parameter @value replace it with @legacy. Fixes: 05ee799f202 ("usb: dwc2: Move gadget settings into core_params") Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/usb/dwc2/params.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 2/5] usb: dwc2: fix dwc2_get_device_property for u8 and u16

2016-11-20 Thread Stefan Wahren
t;) Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/usb/dwc2/params.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index fd5f7f8..2c7b624 100644 --- a/drivers/usb/dwc2/params.c +++ b/drivers/u

[PATCH 0/5] usb: dwc2: fix parameter handling

2016-11-20 Thread Stefan Wahren
This patch series fixes several parameter handling issues found on bcm2835 in gadget mode. It's based on Felipe's USB next. Stefan Wahren (5): usb: dwc2: Do not set host parameter in peripheral mode usb: dwc2: fix dwc2_get_device_property for u8 and u16 usb: dwc2: fix default value for DMA

[PATCH 3/5] usb: dwc2: fix default value for DMA support

2016-11-20 Thread Stefan Wahren
The current defaults for DMA results on a non-DMA platform in a unnecessary error message: Invalid value 0 for param gadget-dma So fix this by using dma_capable as default value. Fixes: 9962b62f1be ("usb: dwc2: Deprecate g-use-dma binding") Signed-off-by: Stefan Wahren <stefan.wa

[PATCH 1/5] usb: dwc2: Do not set host parameter in peripheral mode

2016-11-20 Thread Stefan Wahren
56 invalid for host_nperio_tx_fifo_size. Check HW configuration. 512 invalid for host_perio_tx_fifo_size. Check HW configuration. Fixes: 55e1040e424b ("usb: dwc2: Improve handling of host and device hwparams") Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- driver

[PATCH 4/5] usb: dwc2: gadget: fix default value for gadget-dma-desc

2016-11-20 Thread Stefan Wahren
The current default for gadget DMA descriptor results on bcm2835 in a unnecessary error message: Invalid value 1 for param gadget-dma-desc So fix this by using hw->dma_desc_enable as default value. Fixes: dec4b55677e ("usb: dwc2: gadget: Add descriptor DMA parameter") Signed-o

Re: [PATCH v2 2/4] usb: dwc2: Add binding for AHB burst

2016-11-17 Thread Stefan Wahren
Hi John, Am 17.11.2016 um 00:47 schrieb John Youn: > Add the "snps,ahb-burst" binding and read it in. > > This property controls which burst type to perform on the AHB bus as a > master in internal DMA mode. This overrides the legacy param value, > which we need to keep around for now since

Re: [PATCH 1/4] usb: dwc2: Fix AHB burst type for bcm2835

2016-11-16 Thread Stefan Wahren
Hi John, > John Youn hat am 16. November 2016 um 01:36 > geschrieben: > > > The ahbcfg param for bcm2835 is specifying a HBSTLEN of 0x8 (0x10 >> 1) > which is not a valid value for that field. Remove the param and default > to using INCR4. i don't have any Synopsys

usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

2016-10-31 Thread Stefan Wahren
I inspired by this issue [1] i build up a slightly modified setup with a Raspberry Pi B (mainline kernel 4.9rc3), a powered 7 port USB hub and 5 Prolific PL2303 USB to serial convertors. I modified the usb_test for dwc2 [2], which only tries to open all ttyUSB devices one after the other.

[PATCH] usb: chipidea: host: fix NULL ptr dereference during shutdown

2016-09-10 Thread Stefan Wahren
LE_END and we finish interrupt handling before the hcd is deallocated. This avoids the NULL pointer dereference. Suggested-by: Alan Stern <st...@rowland.harvard.edu> Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> Fixes: b09b5224fe86 ("usb: chipidea: implement platform shutdown

Re: usb: chipidea: hdc: kernel panic during shutdown

2016-09-09 Thread Stefan Wahren
Am 05.09.2016 um 04:51 schrieb Peter Chen: > On Fri, Sep 02, 2016 at 08:20:35PM +0200, Stefan Wahren wrote: >> Hi Peter, >> >>> Stefan Wahren <stefan.wah...@i2se.com> hat am 25. August 2016 um 19:17 >>> geschrieben: >>> >>> >>> Hi,

Re: [RFT PATCH v4 0/3] usb: dwc2: Fix core reset and force mode delays

2016-09-06 Thread Stefan Wahren
I have doubled > this. > > Appreciate any testing on RK3188 and RPi platforms. i tested the whole series successful with a Raspberry Pi B in dr_mode "host" and "otg" Tested-by: Stefan Wahren <stefan.wah...@i2se.com> -- To unsubscribe from this list: send the line "

Re: usb: chipidea: hdc: kernel panic during shutdown

2016-09-02 Thread Stefan Wahren
Hi Peter, > Stefan Wahren <stefan.wah...@i2se.com> hat am 25. August 2016 um 19:17 > geschrieben: > > > Hi, > > > Peter Chen <hzpeterc...@gmail.com> hat am 25. August 2016 um 11:16 > > geschrieben: > > > > > > On Thu, Aug 25, 2016 a

Re: usb: chipidea: hdc: kernel panic during shutdown

2016-08-25 Thread Stefan Wahren
Hi, > Peter Chen <hzpeterc...@gmail.com> hat am 25. August 2016 um 11:16 > geschrieben: > > > On Thu, Aug 25, 2016 at 08:27:03AM +0200, Stefan Wahren wrote: > > Am 25.08.2016 um 08:44 schrieb Peter Chen: > > > On Thu, Aug 25, 2016 at 07:06:12AM +0200,

Re: usb: chipidea: hdc: kernel panic during shutdown

2016-08-25 Thread Stefan Wahren
Am 25.08.2016 um 08:44 schrieb Peter Chen: > On Thu, Aug 25, 2016 at 07:06:12AM +0200, Stefan Wahren wrote: >> Hi Alan, >> >> i tried the following patch: >> --- a/drivers/usb/chipidea/host.c >> +++ b/drivers/usb/chipidea/host.c >> @@ -185,6 +185,8 @@ s

Re: usb: chipidea: hdc: kernel panic during shutdown

2016-08-24 Thread Stefan Wahren
Hi Alan, > Alan Stern <st...@rowland.harvard.edu> hat am 24. August 2016 um 20:55 > geschrieben: > > > On Wed, 24 Aug 2016, Stefan Wahren wrote: > > > Hi, > > > > [add Li Jun to CC] > > > > > Alan Stern <st...@rowland.ha

Re: usb: chipidea: hdc: kernel panic during shutdown

2016-08-24 Thread Stefan Wahren
Hi, [add Li Jun to CC] > Alan Stern <st...@rowland.harvard.edu> hat am 24. August 2016 um 15:45 > geschrieben: > > > On Wed, 24 Aug 2016, Peter Chen wrote: > > > On Tue, Aug 23, 2016 at 09:17:02PM +0200, Stefan Wahren wrote: > > > Hi, > >

usb: chipidea: hdc: kernel panic during shutdown

2016-08-23 Thread Stefan Wahren
Hi, i'm using a iMX233-OLinuXino board and the kernel panics during shutdown with 4.8.0-rc2-next-20160819: [ 420.04] ci_hdrc ci_hdrc.0: remove, state 1 [ 420.05] usb usb1: USB disconnect, device number 1 [ 420.06] usb 1-1: USB disconnect, device number 2 [ 420.06] usb 1-1.1:

Re: [Bug] usb: dwc2: host function broken in OTG mode on bcm283x

2016-08-23 Thread Stefan Wahren
Hi John, > John Youn hat am 23. August 2016 um 20:37 > geschrieben: > > > > How about we fall back to smaller defaults if the original values > fail? And don't configure more than the amount of endpoints. this sounds good. I would prefer to calculate the estimated

Re: [Bug] usb: dwc2: host function broken in OTG mode on bcm283x

2016-08-22 Thread Stefan Wahren
Hi John, > John Youn <john.y...@synopsys.com> hat am 23. August 2016 um 00:08 > geschrieben: > > > On 8/22/2016 1:47 PM, Stefan Wahren wrote: > > Hi John, > > > >> John Youn <john.y...@synopsys.com> hat am 22. August 2016 um 22:06 > >>

Re: [Bug] usb: dwc2: host function broken in OTG mode on bcm283x

2016-08-22 Thread Stefan Wahren
Hi John, > John Youn <john.y...@synopsys.com> hat am 22. August 2016 um 22:06 > geschrieben: > > > On 8/20/2016 6:03 AM, Stefan Wahren wrote: > > Hi John, > > > > > > Hi Stefan, > > Why doesn't DT work? I think all the properties are

  1   2   >