On Wed, 2 Oct 2013, Daniel Mack wrote:
> On 01.10.2013 21:32, Thomas Pugliese wrote:
> > This patch updates snd_usb_audio_create also support devices whose
> > speed == USB_SPEED_WIRELESS.
>
> Interesting. What device are you testing this with?
>
>
> Daniel
&g
This patch updates snd_usb_audio_create also support devices whose
speed == USB_SPEED_WIRELESS.
Signed-off-by: Thomas Pugliese
---
sound/usb/card.c |1 +
1 file changed, 1 insertion(+)
diff --git a/sound/usb/card.c b/sound/usb/card.c
index 64952e2..ef76aa0 100644
--- a/sound/usb/card.c
Hi,
This patch adds support for dev speed USB_SPEED_WIRELESS in
snd_usb_parse_datainterval which allows the usb sound core to create
ISO urbs with the correct number and size of buffers.
Signed-off-by: Thomas Pugliese
---
sound/usb/helper.c |1 +
1 file changed, 1 insertion(+)
diff
This set of patches implements a few minor additions in preparation for
adding isochronous support to the HWA.
Thomas Pugliese (3):
implement hwahc_op_get_frame_number
set the RPIPE bOverTheAirInterval for isoc endpoints
Add isoc transfer type enum and packet definitions
drivers/usb/host
This patch adds transfer type enum and packet definitions for
WA_XFER_ISO_PACKET_INFO and WA_XFER_ISO_PACKET_STATUS packets.
It also changes instances of __attribute__((packed)) to __packed to make
checkpatch.pl happy.
Signed-off-by: Thomas Pugliese
---
include/linux/usb/wusb-wa.h | 45
-by: Thomas Pugliese
---
drivers/usb/host/hwa-hc.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/hwa-hc.c b/drivers/usb/host/hwa-hc.c
index 5b86ffb..e58b924 100644
--- a/drivers/usb/host/hwa-hc.c
+++ b/drivers/usb/host/hwa-hc.c
@@ -199,10 +199,14
This patch sets the RPIPE bOverTheAirInterval field for RPIPES which
refer to isochronous endpoints.
Signed-off-by: Thomas Pugliese
---
drivers/usb/wusbcore/wa-rpipe.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/wusbcore/wa-rpipe.c b/drivers/usb
.
Signed-off-by: Thomas Pugliese
---
drivers/usb/wusbcore/wa-xfer.c | 51 ++--
1 file changed, 38 insertions(+), 13 deletions(-)
diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers/usb/wusbcore/wa-xfer.c
index 6327df0..7a78240 100644
--- a/drivers/usb/wusbcore/wa
On Mon, 30 Sep 2013, Greg KH wrote:
> On Mon, Sep 30, 2013 at 10:48:46PM -0500, Thomas Pugliese wrote:
> > Fix a build warning found by the kbuild test robot in the most recent
> > wusbcore patches.
> >
> > Signed-off-by: Thomas Pugliese
>
> You
Fix a build warning found by the kbuild test robot in the most recent
wusbcore patches.
Signed-off-by: Thomas Pugliese
---
drivers/usb/wusbcore/wa-xfer.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers/usb/wusbcore/wa-xfer.c
index
nt is dequeued after the driver has received the
transfer result but before the data is received.
Signed-off-by: Thomas Pugliese
---
drivers/usb/wusbcore/wa-xfer.c | 122
1 file changed, 87 insertions(+), 35 deletions(-)
diff --git a/drivers/usb/wusbco
Hi,
This set of patches fixes a few places where the endiannes was not
being converted for the dwTransferID field of transfer requests and
transfer results. It also adds the xfer ID to some debug prints to aid
in bus log analysis.
Thomas Pugliese (2):
fix endianess issues when using
Include the xfer_id in debug prints for transfers and transfer segments.
This makes it much easier to correlate debug logs to USB analyzer logs.
Signed-off-by: Thomas Pugliese
---
drivers/usb/wusbcore/wa-xfer.c | 94 +---
1 file changed, 49 insertions
Add a new function to get the xfer ID in little endian format
(wa_xfer_id_le32), and use it instead of wa_xfer_id where appropriate.
Signed-off-by: Thomas Pugliese
---
drivers/usb/wusbcore/wa-xfer.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a
vel error handler.
Signed-off-by: Thomas Pugliese
---
drivers/usb/wusbcore/wa-xfer.c | 121 ++--
1 file changed, 67 insertions(+), 54 deletions(-)
diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers/usb/wusbcore/wa-xfer.c
index dfb11bf..4531752 100644
--- a/dr
rename patches I sent
earlier since this set references some of those renamed objects.
Thomas Pugliese (4):
usb: wusbcore: allow wa_xfer_destroy to clean up partially
constructed xfers
usb: wusbcore: resource cleanup fix in __wa_xfer_setup_segs
usb: wusbcore: clean up the sg list that was
being leaked for all transfers before this change.
Signed-off-by: Thomas Pugliese
---
drivers/usb/wusbcore/wa-xfer.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers/usb/wusbcore/wa-xfer.c
index 11d684c..dfb11bf 100644
--- a/d
This patch fixes two cases where error handling code was freeing memory
but not setting the pointer to NULL. This could lead to a double free
in the HWA shutdown code.
Signed-off-by: Thomas Pugliese
---
drivers/usb/wusbcore/wa-xfer.c |2 ++
1 file changed, 2 insertions(+)
diff --git a
Clean up the SG list after transfer completetion for out transfers if one
was created by the HWA.
Signed-off-by: Thomas Pugliese
---
drivers/usb/wusbcore/wa-xfer.c |4
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers/usb/wusbcore/wa-xfer.c
index
Rename xfer_result to dti_buf and xfer_result_size to dti_buf_size in
struct wahc. The dti buffer will also be used for isochronous status
packets once isochronous transfers are supported.
Signed-off-by: Thomas Pugliese
---
drivers/usb/wusbcore/wa-hc.c | 14 +++---
drivers/usb
Hi,
This set of patches renames various data fields in wa_seg and wahc
to more clearly specify their purpose. I plan to add isochronous
support to wusbcore soon and these changes will make that patch easier
to comprehend.
Thomas Pugliese (2):
usb: wusbcore: rename urb to tr_urb in struct
Rename urb to tr_urb in struct wa_seg to make it clear that the urb is
used for the transfer request.
Signed-off-by: Thomas Pugliese
---
drivers/usb/wusbcore/wa-xfer.c | 30 --
1 file changed, 16 insertions(+), 14 deletions(-)
diff --git a/drivers/usb/wusbcore
Use usb_free_urb instead of kfree in error path and point to the correct
URB. Also remember to clean up the sg list for the URB if it was allocated.
Signed-off-by: Thomas Pugliese
---
drivers/usb/wusbcore/wa-xfer.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a
The check to free the URB was the opposite of the correct case. This
patch removes the check altogether since the ptr will be NULL if the URB
was not allocated. Also use usb_free_urb instead of usb_put_urb.
Signed-off-by: Thomas Pugliese
---
drivers/usb/wusbcore/wa-xfer.c |9
already done by usb_init_urb.
Signed-off-by: Thomas Pugliese
---
drivers/usb/wusbcore/wa-xfer.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers/usb/wusbcore/wa-xfer.c
index 573f8b2..6ad02f5 100644
--- a/drivers/usb
Various minor cleanups to resource init and free code including two
actual memory leaks. These should be applied after the WUSB STALL patch
I submitted earlier.
Thomas Pugliese (3):
fix resource cleanup in error path in __wa_xfer_setup_segs
fix leak of urb in wa_xfer_destroy.
Use
removes the unneccessary call to spin_lock_irqsave for a nested
lock that was present in the first patch.
Signed-off-by: Thomas Pugliese
diff --git a/drivers/usb/wusbcore/wa-hc.h b/drivers/usb/wusbcore/wa-hc.h
index d6bea3e..cf250c2 100644
--- a/drivers/usb/wusbcore/wa-hc.h
+++ b/drivers/usb
-by: Thomas Pugliese
diff --git a/drivers/usb/wusbcore/wa-hc.h b/drivers/usb/wusbcore/wa-hc.h
index d6bea3e..cf250c2 100644
--- a/drivers/usb/wusbcore/wa-hc.h
+++ b/drivers/usb/wusbcore/wa-hc.h
@@ -91,6 +91,7 @@
struct wusbhc;
struct wahc;
extern void wa_urb_enqueue_run(struct work_struct *ws
to corrupt the list while it is being iterated over. This patch
moves all list entries to a temp list while holding the list lock, then
traverses the temp list with no lock held.
Signed-off-by: Thomas Pugliese
diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers/usb/wusbcore/wa-xfer.c
index
On Fri, 9 Aug 2013, Greg KH wrote:
> On Fri, Aug 09, 2013 at 09:52:13AM -0500, Thomas Pugliese wrote:
> > This patch fixes a kernel panic that can occur when disconnecting a
> > wireless USB->serial device. When the serial device disconnects, the
> > device cleanup p
perly by usb_hcd_disable_endpoint. It also updates wa_urb_dequeue to
handle the case where the endpoint has already been cleaned up when
usb_kill_urb is called which is where the panic originally occurred.
Signed-off-by: Thomas Pugliese
diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers/usb/wus
tines. Second, set the hwarc->neep_urb and hwarc->rd_buffer to NULL
when they are freed in the error path in the post_reset routine. This
prevents a double free when the disconnect routine is called and attempts
to free those resources again.
Signed-off-by: Thomas Pugliese
diff --git a/driv
Prevent the USB core from suspending the HWA root hub since bus_suspend
and bus_resume are not yet supported. Otherwise the PM system will chew
up CPU time constantly attempting to suspend and resume the root hub but
never succeeding.
Signed-off-by: Thomas Pugliese
diff --git a/drivers/usb
Prevent the USB core from suspending the HWA root hub since bus_suspend
and bus_resume are not yet supported. Otherwise the PM system will chew
up CPU time constantly attempting to suspend and resume the root hub but
never succeeding.
Signed-off-by: Thomas Pugliese
diff --git a/drivers/usb
implementation can also leave the upper bits of the port bitmap
uninitialized if wusbhc->ports_max is not one less than an even multiple
of 8. This patch fixes that as well by initializing the buffer to 0.
Signed-off-by: Thomas Pugliese
diff --git a/drivers/usb/wusbcore/rh.c b/drivers/usb/wusbc
r the radio control interface has already run, the uwb directory
will be gone so the call to sysfs_remove_link generates a warning.
Signed-off-by: Thomas Pugliese
diff --git a/drivers/uwb/pal.c b/drivers/uwb/pal.c
index 690577d..c1304b8 100644
--- a/drivers/uwb/pal.c
+++ b/drivers/uwb/pal.c
@@
On Wed, 17 Jul 2013, Alan Stern wrote:
> On Wed, 17 Jul 2013, Thomas Pugliese wrote:
>
> > On Wed, 17 Jul 2013, Alan Stern wrote:
> >
> > > On Wed, 17 Jul 2013, Thomas Pugliese wrote:
> > >
> > > > Hi,
> > > > What is t
On Wed, 17 Jul 2013, Alan Stern wrote:
> On Wed, 17 Jul 2013, Thomas Pugliese wrote:
>
> > Hi,
> > What is the expected behavior if a host controller does not implement
> > bus_suspend and bus_resume? I am seeing that with the HWA HCD, kworker
> > and khubd p
Hi,
What is the expected behavior if a host controller does not implement
bus_suspend and bus_resume? I am seeing that with the HWA HCD, kworker
and khubd peg the CPU at 100% because the kernel is constantly calling
hcd_bus_suspend and hcd_bus_resume. The calls to hcd_bus_suspend and
hcd_bus_
On Wed, 26 Jun 2013, Ming Lei wrote:
> USB spec stats that short packet can only appear at the end
> of transfer. Because lost of HC(EHCI/UHCI/OHCI/...) can't
> build a full packet from discontinuous buffers, we introduce
> the limit in usb_submit_urb() to avoid such kind of bad sg
> coming from
channel. It is
the responsibility of userspace to ensure that the uwb_rc class device has
been created before starting the HWA channel.
Signed-off-by: Thomas Pugliese
diff --git a/drivers/usb/host/hwa-hc.c b/drivers/usb/host/hwa-hc.c
index 4af750e..483990c 100644
--- a/drivers/usb/host/hwa
On Mon, 24 Jun 2013, Greg KH wrote:
> On Mon, Jun 24, 2013 at 12:18:04PM -0500, Thomas Pugliese wrote:
> > This patch fixes a race condition that caused the HWA_HC interface probe
> > function to occasionally fail. The HWA_HC would attempt to register
> > itself with th
This patch fixes a race condition that caused the HWA_HC interface probe
function to occasionally fail. The HWA_HC would attempt to register
itself with the HWA_RC by searching for a uwb_rc class device with the
same parent device ptr. If the probe function for the HWA_RC interface
had yet to
On Thu, 20 Jun 2013, Alan Stern wrote:
> On Thu, 20 Jun 2013, Greg KH wrote:
>
> > > I'm not exactly sure what the implications of combining the modules are
> > > so
> > > I don't know if that would fix it or not.
> > >
> > > It is true that an HWA will always have an associated radio contro
On Wed, 19 Jun 2013, Greg KH wrote:
> On Wed, Jun 19, 2013 at 03:33:51PM -0500, Thomas Pugliese wrote:
> > Hi,
> > I am attempting to debug a problem where the hwa_hc module occasionally
> > fails to start correctly when an HWA device is plugged in. An HWA device
&g
Hi,
I am attempting to debug a problem where the hwa_hc module occasionally
fails to start correctly when an HWA device is plugged in. An HWA device
consists of two USB interfaces each with its own driver: the radio control
interface (hwa_rc.ko), and the host controller interface (hwa_hc.ko).
Add documenation for new ABI entries.
Signed-off-by: Thomas Pugliese
---
Documentation/ABI/testing/sysfs-class-uwb_rc-wusbhc | 19 +++
1 file changed, 19 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-class-uwb_rc-wusbhc
b/Documentation/ABI/testing/sysfs-class
This patch set adds sysfs attributes to the wusbhc for DNTS count and
interval and the host controller transaction retry count.
Thomas Pugliese (3):
add sysfs attribute for DNTS count and interval
add sysfs attribute for retry count
add entries in Documentation/ABI for new wusbhc sysfs
This patch adds a sysfs attribute for the wireless USB host controller
device notification transmit slot(DNTS) count and interval. It also
changes the defaults from 16 slots in every MMC to a more reasonable 4
slots every 2ms.
Signed-off-by: Thomas Pugliese
---
drivers/usb/wusbcore/mmc.c
This patch adds a sysfs attribute for the wireless host controller
transaction retry count. It also changes the default value from 15
retries to infinite retries because the driver currently does not handle
retry errors gracefully.
Signed-off-by: Thomas Pugliese
---
drivers/usb/wusbcore/wa
Sorry about that. It was my first attempt at a multi-part patch. I'll
update the documentation, renumber and resend.
Tom
On Fri, 14 Jun 2013, Greg KH wrote:
> On Thu, Jun 13, 2013 at 12:20:30PM -0500, Thomas Pugliese wrote:
> > This patch adds a sysfs attribute for the wir
This patch adds a sysfs attribute for the wireless host controller
transaction retry count. It also changes the default value from 15
retries to infinite retries because the driver currently does not handle
retry errors gracefully.
Signed-off-by: Thomas Pugliese
diff --git a/drivers/usb
This patch adds a sysfs attribute for the wireless USB host controller
device notification transmit slot(DNTS) count and interval. It also
changes the defaults from 16 slots in every MMC to a more reasonable 4
slots every 2ms.
Signed-off-by: Thomas Pugliese
diff --git a/drivers/usb/wusbcore
On Tue, 11 Jun 2013, Alan Stern wrote:
> On Tue, 11 Jun 2013, Thomas Pugliese wrote:
>
> > This patch adds support for scatter gather DMA to the wire adapter and
> > updates the HWA to advertise support for SG transfers. This allows the
> > block layer to submit tran
On Tue, 11 Jun 2013, Greg KH wrote:
> On Tue, Jun 11, 2013 at 10:39:31AM -0500, Thomas Pugliese wrote:
> > This patch adds support for scatter gather DMA to the wire adapter and
>
> Don't you mean "wireless adapter"?
The Wireless USB spec uses the term "wi
This patch adds support for scatter gather DMA to the wire adapter and
updates the HWA to advertise support for SG transfers. This allows the
block layer to submit transfer requests to the HWA HC without first
breaking them up into PAGE_SIZE requests.
Signed-off-by: Thomas Pugliese
diff
This patch adds support for the Alereon 5310 and 5611 devices to the
HWA-rc driver.
Signed-off-by: Thomas Pugliese
diff --git a/drivers/uwb/hwa-rc.c b/drivers/uwb/hwa-rc.c
index 810c90a..0621abe 100644
--- a/drivers/uwb/hwa-rc.c
+++ b/drivers/uwb/hwa-rc.c
@@ -900,6 +900,12 @@ static const
No action is needed for the HWA_NOTIF_BPST_ADJ event. Ignore it instead
of printing a warning to the log since these events can happen dozens of
times per second.
Signed-off-by: Thomas Pugliese
diff --git a/drivers/usb/wusbcore/wa-nep.c b/drivers/usb/wusbcore/wa-nep.c
index f67f7f1..ada4e08
This patch adds the HWA specific members to struct usb_rpipe_descriptor
and sets them correctly based on the wireless endpoint compananion
descriptor.
Signed-off-by: Thomas Pugliese
diff --git a/drivers/usb/wusbcore/wa-rpipe.c b/drivers/usb/wusbcore/wa-rpipe.c
index f0d546c..9429c12 100644
Suspend and resume are not currently supported on the wireless root hub.
Remove the suspend and resume op functions in the host controller driver
to avoid constant error messages in the system log.
Signed-off-by: Thomas Pugliese
diff --git a/drivers/usb/host/hwa-hc.c b/drivers/usb/host/hwa
consistently.
Signed-off-by: Thomas Pugliese
diff --git a/drivers/usb/wusbcore/devconnect.c
b/drivers/usb/wusbcore/devconnect.c
index 1d36531..33a1278 100644
--- a/drivers/usb/wusbcore/devconnect.c
+++ b/drivers/usb/wusbcore/devconnect.c
@@ -455,8 +455,8 @@ static void __wusbhc_keep_alive(struct wusbhc
On Wed, 5 Jun 2013, Thomas Pugliese wrote:
>
>
> On Tue, 4 Jun 2013, Thomas Pugliese wrote:
>
> > This patch adds the HWA-specific RPIPE fields to usb_rpipe_descriptor and
> > sets the appropriate values in usb/wusbcore/wa-rpipe.c:rpipe_aim.
> >
>
On Tue, 4 Jun 2013, Thomas Pugliese wrote:
> This patch adds the HWA-specific RPIPE fields to usb_rpipe_descriptor and
> sets the appropriate values in usb/wusbcore/wa-rpipe.c:rpipe_aim.
>
> Signed-off-by: Thomas Pugliese
>
> diff --git a/drivers/usb/wusbcore/wa-rpi
This patch adds the HWA-specific RPIPE fields to usb_rpipe_descriptor and
sets the appropriate values in usb/wusbcore/wa-rpipe.c:rpipe_aim.
Signed-off-by: Thomas Pugliese
diff --git a/drivers/usb/wusbcore/wa-rpipe.c b/drivers/usb/wusbcore/wa-rpipe.c
index f0d546c..ed77ec7 100644
--- a/drivers
root hubs do not support.
Signed-off-by: Thomas Pugliese
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index d53547d..014dc99 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -149,6 +149,27 @@ static const u8 usb3_rh_dev_descriptor[18] = {
0x01
On Thu, 23 May 2013, Alan Stern wrote:
> On Thu, 23 May 2013, Thomas Pugliese wrote:
>
> > Hi,
> > I am attempting to get a wireless USB mass storage device to work with
> > an HWA as the host controller. Everything works fine as long as the SCSI
> > reads a
Hi,
I am attempting to get a wireless USB mass storage device to work with
an HWA as the host controller. Everything works fine as long as the SCSI
reads are smaller than 4kbytes. When the usb-storage driver receives the
first 16kB read, it breaks it up into 4-4kB URBs and sends it to the HWA
101 - 167 of 167 matches
Mail list logo
