RE: [PATCH] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

2016-04-26 Thread Yoshihiro Shimoda
Hi Geert-san, > From: Geert Uytterhoeven > Sent: Monday, April 25, 2016 11:57 PM > > Hi Shimoda-san, > > On Thu, Apr 21, 2016 at 2:57 PM, Geert Uytterhoeven > <ge...@linux-m68k.org> wrote: > > On Thu, Apr 21, 2016 at 12:27 PM, Yoshihiro Shimoda > > &

RE: [PATCH v2] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

2016-04-25 Thread Yoshihiro Shimoda
Hi Geert-san, > From: Geert Uytterhoeven > Sent: Monday, April 25, 2016 3:58 PM > > Hi Shimoda-san, > > On Mon, Apr 25, 2016 at 4:10 AM, Yoshihiro Shimoda > <yoshihiro.shimoda...@renesas.com> wrote: > >> From: Rob Herring > >> Sent: Friday, April 22,

RE: [PATCH v2] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

2016-04-24 Thread Yoshihiro Shimoda
Hi, > From: Rob Herring > Sent: Friday, April 22, 2016 10:29 PM > > On Fri, Apr 22, 2016 at 4:36 AM, Felipe Balbi > <felipe.ba...@linux.intel.com> wrote: > > > > Hi, > > > > Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes:

RE: [PATCH v2] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

2016-04-24 Thread Yoshihiro Shimoda
Hi, > From: Felipe Balbi > Sent: Friday, April 22, 2016 6:37 PM > > Hi, > > Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: > > The firmware of R-Car USB 3.0 host controller will control the reset. > > So, if the xhci driver doesn't

[PATCH v2] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

2016-04-22 Thread Yoshihiro Shimoda
Car H2 and M2 xHCI controllers) Cc: <sta...@vger.kernel.org> # v3.17+ Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- Changes from v1: - Revise the commit log. (http://www.spinics.net/lists/stable/msg130007.html) drivers/usb/host/xhci-rcar.h | 6 +- 1

RE: [PATCH] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

2016-04-22 Thread Yoshihiro Shimoda
Hi, > From: linux-renesas-soc-ow...@vger.kernel.org > [mailto:linux-renesas-soc-ow...@vger.kernel.org] On Behalf Of Yoshihiro > Shimoda > Sent: Thursday, April 21, 2016 7:28 PM > > Hi Felipe, > > > From: Felipe Balbi > > Sent: Thursday, April 21, 2016

RE: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

2016-04-21 Thread Yoshihiro Shimoda
Hi, > From: Peter Chen > Sent: Friday, April 22, 2016 12:34 PM > > On Fri, Apr 22, 2016 at 09:26:46AM +0800, Peter Chen wrote: > > On Fri, Apr 15, 2016 at 10:03:16AM +, Yoshihiro Shimoda wrote: > > > Hi, > > > > > > > From: Yoshihiro Shim

RE: [PATCH] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

2016-04-21 Thread Yoshihiro Shimoda
Hi Felipe, > From: Felipe Balbi > Sent: Thursday, April 21, 2016 7:19 PM > > Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: > > > Hi Felipe, > > > >> From: Felipe Balbi > >> Sent: Thursday, April 21, 2016 7:05 PM > >&

RE: [PATCH] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

2016-04-21 Thread Yoshihiro Shimoda
Hi Felipe, > From: Felipe Balbi > Sent: Thursday, April 21, 2016 7:05 PM > > Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: > > > If kernel configuration is CONFIG_USB_XHCI_PLATFORM=y and > > CONFIG_USB_XHCI_RCAR is not set, R-Car Gen2/3 will

[PATCH] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

2016-04-21 Thread Yoshihiro Shimoda
. Fixes: 4ac8918f3a7 (usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers) Cc: <sta...@vger.kernel.org> # v3.17+ Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/host/xhci-rcar.h | 6 +- 1 file changed, 5 insertions(+), 1 delet

RE: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

2016-04-19 Thread Yoshihiro Shimoda
Hi, > From: Peter Chen > Sent: Tuesday, April 19, 2016 6:18 PM > > On Fri, Apr 15, 2016 at 10:03:16AM +0000, Yoshihiro Shimoda wrote: > > Hi, > > > > > From: Yoshihiro Shimoda > > > Sent: Friday, April 15, 2016 6:59 PM > > > > > >

[PATCH 4/5] usb: renesas_usbhs: change arguments of dma_map_ctrl()

2016-04-18 Thread Yoshihiro Shimoda
Since usbhsg_dma_map_ctrl() needs DMA device structure in the near future, this patch changes arguments of dma_map_ctrl() to give such data. (This patch is only change the argument.) Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/renesas_usbhs/

[PATCH 5/5] usb: renesas_usbhs: use usb_gadget_{un}map_request_by_dev() for IPMMU

2016-04-18 Thread Yoshihiro Shimoda
{un}map_request_by_dev() APIs for IPMMU. (Then, iommus property should be set into USB-DMAC node(s).) Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/renesas_usbhs/mod_gadget.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drive

[PATCH 3/5] usb: renesas_usbhs: change function call orfer in usbhsf_dma_prepare_push()

2016-04-18 Thread Yoshihiro Shimoda
Since usbhsf_dma_{un}map() will use the "fifo" data in the near future, this patch changes function call orfer in usbhsf_dma_prepare_push(). Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/renesas_usbhs/fifo.c | 12 ++-- 1 file chang

[PATCH 2/5] usb: gadget: udc: core: add usb_gadget_{un}map_request_by_dev()

2016-04-18 Thread Yoshihiro Shimoda
to set a DMAC's device structure by a udc controller driver. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/gadget/udc/udc-core.c | 24 ++-- include/linux/usb/gadget.h| 4 2 files changed, 22 insertions(+), 6 del

[PATCH 1/5] usb: gadget: udc: core: Fix argument of dev_err() in usb_gadget_map_request()

2016-04-18 Thread Yoshihiro Shimoda
The argument of dev_err() in usb_gadget_map_request() should be dev instead of >dev. Fixes: 7ace8fc ("usb: gadget: udc: core: Fix argument of dma_map_single for IOMMU") Cc: <sta...@vger.kernel.org> # v4.3+ Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas

[PATCH 0/5] usb: gadget: add new APIs of udc-core and modify renesas_usbhs for IPMMU

2016-04-18 Thread Yoshihiro Shimoda
/gmane.linux.kernel.renesas-soc/2627 Yoshihiro Shimoda (5): usb: gadget: udc: core: Fix argument of dev_err() in usb_gadget_map_request() usb: gadget: udc: core: add usb_gadget_{un}map_request_by_dev() usb: renesas_usbhs: change function call orfer in usbhsf_dma_prepare_push() usb

RE: [PATCH] usb: renesas_usbhs: fix signed-unsigned return

2016-04-14 Thread Yoshihiro Shimoda
p_pipecfg() prototype is changed like the following? static int usbhsp_setup_pipecfg(struct usbhs_pipe *pipe, int is_host, int dir_in, u16 *pipecfg); Best regards, Yoshihiro Shimoda > Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> >

RE: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

2016-04-14 Thread Yoshihiro Shimoda
Hi, > From: Roger Quadros > Sent: Monday, April 11, 2016 7:55 PM > > On 08/04/16 14:22, Yoshihiro Shimoda wrote: > > Hi, > > > >> From: Roger Quadros > >> Sent: Thursday, April 07, 2016 8:45 PM > >> > >> Hi, > >> > >>

[PATCH] usb: host: xhci-plat: add firmware for the R-Car M3-W xHCI controllers

2016-04-12 Thread Yoshihiro Shimoda
might not work correctly. So, we would like to keep the v1 and v2 firmware. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- WHENCE| 3 ++- r8a779x_usb3_v3.dlmem | Bin 0 -> 9472 bytes 2 files changed, 2 insertions(+), 1 deletion(-) create mo

RE: [PATCH] usb: host: xhci-plat: add firmware for the R-Car M3 xHCI controllers

2016-04-12 Thread Yoshihiro Shimoda
Hi Geert-san, > -Original Message- > From: geert.uytterhoe...@gmail.com [mailto:geert.uytterhoe...@gmail.com] On > Behalf Of Geert Uytterhoeven > Sent: Tuesday, April 12, 2016 3:55 PM > To: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> > Cc: linux-firmw

[PATCH] usb: host: xhci-plat: add firmware for the R-Car M3 xHCI controllers

2016-04-12 Thread Yoshihiro Shimoda
might not work correctly. So, we would like to keep the v1 and v2 firmware. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- WHENCE| 3 ++- r8a779x_usb3_v3.dlmem | Bin 0 -> 9472 bytes 2 files changed, 2 insertions(+), 1 deletion(-) create mo

RE: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

2016-04-08 Thread Yoshihiro Shimoda
Hi, > From: Roger Quadros > Sent: Thursday, April 07, 2016 8:45 PM > > Hi, > > On 07/04/16 11:52, Yoshihiro Shimoda wrote: > > Hi, > > > >> From: Roger Quadros > >> Sent: Tuesday, April 05, 2016 11:05 PM < snip > > > diff --git a

RE: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

2016-04-07 Thread Yoshihiro Shimoda
HCI. For example of xHCI: - otg->hcds[0] = primary_hcd - otg->hcds[1] = shared_hcd For example of EHCI/OHCI: - otg->hcds[0] = primary_hcd of EHCI - otg->hcds[1] = primary_hcd of OHCI Best regards, Yoshihiro Shimoda -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH v6 12/12] usb: host: xhci-plat: Add otg device to platform data

2016-04-05 Thread Yoshihiro Shimoda
ev); > + > + if (pdata->otg_dev) Ditto. > + usb_otg_remove_hcd(xhci->shared_hcd); > + else > + usb_remove_hcd(xhci->shared_hcd); > > - usb_remove_hcd(xhci->shared_hcd); > usb_phy_shutdown(hcd->usb_phy); > > - usb_remove_hcd(h

[PATCH/RFC 4/5] usb: renesas_usbhs: change arguments of dma_map_ctrl()

2016-04-05 Thread Yoshihiro Shimoda
In near the future, since usbhsg_dma_map_ctrl() needs DMA device structure, this patch changes arguments of dma_map_ctrl() to give such data. (This patch is only change the argument.) Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/renesas_usbhs/

[PATCH/RFC 5/5] usb: renesas_usbhs: use usb_gadget_{un}map_request_by_dev() for IPMMU

2016-04-05 Thread Yoshihiro Shimoda
{un}map_request_by_dev() APIs for IPMMU. (Then, iommus property should be set into USB-DMAC node(s).) Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/renesas_usbhs/mod_gadget.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drive

[PATCH/RFC 1/5] usb: gadget: udc: core: Fix argument of dev_err() in usb_gadget_map_request()

2016-04-05 Thread Yoshihiro Shimoda
The argument of dev_err() in usb_gadget_map_request() should be dev instead of >dev. Fixes: 7ace8fc ("usb: gadget: udc: core: Fix argument of dma_map_single for IOMMU") Cc: <sta...@vger.kernel.org> # v4.3+ Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas

[PATCH/RFC 2/5] usb: gadget: udc: core: add usb_gadget_{un}map_request_by_dev()

2016-04-05 Thread Yoshihiro Shimoda
to set a DMAC's device structure by a udc controller driver. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/gadget/udc/udc-core.c | 24 ++-- include/linux/usb/gadget.h| 4 2 files changed, 22 insertions(+), 6 del

[PATCH/RFC 3/5] usb: renesas_usbhs: change function call orfer in usbhsf_dma_prepare_push()

2016-04-05 Thread Yoshihiro Shimoda
In near the future, since usbhsf_dma_{un}map() will use the "fifo" data, this patch changes function call orfer in usbhsf_dma_prepare_push(). Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/renesas_usbhs/fifo.c | 12 ++-- 1 file chang

[PATCH/RFC 0/5] usb: gadget: add new APIs of udc-core and modify renesas_usbhs for IPMMU

2016-04-05 Thread Yoshihiro Shimoda
This patch set is based on the latest Felipe's usb.git / testing/next branch. (commit id = eac6b9922641f88a7da87a145d6ad9bed706c9ec) I'm not sure this is a right way for using IOMMU driver on udc driver. So, I marked this patch set as RFC :) Yoshihiro Shimoda (5): usb: gadget: udc: core: Fix

RE: [PATCH] usb: gadget: udc-core: remove manual dma configuration

2016-04-05 Thread Yoshihiro Shimoda
ce manually, because all DMA operation are performed > using parent/controller device. > > Cc: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> > Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> My environment could work correctly after I applied this patch.

[PATCH] usb: renesas_usbhs: fix to avoid using a disabled ep in usbhsg_queue_done()

2016-04-04 Thread Yoshihiro Shimoda
ger.kernel.org> # v3.1+ Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/renesas_usbhs/mod_gadget.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.

RE: [PATCH v2 5/6] usb: host: xhci: plat: make use of new methods in xhci_plat_priv

2016-03-30 Thread Yoshihiro Shimoda
Hi, > Sent: Wednesday, March 30, 2016 2:59 PM > > Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: > > [ text/plain ] > > Hi Felipe, > > > > Thank you for the patch! > > hey, no problem :-) > > >> Sent: Tuesday, Marc

RE: [PATCH v2 5/6] usb: host: xhci: plat: make use of new methods in xhci_plat_priv

2016-03-29 Thread Yoshihiro Shimoda
priv xhci_plat_renesas_rcar_gen2 = { .type = XHCI_PLAT_TYPE_RENESAS_RCAR_GEN2, .firmware_name = XHCI_RCAR_FIRMWARE_NAME_V1, .init_quirk = xhci_rcar_init_quirk, .plat_start = xhci_rcar_start, }; Best regards, Yoshihiro Shimoda -- To unsubscribe from this list: send the lin

RE: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value

2016-03-28 Thread Yoshihiro Shimoda
Hi, > Sent: Monday, March 28, 2016 5:30 PM > > Hi, > > Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: > >> > ps: there might be bugs there, but it's a holiday and I really shouldn't > >> > be spending time on this right now ;-) >

RE: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value

2016-03-28 Thread Yoshihiro Shimoda
Hi, > Sent: Saturday, March 26, 2016 6:11 PM < snip > > > ps: there might be bugs there, but it's a holiday and I really shouldn't > > be spending time on this right now ;-) > > I'm also off on holiday now until Sunday 10th April... yay :-) > > > > Anyway, have fun testing. Let me know if it

RE: [PATCH v2 0/2] usb: renesas_usbhs: fix to avoid unexpected condition

2016-03-22 Thread Yoshihiro Shimoda
Hi Felipe-san, > From: Felipe Balbi [mailto:ba...@kernel.org] > Sent: Tuesday, March 22, 2016 4:16 PM > > Yoshihiro-san, > > Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: > >> From: Yoshihiro Shimoda > >> Sent: Thursday, March 10, 2016

RE: [PATCH v2 0/2] usb: renesas_usbhs: fix to avoid unexpected condition

2016-03-22 Thread Yoshihiro Shimoda
Hi Felipe, > From: Yoshihiro Shimoda > Sent: Thursday, March 10, 2016 11:30 AM > > This patch set is based on the latest Felipe's usb.git / testing/next branch. > (commit id = ac5706631325ae3695bfa1527101ab2b2f64859f) Would you review the patch set? I confirmed that the

[PATCH v3 2/2] usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB phys

2016-03-14 Thread Yoshihiro Shimoda
This patch fixes an issue that cannot work if R-Car Gen2/3 run on above 4GB physical memory environment to use a quirk XHCI_NO_64BIT_SUPPORT. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/host/xhci-plat.c | 13 + 1 file changed, 13 inse

[PATCH v3 0/2] usb: host: xhci: add a new quirk and fix an issue for R-Car Gen2/3

2016-03-14 Thread Yoshihiro Shimoda
new quirk "XHCI_CLEAR_AC64" for using it on some PCIe card. http://thread.gmane.org/gmane.linux.kernel.renesas-soc/858/focus=1694 Yoshihiro Shimoda (2): usb: host: xhci: add a new quirk XHCI_NO_64BIT_SUPPORT usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB

[PATCH v3 1/2] usb: host: xhci: add a new quirk XHCI_NO_64BIT_SUPPORT

2016-03-14 Thread Yoshihiro Shimoda
controller will be died after a usb device is connected if it runs on above 4GB physical memory environment. So, this patch adds a new quirk XHCI_NO_64BIT_SUPPORT to resolve such an issue. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/host/xhci.

RE: [PATCH v2 2/2] usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB phys

2016-03-14 Thread Yoshihiro Shimoda
Hi, > Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: > > > [ text/plain ] > > This patch fixes an issue that cannot work if R-Car Gen2/3 run on > > above 4GB physical memory environment to use a quirk XHCI_CLEAR_AC64. > > > > Signed-of

RE: [PATCH v2 1/2] usb: host: xhci: add a new quirk XHCI_CLEAR_AC64

2016-03-14 Thread Yoshihiro Shimoda
Hi, > Hi, > > Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: > > [ text/plain ] > > On some xHCI controllers (e.g. R-Car SoCs), the AC64 bit (bit 0) of > > HCCPARAMS1 is set to 1. However, the xHCs don't support 64-bit > > address mem

[PATCH v2 1/2] usb: host: xhci: add a new quirk XHCI_CLEAR_AC64

2016-03-09 Thread Yoshihiro Shimoda
controller will be died after a usb device is connected if it runs on above 4GB physical memory environment. So, this patch adds a new quirk XHCI_CLEAR_AC64 to resolve such an issue. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/host/xhci.

[PATCH v2 2/2] usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB phys

2016-03-09 Thread Yoshihiro Shimoda
This patch fixes an issue that cannot work if R-Car Gen2/3 run on above 4GB physical memory environment to use a quirk XHCI_CLEAR_AC64. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/host/xhci-plat.c | 7 +++ 1 file changed, 7 insertions(+) diff

[PATCH v2 0/2] usb: host: xhci: add a new quirk and fix an issue for R-Car Gen2/3

2016-03-09 Thread Yoshihiro Shimoda
This patch set is based on the latest usb.git / usb-next branch. (commit id = ace53bfc4374cada8b645765e2b4ad5831e760932) Changes from v1: - Add a new quirk "XHCI_CLEAR_AC64" for using it on some PCIe card. http://thread.gmane.org/gmane.linux.kernel.renesas-soc/858/focus=1694

[PATCH v2 2/2] usb: renesas_usbhs: disable TX IRQ before starting TX DMAC transfer

2016-03-09 Thread Yoshihiro Shimoda
v3.1+ Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/renesas_usbhs/fifo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers/usb/renesas_usbhs/fifo.c index 0c25c01..000f975 100644 --- a/drivers/usb/renesas_usbhs/fi

[PATCH v2 0/2] usb: renesas_usbhs: fix to avoid unexpected condition

2016-03-09 Thread Yoshihiro Shimoda
-> IRQ - typo: heppen -> happen Yoshihiro Shimoda (2): usb: renesas_usbhs: avoid NULL pointer derefernce in usbhsf_pkt_handler() usb: renesas_usbhs: disable TX IRQ before starting TX DMAC transfer drivers/usb/renesas_usbhs/fifo.c | 4 +++- 1 file changed, 3 insertion

[PATCH v2 1/2] usb: renesas_usbhs: avoid NULL pointer derefernce in usbhsf_pkt_handler()

2016-03-09 Thread Yoshihiro Shimoda
h adds a condition to avoid the dereference. Fixes: e73a989 ("usb: renesas_usbhs: add DMAEngine support") Cc: <sta...@vger.kernel.org> # v3.1+ Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/renesas_usbhs/fifo.c | 3 ++- 1 file changed,

RE: [PATCH 2/2] usb: renesas_usbhs: disable tx irq before starting TX DMAC transfer

2016-03-09 Thread Yoshihiro Shimoda
Hello, > Hello. > > On 3/8/2016 8:58 AM, Yoshihiro Shimoda wrote: > > > This patch adds a code to surely disable tx irq of the pipe before > > TX IRQ. > > > starting TX DMAC transfer. Otherwise, a lot of unnecessary tx irqs > > TX IRQs

RE: [PATCH 1/2] usb: renesas_usbhs: avoid NULL pointer derefernce in usbhsf_pkt_handler()

2016-03-09 Thread Yoshihiro Shimoda
Hi, > > Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: > >> Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: > >> > This patch adds a condition to avoid the dereference. > >> > > >> > Sig

RE: [PATCH] usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB phys

2016-03-09 Thread Yoshihiro Shimoda
the AC64 bit of xhci->hcc_params in the > >> xhci_plat_quirks() to fix the issue. > >> > >> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> > >> --- > >> drivers/usb/host/xhci-plat.c | 13 + > >> 1 file

RE: [PATCH 1/2] usb: renesas_usbhs: avoid NULL pointer derefernce in usbhsf_pkt_handler()

2016-03-09 Thread Yoshihiro Shimoda
Hi Felipe, > Hi Yoshihiro, > > Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: > > [ text/plain ] > > When unexpected situation happened (e.g. tx/rx irq happened while > > DMAC is used), the usbhsf_pkt_handler() was possible to cause NULL > >

RE: [PATCH] usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB phys

2016-03-09 Thread Yoshihiro Shimoda
Hi Mathias, Would you review this patch? This patch could be applied into the latest usb.git / usb-next branch. Best regards, Yoshihiro Shimoda > -Original Message- > From: Yoshihiro Shimoda > Sent: Tuesday, February 16, 2016 12:26 PM > To: mathias.ny...@in

[PATCH 0/2] usb: renesas_usbhs: fix to avoid unexpected condition

2016-03-07 Thread Yoshihiro Shimoda
This patch set is based on the latest Felipe's usb.git / testing/next branch. (commit id = ac5706631325ae3695bfa1527101ab2b2f64859f) Yoshihiro Shimoda (2): usb: renesas_usbhs: avoid NULL pointer derefernce in usbhsf_pkt_handler() usb: renesas_usbhs: disable tx irq before starting TX DMAC

[PATCH 2/2] usb: renesas_usbhs: disable tx irq before starting TX DMAC transfer

2016-03-07 Thread Yoshihiro Shimoda
This patch adds a code to surely disable tx irq of the pipe before starting TX DMAC transfer. Otherwise, a lot of unnecessary tx irqs may heppen in rare cases when DMAC is used. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/renesas_usbhs/fifo.c | 1 +

[PATCH 1/2] usb: renesas_usbhs: avoid NULL pointer derefernce in usbhsf_pkt_handler()

2016-03-07 Thread Yoshihiro Shimoda
h adds a condition to avoid the dereference. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/renesas_usbhs/fifo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers/usb/renesas_usbhs/fifo.c i

[PATCH/RESEND] usb: renesas_usbhs: gadget: fix giveback status code in usbhsg_pipe_disable()

2016-03-03 Thread Yoshihiro Shimoda
A udc driver should set the giveback status to -ESHUTDOWN in usb_ep_disable(). Otherwise, a gadget driver (e.g. g_serial) might request next data wrongly and it is possible to cause kernel panic. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/renesas

RE: [PATCH] usb: renesas_usbhs: gadget: fix giveback status code in usbhsg_pipe_disable()

2016-03-03 Thread Yoshihiro Shimoda
Hi Felipe, > From: Felipe Balbi [mailto:ba...@kernel.org] > Sent: Thursday, March 03, 2016 6:22 PM > > Hi Yoshihiro, > > Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: > > [ text/plain ] > > Hi Felipe, > > > > Oops, I completely fo

RE: [PATCH] usb: gadget: renesas_usb3: Use ARCH_RENESAS

2016-03-03 Thread Yoshihiro Shimoda
ation for which being that RENESAS seems to be a more > appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. > > Signed-off-by: Simon Horman <horms+rene...@verge.net.au> Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> Best regards, Yoshihir

RE: [PATCH] usb: renesas_usbhs: gadget: fix giveback status code in usbhsg_pipe_disable()

2016-03-02 Thread Yoshihiro Shimoda
Hi Felipe, Oops, I completely forgot this patch. Would you review this patch? Or should I resend it? I confirmed that this patch could be applied on your latest testing/fixes branch. Best regards, Yoshihiro Shimoda > -Original Message- > From: Yoshihiro Shimoda > Sent: Friday,

[PATCH] usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB phys

2016-02-15 Thread Yoshihiro Shimoda
after a usb device is connected if R-Car Gen2/3 run on above 4GB physical memory environment. This patch adds clearing the AC64 bit of xhci->hcc_params in the xhci_plat_quirks() to fix the issue. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/host/xh

[PATCH] usb: renesas_usbhs: Don't check CSSTS bit if peripheral mode

2016-02-04 Thread Yoshihiro Shimoda
Since Some SoCs (e.g. R-Car Gen2) don't have the CSSTS bit in the pipectrl registers ({DCP,PIPEn}CTR) because such SoCs have peripheral mode only. So, this driver should not check the CSSTS bit if peripheral mode is running. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.

RE: [PATCH] usb: renesas_usbhs: add R-Car Gen3 power control

2016-02-04 Thread Yoshihiro Shimoda
depend on this patch) soon. Best regards, Yoshihiro Shimoda > -Original Message- > From: Yoshihiro Shimoda > Sent: Thursday, January 07, 2016 6:18 PM > To: gre...@linuxfoundation.org; ba...@ti.com > Cc: linux-usb@vger.kernel.org; linux...@vger.kernel.org; Yo

RE: [PATCH] usb: renesas_usbhs: constify usbhs_pkt_handle structures

2016-01-06 Thread Yoshihiro Shimoda
Coccinelle. > > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Thank you for the patch! Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> Best regards, Yoshihiro Shimoda -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the

[PATCH] usb: renesas_usbhs: gadget: fix giveback status code in usbhsg_pipe_disable()

2015-12-25 Thread Yoshihiro Shimoda
A udc driver should set the giveback status to -ESHUTDOWN in usb_ep_disable(). Otherwise, a gadget driver (e.g. g_serial) might request next data wrongly and it is possible to cause kernel panic. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- This patch is

RE: [PATCH v2] usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller

2015-12-21 Thread Yoshihiro Shimoda
Hi Rob, > From: Rob Herring [mailto:r...@kernel.org] > Sent: Saturday, December 19, 2015 1:20 PM > > On Wed, Dec 16, 2015 at 11:51:59AM +0900, Yoshihiro Shimoda wrote: > > R-Car H3 has USB3.0 peripheral controllers. This controller's has the > > following features: >

[PATCH v3] usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller

2015-12-21 Thread Yoshihiro Shimoda
-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- This patch is based on the latest Felipe's usb.git / testing/next branch. (commit id = e9284de9fae69f1d5e57a4817bfc36dc5f3adf71) Changes from v2: - Fix compatible string order to "-". Changes from v1: - fix build error in

RE: [PATCH] usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller

2015-12-15 Thread Yoshihiro Shimoda
Hi Arnd, Thank you very much for your review! > From: Arnd Bergmann > Sent: Tuesday, December 15, 2015 6:30 PM > > On Tuesday 15 December 2015 15:54:32 Yoshihiro Shimoda wrote: > > R-Car H3 has USB3.0 peripheral controllers. This controller's has the > > following f

RE: [PATCH] usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller

2015-12-15 Thread Yoshihiro Shimoda
Hi Arnd again, > From: Yoshihiro Shimoda > Sent: Wednesday, December 16, 2015 10:43 AM < snip > > > > +static void usb3_write(struct renesas_usb3 *usb3, u32 data, u32 offs) > > > +{ > > > + iowrite32(data, usb3->reg + offs); > > > +} > >

[PATCH v2] usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller

2015-12-15 Thread Yoshihiro Shimoda
-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- This patch is based on the latest Felipe's usb.git / testing/next branch. (commit id = e9284de9fae69f1d5e57a4817bfc36dc5f3adf71) Changes from v1: - fix build error in i386 environment if COMPILE_TEST=y - merge the header file code into

[PATCH] usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller

2015-12-14 Thread Yoshihiro Shimoda
-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- This patch is based on the latest Felipe's usb.git / testing/next branch. (commit id = e9284de9fae69f1d5e57a4817bfc36dc5f3adf71) .../devicetree/bindings/usb/renesas_usb3.txt | 23 + drivers/usb/gadget/udc/K

RE: [PATCH 1/3] usb: renesas_usbhs: gadget: Fix NULL pointer dereference in usbhsg_ep_dequeue()

2015-11-17 Thread Yoshihiro Shimoda
Hi, > From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Wednesday, November 18, 2015 12:32 AM > > Hi, > > Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: > > This patch fixes an issue that NULL pointer dereference happens when > > a gadget

[PATCH v2] usb: renesas_usbhs: gadget: Fix NULL pointer dereference in usbhsg_ep_dequeue()

2015-11-17 Thread Yoshihiro Shimoda
ULL. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- This patch is based on the latest Felipe's usb.git / testing/fixes branch. (commit id = 455bfac5ad0a6394835ab10fad68f5ce3053160b) Perhaps this issue has existed from the first gadget support in this driver... Change

[PATCH v2 0/3] usb: renesas_usbhs: gadget: modifications for g_audio

2015-11-17 Thread Yoshihiro Shimoda
This patch is based on the latest Felipe's usb.git / testing/next branch. (The commit id = 81e9d14a53eb1abfbe6ac828a87a2deb4702b5f1) Changes from v1: - Rebase the latest usb.git testing/next branch. - Separate other one patch. (In other words, that patch is for bugfix.) Yoshihiro Shimoda (2

[PATCH v2 2/2] usb: renesas_usbhs: Modify ep.caps.type_xxx and usb_ep_maxpacket_limit()

2015-11-17 Thread Yoshihiro Shimoda
should set correct type. Also the second argument of usb_ep_maxpacket_limit() was set to 512 even if the pipe is isochronous or interrupt. So, this driver could not bind a gadget driver like the g_audio driver. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drive

[PATCH v2 1/2] usb: renesas_usbhs: Modify pipe configuration

2015-11-17 Thread Yoshihiro Shimoda
tch modifies the pipe configuration via struct renesas_usbhs_driver_param to simplify the code. Also this patch changes: - a double buffer configuration - isochronous buffer size from 512 to 1024 Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/rene

[PATCH 3/3] usb: renesas_usbhs: Modify ep.caps.type_xxx and usb_ep_maxpacket_limit()

2015-11-11 Thread Yoshihiro Shimoda
should set correct type. Also the second argument of usb_ep_maxpacket_limit() was set to 512 even if the pipe is isochronous or interrupt. So, this driver could not bind a gadget driver like the g_audio driver. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drive

[PATCH 1/3] usb: renesas_usbhs: gadget: Fix NULL pointer dereference in usbhsg_ep_dequeue()

2015-11-11 Thread Yoshihiro Shimoda
This patch fixes an issue that NULL pointer dereference happens when a gadget driver calls usb_ep_dequeue() after usb_ep_disable(). Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/renesas_usbhs/mod_gadget.c | 11 +-- 1 file changed, 9 insertions

[PATCH 2/3] usb: renesas_usbhs: Modify pipe configuration

2015-11-11 Thread Yoshihiro Shimoda
tch modifies the pipe configuration via struct renesas_usbhs_driver_param to simplify the code. Also this patch changes: - a double buffer configuration - isochronous buffer size from 512 to 1024 Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/rene

[PATCH 0/3] usb: renesas_usbhs: gadget: modifications for g_audio

2015-11-11 Thread Yoshihiro Shimoda
This patch is based on the latest Felipe's usb.git / testing/next branch. (The commit id = 81e9d14a53eb1abfbe6ac828a87a2deb4702b5f1) Yoshihiro Shimoda (3): usb: renesas_usbhs: gadget: Fix NULL pointer dereference in usbhsg_ep_dequeue() usb: renesas_usbhs: Modify pipe configuration usb

[PATCH v3 6/7] usb: host: xhci-plat: add support for the R-Car M2-N xHCI controller

2015-10-26 Thread Yoshihiro Shimoda
This patch adds support for R-Car M2-N (r8a7793) xHCI controller. This SoC is compatible with R-Car H2 (r8a7790) and R-Car M2-W (r8a7791). Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- Documentation/devicetree/bindings/usb/usb-xhci.txt | 4 ++-- drivers/usb/hos

[PATCH v3 2/7] usb: host: xhci: add a platform-private field

2015-10-26 Thread Yoshihiro Shimoda
This patch adds an xhci->priv field for private use by XHCI platform drivers. Until now none of the platform drivers has used this private space. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/host/xhci.h | 3 +++ 1 file changed, 3 insertions(+) d

RE: [PATCH v3 1/7] usb: host: xhci: fix hcd private size

2015-10-26 Thread Yoshihiro Shimoda
Hi, > From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Monday, October 26, 2015 11:27 PM > > Hi, > > Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: > > This patch fixes the hcd

[PATCH v4 1/7] usb: host: xhci: cleanup hcd private size

2015-10-26 Thread Yoshihiro Shimoda
struct xhcd_hcd)" memory space in each hcd (main_hcd and shared_hcd) actually. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/host/xhci-pci.c | 1 - drivers/usb/host/xhci-plat.c | 1 - drivers/usb/host/xhci.c | 2 +- 3 files changed, 1 insertion(+),

[PATCH v4 0/7] usb: host: xhci-plat: add support for the R-Car M2-N and H3 xHCI controllers

2015-10-26 Thread Yoshihiro Shimoda
xhci_hcd from const pointer to priv[0]. Changes from v1: - Add "const void *priv" in struct xhci_hcd to simplify the code to match platform specific variables using of_device_id.data. To achieve this purpose, this patch set made patch 1 to 3. Yoshihiro Shimoda (7): usb: host:

[PATCH v4 5/7] usb: host: xhci-rcar: Change code for new SoCs

2015-10-26 Thread Yoshihiro Shimoda
This patch changes code to ease the addition of next generation SoCs. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/host/xhci-plat.c | 1 + drivers/usb/host/xhci-rcar.c | 37 +++-- drivers/usb/host/xhci-rcar.h | 2

[PATCH v4 4/7] usb: host: xhci-plat: add firmware_name in xhci_plat_priv

2015-10-26 Thread Yoshihiro Shimoda
This patch adds a member "firmware_name" in struct xhci_plat_priv to simplify the code to match specific firmware name. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/host/xhci-plat.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drive

[PATCH v4 7/7] usb: host: xhci-plat: add support for the R-Car H3 xHCI controllers

2015-10-26 Thread Yoshihiro Shimoda
The R-Car H3 has two xHCI controllers. This SoC is compatible with R-Car Gen2 SoCs, however this SoC doesn't need some specific registers setting, and need a new firmware. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- Documentation/devicetree/bindings/usb/usb-xh

[PATCH v4 6/7] usb: host: xhci-plat: add support for the R-Car M2-N xHCI controller

2015-10-26 Thread Yoshihiro Shimoda
This patch adds support for R-Car M2-N (r8a7793) xHCI controller. This SoC is compatible with R-Car H2 (r8a7790) and R-Car M2-W (r8a7791). Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- Documentation/devicetree/bindings/usb/usb-xhci.txt | 4 ++-- drivers/usb/hos

[PATCH v4 3/7] usb: host: xhci-plat: add struct xhci_plat_priv

2015-10-26 Thread Yoshihiro Shimoda
This patch adds struct xhci_plat_priv to simplify the code to match platform specific variables. For now, this patch adds a member "type" in the structure. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/host/

[PATCH v4 2/7] usb: host: xhci: add a platform-private field

2015-10-26 Thread Yoshihiro Shimoda
This patch adds an xhci->priv field for private use by XHCI platform drivers. Until now none of the platform drivers has used this private space. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/host/xhci.h | 3 +++ 1 file changed, 3 insertions(+) d

RE: [PATCH v2 1/6] usb: host: xhci: add a platform-private pointer field

2015-10-22 Thread Yoshihiro Shimoda
Hi Greg, > From: Yoshihiro Shimoda > Sent: Monday, October 19, 2015 6:11 PM > > Hi Greg, > > > Sent: Saturday, October 17, 2015 3:38 PM > > > > On Wed, Oct 07, 2015 at 08:38:53PM +0900, Yoshihiro Shimoda wrote: > > > This patch adds an xhci->

RE: [PATCH v2 1/6] usb: host: xhci: add a platform-private pointer field

2015-10-19 Thread Yoshihiro Shimoda
Hi Greg, > Sent: Saturday, October 17, 2015 3:38 PM > > On Wed, Oct 07, 2015 at 08:38:53PM +0900, Yoshihiro Shimoda wrote: > > This patch adds an xhci->priv field for storing the of_device_id.data > > pointer. This will simplify the code to match platform specific >

[PATCH v2 3/6] usb: host: xhci-plat: add firmware_name in xhci_plat_priv

2015-10-07 Thread Yoshihiro Shimoda
This patch adds a member "firmware_name" in struct xhci_plat_priv to simplify the code to match specific firmware name. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/host/xhci-plat.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drive

[PATCH v2 1/6] usb: host: xhci: add a platform-private pointer field

2015-10-07 Thread Yoshihiro Shimoda
This patch adds an xhci->priv field for storing the of_device_id.data pointer. This will simplify the code to match platform specific variables (e.g. platform type and firmware name). Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/host/xhci.h | 3 ++

[PATCH v2 2/6] usb: host: xhci-plat: add struct xhci_plat_priv

2015-10-07 Thread Yoshihiro Shimoda
This patch adds struct xhci_plat_priv to simplify the code to match platform specific variables. For now, this patch adds a member "type" in the structure. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/usb/host/

[PATCH v2 0/6] usb: host: xhci-plat: add support for the R-Car M2-N and H3 xHCI controllers

2015-10-07 Thread Yoshihiro Shimoda
b0960bcb85.) Changes from v1: - Add "const void *priv" in struct xhci_hcd to simplify the code to match platform specific variables using of_device_id.data. To achieve this purpose, this patch set made patch 1 to 3. Yoshihiro Shimoda (6): usb: host: xhci: add a platform-private

RE: [PATCH 1/3] usb: renesas_usbhs: Remove unneeded #include

2015-10-07 Thread Yoshihiro Shimoda
! > --- I'm not sure my Acked-by is useful for it :) Anyway, Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> Best regards, Yoshihiro Shimoda > drivers/usb/renesas_usbhs/rcar2.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/renesas_u

<    1   2   3   4   5   6   7   >