Linus Walleij writes:
> This makes it possible to instantiate the PXA25x UDC
> driver from the device tree.
>
> Cc: Robert Jarzmik
> Signed-off-by: Linus Walleij
> ---
> drivers/usb/gadget/udc/pxa25x_udc.c | 11 +++
> 1 file changed, 11 insertions(+)
Mmmh
all, so remove
> those variables from the device structure.
>
> Cc: Daniel Mack
> Cc: Haojian Zhuang
> Cc: Robert Jarzmik
> Cc: Felipe Balbi
> Signed-off-by: Greg Kroah-Hartman
Acked-by: Robert Jarzmik
Cheers.
--
Robert
--
To unsubscribe from this list: send the line &quo
Andy Shevchenko writes:
> ...instead of open coding file operations followed by custom ->open()
> callbacks per each attribute.
>
> Cc: Daniel Mack
> Cc: Haojian Zhuang
> Cc: Robert Jarzmik
> Signed-off-by: Andy Shevchenko
Acked-by: Robert Jarzmik
Cheers.
--
Rober
Andy Shevchenko writes:
> ...instead of open coding file operations followed by custom ->open()
> callbacks per each attribute.
>
> Cc: Daniel Mack
> Cc: Haojian Zhuang
> Cc: Robert Jarzmik
> Signed-off-by: Andy Shevchenko
Acked-by: Robert Jarzmik
Cheers.
--
Rober
t is updated a few statements later, this too is
> redundant and can be removed. Cleans up clan warnings:
>
> drivers/usb/gadget/udc/pxa27x_udc.c:986:3: warning: Value stored
> to 'is_short' is never read
> drivers/usb/gadget/udc/pxa27x_udc.c:1141:2: warning: Value stored
> to
> Cc: Nicolas Ferre
> Cc: Kevin Cernekee
> Cc: Florian Fainelli
> Cc: Li Yang
> Cc: Vladimir Zapolskiy
> Cc: Sylvain Lemieux
> Cc: Daniel Mack
> Cc: Haojian Zhuang
> Cc: Robert Jarzmik
> Cc: Michal Simek
> Cc: "Sören Brinkmann"
> Cc: Raviteja Ga
Petr Cvek writes:
> A call usb_put_phy(udc->transceiver) must be tested for a valid pointer.
> Use an already existing test for usb_unregister_notifier call.
>
> Reported-by: Robert Jarzmik
> Signed-off-by: Petr Cvek
Acked-by: Robert Jarzmik
Cheers.
--
Robert
--
To uns
Petr Cvek writes:
> Functions udc_enable() and udc_disable() have a duplicated prototype.
> Remove it.
>
> Signed-off-by: Petr Cvek
Acked-by: Robert Jarzmik
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body
Petr Cvek writes:
> Remove duplicated function declaration for udc_enable() and udc_disable().
The patch title looks a bit tool long to me, and that also applied to your
second one.
Moreover the correct prefix for this driver (for the title) is :
usb: gadget: pxa27x: MySuperSyntheticTi
Petr Cvek writes:
> Move call usb_put_phy(udc->transceiver) inside a valid pointer test.
>
> Reported-by: robert.jarz...@free.fr
I'd rather have my normal signature here :
Reported-by: Robert Jarzmik
> Signed-off-by: Petr Cvek
Acked-by: Robert Jarzmik
Cheers.
--
Robe
fied as !in_interrupt())
> seems to work fine
> (after torture reloads). Can the caller (udc core) be changed to be able to
> sleep?
This question is for Felipe. From the several years back when I wrote this code
I think it was granted that the pullup() callback was not in interrupt conte
Petr Cvek writes:
> Dne 12.2.2017 v 13:02 Robert Jarzmik napsal(a):
> That's weird I even removed pxa_set_udc_info() from magician machine init and
> it still fails.
> Host cable and/or actual camera is not required. It fails without them.
>
> So you binded pxa27
Petr Cvek writes:
> Hi
>
> any news?
Yeah, I don't have the error on my mainstone, which kind of hinders my debug
capability.
I have tried your script, and this is what I get :
- dmesg | tail
random: crng init done
gadgetfs: USB Gadget filesystem, version 24 Aug 2004
c
Petr Cvek writes:
> Setting the UVC gadget with configfs and then reloading UDC controler driver
> (pxa27x_udc) causes kernel to fail.
>
> UDC subsystem was patched only in decreasing maxpacket size for UVC, addition
> of more predefined endpoints for pxa27x_udc and addition of some debugging
>
script)
For pxa27x_udc.c :
Acked-by: Robert Jarzmik
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Joe Perches writes:
> Use the more common logging mechanism.
>
> Miscellanea:
>
> o Realign multiline statements
> o Coalesce format
>
> Signed-off-by: Joe Perches
For pxa25x_udc.h:
Acked-by: Robert Jarzmik
Cheers.
--
Robert
--
To unsubscribe from this list: send the
Felipe Balbi writes:
> Hi Robert,
>
> Robert Jarzmik writes:
>> Felipe Balbi writes:
>>
>>> Hi,
>>>
>>> Robert Jarzmik writes:
>>>> I don't know if there are other users than pxa, I'll make the assumption
>>>>
not necessary anymore.
Signed-off-by: Robert Jarzmik
---
drivers/usb/phy/phy-generic.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c
index 41b8aff9b925..c14e767a3fbf 100644
--- a/drivers/usb/phy/phy
e gadget will be aware it should
answer enumeration and go forth
Without this fix, the USB cable must be removed and replugged for any
gadget relying on phy-generic and its gpio vbus handling to work.
The problem was seen on a pxa27x architecture based board on a
devicetree build.
Signed-off-by
devicetree platforms, we'll rely on the probe deferral, and
the phy can be gadget API agnostic.
Signed-off-by: Robert Jarzmik
---
drivers/usb/gadget/udc/pxa27x_udc.c | 51 +++--
1 file changed, 49 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/u
Felipe Balbi writes:
> Hi,
>
> Robert Jarzmik writes:
>> I don't know if there are other users than pxa, I'll make the assumption
>> there
>> aren't.
>
> yeah, we can keep patches in linux-next for as long as possible. If
> nobody complains, w
Felipe Balbi writes:
>> - amend the drivers (for my part I have pxa27x_udc.c and probably
>> pxa25x_udc.c)
>> to subscribe to the notifier, and in the action function call either
>> usb_gadget_vbus_connect() or usb_gadget_vbus_disconnect().
>>
>> Would that kind of approach solve the layering
Felipe Balbi writes:
> Hi Robert,
>
> your commit 7acc9973e3c4 ("usb: phy: generic: add vbus support") added
> GPIO-based VBUS handling for phy-generic.c, but that ends up calling
> usb_gadget_vbus_connect() which forces NOP to depend on the gadget API.
>
> I was grepping around and couldn't find
uot;Fixes" :
Fixes: 70189a63d408 ("usb: gadget: pxa27x_udc: convert to udc_start/udc_stop")
Apart form that:
Acked-by: Robert Jarzmik
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Arnd Bergmann writes:
> Coming back to the specific pxa25x_udc case: using __raw_* accessors
> in the driver would possibly end up breaking the PXA25x machines in
> the (very unlikely) case that someone wants to make it work with
> big-endian kernels, assuming it does not have the same hardware
>
.
Even if in this specific case the driver was not broken, because the
interrupt controller is always probed before drivers, propagate the
proper return code.
Signed-off-by: Robert Jarzmik
---
drivers/usb/host/ohci-pxa27x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
Felipe Balbi writes:
> Hi Arnd,
>
>> arch/arm/mach-ixp4xx/include/mach/ixp4xx-regs.h | 198 -
>> arch/arm/mach-pxa/include/mach/pxa25x-udc.h | 163
>
> for arch/arm I need Acked-by from relevant folks.
You already have mine for arch/arm/mach-pxa/include/mach/pxa25x-udc.h I th
Arnd Bergmann writes:
> On Friday 29 January 2016 10:32:07 Robert Jarzmik wrote:
>> > This addresses both issues by moving all the definitions into the
>> > pxa25x_udc driver itself. It turns out the only difference between
>> > them was 'UDCCS_IO_ROF',
is patch.
>
> Signed-off-by: Arnd Bergmann
For pxa25x_udc:
Acked-by: Robert Jarzmik
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
e behavior of the driver, other than using
> ioremap() on the platform resource to replace the hardcoded
> virtual address pointers.
>
> Signed-off-by: Arnd Bergmann
Acked-by: Robert Jarzmik
It's too bad coccinelle cannot make that work more automatic, isn't it ? :)
Cheers.
Arnd Bergmann writes:
> ixp4xx and pxa25x both use this driver and provide a slightly
> different set of register definitions for it. Aside from that,
> the definition in the ixp4xx-regs.h header conflicts with the
> on in the pxa27x device driver when compile-testing that:
>
> In file included f
nabled and just
> ignore the following usb_ep_enable().
>
> Fix this problem by calling
> gadget_driver->disconnect().
>
> Cc: # v3.10+
> Signed-off-by: Felipe Balbi
Tested-by: Robert Jarzmik
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "
Felipe Balbi writes:
> pxa27x disconnects pullups on suspend but doesn't
> notify the gadget driver about it, so gadget driver
> can't disable the endpoints it was using.
>
> This causes problems on resume because gadget core
> will think endpoints are still enabled and just
> ignore the followin
Felipe Balbi writes:
> Hi,
>
>> Euh it's expected to work _after resume_.
>
> sure is, but you can't expect it to have a proper IP. From host's
> perspective this is a brand new usb0 network interface. Unless you have
> dhcp client running on the phone and a server on your PC, you can't
> assume
Felipe Balbi writes:
> Hi,
>
> this could be a bug in either g_ether or pxa27x... Seems like something
> is enabling endpoints which were already enabled. Not sure if this is
> pxa27x not _really_ disabling endpoints or g_ether being stupid.
You're probably right.
>From what I remember, g_ether i
Felipe Balbi writes:
> Hi,
> you can increase fbcon verbosity, right ? I guess that was
> CONFIG_MESSAGE_LOGLEVEL_DEFAULT.
Sure.
> Set it to 9 and you should get everything. Another option is to change
> dev_* to dev_crit() and KERN_* to KERN_CRIT.
>
>> I know there is not panic/crash, as the sc
Robert Jarzmik writes:
> Felipe Balbi writes:
>
>> Hi,
>>
>> without any sort of logs it a bit difficult :-) Care to send some output
>> of the failure ? Are there any oopses or what exactly happens ?
> Ah well, the UDC is the only way to "speak" to
Felipe Balbi writes:
> Hi,
>
> without any sort of logs it a bit difficult :-) Care to send some output
> of the failure ? Are there any oopses or what exactly happens ?
Ah well, the UDC is the only way to "speak" to the board (no UART), so I don't
have any written feedback available. All I have
Hi Robert and Felipe,
I experience a regression in the 4.4-rc1 kernel which appeared between v4.3 and
v4.4-rc1.
The test :
- boot the mioa701 kernel (ie. pxa27x_udc driver)
- echo mem > /sys/power/state
- resume from "Suspend to RAM" with a key press
- try to use the udc (in my case, g_eth
Alan Stern writes:
Hi Alan,
> On Sat, 25 Jul 2015, Robert Jarzmik wrote:
>
>> Petr Cvek writes:
>>
>> > On 23.7.2015 21:46, Alan Stern wrote:
>> >>> It seems that it allows using a BULK endpoint for requested INT
>> >>> endpoint
Petr Cvek writes:
> On 23.7.2015 21:46, Alan Stern wrote:
>>> It seems that it allows using a BULK endpoint for requested INT
>>> endpoint. For my PXA27x machine the original code returns BULK EP
>>> even with valid INT endpoint definition (because BULK EPs are defined
>>> earlier than INT EPs).
Robert Baldyga writes:
> Convert endpoint configuration to new capabilities model.
The commit message is very short to judge the patch's correctness.
I'll side up with Felipe's opinion. If it's fine by him, so it is by me.
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "unsu
Alexandre Courbot writes:
> On 03/28/2015 04:30 AM, Uwe Kleine-König wrote:
> Looks good, but can't we also merge the call to gpiod_direction to avoid using
> GPIOD_ASIS? The golden rule is that a direction should not remain in an
> unknown
> state after being requested.
>
> This would also requ
Felipe Balbi writes:
> Looks good to me:
>
> Acked-by: Felipe Balbi
Same for me:
Acked-by: Robert Jarzmik
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majo
simplify the error handler logic by returning
> immediately and remove the unnecessary labels.
>
> Signed-off-by: Joe Perches
Tested-by: Robert Jarzmik
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to
dd vbus support".
Signed-off-by: Robert Jarzmik
---
drivers/usb/phy/phy-generic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c
index bdb4cb3..48af068 100644
--- a/drivers/usb/phy/phy-generic.c
+++ b
All the gpios, ie. reset-gpios and vbus-detect-gpio, should be optional
and not prevent the driver from working. Fix the regression in the
behavior introduced by commit "usb: phy: generic: migrate to gpio_desc".
Signed-off-by: Robert Jarzmik
Tested-by: Fabio Estevam
---
Since v1:
Fabio Estevam writes:
> On Thu, Jan 29, 2015 at 8:41 PM, Robert Jarzmik
> wrote:
>> All the gpios, ie. reset-gpios and vbus-detect-gpio, should be optional
>> and not prevent the driver from working. Fix the regression in the
>> behavior introduced by commit "
Fabio Estevam writes:
> Since the "power" GPIO is mapped as active-low, its actual signal will be 0
> after this code. Contrary to the legacy integer GPIO interface, the active-low
> property is handled during mapping and is thus transparent to GPIO consumers."
>
> ,which is exactly what we want
Fabio Estevam writes:
> Why do you set it to zero independently of the GPIO active level flag?
I don't.
Please have a look at gpiod_direction_output() first, especially :
if (test_bit(FLAG_ACTIVE_LOW, &desc->flags))
> ,which correctly puts the GPIO output to the correct initial level
>
dd vbus support".
Signed-off-by: Robert Jarzmik
---
drivers/usb/phy/phy-generic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c
index 9f08c1e..af32ce2 100644
--- a/drivers/usb/phy/phy-generic.c
+++ b
All the gpios, ie. reset-gpios and vbus-detect-gpio, should be optional
and not prevent the driver from working. Fix the regression in the
behavior introduced by commit "usb: phy: generic: migrate to gpio_desc".
Signed-off-by: Robert Jarzmik
---
Since v1: correctly handle the e
is
masked until the end of the threaded handler. This prevents the irq core
from spitting out an error :
"Threaded irq requested with handler=NULL and !ONESHOT for irq 63"
Signed-off-by: Robert Jarzmik
---
drivers/usb/phy/phy-generic.c | 13 +++--
1 file changed, 7 insertions(
Felipe Balbi writes:
>> > At the same time, declare the interrupt as "one shot" so that it is
>> > masked until the end of the threaded handler. This prevents the irq core
>> > from spitting out an error :
>> > "Threaded irq requested with handler=NULL and !ONESHOT for irq 63"
>>
>> Shouldn't
Felipe Balbi writes:
>> nop->gpiod_reset = devm_gpiod_get_optional(dev, "reset");
>> if (gpiod_is_active_low(nop->gpiod_reset))
>> gpiod_direction_output(nop->gpiod_reset, GPIOD_OUT_LOW);
>> else
>> gpiod_direction_output(nop->gpiod_reset, GPIOD_OUT
Felipe Balbi writes:
> diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c
> index 9a826ff31951..34231c31cd1a 100644
> --- a/drivers/usb/phy/phy-generic.c
> +++ b/drivers/usb/phy/phy-generic.c
> @@ -219,11 +219,11 @@ int usb_phy_gen_create_phy(struct device *dev, struct
>
-vbus@13[0]' - status (0)
[0.619221] RJK2: nop->gpiod_vbus = c06bf6dc
So I'll submit that one in [1]. It has to work in your case too, it works in
mine ...
Cheers.
--
Robert
---<8---
[1] Patch
>From 4005a6abf519272267399ac4030a5671f7877ca4 Mon Sep 17 00:00:00 2001
From: Robe
- Mail original -
De: "Fabio Estevam"
À: "Robert Jarzmik"
Cc: "Felipe Balbi" , "Linus Walleij" ,
"Philipp Zabel" , "USB list"
Envoyé: Mardi 27 Janvier 2015 13:41:57
Objet: Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpi
- Mail original -
De: "Fabio Estevam"
À: "Robert Jarzmik"
Cc: "Felipe Balbi" , "Linus Walleij" ,
"Philipp Zabel" , "USB list"
Envoyé: Mardi 27 Janvier 2015 12:23:43
Objet: Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio
- Mail original -
De: "Fabio Estevam"
À: "Robert Jarzmik"
Cc: "Felipe Balbi" , "Linus Walleij" ,
"Philipp Zabel" , "USB list"
Envoyé: Mardi 27 Janvier 2015 10:40:35
Objet: Re: [PATCH v2 1/3] usb: phy: generic: migrate to g
Robert Jarzmik writes:
> I'm not convinced of the "so many issues". So far I see the
> "gpiod_get_optional()" requirement, which is a one liner patch.
Would you try the following patch to see if it fixes all your concerns please ?
Chee
Fabio Estevam writes:
> On Sat, Dec 6, 2014 at 7:05 PM, Robert Jarzmik wrote:
>> Change internal gpio handling from integer gpios into gpio
>> descriptors. This change only addresses the internal API and
>> device-tree/ACPI, while the legacy platform data remains i
Fabio Estevam writes:
> On Fri, Jan 23, 2015 at 2:12 AM, Fabio Estevam wrote:
>> Will need to debug more.
>
> The problem here is that:
>
> nop->gpiod_reset = devm_gpiod_get(dev, "reset-gpios");
>
> Always return -2.
>
> On imx51-babbage.dts we pass 'reset-gpios' and it used to retrieve it
> fin
or the generic phy, otherwise
> the Altera SOCFPGA platform at least is broken.
>
> Fixes breakage caused by a combination of e9f2cefb0cd "usb: phy:
> generic: migrate to gpio_desc" and 135b3c4304d "usb: dwc2: platform:
> add generic PHY framework support".
>
>
Paul Zimmerman writes:
> The patch below fixes it. And it seems like the right thing to me,
> since GPIOs should be optional for a generic phy, I would think. But
> my device tree foo is very weak, so I'm not sure.
>
> CCing Robert, who touched the generic phy code last. Robert, what do
> you thin
Felipe Balbi writes:
> Hi,
Happy new year Felipe,
> sorry for the long delay, got caught up with other stuff. It's now in my
> testing/next and I'll start testing with the boards I have.
Excellent news.
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-usb"
Robert Jarzmik writes:
> Hi Felipe,
>
> This is the 2nd opus of this serie.
> For patches 1 and 2, all comments have been addressed.
>
> For patch 3, you had a question about device charging spec and the regulator
> timings. I read the specs, saw the 15mn timing you
Add support for vbus detection and power supply. This code is more or
less stolen from phy-gpio-vbus-usb.c, and aims at providing a detection
mechanism for VBus (ie. usb cable plug) based on a GPIO line, and a
power supply activation which draws current from the VBus.
Signed-off-by: Robert
Enhance the phy documentation by adding 2 new optional bindings :
- the vbus gpio, which detects usb insertion
- the vbus regulator, which provides current drawn from the usb cable
Signed-off-by: Robert Jarzmik
---
Since v1: changed vbus-gpios to vbus-detect-gpio
---
Documentation/devicetree
r.
Cheers.
--
Robert
Robert Jarzmik (3):
usb: phy: generic: migrate to gpio_desc
usb: phy: nop: device tree documentation for vbus
usb: phy: generic: add vbus support
.../devicetree/bindings/usb/usb-nop-xceiv.txt | 8 ++
drivers/usb/phy/phy-generic.c
the commit message so that this patch gets
some testing as I'm pretty sure it's buggy.
Signed-off-by: Robert Jarzmik
Acked-by: Linus Walleij
---
Since v1: added Linus's ack
---
drivers/usb/phy/phy-generic.c | 61 ++-
drivers/usb/phy/phy
Alexandre Courbot writes:
> I think what you want to do is explained in the "Platform Data"
> section of Documentation/gpio/board.txt
Ah yeah, already one year and I never checked again this documemtation.
Thanks.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-usb
Dmitry Eremin-Solenikov writes:
> Extract lubbock-specific code from pxa25x_udc driver. As a bonus, phy
> driver determines connector/VBUS status by reading CPLD register. Also
> it uses a work to call into udc stack, instead of pinging vbus session
> right from irq handler.
This comment is not a
Linus Walleij writes:
> This definately make things better so:
> Acked-by: Linus Walleij
Thanks.
> One comment though:
>
>>> if (dev->of_node) {
> (...)
>>> + nop->gpiod_reset = devm_gpiod_get(dev, "reset-gpios");
>>> + err = PTR_ERR(nop->gpiod_reset);
>>> }
Dmitry Eremin-Solenikov writes:
> 2014-11-27 1:12 GMT+03:00 Robert Jarzmik :
>> OK Dmitry, I pulled through, the interrupts are working back.
>
> What was the problem? Hardware issues? Firmware in CPLD being of old
> revision?
There were basically 2 problems :
- hardware: s
OK Dmitry, I pulled through, the interrupts are working back.
Actually one of the blockers I have is in pxa25x_udc, and it is also in your
phy-lubbock.c. The bottom of the error is that disable_irq() is called from
within a irq handler, and it deadlocks. A disable_irq_nosync() should be used
...
Felipe Balbi writes:
> On Mon, Nov 24, 2014 at 10:45:03PM +0100, Robert Jarzmik wrote:
>> Felipe Balbi writes:
>>
>> > @@ -1136,8 +1136,7 @@ static const struct file_operations debug_fops = {
>> >} while (0)
>> > #define remove_debug_files(dev
Felipe Balbi writes:
> @@ -1136,8 +1136,7 @@ static const struct file_operations debug_fops = {
> } while (0)
> #define remove_debug_files(dev) \
> do { \
> - if (dev->debugfs_udc) \
> - debugfs_remove(dev->debugfs_udc); \
> + debugfs_remov
Dmitry Eremin-Solenikov writes:
> 2014-11-22 20:49 GMT+03:00 Robert Jarzmik :
> Next point would be (from my POV) to make sure that
> lubbock_unmask_irq() is called
> and works as expected.
Actually the problem is probably within the CPLD.
Irrespective of the CPLD register LUB_IRQ_
Dmitry Eremin-Solenikov writes:
> Hello,
>
> 2014-11-22 20:18 GMT+03:00 Robert Jarzmik :
>> Dmitry Eremin-Solenikov writes:
>>
>>> 2014-11-22 16:56 GMT+03:00 Robert Jarzmik :
>>>> Robert Jarzmik writes:
>>>>> Okay, now my ADSL line is re
Dmitry Eremin-Solenikov writes:
> 2014-11-22 16:56 GMT+03:00 Robert Jarzmik :
>> Robert Jarzmik writes:
>>> Okay, now my ADSL line is repaired, thank you Mr farmer "I drive a tractor
>>> but I
>>> don't care about telephone posts", I
Robert Jarzmik writes:
> Okay, now my ADSL line is repaired, thank you Mr farmer "I drive a tractor
> but I
> don't care about telephone posts", I'll fetch your changes and make a
> test. Let's say I schedule this for saturday.
Removed people from the
Felipe Balbi writes:
> On Fri, Nov 21, 2014 at 06:17:58PM +0100, Robert Jarzmik wrote:
>> Felipe Balbi writes:
>>
>> > On Sun, Nov 09, 2014 at 02:02:18PM +0100, Robert Jarzmik wrote:
>> >> hsusb1_phy {
>> >> @@ -26,8 +31,11 @@
Felipe Balbi writes:
> On Sun, Nov 09, 2014 at 03:58:14PM +0100, Robert Jarzmik wrote:
>> +if (!enabled) {
>> +ret = regulator_enable(vbus_draw);
>> +if (ret < 0)
>> +retur
Felipe Balbi writes:
> On Sun, Nov 09, 2014 at 02:02:18PM +0100, Robert Jarzmik wrote:
>> hsusb1_phy {
>> @@ -26,8 +31,11 @@ Example:
>> clock-names = "main_clk";
>> vcc-supply = <&hsusb1_vcc_regulator>;
>>
Dmitry Eremin-Solenikov writes:
> I have sketched a compile-tested only PHY for the Lubbock platform. Could you
> please take a look and test.
> git://git.infradead.org/users/dbaryshkov/zaurus.git lubbock
Okay, now my ADSL line is repaired, thank you Mr farmer "I drive a tractor but I
don't ca
Dmitry Eremin-Solenikov writes:
> Hello,
> OK, I will take a look. It seems the correct way would be to strip this code
> away to a phy, like gpio-vbus or nop phys. Do you have access to lubbock
> (or maybe Daniel, Haojian or Russell has?)?
Actually Russell kindly gave me his, so I do have one fo
Dmitry Eremin-Solenikov writes:
> Change clk_enable/disable() calls to clk_prepare_enable() and
> clk_disable_unprepare().
>
> Signed-off-by: Dmitry Eremin-Solenikov
> ---
> drivers/usb/gadget/udc/pxa25x_udc.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/driv
Dmitry Eremin-Solenikov writes:
> Change clk_enable/disable() calls to clk_prepare_enable() and
> clk_disable_unrepapre().
No, there are already patches for this in Felipe's next tree :
git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next
Cheers.
--
Robert
--
To unsubscribe
Dmitry Eremin-Solenikov writes:
> Change clk_enable/disable() calls to clk_prepare_enable() and
> clk_disable_unrepapre().
=> clk_disable_unprepare() (typo)
Otherwise, good for me, ack.
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
t
Robert Jarzmik writes:
> Add support for vbus detection and power supply. This code is more or
> less stolen from phy-gpio-vbus-usb.c, and aims at providing a detection
> mechanism for VBus (ie. usb cable plug) based on a GPIO line, and a
> power supply activation which draws curr
Add support for vbus detection and power supply. This code is more or
less stolen from phy-gpio-vbus-usb.c, and aims at providing a detection
mechanism for VBus (ie. usb cable plug) based on a GPIO line, and a
power supply activation which draws current from the VBus.
Signed-off-by: Robert
Enhance the phy documentation by adding 2 new optional bindings :
- the vbus gpio, which detects usb insertion
- the vbus regulator, which provides current drawn from the usb cable
Signed-off-by: Robert Jarzmik
---
Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt | 8
1 file
Robert Jarzmik writes:
> } else if (pdata) {
> type = pdata->type;
> clk_rate = pdata->clk_rate;
> needs_vcc = pdata->needs_vcc;
> - nop->gpio_reset = pdata->gpio_reset;
> - } else {
>
the commit message so that this patch gets
some testing as I'm pretty sure it's buggy.
Signed-off-by: Robert Jarzmik
---
drivers/usb/phy/phy-generic.c | 58 ---
drivers/usb/phy/phy-generic.h | 4 +--
2 files changed, 18 insertions(+), 44 deletion
Felipe Balbi writes:
> fine by me, as long as their all optional and agreed with devicetree
> folks. I think we still have time for v3.19 if you manage to finish this
> before next week's end.
I will try, no promise I'll succeed in this window.
At least I should fire out within the next days the
Felipe Balbi writes:
> On Thu, Nov 06, 2014 at 04:17:48PM -0600, Felipe Balbi wrote:
>> I seem to have missed that, let me replace the patches and use yours.
>
> now done.
Thanks.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majo
udc: fix warning in
non device-tree build" sent October the 29th fixing this issue (in [1]) ?
Cheers.
--
Robert
[1] Patch
From: Robert Jarzmik
Subject: [PATCH v1] usb: gadget: pxa27x_udc: fix warning in non device-tree
build
To: Felipe Balbi
Cc: linux-usb@vger.kernel.org, Robert Jarzmik
Da
Felipe Balbi writes:
> On Wed, Nov 05, 2014 at 08:46:58PM +0100, Robert Jarzmik wrote:
> Well, let's add that :-) Just make it optional. It's pointless to have
> 80% duplicated code just because of 20% missing in phy-generic :-)
>
> Then we avoid adding gpio-vbus speci
Felipe Balbi writes:
> Hi,
>
> On Sun, Nov 02, 2014 at 07:11:49PM +0100, Robert Jarzmik wrote:
>> In order to prepare device-tree conversion, port gpio_vbus to use
>> gpio_desc.
>>
>> Signed-off-by: Robert Jarzmik
>
> Can we just convert users of t
1 - 100 of 173 matches
Mail list logo
