Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-15 Thread Felipe Balbi
On Thu, Mar 14, 2013 at 03:34:31PM -0400, Alan Stern wrote: On Thu, 14 Mar 2013, Felipe Balbi wrote: Here's the diff which needs testing: Can't test the net2272 part. diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c index 691cc65..d23c1b8 100644 ---

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-15 Thread Alan Stern
On Fri, 15 Mar 2013, Felipe Balbi wrote: Adding this back in revealed a bug in udc-core. It is fixed as follows: Index: usb-3.9/drivers/usb/gadget/udc-core.c === --- usb-3.9.orig/drivers/usb/gadget/udc-core.c +++

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-14 Thread Felipe Balbi
Hi Alan, On Wed, Mar 13, 2013 at 05:53:04PM +0800, Chen Gang wrote: Hello Felipe Balbi: I have communicate with related member of net2272 and net2280. net2272 and net2280 belong to PLX Tech Corporation. they say: PLX is not longer maintain these drivers. (it means: they can

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-14 Thread Alan Stern
On Thu, 14 Mar 2013, Felipe Balbi wrote: Hi Alan, On Wed, Mar 13, 2013 at 05:53:04PM +0800, Chen Gang wrote: Hello Felipe Balbi: I have communicate with related member of net2272 and net2280. net2272 and net2280 belong to PLX Tech Corporation. they say: PLX is not longer

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-14 Thread Felipe Balbi
On Thu, Mar 14, 2013 at 11:07:33AM -0400, Alan Stern wrote: On Thu, 14 Mar 2013, Felipe Balbi wrote: Hi Alan, On Wed, Mar 13, 2013 at 05:53:04PM +0800, Chen Gang wrote: Hello Felipe Balbi: I have communicate with related member of net2272 and net2280. net2272 and

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-14 Thread Alan Stern
On Thu, 14 Mar 2013, Felipe Balbi wrote: Here's the diff which needs testing: Can't test the net2272 part. diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c index 691cc65..d23c1b8 100644 --- a/drivers/usb/gadget/net2280.c +++ b/drivers/usb/gadget/net2280.c @@

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-14 Thread Chen Gang
于 2013年03月14日 23:07, Alan Stern 写道: I have a net2280. Which patch do you want me to test? The two of you have come up with two different versions. thank Alan very much, thank Felipe, too. :-) -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-11 Thread Chen Gang
于 2013年03月04日 22:35, Felipe Balbi 写道: since stop_activity() also gets called from RESET interrupt, and in that case we need to call driver-disconnect(). Can you make a simple test that would take current code and issue a device reset to see if that would break, then apply my suggestion above

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-11 Thread Felipe Balbi
On Mon, Mar 11, 2013 at 06:17:10PM +0800, Chen Gang wrote: 于 2013年03月04日 22:35, Felipe Balbi 写道: since stop_activity() also gets called from RESET interrupt, and in that case we need to call driver-disconnect(). Can you make a simple test that would take current code and issue a device

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-11 Thread Chen Gang
于 2013年03月11日 18:17, Chen Gang 写道: 于 2013年03月04日 22:35, Felipe Balbi 写道: since stop_activity() also gets called from RESET interrupt, and in that case we need to call driver-disconnect(). Can you make a simple test that would take current code and issue a device reset to see if that would

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-11 Thread Felipe Balbi
On Mon, Mar 11, 2013 at 06:42:25PM +0800, Chen Gang wrote: if I can not find other members to help us, I will try to find another ways. code inspection works most of the time. all together: I beleive ways is always more than issues. BTW: I also add comments for your test

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-11 Thread Chen Gang
于 2013年03月11日 18:50, Felipe Balbi 写道: On Mon, Mar 11, 2013 at 06:42:25PM +0800, Chen Gang wrote: if I can not find other members to help us, I will try to find another ways. code inspection works most of the time. excuse me, my English is not quite well, could you describe it with

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-11 Thread Felipe Balbi
On Mon, Mar 11, 2013 at 07:03:02PM +0800, Chen Gang wrote: 于 2013年03月11日 18:50, Felipe Balbi 写道: On Mon, Mar 11, 2013 at 06:42:25PM +0800, Chen Gang wrote: if I can not find other members to help us, I will try to find another ways. code inspection works most of the time.

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-11 Thread Chen Gang F T
于 2013年03月11日 19:07, Felipe Balbi 写道: I mean just reading the code and understanding what it does. When you don't have HW to test, it's the only way to patch the driver. ok, thanks. and I still try to find another ways, at least within this week (before 2013-03-15). thanks again. --

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-06 Thread Chen Gang
于 2013年03月05日 19:10, Felipe Balbi 写道: no problem, take your time. Family is more important than a bugfix. I don't have that HW anyway and can't test fixes to it. I do not have either, but I should try (I need think ways to perform, such as qemu kvm, or another ways) welcome additional

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-05 Thread Felipe Balbi
Hi, On Tue, Mar 05, 2013 at 09:42:36AM +0800, Chen Gang wrote: 于 2013年03月04日 22:35, Felipe Balbi 写道: this is the wrong fix, I believe. Looks like when I wrote the commits you mention, I deleted more code then I should. Looks like the real fix would be to add back: /* report

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-04 Thread Felipe Balbi
Hi, On Thu, Feb 28, 2013 at 04:13:01PM +0800, Chen Gang wrote: originally, when deleted the relative code, left some 'another'. need delete 'another', too. the relative patches are: commit 96f8db6a77e3490608e5b5b3f57e7201f8c85496 Author: Felipe Balbi ba...@ti.com Date:

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-04 Thread Chen Gang
于 2013年03月04日 22:35, Felipe Balbi 写道: this is the wrong fix, I believe. Looks like when I wrote the commits you mention, I deleted more code then I should. Looks like the real fix would be to add back: /* report disconnect; the driver is already quiesced */ if (driver) {

[PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-02-28 Thread Chen Gang
originally, when deleted the relative code, left some 'another'. need delete 'another', too. the relative patches are: commit 96f8db6a77e3490608e5b5b3f57e7201f8c85496 Author: Felipe Balbi ba...@ti.com Date: Mon Oct 10 10:33:47 2011 +0300 usb: gadget: net2272: convert