Re: [PATCH 3/3] usb: dwc3: Support option to disable USB2 LPM

2018-11-12 Thread Roger Quadros
On 12/11/18 13:03, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: Also can we have some consistency in usage of '-' vs '_'? >>> Right.. I agree. I've been using '-' as it is the preferred syntax as >>> most of the properties, but some old properties use '_'. Do you have any >>>

Re: [PATCH 3/3] usb: dwc3: Support option to disable USB2 LPM

2018-11-12 Thread Felipe Balbi
Hi, Roger Quadros writes: >>> Also can we have some consistency in usage of '-' vs '_'? >> Right.. I agree. I've been using '-' as it is the preferred syntax as >> most of the properties, but some old properties use '_'. Do you have any >> suggestion? > > I'd keep it consistent to

Re: [PATCH 3/3] usb: dwc3: Support option to disable USB2 LPM

2018-11-12 Thread Roger Quadros
Thinh, On 12/11/18 07:29, Thinh Nguyen wrote: > Hi Roger, > > On 11/9/2018 3:58 AM, Roger Quadros wrote: >> Hi, >> >> On 08/11/18 04:10, Thinh Nguyen wrote: >>> Support the option to disable USB2 LPM. Set xhci "usb2-lpm-disable" >>> property via "snps,usb2-lpm-disable" property. >>> >>>

Re: [PATCH 3/3] usb: dwc3: Support option to disable USB2 LPM

2018-11-11 Thread Thinh Nguyen
Hi Roger, On 11/9/2018 3:58 AM, Roger Quadros wrote: > Hi, > > On 08/11/18 04:10, Thinh Nguyen wrote: >> Support the option to disable USB2 LPM. Set xhci "usb2-lpm-disable" >> property via "snps,usb2-lpm-disable" property. >> >> Signed-off-by: Thinh Nguyen >> --- >> drivers/usb/dwc3/core.c | 2

Re: [PATCH 3/3] usb: dwc3: Support option to disable USB2 LPM

2018-11-09 Thread Roger Quadros
Hi, On 08/11/18 04:10, Thinh Nguyen wrote: > Support the option to disable USB2 LPM. Set xhci "usb2-lpm-disable" > property via "snps,usb2-lpm-disable" property. > > Signed-off-by: Thinh Nguyen > --- > drivers/usb/dwc3/core.c | 2 ++ > drivers/usb/dwc3/core.h | 2 ++ > drivers/usb/dwc3/host.c

Re: [PATCH 3/3] usb: dwc3: Support option to disable USB2 LPM

2018-11-08 Thread Felipe Balbi
Hi, Oliver Neukum writes: >> > > --- a/drivers/usb/dwc3/core.h >> > > +++ b/drivers/usb/dwc3/core.h >> > > @@ -971,6 +971,7 @@ struct dwc3_scratchpad_array { >> > > * @setup_packet_pending: true when there's a Setup Packet in FIFO. >> > > Workaround >> > > * @three_stage_setup: set if we

Re: [PATCH 3/3] usb: dwc3: Support option to disable USB2 LPM

2018-11-08 Thread Oliver Neukum
On Do, 2018-11-08 at 12:47 +0200, Felipe Balbi wrote: Hi, > Oliver Neukum writes: > > On Mi, 2018-11-07 at 18:10 -0800, Thinh Nguyen wrote: > > > > > > --- a/drivers/usb/dwc3/core.h > > > +++ b/drivers/usb/dwc3/core.h > > > @@ -971,6 +971,7 @@ struct dwc3_scratchpad_array { > > > *

Re: [PATCH 3/3] usb: dwc3: Support option to disable USB2 LPM

2018-11-08 Thread Felipe Balbi
Hi, Felipe Balbi writes: >>> --- a/drivers/usb/dwc3/core.h >>> +++ b/drivers/usb/dwc3/core.h >>> @@ -971,6 +971,7 @@ struct dwc3_scratchpad_array { >>> * @setup_packet_pending: true when there's a Setup Packet in FIFO. >>> Workaround >>> * @three_stage_setup: set if we perform a three

Re: [PATCH 3/3] usb: dwc3: Support option to disable USB2 LPM

2018-11-08 Thread Felipe Balbi
Hi, Oliver Neukum writes: > On Mi, 2018-11-07 at 18:10 -0800, Thinh Nguyen wrote: >> >> --- a/drivers/usb/dwc3/core.h >> +++ b/drivers/usb/dwc3/core.h >> @@ -971,6 +971,7 @@ struct dwc3_scratchpad_array { >> * @setup_packet_pending: true when there's a Setup Packet in FIFO. >> Workaround >>

Re: [PATCH 3/3] usb: dwc3: Support option to disable USB2 LPM

2018-11-08 Thread Oliver Neukum
On Mi, 2018-11-07 at 18:10 -0800, Thinh Nguyen wrote: > > --- a/drivers/usb/dwc3/core.h > +++ b/drivers/usb/dwc3/core.h > @@ -971,6 +971,7 @@ struct dwc3_scratchpad_array { > * @setup_packet_pending: true when there's a Setup Packet in FIFO. > Workaround > * @three_stage_setup: set if we

[PATCH 3/3] usb: dwc3: Support option to disable USB2 LPM

2018-11-07 Thread Thinh Nguyen
Support the option to disable USB2 LPM. Set xhci "usb2-lpm-disable" property via "snps,usb2-lpm-disable" property. Signed-off-by: Thinh Nguyen --- drivers/usb/dwc3/core.c | 2 ++ drivers/usb/dwc3/core.h | 2 ++ drivers/usb/dwc3/host.c | 5 - 3 files changed, 8 insertions(+), 1 deletion(-)