Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Greg KH
On Thu, Mar 28, 2013 at 01:11:04AM +0800, Lan Tianyu wrote: Usb port isn't assigned to any bus_type. This seems not good from Greg's comments. http://marc.info/?l=linux-usbm=136200364929942w=2 This patch is to register usb port to usb_bus_type. The usb port's original name is portX.

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Greg KH
On Fri, Mar 29, 2013 at 02:17:02AM +0800, Lan Tianyu wrote: On 2013/3/29 1:59, Greg KH wrote: On Thu, Mar 28, 2013 at 01:11:04AM +0800, Lan Tianyu wrote: Usb port isn't assigned to any bus_type. This seems not good from Greg's comments. http://marc.info/?l=linux-usbm=136200364929942w=2

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Lan Tianyu
On 2013/3/29 2:21, Greg KH wrote: What does it look like if you reverse the naming scheme (hub dev name + port)? Doesn't that show the devices in a bit more logical way? Hi Greg: Do you mean e.g port1.2-1, originally it's port2-1.1. 2-1 is hub dev name? No, I mean 2-1.port1 as these

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, Greg KH wrote: ls /sys/bus/usb/devices 1-0:1.02-0:1.0 port1-1 port1-1.3 port2-1.2 port2-2 port4-3 1-12-1 port1-1.1port1-1.4 port2-1.3 port3-1 port4-4 1-1.1 2-1:1.0 port1-1.2port1-1.5 port2-1.4 port3-2 usb1 1-1:1.0

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Greg KH
On Thu, Mar 28, 2013 at 02:44:01PM -0400, Alan Stern wrote: On Thu, 28 Mar 2013, Greg KH wrote: ls /sys/bus/usb/devices 1-0:1.02-0:1.0 port1-1 port1-1.3 port2-1.2 port2-2 port4-3 1-12-1 port1-1.1port1-1.4 port2-1.3 port3-1 port4-4 1-1.1 2-1:1.0

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Lan Tianyu
On 2013/3/29 2:44, Alan Stern wrote: On Thu, 28 Mar 2013, Greg KH wrote: ls /sys/bus/usb/devices 1-0:1.02-0:1.0 port1-1 port1-1.3 port2-1.2 port2-2 port4-3 1-12-1 port1-1.1port1-1.4 port2-1.3 port3-1 port4-4 1-1.1 2-1:1.0 port1-1.2port1-1.5 port2-1.4

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Lan Tianyu
On 2013/3/29 2:53, Greg KH wrote: On Thu, Mar 28, 2013 at 02:44:01PM -0400, Alan Stern wrote: On Thu, 28 Mar 2013, Greg KH wrote: ls /sys/bus/usb/devices 1-0:1.02-0:1.0 port1-1 port1-1.3 port2-1.2 port2-2 port4-3 1-12-1 port1-1.1port1-1.4 port2-1.3 port3-1

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, Greg KH wrote: On Thu, Mar 28, 2013 at 02:44:01PM -0400, Alan Stern wrote: On Thu, 28 Mar 2013, Greg KH wrote: ls /sys/bus/usb/devices 1-0:1.02-0:1.0 port1-1 port1-1.3 port2-1.2 port2-2 port4-3 1-12-1 port1-1.1port1-1.4

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Greg KH
On Fri, Mar 29, 2013 at 03:08:17AM +0800, Lan Tianyu wrote: On 2013/3/29 2:53, Greg KH wrote: On Thu, Mar 28, 2013 at 02:44:01PM -0400, Alan Stern wrote: On Thu, 28 Mar 2013, Greg KH wrote: ls /sys/bus/usb/devices 1-0:1.02-0:1.0 port1-1 port1-1.3 port2-1.2 port2-2 port4-3 1-1

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Greg KH
On Thu, Mar 28, 2013 at 03:16:08PM -0400, Alan Stern wrote: On Thu, 28 Mar 2013, Greg KH wrote: On Thu, Mar 28, 2013 at 02:44:01PM -0400, Alan Stern wrote: On Thu, 28 Mar 2013, Greg KH wrote: ls /sys/bus/usb/devices 1-0:1.02-0:1.0 port1-1 port1-1.3 port2-1.2

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Sarah Sharp
On Thu, Mar 28, 2013 at 03:56:17PM -0700, Greg KH wrote: Has anyone tried this patch with libusb? At this point, I don't know if it has tested with libusb or even lsusb. I didn't see this patch until today, and I have not tested it on the Intel platform that actually implements the port power

[PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-27 Thread Lan Tianyu
Usb port isn't assigned to any bus_type. This seems not good from Greg's comments. http://marc.info/?l=linux-usbm=136200364929942w=2 This patch is to register usb port to usb_bus_type. The usb port's original name is portX. This will cause name confilct after adding usb port to

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-27 Thread Alan Stern
On Thu, 28 Mar 2013, Lan Tianyu wrote: Usb port isn't assigned to any bus_type. This seems not good from Greg's comments. http://marc.info/?l=linux-usbm=136200364929942w=2 This patch is to register usb port to usb_bus_type. The usb port's original name is portX. This will cause name