Re: [PATCH v2 2/2] usb: gadget: Add xilinx axi usb2 device support

2014-07-07 Thread sundeep subbaraya
Hi Felipe, On Wed, Jul 2, 2014 at 10:16 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Sun, May 25, 2014 at 11:10:30PM +0530, sundeep subbaraya wrote: Hi Felipe, Please take a look at below about how this IP works: IN: req.buf --- DMA (transfers from ddr to IP buffer, raise DMA done

Re: [PATCH v2 2/2] usb: gadget: Add xilinx axi usb2 device support

2014-07-02 Thread Felipe Balbi
Hi, On Sun, May 25, 2014 at 11:10:30PM +0530, sundeep subbaraya wrote: Hi Felipe, Please take a look at below about how this IP works: IN: req.buf --- DMA (transfers from ddr to IP buffer, raise DMA done interrupt and set Buffer ready to transfer data to Host)Host PC buffer

Re: [PATCH v2 2/2] usb: gadget: Add xilinx axi usb2 device support

2014-05-25 Thread sundeep subbaraya
Hi Felipe, Please take a look at below about how this IP works: IN: req.buf --- DMA (transfers from ddr to IP buffer, raise DMA done interrupt and set Buffer ready to transfer data to Host)Host PC buffer sent interrupt OUT: Host PC---buffer ready interrupt---DMA (transfer from

Re: [PATCH v2 2/2] usb: gadget: Add xilinx axi usb2 device support

2014-04-22 Thread sundeep subbaraya
Hi, On Mon, Apr 21, 2014 at 10:09 PM, Alan Stern st...@rowland.harvard.edu wrote: On Mon, 21 Apr 2014, Felipe Balbi wrote: Hi, On Fri, Apr 18, 2014 at 07:34:08PM +0530, sundeep subbaraya wrote: snip in ep_queue driver starts dma transfer from/to IP buffer to/from req-buf. If

Re: [PATCH v2 2/2] usb: gadget: Add xilinx axi usb2 device support

2014-04-22 Thread Alan Stern
On Tue, 22 Apr 2014, sundeep subbaraya wrote: Hi, On Mon, Apr 21, 2014 at 10:09 PM, Alan Stern st...@rowland.harvard.edu wrote: On Mon, 21 Apr 2014, Felipe Balbi wrote: Hi, On Fri, Apr 18, 2014 at 07:34:08PM +0530, sundeep subbaraya wrote: snip in ep_queue driver starts

Re: [PATCH v2 2/2] usb: gadget: Add xilinx axi usb2 device support

2014-04-22 Thread Felipe Balbi
Hi, On Tue, Apr 22, 2014 at 12:58:41PM +0530, sundeep subbaraya wrote: Hi, On Mon, Apr 21, 2014 at 10:09 PM, Alan Stern st...@rowland.harvard.edu wrote: On Mon, 21 Apr 2014, Felipe Balbi wrote: Hi, On Fri, Apr 18, 2014 at 07:34:08PM +0530, sundeep subbaraya wrote: snip

Re: [PATCH v2 2/2] usb: gadget: Add xilinx axi usb2 device support

2014-04-21 Thread Felipe Balbi
Hi, On Fri, Apr 18, 2014 at 07:34:08PM +0530, sundeep subbaraya wrote: snip in ep_queue driver starts dma transfer from/to IP buffer to/from req-buf. If transfer is completed then request is not added to ep request queue and returns from ep_queue. If transfer is not completed (actual

Re: [PATCH v2 2/2] usb: gadget: Add xilinx axi usb2 device support

2014-04-21 Thread Alan Stern
On Mon, 21 Apr 2014, Felipe Balbi wrote: Hi, On Fri, Apr 18, 2014 at 07:34:08PM +0530, sundeep subbaraya wrote: snip in ep_queue driver starts dma transfer from/to IP buffer to/from req-buf. If transfer is completed then request is not added to ep request queue and returns

Re: [PATCH v2 2/2] usb: gadget: Add xilinx axi usb2 device support

2014-04-18 Thread sundeep subbaraya
Hi Felipe, On Thu, Apr 17, 2014 at 8:31 PM, Felipe Balbi ba...@ti.com wrote: On Thu, Apr 17, 2014 at 03:01:37PM +0530, sundeep subbaraya wrote: Hi Felipe, On Wed, Apr 16, 2014 at 11:32 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Wed, Apr 16, 2014 at 04:09:28PM +0530, sundeep subbaraya

Re: [PATCH v2 2/2] usb: gadget: Add xilinx axi usb2 device support

2014-04-17 Thread sundeep subbaraya
Hi Felipe, On Wed, Apr 16, 2014 at 11:32 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Wed, Apr 16, 2014 at 04:09:28PM +0530, sundeep subbaraya wrote: Hi Felipe, On Thu, Apr 3, 2014 at 8:28 PM, Felipe Balbi ba...@ti.com wrote: +static int start_dma(struct xusb_ep *ep, u32 src, u32 dst, u32

Re: [PATCH v2 2/2] usb: gadget: Add xilinx axi usb2 device support

2014-04-17 Thread sundeep subbaraya
Hi, On Thu, Apr 17, 2014 at 1:38 AM, Paul Zimmerman paul.zimmer...@synopsys.com wrote: From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of sundeep subbaraya Sent: Wednesday, April 16, 2014 3:39 AM Hi Felipe, On Thu, Apr 3, 2014 at 8:28 PM, Felipe

Re: [PATCH v2 2/2] usb: gadget: Add xilinx axi usb2 device support

2014-04-17 Thread Felipe Balbi
On Thu, Apr 17, 2014 at 03:01:37PM +0530, sundeep subbaraya wrote: Hi Felipe, On Wed, Apr 16, 2014 at 11:32 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Wed, Apr 16, 2014 at 04:09:28PM +0530, sundeep subbaraya wrote: Hi Felipe, On Thu, Apr 3, 2014 at 8:28 PM, Felipe Balbi

Re: [PATCH v2 2/2] usb: gadget: Add xilinx axi usb2 device support

2014-04-16 Thread sundeep subbaraya
Hi Felipe, On Thu, Apr 3, 2014 at 8:28 PM, Felipe Balbi ba...@ti.com wrote: +static int start_dma(struct xusb_ep *ep, u32 src, u32 dst, u32 length) please prepend this with xudc_, it makes tracing a lot easier. +{ + struct xusb_udc *udc; + int rc = 0; + unsigned long timeout;

Re: [PATCH v2 2/2] usb: gadget: Add xilinx axi usb2 device support

2014-04-16 Thread Felipe Balbi
Hi, On Wed, Apr 16, 2014 at 04:09:28PM +0530, sundeep subbaraya wrote: Hi Felipe, On Thu, Apr 3, 2014 at 8:28 PM, Felipe Balbi ba...@ti.com wrote: +static int start_dma(struct xusb_ep *ep, u32 src, u32 dst, u32 length) please prepend this with xudc_, it makes tracing a lot easier.

RE: [PATCH v2 2/2] usb: gadget: Add xilinx axi usb2 device support

2014-04-16 Thread Paul Zimmerman
From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of sundeep subbaraya Sent: Wednesday, April 16, 2014 3:39 AM Hi Felipe, On Thu, Apr 3, 2014 at 8:28 PM, Felipe Balbi ba...@ti.com wrote: +static int start_dma(struct xusb_ep *ep, u32 src, u32

Re: Fwd: [PATCH v2 2/2] usb: gadget: Add xilinx axi usb2 device support

2014-04-08 Thread sundeep subbaraya
On Mon, Apr 7, 2014 at 10:05 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Apr 07, 2014 at 02:36:13PM +0530, sundeep subbaraya wrote: +/** + * xudc_wrstatus - Sets up the usb device status stages. + * @udc: pointer to the usb device controller structure. + */ +static void

Re: Fwd: [PATCH v2 2/2] usb: gadget: Add xilinx axi usb2 device support

2014-04-08 Thread Felipe Balbi
Hi, On Tue, Apr 08, 2014 at 09:31:29PM +0530, sundeep subbaraya wrote: +static const struct usb_gadget_ops xusb_udc_ops = { + .get_frame = xudc_get_frame, + .wakeup = xudc_wakeup, + .udc_start = xudc_start, + .udc_stop = xudc_stop, no pullup ??? What gives ?

Re: [PATCH v2 2/2] usb: gadget: Add xilinx axi usb2 device support

2014-04-07 Thread sundeep subbaraya
Hi Michal, On Thu, Apr 3, 2014 at 8:53 PM, Michal Simek mon...@monstr.eu wrote: +struct xusb_udc { +struct usb_gadget gadget; +struct xusb_ep ep[8]; +struct usb_gadget_driver *driver; +struct cmdbuf ch9cmd; +u32 usb_state; +u32 remote_wkp; +unsigned int

Re: Fwd: [PATCH v2 2/2] usb: gadget: Add xilinx axi usb2 device support

2014-04-07 Thread Felipe Balbi
Hi, On Mon, Apr 07, 2014 at 02:36:13PM +0530, sundeep subbaraya wrote: +/** + * xudc_wrstatus - Sets up the usb device status stages. + * @udc: pointer to the usb device controller structure. + */ +static void xudc_wrstatus(struct xusb_udc *udc) +{ + u32 epcfgreg; + +

Re: [PATCH v2 2/2] usb: gadget: Add xilinx axi usb2 device support

2014-04-03 Thread Michal Simek
+struct xusb_udc { +struct usb_gadget gadget; +struct xusb_ep ep[8]; +struct usb_gadget_driver *driver; +struct cmdbuf ch9cmd; +u32 usb_state; +u32 remote_wkp; +unsigned int (*read_fn)(void __iomem *); +void (*write_fn)(void __iomem *, u32, u32); why do