Hi Peter,
On Wed, Jul 4, 2018 at 5:24 AM, Peter Chen wrote:
> It seems there is no harm if we always include drivers/usb/chipidea/ulpi.c
> except increasing
> a little code size, how about always build ulpi.c for the whole chipidea at
> Makefile, delete
> CONFIG_USB_CHIPIDEA_ULPI as well,
> On Tue, Jul 3, 2018 at 12:40 AM, Shawn Guo wrote:
>
> > We can have the options in defconfig, but they can still be turned off
> > for whatever reason and we get the hang. Really, missing a user
> > selectable option in defconfig shouldn't result in a system hang.
>
> Yes, 100% agree and
On Tue, Jul 03, 2018 at 07:52:07AM -0300, Fabio Estevam wrote:
> Hi Shawn,
>
> On Tue, Jul 3, 2018 at 12:40 AM, Shawn Guo wrote:
>
> > We can have the options in defconfig, but they can still be turned off
> > for whatever reason and we get the hang. Really, missing a user
> > selectable
Hi Shawn,
On Tue, Jul 3, 2018 at 12:40 AM, Shawn Guo wrote:
> We can have the options in defconfig, but they can still be turned off
> for whatever reason and we get the hang. Really, missing a user
> selectable option in defconfig shouldn't result in a system hang.
Yes, 100% agree and this
On Mon, Jul 02, 2018 at 11:22:55PM -0300, Fabio Estevam wrote:
> Hi Shawn,
>
> On Mon, Jul 2, 2018 at 11:06 PM, Shawn Guo wrote:
>
> > A second thought on this - shouldn't such dependency be solved by
> > Kconfig select clause?
>
> I suspect we are not able to fix it via Kconfig as we really
Hi Shawn,
On Mon, Jul 2, 2018 at 11:06 PM, Shawn Guo wrote:
> A second thought on this - shouldn't such dependency be solved by
> Kconfig select clause?
I suspect we are not able to fix it via Kconfig as we really don't
know if a system uses ULPI interface or not via Kconfig perspective.
If
On Mon, Jun 25, 2018 at 11:25:12AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam
>
> Since commit 03e6275ae381087bd8 ("usb: chipidea: Fix ULPI on imx51") the
> kernel hangs on a imx51-babbage board, when using the ULPI interface with
> the CONFIG_USB_CHIPIDEA_ULPI option unselected.
>
>
On Mon, Jul 2, 2018 at 10:48 PM, Shawn Guo wrote:
> I will make sure both defconfig patches go into 4.18-rc.
Thanks, Shawn!
Peter,
Could you please then queue this chipidea patch for 4.18-rc?
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a
On Mon, Jul 02, 2018 at 08:52:34AM -0300, Fabio Estevam wrote:
> Hi Peter,
>
> On Mon, Jul 2, 2018 at 12:08 AM, Peter Chen wrote:
>
> > Fabio, since this function has dependency with defconfig, is the defconfig
> > change a fix for v4.18-rc
> > or for v4.19-rc1?
>
> I have sent the defconfig
Hi Peter,
On Mon, Jul 2, 2018 at 12:08 AM, Peter Chen wrote:
> Fabio, since this function has dependency with defconfig, is the defconfig
> change a fix for v4.18-rc
> or for v4.19-rc1?
I have sent the defconfig changes for imx_v6_v7_defconfig and
imx_v4_v5_defconfig and hope that they could
>
> On Mon, Jun 25, 2018 at 7:24 AM Fabio Estevam wrote:
> >
> > From: Fabio Estevam
> >
> > Since commit 03e6275ae381087bd8 ("usb: chipidea: Fix ULPI on imx51")
> > the kernel hangs on a imx51-babbage board, when using the ULPI
> > interface with the CONFIG_USB_CHIPIDEA_ULPI option
On Mon, Jun 25, 2018 at 7:24 AM Fabio Estevam wrote:
>
> From: Fabio Estevam
>
> Since commit 03e6275ae381087bd8 ("usb: chipidea: Fix ULPI on imx51") the
> kernel hangs on a imx51-babbage board, when using the ULPI interface with
> the CONFIG_USB_CHIPIDEA_ULPI option unselected.
>
> Instead of
Hi Peter,
On Mon, Jun 25, 2018 at 11:51 PM, Peter Chen wrote:
> Fabio, I wonder it may cause the USB not work at imx27 which
> do not use this configuration now. Any possibilities to test and verify it?
I don't have access to a mx27 board, but I can send a patch that
selects
>
> Fixes: 03e6275ae381087bd8 ("usb: chipidea: Fix ULPI on imx51")
> Suggested-by: Lucas Stach
> Signed-off-by: Fabio Estevam
> ---
> Changes since v1:
> - Only propagate the error when CONFIG_USB_CHIPIDEA_ULPI is unselected
>
> drivers/usb/chipidea/core.c | 11 +++
> 1 file
14 matches
Mail list logo
