Re: [V2 PATCH 00/27] mv-usb fix and enhancement patches

2013-01-08 Thread Chao Xie
On Sat, Jan 5, 2013 at 9:35 AM, Chao Xie xiechao.m...@gmail.com wrote: hi, Felipe How about these patches? i see that 3.8-rc2 is tagged but these patches are not merged. Thanks. On Tue, Dec 4, 2012 at 3:34 PM, Haojian Zhuang haojian.zhu...@gmail.com wrote: On Fri, Nov 30, 2012 at 10:10 PM,

[PATCH 1/1] usb: gadget: s3c-hsotg: Use devm_regulator_bulk_get API

2013-01-08 Thread Sachin Kamat
devm_regulator_bulk_get is device managed and saves some cleanup and exit code. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/gadget/s3c-hsotg.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/s3c-hsotg.c

Re: [RESEND 2/2] musb: fix dependency on transceiver driver

2013-01-08 Thread Sebastian Andrzej Siewior
On Fri, Jan 04, 2013 at 11:13:58PM +0800, Ming Lei wrote: This patch let glue driver return -EPROBE_DEFER if the transceiver is not readly, so we can support defer probe on musb to fix the below error on 3.7-rc5 if transceiver drivers are built as module: looks good Sebastian -- To

Re: Linux USB file storage gadget with new UDC

2013-01-08 Thread victor yeo
Hi, For testing purposes, you probably should use a Linux host. Then you could use usbmon on the host to see what's happening, and there would be more debugging options available. Got it, i will get a PC to install Linux. Did you enable the two debugging options in file_storage.c? And

Re: [PATCH 1/1]linux-usb:optimize to match the Huawei USB storage devices and support new switch command

2013-01-08 Thread Sebastian Andrzej Siewior
On Sat, Jan 05, 2013 at 10:57:42AM +0800, fangxiaozhi 00110321 wrote: From: fangxiaozhi huana...@huawei.com 1. Optimize the match rules with new macro for Huawei USB storage devices, to avoid to load USB storage driver for the modem interface with Huawei devices. 2. Add to support

Re: [PATCH] drivers: xhci: fix incorrect bit test

2013-01-08 Thread Sergei Shtylyov
Hello. On 08-01-2013 7:39, Nickolai Zeldovich wrote: Fix incorrect bit test that originally showed up in 4ee823b83bc9851743fab756c76b27d6a1e2472b: use '' instead of ''. Please also specify the summary of that commit in parens (or however you like). Signed-off-by: Nickolai Zeldovich

net: usb: cdc_ncm: add support IFF_NOARP

2013-01-08 Thread Wei Shuai
Hi Alexey, Recently I met a Modem which cannot do ARP. But I found our cdc_ncm_bind() function cannot handle this special case. Do you have any plan to handle it? static int cdc_ncm_bind(struct usbnet *dev, struct usb_interface *intf) { ... /* cannot do ARP */

usb device removed from sysfs before input children devices

2013-01-08 Thread Karl Relton
On coming out of suspend my usb bluetooth adaptor is being reset by the system. In linux 3.7 the usb devices are being removed from the sysfs tree first, and then the various 'child' devices (like my bluetooth mouse keyboard related devices) afterwards. This is causing the udev events for the

[PATCH 5/5] kfifo: log based kfifo API

2013-01-08 Thread Yuanhan Liu
The current kfifo API take the kfifo size as input, while it rounds _down_ the size to power of 2 at __kfifo_alloc. This may introduce potential issue. Take the code at drivers/hid/hid-logitech-dj.c as example: if (kfifo_alloc(djrcv_dev-notif_fifo,

TP-LINK HSUPA Modem

2013-01-08 Thread hockseng leow
Hello, Please add the modem to a proper driver. Attached is the dmesg. Thanks. -- Leow Hock Seng Tel:64463211 Mobile:96740759 http://www.oses.sg [51536.010224] usb 2-1.4: new full-speed USB device number 10 using uhci_hcd [51536.224219] usb 2-1.4: New USB device found, idVendor=2357,

Re: usb serial driver: private data already deallocated when release function is called

2013-01-08 Thread Alan Stern
On Tue, 8 Jan 2013, Tilman wrote: I added an addition port_probe, and port_remove function that do nothing but a return 0. The bahavior is unchanged. The private data is already deallocated once the release function is called Of course. Changes you make in your driver aren't going to affect

Re: [PATCH v3 8/9] usb: expose usb port's pm qos flags to user space

2013-01-08 Thread Alan Stern
On Tue, 8 Jan 2013, Lan Tianyu wrote: On 2013年01月08日 02:44, Alan Stern wrote: On Sun, 6 Jan 2013, Lan Tianyu wrote: This patch is to expose usb port's pm qos flags(pm_qos_no_power_off, pm_qos_remote_wakeup) to user space. User can set pm_qos_no_power_off flag to prohibit the port from

Re: [PATCH v4 0/7] Add fully tested id switch and vbus connect detect support for Chipidea

2013-01-08 Thread Maxime Ripard
Hi Peter, On 27/12/2012 07:59, Peter Chen wrote: (Sorry for update slowly due to long time business trip) Changes for v4 mainly for 2/7, 3/7, 4/7, see individual patch commit for detail. This patchset adds fully tested otg id switch function and vbus connect/disconnect detection for

Re: Linux USB file storage gadget with new UDC

2013-01-08 Thread Alan Stern
On Tue, 8 Jan 2013, victor yeo wrote: This log looks oddly incomplete. A lot of debugging messages are missing. g_file_storage gadget: ep0-setup, length 8: : 80 06 00 01 00 00 40 00 g_file_storage gadget: get device descriptor For example, right here we should see the

Re: USB autosuspend vs. URB submission

2013-01-08 Thread Alan Stern
On Mon, 7 Jan 2013, Josh Boyer wrote: Hi, We've had a few reports in Fedora of users hitting the WARN_ONCE in drivers/usb/core/urb.c that prints a warning about a usb_submit_urb being called on an active URB. One of them[1] is from the ums_realtek driver and the other[2] is from the

Re: usb serial driver: private data already deallocated when release function is called

2013-01-08 Thread Greg KH
On Tue, Jan 08, 2013 at 12:14:19AM +, Tilman wrote: I added an addition port_probe, and port_remove function that do nothing but a return 0. The bahavior is unchanged. The private data is already deallocated once the release function is called Now, i have 2 follow up questions: 1) When

Re: USB autosuspend vs. URB submission

2013-01-08 Thread Josh Boyer
On Tue, Jan 08, 2013 at 10:51:20AM -0500, Alan Stern wrote: On Mon, 7 Jan 2013, Josh Boyer wrote: Hi, We've had a few reports in Fedora of users hitting the WARN_ONCE in drivers/usb/core/urb.c that prints a warning about a usb_submit_urb being called on an active URB. One of them[1]

Re: TP-LINK HSUPA Modem

2013-01-08 Thread Greg KH
On Tue, Jan 08, 2013 at 11:07:22PM +0800, hockseng leow wrote: Hello, Please add the modem to a proper driver. Attached is the dmesg. What type of device is this? And where did you get the instructions that told you to add it to the generic USB Serial driver? [51536.010224] usb 2-1.4:

Re: TP-LINK HSUPA Modem

2013-01-08 Thread Anil Nair
Hello, How does the same product have different product id? [51536.224219] usb 2-1.4: New USB device found, idVendor=2357, idProduct=f006 [51541.301304] usb 2-1.4: New USB device found, idVendor=2357, idProduct=0200 Is it the fact that one time it is detected as USB device and second time as

[PATCH 1/2] omap2430: fix wrong devm_kzalloc() result check

2013-01-08 Thread Sergei Shtylyov
Commit 00a0b1d58af873d842580dcac55f3b156c3a4077 (usb: musb: omap: Add device tree support for omap musb glue) assigns result of devm_kzalloc() call to the 'config' variable but then checks for NULL the 'data' variable (already checked after previous call). Thus we risk a kernel oops further when

[PATCH 2/2] omap2430: kill redundant assignments in omap2430_probe()

2013-01-08 Thread Sergei Shtylyov
Commit 00a0b1d58af873d842580dcac55f3b156c3a4077 (usb: musb: omap: Add device tree support for omap musb glue) added assignments of the 'ret' variable to -ENOMEM on *some* error paths of the calls to devm_kzalloc(), while that variable was already pre-initialized for to that value, so these

Re: [PATCH 5/5] kfifo: log based kfifo API

2013-01-08 Thread Dmitry Torokhov
Hi Yuanhan, On Tue, Jan 08, 2013 at 10:57:53PM +0800, Yuanhan Liu wrote: The current kfifo API take the kfifo size as input, while it rounds _down_ the size to power of 2 at __kfifo_alloc. This may introduce potential issue. Take the code at drivers/hid/hid-logitech-dj.c as example:

Re: [PATCH v2 3/3] usb: musb: omap: Add device tree support for omap musb glue

2013-01-08 Thread Sergei Shtylyov
Hello. On 09/11/2012 01:09 PM, Kishon Vijay Abraham I wrote: Added device tree support for omap musb driver and updated the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com Belated comments to the patch which didn't pass my message

Re: [PATCH] drivers/usb/host/uhci-* : check buffer length to avoid memory overflow

2013-01-08 Thread Alan Stern
Gang: I apologize for taking so long to respond to your patch. I didn't get much work done during the holidays... Overall it looks pretty good. There are a few things that I would prefer to change. On Thu, 20 Dec 2012, Chen Gang wrote: reason (why): for function

Re: [PATCH 5/5] kfifo: log based kfifo API

2013-01-08 Thread Andy Walls
Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Yuanhan, On Tue, Jan 08, 2013 at 10:57:53PM +0800, Yuanhan Liu wrote: The current kfifo API take the kfifo size as input, while it rounds _down_ the size to power of 2 at __kfifo_alloc. This may introduce potential issue. Take the code

Re: net: usb: cdc_ncm: add support IFF_NOARP

2013-01-08 Thread Bjørn Mork
Wei Shuai cpuw...@gmail.com wrote: Hi Alexey, Recently I met a Modem which cannot do ARP. But I found our cdc_ncm_bind() function cannot handle this special case. Do you have any plan to handle it? static int cdc_ncm_bind(struct usbnet *dev, struct usb_interface *intf) { ...

Re: net: usb: cdc_ncm: add support IFF_NOARP

2013-01-08 Thread Alexey Orishko
Hi, On Tue, Jan 8, 2013 at 2:14 PM, Wei Shuai cpuw...@gmail.com wrote: Hi Alexey, Recently I met a Modem which cannot do ARP. But I found our cdc_ncm_bind() function cannot handle this special case. Do you have any plan to handle it? static int cdc_ncm_bind(struct usbnet *dev,

Re: [PATCH 5/5] kfifo: log based kfifo API

2013-01-08 Thread Yuanhan Liu
On Tue, Jan 08, 2013 at 10:16:46AM -0800, Dmitry Torokhov wrote: Hi Yuanhan, On Tue, Jan 08, 2013 at 10:57:53PM +0800, Yuanhan Liu wrote: The current kfifo API take the kfifo size as input, while it rounds _down_ the size to power of 2 at __kfifo_alloc. This may introduce potential

Re: [PATCH] drivers/usb/host/uhci-* : check buffer length to avoid memory overflow

2013-01-08 Thread Chen Gang
于 2013年01月09日 04:53, Alan Stern 写道: Gang: I apologize for taking so long to respond to your patch. I didn't get much work done during the holidays... I understand. it is necessary to have a rest, so can keep our contributes (work), with efficiency and sustainable. :-) Can you

Re: [PATCH v3 8/9] usb: expose usb port's pm qos flags to user space

2013-01-08 Thread Lan Tianyu
On 2013年01月08日 23:16, Alan Stern wrote: On Tue, 8 Jan 2013, Lan Tianyu wrote: On 2013年01月08日 02:44, Alan Stern wrote: On Sun, 6 Jan 2013, Lan Tianyu wrote: This patch is to expose usb port's pm qos flags(pm_qos_no_power_off, pm_qos_remote_wakeup) to user space. User can set

Re: [PATCH v4 0/7] Add fully tested id switch and vbus connect detect support for Chipidea

2013-01-08 Thread Peter Chen
On Tue, Jan 08, 2013 at 04:27:21PM +0100, Maxime Ripard wrote: Hi Peter, On 27/12/2012 07:59, Peter Chen wrote: (Sorry for update slowly due to long time business trip) Changes for v4 mainly for 2/7, 3/7, 4/7, see individual patch commit for detail. This patchset adds fully

[PATCH] usb: gadget: FunctionFS: Fix missing braces in parse_opts

2013-01-08 Thread Benoit Goby
Add missing braces around an if block in ffs_fs_parse_opts. This broke parsing the uid/gid mount options and causes mount to fail when using uid/gid. This has been introduced by commit b9b73f7c (userns: Convert usb functionfs to use kuid/kgid where appropriate) in 3.7. Signed-off-by: Benoit Goby

Re: [PATCH v8 1/2] usb: phy: samsung: Introducing usb phy driver for hsotg

2013-01-08 Thread Praveen Paneri
Hi Tomasz, Sorry! I I missed this comment of yours. Is it okay if we keep pmu_isolation as it is (as it does not seem much out of the line). We have already gone through a lot of rework and there has been no fruitful result :( Also after Viveks work, this is only milited to non DT SoCs. Thanks,

Re: [PATCH v8 1/2] usb: phy: samsung: Introducing usb phy driver for hsotg

2013-01-08 Thread Praveen Paneri
Hi Tomasz, On Wed, Jan 9, 2013 at 11:28 AM, Praveen Paneri p.pan...@samsung.com wrote: Hi Tomasz, Sorry! I I missed this comment of yours. Is it okay if we keep pmu_isolation as it is (as it does not seem much out of the line). We have already gone through a lot of rework and there has been

Re: [PATCH v9 1/2] usb: phy: samsung: Introducing usb phy driver for hsotg

2013-01-08 Thread Praveen Paneri
Hi Kukjin, It has been a long time since I posted these patches. It will be very kind of you to express your views about this series. If this looks fine to you, please ack. Thanks, Praveen On Fri, Nov 23, 2012 at 4:03 PM, Praveen Paneri p.pan...@samsung.com wrote: This driver uses usb_phy

Re: TP-LINK HSUPA Modem

2013-01-08 Thread Mikael Abrahamsson
On Tue, 8 Jan 2013, Anil Nair wrote: How does the same product have different product id? [51536.224219] usb 2-1.4: New USB device found, idVendor=2357, idProduct=f006 [51541.301304] usb 2-1.4: New USB device found, idVendor=2357, idProduct=0200 Is it the fact that one time it is detected

Re: TP-LINK HSUPA Modem

2013-01-08 Thread Thomas Schäfer
Is this device here the same?: http://www.draisberghof.de/usb_modeswitch/bb/viewtopic.php?f=3t=942hilit=tp+link+hsupa+2357 If, yes. I am a little confused about the three device IDs: 2357:f006 2357:0200 2357:0201 If you like try option, qmi_wwan and post the results. Regards, Thomas -- To