Re: [PATCH] usb: ehci: change order of register cleanup during shutdown

On Mon, Aug 01, 2016 at 06:07:17PM +0200, Alan Stern wrote: > On Mon, 1 Aug 2016, Marc Ohlf wrote: > > > In ehci_turn_off_all_ports() all EHCI port register bits > > (except the PORT_RWC_BITS) are set to zero. > > Even the PORT_WRC_BITS are set to 0. Oddly enough, the way to set > those bits

Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue

On Tue 02-08-16 12:03:23, Oliver Neukum wrote: > On Tue, 2016-08-02 at 10:18 +0200, Michal Hocko wrote: > > On Tue 02-08-16 10:06:12, Oliver Neukum wrote: > > > On Mon, 2016-08-01 at 10:20 -0400, Tejun Heo wrote: > > > > Hello, > > > > > > > > If any real IO depends on those devices then this is

RE: USB vulnerability

From: Felipe Balbi > Sent: 29 July 2016 01:30 ... > > - maxp = usb_endpoint_maxp(>desc) & 0x07ff; > > usb_endpoint_maxp() should probably be updated to return only maximum > packet size. Then we would need to introduce usb_endpoint_mult() or > something along those lines to take care of

Re: usbtmc: vendor specific i/o

On Tue, Aug 02, 2016 at 11:25:22AM +0200, dave penkler wrote: >For supportability I would recommend to set the commands depending on the >recognised HW, not with aA ioctl. See rigol quirk. What are the device >and manufacturer ids to which these vendor extensions apply? >/dave

Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue

On Tue, 2016-08-02 at 10:18 +0200, Michal Hocko wrote: > On Tue 02-08-16 10:06:12, Oliver Neukum wrote: > > On Mon, 2016-08-01 at 10:20 -0400, Tejun Heo wrote: > > > Hello, > > > > > > If any real IO depends on those devices then this is not sufficient and > > > > they need some form of guarantee

[PATCH 0/1] USB: serial: option: add support for Telit LE920A4

This patch adds a set of compositions for Telit LE920A4. Compositions in short are: 0x1207: tty + tty 0x1208: tty + adb + tty + tty 0x1211: tty + adb + ecm 0x1212: tty + adb 0x1213: ecm + tty 0x1214: tty + adb + ecm + tty telit_le922_blacklist_usbcfg3 is reused for compositions 0x1211 and

[PATCH 1/1] USB: serial: option: add support for Telit LE920A4

This patch adds a set of compositions for Telit LE920A4. Compositions in short are: 0x1207: tty + tty 0x1208: tty + adb + tty + tty 0x1211: tty + adb + ecm 0x1212: tty + adb 0x1213: ecm + tty 0x1214: tty + adb + ecm + tty telit_le922_blacklist_usbcfg3 is reused for compositions 0x1211 and

[PATCH 0986/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0987/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

Re: [PATCH] musb: omap2430: do not assume balanced enable()/disable()

* Andreas Kemnade [160729 11:14]: > The code assumes that omap2430_musb_enable() and > omap2430_musb_disable() is called in a balanced way. The > That fact is broken by the fact that musb_init_controller() calls > musb_platform_disable() to switch from unknown state to off

[PATCH 2/2] usb: dwc3: core: allow device to runtime_suspend several times

After going through runtime_suspend/runtime_resume cycle once we would be left with an unbalanced pm_runtime_get() call. Fix that by making sure that we try to suspend right after resuming so things are balanced and device can runtime_suspend again. Signed-off-by: Felipe Balbi

[PATCH 0232/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0696/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error

On Tue, 2016-08-02 at 09:54 -0400, Robert Foss wrote: > > On 2016-08-02 08:23 AM, Oliver Neukum wrote: > > On Thu, 2016-07-28 at 14:19 -0400, robert.f...@collabora.com wrote: > >> From: Prathmesh Prabhu > >> > >> Implemented queued response handling. This queue is processed

Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error

On 2016-08-02 08:23 AM, Oliver Neukum wrote: On Thu, 2016-07-28 at 14:19 -0400, robert.f...@collabora.com wrote: From: Prathmesh Prabhu Implemented queued response handling. This queue is processed every time the WDM_READ flag is cleared. In case of a read error,

Re: [PATCH 0984/1285] Replace numeric parameter like 0444 with macro

Hi Felipe, >> I find that the developers often just specified the numeric value >> when calling a macro which is defined with a parameter for access permission. >> As we know, these numeric value for access permission have had the >> corresponding macro, >> and that using macro can improve the

Re: [PATCH 0984/1285] Replace numeric parameter like 0444 with macro

Baole Ni writes: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and that using

[PATCH 0975/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

Re: [PATCH] usb: ehci: change order of register cleanup during shutdown

On Tue, 2 Aug 2016, Marc Ohlf wrote: > On Mon, Aug 01, 2016 at 06:07:17PM +0200, Alan Stern wrote: > > On Mon, 1 Aug 2016, Marc Ohlf wrote: > > > > > In ehci_turn_off_all_ports() all EHCI port register bits > > > (except the PORT_RWC_BITS) are set to zero. > > > > Even the PORT_WRC_BITS are set

[PATCH 1/1] Add driver for smsc usb251x i2c configuration

This driver copy the configuration of the controller EEPROM via i2c. Configuration information is available in Documentation/usb/usb251x.txt Signed-off-by: Fabien Lahoudere --- Documentation/devicetree/bindings/usb/usb251x.txt | 27 +++

[PATCH 0990/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue

On Tue 02-08-16 13:44:48, Oliver Neukum wrote: > On Tue, 2016-08-02 at 13:34 +0200, Michal Hocko wrote: > > On Tue 02-08-16 12:03:23, Oliver Neukum wrote: > > > On Tue, 2016-08-02 at 10:18 +0200, Michal Hocko wrote: > > > > On Tue 02-08-16 10:06:12, Oliver Neukum wrote: > > > > > On Mon,

Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue

On Tue, 2016-08-02 at 14:48 +0200, Michal Hocko wrote: > On Tue 02-08-16 13:44:48, Oliver Neukum wrote: > > On Tue, 2016-08-02 at 13:34 +0200, Michal Hocko wrote: > > > On Tue 02-08-16 12:03:23, Oliver Neukum wrote: > > > > On Tue, 2016-08-02 at 10:18 +0200, Michal Hocko wrote: > > > > > On Tue

Re: [PATCH 0987/1285] Replace numeric parameter like 0444 with macro

Baole Ni writes: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and that using

Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error

On Thu, 2016-07-28 at 14:19 -0400, robert.f...@collabora.com wrote: > From: Prathmesh Prabhu > > Implemented queued response handling. This queue is processed every > time the > WDM_READ flag is cleared. > > In case of a read error, userspace may not actually read the

[PATCH 0985/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0988/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

Re: [PATCH 0986/1285] Replace numeric parameter like 0444 with macro

Baole Ni writes: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and that using

[PATCH 0989/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

Re: [PATCH 0982/1285] Replace numeric parameter like 0444 with macro

On Tue, 2 Aug 2016, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and that using

Re: [PATCH 0984/1285] Replace numeric parameter like 0444 with macro

Hi Felipe, >> I find that the developers often just specified the numeric value >> when calling a macro which is defined with a parameter for access permission. >> As we know, these numeric value for access permission have had the >> corresponding macro, >> and that using macro can improve the

[PATCH 0974/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0976/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0977/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0980/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0978/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0982/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error

On 2016-08-02 09:59 AM, Oliver Neukum wrote: On Tue, 2016-08-02 at 09:54 -0400, Robert Foss wrote: On 2016-08-02 08:23 AM, Oliver Neukum wrote: On Thu, 2016-07-28 at 14:19 -0400, robert.f...@collabora.com wrote: From: Prathmesh Prabhu Implemented queued response

[PATCH 0979/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0983/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

Re: [PATCH 1/1] Add driver for smsc usb251x i2c configuration

Hi, On Tue, Aug 02, 2016 at 04:31:54PM +0200, Fabien Lahoudere wrote: > This driver copy the configuration of the controller EEPROM via i2c. > Configuration information is available in Documentation/usb/usb251x.txt > > Signed-off-by: Fabien Lahoudere > --- >

[PATCH 0981/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[PATCH 0984/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

Re: [PATCH 2/2] usb: dwc3: core: allow device to runtime_suspend several times

On Tue, 2 Aug 2016, Felipe Balbi wrote: > After going through runtime_suspend/runtime_resume > cycle once we would be left with an unbalanced > pm_runtime_get() call. Fix that by making sure that > we try to suspend right after resuming so things are > balanced and device can runtime_suspend

Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue

On Tue 02-08-16 15:02:44, Tejun Heo wrote: > Hello, > > On Tue, Aug 02, 2016 at 03:29:48PM +0200, Oliver Neukum wrote: > > Apparently if that is the requirement USB will have to define its own > > set of flags to use in such contexts. But still the calls as currently > > executed work. Taking

[PATCH 0752/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

Re: [PATCH 1/9] usb: gadget: fix usb_ep_align_maybe endianness and new usb_ep_align

Hi Michal, On 27/07/16 20:37, Michal Nazarewicz wrote: > On Tue, Jul 26 2016, Felipe F. Tonello wrote: >> USB spec specifies wMaxPacketSize to be little endian (as other properties), >> so when using this variable in the driver we should convert to the current >> CPU endianness if necessary. >>

[PATCH 0751/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

Re: NEC uPD720200 xHCI Controller dies when Runtime PM enabled

Hello, On Mon, Aug 1, 2016 at 1:44 PM, Durval Menezes wrote: > Hi Mike, > > On Mon, Aug 1, 2016 at 12:05 PM, Mike Murdoch > wrote: > > On 2016-08-01 13:57, Durval Menezes wrote: > > > Hi Mathias, > > > > > > On Mon, Aug 1, 2016 at 8:20 AM,

Re: usbtmc: vendor specific i/o

On Tue, Aug 02, 2016 at 12:09:12PM +0200, Ladislav Michl wrote: > On Tue, Aug 02, 2016 at 11:25:22AM +0200, dave penkler wrote: > >For supportability I would recommend to set the commands depending on the > >recognised HW, not with aA ioctl. See rigol quirk. What are the device > >and

Re: [PATCH] musb: omap2430: do not assume balanced enable()/disable()

On Tue, 2 Aug 2016 03:33:34 -0700 Tony Lindgren wrote: > * Andreas Kemnade [160729 11:14]: > > The code assumes that omap2430_musb_enable() and > > omap2430_musb_disable() is called in a balanced way. The > > That fact is broken by the fact that

Re: [PATCH 2/9] usb: gadget: align buffer size when allocating for OUT endpoint

Hi Michal, On 27/07/16 20:59, Michal Nazarewicz wrote: > On Tue, Jul 26 2016, Felipe F. Tonello wrote: >> Using usb_ep_align() makes sure that the buffer size for OUT endpoints is >> always aligned with wMaxPacketSize (512 usually). This makes sure >> that no buffer has the wrong size, which can

[PATCH 0661/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

Re: [PATCH 7/9] usb: gadget: remove useless parameter in alloc_ep_req()

Hi Michal, On 27/07/16 21:02, Michal Nazarewicz wrote: > On Tue, Jul 26 2016, Felipe F. Tonello wrote: >> This parameter was not really necessary and gadget drivers would almost >> always > > I personally like when commit messages can be read without subject, so > perhaps: > > The

Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue

On Tue, 2016-08-02 at 13:34 +0200, Michal Hocko wrote: > On Tue 02-08-16 12:03:23, Oliver Neukum wrote: > > On Tue, 2016-08-02 at 10:18 +0200, Michal Hocko wrote: > > > On Tue 02-08-16 10:06:12, Oliver Neukum wrote: > > > > On Mon, 2016-08-01 at 10:20 -0400, Tejun Heo wrote: > > > > > Hello, > > >

Re: [PATCH V2 RFC 6/6] ARM: dts: bcm2835: Add Raspberry Pi Zero

On 07/26/2016 12:53 PM, Stefan Wahren wrote: The Raspberry Pi Zero is a minified version of model A+. It's notable there is no PWR LED and the ACT LED is inverted. Patches 3-6, Acked-by: Stephen Warren diff --git a/arch/arm/boot/dts/bcm2835-rpi-zero.dts

[PATCH 1/2] usb: dwc3: pci: runtime_resume child device

During runtime_resume of dwc3-pci.c, we need to runtime our child device (which is dwc3 proper) otherwise nothing will happen. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/dwc3-pci.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] usb: dwc2: Remove deprecated create_singlethread_workqueue

++ Felipe On 7/28/2016 1:27 AM, Bhaktipriya Shridhar wrote: > alloc_ordered_workqueue replaces the deprecated > create_singlethread_workqueue. > > There are multiple work items on the work queue, which require > ordering. Hence, an ordered workqueue has been used. > > The workqueue "wq_otg" is

Re: [PATCH V2 RFC 6/6] ARM: dts: bcm2835: Add Raspberry Pi Zero

Hi Stephen, > Stephen Warren hat am 2. August 2016 um 19:19 > geschrieben: > > > On 07/26/2016 12:53 PM, Stefan Wahren wrote: > > The Raspberry Pi Zero is a minified version of model A+. It's > > notable there is no PWR LED and the ACT LED is inverted. > > Patches 3-6,

Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue

Hello, On Tue, Aug 02, 2016 at 03:29:48PM +0200, Oliver Neukum wrote: > Apparently if that is the requirement USB will have to define its own > set of flags to use in such contexts. But still the calls as currently > executed work. Taking away WQ_MEM_RECLAIM would create danger of > introducing a

Re: [PATCH V2 RFC 6/6] ARM: dts: bcm2835: Add Raspberry Pi Zero

On 08/02/2016 01:29 PM, Stefan Wahren wrote: Hi Stephen, Stephen Warren hat am 2. August 2016 um 19:19 geschrieben: On 07/26/2016 12:53 PM, Stefan Wahren wrote: The Raspberry Pi Zero is a minified version of model A+. It's notable there is no PWR LED and the ACT LED

[RFC PATCH 3/4] usb: typec: USB Type-C Port Manager (tcpm)

This driver implements the USB Type-C Power Delivery state machine for both source and sink ports. Alternate mode support is not fully implemented. The driver attaches to the USB Type-C class code implemented in the following patches. usb: typec: add driver for Intel Whiskey Cove PMIC

[RFC PATCH 4/4] usb: typec: Type-C Port Controller Interface driver (tcpci)

The port controller interface driver interconnects the Type-C Port Manager with a Type-C Port Controller Interface (TCPCI) compliant port controller. Signed-off-by: Guenter Roeck --- drivers/usb/typec/Kconfig | 9 + drivers/usb/typec/Makefile | 1 +

[RFC PATCH 2/4] usb: typec: Do not check if connected when setting roles

The connection status can change after the connection status was checked. Leave it up to the driver to perform the necessary checks. Signed-off-by: Guenter Roeck --- drivers/usb/typec/typec.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/usb/typec/typec.c

[RFC PATCH 0/4] Type-C Port Manager

The following series of patches implements a USB Type-C Port Manager using the pending USB Type-C class code as basis. The code is still WIP (I am still waiting for a final decision on locking in the class code), but I think it is important to get feedback from the community at this point. There

[RFC PATCH 1/4] usb: typec: Drop locking from class code

Drop locking from USB Type-C class code to avoid deadlocks between driver and class code. Signed-off-by: Guenter Roeck --- drivers/usb/typec/typec.c | 196 ++ 1 file changed, 41 insertions(+), 155 deletions(-) diff --git

Re: [PATCH 3/3] usb: gadget: u_ether: fix dereference after null check coverify warning

On Fri, Jul 01, 2016 at 03:33:30PM +0800, Peter Chen wrote: > skb is checked for null pointer at above code, so skb might be null. > eem_wrap uses it without checking null pointer, fix it by adding null > pointer check. > > Signed-off-by: Peter Chen > --- >

Re: usbtmc: vendor specific i/o

On Tue, Aug 02, 2016 at 06:58:11AM +0200, Greg Kroah-Hartman wrote: > On Mon, Aug 01, 2016 at 08:40:02PM +0200, Ladislav Michl wrote: > > Hi, > > > > I need to ask usbtmc device for vendor specific data. What about adding > > ioctl > > which switches MsgIDs to be vendor specific? Or are there

Re: [PATCH] scsi: introduce a quirk for false cache reporting

On Tue, Jul 12, 2016 at 10:24:36AM +0200, Oliver Neukum wrote: > Some SATA to USB bridges fail to cooperate with some > drives resulting in no cache being present being reported > to the host. That causes the host to skip sending > a command to synchronize caches. That causes data loss > when the

Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue

On Mon, 2016-08-01 at 10:20 -0400, Tejun Heo wrote: > Hello, > > If any real IO depends on those devices then this is not sufficient and > > they need some form of guarantee for progress (aka mempool). > > Oliver, Alan, what do you think? If USB itself can't operate without > allocating memory

Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue

On Tue 02-08-16 10:06:12, Oliver Neukum wrote: > On Mon, 2016-08-01 at 10:20 -0400, Tejun Heo wrote: > > Hello, > > > > If any real IO depends on those devices then this is not sufficient and > > > they need some form of guarantee for progress (aka mempool). > > > > Oliver, Alan, what do you

Re: [PATCH v2 1/3] dt: bindings: add bindings for Allwinner A64 usb phy

Hi, Series looks good to me and is: Reviewed-by: Hans de Goede Regards, Hans On 01-08-16 18:34, Icenowy Zheng wrote: Signed-off-by: Icenowy Zheng --- Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt | 1 + 1 file changed, 1 insertion(+)