Re: [PATCH 0/6] USB: serial: kl5kusb105: fixes and clean ups

On Tue, Jan 10, 2017 at 12:05:36PM +0100, Johan Hovold wrote: > This series fixes an information leak, and cleans up the driver > somewhat. All look good to me: Reviewed-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in

Re: [PATCH 08/11] dmaengine: cppi41: Implement the glue for da8xx

* Alexandre Bailon [170110 07:23]: > On 01/10/2017 11:05 AM, Sekhar Nori wrote: > > On DA8xx, CPPI 4.1 DMAengine is not an independent system resource, but > > embedded within the USB 2.0 controller. So, I think all that is needed > > is for MUSB DA8xx glue to trigger probe

Re: [PATCH 0/6] USB: serial: kl5kusb105: fixes and clean ups

On Tue, Jan 10, 2017 at 04:42:25PM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 10, 2017 at 12:05:36PM +0100, Johan Hovold wrote: > > This series fixes an information leak, and cleans up the driver > > somewhat. > > All look good to me: > > Reviewed-by: Greg Kroah-Hartman

Re: [PATCH 1/3] ARM: dts: da850: Add the cppi41 dma node

On 01/09/2017 12:26 PM, Sergei Shtylyov wrote: Hello. On 01/09/2017 07:24 PM, Alexandre Bailon wrote: This adds the device tree node for the cppi41 dma used by the usb otg controller present in the da850 family of SoC's. Signed-off-by: Alexandre Bailon ---

Re: [PATCH 1/3] ARM: dts: da850: Add the cppi41 dma node

On 01/09/2017 07:26 PM, Sergei Shtylyov wrote: > Hello. > > On 01/09/2017 07:24 PM, Alexandre Bailon wrote: > >> This adds the device tree node for the cppi41 dma >> used by the usb otg controller present in the da850 family of SoC's. >> >> Signed-off-by: Alexandre Bailon

Re: [PATCH] usb: musb: fix runtime PM in debugfs

On Tue, Jan 10, 2017 at 05:03:35PM +0100, Greg KH wrote: > On Mon, Jan 09, 2017 at 02:59:39PM -0600, Bin Liu wrote: > > MUSB driver now has runtime PM support, but the debugfs driver misses > > the PM _get/_put() calls, which could cause MUSB register access > > failure. > > > > Cc:

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On 01/10/2017 09:05 AM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Tuesday, January 10, 2017 07:36:35 AM Shuah Khan wrote: >> On 01/10/2017 07:16 AM, Shuah Khan wrote: >>> On 01/10/2017 05:05 AM, Bartlomiej Zolnierkiewicz wrote: Hi, On Monday, January 09, 2017 07:21:31

Re: [PATCH 1/3] ARM: dts: da850: Add the cppi41 dma node

On 01/10/2017 07:15 PM, David Lechner wrote: This adds the device tree node for the cppi41 dma used by the usb otg controller present in the da850 family of SoC's. Signed-off-by: Alexandre Bailon --- arch/arm/boot/dts/da850.dtsi | 16 1 file changed, 16

Re: [PATCHv14 2/3] usb: USB Type-C connector class

On 01/10/2017 12:54 AM, Heikki Krogerus wrote: Hi Guenter, On Mon, Jan 09, 2017 at 08:59:32AM -0800, Guenter Roeck wrote: +/** + * typec_register_partner - Register a USB Type-C Partner + * @port: The USB Type-C Port the partner is connected to + * @desc: Description of the partner + * + *

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On 01/10/2017 07:16 AM, Shuah Khan wrote: > On 01/10/2017 05:05 AM, Bartlomiej Zolnierkiewicz wrote: >> >> Hi, >> >> On Monday, January 09, 2017 07:21:31 PM Shuah Khan wrote: >>> Fix dwc3_exynos_probe() to call clk_prepare_enable() only when suspend >>> clock is specified. Call

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On 01/10/2017 04:20 AM, Sergei Shtylyov wrote: > Hello! > > On 01/10/2017 05:21 AM, Shuah Khan wrote: > >> Fix dwc3_exynos_probe() to call clk_prepare_enable() only when suspend >> clock is specified. Call clk_disable_unprepare() from remove and probe >> error path only when susp_clk has been

Re: Fwd: Raw hid gadget

On Tue, 10 Jan 2017, Greg KH wrote: > On Mon, Jan 09, 2017 at 10:24:42PM +0200, Rogan Dawes wrote: > > Sigh! This got bounced because of HTML parts. > > > > Another question that arises, though: > > > > What sort of performance can I expect writing to and reading from a > > RAW HID gadget,

Re: [PATCH 08/11] dmaengine: cppi41: Implement the glue for da8xx

On 01/10/2017 11:05 AM, Sekhar Nori wrote: > On Tuesday 10 January 2017 03:08 PM, Alexandre Bailon wrote: >> On 01/09/2017 07:08 PM, Grygorii Strashko wrote: >>> >>> >>> On 01/09/2017 10:06 AM, Alexandre Bailon wrote: The da8xx has a cppi41 dma controller. This is add the glue layer

Re: [PATCH] usb: musb: fix runtime PM in debugfs

On Mon, Jan 09, 2017 at 02:59:39PM -0600, Bin Liu wrote: > MUSB driver now has runtime PM support, but the debugfs driver misses > the PM _get/_put() calls, which could cause MUSB register access > failure. > > Cc: sta...@vger.kernel.org # 4.9+ > Acked-by: Tony Lindgren >

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hi, On Tuesday, January 10, 2017 07:36:35 AM Shuah Khan wrote: > On 01/10/2017 07:16 AM, Shuah Khan wrote: > > On 01/10/2017 05:05 AM, Bartlomiej Zolnierkiewicz wrote: > >> > >> Hi, > >> > >> On Monday, January 09, 2017 07:21:31 PM Shuah Khan wrote: > >>> Fix dwc3_exynos_probe() to call

[PATCH v2] usb: musb: fix runtime PM in debugfs

MUSB driver now has runtime PM support, but the debugfs driver misses the PM _get/_put() calls, which could cause MUSB register access failure. Cc: sta...@vger.kernel.org # 4.9+ Acked-by: Tony Lindgren Signed-off-by: Bin Liu --- v2: rebased to v4.10-rc3.

Re: [PATCH net 0/2] r8152: fix autosuspend issue

From: Hayes Wang Date: Tue, 10 Jan 2017 17:04:05 +0800 > Avoid rx is split into two parts when runtime suspend occurs. Series applied and queued up for -stable. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hi, On Tuesday, January 10, 2017 09:28:52 AM Shuah Khan wrote: > On 01/10/2017 09:05 AM, Bartlomiej Zolnierkiewicz wrote: > > > > Hi, > > > > On Tuesday, January 10, 2017 07:36:35 AM Shuah Khan wrote: > >> On 01/10/2017 07:16 AM, Shuah Khan wrote: > >>> On 01/10/2017 05:05 AM, Bartlomiej

Re: Advanced Format SAT devices show incorrect physical block size

On Tue, 10 Jan 2017, Pali Rohár wrote: > Per Tom Yan suggestion I'm forwarding bug from bugzilla to this ML: > https://bugzilla.kernel.org/show_bug.cgi?id=102271 This really should be sent to the linux-scsi mailing list (CC'ed) as well as to linux-usb. > === Dainius Masiliūnas wrote: === > >

Re: Advanced Format SAT devices show incorrect physical block size

Huh, intersting to know. Why would they die on 16 and not on 10? Also, wouldn't the right way to handle it be to use a quirk for broken models, then? Since my disk seems to work fine in that regard. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to

Re: [PATCH] usb: musb: Add support for optional VBUS irq to dsps glue layer

On Thu, Jan 05, 2017 at 11:12:59AM -0800, Tony Lindgren wrote: > We can now configure the PMIC interrupt to provide us VBUS > events. In that case we don't need to constantly poll the > status and can make it optional. This is only wired up > for the mini-B interface on beaglebone. Is it possible

Re: [PATCH 1/2] usb: musb: blackfin: fix unused warnings on suspend/resume

On Fri, Dec 16, 2016 at 07:19:39PM -0500, Jérémy Lefaure wrote: > When CONFIG_PM_SLEEP is disabled, SIMPLE_DEV_PM_OPS does not use > bfin_resume and bfin_suspend even if CONFIG_PM is enabled: > > drivers/usb/musb/blackfin.c:602:12: warning: ‘bfin_resume’ defined but > not used [-Wunused-function]

Re: Advanced Format SAT devices show incorrect physical block size

On Tue, Jan 10, 2017 at 9:00 PM, Alan Stern wrote: > It is used for preventing the kernel from issuing a READ CAPACITY(16) > command to the device. Normally the kernel would do this if the reply > to READ CAPACITY(10) indicated there were more than 2^32 blocks (about >

Re: Advanced Format SAT devices show incorrect physical block size

On Tuesday 10 January 2017 21:02:09 Alan Stern wrote: > Quick summary: READ CAPACITY(10) does not include physical sector > size information whereas READ CAPACITY(16) does. But the kernel > uses READ CAPACITY(10) by default for USB drives, because quite a > few of them die when given a READ

Re: Advanced Format SAT devices show incorrect physical block size

On Tue, 2017-01-10 at 16:00 -0500, Alan Stern wrote: > In theory, I suppose we could change the kernel so that it would > default to READ CAPACITY(16) for devices that report a SCSI level >= > 3, or something along those lines. In general we hesitate to make > changes of this sort, because they

Re: [PATCH v2 2/4] usb: dwc2: Add binding for AHB burst

On 12/19/2016 6:49 AM, Christian Lamparter wrote: > Hello John, hello Felipe > > On Monday, November 28, 2016 7:32:20 PM CET John Youn wrote: >> On 11/22/2016 12:51 PM, Christian Lamparter wrote: >>> On Monday, November 21, 2016 7:32:30 PM CET John Youn wrote: On 11/21/2016 1:10 PM,

Re: Advanced Format SAT devices show incorrect physical block size

(I pressed reply instead of reply to all, sorry. Resending this.) On Tue, Jan 10, 2017 at 8:29 PM, Alan Stern wrote: > There _is_ a quirk for broken models. However, we don't know how > complete the set of quirk entries is, so we err on the side of caution. Then what

Re: [PATCH 4/4] ARM: dts: sun8i: add OTG function to Lichee Pi Zero

On Tue, Jan 03, 2017 at 11:25:34PM +0800, Icenowy Zheng wrote: > Lichee Pi Zero features a USB OTG port. > > Add support for it. > > Note: in order to use the Host mode, the board must be powered via the > +5V and GND pins. > > Signed-off-by: Icenowy Zheng > --- >

Re: [PATCH v2] usb: musb: sunxi: Uses the resource-managed extcon API when registering extcon notifier

On Tue, Jan 10, 2017 at 05:20:38PM +0900, Chanwoo Choi wrote: > Hi Felipe, > > This patch got the acked-by from Bin Liu and. > Could you please apply this patch? I have picked this one. Regards, -Bin. > > On 2016년 12월 30일 13:19, Chanwoo Choi wrote: > > This patch just uses the

Re: Advanced Format SAT devices show incorrect physical block size

On Tue, 10 Jan 2017, Dainius Masiliūnas wrote: > (I pressed reply instead of reply to all, sorry. Resending this.) > > On Tue, Jan 10, 2017 at 8:29 PM, Alan Stern wrote: > > There _is_ a quirk for broken models. However, we don't know how > > complete the set of

Re: Advanced Format SAT devices show incorrect physical block size

On Tue, 10 Jan 2017, Dainius Masiliūnas wrote: > Huh, intersting to know. Why would they die on 16 and not on 10? Also, Probably because they are too old to support READ CAPACITY(16) correctly. > wouldn't the right way to handle it be to use a quirk for broken > models, then? Since my disk

[PATCH] usb: dwc3-exynos remove suspend clock unspecified debug message

dwc3-exynos prints debug message when suspend clock is not specified. The suspend clock is optional and driver can work without it. This debug message doesn't add any value and leads to confusion and concern. Remove it. Signed-off-by: Shuah Khan --- This patch is a

Re: [PATCH v2 2/4] usb: dwc2: Add binding for AHB burst

On Tuesday, January 10, 2017 1:46:56 PM CET John Youn wrote: > On 12/19/2016 6:49 AM, Christian Lamparter wrote: > > (Lot's of old stuff, that doesn't matter anymore) Hello John, > This should be fixed against the latest dwc2 param rework series [1] > which i hope to get queued for 4.11. If you

Re: [PATCH v2 2/2] dmaengine: cppi41: Ignore EINPROGRESS for PM runtime in interrupt handler

On Tue, Jan 10, 2017 at 1:34 PM, Alexandre Bailon wrote: > On 01/09/2017 08:11 PM, Grygorii Strashko wrote: >>> Hmm if the cppi41 interrupt fires, the device has resumed :) >>> >>> I think we should have a cppi41.c specific flag that we can set >>> at the end of

Re: [PATCH] usb: dwc3-exynos fix axius clock error path to do cleanup

Hello Shuah, Patch looks good to me, I've just one comment. On 01/10/2017 08:05 PM, Shuah Khan wrote: > Axius clock error path returns without disabling clock and suspend clock. > Fix it to disable them before returning error. > > Signed-off-by: Shuah Khan > --- >

Re: [PATCH] usb: dwc3-exynos fix axius clock error path to do cleanup

Hello Shuah, On 01/10/2017 09:30 PM, Shuah Khan wrote: [snip] >>> clk_disable_unprepare(exynos->axius_clk); >>> +axius_clk_err: >> >> This label isn't consistent with the others, I know the errN aren't great >> so what about changing those to meaningful names in a preparatory patch? >> >>

[PATCH] usb: dwc3-exynos fix axius clock error path to do cleanup

Axius clock error path returns without disabling clock and suspend clock. Fix it to disable them before returning error. Signed-off-by: Shuah Khan --- drivers/usb/dwc3/dwc3-exynos.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] usb: dwc3-exynos remove suspend clock unspecified debug message

On 01/10/2017 05:18 PM, Javier Martinez Canillas wrote: > Hello Shuah, > > On 01/10/2017 06:20 PM, Shuah Khan wrote: >> dwc3-exynos prints debug message when suspend clock is not specified. >> The suspend clock is optional and driver can work without it. >> >> This debug message doesn't add any

Re: [PATCH] usb: dwc3-exynos remove suspend clock unspecified debug message

Hello Shuah, On 01/10/2017 06:20 PM, Shuah Khan wrote: > dwc3-exynos prints debug message when suspend clock is not specified. > The suspend clock is optional and driver can work without it. > > This debug message doesn't add any value and leads to confusion and > concern. Remove it. > >

Re: [PATCH v2 2/4] usb: dwc2: Add binding for AHB burst

On 1/10/2017 3:03 PM, Christian Lamparter wrote: > On Tuesday, January 10, 2017 1:46:56 PM CET John Youn wrote: >> On 12/19/2016 6:49 AM, Christian Lamparter wrote: >>> (Lot's of old stuff, that doesn't matter anymore) > > Hello John, > >> This should be fixed against the latest dwc2 param

Re: [PATCH] usb: dwc3-exynos fix axius clock error path to do cleanup

On 01/10/2017 05:27 PM, Javier Martinez Canillas wrote: > Hello Shuah, > > Patch looks good to me, I've just one comment. > > On 01/10/2017 08:05 PM, Shuah Khan wrote: >> Axius clock error path returns without disabling clock and suspend clock. >> Fix it to disable them before returning error.

Re: [PATCH] usb: dwc3-exynos fix axius clock error path to do cleanup

On 01/10/2017 05:32 PM, Javier Martinez Canillas wrote: > Hello Shuah, > > On 01/10/2017 09:30 PM, Shuah Khan wrote: > > [snip] > clk_disable_unprepare(exynos->axius_clk); +axius_clk_err: >>> >>> This label isn't consistent with the others, I know the errN aren't great >>> so what

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hi Krzysztof, On Tuesday 10 January 2017 11:55 PM, Krzysztof Kozlowski wrote: > On Tue, Jan 10, 2017 at 06:09:40PM +0100, Bartlomiej Zolnierkiewicz wrote: >> BTW What is interesting is that the Exynos7 dts patch [2] has never >> made it into upstream for some reason. In the meantime however >>

Re: [PATCH v2 0/6] usb: Replace the deprecated extcon API

Hi Felipe, These patches have already acked-by tag from you. Could you please apply them if there is additional comment? On 2016년 12월 30일 13:08, Chanwoo Choi wrote: > This patches just replace the deprecated extcon API without any change > of extcon operation and use the resource-managed

Re: [PATCHv14 2/3] usb: USB Type-C connector class

On Tue, Jan 10, 2017 at 11:08:51AM +0100, Oliver Neukum wrote: > > And since we are talking about the ABI, can we also change the listing > > of the accessory mode back to just "audio" and "debug" like I > > originally had it? I don't remember who and why wanted it to be > > changed to "Audio

Re: [PATCHv14 2/3] usb: USB Type-C connector class

On Tue, Jan 10, 2017 at 04:46:12PM +0200, Heikki Krogerus wrote: > On Tue, Jan 10, 2017 at 05:50:04AM -0800, Guenter Roeck wrote: > > On 01/10/2017 12:54 AM, Heikki Krogerus wrote: > > > Hi Guenter, > > > > > > On Mon, Jan 09, 2017 at 08:59:32AM -0800, Guenter Roeck wrote: > > > > > +/** > > > >

Re: [PATCH 01/11] dmaengine: cppi41: rename platform variables

Hello! On 01/09/2017 07:06 PM, Alexandre Bailon wrote: Currently, only the am335x is supported by the driver. Though the driver has a glue layer to support different platforms, some platform variable names are not prefixed with the platform name. To facilitate the addition of a new platform,

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On 2017-01-10 22:39, Bartlomiej Zolnierkiewicz wrote: Hi, On Tuesday, January 10, 2017 09:28:52 AM Shuah Khan wrote: On 01/10/2017 09:05 AM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Tuesday, January 10, 2017 07:36:35 AM Shuah Khan wrote: >> On 01/10/2017 07:16 AM, Shuah Khan wrote: >>>

Re: [PATCH 09/11] dmaengine: cppi41: Fix a race between PM runtime and channel abort

On 01/09/2017 07:06 PM, Alexandre Bailon wrote: cppi41_dma_issue_pending() may be called while the device is runtime suspended. In that case, the descritpor will be push to the pending "Descriptor" and "pushed". list and then be queued to hardware queue. But if cppi41_stop_chan() is

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hi, On Tuesday, January 10, 2017 11:23:38 PM Anand Moon wrote: > Hi Shuah, > > On 10 January 2017 at 21:58, Shuah Khan wrote: > > On 01/10/2017 09:05 AM, Bartlomiej Zolnierkiewicz wrote: > >> > >> Hi, > >> > >> On Tuesday, January 10, 2017 07:36:35 AM Shuah Khan wrote:

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On Tue, Jan 10, 2017 at 06:09:40PM +0100, Bartlomiej Zolnierkiewicz wrote: > BTW What is interesting is that the Exynos7 dts patch [2] has never > made it into upstream for some reason. In the meantime however > Exynos5433 (similar to Exynos7 to some degree) became the user of > susp_clk. > >

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On Tuesday, January 10, 2017 07:03:57 PM Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Tuesday, January 10, 2017 11:23:38 PM Anand Moon wrote: > > Hi Shuah, > > > > On 10 January 2017 at 21:58, Shuah Khan wrote: > > > On 01/10/2017 09:05 AM, Bartlomiej Zolnierkiewicz

Re: [PATCH 02/11] dmaengine: cppi41: Split out the interrupt handler

Hello. On 01/09/2017 07:06 PM, Alexandre Bailon wrote: The current interrupt handler do some actions specifics to am335x. These actions should be made by the platform interrupt handler. Split out the interrupt handler in two: one for the am335x platform and a generic one. Signed-off-by:

Re: [PATCH 08/11] dmaengine: cppi41: Implement the glue for da8xx

On 01/09/2017 07:06 PM, Alexandre Bailon wrote: The da8xx has a cppi41 dma controller. It's called CPPI 4.1. :-) This is add the glue layer required to make it work on da8xx, as well some changes in driver (e.g to manage clock). Signed-off-by: Alexandre Bailon ---

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hi Shuah, On 10 January 2017 at 21:58, Shuah Khan wrote: > On 01/10/2017 09:05 AM, Bartlomiej Zolnierkiewicz wrote: >> >> Hi, >> >> On Tuesday, January 10, 2017 07:36:35 AM Shuah Khan wrote: >>> On 01/10/2017 07:16 AM, Shuah Khan wrote: On 01/10/2017 05:05 AM,

Re: [PATCH v3] USB: Add uPD78F0730 USB to Serial Adaptor Driver

Hi Johan, Thanks for feedback. > > * Dropped inversion of DTR and RTS signals > > Did you figure out whether this was needed or not, for example by > comparing to the hardware flow control levels? The current version matches the Windows driver. I don't have any other adapters at the moment,

RE: [PATCH v8 1/2] usbip: vhci extension: modifications to userspace

Dear Shuah, I wrote revised change log draft as below. Please, let me know if it's not enough. --- 1. Summary This series of patches extends number of ports limitation in application (vhci) side. Driver portion of 'static' extension has been merged at 4.9-rc1. This patch is the userspace

RE: [PATCH v8 2/2] usbip: vhci extension: dynamic extension

Dear Shuah, I wrote revised change log draft as below. It may be short enough but I hope it's acceptable. The dynamic extension is added regarding following review comments. [1] http://www.mail-archive.com/linux-usb@vger.kernel.org/msg68936.html [2]

Re: [PATCHv14 2/3] usb: USB Type-C connector class

On Tue, Jan 10, 2017 at 05:50:04AM -0800, Guenter Roeck wrote: > On 01/10/2017 12:54 AM, Heikki Krogerus wrote: > > Hi Guenter, > > > > On Mon, Jan 09, 2017 at 08:59:32AM -0800, Guenter Roeck wrote: > > > > +/** > > > > + * typec_register_partner - Register a USB Type-C Partner > > > > + * @port:

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hi Bartlomiej, On 10 January 2017 at 23:33, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Tuesday, January 10, 2017 11:23:38 PM Anand Moon wrote: >> Hi Shuah, >> >> On 10 January 2017 at 21:58, Shuah Khan wrote: >> > On 01/10/2017 09:05 AM,

[PATCH] usb: isp1760: constify usb_gadget_ops structures

Declare usb_gadget_ops structures as const as they are only stored in the ops field of a usb_gadget structure. This field is of type const, so usb_gadget_ops structures having this property can be declared const too. Done using Coccinelle: @r1 disable optional_qualifier@ identifier i; position p;

[PATCH] usb: gadget: constify usb_gadget_ops structures

Declare usb_gadget_ops structures as const as they are only stored in the ops field of a usb_gadget structure. This field is of type const, so usb_gadget_ops structures having this property can be declared const too. Done using Coccinelle: @r1 disable optional_qualifier@ identifier i; position p;

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On 01/10/2017 11:23 AM, Bartlomiej Zolnierkiewicz wrote: > On Tuesday, January 10, 2017 07:03:57 PM Bartlomiej Zolnierkiewicz wrote: >> >> Hi, >> >> On Tuesday, January 10, 2017 11:23:38 PM Anand Moon wrote: >>> Hi Shuah, >>> >>> On 10 January 2017 at 21:58, Shuah Khan

Re: [PATCH 13/21] usb: dwc2: Update parameter types

On 1/10/2017 3:24 AM, Sergei Shtylyov wrote: > On 01/10/2017 05:24 AM, John Youn wrote: > >> Update the param types to appropriately sized ints and bools. >> >> Signed-off-by: John Youn >> --- >> drivers/usb/dwc2/core.h | 52 >>

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On 01/10/2017 11:59 AM, Krzysztof Kozlowski wrote: > On Tue, Jan 10, 2017 at 11:37:24AM -0700, Shuah Khan wrote: >> On 01/10/2017 11:23 AM, Bartlomiej Zolnierkiewicz wrote: >>> I also think that regardless of what is decided on making susp_clk >>> non-optional for some Exynos SoCs we should

Advanced Format SAT devices show incorrect physical block size

Per Tom Yan suggestion I'm forwarding bug from bugzilla to this ML: https://bugzilla.kernel.org/show_bug.cgi?id=102271 === Dainius Masiliūnas wrote: === When using an Advanced Format drive connected through a SCSI-to-ATA Translation device, the physical block size reported by the kernel (in

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On Tue, Jan 10, 2017 at 11:37:24AM -0700, Shuah Khan wrote: > On 01/10/2017 11:23 AM, Bartlomiej Zolnierkiewicz wrote: > > I also think that regardless of what is decided on making susp_clk > > non-optional for some Exynos SoCs we should probably remove the debug > > message as it doesn't bring

Re: VL805 USB 3.0 does not see connected devices (only on x86_64) (x86 is ok)

hi! Using 4.9.2 kernel. Still no success with VL805 USB 3.0 i can give a remote shell to test and reproduce the bug any help? 2016-09-23 0:47 GMT+03:00 c400 : > btw > i've tested a liitle better and the disk is visible, but write errors occurs > after ejecting and inserting

Re: [PATCH 4/4] usb: musb: musb_cppi41: Workaround dma stall issue during teardown

On 01/09/2017 07:34 PM, Sergei Shtylyov wrote: > Hello! > > On 01/09/2017 07:39 PM, Alexandre Bailon wrote: > >> The dma may hung up if a teardown is initiated while an endpoint is still > >The DMA may hang up... > >> active (Advisory 2.3.27 of da8xx errata). >> To workaround this issue,

Re: [PATCHv14 2/3] usb: USB Type-C connector class

On Fri, 2017-01-06 at 12:54 +0200, Heikki Krogerus wrote: > Hi guys, > > On Thu, Jan 05, 2017 at 05:54:02PM +0200, Mika Westerberg wrote: > > I wonder if "source sink" instead is better? Along the lines of > > /sys/power/state. > > > > Then you can print "[source] sink" when source is selected

Re: [PATCH 07/11] dt/bindings: da8xx-usb: Add binding for the cppi41 dma controller

Hello, On 01/09/2017 07:41 PM, Sergei Shtylyov wrote: > Hello! > > On 01/09/2017 07:06 PM, Alexandre Bailon wrote: > >> DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx cppi41 dma controller. > >It's called CPPI 4.1, not cppi41. >Let me introduce myself: I was the author of the 1st

Re: [PATCH 11/11] dmaengine: cppi41: Fix teardown warnings

On 01/09/2017 07:46 PM, Sergei Shtylyov wrote: > On 01/09/2017 07:06 PM, Alexandre Bailon wrote: > >> During the teardown of a RX channel, because there is only one >> completion queue available for RX channel, descriptor of another >> channel may be popped which will cause 2 warnings: >> - the

Re: [PATCH 08/11] dmaengine: cppi41: Implement the glue for da8xx

On Tuesday 10 January 2017 03:08 PM, Alexandre Bailon wrote: > On 01/09/2017 07:08 PM, Grygorii Strashko wrote: >> >> >> On 01/09/2017 10:06 AM, Alexandre Bailon wrote: >>> The da8xx has a cppi41 dma controller. >>> This is add the glue layer required to make it work on da8xx, >>> as well some

[PATCH 4/6] USB: serial: kl5kusb105: clean up struct definition

Drop redundant packed attribute from the port-settings struct which is already 1-byte aligned. Also replace __u8 with u8 for the field types as this is not a structure we share with user space. Signed-off-by: Johan Hovold --- drivers/usb/serial/kl5kusb105.c | 12 ++--

[PATCH 5/6] USB: serial: kl5kusb105: remove unused termios structure

Remove unused termios structure from private data that was left by an earlier purge by commit b1cff285ae8d ("usb serial: Eliminate bogus ioctl code"). Signed-off-by: Johan Hovold --- drivers/usb/serial/kl5kusb105.c | 11 --- 1 file changed, 11 deletions(-) diff --git

[PATCH 1/6] USB: serial: kl5kusb105: fix line-state error handling

The current implementation failed to detect short transfers when attempting to read the line state, and also, to make things worse, logged the content of the uninitialised heap transfer buffer. Fixes: abf492e7b3ae ("USB: kl5kusb105: fix DMA buffers on stack") Fixes: 1da177e4c3f4

[PATCH 6/6] USB: serial: kl5kusb105: fix port-settings error handling

Fix port-settings error handling in order to detect a short transfer. Note that this currently only implies that an error is logged. Signed-off-by: Johan Hovold --- drivers/usb/serial/kl5kusb105.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[PATCH 2/6] USB: serial: kl5kusb105: make logging less verbose

Replace a couple of dev_info with dev_dbg and remove another. Also use the port device for logging, and include a radix prefix when logging the baudrate. Signed-off-by: Johan Hovold --- drivers/usb/serial/kl5kusb105.c | 16 1 file changed, 8 insertions(+), 8

[PATCH 3/6] USB: serial: kl5kusb105: remove dead code

Remove dead and broken code that only served as a reminder to one day implement modem control. Signed-off-by: Johan Hovold --- drivers/usb/serial/kl5kusb105.c | 76 + 1 file changed, 8 insertions(+), 68 deletions(-) diff --git

[PATCH 0/6] USB: serial: kl5kusb105: fixes and clean ups

This series fixes an information leak, and cleans up the driver somewhat. Johan Johan Hovold (6): USB: serial: kl5kusb105: fix line-state error handling USB: serial: kl5kusb105: make logging less verbose USB: serial: kl5kusb105: remove dead code USB: serial: kl5kusb105: clean up struct

[PATCH net 1/2] r8152: split rtl8152_suspend function

Split rtl8152_suspend() into rtl8152_system_suspend() and rtl8152_rumtime_suspend(). Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 57 ++--- 1 file changed, 40 insertions(+), 17 deletions(-) diff --git

[PATCH net 2/2] r8152: fix rx issue for runtime suspend

Pause the rx and make sure the rx fifo is empty when the autosuspend occurs. If the rx data comes when the driver is canceling the rx urb, the host controller would stop getting the data from the device and continue it after next rx urb is submitted. That is, one continuing data is split into two

[PATCH net 0/2] r8152: fix autosuspend issue

Avoid rx is split into two parts when runtime suspend occurs. Hayes Wang (2): r8152: split rtl8152_suspend function r8152: fix rx issue for runtime suspend drivers/net/usb/r8152.c | 80 +++-- 1 file changed, 64 insertions(+), 16 deletions(-) --

Re: [PATCHv14 2/3] usb: USB Type-C connector class

Hi Guenter, On Mon, Jan 09, 2017 at 08:59:32AM -0800, Guenter Roeck wrote: > > +/** > > + * typec_register_partner - Register a USB Type-C Partner > > + * @port: The USB Type-C Port the partner is connected to > > + * @desc: Description of the partner > > + * > > + * Registers a device for USB

Re: [PATCH v2] usb: musb: sunxi: Uses the resource-managed extcon API when registering extcon notifier

Hi Felipe, This patch got the acked-by from Bin Liu and. Could you please apply this patch? On 2016년 12월 30일 13:19, Chanwoo Choi wrote: > This patch just uses the resource-managed extcon API when registering > the extcon notifier. > > Signed-off-by: Chanwoo Choi >

Re: [PATCH 08/11] dmaengine: cppi41: Implement the glue for da8xx

On 01/09/2017 07:08 PM, Grygorii Strashko wrote: > > > On 01/09/2017 10:06 AM, Alexandre Bailon wrote: >> The da8xx has a cppi41 dma controller. >> This is add the glue layer required to make it work on da8xx, >> as well some changes in driver (e.g to manage clock). >> >> Signed-off-by:

Re: [PATCH v2 1/2] dmaengine: cppi41: Fix list not empty warning on runtime suspend

On 01/09/2017 07:16 PM, Grygorii Strashko wrote: > > > On 01/09/2017 11:03 AM, Alexandre Bailon wrote: >> Sometime, a transfer may not be queued due to a race between runtime pm >> and cppi41_dma_issue_pending(). >> Sometime, cppi41_runtime_resume() may be interrupted right before to >> update

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hello! On 01/10/2017 05:21 AM, Shuah Khan wrote: Fix dwc3_exynos_probe() to call clk_prepare_enable() only when suspend clock is specified. Call clk_disable_unprepare() from remove and probe error path only when susp_clk has been set from remove and probe error paths. Signed-off-by: Shuah

Re: [PATCH v2 2/2] dmaengine: cppi41: Ignore EINPROGRESS for PM runtime in interrupt handler

On 01/09/2017 08:11 PM, Grygorii Strashko wrote: > > > On 01/09/2017 12:39 PM, Tony Lindgren wrote: >> * Alexandre Bailon [170109 09:04]: >>> We can occasionally get -EINPROGRESS for pm_runtime_get. >>> This is happening when an interrupt is fired before PM runtime had

Re: [PATCH 13/21] usb: dwc2: Update parameter types

On 01/10/2017 05:24 AM, John Youn wrote: Update the param types to appropriately sized ints and bools. Signed-off-by: John Youn --- drivers/usb/dwc2/core.h | 52 - 1 file changed, 26 insertions(+), 26 deletions(-) diff

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hi, On Monday, January 09, 2017 07:21:31 PM Shuah Khan wrote: > Fix dwc3_exynos_probe() to call clk_prepare_enable() only when suspend > clock is specified. Call clk_disable_unprepare() from remove and probe > error path only when susp_clk has been set from remove and probe error > paths. It is

Re: [PATCH v5 0/6] inherit dma configuration from parent dev

On 05/01/17 19:16, Greg KH wrote: > On Thu, Jan 05, 2017 at 05:21:09PM +0200, Roger Quadros wrote: >> Hi, >> >> On 17/11/16 13:43, Sriram Dash wrote: >>> For xhci-hcd platform device, all the DMA parameters are not >>> configured properly, notably dma ops for dwc3 devices. >>> >>> The idea here is

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On 01/10/2017 05:05 AM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Monday, January 09, 2017 07:21:31 PM Shuah Khan wrote: >> Fix dwc3_exynos_probe() to call clk_prepare_enable() only when suspend >> clock is specified. Call clk_disable_unprepare() from remove and probe >> error path only