RE: [RFC/RFT usb-next v1 5/6] usb: chipidea: do not set the "phy" field in struct usb_hcd

2018-01-26 Thread Peter Chen
> > Now that usb_add_hcd parses all generic PHYs anyways the code which skips > initialization of a single PHY will go away. > Remove the code which sets struct usb_hcd's phy field from the chipidea > driver as > this field will go away soon. > > Signed-off-by: Martin Blumenstingl

Re: uvcvideo: Failed to resubmit video URB (-1).

2018-01-26 Thread Greg KH
On Thu, Jan 25, 2018 at 01:37:45PM -0300, Cristian wrote: > Hello, > > Open bug in bugzilla.kernel.org > https://bugzilla.kernel.org/show_bug.cgi?id=198575 > > dmesg: > [ 6529.509530] uvcvideo: Failed to resubmit video URB (-1). Does that mean the device does not work? What happened when this

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

2018-01-26 Thread Tomas Paukrt
Hi Maxim, unfortunately we cannot test the latest kernel right now, because we have custom drivers and additional changes that need to be ported, but the MUSB driver in our kernel should contain all fixes from

[PATCH 01/14] usb: dwc2: Rename hibernation to partial_power_down

2018-01-26 Thread Grigor Tovmasyan
From: Vardan Mikayelyan No-op change, only rename. This code was misnamed originally. It was only responsible for partial power down and not for hibernation. Rename core_params->hibernation to core_params->power_down, dwc2_set_param_hibernation() to

[PATCH 03/14] usb: dwc2: gadget: Moved dtxfsiz backup array place

2018-01-26 Thread Grigor Tovmasyan
From: Vardan Mikayelyan Moved dtxfsiz from dwc2_gregs_backup to dwc2_dregs_backup, because it is device register. Signed-off-by: Vardan Mikayelyan Signed-off-by: John Youn Signed-off-by: Grigor Tovmasyan

[PATCH 04/14] usb: dwc2: gadget: Fix dwc2_restore_device_registers

2018-01-26 Thread Grigor Tovmasyan
From: Vardan Mikayelyan Add parameter remote_wakeup to dwc2_restore_device_registers() to be able to restore device registers according to programming guide for dwc-otg. It says that in case of rem_wakeup DCTL must not be restored here. Remove setting of DCTL_PWRONPRGDONE

[PATCH 05/14] usb: dwc2: core: Add hibernated flag

2018-01-26 Thread Grigor Tovmasyan
From: Vardan Mikayelyan Added a flag to indicate that core is in hibernation, it is used to determine the hibernation state of the core. Signed-off-by: Vardan Mikayelyan Signed-off-by: John Youn Signed-off-by: Grigor Tovmasyan

[PATCH 06/14] usb: dwc2: gadget: Add remote_wakeup_allowed flag

2018-01-26 Thread Grigor Tovmasyan
From: Vardan Mikayelyan It will be set once corresponding set_feature command comes. True if device is allowed to wake-up host by remote-wakeup signalling. This is preparation for remote wake-up support implementation, it will not be implemented until gadget stack provide

Re: USB-C Devices only show up if connected at boot

2018-01-26 Thread Mika Westerberg
On Fri, Jan 26, 2018 at 08:07:56AM +, Mike Lothian wrote: > Whether CONFIG_HOTPLUG_PCI_ACPI=y or CONFIG_HOTPLUG_PCI_ACPI=n the > device doesn't show unless echo 1 > /sys/bus/pci/rescan is issued That's not how it is supposed to work. Please send me full dmesg and in addition acpidump of the

Re: [PATCH 4.4 0/4] Backport missing sccurity and deadlock fix

2018-01-26 Thread Greg KH
On Thu, Jan 25, 2018 at 11:37:40AM -0700, Shuah Khan wrote: > As I started backporting security fixes, I found a deadlock bug that was > fixed in a later release. This patch series contains backports for all > these problems. All now queued up, thanks for the backports. greg k-h -- To

[PATCH 14/14] usb: dwc2: Enable power down

2018-01-26 Thread Grigor Tovmasyan
From: John Youn Enable the power down option based on the core capability. Signed-off-by: John Youn Signed-off-by: Vardan Mikayelyan Signed-off-by: Artur Petrosyan Signed-off-by: Grigor Tovmasyan

Re: USB-C Devices only show up if connected at boot

2018-01-26 Thread Mike Lothian
On 26 January 2018 at 08:31, Mika Westerberg wrote: > On Fri, Jan 26, 2018 at 08:07:56AM +, Mike Lothian wrote: >> Whether CONFIG_HOTPLUG_PCI_ACPI=y or CONFIG_HOTPLUG_PCI_ACPI=n the >> device doesn't show unless echo 1 > /sys/bus/pci/rescan is issued > >

[PATCH 09/14] usb: dwc2: Add host/device hibernation functions

2018-01-26 Thread Grigor Tovmasyan
From: Vardan Mikayelyan Add host/device hibernation functions which must be wrapped by core's dwc2_enter_hibernation()/dwc2_exit_hibernation() functions. Make dwc2_backup_global_registers dwc2_restore_global_register non-static to use them in both host/gadget sides.

[PATCH 08/14] usb: dwc2: Add helper functions for restore routine

2018-01-26 Thread Grigor Tovmasyan
From: Vardan Mikayelyan Add common (host/device) helper functions, which will be called while exiting from hibernation, from both sides. dwc2_restore_essential_regs() dwc2_hib_restore_common() Signed-off-by: Vardan Mikayelyan Signed-off-by: John

[PATCH 07/14] usb: dwc2: Changes in registers backup/restore functions

2018-01-26 Thread Grigor Tovmasyan
From: Vardan Mikayelyan Move hptxfsiz to host register's backup/restore functions, not needed to have it in global register's backup/restore functions. Add backup for glpmcfg, and read/write for gi2cctl and pcgcctl. As requires programming guide. Affected functions:

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

2018-01-26 Thread Maxim Uvarov
Bin, I looked to my local git and code does not have this latest line "goto finish". It was tested without it and everything worked. Right now I can not get access to that hardware to check with and without. But only can confirm that without "goto finish" function works with bunch of drivers

[PATCH 02/14] usb: dwc2: Add hibernation field into dwc2_hw_params

2018-01-26 Thread Grigor Tovmasyan
From: Vardan Mikayelyan Add parameter and it's initialization, needed for hibernation. Reimplement dwc2_set_param_power_down() to support hibernation too. Now 'power_down' parameter can be initialized with 0, 1 or 2. 0 - No 1 - Partial power down 2 - Hibernation

[PATCH 00/14] usb: dwc2: Add hibernation support

2018-01-26 Thread Grigor Tovmasyan
This series contains patches which are already have been sent in "usb: dwc2: fixes, enhancements and new features" series. That patch series was too large, and based on community feedbacks decided to split that series into small pieces. This is a fourth and last part. In this series we included

[PATCH 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

2018-01-26 Thread Grigor Tovmasyan
From: Vardan Mikayelyan These are wrapper functions which are calling device or host enter/exit hibernation functions. Signed-off-by: Vardan Mikayelyan Signed-off-by: John Youn Signed-off-by: Grigor Tovmasyan

[PATCH 11/14] usb: dwc2: Allow entering hibernation from USB_SUSPEND interrupt

2018-01-26 Thread Grigor Tovmasyan
From: Vardan Mikayelyan Do changes to allow entering hibernated state from USB_SUSPEND interrupt. All code is added under if conditions and mustn't impact existing functionality. Signed-off-by: Vardan Mikayelyan Signed-off-by: John Youn

[PATCH 12/14] usb: dwc2: Add dwc2_handle_gpwrdn_intr() handler

2018-01-26 Thread Grigor Tovmasyan
From: Vardan Mikayelyan The GPWRDN interrupts are those that occur in both Host and Device mode while core is in hibernated state. Export dwc2_core_init to be able to use it in GPWRDN_IDSTS interrupt handler. Here we have duplicated init functions in host and gadget sides

[PATCH 13/14] usb: dwc2: Change hub-control to allow hibernation

2018-01-26 Thread Grigor Tovmasyan
From: Vardan Mikayelyan Affected cases: ClearPortFeature's USB_PORT_FEAT_SUSPEND SetPortFeature's USB_PORT_FEAT_SUSPEND USB_PORT_FEAT_RESET Signed-off-by: Vardan Mikayelyan Signed-off-by: John Youn Signed-off-by: Grigor

Re: USB-C Devices only show up if connected at boot

2018-01-26 Thread Mike Lothian
On 26 January 2018 at 06:33, Mika Westerberg wrote: > On Thu, Jan 25, 2018 at 10:20:02PM +, Mike Lothian wrote: >> I've just tried this and the USB-C device was detected :D This is the >> first time it's ever been detected after boot >> >> 02:00.0 PCI bridge:

Re: dvb usb issues since kernel 4.9

2018-01-26 Thread Mauro Carvalho Chehab
Hi Alan, Em Mon, 8 Jan 2018 14:15:35 -0500 (EST) Alan Stern escreveu: > On Mon, 8 Jan 2018, Linus Torvalds wrote: > > > Can somebody tell which softirq it is that dvb/usb cares about? > > I don't know about the DVB part. The USB part is a little difficult to >

[PATCH] USB: wusbcore: remove redundant re-assignment to pointer 'dev'

2018-01-26 Thread Colin King
From: Colin Ian King Pointer dev is initialized and then re-assigned with the same value a little later, hence the second assignment is redundant and can be removed. Cleans up clang warning: drivers/usb/wusbcore/wa-nep.c:88:17: warning: Value stored to 'dev' during its

[PATCH] USB: gadget: function: remove redundant initialization of 'tv_nexus'

2018-01-26 Thread Colin King
From: Colin Ian King Pointer tv_nexus is being initialized a value and this is never read and is later being updated with the same value. Remove the redundant initialization so that the assignment to tv_nexus is performed later and more local to when it is being read.

how to disable a xhci logical port?

2018-01-26 Thread Bin Liu
Hi, A xHCI controller has two logical ports, hs and ss port. Is it possible to disable one port, for example the ss port? If so, how? By disable, I meant the xHCI driver doesn't see the port when the xHCI driver is loaded and doesn't create that usb bus. Thanks, -Bin. -- To unsubscribe from

[PATCH 4.4] usbip: vhci_hcd: clear just the USB_PORT_STAT_POWER bit

2018-01-26 Thread Shuah Khan
Upstream commit 1c9de5bf4286 ("usbip: vhci-hcd: Add USB3 SuperSpeed support") vhci_hcd clears all the bits port_status bits instead of clearing just the USB_PORT_STAT_POWER bit when it handles ClearPortFeature: USB_PORT_FEAT_POWER. This causes vhci_hcd attach to fail in a bad state, leaving

[PATCH 4.9] usbip: vhci_hcd: clear just the USB_PORT_STAT_POWER bit

2018-01-26 Thread Shuah Khan
Upstream commit 1c9de5bf4286 ("usbip: vhci-hcd: Add USB3 SuperSpeed support") vhci_hcd clears all the bits port_status bits instead of clearing just the USB_PORT_STAT_POWER bit when it handles ClearPortFeature: USB_PORT_FEAT_POWER. This causes vhci_hcd attach to fail in a bad state, leaving

[PATCH] usbip: keep usbip_device sockfd state in sync with tcp_socket

2018-01-26 Thread Shuah Khan
Keep usbip_device sockfd state in sync with tcp_socket. When tcp_socket is reset to null, reset sockfd to -1 to keep it in sync. Signed-off-by: Shuah Khan Cc: sta...@vger.kernel.org --- drivers/usb/usbip/stub_dev.c | 3 +++ drivers/usb/usbip/vhci_hcd.c | 2 ++ 2 files

Re: dvb usb issues since kernel 4.9

2018-01-26 Thread Mauro Carvalho Chehab
Em Fri, 26 Jan 2018 12:17:37 -0200 Mauro Carvalho Chehab escreveu: > Hi Alan, > > Em Mon, 8 Jan 2018 14:15:35 -0500 (EST) > Alan Stern escreveu: > > > On Mon, 8 Jan 2018, Linus Torvalds wrote: > > > > > Can somebody tell which softirq it

Re: [RFC/RFT usb-next v1 5/6] usb: chipidea: do not set the "phy" field in struct usb_hcd

2018-01-26 Thread Martin Blumenstingl
Hi Peter, On Fri, Jan 26, 2018 at 10:06 AM, Peter Chen wrote: > >> >> Now that usb_add_hcd parses all generic PHYs anyways the code which skips >> initialization of a single PHY will go away. >> Remove the code which sets struct usb_hcd's phy field from the chipidea >>

Re: [PATCH] USB: wusbcore: remove redundant re-assignment to pointer 'dev'

2018-01-26 Thread Johan Hovold
On Fri, Jan 26, 2018 at 03:07:12PM +, Colin King wrote: > From: Colin Ian King > > Pointer dev is initialized and then re-assigned with the same value > a little later, hence the second assignment is redundant and can be > removed. > > Cleans up clang warning: >