Re: [PATCH] Fix big-endian application issue for MUSB gadget

2018-08-02 Thread Bin Liu
Hi, On Thu, Jul 26, 2018 at 12:52:53PM +, Alexey Spirkov wrote: > Existing code is not applicable to big-endian machines > ctrlrequest fields received in USB endian - i.e. in little-endian > and should be converted to cpu endianness before usage. > > Signed-off-by: Alexey Spirkov > --- >

Re: usb: dynamic suspend

2018-08-02 Thread Muni Sekhar
On Thu, Aug 2, 2018 at 8:21 PM, Alan Stern wrote: > On Thu, 2 Aug 2018, Muni Sekhar wrote: > >> On Thu, Aug 2, 2018 at 7:08 PM, Alan Stern wrote: >> > On Thu, 2 Aug 2018, Muni Sekhar wrote: >> > >> >> [ Please keep me in CC as I'm not subscribed to the list] >> >> >> >> >> >> Hello All, >> >> >>

Re: [PATCH] Fix memory issue in non-DMA mode for MUSB gadget

2018-08-02 Thread Bin Liu
On Thu, Aug 02, 2018 at 11:14:32AM -0500, Bin Liu wrote: > Hi, > > On Thu, Jul 26, 2018 at 12:52:57PM +, Alexey Spirkov wrote: > > dma_mapping_error function unable to works in PowerPC arch > > when MUSB do not use DMA (illegal memory access). Proposed > > patch replace its usage to usual

Re: [PATCH] Fix memory issue in non-DMA mode for MUSB gadget

2018-08-02 Thread Bin Liu
Hi, On Thu, Jul 26, 2018 at 12:52:57PM +, Alexey Spirkov wrote: > dma_mapping_error function unable to works in PowerPC arch > when MUSB do not use DMA (illegal memory access). Proposed > patch replace its usage to usual define for checking DMA mapping. > > Signed-off-by: Alexey Spirkov >

Re: [PATCH] Fix big-endian application issue for MUSB gadget

2018-08-02 Thread Bin Liu
On Thu, Aug 02, 2018 at 11:44:00AM -0500, Bin Liu wrote: > Hi, > > On Thu, Jul 26, 2018 at 12:52:53PM +, Alexey Spirkov wrote: > > Existing code is not applicable to big-endian machines > > ctrlrequest fields received in USB endian - i.e. in little-endian > > and should be converted to cpu

Re: usb: dynamic suspend

2018-08-02 Thread Alan Stern
On Thu, 2 Aug 2018, Muni Sekhar wrote: > I see that CONFIG_PM_RUNTIME & CONFIG_USB_SUSPEND are not enabled. Is that > fine? The CONFIG_PM_RUNTIME and CONFIG_USB_SUSPEND symbols are no longer used. > The device is using btusb driver. Does unloading the driver helps? It should. > I ran ‘lsof’

Re: [PATCH 2/3] usb: dwc3: gadget: Don't skip updating remaining data

2018-08-02 Thread Thinh Nguyen
On 8/2/2018 12:46 AM, Felipe Balbi wrote: > Hi, > > Thinh Nguyen writes: > > > >>> These patches will not fix the issue. >>> >> What do you think of this fix? >> >> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c >> index f452ab708ffc..338f7ab8a8b4 100644 >> ---

[PATCH] usb: dwc3: gadget: Properly check last unaligned/zero chain TRB

2018-08-02 Thread Thinh Nguyen
Current check for the last extra TRB for zero and unaligned transfers does not account for isoc OUT. The last TRB of the Buffer Descriptor for isoc OUT transfers will be retired with HWO=0. As a result, we won't return early. The req->remaining will be updated to include the BUFSIZ count of the

Re: usb: dynamic suspend

2018-08-02 Thread Muni Sekhar
On Thu, Aug 2, 2018 at 7:08 PM, Alan Stern wrote: > On Thu, 2 Aug 2018, Muni Sekhar wrote: > >> [ Please keep me in CC as I'm not subscribed to the list] >> >> >> Hello All, >> >> >> I’ve an Ubuntu 16.04 LTS PC with 4.4.0-124-generic kernel version. >> >> I want to test the dynamic suspend for

Re: usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

2018-08-02 Thread Vincent Pelletier
On Thu, 2 Aug 2018 00:45:14 +, "He, Bo" wrote: > Your patch fix the issue BUG: scheduling while atomic: Yes, although from my understanding of Felipe's answer, the actual bug is the "scheduling" part (sleeping in dwc3 UDC) rather than the "atomic" part. So my patch addresses, still if my

Re: usb: dynamic suspend

2018-08-02 Thread Alan Stern
On Thu, 2 Aug 2018, Muni Sekhar wrote: > On Thu, Aug 2, 2018 at 7:08 PM, Alan Stern wrote: > > On Thu, 2 Aug 2018, Muni Sekhar wrote: > > > >> [ Please keep me in CC as I'm not subscribed to the list] > >> > >> > >> Hello All, > >> > >> > >> I’ve an Ubuntu 16.04 LTS PC with 4.4.0-124-generic

Re: [PATCH] usb: ehci-sh: convert to SPDX identifiers

2018-08-02 Thread Greg Kroah-Hartman
On Thu, Aug 02, 2018 at 01:46:40AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > Signed-off-by: Kuninori Morimoto > --- > include/linux/platform_data/ehci-sh.h | 14 +- > 1 file changed, 1 insertion(+), 13 deletions(-) I can not take patches without any

Re: [PATCH] usb: ehci-sh: convert to SPDX identifiers

2018-08-02 Thread Kuninori Morimoto
Hi Greg > > From: Kuninori Morimoto > > > > Signed-off-by: Kuninori Morimoto > > --- > > include/linux/platform_data/ehci-sh.h | 14 +- > > 1 file changed, 1 insertion(+), 13 deletions(-) > > I can not take patches without any changelog text at all, sorry. OK, will post v2

I have you not received the first message I sent you this morning. We need to talk about something and I'm sure you would like to hear this information.

2018-08-02 Thread Robert Wilson

Re: [PATCH 2/3] usb: dwc3: gadget: Don't skip updating remaining data

2018-08-02 Thread Felipe Balbi
Hi, Thinh Nguyen writes: 1. When a TRB receives whose CSP bit is 0 and CHN bit is 1 receives a short packet, the chained TRBs that follow it are not written back (e.g. the BUFSIZ and HWO fields remain the same as the software-prepared value) 2. In the case of

Re: [PATCH 2/3] usb: dwc3: gadget: Don't skip updating remaining data

2018-08-02 Thread Felipe Balbi
Hi, Thinh Nguyen writes: >> These patches will not fix the issue. >> > > What do you think of this fix? > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > index f452ab708ffc..338f7ab8a8b4 100644 > --- a/drivers/usb/dwc3/gadget.c > +++ b/drivers/usb/dwc3/gadget.c > @@

RE: fusb302 type-c chip driver supply cutting out

2018-08-02 Thread Adam Thomson
On 01 August 2018 19:38, Tim Harvey wrote: > On Tue, Jul 31, 2018 at 2:22 AM Adam Thomson > wrote: > > > > On 27 July 2018 17:41, Tim Harvey wrote: > > > > Adding Guenter to the thread. > > > > > Greetings, > > > > > > I have a custom design with a Fairchild FUSB302 Type-C chip driver > > > that

Re: usb: dynamic suspend

2018-08-02 Thread Alan Stern
On Thu, 2 Aug 2018, Muni Sekhar wrote: > [ Please keep me in CC as I'm not subscribed to the list] > > > Hello All, > > > I’ve an Ubuntu 16.04 LTS PC with 4.4.0-124-generic kernel version. > > I want to test the dynamic suspend for the below mentioned connected > USB device. > > Bus 003

[PATCH 0/3] add dwc2 support for px30

2018-08-02 Thread Heiko Stuebner
This is split out from the series adding the px30 support, due to the dwc2 binding change not having landed yet in a maintainer tree. The Acked binding change should go through some usb tree, while I'll pick up the dts changes once that has happened. The binding itself is unchanged. Heiko

[PATCH 1/3] dt-bindings: usb: dwc2: add description for px30

2018-08-02 Thread Heiko Stuebner
From: Liang Chen This patch adds the compatible of dwc2 for PX30 SoCs. Signed-off-by: Liang Chen Acked-by: Rob Herring Signed-off-by: Heiko Stuebner --- unchanged from it being part of the general px30 series Documentation/devicetree/bindings/usb/dwc2.txt | 1 + 1 file changed, 1

[PATCH 2/3] arm64: dts: rockchip: add dwc2 otg controller on px30

2018-08-02 Thread Heiko Stuebner
Add the node for the dwc2-based otg controller on the px30 soc. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/px30.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi index

[PATCH 3/3] arm64: dts: rockchip: enable dwc2-based otg controller on px30-evb

2018-08-02 Thread Heiko Stuebner
Enable the newly added controller on the px30 evaluation board. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/px30-evb.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/px30-evb.dts b/arch/arm64/boot/dts/rockchip/px30-evb.dts index

Re: broken TRIM support for JMS578 in uas mode

2018-08-02 Thread Oliver Neukum
On Mo, 2018-07-30 at 14:43 +0300, Mailing Lists wrote: > I cannot issue TRIM commands to SSD behind a JMS578-based sata to > usb-c adapter. Tried with Fedora 28 kernel and with latest > 4.18.0-0.rc6.git0.1.vanilla.knurd.1.fc28.x86_64 > lsblk -D shows that discard is not enabled, but the SSD has

usb: dynamic suspend

2018-08-02 Thread Muni Sekhar
[ Please keep me in CC as I'm not subscribed to the list] Hello All, I’ve an Ubuntu 16.04 LTS PC with 4.4.0-124-generic kernel version. I want to test the dynamic suspend for the below mentioned connected USB device. Bus 003 Device 028: ID 0cf3:e300 Atheros Communications, Inc. First I’d

Re: broken TRIM support for JMS578 in uas mode

2018-08-02 Thread Johannes Thumshirn
On Thu, Aug 02, 2018 at 02:24:16PM +0200, Oliver Neukum wrote: > On Mo, 2018-07-30 at 14:43 +0300, Mailing Lists wrote: > > I cannot issue TRIM commands to SSD behind a JMS578-based sata to > > usb-c adapter. Tried with Fedora 28 kernel and with latest > >