Re: [PATCH 1/3] usb: misc: usb3503: Fix up whitespace

2013-05-31 Thread Dongjin Kim
Signed-off-by: Dongjin Kim On Sat, Jun 1, 2013 at 10:34 AM, Julius Werner wrote: > Remove an erroneous tab that should be a space. > > Signed-off-by: Julius Werner > --- > drivers/usb/misc/usb3503.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/misc/usb35

Re: [PATCH 3/3] usb: misc: usb3503: Remove 100ms sleep on reset, conform to data sheet

2013-05-31 Thread Dongjin Kim
Signed-off-by: Dongjin Kim On Sat, Jun 1, 2013 at 10:34 AM, Julius Werner wrote: > The usb3503 driver sleeps a flat 100ms when resetting the chip, with a > comment about waiting for the reference clock. This seems to be a > board-specific detail that should not hold up boot across all platforms.

Re: [PATCH 2/3] usb: misc: usb3503: Remove hardcoded disabling of ports 2 and 3

2013-05-31 Thread Dongjin Kim
Hi, I have sent two patches for the same issue, these two are merged into Greg's tree. Please review the patches. [1] https://patchwork.kernel.org/patch/2599021 [2] https://patchwork.kernel.org/patch/2599031 Many thanks, Dongjin. On Sat, Jun 1, 2013 at 10:34 AM, Julius Werner wrote: > The usb3

Re: [PATCH 0/3] usb: misc: usb3503: Fix up usb3503 driver

2013-05-31 Thread Olof Johansson
2013/5/31 Julius Werner : > This patch set contains a few minor changes to the recently added SMSC > USB3503 driver. It addresses issues that seem to be either left-over > stopgaps from an early development stage or board-specific hacks, > changing them to defaults that should be most sane and usea

Re: [PATCH] USB: gadget: f_uac2: Fix broken prm to uac2 mapping

2013-05-31 Thread Jassi Brar
On Sat, Jun 1, 2013 at 2:47 AM, Felipe Balbi wrote: > HI, > > On Thu, May 30, 2013 at 06:23:33PM +0530, Jassi Brar wrote: >> From: Jassi Brar >> >> prm_to_uac2() is broken because it tests against pointer it itself >> mapped onto, which will never be different. >> Fix the mapping by adding pointe

[PATCH 3/3] usb: misc: usb3503: Remove 100ms sleep on reset, conform to data sheet

2013-05-31 Thread Julius Werner
The usb3503 driver sleeps a flat 100ms when resetting the chip, with a comment about waiting for the reference clock. This seems to be a board-specific detail that should not hold up boot across all platforms. This patch reduces the sleep to the 4ms initialization delay that the chip itself actuall

[PATCH 1/3] usb: misc: usb3503: Fix up whitespace

2013-05-31 Thread Julius Werner
Remove an erroneous tab that should be a space. Signed-off-by: Julius Werner --- drivers/usb/misc/usb3503.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c index d3a1cce..73aeb87 100644 --- a/drivers/usb/misc/usb3503.c +

[PATCH 2/3] usb: misc: usb3503: Remove hardcoded disabling of ports 2 and 3

2013-05-31 Thread Julius Werner
The usb3503 driver currently disables port 2 and 3 without explaination. It doesn't make sense to do this in a mainline Linux driver that should support all platforms which use this chip. If specific use cases really require ports to be disabled, this should either be done through local patches or

[PATCH 0/3] usb: misc: usb3503: Fix up usb3503 driver

2013-05-31 Thread Julius Werner
This patch set contains a few minor changes to the recently added SMSC USB3503 driver. It addresses issues that seem to be either left-over stopgaps from an early development stage or board-specific hacks, changing them to defaults that should be most sane and useable for all platforms that contain

Re: [PATCH] usb: musb: Fix format specifier warning

2013-05-31 Thread Randy Dunlap
On 05/31/13 15:34, Andy Shevchenko wrote: > On Fri, May 31, 2013 at 11:22 PM, Emil Goode wrote: >> This patch fixes a format specifier warning. dma_addr_t can be either >> u32 or u64 so we should cast to the largest type and change the format >> specifier to %llx. > > dma_addr_t is derived from p

Re: [PATCH] usb: musb: Fix format specifier warning

2013-05-31 Thread Andy Shevchenko
On Fri, May 31, 2013 at 11:22 PM, Emil Goode wrote: > This patch fixes a format specifier warning. dma_addr_t can be either > u32 or u64 so we should cast to the largest type and change the format > specifier to %llx. dma_addr_t is derived from phys_addr_t, thus you may use %pa specifier which is

Re: [PATCH] USB: gadget: f_uac2: Fix broken prm to uac2 mapping

2013-05-31 Thread Felipe Balbi
HI, On Thu, May 30, 2013 at 06:23:33PM +0530, Jassi Brar wrote: > From: Jassi Brar > > prm_to_uac2() is broken because it tests against pointer it itself > mapped onto, which will never be different. > Fix the mapping by adding pointer to parent chip in each rtd param > and removing the prm_to_u

Re: [PATCH v2] usb: musb: Fix format specifier warning

2013-05-31 Thread Felipe Balbi
Hi, On Fri, May 31, 2013 at 10:49:49PM +0200, Emil Goode wrote: > This patch fixes a format specifier warning. dma_addr_t can be either > u32 or u64 so we should cast to the largest type and change the format > specifier to %llx. > The addition of urb->transfer_dma and urb->actual_length is also d

[PATCH v2] usb: musb: Fix format specifier warning

2013-05-31 Thread Emil Goode
This patch fixes a format specifier warning. dma_addr_t can be either u32 or u64 so we should cast to the largest type and change the format specifier to %llx. The addition of urb->transfer_dma and urb->actual_length is also done a few lines below. I have moved this code up and pass the variable bu

Re: [PATCH] usb: musb: Fix format specifier warning

2013-05-31 Thread Sergei Shtylyov
Hello. On 06/01/2013 12:22 AM, Emil Goode wrote: This patch fixes a format specifier warning. dma_addr_t can be either u32 or u64 so we should cast to the largest type and change the format specifier to %llx. The addition of urb->transfer_dma and urb->actual_length is also done a few lines belo

[PATCH] usb: musb: Fix format specifier warning

2013-05-31 Thread Emil Goode
This patch fixes a format specifier warning. dma_addr_t can be either u32 or u64 so we should cast to the largest type and change the format specifier to %llx. The addition of urb->transfer_dma and urb->actual_length is also done a few lines below. I have moved this code up and pass the variable bu

[PATCH] Allow the USB HCD to create Wireless USB root hubs

2013-05-31 Thread Thomas Pugliese
This patch adds Wireless USB root hub support to the USB HCD. It allows the HWA to create its root hub which previously failed because the HCD treated wireless root hubs the same as USB2 high speed hubs. The creation of the root hub would fail in that case due to lack of TTs which wireless ro

Re: [PATCH 5/7] USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy

2013-05-31 Thread Sergei Shtylyov
Hello. On 05/31/2013 10:38 PM, Michael Grzeschik wrote: From: Sascha Hauer Signed-off-by: Sascha Hauer --- drivers/usb/chipidea/ci13xxx_imx.c | 41 ++ 1 file changed, 19 insertions(+), 22 deletions(-) diff --git a/drivers/usb/chipidea/ci13xxx_imx.c b/

[PATCH 7/7] usb: chipidea: usbmisc: use module_platform_driver

2013-05-31 Thread Michael Grzeschik
From: Philipp Zabel Signed-off-by: Philipp Zabel --- drivers/usb/chipidea/usbmisc_imx.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c index 714a6bd..588bae8 100644 --- a/drivers/usb/chipi

[PATCH v6 0/7] USB: add devicetree helpers for determining dr_mode and phy_type

2013-05-31 Thread Michael Grzeschik
changes since v5: - fixed compiling issues with non dt kernels in helper functions - moved ci13xxx_imx glue calls into dr_mode and phy_type helpers to core.c - added missing PTS option into PTW, PTS patch - added kernel parameter patch to force core into fullspeed mode - fixed kmalloc pdata patch i

[PATCH 3/7] USB: chipidea: add PTW, PTS and STS handling

2013-05-31 Thread Michael Grzeschik
From: Michael Grzeschik This patch makes it possible to configure the PTW, PTS and STS bits inside the portsc register for host and device mode before the driver starts and the phy can be addressed as hardware implementation is designed. Signed-off-by: Michael Grzeschik Signed-off-by: Marc Klei

[PATCH 5/7] USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy

2013-05-31 Thread Michael Grzeschik
From: Sascha Hauer Signed-off-by: Sascha Hauer --- drivers/usb/chipidea/ci13xxx_imx.c | 41 ++ 1 file changed, 19 insertions(+), 22 deletions(-) diff --git a/drivers/usb/chipidea/ci13xxx_imx.c b/drivers/usb/chipidea/ci13xxx_imx.c index 4d64541..48c446b 1006

[PATCH 6/7] usb: chipidea: udc: add force-full-speed option

2013-05-31 Thread Michael Grzeschik
From: Michael Grzeschik This patch makes it possible to set the chipidea udc into full-speed only mode. It can be set by the oftree property "force-full-speed". Signed-off-by: Michael Grzeschik Signed-off-by: Marc Kleine-Budde --- drivers/usb/chipidea/bits.h | 2 ++ drivers/usb/chipidea/core

[PATCH 4/7] USB chipidea: introduce dual role mode pdata flags

2013-05-31 Thread Michael Grzeschik
From: Sascha Hauer Even if a chipidea core is otg capable the board may not. This allows to explicitly set the core to host/peripheral mode. Without these flags the driver falls back to the old behaviour. Signed-off-by: Sascha Hauer --- .../devicetree/bindings/usb/ci13xxx-imx.txt| 1 +

[PATCH 2/7] USB: chipidea: ci13xxx-imx: move static pdata into probe function

2013-05-31 Thread Michael Grzeschik
From: Michael Grzeschik The pdata structure gets copied anyway inside ci13xxx_add_device by platform_device_add. We don't need to have it static. Signed-off-by: Michael Grzeschik Signed-off-by: Marc Kleine-Budde Signed-off-by: Sascha Hauer Reviewed-by: Peter Chen --- drivers/usb/chipidea/ci

[PATCH 1/7] USB: add devicetree helpers for determining dr_mode and phy_type

2013-05-31 Thread Michael Grzeschik
From: Michael Grzeschik This adds two little devicetree helper functions for determining the dr_mode (host, peripheral, otg) and phy_type (utmi, ulpi,...) from the devicetree. Signed-off-by: Michael Grzeschik Signed-off-by: Marc Kleine-Budde Signed-off-by: Sascha Hauer --- drivers/usb/phy/Ma

Re: MUSB multiplatform work?

2013-05-31 Thread Tony Lindgren
* Felipe Balbi [130530 21:06]: > On Thu, May 30, 2013 at 01:54:49PM -0700, Tony Lindgren wrote: > > * Tony Lindgren [130530 13:25]: > > > > > > TUSB we can make depend on ARMv7, the only implementation we have > > > is for omap2420, which is ARMv6. This should solve the issue for > > > ARMv7 mul

[PATCH] USB: Serial: cypress_M8: Enable FRWD Dongle hidcom device

2013-05-31 Thread Robert Butora
The patch adds a new HIDCOM device and does not affect other devices driven by the cypress_M8 module. Changes are: - add VendorID ProductID to device tables - skip unstable speed check because FRWD uses 115200bps - skip reset at probe which is an issue workaround for this particular device. Signed

Re: [PATCH V8 0/3] USB: OHCI: Start splitting up the driver

2013-05-31 Thread Arnd Bergmann
On Friday 31 May 2013 10:12:38 Alan Stern wrote: > On Thu, 30 May 2013, Arnd Bergmann wrote: > > > > I'll try to replicate your result. I don't have my USB audio device > > > here today, so it will have to wait until tomorrow. > > > > Strange enough, it seems to be working now, on a different b

Re: [PATCH V8 0/3] USB: OHCI: Start splitting up the driver

2013-05-31 Thread Alan Stern
On Thu, 30 May 2013, Arnd Bergmann wrote: > > I'll try to replicate your result. I don't have my USB audio device > > here today, so it will have to wait until tomorrow. > > Strange enough, it seems to be working now, on a different base. > > The kernel I tried last (based on yesterday's linux

Re: [PATCH V2 1/2] USB: OHCI: make ohci-platform a separate driver

2013-05-31 Thread Alan Stern
On Fri, 31 May 2013 manjunath.gou...@linaro.org wrote: > From: Manjunath Goudar > > This patch splits the ohci-platform code from ohci-hcd out > into its own separate driver module.This work is part of enabling > multi-platform kernels on ARM. > > In V2: > -Passed "hcd" argment instead of "oh

Re: [RFC PATCH 2/2] USB: OHCI: add a name for the platform-private field

2013-05-31 Thread Alan Stern
On Fri, 31 May 2013, Manjunath Goudar wrote: > On 30 May 2013 22:56, Alan Stern wrote: > > > On Thu, 30 May 2013, Manjunath Goudar wrote: > > > > > This patch adds an ohci->priv field for private use by OHCI > > > platform drivers. > > > > > > Until now none of the platform drivers has used this

Re: Linux USB file storage gadget with new UDC

2013-05-31 Thread Alan Stern
On Fri, 31 May 2013, victor yeo wrote: > When i run USB 2.0 Command Verifier on file gadget and UDC driver, an > error in Command Verifier says "Device must support being set to > Addressed/Configured state". Does it mean the gadget cannot support > putting device in addressed state or configured

Re: [PATCH -next] usb: fusbh200-hcd: fix error handling in fusbh200_hcd_fusbh200_probe()

2013-05-31 Thread Wei Yongjun
On 05/31/2013 08:29 PM, Greg KH wrote: > On Fri, May 31, 2013 at 08:05:22PM +0800, Wei Yongjun wrote: >> On 05/31/2013 07:21 PM, gre...@linuxfoundation.org wrote: >>> On Fri, May 31, 2013 at 02:35:41AM +, Wendy Yuan-Hsin Chen(??元馨) wrote: -Original Message- From: Wei Yongjun [

Re: [PATCH -next] usb: fusbh200-hcd: fix error handling in fusbh200_hcd_fusbh200_probe()

2013-05-31 Thread Greg KH
On Fri, May 31, 2013 at 08:05:22PM +0800, Wei Yongjun wrote: > On 05/31/2013 07:21 PM, gre...@linuxfoundation.org wrote: > > On Fri, May 31, 2013 at 02:35:41AM +, Wendy Yuan-Hsin Chen(??元馨) wrote: > >> -Original Message- > >> From: Wei Yongjun [mailto:weiyj...@gmail.com] > >> Sent: Tue

[PATCH V2 2/2] USB: OHCI: add a name for the platform-private field

2013-05-31 Thread manjunath . goudar
From: Manjunath Goudar This patch adds an ohci->priv field for private use by OHCI platform drivers. Until now none of the platform drivers has used this private space, but that's about to change in the next patch of this series. In V2: No changes. Signed-off-by: Manjunath Goudar Cc: Arnd Ber

[PATCH V2 0/2] USB: OHCI: Splitting ohci-platform into independent driver

2013-05-31 Thread manjunath . goudar
From: Manjunath Goudar This series patch begins the process of splitting ohci-platform up into independent driver modules and add a name for the platform-private field. Patch 1/2 separate ohci-platform into independent driver modules. V1 to V2: Passed "hcd" argment instead of "ohci" in ohci_set

[PATCH V2 1/2] USB: OHCI: make ohci-platform a separate driver

2013-05-31 Thread manjunath . goudar
From: Manjunath Goudar This patch splits the ohci-platform code from ohci-hcd out into its own separate driver module.This work is part of enabling multi-platform kernels on ARM. In V2: -Passed "hcd" argment instead of "ohci" in ohci_setup() because it is using "struct usb_hcd" argment. Si

Re: [PATCH -next] usb: fusbh200-hcd: fix error handling in fusbh200_hcd_fusbh200_probe()

2013-05-31 Thread Wei Yongjun
On 05/31/2013 07:21 PM, gre...@linuxfoundation.org wrote: > On Fri, May 31, 2013 at 02:35:41AM +, Wendy Yuan-Hsin Chen(��元馨) wrote: >> -Original Message- >> From: Wei Yongjun [mailto:weiyj...@gmail.com] >> Sent: Tuesday, May 21, 2013 10:41 AM >> To: gre...@linuxfoundation.org; Wendy Yu

[PATCH v2 2/2] USB: ehci-omap: select NOP_USB_XCEIV PHY driver

2013-05-31 Thread Roger Quadros
ehci-omap needs NOP_USB_XCEIV PHY driver to function properly, so select it. As the USB PHY drivers no longer depend on USB_PHY, it is safe to select the PHY drivers. Signed-off-by: Roger Quadros Tested-by: Adrien Vergé --- drivers/usb/host/Kconfig |4 +--- 1 files changed, 1 insertions(+),

[PATCH v2 1/2] USB: PHY: Make PHY driver selection possible by controller drivers

2013-05-31 Thread Roger Quadros
Convert PHY Drivers from menuconfig to menu so that the PHY drivers can be explicitely selected by the controller drivers. USB_PHY is no longer a user visible option. It is upto to the PHY drivers to select it if needed. This patch does so for the existing PHY drivers that use the USB_PHY library.

[PATCH v2 0/2] USB: PHY: Improve PHY selection logic

2013-05-31 Thread Roger Quadros
Hi, Improve Kconfig so that the relevant PHY driver can be explicitely selected by the controller driver instead of relying on the user to do so. Detailed description in patch 1. v2: - Merge patches 3-5 into the first patch to prevent circular dependency between the Kconfig options during bisect

Re: [PATCH -next] usb: fusbh200-hcd: fix error handling in fusbh200_hcd_fusbh200_probe()

2013-05-31 Thread gre...@linuxfoundation.org
On Fri, May 31, 2013 at 02:35:41AM +, Wendy Yuan-Hsin Chen(陳元馨) wrote: > > -Original Message- > From: Wei Yongjun [mailto:weiyj...@gmail.com] > Sent: Tuesday, May 21, 2013 10:41 AM > To: gre...@linuxfoundation.org; Wendy Yuan-Hsin Chen(陳元馨) > Cc: yongjun_...@trendmicro.com.cn; linux-u

Re: [RFC Patch] USB: Add check for portnum in the usb_acpi_find_device()

2013-05-31 Thread Greg KH
On Fri, May 31, 2013 at 02:18:06PM +0800, Lan Tianyu wrote: > This patch is to add a check of "portnum" which from the usb > port dev's name. Why do we need this now? > The "portnum" will be used as array index > for struct usb_hub->ports in the usb_set_hub_port_connect_type(). Is something fail

[PATCH 06/11] usb: musb: dsps: Adopt pinctrl support

2013-05-31 Thread Hebbar Gururaja
Amend the musb controller to optionally take a pin control handle and set the state of the pins to: - "default" on boot, resume - "sleep" on suspend() By optionally putting the pins into sleep state in the suspend callback we can accomplish two things. - One is to minimize current leakage from pi

Re: Linux USB file storage gadget with new UDC

2013-05-31 Thread victor yeo
Hi, On Thu, May 30, 2013 at 10:44 PM, Alan Stern wrote: > On Thu, 30 May 2013, victor yeo wrote: > >> I tested the g_zero with USB 2.0 Command Verifier. After the Command >> Verifier is run, the UDC gadget driver queue function is continuously >> being called, and the linux command prompt is froz

Re: [PATCH] usb: dwc3: Addition of "dr_mode" dt property.

2013-05-31 Thread Michael Grzeschik
Hi, On Thu, May 30, 2013 at 03:14:54PM -0500, Ruchika Kharwar wrote: > This patch adds an optional parameter "dr_mode" to the dwc3 core device node. > In the case the compile flag for the DWC3 controller is set to > "USB_DWC3_DUAL_ROLE" a device tree could restrain to either functionality of > hos