Re: [PATCH] staging: dwc2: fix thinko in dwc2_hc_set_even_odd_frame()

2013-07-19 Thread Stephen Warren
On 07/17/2013 02:07 PM, Paul Zimmerman wrote: ... With the two additional patches I sent out yesterday and today, the driver is working really well for me on the Pi with your mainline- based kernel. I was able to run an overnight test copying data to/from a thumb drive (not to the root fs due

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-19 Thread Greg KH
On Fri, Jul 19, 2013 at 11:25:44AM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:13 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:07:10AM +0530, Kishon Vijay Abraham I wrote: + ret = dev_set_name(phy-dev, %s.%d, dev_name(dev), id); Your naming is odd, no phy

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-19 Thread Kishon Vijay Abraham I
Hi, On Friday 19 July 2013 11:59 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:25:44AM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:13 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:07:10AM +0530, Kishon Vijay Abraham I wrote: + ret = dev_set_name(phy-dev, %s.%d,

Re: How should we handle isochronous underruns?

2013-07-19 Thread Clemens Ladisch
Ming Lei wrote: On Fri, Jul 19, 2013 at 5:20 AM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 18 Jul 2013, Clemens Ladisch wrote: In any case, there must be _some_ mechanism to explicitly restart a stream. I do not really care if this is some URB flag or some function call. I prefer

[PATCH] usbserial: append Petatel NP10T device to GSM modems list

2013-07-19 Thread Daniil Bolsun
This patch was tested on 3.10.1 kernel. Same models of Petatel NP10T modems have different device IDs. Unfortunately they have no additional revision information on a board which may treat them as different devices. Currently I've seen only two NP10T devices with various IDs. Possibly Petatel

Investment

2013-07-19 Thread Mr. Milos Antic
ATTENTION. Let me use the liberty of this medium to inform you that my principal is interested in investing his bond as a silent business partner in your company. He would like to invest in private sector projects with an established company in any project(s) which are already in the

Re: [RFC] ux500 dma short transfers on MUSB

2013-07-19 Thread Rajaram R
On Thu, Jul 11, 2013 at 10:44 PM, Sebastian Andrzej Siewior bige...@linutronix.de wrote: On 07/11/2013 06:58 PM, Greg KH wrote: following scenario: you attach an UART-TO-USB adapter to your musb port running ux500-dma code. The USB UARt driver queues 1x RX URB with the size of 256 bytes

Re: [RFC] ux500 dma short transfers on MUSB

2013-07-19 Thread Sebastian Andrzej Siewior
On 07/19/2013 09:59 AM, Rajaram R wrote: Okay. musb offloads the actual transfer to the DMA engine it is using. Once it does so, it relies on whatever comes back from dma engine regarding transfer complete, transferred size etc. AFAIK ux500 musb dma code handles data which is multiple of max

Re: How should we handle isochronous underruns?

2013-07-19 Thread Ming Lei
On Fri, Jul 19, 2013 at 1:44 AM, Clemens Ladisch clem...@ladisch.de wrote: Alan Stern wrote: On Thu, 18 Jul 2013, Ming Lei wrote: On Thu, Jul 18, 2013 at 3:24 AM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 4 Jul 2013, Alan Stern wrote: On Thu, 4 Jul 2013, Ming Lei wrote: I had

Re: [RFC] ux500 dma short transfers on MUSB

2013-07-19 Thread Rajaram R
On Fri, Jul 19, 2013 at 1:36 PM, Sebastian Andrzej Siewior bige...@linutronix.de wrote: On 07/19/2013 09:59 AM, Rajaram R wrote: Okay. musb offloads the actual transfer to the DMA engine it is using. Once it does so, it relies on whatever comes back from dma engine regarding transfer complete,

Re: [PATCH 1/2] Revert Revert HID: Fix logitech-dj: missing Unifying device issue

2013-07-19 Thread Benjamin Tissoires
Hi Peter, thanks for forwarding this to the appropriate people mailing list. Hi Sarah, thanks for starting investigating this :) On Fri, Jul 19, 2013 at 1:37 AM, Peter Hurley pe...@hurleysoftware.com wrote: Before we revert to using the workaround, I'd like to suggest that this new

Re: [PATCH v2 0/4] usb: musb: fix USB enumeration issue in OMAP3 platform

2013-07-19 Thread Kishon Vijay Abraham I
Felipe, On Tuesday 16 July 2013 06:12 PM, Felipe Balbi wrote: Hi, On Tue, Jul 16, 2013 at 11:22:38AM +0530, Kishon Vijay Abraham I wrote: Tony, On Monday 08 July 2013 04:44 PM, Kishon Vijay Abraham I wrote: This series fixes the USB enumeration issue caused because of the controller not

Re: [RFC] ux500 dma short transfers on MUSB

2013-07-19 Thread Sebastian Andrzej Siewior
On 07/19/2013 10:26 AM, Rajaram R wrote: We program the DMA only when we receive RX interrupt and when the length of data is known. When you submit URB for RX the flow would be something like musb_start_urb==musb_ep_program, Note here we do not program the DMA. DMA is programmed

Re: How should we handle isochronous underruns?

2013-07-19 Thread Clemens Ladisch
Ming Lei wrote: On Fri, Jul 19, 2013 at 1:44 AM, Clemens Ladisch clem...@ladisch.de wrote: In any case, there must be _some_ mechanism to explicitly restart a stream. I do not really care if this is some URB flag or some function call. Thought about the problem further, looks there is one

Re: [RFC] ux500 dma short transfers on MUSB

2013-07-19 Thread Rajaram R
On Fri, Jul 19, 2013 at 2:23 PM, Sebastian Andrzej Siewior bige...@linutronix.de wrote: On 07/19/2013 10:26 AM, Rajaram R wrote: We program the DMA only when we receive RX interrupt and when the length of data is known. When you submit URB for RX the flow would be something like

Re: [RFC] ux500 dma short transfers on MUSB

2013-07-19 Thread Sebastian Andrzej Siewior
On 07/19/2013 11:16 AM, Rajaram R wrote: That was work in progress. You may wish to look at this patch http://permalink.gmane.org/gmane.linux.usb.general/79858 If a device sends 513 bytes to a musb device. 512 bytes will be received in DMA mode and 1 byte in FIFO mode. FIFO will always

Re: [RFC] ux500 dma short transfers on MUSB

2013-07-19 Thread Rajaram R
On Fri, Jul 19, 2013 at 2:51 PM, Sebastian Andrzej Siewior bige...@linutronix.de wrote: On 07/19/2013 11:16 AM, Rajaram R wrote: That was work in progress. You may wish to look at this patch http://permalink.gmane.org/gmane.linux.usb.general/79858 If a device sends 513 bytes to a musb device.

Re: How should we handle isochronous underruns?

2013-07-19 Thread Ming Lei
On Fri, Jul 19, 2013 at 5:06 PM, Clemens Ladisch clem...@ladisch.de wrote: Ming Lei wrote: On Fri, Jul 19, 2013 at 1:44 AM, Clemens Ladisch clem...@ladisch.de wrote: In any case, there must be _some_ mechanism to explicitly restart a stream. I do not really care if this is some URB flag or

[PATCH v2 09/21] usb/gadget: f_mass_storage: use fsg_common_setup in fsg_common_init

2013-07-19 Thread Andrzej Pietrasiewicz
fsg_common_init is a lengthy function. Now there are helper functions which cover all parts of it. Use them. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/f_mass_storage.c | 19 +++ 1

[PATCH v2 17/21] usb/gadget: f_mass_storage: convert to new function interface with backward compatibility

2013-07-19 Thread Andrzej Pietrasiewicz
Converting mass storage to the new function interface requires converting the USB mass storage's function code and its users. This patch converts the f_mass_storage.c to the new function interface. The file is now compiled into a separate usb_f_mass_storage.ko module. The old function interface is

[PATCH v2 12/21] usb/gadget: f_mass_storage: use fsg_common_set_ops/_private_data in fsg_common_init

2013-07-19 Thread Andrzej Pietrasiewicz
fsg_common_init is a lengthy function. Now there are helper functions which cover all parts of it. Use them. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/f_mass_storage.c |5 +++-- 1 files changed, 3

[PATCH v2 10/21] usb/gadget: f_mass_storage: use fsg_common_set_num_buffers in fsg_common_init

2013-07-19 Thread Andrzej Pietrasiewicz
fsg_common_init is a lengthy function. Now there are helper functions which cover all parts of it. Use them. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/f_mass_storage.c | 29

[PATCH v2 11/21] usb/gadget: f_mass_storage: use fsg_common_set_nluns in fsg_common_init

2013-07-19 Thread Andrzej Pietrasiewicz
fsg_common_init is a lengthy function. Now there are helper functions which cover all parts of it. Use them. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/f_mass_storage.c | 22 +- 1

[PATCH v2 21/21] usb/gadget: f_mass_storage: add configfs support

2013-07-19 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../ABI/testing/configfs-usb-gadget-mass-storage | 31 ++ drivers/usb/gadget/Kconfig | 11 + drivers/usb/gadget/f_mass_storage.c|

[PATCH v2 00/21] Equivalent of g_mass_storage with configfs

2013-07-19 Thread Andrzej Pietrasiewicz
This series aims at integrating configfs into mass storage, the way it has been done for acm, ncm, ecm, eem, ecm subset, rndis, obex and phonet. It contains everything that is required to provide the equivalent of g_mass_storage.ko with configfs. Mass storage itself is quite large, so the

[PATCH v2 19/21] usb/gadget: storage_common: make attribute operations more generic

2013-07-19 Thread Andrzej Pietrasiewicz
Show/store methods for sysfs attributes contain code which can be used also by configfs. Make them abstract the source the lun and rw_semaphore are taken from. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[PATCH v2 20/21] usb/gadget: storage_common: add methods to show/store 'cdrom' and 'removable'

2013-07-19 Thread Andrzej Pietrasiewicz
This will be required by configfs integration. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/storage_common.c | 42 +++ drivers/usb/gadget/storage_common.h |5 2

[PATCH v2 02/21] usb/gadget: f_phonet: remove unused preprocessor conditional

2013-07-19 Thread Andrzej Pietrasiewicz
The compatibility layer which the USBF_PHONET_INCLUDED was a part of is no longer present - the USBF_PHONET_INCLUDED is not #defined by anyone anymore, so the ifndef is always true. Removing it. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park

[PATCH v2 14/21] usb/gadget: f_mass_storage: use fsg_common_create_luns in fsg_common_init

2013-07-19 Thread Andrzej Pietrasiewicz
fsg_common_init is a lengthy function. Now there are helper functions which cover all parts of it. Use them. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/f_mass_storage.c | 101

[PATCH v2 07/21] usb/gadget: f_mass_storage: use usb_gstrings_attach

2013-07-19 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/f_mass_storage.c | 25 - 1 files changed, 12 insertions(+), 13 deletions(-) diff --git a/drivers/usb/gadget/f_mass_storage.c

[PATCH v2 13/21] usb/gadget: f_mass_storage: use fsg_common_set_cdev in fsg_common_init

2013-07-19 Thread Andrzej Pietrasiewicz
fsg_common_init is a lengthy function. Now there are helper functions which cover all parts of it. Use them. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/f_mass_storage.c | 23 ++- 1

[PATCH v2 04/21] usb/gadget: create a utility module for mass_storage

2013-07-19 Thread Andrzej Pietrasiewicz
Converting to configfs requires making the f_mass_storage.c a module. But first we need to get rid of #include storage_common.c. This patch makes storage_common.c a separately compiled file, which is built as a utility module named u_ms.ko. After all mass storage users are converted to the new

[PATCH v2 15/21] usb/gadget: f_mass_storage: use fsg_common_set_inquiry_string in fsg_common_init

2013-07-19 Thread Andrzej Pietrasiewicz
fsg_common_init is a lengthy function. Now there are helper functions which cover all parts of it. Use them. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/f_mass_storage.c | 13 +++-- 1 files

[PATCH v2 03/21] usb/gadget: configfs: add a method to unregister the gadget

2013-07-19 Thread Andrzej Pietrasiewicz
Add a method to unregister the gadget using its config_item. There can be functions (e.g. mass storage), which in some circumstances need the gadget stopped. Add a method of stopping the gadget. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park

[PATCH v2 08/21] usb/gadget: f_mass_storage: split fsg_common initialization into a number of functions

2013-07-19 Thread Andrzej Pietrasiewicz
When configfs is in place, the things related to intialization of struct fsg_common will be split over a number of places. This patch adds several functions which together cover the former intialization routine fsg_common_init. When configfs is in place, the luns will not be represented in sysfs,

[PATCH v2 18/21] usb/gadget: mass_storage: convert to new interface of f_mass_storage

2013-07-19 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/Kconfig|1 + drivers/usb/gadget/mass_storage.c | 107 +++- 2 files changed, 81 insertions(+), 27 deletions(-) diff

[PATCH v2 16/21] usb/gadget: f_mass_storage: use fsg_common_run_thread in fsg_common_init

2013-07-19 Thread Andrzej Pietrasiewicz
fsg_common_init is a lengthy function. Now there are helper functions which cover all parts of it. Use them. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/f_mass_storage.c | 14 +++--- 1 files

[PATCH v2 01/21] usb/gadget: multi: fix error return code in cdc_do_config()

2013-07-19 Thread Andrzej Pietrasiewicz
Fix to return a negative error code from the error handling case instead of 0, as returned elsewhere in this function. Introduced by commit 59835a (usb: gadget: multi: use function framework for ACM.) Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park

[PATCH v2 06/21] usb/gadget: f_mass_storage: add a level of indirection for luns storage

2013-07-19 Thread Andrzej Pietrasiewicz
This is needed to prepare for configfs integration. So far the luns have been allocated during gadget's initialization, based on the nluns module parameter's value; the exact number is known when the gadget is initialized and that number of luns is allocated in one go; they all will be used.

[PATCH v2 05/21] usb/gadget: f_mass_storage: factor out a header file

2013-07-19 Thread Andrzej Pietrasiewicz
In order to prepare for the new function interface the f_mass_storage.c needs to be compiled as a module, and so a header file will be required. This patch factors out some code to a new f_mass_storage.h. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park

Re: How should we handle isochronous underruns?

2013-07-19 Thread Clemens Ladisch
Ming Lei wrote: On Fri, Jul 19, 2013 at 5:06 PM, Clemens Ladisch clem...@ladisch.de wrote: Ming Lei wrote: if (list_empty (stream-td_list)) { if (running from hcd interrupt or tasklet context) underrun else new stream } Why shouldn't a driver start a stream in

Re: How should we handle isochronous underruns?

2013-07-19 Thread Ming Lei
On Fri, Jul 19, 2013 at 6:30 PM, Clemens Ladisch clem...@ladisch.de wrote: Ming Lei wrote: On Fri, Jul 19, 2013 at 5:06 PM, Clemens Ladisch clem...@ladisch.de wrote: Ming Lei wrote: if (list_empty (stream-td_list)) { if (running from hcd interrupt or tasklet context) underrun

RE: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-19 Thread Gioh Kim
Thanks a lot for your replay. -Original Message- From: Alan Stern [mailto:st...@rowland.harvard.edu] Sent: Thursday, July 18, 2013 11:09 PM To: Ming Lei Cc: Gioh Kim; linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; Mark Salter; namhyung@lge.com; Minchan Kim; Chanho Min;

Re: Audio I/O parameters

2013-07-19 Thread James Stone
On Wed, Jul 17, 2013 at 7:48 PM, Alan Stern st...@rowland.harvard.edu wrote: The 32-frames/period trace looks just like the 64 frames/period, only worse. Each URB has only 4 packets, and the underrun problem is severe. This won't happen after the minimum pipeline length is fixed. The

Re: [PATCH] usb: xhci: add the suspend/resume functionality

2013-07-19 Thread Felipe Balbi
Hi, On Thu, Jul 18, 2013 at 04:18:08PM -0700, Sarah Sharp wrote: Hi Felipe, My bad, this patch got dropped. I've refreshed it against Greg's usb-next branch. Do you still want me to push this? Again, my apologies for dropping this. Sure, this is necessary, at least, for the

Re: How should we handle isochronous underruns?

2013-07-19 Thread Ming Lei
On Fri, Jul 19, 2013 at 6:36 PM, Ming Lei tom.leim...@gmail.com wrote: On Fri, Jul 19, 2013 at 6:30 PM, Clemens Ladisch clem...@ladisch.de wrote: Ming Lei wrote: On Fri, Jul 19, 2013 at 5:06 PM, Clemens Ladisch clem...@ladisch.de wrote: Ming Lei wrote: if (list_empty (stream-td_list)) {

[PATCH 0/3] staging: dwc2: Add some dma-related defensive programming

2013-07-19 Thread Matthijs Kooijman
Hi Greg, here's three patches for dwc2, acked by Paul. They're not critical, so no need to push them to 3.11. Gr. Matthijs Matthijs Kooijman (3): staging: dwc2: disable dma when no dma_mask was setup staging: dwc2: when dma is disabled, clear hcd-self.uses_dma staging: dwc2: Don't touch

[PATCH 3/3] staging: dwc2: Don't touch the dma_mask when dma is disabled

2013-07-19 Thread Matthijs Kooijman
There was some code that cleared the dma_mask when dma was disabled in the driver. Given that clearing the mask doesn't actually tell the usb core we're not using dma, and a previous commit explicitely sets the hcd-self.uses_dma value, it seems these values are unneeded and can only potentially

[PATCH 1/3] staging: dwc2: disable dma when no dma_mask was setup

2013-07-19 Thread Matthijs Kooijman
If the platform or bus driver failed to setup a dma_mask, but the hardware advertises support for DMA, before DMA would be enabled in dwc2, but disabled in the usb core, making all connectivity break. With this commit, the dwc2 driver will emit a warning and fall back to slave mode in this case.

[PATCH 2/3] staging: dwc2: when dma is disabled, clear hcd-self.uses_dma

2013-07-19 Thread Matthijs Kooijman
When dma is disabled inside dwc2 (because the hardware does not support it, or the code was changed to disable it for testing), let the usb core know about this by clearing hcd-self.uses_dma. By default, the usb core assumes that dma is used when a dma_mask is set, but this might not always match

Re: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-19 Thread Ming Lei
On Fri, Jul 19, 2013 at 11:50 AM, Ming Lei tom.leim...@gmail.com wrote: On Thu, Jul 18, 2013 at 10:08 PM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 18 Jul 2013, Ming Lei wrote: I guess that HC could have a use-after-free problem like following situation. 1. A qtd which is

[PATCH v2 4/4] usb: musb: dsps: Remove the phy control from glue and add phy driver APIs

2013-07-19 Thread George Cherian
Remove usb phy control module access from platform glue. The same is now done using am phy driver and phy-omap-control. Adapt the driver to the split dt nodes. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de Signed-off-by: George Cherian george.cher...@ti.com ---

[PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX

2013-07-19 Thread George Cherian
Add phy nodes for AM33XX platform and split the musb nodes per instance. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de Signed-off-by: George Cherian george.cher...@ti.com --- arch/arm/boot/dts/am33xx.dtsi | 68 +-- 1 file changed, 53

[PATCH v2 0/4] Add phy support for AM335X platform using Generic PHy framework

2013-07-19 Thread George Cherian
This patch series adds phy support for AM335X platform. This patch series is based on Generic PHY framework [1]. This series has - adds dual musb instances support for am335x platform - adds phy-am-usb driver used in AM platforms - adds OTG callbacks -

[PATCH v2 1/4] usb: phy: phy-omap-control: Add API to power and wakeup

2013-07-19 Thread George Cherian
on/off USB PHY for AM335X Add APIs to -power on/off USB PHY for AM335X -enable/disable PHY wakeup. This API will be called from phy-am-usb driver. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/phy/phy-omap-control.c | 67

[PATCH v2 2/4] phy: phy-amxxxx-usb: Add PHY driver for amxxxx platform

2013-07-19 Thread George Cherian
Adds phy driver support for am33xx platform, the host/device peripheral controller shall get this phy object to control the phy operations. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/phy/Kconfig | 12 +++ drivers/phy/Makefile | 1 +

Re: [PATCH v2 0/4] Add phy support for AM335X platform using Generic PHy framework

2013-07-19 Thread Kishon Vijay Abraham I
Hi, On Friday 19 July 2013 06:04 PM, George Cherian wrote: This patch series adds phy support for AM335X platform. This patch series is based on Generic PHY framework [1]. There are some comments on the generic PHY framework. So you might have to adapt it once those comments are fixed. Thanks

Re: [PATCH v2 1/4] usb: phy: phy-omap-control: Add API to power and wakeup

2013-07-19 Thread Kishon Vijay Abraham I
Hi, On Friday 19 July 2013 06:04 PM, George Cherian wrote: on/off USB PHY for AM335X Add APIs to -power on/off USB PHY for AM335X -enable/disable PHY wakeup. This API will be called from phy-am-usb driver. Signed-off-by: George Cherian george.cher...@ti.com ---

Re: [PATCH v2 2/4] phy: phy-amxxxx-usb: Add PHY driver for amxxxx platform

2013-07-19 Thread Kishon Vijay Abraham I
Hi, On Friday 19 July 2013 06:04 PM, George Cherian wrote: Adds phy driver support for am33xx platform, the host/device peripheral controller shall get this phy object to control the phy operations. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/phy/Kconfig |

Re: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX

2013-07-19 Thread Kishon Vijay Abraham I
Hi, On Friday 19 July 2013 06:04 PM, George Cherian wrote: Add phy nodes for AM33XX platform and split the musb nodes per instance. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de Signed-off-by: George Cherian george.cher...@ti.com --- arch/arm/boot/dts/am33xx.dtsi | 68

Re: [PATCH v2 4/4] usb: musb: dsps: Remove the phy control from glue and add phy driver APIs

2013-07-19 Thread Kishon Vijay Abraham I
On Friday 19 July 2013 06:04 PM, George Cherian wrote: Remove usb phy control module access from platform glue. The same is now done using am phy driver and phy-omap-control. Adapt the driver to the split dt nodes. This patch should be split. Signed-off-by: Sebastian Andrzej Siewior

Re: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX

2013-07-19 Thread Sergei Shtylyov
Hello. On 19-07-2013 16:34, George Cherian wrote: Add phy nodes for AM33XX platform and split the musb nodes per instance. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de Signed-off-by: George Cherian george.cher...@ti.com --- arch/arm/boot/dts/am33xx.dtsi | 68

Re: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX

2013-07-19 Thread Sebastian Andrzej Siewior
On 07/19/2013 03:56 PM, Sergei Shtylyov wrote: On 19-07-2013 16:34, George Cherian wrote: diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index 8e1248f..e3890c4 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -326,21 +326,59 @@

Re: xhci driver problem

2013-07-19 Thread Alan Stern
On Thu, 18 Jul 2013, Sarah Sharp wrote: Then try using your other camera. If that doesn't work, you may have to unconfigure the device by running something like: root@xanatos:/sys/bus/usb/devices/3-1.6# echo 0 bConfigurationValue Alan, is that the right command? It fails on my machine

Re: [PATCH] backports: backport drvdata = NULL core driver fixes

2013-07-19 Thread Alan Stern
On Thu, 18 Jul 2013, Luis R. Rodriguez wrote: From: Luis R. Rodriguez mcg...@do-not-panic.com The Linux kernel had tons of code which at times cleared the drvdata upon probe failure or release. There are however a bunch of drivers that didn't clear this. Commit 0998d063 implmented

Re: [PATCH v12 00/13] Add tested id switch and vbus connect detect support for Chipidea

2013-07-19 Thread Fabio Estevam
Hi Alexander, On Thu, Jul 11, 2013 at 3:27 AM, Peter Chen peter.c...@freescale.com wrote: This patchset adds tested otg id switch function and vbus connect and disconnect detection for chipidea driver. And fix kinds of bugs found at chipidea drivers after enabling id and vbus detection.

Re: [PATCH 1/2] Revert Revert HID: Fix logitech-dj: missing Unifying device issue

2013-07-19 Thread Joseph Salisbury
On 07/18/2013 07:37 PM, Peter Hurley wrote: On 07/18/2013 06:09 PM, Sarah Sharp wrote: On Thu, Jul 18, 2013 at 04:28:01PM -0400, Peter Hurley wrote: [ +cc Sarah Sharp, linux-usb ] On 07/18/2013 09:21 AM, Nestor Lopez Casado wrote: This reverts commit 8af6c08830b1ae114d1a8b548b1f8b056e068887.

Re: [PATCH 1/2] Revert Revert HID: Fix logitech-dj: missing Unifying device issue

2013-07-19 Thread Alan Stern
On Thu, 18 Jul 2013, Sarah Sharp wrote: Question: does this USB device need a control transfer to reset its endpoints when the endpoints are not actually halted? If so, yes, that is a known xHCI driver bug that needs to be fixed. The xHCI host will not accept a Reset Endpoint command when

Re: Audio I/O parameters

2013-07-19 Thread Alan Stern
On Fri, 19 Jul 2013, James Stone wrote: The questions now are: Why are the same requests sent over and over again? Why does the ALSA driver attempt to set the clock frequency while the clock is actively in use? Has this behavior changed since the

Re: How should we handle isochronous underruns?

2013-07-19 Thread Alan Stern
On Fri, 19 Jul 2013, Ming Lei wrote: Even we can introduce one flag of 'completing' in 'struct urb' to check if the USB's submit is called inside its own complete(), by which we can check if resubmission is in underrun easily. Consider that isoc URB's resubmission in completion handler

RE: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-19 Thread Alan Stern
On Fri, 19 Jul 2013, Gioh Kim wrote: I was going to ask the same question. This particular piece of code gets executed _only_ when an URB is unlinked. Not during any other kind of error. I've got the problem when I listened to the mp3 file of USB HDD. I checked the urb data when the

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-19 Thread Stephen Warren
On 07/19/2013 12:36 AM, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:59 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:25:44AM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:13 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:07:10AM +0530, Kishon Vijay

Re: [PATCH 1/2] Revert Revert HID: Fix logitech-dj: missing Unifying device issue

2013-07-19 Thread Nestor Lopez Casado
Hi Sarah, On Fri, Jul 19, 2013 at 12:09 AM, Sarah Sharp sarah.a.sh...@linux.intel.com wrote: On Thu, Jul 18, 2013 at 04:28:01PM -0400, Peter Hurley wrote: [ +cc Sarah Sharp, linux-usb ] On 07/18/2013 09:21 AM, Nestor Lopez Casado wrote: This reverts commit

Re: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX

2013-07-19 Thread Sergei Shtylyov
Hello. On 07/19/2013 06:20 PM, Sebastian Andrzej Siewior wrote: diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index 8e1248f..e3890c4 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -326,21 +326,59 @@ status =

Re: [PATCH] usb: Add Device Tree support to XHCI Platform driver

2013-07-19 Thread Sergei Shtylyov
Hello. On 07/19/2013 02:40 AM, Sergei Shtylyov wrote: Add Device Tree match table. Setup dma_mask and coherent_dma_mask if they're not already set. Signed-off-by: Al Cooper alcoop...@gmail.com [...] @@ -186,11 +198,17 @@ static int xhci_plat_remove(struct platform_device *dev)

Re: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX

2013-07-19 Thread Sebastian Andrzej Siewior
On 07/19/2013 08:33 PM, Sergei Shtylyov wrote: Hello. Hello, usb: usb@4740 { compatible = ti,am33xx-usb; usb0_phy: phy@47401300 { compatible = ti,am335x-usb-phy; } usb0: usb@47401000 { musb0: usb@47401400 { compatible = mg,musbmhdrc;

Re: [PATCH] usbserial: append Petatel NP10T device to GSM modems list

2013-07-19 Thread Greg KH
On Fri, Jul 19, 2013 at 10:21:23AM +0300, Daniil Bolsun wrote: This patch was tested on 3.10.1 kernel. Same models of Petatel NP10T modems have different device IDs. Unfortunately they have no additional revision information on a board which may treat them as different devices. Currently

Re: [PATCH] staging: dwc2: fix thinko in dwc2_hc_set_even_odd_frame()

2013-07-19 Thread Stephen Warren
On 07/19/2013 01:55 PM, Paul Zimmerman wrote: From: Stephen Warren [mailto:swar...@wwwdotorg.org] Sent: Thursday, July 18, 2013 11:01 PM ... I then wanted to try WiFi, so I plugged in a USB mouse/keyboard, and started X, trying to use GUI tools. Then I saw some issues. With just the USB

RE: [PATCH] staging: dwc2: fix thinko in dwc2_hc_set_even_odd_frame()

2013-07-19 Thread Paul Zimmerman
From: Stephen Warren [mailto:swar...@wwwdotorg.org] Sent: Thursday, July 18, 2013 11:01 PM ... I then wanted to try WiFi, so I plugged in a USB mouse/keyboard, and started X, trying to use GUI tools. Then I saw some issues. With just the USB mouse/keyboard attached (via a powered hub),

Re: [PATCH] backports: backport drvdata = NULL core driver fixes

2013-07-19 Thread Luis R. Rodriguez
On Fri, Jul 19, 2013 at 2:07 PM, Luis R. Rodriguez mcg...@do-not-panic.com wrote: This is not a very good idea. Although setting drvdata to NULL allowed a lot of code to be removed, it also exposed a bunch of hidden bugs -- drivers were using the drvdata value even after their remove function

Re: [PATCH] backports: backport drvdata = NULL core driver fixes

2013-07-19 Thread Luis R. Rodriguez
On Fri, Jul 19, 2013 at 7:17 AM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 18 Jul 2013, Luis R. Rodriguez wrote: From: Luis R. Rodriguez mcg...@do-not-panic.com The Linux kernel had tons of code which at times cleared the drvdata upon probe failure or release. There are however a

Re: [PATCH] backports: backport drvdata = NULL core driver fixes

2013-07-19 Thread Julia Lawall
On Fri, 19 Jul 2013, Luis R. Rodriguez wrote: On Fri, Jul 19, 2013 at 2:07 PM, Luis R. Rodriguez mcg...@do-not-panic.com wrote: This is not a very good idea. Although setting drvdata to NULL allowed a lot of code to be removed, it also exposed a bunch of hidden bugs -- drivers were using

Re: [PATCH] backports: backport drvdata = NULL core driver fixes

2013-07-19 Thread Luis R. Rodriguez
On Fri, Jul 19, 2013 at 2:27 PM, Julia Lawall julia.law...@lip6.fr wrote: On Fri, 19 Jul 2013, Luis R. Rodriguez wrote: On Fri, Jul 19, 2013 at 2:07 PM, Luis R. Rodriguez mcg...@do-not-panic.com wrote: This is not a very good idea. Although setting drvdata to NULL allowed a lot of code to

Re: [PATCH] usb: Add Device Tree support to XHCI Platform driver

2013-07-19 Thread Sarah Sharp
On Fri, Jul 19, 2013 at 10:42:50PM +0400, Sergei Shtylyov wrote: Hello. On 07/19/2013 02:40 AM, Sergei Shtylyov wrote: Add Device Tree match table. Setup dma_mask and coherent_dma_mask if they're not already set. Signed-off-by: Al Cooper alcoop...@gmail.com [...] @@ -186,11 +198,17

[PATCH v2 01/10] backports: backport drvdata = NULL core driver fixes

2013-07-19 Thread Luis R. Rodriguez
From: Luis R. Rodriguez mcg...@do-not-panic.com The Linux kernel had tons of code which at times cleared the drvdata upon probe failure or release. There are however a bunch of drivers that didn't clear this. Commit 0998d063 implmented clearing this upon device_release_driver() and dealt with

Re: Sound Blaster USB X-Fi configuration problem

2013-07-19 Thread Mariusz Grecki
Hi Alan, thanks for the fast response and useful infos. Unfortunately your patch does not work but triggered by it I made it working. The changes as as follows: First we should diverse between Audigy and X-Fi in snd_usb_apply_boot_quirk: case USB_ID(0x041e, 0x30df): /*

[PATCH] usb: cp210x support SEL C662 Vendor/Device

2013-07-19 Thread Barry Grussling
From: Barry Grussling ba...@grussling.com This patch adds support for the Schweitzer Engineering Laboratories C662 USB cable based off the CP210x driver. Signed-off-by: Barry Grussling ba...@grussling.com --- I have tested this patch and verified the C662 works properly with it.

[PROBLEM/BUG] mouse polling at only half rate on ohci_hcd

2013-07-19 Thread sgtcapslock
This is https://bugzilla.kernel.org/show_bug.cgi?id=60586 - I'm posting it here as directed by Greg Kroah-Hartman. -- usbhid's mousepoll parameter is setting all of the gaming mice I've tested to exactly 1/2 of the expected polling rate that I specify, but only if the gaming mice are using the

Re: How should we handle isochronous underruns?

2013-07-19 Thread Ming Lei
On Fri, Jul 19, 2013 at 10:53 PM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 19 Jul 2013, Ming Lei wrote: Even we can introduce one flag of 'completing' in 'struct urb' to check if the USB's submit is called inside its own complete(), by which we can check if resubmission is in

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-19 Thread Kishon Vijay Abraham I
Hi, On Friday 19 July 2013 09:24 PM, Stephen Warren wrote: On 07/19/2013 12:36 AM, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:59 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:25:44AM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:13 AM, Greg KH wrote:

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-19 Thread Kishon Vijay Abraham I
Hi, On Saturday 20 July 2013 05:20 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 12:06:01PM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:59 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:25:44AM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:13 AM,

Re: [PATCH] backports: backport drvdata = NULL core driver fixes

2013-07-19 Thread Alan Stern
On Fri, 19 Jul 2013, Luis R. Rodriguez wrote: Thanks Julia. In that case I'm going to just leave this in place given that if there's a bug upstream we'll get it fixed as soon as a respective patch gets upstream as well. That is, we are not using old drivers, we use the same upstream drivers

Re: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX

2013-07-19 Thread George Cherian
On 7/20/2013 12:03 AM, Sergei Shtylyov wrote: Hello. On 07/19/2013 06:20 PM, Sebastian Andrzej Siewior wrote: diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index 8e1248f..e3890c4 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@

Re: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX

2013-07-19 Thread George Cherian
On 7/20/2013 12:12 AM, Sebastian Andrzej Siewior wrote: On 07/19/2013 08:33 PM, Sergei Shtylyov wrote: Hello. Hello, usb: usb@4740 { compatible = ti,am33xx-usb; usb0_phy: phy@47401300 { compatible = ti,am335x-usb-phy; } usb0: usb@47401000 {

Re: Sound Blaster USB X-Fi configuration problem

2013-07-19 Thread Alan Stern
On Sat, 20 Jul 2013, Mariusz Grecki wrote: Hi Alan, thanks for the fast response and useful infos. Unfortunately your patch does not work but triggered by it I made it working. The changes as as follows: First we should diverse between Audigy and X-Fi in snd_usb_apply_boot_quirk:

Re: [PROBLEM/BUG] mouse polling at only half rate on ohci_hcd

2013-07-19 Thread Alan Stern
On Fri, 19 Jul 2013 sgtcapsl...@lavabit.com wrote: This is https://bugzilla.kernel.org/show_bug.cgi?id=60586 - I'm posting it here as directed by Greg Kroah-Hartman. -- usbhid's mousepoll parameter is setting all of the gaming mice I've tested to exactly 1/2 of the expected polling rate

Re: How should we handle isochronous underruns?

2013-07-19 Thread Alan Stern
On Sat, 20 Jul 2013, Ming Lei wrote: Trying to check the context of an URB submission strikes me as not robust at all. Who knows what tricks drivers will get up to in the future? Firstly, it shouldn't be fragile as you image, with the below simple script, we can find almost all isoc

Re: [PROBLEM/BUG] mouse polling at only half rate on ohci_hcd

2013-07-19 Thread sgtcapslock
Can you provide usbmon traces showing what happens when the mouse is plugged in to an OHCI controller and when it is plugged in to an EHCI controller? Instructions are in Documentation/usb/usbmon.txt. Alan Stern Absolutely. Ahh, I'm not really sure if I should send them as attachments to

Attaching an usb 1.1 (sound ) device to an usb3 port results in not enough bandwidth

2013-07-19 Thread Volker Schroer
Hi all, Attaching an usb 1.1 device ( Funcube dongle pro+ ) results in an not enough bandwidth and some error messages from the xhci driver. (See attachment in bugzilla #60581 ) The device is not usable. The device works without any problems with ehci or ohci drivers. Regards Volker Schroer

Re: How should we handle isochronous underruns?

2013-07-19 Thread Ming Lei
On Sat, Jul 20, 2013 at 11:57 AM, Alan Stern st...@rowland.harvard.edu wrote: On Sat, 20 Jul 2013, Ming Lei wrote: Trying to check the context of an URB submission strikes me as not robust at all. Who knows what tricks drivers will get up to in the future? Firstly, it shouldn't be

  1   2   >