Re: [PATCH 06/16] usb: musb: dsps: rename ti81xx_driver_data to am33xx_driver_data

2013-07-23 Thread George Cherian
Hi Sebastian, On 7/22/2013 11:39 PM, Sebastian Andrzej Siewior wrote: This patch renames the type struct from ti81xx_driver_data to am33xx_driver_data since it is not used for ti81xx anymore. The EOI member is also removed since the am33xx SoC does not have such register. The interrupt is

Re: [PATCH 1/1] TX throttling bug-fixing patch of AX88179_178A

2013-07-23 Thread Eric Dumazet
On Mon, 2013-07-22 at 20:47 +0100, Ben Hutchings wrote: On Mon, 2013-07-22 at 11:47 -0700, Eric Dumazet wrote: On Mon, 2013-07-22 at 19:38 +0100, Ben Hutchings wrote: On Mon, 2013-07-22 at 11:29 -0700, Grant Grundler wrote: On Mon, Jul 22, 2013 at 10:07 AM, Eric Dumazet

a small patch that fixes the ohci warn irq nobody cared on shutdown.

2013-07-23 Thread Caizhiyong
Hi: Here's a small patch that fixes the ohci shutdown. The patch is against v3.4.54. From cc16ef2f15300201cc3f680b7df20ecded28daa4 Mon Sep 17 00:00:00 2001 From: Cai Zhiyong caizhiy...@huawei.com Date: Tue, 23 Jul 2013 12:17:01 +0800 Subject: [PATCH] USB: ohci_usb warn irq nobody cared

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
Hi Alan, On Monday 22 of July 2013 10:44:39 Alan Stern wrote: On Mon, 22 Jul 2013, Kishon Vijay Abraham I wrote: The PHY and the controller it is attached to are both physical devices. The connection between them is hardwired by the system manufacturer and cannot be

Re: [PATCH 2/2] usb: dwc3: ep0: don't change to configured state too early

2013-07-23 Thread Felipe Balbi
Hi, On Mon, Jul 22, 2013 at 10:55:28AM -0400, Alan Stern wrote: On Mon, 22 Jul 2013, Felipe Balbi wrote: before changing to configured state, we need to wait until gadget driver has had a chance to process the request. In case of USB_GADGET_DELAYED_STATUS, that means we need to

Re: [PATCH] usb: gadget: udc-core: move sysfs_notify() to a workqueue

2013-07-23 Thread Felipe Balbi
Hi, On Mon, Jul 22, 2013 at 10:53:50AM -0400, Alan Stern wrote: On Mon, 22 Jul 2013, Felipe Balbi wrote: indeed. Added a flush_work() call to usb_del_gadget_udc() Also, what happens if two state transitions occur before the work queue gets around to executing the work routine?

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
[Fixed address of devicetree mailing list and added more people on CC.] For reference, full thread can be found under following link: http://thread.gmane.org/gmane.linux.ports.arm.kernel/252813 Best regards, Tomasz On Tuesday 23 of July 2013 09:29:32 Tomasz Figa wrote: Hi Alan, On Monday 22

Re: [PATCH v3 1/1] Intel xhci: refactor EHCI/xHCI port switching

2013-07-23 Thread Mathias Nyman
On 07/22/2013 06:23 PM, Alan Stern wrote: On Mon, 22 Jul 2013, Mathias Nyman wrote: Make the Linux xHCI driver automatically try to switchover the EHCI ports to xHCI when an Intel xHCI host is detected, and it also finds an Intel EHCI host. This means we will no longer have to add Intel xHCI

Re: [PATCH 6/6] USB: OHCI: make ohci-s3c2410 a separate driver

2013-07-23 Thread Tomasz Figa
Hi Manjunath, Please see some comments inline. On Monday 22 of July 2013 14:49:30 Manjunath Goudar wrote: Separate the Samsung OHCI S3C host controller driver from ohci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels

Re: [PROBLEM/BUG] mouse polling at only half rate on ohci_hcd

2013-07-23 Thread Jiri Kosina
On Sun, 21 Jul 2013, sgtcapslock wrote: I took Alan's excellent advice and read a good bit of that book last night. Definitely some good authors there! After pondering Alan's diagnosis for a bit, I went to inspect the usbhid driver code, and wound up creating a patch which works! I've

[PATCH v4 1/1] Intel xhci: refactor EHCI/xHCI port switching

2013-07-23 Thread Mathias Nyman
Make the Linux xHCI driver automatically try to switchover the EHCI ports to xHCI when an Intel xHCI host is detected, and it also finds an Intel EHCI host. This means we will no longer have to add Intel xHCI hosts to a quirks list when the PCI device IDs change. Simply continuing to add new

Re: [PATCH 06/16] usb: musb: dsps: rename ti81xx_driver_data to am33xx_driver_data

2013-07-23 Thread Sebastian Andrzej Siewior
On 07/23/2013 08:04 AM, George Cherian wrote: Hi Sebastian, On 7/22/2013 11:39 PM, Sebastian Andrzej Siewior wrote: This patch renames the type struct from ti81xx_driver_data to am33xx_driver_data since it is not used for ti81xx anymore. The EOI member is also removed since the am33xx

Re: [PATCH 06/16] usb: musb: dsps: rename ti81xx_driver_data to am33xx_driver_data

2013-07-23 Thread George Cherian
On 7/23/2013 2:39 PM, Sebastian Andrzej Siewior wrote: On 07/23/2013 08:04 AM, George Cherian wrote: Hi Sebastian, On 7/22/2013 11:39 PM, Sebastian Andrzej Siewior wrote: This patch renames the type struct from ti81xx_driver_data to am33xx_driver_data since it is not used for ti81xx

Re: [PATCH 05/16] usb: musb: dsps: use proper child nodes

2013-07-23 Thread Sebastian Andrzej Siewior
On 07/23/2013 08:46 AM, George Cherian wrote: diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts index 3aee1a4..a3a642a 100644 --- a/arch/arm/boot/dts/am335x-evm.dts +++ b/arch/arm/boot/dts/am335x-evm.dts @@ -171,6 +171,26 @@ }; }; +

Re: [PATCH 6/6] USB: ehci-omap: Implement suspend/resume

2013-07-23 Thread Roger Quadros
On 07/22/2013 06:18 PM, Alan Stern wrote: On Mon, 22 Jul 2013, Roger Quadros wrote: Right, I understand it now. How does the below code look? +static int omap_ehci_suspend(struct device *dev) +{ + struct usb_hcd *hcd = dev_get_drvdata(dev); + bool do_wakeup =

[PATCH 1/3] net/usb/r815x: replace USB buffer from stack to DMA-able

2013-07-23 Thread hayeswang
Some USB buffers use stack which may not be DMA-able. Use the buffers from kmalloc to replace those one. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r815x.c | 44 +++- 1 file changed, 27 insertions(+), 17 deletions(-) diff --git

[PATCH 2/3] net/usb/r8152: make sure the USB buffer is DMA-able

2013-07-23 Thread hayeswang
Allocate the required memory before calling usb_control_msg. And the additional memory copy is necessary. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 60 - 1 file changed, 35 insertions(+), 25 deletions(-) diff

[PATCH 3/3] net/usb/r8152: adjust relative ocp function

2013-07-23 Thread hayeswang
- fix the conversion between cpu and __le32 - replace some pla_ocp and usb_ocp functions with generic_ocp function Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 66 + 1 file changed, 23 insertions(+), 43

Re: [PROBLEM/BUG] mouse polling at only half rate on ohci_hcd

2013-07-23 Thread Josef Schimke
On 07/23/2013 03:26 AM, Jiri Kosina wrote: Hi, as Greg mentioned already -- normally there shouldn't be any reason for private e-mail, Ccing proper mailinglists is always a good idea to get as much feedback as possible; feel free to drop me an e-mail. Hello, Ahh, apologies to both of

Re: [PATCH V2] usb: Add Device Tree support to XHCI Platform driver

2013-07-23 Thread Sergei Shtylyov
Hello. On 23-07-2013 3:04, Al Cooper wrote: Add Device Tree match table to xhci-plat.c. Add DT bindings document. Signed-off-by: Al Cooper alcoop...@gmail.com [...] diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c index d718134..4c4823a 100644 ---

Re: [PATCH v2 1/8] clk: mux: Add support for read-only muxes.

2013-07-23 Thread Sergei Shtylyov
Hello. On 23-07-2013 3:49, Tomasz Figa wrote: Some platforms have read-only clock muxes that are preconfigured at reset and cannot be changed at runtime. This patch extends mux clock driver to allow handling such read-only muxes by adding new CLK_MUX_READ_ONLY mux flag. Signed-off-by:

Re: [PATCH v2 1/8] clk: mux: Add support for read-only muxes.

2013-07-23 Thread Tomasz Figa
Hi Sergei, On Tuesday 23 of July 2013 15:22:44 Sergei Shtylyov wrote: Hello. On 23-07-2013 3:49, Tomasz Figa wrote: Some platforms have read-only clock muxes that are preconfigured at reset and cannot be changed at runtime. This patch extends mux clock driver to allow handling such

Weird Serial number with Fitbit Base Station dongle

2013-07-23 Thread Laurent Bigonville
Hi, This is probably a minor issue, but when plugin the Fitbit base station dongle, I'm getting some weird serial number in dmesg. Can something be done here? Kind regards Laurent Bigonville [ 9993.722197] usb 1-1.2: new full-speed USB device number 7 using ehci-pci [ 9993.820617] usb 1-1.2:

[PATCH v3 4/5] staging: ozwpan: Convert macro to function.

2013-07-23 Thread Rupesh Gujare
From: Joe Perches j...@perches.com Replace macro with inline function. Signed-off-by: Joe Perches j...@perches.com Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozurbparanoia.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v3 0/5] staging: ozwpan: Replace debug macro

2013-07-23 Thread Rupesh Gujare
This is v3 of this original patch series here:- http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2013-June/039280.html v3 adds commit log for each patch as suggested by Joe here:- http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2013-July/039361.html Joe Perches

[PATCH v3 5/5] staging: ozwpan: Rename Kbuild to Makefile

2013-07-23 Thread Rupesh Gujare
From: Joe Perches j...@perches.com Rename Kbuild to usual Makefile, consistent with Kernel build structure. Signed-off-by: Joe Perches j...@perches.com Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/Kbuild | 16

[PATCH v3 1/5] staging: ozwpan: Remove extra debug logs.

2013-07-23 Thread Rupesh Gujare
From: Joe Perches j...@perches.com Remove unnecessary debug logs. Most of these logs print function name at the start of function, which are not really required. Signed-off-by: Joe Perches j...@perches.com Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozcdev.c

[PATCH v3 3/5] staging: ozwpan: Remove old debug macro.

2013-07-23 Thread Rupesh Gujare
From: Joe Perches j...@perches.com Remove old oz_trace oz_trace2 macro related header files. Signed-off-by: Joe Perches j...@perches.com Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/Kbuild |6 ++ drivers/staging/ozwpan/ozcdev.c|2

EHCI driver breaks at 6 endpoints

2013-07-23 Thread Stoddard, Nate (GE Healthcare)
Hello, We are attempting to create a system that will support 8 full speed USB devices each sending a 64-byte transfer every 1ms via interrupt endpoints. When we connect 5 full speed USB devices our USB host use 24% of the CPU, but when we connect a 6th device, the CPU goes to 100%. Has

[PATCH] USB: option: add D-Link DWM-152/C1 and DWM-156/C1

2013-07-23 Thread Alexandr Sky Ivanov
Adding support for D-Link DWM-152/C1 and DWM-156/C1 devices. DWM-152/C1: T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 6 Spd=480 MxCh= 0 D: Ver= 2.00 Cls=00(ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 P: Vendor=07d1 ProdID=3e01 Rev= 0.00 S: Product=USB Configuration S:

Re: [PATCH 2/2] usb: dwc3: ep0: don't change to configured state too early

2013-07-23 Thread Alan Stern
On Tue, 23 Jul 2013, Felipe Balbi wrote: @@ -148,6 +148,7 @@ static int __dwc3_gadget_ep0_queue(struct dwc3_ep *dep, direction = !dwc-ep0_expect_in; dwc-delayed_status = false; + usb_gadget_set_state(dwc-gadget, USB_STATE_CONFIGURED); Isn't

Re: [PATCH] usb: gadget: udc-core: move sysfs_notify() to a workqueue

2013-07-23 Thread Alan Stern
On Tue, 23 Jul 2013, Felipe Balbi wrote: Here's a newer version: commit 766ed104b6f420dc7587a63dc1679f78176d082e Author: Felipe Balbi ba...@ti.com Date: Wed Jul 17 11:09:49 2013 +0300 usb: gadget: udc-core: move sysfs_notify() to a workqueue usb_gadget_set_state() will

Re: [PATCH 6/6] USB: ehci-omap: Implement suspend/resume

2013-07-23 Thread Alan Stern
On Tue, 23 Jul 2013, Roger Quadros wrote: + pm_runtime_get_sync(dev); + ehci_resume(hcd, false); + ret = ehci_suspend(hcd, do_wakeup); + pm_runtime_put_sync(dev); It would be better to call pm_runtime_resume(dev) at the start

Re: Weird Serial number with Fitbit Base Station dongle

2013-07-23 Thread Alan Stern
On Tue, 23 Jul 2013, Laurent Bigonville wrote: Hi, This is probably a minor issue, but when plugin the Fitbit base station dongle, I'm getting some weird serial number in dmesg. Can something be done here? Kind regards Laurent Bigonville [ 9993.722197] usb 1-1.2: new full-speed

Re: [PATCH v4 1/1] Intel xhci: refactor EHCI/xHCI port switching

2013-07-23 Thread Alan Stern
On Tue, 23 Jul 2013, Mathias Nyman wrote: Make the Linux xHCI driver automatically try to switchover the EHCI ports to xHCI when an Intel xHCI host is detected, and it also finds an Intel EHCI host. This means we will no longer have to add Intel xHCI hosts to a quirks list when the PCI

[PATCH V3] usb: Add Device Tree support to XHCI Platform driver

2013-07-23 Thread Al Cooper
Add Device Tree match table to xhci-plat.c. Add DT bindings document. Signed-off-by: Al Cooper alcoop...@gmail.com --- Documentation/devicetree/bindings/usb/usb-xhci.txt | 14 ++ drivers/usb/host/xhci-plat.c | 9 + 2 files changed, 23 insertions(+)

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Alan Stern
On Tue, 23 Jul 2013, Tomasz Figa wrote: On Tuesday 23 of July 2013 09:29:32 Tomasz Figa wrote: Hi Alan, Thanks for helping to clarify the issues here. Okay. Are PHYs _always_ platform devices? They can be i2c, spi or any other device types as well. In those other cases, presumably

Re: [PATCH V3] usb: Add Device Tree support to XHCI Platform driver

2013-07-23 Thread Sergei Shtylyov
Hello. On 07/23/2013 06:35 PM, Matthijs Kooijman wrote: @@ -212,11 +213,19 @@ static int xhci_plat_remove(struct platform_device *dev) return 0; } +#ifdef CONFIG_OF +static const struct of_device_id usb_xhci_of_match[] = { + { .compatible = usb-xhci }, + {}, +}; I

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 10:37:05 Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: On Tuesday 23 of July 2013 09:29:32 Tomasz Figa wrote: Hi Alan, Thanks for helping to clarify the issues here. Okay. Are PHYs _always_ platform devices? They can be i2c, spi or any

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Kishon Vijay Abraham I
Hi, On Tuesday 23 July 2013 08:07 PM, Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: On Tuesday 23 of July 2013 09:29:32 Tomasz Figa wrote: Hi Alan, Thanks for helping to clarify the issues here. Okay. Are PHYs _always_ platform devices? They can be i2c, spi or any other

Re: EHCI driver breaks at 6 endpoints

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 01:33:25PM +, Stoddard, Nate (GE Healthcare) wrote: Hello, We are attempting to create a system that will support 8 full speed USB devices each sending a 64-byte transfer every 1ms via interrupt endpoints. When we connect 5 full speed USB devices our USB host use

Re: EHCI driver breaks at 6 endpoints

2013-07-23 Thread Fabio Estevam
On Tue, Jul 23, 2013 at 10:33 AM, Stoddard, Nate (GE Healthcare) nate.stodd...@med.ge.com wrote: Hello, We are attempting to create a system that will support 8 full speed USB devices each sending a 64-byte transfer every 1ms via interrupt endpoints. When we connect 5 full speed USB

Re: [PATCH 2/2] usb: dwc3: ep0: don't change to configured state too early

2013-07-23 Thread Felipe Balbi
Hi, On Tue, Jul 23, 2013 at 10:06:15AM -0400, Alan Stern wrote: @@ -148,6 +148,7 @@ static int __dwc3_gadget_ep0_queue(struct dwc3_ep *dep, direction = !dwc-ep0_expect_in; dwc-delayed_status = false; +

[PATCH V2 1/2] USB: OHCI: make ohci-ep93xx a separate driver

2013-07-23 Thread Manjunath Goudar
Separate the OHCI EP93XX host controller driver from ohci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM. Signed-off-by: Manjunath Goudar manjunath.gou...@linaro.org Cc: Arnd Bergmann a...@arndb.de Cc: Alan Stern

[PATCH V2 2/2] USB: OHCI: make ohci-pxa27x a separate driver

2013-07-23 Thread Manjunath Goudar
Separate the OHCI pxa27x/pxa3xx host controller driver from ohci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM. Signed-off-by: Manjunath Goudar manjunath.gou...@linaro.org Cc: Arnd Bergmann a...@arndb.de Cc: Greg KH

Re: a small patch that fixes the ohci warn irq nobody cared on shutdown.

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 07:13:02AM +, Caizhiyong wrote: Hi: Here's a small patch that fixes the ohci shutdown. The patch is against v3.4.54. 3.4 is quite old, and we can't add new patches to it that are not also in Linus's tree. Can you verify that 3.11-rc2 also needs this patch,

Re: [PATCH V3] usb: Add Device Tree support to XHCI Platform driver

2013-07-23 Thread Alan Cooper
This compiles without CONFIG_OF because of_match_ptr() assigns NULL if CONFIG_OF is not defined. On Tue, Jul 23, 2013 at 10:35 AM, Matthijs Kooijman matth...@stdin.nl wrote: Hi Al, @@ -212,11 +213,19 @@ static int xhci_plat_remove(struct platform_device *dev) return 0; } +#ifdef

Re: [PATCH V3] usb: Add Device Tree support to XHCI Platform driver

2013-07-23 Thread Matthijs Kooijman
Hi Alan, This compiles without CONFIG_OF because of_match_ptr() assigns NULL if CONFIG_OF is not defined. Ah, I guess that makes sense :-) Apologies for the noise... Gr. Matthijs -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 08:48:24PM +0530, Kishon Vijay Abraham I wrote: Hi, On Tuesday 23 July 2013 08:07 PM, Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: On Tuesday 23 of July 2013 09:29:32 Tomasz Figa wrote: Hi Alan, Thanks for helping to clarify the issues here.

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Kishon Vijay Abraham I
Hi Greg, On Tuesday 23 July 2013 09:48 PM, Greg KH wrote: On Tue, Jul 23, 2013 at 08:48:24PM +0530, Kishon Vijay Abraham I wrote: Hi, On Tuesday 23 July 2013 08:07 PM, Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: On Tuesday 23 of July 2013 09:29:32 Tomasz Figa wrote: Hi Alan,

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 09:58:34PM +0530, Kishon Vijay Abraham I wrote: Hi Greg, On Tuesday 23 July 2013 09:48 PM, Greg KH wrote: On Tue, Jul 23, 2013 at 08:48:24PM +0530, Kishon Vijay Abraham I wrote: Hi, On Tuesday 23 July 2013 08:07 PM, Alan Stern wrote: On Tue, 23 Jul 2013,

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 09:18:46 Greg KH wrote: On Tue, Jul 23, 2013 at 08:48:24PM +0530, Kishon Vijay Abraham I wrote: Hi, On Tuesday 23 July 2013 08:07 PM, Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: On Tuesday 23 of July 2013 09:29:32 Tomasz Figa wrote: Hi

Re: [PATCH 2/2] usb: dwc3: ep0: don't change to configured state too early

2013-07-23 Thread Alan Stern
On Tue, 23 Jul 2013, Felipe Balbi wrote: I see. Doesn't the mass-storage gadget also use delayed status when going into the _un_configured state? no it doesn't, we bail out early if config number is zero, look at composite.c and you'll see in case of configuration zero, we just make

Re: [PATCH 15/16] dmaengine: add transfered member to dma_async_tx_descriptor

2013-07-23 Thread Sebastian Andrzej Siewior
On 07/22/2013 08:52 PM, Sergei Shtylyov wrote: @@ -416,6 +418,7 @@ struct dma_async_tx_descriptor { dma_cookie_t (*tx_submit)(struct dma_async_tx_descriptor *tx); dma_async_tx_callback callback; void *callback_param; +unsigned int transfered; Correct grammar is

Re: [PATCH 14/16] usb: musb: dsps: add MUSB_DEVCTL_SESSION back after removal

2013-07-23 Thread Sebastian Andrzej Siewior
On 07/23/2013 07:28 PM, Bin Liu wrote: Hi, Hi, On Mon, Jul 22, 2013 at 1:10 PM, Sebastian Andrzej Siewior bige...@linutronix.de mailto:bige...@linutronix.de wrote: This patch adds the MUSB_DEVCTL_SESSION back after it has been removed. If it is missing then the host session is

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: Ick, no. Why can't you just pass the pointer to the phy itself? If you had a priv pointer to search from, then you could have just passed the original phy pointer in the first place, right? IMHO it would be better if you

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Mark Brown
On Tue, Jul 23, 2013 at 10:37:05AM -0400, Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: Okay. Are PHYs _always_ platform devices? They can be i2c, spi or any other device types as well. In those other cases, presumably there is no platform data associated with the PHY

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Mark Brown
On Tue, Jul 23, 2013 at 10:37:11AM -0700, Greg KH wrote: On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: I fully agree that a simple, single string will not scale even in some, not so uncommon cases, but there is already a lot of existing lookup solutions over the kernel and

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 10:37:11 Greg KH wrote: On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: Ick, no. Why can't you just pass the pointer to the phy itself? If you had a priv pointer to search from, then you could have just passed the original phy pointer in

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 06:44:56PM +0100, Mark Brown wrote: On Tue, Jul 23, 2013 at 10:37:11AM -0700, Greg KH wrote: On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: I fully agree that a simple, single string will not scale even in some, not so uncommon cases, but there

[PATCH 19/27] drivers/usb/phy: don't check resource with devm_ioremap_resource

2013-07-23 Thread Wolfram Sang
devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang w...@the-dreams.de --- Please apply via the subsystem-tree. drivers/usb/phy/phy-rcar-usb.c |5 - 1 file changed, 5 deletions(-) diff --git

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 07:48:11PM +0200, Tomasz Figa wrote: On Tuesday 23 of July 2013 10:37:11 Greg KH wrote: On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: Ick, no. Why can't you just pass the pointer to the phy itself? If you had a priv pointer to search from,

Re: [PATCH v2 01/42] ARM: at91: move at91_pmc.h to include/linux/clk/at91.h

2013-07-23 Thread Jean-Christophe PLAGNIOL-VILLARD
On 15:37 Wed 17 Jul , Boris BREZILLON wrote: This patch moves at91_pmc.h header from machine specific directory (arch/arm/mach-at91/include/mach/at91_pmc.h) to clk include directory (include/linux/clk/at91.h). please the at91_pmc.h in the name so we known the IP that we use and if we

Re: FUSB200 xhci issue

2013-07-23 Thread Christian Lamparter
On Tuesday, July 23, 2013 06:59:46 AM Oleksij Rempel wrote: Am 22.07.2013 23:23, schrieb Christian Lamparter: On Monday, July 22, 2013 10:47:41 PM Oleksij Rempel wrote: Am 22.07.2013 21:54, schrieb Christian Lamparter: Hello! On Monday, July 22, 2013 05:21:54 PM Oleksij Rempel wrote:

Re: [PATCH 2/6] USB: OHCI: make ohci-omap a separate driver

2013-07-23 Thread Alan Stern
On Mon, 22 Jul 2013, Manjunath Goudar wrote: Separate the TI OHCI OMAP1/2 host controller driver from ohci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM; it would be nice to have in 3.11. Signed-off-by:

Re: [PATCH 3/6] USB: OHCI: make ohci-omap3 a separate driver

2013-07-23 Thread Alan Stern
On Mon, 22 Jul 2013, Manjunath Goudar wrote: Separate the TI OHCI OMAP3 host controller driver from ohci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM; it would be nice to have in 3.11. Signed-off-by:

Re: [PATCH 5/6] USB: OHCI: make ohci-at91 a separate driver

2013-07-23 Thread Alan Stern
On Mon, 22 Jul 2013, Manjunath Goudar wrote: Separate the TI OHCI Atmel host controller driver from ohci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM; it would be nice to have in 3.12. Signed-off-by:

Re: [PATCH V2] USB: EHCI: make ehci-w90X900 a separate driver

2013-07-23 Thread Alan Stern
On Mon, 22 Jul 2013, Manjunath Goudar wrote: Separate the W90X900(W90P910) on-chip host controller driver from ehci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM; however, note that other changes are still needed

[PATCH] usb: gadget: at91_udc: Check gpio lookup results

2013-07-23 Thread Olof Johansson
This resolves the following valid build warning: drivers/usb/gadget/at91_udc.c:1685:34: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized] I switched from ? : to !! mostly to save from wrapping the lines while I was at it. Signed-off-by: Olof Johansson

Re: [PATCH 14/16] usb: musb: dsps: add MUSB_DEVCTL_SESSION back after removal

2013-07-23 Thread Bin Liu
Hi Sebastian, On Tue, Jul 23, 2013 at 12:31 PM, Sebastian Andrzej Siewior bige...@linutronix.de wrote: On 07/23/2013 07:28 PM, Bin Liu wrote: Hi, Hi, On Mon, Jul 22, 2013 at 1:10 PM, Sebastian Andrzej Siewior bige...@linutronix.de mailto:bige...@linutronix.de wrote: This

[PATCH] usb: xhci: Mark two functions __maybe_unused

2013-07-23 Thread Olof Johansson
Resolves the following build warnings: drivers/usb/host/xhci.c:332:13: warning: 'xhci_msix_sync_irqs' defined but not used [-Wunused-function] drivers/usb/host/xhci.c:3901:12: warning: 'xhci_change_max_exit_latency' defined but not used [-Wunused-function] These functions are not always used,

Re: [PATCH 06/16] usb: musb: dsps: rename ti81xx_driver_data to am33xx_driver_data

2013-07-23 Thread Bin Liu
(re-send, due to last delivery failure to the mailing list...) On Tue, Jul 23, 2013 at 1:23 PM, Bin Liu binml...@gmail.com wrote: Hi Sebastian, On Mon, Jul 22, 2013 at 1:09 PM, Sebastian Andrzej Siewior bige...@linutronix.de wrote: This patch renames the type struct from ti81xx_driver_data

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Mark Brown
On Tue, Jul 23, 2013 at 11:01:10AM -0700, Greg KH wrote: On Tue, Jul 23, 2013 at 06:44:56PM +0100, Mark Brown wrote: What are the problems you are seeing with doing things with lookups? You don't know the id of the device you are looking up, due to multiple devices being in the system

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Alan Stern
On Tue, 23 Jul 2013, Tomasz Figa wrote: IMHO it would be better if you provided some code example, but let's try to check if I understood you correctly. 8 [Board file] static struct phy my_phy; static struct

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 08:31:05PM +0100, Mark Brown wrote: You don't know the id of the device you are looking up, due to multiple devices being in the system (dynamic ids, look back earlier in this thread for details about that.) I got copied in very late so don't have most of the

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 12:44:23 Greg KH wrote: On Tue, Jul 23, 2013 at 08:31:05PM +0100, Mark Brown wrote: You don't know the id of the device you are looking up, due to multiple devices being in the system (dynamic ids, look back earlier in this thread for details about that.)

Re: Audio I/O parameters

2013-07-23 Thread James Stone
On Fri, Jul 19, 2013 at 4:17 PM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 19 Jul 2013, James Stone wrote: The questions now are: Why are the same requests sent over and over again? Why does the ALSA driver attempt to set the clock frequency while

Re: Audio I/O parameters

2013-07-23 Thread Alan Stern
On Tue, 23 Jul 2013, James Stone wrote: Hi Alan, Just tried a few old kernels, and it seems that the bug I am experiencing was introduced at the start of 3.7 - kernel 3.6.11 is Note that 3.6.11 came out _after_ 3.7, not before. fine, and all the 3.7 series kernels are broken. So it seems

[PATCH] usb: gadget: mv_u3d_core: fix violation of locking discipline in mv_u3d_ep_disable()

2013-07-23 Thread Alexey Khoroshilov
mv_u3d_nuke() expects to be calles with ep-u3d-lock held, because mv_u3d_done() does. But mv_u3d_ep_disable() calls it without lock that can lead to unpleasant consequences. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru ---

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 15:36:00 Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: IMHO it would be better if you provided some code example, but let's try to check if I understood you correctly. 8--- -

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 11:04:14 Greg KH wrote: On Tue, Jul 23, 2013 at 07:48:11PM +0200, Tomasz Figa wrote: On Tuesday 23 of July 2013 10:37:11 Greg KH wrote: On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: Ick, no. Why can't you just pass the pointer to the phy

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 10:07:52PM +0200, Tomasz Figa wrote: On Tuesday 23 of July 2013 12:44:23 Greg KH wrote: On Tue, Jul 23, 2013 at 08:31:05PM +0100, Mark Brown wrote: You don't know the id of the device you are looking up, due to multiple devices being in the system (dynamic ids,

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Alan Stern
On Tue, 23 Jul 2013, Tomasz Figa wrote: That's what I was going to suggest too. The struct phy is defined in the board file, which already knows about all the PHYs that exist in the system. (Or perhaps it is allocated dynamically, so that when many board files are present in the same

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 16:53:55 Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: That's what I was going to suggest too. The struct phy is defined in the board file, which already knows about all the PHYs that exist in the system. (Or perhaps it is allocated

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 13:50:07 Greg KH wrote: On Tue, Jul 23, 2013 at 10:07:52PM +0200, Tomasz Figa wrote: On Tuesday 23 of July 2013 12:44:23 Greg KH wrote: On Tue, Jul 23, 2013 at 08:31:05PM +0100, Mark Brown wrote: You don't know the id of the device you are looking up, due to

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Alan Stern
On Tue, 23 Jul 2013, Tomasz Figa wrote: If you want to keep the phy struct completely separate from the board file, there's an easy way to do it. Let's say the board file knows about N different PHYs in the system. Then you define an array of N pointers to phys: struct phy

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 11:05:48PM +0200, Tomasz Figa wrote: That's not so bad, as long as you let the phy core use whatever name it wants for the device when it registers it with sysfs. Yes, in regulator core consumer names are completely separated from this. Regulator core simply

Re: [PATCH v4] staging: usbip: replace pr_warning() with dev_warn().

2013-07-23 Thread Greg KH
On Thu, Jun 27, 2013 at 03:34:52PM +0530, navin patidar wrote: dev_warn() is preferred over pr_warning(). container_of() is used to get usb_driver pointer from usbip_device container (stub_device or vhci_device), to get device structure required for dev_warn(). Signed-off-by: navin patidar

Re: [PATCH 3/3] staging: dwc2: Don't touch the dma_mask when dma is disabled

2013-07-23 Thread Greg KH
On Fri, Jul 19, 2013 at 11:34:24AM +0200, Matthijs Kooijman wrote: There was some code that cleared the dma_mask when dma was disabled in the driver. Given that clearing the mask doesn't actually tell the usb core we're not using dma, and a previous commit explicitely sets the

Re: [PATCH] staging: dwc2: add microframe scheduler from downstream Pi kernel

2013-07-23 Thread Greg KH
On Wed, Jul 17, 2013 at 12:35:46PM -0700, Paul Zimmerman wrote: The transfer scheduler in the dwc2 driver is pretty basic, not to mention buggy. It works fairly well with just a couple of devices plugged in, but if you add, say, multiple devices with periodic endpoints, the scheduler breaks

[PATCH 4/5] Intel xhci: refactor EHCI/xHCI port switching

2013-07-23 Thread Sarah Sharp
From: Mathias Nyman mathias.ny...@linux.intel.com Make the Linux xHCI driver automatically try to switchover the EHCI ports to xHCI when an Intel xHCI host is detected, and it also finds an Intel EHCI host. This means we will no longer have to add Intel xHCI hosts to a quirks list when the PCI

[PATCH 5/5] xhci: Correct misplaced newlines

2013-07-23 Thread Sarah Sharp
From: Joe Perches j...@perches.com Logging messages end in newlines, not have them put in the middle of messages. Signed-off-by: Joe Perches j...@perches.com Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci.c | 10 +- 1 files changed, 5 insertions(+),

[Pull Request] xhci: Features for 3.12

2013-07-23 Thread Sarah Sharp
The following changes since commit 3b2f64d00c46e1e4e9bd0bb9bb12619adac27a4b: Linux 3.11-rc2 (2013-07-21 12:05:29 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git for-usb-next-2013-07-23 for you to fetch changes up to

[PATCH 2/5] xhci: Refactor port status into a new function.

2013-07-23 Thread Sarah Sharp
The hub control function is *way* too long. Refactor it into a new function, and document the side effects of calling that function. Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 210 --- 1 files changed, 119

[PATCH 1/5] usb: xhci: add the suspend/resume functionality

2013-07-23 Thread Sarah Sharp
From: Vikas Sajjan vikas.saj...@linaro.org Adds power management support to xHCI platform driver. This patch facilitates the transition of xHCI host controller between S0 and S3/S4 power states, during suspend/resume cycles. Signed-off-by: Abhilash Kesavan a.kesa...@samsung.com Signed-off-by:

[PATCH 3/5] xhci: Report USB 2.1 link status for L1

2013-07-23 Thread Sarah Sharp
USB 2.1 devices can go into a lower power link state, L1. When they are active, they are in the L0 state. The L1 transition can be purely driven by software, or some USB host controllers (including some xHCI 1.0 hosts) allow the host hardware to track idleness and automatically place a port into

Re: [PATCH 4/7] staging: usbip: add option for usbipd to save its process id.

2013-07-23 Thread Greg KH
On Mon, Jul 08, 2013 at 07:43:30PM -0600, Anthony Foiani wrote: Anthony Foiani anthony.foi...@gmail.com writes: Introduce option -P / --pid to request that usbipd save its PID to a file while running. I've already spotted one problem with this patch: +

Re: [PATCH 5/7] staging: usbip: set server port via option.

2013-07-23 Thread Greg KH
On Mon, Jul 08, 2013 at 07:47:20PM -0600, Anthony Foiani wrote: Anthony Foiani anthony.foi...@gmail.com writes: Add an option -p / --port to specify the TCP port to listen on. This is unfortunate, as port is also used to indicate which usbip port is in use by a particular connection.

Re: Weird Serial number with Fitbit Base Station dongle

2013-07-23 Thread Laurent Bigonville
Le Tue, 23 Jul 2013 10:16:00 -0400 (EDT), Alan Stern st...@rowland.harvard.edu a écrit : On Tue, 23 Jul 2013, Laurent Bigonville wrote: Hi, This is probably a minor issue, but when plugin the Fitbit base station dongle, I'm getting some weird serial number in dmesg. Can something

Re: [Pull Request] xhci: Features for 3.12

2013-07-23 Thread Greg Kroah-Hartman
On Tue, Jul 23, 2013 at 03:01:32PM -0700, Sarah Sharp wrote: The following changes since commit 3b2f64d00c46e1e4e9bd0bb9bb12619adac27a4b: Linux 3.11-rc2 (2013-07-21 12:05:29 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git

  1   2   >