Re: [PATCH v12 0/7] PHY framework

2013-09-28 Thread Kishon Vijay Abraham I
On Saturday 28 September 2013 06:07 AM, Greg KH wrote: On Fri, Sep 27, 2013 at 11:53:24AM +0530, Kishon Vijay Abraham I wrote: Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with

Re: [PATCH] Memory mapping for USBFS

2013-09-28 Thread Markus Rechberger
On Sat, Sep 28, 2013 at 4:39 AM, Ming Lei tom.leim...@gmail.com wrote: On Sat, Sep 28, 2013 at 10:29 AM, Alan Stern st...@rowland.harvard.edu wrote: On Sat, 28 Sep 2013, Ming Lei wrote: On Wed, Sep 25, 2013 at 3:12 AM, Markus Rechberger mrechber...@gmail.com wrote: This patch adds memory

[PATCH] Regression fix revert: Bluetooth: Add missing reset_resume dev_pm_ops

2013-09-28 Thread Hans de Goede
Many btusb devices have 2 modes, a hid mode and a bluetooth hci mode. These devices default to hid mode for BIOS use. This means that after having been reset they will revert to HID mode, and are no longer usable as a HCI. Therefor it is a very bad idea to just blindly make reset_resume point to

Re: [PATCH] Memory mapping for USBFS

2013-09-28 Thread Alan Stern
On Sat, 28 Sep 2013, Ming Lei wrote: On Sat, Sep 28, 2013 at 10:29 AM, Alan Stern st...@rowland.harvard.edu wrote: On Sat, 28 Sep 2013, Ming Lei wrote: On Wed, Sep 25, 2013 at 3:12 AM, Markus Rechberger mrechber...@gmail.com wrote: This patch adds memory mapping support to USBFS for

Re: [PATCH] Memory mapping for USBFS

2013-09-28 Thread Alan Stern
On Sat, 28 Sep 2013, Markus Rechberger wrote: Actually I observed both throughput and cpu utilization can be improved with the 4GB of DMA limit on either 32bit arch or 64bit arch, wrt. direct I/O over usb mass storage block device. I didn't look into the sg API in detail yet, but

Re: [PATCH] Memory mapping for USBFS

2013-09-28 Thread Markus Rechberger
On Sat, Sep 28, 2013 at 3:45 PM, Alan Stern st...@rowland.harvard.edu wrote: On Sat, 28 Sep 2013, Markus Rechberger wrote: Actually I observed both throughput and cpu utilization can be improved with the 4GB of DMA limit on either 32bit arch or 64bit arch, wrt. direct I/O over usb mass

Re: [PATCH] Memory mapping for USBFS

2013-09-28 Thread Ming Lei
On Sat, Sep 28, 2013 at 9:38 PM, Alan Stern st...@rowland.harvard.edu wrote: Very few non-xHCI controllers can do DMA above the 4 GB limit. Yes, but I am wondering non-xHCI need this kind of zero copy optimization, since very few user space drivers complain or care performance or cpu

Re: [PATCH] Memory mapping for USBFS

2013-09-28 Thread Alan Stern
On Sat, 28 Sep 2013, Markus Rechberger wrote: How about the initial patch, is it okay so far? I haven't had time to look through it yet. There's a settopbox manufacturer who pushed it to his next firmware release so we can do some additional performance measuring as well. My next step would

Re: [PATCH] Memory mapping for USBFS

2013-09-28 Thread Markus Rechberger
On Sat, Sep 28, 2013 at 5:17 PM, Alan Stern st...@rowland.harvard.edu wrote: On Sat, 28 Sep 2013, Markus Rechberger wrote: How about the initial patch, is it okay so far? I haven't had time to look through it yet. There's a settopbox manufacturer who pushed it to his next firmware release

Re: [PATCH] Memory mapping for USBFS

2013-09-28 Thread Alan Stern
On Sat, 28 Sep 2013, Markus Rechberger wrote: My next step would be to eliminate the kmallocs/kfrees for the single urbs (just by allocating the urbs with the same mechanism and passing the returned pointer to SUBMIT_URB). The time spent allocating and freeing URBs is probably pretty

[PATCH] USB: OHCI: Check the overrides pointer for NULL in ohci_init_driver()

2013-09-28 Thread Tomasz Figa
A series of commit starting at 50a97e059b USB: OHCI: make ohci-exynos a separate driver and ending at b8ad5c3706 USB: OHCI: make ohci-pxa27x a separate driver introduced the concept of separate OHCI drivers for particular controllers. Respective drivers need to call ohci_init_driver() to

PATCH: Ignore card reader interface on Huawei E1750

2013-09-28 Thread Michal MalĂ˝
Hi, my Huawei 3G modem has an embedded Smart Card reader which causes trouble when the modem is being detected (a bunch of warn (ttyUSBx): open blocked by driver for more than 7 seconds! in messages.log). This trivial patch corrects the problem for me. The modem identifies itself as 12d1:1406

Re: Cannot shutdown power use from built in webcam in thinkpad T530 questions]

2013-09-28 Thread Marc MERLIN
On Mon, Sep 23, 2013 at 10:21:23AM +0200, Oleksij Rempel wrote: Understood, just making sure this was still potentially useful considering what I found out since my last message. Which version of powertop are you actually using? None of current The latest, i.e. 2.4. versions would show

Re: [PATCH] Memory mapping for USBFS

2013-09-28 Thread Markus Rechberger
On Sat, Sep 28, 2013 at 7:43 PM, Alan Stern st...@rowland.harvard.edu wrote: On Sat, 28 Sep 2013, Markus Rechberger wrote: My next step would be to eliminate the kmallocs/kfrees for the single urbs (just by allocating the urbs with the same mechanism and passing the returned pointer to

Re: Cannot shutdown power use from built in webcam in thinkpad T530 questions]

2013-09-28 Thread Oleksij Rempel
Am 28.09.2013 20:08, schrieb Marc MERLIN: On Mon, Sep 23, 2013 at 10:21:23AM +0200, Oleksij Rempel wrote: Understood, just making sure this was still potentially useful considering what I found out since my last message. Which version of powertop are you actually using? None of current The

Re: [PATCH v1] USBNET: fix handling padding packet

2013-09-28 Thread David Miller
From: Ming Lei ming@canonical.com Date: Mon, 23 Sep 2013 20:59:35 +0800 Commit 638c5115a7949(USBNET: support DMA SG) introduces DMA SG if the usb host controller is capable of building packet from discontinuous buffers, but missed handling padding packet when building DMA SG. This

Re: [PATCH] Memory mapping for USBFS

2013-09-28 Thread Markus Rechberger
On Sat, Sep 28, 2013 at 8:52 PM, Markus Rechberger mrechber...@gmail.com wrote: On Sat, Sep 28, 2013 at 8:28 PM, Markus Rechberger mrechber...@gmail.com wrote: On Sat, Sep 28, 2013 at 7:43 PM, Alan Stern st...@rowland.harvard.edu wrote: On Sat, 28 Sep 2013, Markus Rechberger wrote: My

Re: EHCI bus glue driver works for storage, fails for a WiFi module

2013-09-28 Thread Arokux X
Dear Alan, I don't know. Did you run all these tests on the same computer? Yes, it is a single board computer, see image here: http://rhombus-tech.net/allwinner_a10/hacking_the_mele_a1000/A10_device_a1000_inside.jpg WLAN Adapter is left at the bottom. What happens if you back-port your

Re: EHCI bus glue driver works for storage, fails for a WiFi module

2013-09-28 Thread Alan Stern
On Sun, 29 Sep 2013, Arokux X wrote: What happens if you back-port your glue driver to the vendor's kernel? I have now 200 lines of code which are (almost) identical. They work in vendor's kernel and fail in mainline. This indicates that the problem isn't in your glue driver, but is

Re: [PATCH] USB: OHCI: Check the overrides pointer for NULL in ohci_init_driver()

2013-09-28 Thread Alan Stern
On Sat, 28 Sep 2013, Tomasz Figa wrote: A series of commit starting at 50a97e059b USB: OHCI: make ohci-exynos a separate driver and ending at b8ad5c3706 USB: OHCI: make ohci-pxa27x a separate driver introduced the concept of separate OHCI drivers for particular controllers.

Re: [PATCH] Memory mapping for USBFS

2013-09-28 Thread Alan Stern
On Sat, 28 Sep 2013, Markus Rechberger wrote: I hope the SG transfer does not introduce any latency issues we have some usb chipsets which are very picky about latency issues on embedded systems. The latency for SG transfers should be smaller than for non-SG. We got it work by tuning the

Re: [PATCH] Memory mapping for USBFS

2013-09-28 Thread Alan Stern
On Sat, 28 Sep 2013, Markus Rechberger wrote: I put together a few reports: http://support.sundtek.com/index.php/topic,350.0.html http://support.sundtek.com/index.php/topic,1097.msg7780.html#msg7780 http://support.sundtek.com/index.php/topic,411.msg2153.html#msg2153

Re: [PATCH] Memory mapping for USBFS

2013-09-28 Thread Alan Stern
On Sun, 29 Sep 2013, Markus Rechberger wrote: to follow up I know why it doesn't happen anymore because customers are using a kernel module which does optimized transfers and pre-allocated the URBs and transfer buffer in kernelspace, the interface just copies the datastream to our actual