Re: [PATCH 3/9] usb: hcd: Initialize USB phy if needed

2013-11-20 Thread Simon Horman
On Thu, Nov 21, 2013 at 01:26:19AM +0400, Valentine wrote: > On 11/20/2013 09:46 PM, Fabio Estevam wrote: > >On Wed, Nov 20, 2013 at 3:38 PM, Ulrich Hecht wrote: > >>From: Valentine Barshak > >> > >>This adds external USB phy support to USB HCD driver that > >>allows to find and initialize extern

Re: [PATCH] usb: phy: am335x: Prevent GPIO reset line request

2013-11-20 Thread Ezequiel Garcia
(Forgot to Cc OMAP people) On Wed, Nov 20, 2013 at 06:58:34PM -0300, Ezequiel Garcia wrote: > The 'gpio_reset' field was implicitly set to zero, which is a valid > GPIO line and results in the NOP PHY layer trying to request it. > > Instead, the AM335x SoC need special USB PHY reset handling so l

[PATCH] usb: phy: am335x: Prevent GPIO reset line request

2013-11-20 Thread Ezequiel Garcia
The 'gpio_reset' field was implicitly set to zero, which is a valid GPIO line and results in the NOP PHY layer trying to request it. Instead, the AM335x SoC need special USB PHY reset handling so let's set 'gpio_reset' to EINVAL and prevent the NOP PHY from messing with it. Signed-off-by: Ezequie

Re: [PATCH 3/9] usb: hcd: Initialize USB phy if needed

2013-11-20 Thread Valentine
On 11/20/2013 09:46 PM, Fabio Estevam wrote: On Wed, Nov 20, 2013 at 3:38 PM, Ulrich Hecht wrote: From: Valentine Barshak This adds external USB phy support to USB HCD driver that allows to find and initialize external USB phy, bound to the HCD, when the HCD is added. The usb_add_hcd function

Re: [PATCH 9/9] ARM: shmobile: lager: add PCI USB host controllers

2013-11-20 Thread Valentine
On 11/20/2013 09:38 PM, Ulrich Hecht wrote: Adds USB1 and 2 as hosts and binds them to the USB phy. Signed-off-by: Ulrich Hecht --- arch/arm/mach-shmobile/Kconfig | 1 + arch/arm/mach-shmobile/board-lager.c | 23 +++ 2 files changed, 24 insertions(+) diff --git a

Re: [PATCH 7/9] ARM: shmobile: r8a7790: add internal PCI clock

2013-11-20 Thread Valentine
On 11/20/2013 09:38 PM, Ulrich Hecht wrote: Adds clock for internal PCI host controllers. Signed-off-by: Ulrich Hecht --- arch/arm/mach-shmobile/clock-r8a7790.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-shmobile/clock-r8a7790.c b/arch/arm/mach-shm

Re: [PATCH 8/9] usb: phy: rcar-gen2: register using usb_add_phy_dev()

2013-11-20 Thread Valentine
On 11/20/2013 09:38 PM, Ulrich Hecht wrote: Allows binding of PCI USB host controllers to this phy. Signed-off-by: Ulrich Hecht --- drivers/usb/phy/phy-rcar-gen2-usb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-rcar-gen2-usb.c b/drivers/usb/phy

RE: [PATCH] usb: xhci: Link TRB must not occur with a USB payload burst.

2013-11-20 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of David Laight > Sent: Wednesday, November 20, 2013 9:16 AM > > > Ok, so the networking layer should be fine. However, with the current > > patch, if the mass storage driver sends down a scatter-gather

Re: [PATCH 6/9] pci: rcar-gen2: enable clock

2013-11-20 Thread Valentine
On 11/20/2013 09:38 PM, Ulrich Hecht wrote: Makes the PCI host controllers come alive. This is not needed if you use CCLKDEV_DEV_ID in patch 7/9 Thanks, Val. Signed-off-by: Ulrich Hecht --- drivers/pci/host/pci-rcar-gen2.c | 14 ++ 1 file changed, 14 insertions(+) diff --gi

Re: [PATCH 0/9] USB 2.0 host on Lager

2013-11-20 Thread Valentine
On 11/20/2013 09:37 PM, Ulrich Hecht wrote: This is a collection of patches developed by Valentine Barshak towards support of the PCI-attached USB 2.0 host controllers on Lager, with some glue supplied by me: - added missing PCI host clock (MSTP703) - bound PCI USB HCIs to the USB phy - added PC

Re: [RFC PATCH] PM / Runtime: Allow to inactivate devices during system suspend

2013-11-20 Thread Pavel Machek
On Wed 2013-11-20 11:58:31, Alan Stern wrote: > On Wed, 20 Nov 2013, Ulf Hansson wrote: > > > Do note that, the intent with my RFC is also to simplify for drivers > > in general using runtime PM. No matter how you put it, the > > consequences of preventing runtime suspend during system suspend are

Re: usb hub disconnects all devices

2013-11-20 Thread Alan Stern
On Wed, 20 Nov 2013, Kumar Gokhare wrote: > Hello, > > I hope this is the right place to query, if not I apologize. > > I have an android device which runs 2.6.32 kernel(v. old) which > randomly disconnects all downstream devices from the single usb port > occasionally. The issue seems to start

usb hub disconnects all devices

2013-11-20 Thread Kumar Gokhare
Hello, I hope this is the right place to query, if not I apologize. I have an android device which runs 2.6.32 kernel(v. old) which randomly disconnects all downstream devices from the single usb port occasionally. The issue seems to start from ehci reporting a power change event as in the below

Re: [PATCH 1/1] Workaround for Suspend/Resume issue of AX88772B under ChromeOS

2013-11-20 Thread Grant Grundler
On Wed, Nov 20, 2013 at 10:54 AM, David Miller wrote: > From: Grant Grundler > Date: Wed, 20 Nov 2013 09:42:42 -0800 > >> While this patch raises a new issue, can you apply this patch anyway >> since in most cases (default settings) it improves "the user >> experience" for most users? > > I'm not

Re: [PATCH 1/1] Workaround for Suspend/Resume issue of AX88772B under ChromeOS

2013-11-20 Thread David Miller
From: Grant Grundler Date: Wed, 20 Nov 2013 09:42:42 -0800 > While this patch raises a new issue, can you apply this patch anyway > since in most cases (default settings) it improves "the user > experience" for most users? I'm not applying a patch which knowingly is not implemented correctly. --

Re: [PATCH] usb: xhci: Link TRB must not occur with a USB payload burst.

2013-11-20 Thread Sarah Sharp
On Wed, Nov 20, 2013 at 05:16:12PM -, David Laight wrote: > > Ok, so the networking layer should be fine. However, with the current > > patch, if the mass storage driver sends down a scatter-gather list > > that's bigger than a ring segment, or needs to be split up so it doesn't > > cross 64K

Re: linux-next: Tree for Nov 20 (usb/gadget/storage_common.c)

2013-11-20 Thread Randy Dunlap
On 11/19/13 18:28, Stephen Rothwell wrote: > Hi all, > > Please do *not* add any v3.14 material to linux-next until after > v3.13-rc1 is released. > > Changes since 20131119: > on x86_64: when CONFIG_BLOCK is not enabled: drivers/usb/gadget/storage_common.c: In function 'fsg_lun_open': drivers

Re: [PATCH 3/9] usb: hcd: Initialize USB phy if needed

2013-11-20 Thread Fabio Estevam
On Wed, Nov 20, 2013 at 3:38 PM, Ulrich Hecht wrote: > From: Valentine Barshak > > This adds external USB phy support to USB HCD driver that > allows to find and initialize external USB phy, bound to > the HCD, when the HCD is added. > The usb_add_hcd function returns -EPROBE_DEFER if the USB > p

[PATCH 9/9] ARM: shmobile: lager: add PCI USB host controllers

2013-11-20 Thread Ulrich Hecht
Adds USB1 and 2 as hosts and binds them to the USB phy. Signed-off-by: Ulrich Hecht --- arch/arm/mach-shmobile/Kconfig | 1 + arch/arm/mach-shmobile/board-lager.c | 23 +++ 2 files changed, 24 insertions(+) diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-s

[PATCH 5/9] arm: shmobile: lager: Add USBHS support

2013-11-20 Thread Ulrich Hecht
From: Valentine Barshak This adds USBHS PHY and registers USBHS device if the driver is enabled. Signed-off-by: Valentine Barshak Acked-by: Kuninori Morimoto --- arch/arm/mach-shmobile/board-lager.c | 115 +++ 1 file changed, 115 insertions(+) diff --git a/arc

[PATCH 7/9] ARM: shmobile: r8a7790: add internal PCI clock

2013-11-20 Thread Ulrich Hecht
Adds clock for internal PCI host controllers. Signed-off-by: Ulrich Hecht --- arch/arm/mach-shmobile/clock-r8a7790.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-shmobile/clock-r8a7790.c b/arch/arm/mach-shmobile/clock-r8a7790.c index 6107571..5a84698 100

[PATCH 4/9] usb: phy: Add RCAR Gen2 USB phy

2013-11-20 Thread Ulrich Hecht
From: Valentine Barshak This adds RCAR Gen2 USB phy support. The driver configures USB channels 0/2 which are shared between PCI USB hosts and USBHS/USBSS devices. It also controls internal USBHS phy. Signed-off-by: Valentine Barshak --- drivers/usb/phy/Kconfig | 13 ++

[PATCH 3/9] usb: hcd: Initialize USB phy if needed

2013-11-20 Thread Ulrich Hecht
From: Valentine Barshak This adds external USB phy support to USB HCD driver that allows to find and initialize external USB phy, bound to the HCD, when the HCD is added. The usb_add_hcd function returns -EPROBE_DEFER if the USB phy, bound to the HCD, is not ready. If no USB phy is bound, the HCD

[PATCH 6/9] pci: rcar-gen2: enable clock

2013-11-20 Thread Ulrich Hecht
Makes the PCI host controllers come alive. Signed-off-by: Ulrich Hecht --- drivers/pci/host/pci-rcar-gen2.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c index cbaa5c4..568ff8e 100644 --- a/drivers/pci/host

[PATCH 8/9] usb: phy: rcar-gen2: register using usb_add_phy_dev()

2013-11-20 Thread Ulrich Hecht
Allows binding of PCI USB host controllers to this phy. Signed-off-by: Ulrich Hecht --- drivers/usb/phy/phy-rcar-gen2-usb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-rcar-gen2-usb.c b/drivers/usb/phy/phy-rcar-gen2-usb.c index a99a695..25fdd91 1006

Re: [PATCH 1/1] Workaround for Suspend/Resume issue of AX88772B under ChromeOS

2013-11-20 Thread Grant Grundler
On Tue, Nov 19, 2013 at 9:40 PM, David Miller wrote: > From: fre...@asix.com.tw > Date: Wed, 20 Nov 2013 10:11:36 +0800 > >> From: Freddy Xin >> >> This patch adds a workaroud to solve Suspend/Resume issue that AX88772B turns >> off its Ethernet PHY power in the case that REMOTE_WAKEUP feature do

[PATCH 2/9] usb: hcd: Remove USB phy if needed

2013-11-20 Thread Ulrich Hecht
From: Valentine Barshak This adds remove_phy flag to the HCD structure. If the flag is set and if hcd->phy is valid, the phy is shutdown and released whenever usb_add_hcd fails or usb_hcd_remove is called. This can be used by the HCD drivers to auto-remove the external USB phy when it is no longe

[PATCH 1/9] pci: Add R-Car Gen2 internal PCI support

2013-11-20 Thread Ulrich Hecht
From: Valentine Barshak This adds internal PCI controller driver for R-Car Gen2 SoC. There are three PCI controllers available with only a single EHCI/OHCI device built-in on each PCI bus. This gives us three USB channels. Channel 0 is shared with the USBHS device, while channel 2 is shared with

[PATCH 0/9] USB 2.0 host on Lager

2013-11-20 Thread Ulrich Hecht
This is a collection of patches developed by Valentine Barshak towards support of the PCI-attached USB 2.0 host controllers on Lager, with some glue supplied by me: - added missing PCI host clock (MSTP703) - bound PCI USB HCIs to the USB phy - added PCI host platform devices on Lager I chose to d

RE: [PATCH] usb: xhci: Link TRB must not occur with a USB payload burst.

2013-11-20 Thread David Laight
> Ok, so the networking layer should be fine. However, with the current > patch, if the mass storage driver sends down a scatter-gather list > that's bigger than a ring segment, or needs to be split up so it doesn't > cross 64K boundaries, then the URB submission will fail. We don't want > that t

RE: [PATCH] usb: xhci: Link TRB must not occur with a USB payload burst.

2013-11-20 Thread David Laight
> From: Alan Stern [mailto:st...@rowland.harvard.edu] > On Wed, 20 Nov 2013, David Laight wrote: > > > > From: Sarah Sharp > > ... > > > (Also, usb-storage aligns the block sizes to 512K, which explains why > > > we've never had an issue with TD fragments with that driver.) > > > > What is a 'bloc

RE: [PATCH] usb: xhci: Link TRB must not occur with a USB payload burst.

2013-11-20 Thread David Laight
> From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com] > On Wed, Nov 20, 2013 at 09:36:11AM -, David Laight wrote: > > > From: Alan Stern [mailto:st...@rowland.harvard.edu] > > > On Tue, 19 Nov 2013, Sarah Sharp wrote: > > > > > > > The xHCI driver can limit the number of sg-list entries th

Re: [RFC PATCH] PM / Runtime: Allow to inactivate devices during system suspend

2013-11-20 Thread Alan Stern
On Wed, 20 Nov 2013, Ulf Hansson wrote: > Do note that, the intent with my RFC is also to simplify for drivers > in general using runtime PM. No matter how you put it, the > consequences of preventing runtime suspend during system suspend are > causing confusions. Then fix the confusion. Explain

Re: [RFC PATCH] PM / Runtime: Allow to inactivate devices during system suspend

2013-11-20 Thread Alan Stern
On Wed, 20 Nov 2013, Ulf Hansson wrote: > On 19 November 2013 16:35, Alan Stern wrote: > > On Tue, 19 Nov 2013, Ulf Hansson wrote: > > > >> At the moment, system PM is already affecting behaviour of runtime PM > >> since it is preventing runtime suspend during system suspend. > > > > Sure. And t

Re: net/usb/ax88179_178a driver broken in linux-3.12

2013-11-20 Thread Sarah Sharp
On Wed, Nov 20, 2013 at 09:54:02AM -, David Laight wrote: > > From: Of David Miller > > > From: "David Laight" > > > Date: Tue, 19 Nov 2013 10:04:11 - > > > > > There is a patch to xhci-ring.c that should fix the SG problem. > > > http://www.spinics.net/lists/linux-usb/msg97176.html > > >

Re: [PATCH] usb: xhci: Link TRB must not occur with a USB payload burst.

2013-11-20 Thread Sarah Sharp
On Wed, Nov 20, 2013 at 09:46:08AM -, David Laight wrote: > > From: Sarah Sharp > ... > > (Also, usb-storage aligns the block sizes to 512K, which explains why > > we've never had an issue with TD fragments with that driver.) > > What is a 'block' in that context? > 512K sounds more like the v

[PATCH] staging: dwc2: add check on dwc2_core_reset return

2013-11-20 Thread Julien DELACOU
If the GRSTCTL_CSFTRST self-clearing bit never comes back to 0 for any reason, the controller is under reset state and cannot be used. It's preferable to abort initialization in such case. Signed-off-by: Julien Delacou --- drivers/staging/dwc2/core.c | 58 +-

RE: [PATCH] usb: xhci: Link TRB must not occur with a USB payload burst.

2013-11-20 Thread Alan Stern
On Wed, 20 Nov 2013, David Laight wrote: > > From: Sarah Sharp > ... > > (Also, usb-storage aligns the block sizes to 512K, which explains why > > we've never had an issue with TD fragments with that driver.) > > What is a 'block' in that context? I think Sarah means that usb-storage requires th

Re: [PATCH] usb: xhci: Link TRB must not occur with a USB payload burst.

2013-11-20 Thread Sarah Sharp
On Wed, Nov 20, 2013 at 09:36:11AM -, David Laight wrote: > > From: Alan Stern [mailto:st...@rowland.harvard.edu] > > On Tue, 19 Nov 2013, Sarah Sharp wrote: > > > > > The xHCI driver can limit the number of sg-list entries through > > > hcd->self.sg_tablesize. It's currently set to ~0, which

RE: [PATCH] usb: xhci: Link TRB must not occur with a USB payload burst.

2013-11-20 Thread David Laight
> From: Eric Dumazet [mailto:eric.duma...@gmail.com] > On Wed, 2013-11-20 at 09:36 +, David Laight wrote: > > > Ben said the largest number of fragments from the current network > > stack will be 17, and that none of them will cross 32k boundaries. > > So the network stack won't send down long

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-20 Thread Kishon Vijay Abraham I
Hi, On Wednesday 20 November 2013 03:02 PM, Vivek Gautam wrote: > On Wed, Nov 20, 2013 at 2:34 PM, Kishon Vijay Abraham I wrote: >> On Wednesday 20 November 2013 02:27 PM, Vivek Gautam wrote: >>> Hi Kishon, >>> >>> >>> On Mon, Nov 11, 2013 at 4:41 PM, Kishon Vijay Abraham I >>> wrote: Hi,

Re: musb lockup on am335x

2013-11-20 Thread Bin Liu
+linux-usb On Wed, Nov 20, 2013 at 8:02 AM, Mika Penttilä wrote: > On 11/19/2013 09:06 PM, Bin Liu wrote: >> Just realized we missed linux-usb list... >> >> On Tue, Nov 19, 2013 at 10:15 AM, Mika Penttilä >> wrote: >>> On 11/19/2013 05:10 PM, Bin Liu wrote: On Fri, Nov 15, 2013 at 1:47 PM,

RE: [PATCH] usb: xhci: Link TRB must not occur with a USB payload burst.

2013-11-20 Thread Eric Dumazet
On Wed, 2013-11-20 at 09:36 +, David Laight wrote: > Ben said the largest number of fragments from the current network > stack will be 17, and that none of them will cross 32k boundaries. > So the network stack won't send down long SG lists. Please note that skb->head itself _might_ cross a 3

Re: [RFC PATCH] PM / Runtime: Allow to inactivate devices during system suspend

2013-11-20 Thread Ulf Hansson
On 20 November 2013 12:23, Pavel Machek wrote: > On Wed 2013-11-20 11:52:05, Ulf Hansson wrote: >> On 19 November 2013 16:35, Alan Stern wrote: >> > On Tue, 19 Nov 2013, Ulf Hansson wrote: >> > >> >> At the moment, system PM is already affecting behaviour of runtime PM >> >> since it is preventin

Re: [RFC PATCH] PM / Runtime: Allow to inactivate devices during system suspend

2013-11-20 Thread Rafael J. Wysocki
On Wednesday, November 20, 2013 12:23:03 PM Pavel Machek wrote: > On Wed 2013-11-20 11:52:05, Ulf Hansson wrote: > > On 19 November 2013 16:35, Alan Stern wrote: > > > On Tue, 19 Nov 2013, Ulf Hansson wrote: > > > > > >> At the moment, system PM is already affecting behaviour of runtime PM > > >>

Re: [RFC PATCH] PM / Runtime: Allow to inactivate devices during system suspend

2013-11-20 Thread Pavel Machek
On Wed 2013-11-20 11:52:05, Ulf Hansson wrote: > On 19 November 2013 16:35, Alan Stern wrote: > > On Tue, 19 Nov 2013, Ulf Hansson wrote: > > > >> At the moment, system PM is already affecting behaviour of runtime PM > >> since it is preventing runtime suspend during system suspend. > > > > Sure.

Re: [RFC PATCH] PM / Runtime: Allow to inactivate devices during system suspend

2013-11-20 Thread Ulf Hansson
On 19 November 2013 16:35, Alan Stern wrote: > On Tue, 19 Nov 2013, Ulf Hansson wrote: > >> At the moment, system PM is already affecting behaviour of runtime PM >> since it is preventing runtime suspend during system suspend. > > Sure. And that behavior is documented. In any case, it's a bug fo

[Please test fixed version 2/3] cdc-acm: add TIOCGICOUNT

2013-11-20 Thread oliver
From: Oliver Neukum Simple straightforward implementation. Just returning the statistics gathered for TIOCMIWAIT Signed-off-by: Oliver Neukum --- drivers/usb/class/cdc-acm.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/

[Please test fixed version 1/3] cdc-acm: add TIOCMIWAIT

2013-11-20 Thread oliver
From: Oliver Neukum This implements TIOCMIWAIT for TIOCM_DSR, TIOCM_RI and TIOCM_CD Disconnect is handled as TIOCM_CD or an error. Signed-off-by: Oliver Neukum --- drivers/usb/class/cdc-acm.c | 86 ++--- drivers/usb/class/cdc-acm.h | 3 ++ 2 files chang

[Please test fixed version 3/3] cdc-acm: fix power management in ioctl

2013-11-20 Thread oliver
From: Oliver Neukum An ioctl that does depends on communication with a device should prevent suspension of teh device. Signed-off-by: Oliver Neukum --- drivers/usb/class/cdc-acm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.

Re: [PATCH v3 09/10] ARM: dts: omap3-beagle-xm: Add USB Host support

2013-11-20 Thread Roger Quadros
Nishant, On 11/19/2013 11:05 PM, Nishanth Menon wrote: > > > On 09/24/2013 03:53 AM, Roger Quadros wrote: >> Provide RESET GPIO and Power regulator for the USB PHY, >> the USB Host port mode and the PHY device for the controller. >> Also provide pin multiplexer information for USB host pins. >>

RE: [PATCH] usb: xhci: Link TRB must not occur with a USB payload burst.

2013-11-20 Thread David Laight
> From: Sarah Sharp ... > (Also, usb-storage aligns the block sizes to 512K, which explains why > we've never had an issue with TD fragments with that driver.) What is a 'block' in that context? 512K sounds more like the value that very long transfers get chopped up into. With 4k pages that might

RE: [PATCH] usb: xhci: Link TRB must not occur with a USB payload burst.

2013-11-20 Thread David Laight
> From: Alan Stern [mailto:st...@rowland.harvard.edu] > On Tue, 19 Nov 2013, Sarah Sharp wrote: > > > The xHCI driver can limit the number of sg-list entries through > > hcd->self.sg_tablesize. It's currently set to ~0, which is "however > > many entries you want. You could set that to the numbe

[PATCH net v5 0/4] r8152 bug fixes

2013-11-20 Thread Hayes Wang
For the patch #3, I add netif_tx_lock() before checking the netif_queue_stopped(). Besides, I add checking the skb queue length before waking the tx queue. Hayes Wang (4): r8152: fix tx/rx memory overflow r8152: modify the tx flow r8152: support stopping/waking tx queue r8152: fix incorrec

[PATCH net v5 2/4] r8152: modify the tx flow

2013-11-20 Thread Hayes Wang
Remove the code for sending the packet in the rtl8152_start_xmit(). Let rtl8152_start_xmit() to queue the packet only, and schedule a tasklet to send the queued packets. This simplify the code and make sure all the packet would be sent by the original order. Signed-off-by: Hayes Wang --- drivers

[PATCH net v5 4/4] r8152: fix incorrect type in assignment

2013-11-20 Thread Hayes Wang
The data from the hardware should be little endian. Correct the declaration. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index f92e0cf..5107372 10064

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-20 Thread Vivek Gautam
On Wed, Nov 20, 2013 at 2:34 PM, Kishon Vijay Abraham I wrote: > On Wednesday 20 November 2013 02:27 PM, Vivek Gautam wrote: >> Hi Kishon, >> >> >> On Mon, Nov 11, 2013 at 4:41 PM, Kishon Vijay Abraham I >> wrote: >>> Hi, >> sorry for the delayed response. >> >>> >>> On Wednesday 06 November 201

[PATCH net v5 1/4] r8152: fix tx/rx memory overflow

2013-11-20 Thread Hayes Wang
The tx/rx would access the memory which is out of the desired range. Modify the method of checking the end of the memory to avoid it. For r8152_tx_agg_fill(), the variable remain may become negative. However, the declaration is unsigned, so the while loop wouldn't break when reaching the end of th

[PATCH net v5 3/4] r8152: support stopping/waking tx queue

2013-11-20 Thread Hayes Wang
The maximum packet number which a tx aggregation buffer could contain is the tx_qlen. tx_qlen = buffer size / (packet size + descriptor size). If the tx buffer is empty and the queued packets are more than the maximum value which is defined above, stop the tx queue. Wake the tx queue if t

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-20 Thread Kishon Vijay Abraham I
On Wednesday 20 November 2013 02:27 PM, Vivek Gautam wrote: > Hi Kishon, > > > On Mon, Nov 11, 2013 at 4:41 PM, Kishon Vijay Abraham I wrote: >> Hi, > sorry for the delayed response. > >> >> On Wednesday 06 November 2013 05:37 AM, Jingoo Han wrote: >>> On Wednesday, November 06, 2013 2:58 AM, V

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-20 Thread Vivek Gautam
Hi Kishon, On Mon, Nov 11, 2013 at 4:41 PM, Kishon Vijay Abraham I wrote: > Hi, sorry for the delayed response. > > On Wednesday 06 November 2013 05:37 AM, Jingoo Han wrote: >> On Wednesday, November 06, 2013 2:58 AM, Vivek Gautam wrote: >>> On Tue, Nov 5, 2013 at 5:33 PM, Jingoo Han wrote: >>

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-20 Thread Vivek Gautam
On Wed, Nov 20, 2013 at 2:14 PM, Vivek Gautam wrote: > Hi Tomasz, > > > On Sun, Nov 10, 2013 at 7:38 PM, Tomasz Figa wrote: >> Hi Vivek, >> >> On Thursday 31 of October 2013 13:15:41 Vivek Gautam wrote: >>> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. >>> The new driver uses th

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-20 Thread Vivek Gautam
Hi Tomasz, On Sun, Nov 10, 2013 at 7:38 PM, Tomasz Figa wrote: > Hi Vivek, > > On Thursday 31 of October 2013 13:15:41 Vivek Gautam wrote: >> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. >> The new driver uses the generic PHY framework and will interact >> with DWC3 controller