Re: [RESEND PATCH v2 1/7] usb: xhci: plat: Fix suspend/resume when the optional clk exists

Dear Felipe, On Wed, 27 Apr 2016 08:25:38 +0300 Felipe Balbi wrote: > Hi, > > (since you're fixing somebody else's commit, it's nice to Cc authors) > > Jisheng Zhang writes: > > Commit 4718c1774051 ("usb: host: xhci-plat: add clock support") adds > > optional clk support,

Re: [PATCH 1/2] usb: chipidea: add flag CI_HDRC_DP_ALWAYS_PULLUP

On Wed, Apr 27, 2016 at 10:20:53AM +0530, maitysancha...@gmail.com wrote: > > > > Do you know the connect/disconnect by using USB Cable (not ID cable), I > > just want to know if the software can know connection, > > I did not understand this? Can you elaborate? When the board connects to PC,

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

Hi, Grygorii Strashko writes: > On 04/26/2016 09:17 AM, Felipe Balbi wrote: >> >> Hi, >> >> Grygorii Strashko writes: >>> Now not all DMA paremters configured properly for "xhci-hcd" platform >>> device which is created manually. For

Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control

Hi, Jisheng Zhang writes: > The Marvell BG4CT STB board has board level vbus control through gpio. > This patch adds the vbus regulator control to support this board. > > Signed-off-by: Jisheng Zhang > --- > drivers/usb/host/xhci-plat.c | 40

Re: [RESEND PATCH v2 6/7] usb: xhci: plat: add generic PHY support

Hi, Jisheng Zhang writes: > Marvell BG4CT SoC needs two phy: one for usb2 and another for usb3. Add > the calls to retrieve generic PHY to xhci plat in order to support this. > > Signed-off-by: Jisheng Zhang > --- > drivers/usb/host/xhci-plat.c | 87

Re: [RESEND PATCH v2 5/7] usb: xhci: plat: Remove checks for optional clock in error/remove path

Jisheng Zhang writes: > Commit 63589e92c2d9 ("clk: Ignore error and NULL pointers passed to > clk_{unprepare, disable}()") allows NULL or error pointer to be passed > unconditionally. > > This patch is to simplify probe error and remove code paths. this seems wrong to me.

Re: [PATCH v2 0/4] usb: chipidea: Add usb charger detection support

On Tue, Apr 26, 2016 at 04:18:32PM +0800, Li Jun wrote: > Some usb module soc implementations can support usb charger type detection, > which can be used by usb charger framework to control the charging current. > User can define the charge detection api of the platform data if want to > enable

Re: [RESEND PATCH v2 3/7] usb: xhci: plat: Fix suspend/resume when the optional usb_phy exists

Hi, Jisheng Zhang writes: > Commit 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support") adds the > usb_phy for usb3, but it forgets to shutdown/init the usb_phy in the > suspend/resume path. This patch fixes this issue by adding missing > usb_phy related calls. Fixes:

Re: [RESEND PATCH v2 2/7] usb: xhci: plat: attach the usb_phy to the correct hcd

Hi, (Cc authors and maintainer, otherwise you're patch might be forgotten ;-) Jisheng Zhang writes: > Commit 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support") adds the > usb_phy for usb3, but it attached the usb_phy to incorrect hcd. The where did you see that's the

Re: [RESEND PATCH v2 1/7] usb: xhci: plat: Fix suspend/resume when the optional clk exists

Hi, (since you're fixing somebody else's commit, it's nice to Cc authors) Jisheng Zhang writes: > Commit 4718c1774051 ("usb: host: xhci-plat: add clock support") adds > optional clk support, but it forgets to prepare/disable and

Re: [PATCH 07/12] usbip: vudc: Add UDC specific ops

Hi, Krzysztof Opasiak writes: > From: Igor Kotrasinski > > Add endpoints definitions and ops for both endpoints and gadget. > Add also a suitable platform driver and functions for handling > usbip events. > > This commit is a result of

Re: [PATCH 0/7] usb: host: add support for threaded IRQs

Hi, Greg Kroah-Hartman writes: > On Mon, Apr 11, 2016 at 04:35:37PM +0300, Felipe Balbi wrote: >> Felipe Balbi writes: >> >> > Hi guys, >> > >> > this patchset introduces support for threaded IRQs >> > for host controllers drivers to

Re: [PATCH 1/2] usb: chipidea: add flag CI_HDRC_DP_ALWAYS_PULLUP

Hello Peter, On 16-04-21 17:13:34, Peter Chen wrote: > On Tue, Apr 19, 2016 at 12:20:18PM +0530, maitysancha...@gmail.com wrote: > > Hello Peter, > > > > On 16-04-19 10:40:20, Peter Chen wrote: > > > On Mon, Apr 18, 2016 at 02:36:06PM +0530, maitysancha...@gmail.com wrote: > > > > Hello Peter, >

RE: [PATCH v2 1/1] usbip: safe completion against unbind operation

Dear Greg, Very sorry. I made mistake. I will send update with changelog separator. Thank you, n.iwata // > -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Wednesday, April 27, 2016 12:41 PM > To: fx IWATA NOBUO > Cc: valentina.mane...@gmail.com;

Re: [PATCH v2 1/1] usbip: safe completion against unbind operation

On Wed, Apr 27, 2016 at 11:16:05AM +0900, Nobuo Iwata wrote: > This patch adds a code fragment to ignore completing URBs in closing > connection. > > Regarding this patch, 2 execution contexts are related. > > 1) stub_tx.c: stub_complete() which is called from USB core > 1-1) add to unlink list

Re: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

On Tue, Apr 26, 2016 at 04:21:07PM +0800, Peter Chen wrote: > On Tue, Apr 26, 2016 at 07:00:22AM +, Jun Li wrote: > > Hi > > > > > -Original Message- > > > From: Peter Chen [mailto:hzpeterc...@gmail.com] > > > Sent: Tuesday, April 26, 2016 2:28 PM > > > To: Jun Li > >

RE: [PATCH] usb: hub: fix panic caused by NULL bos pointer during reset device

> On Tue, Mar 08, 2016 at 05:15:17PM +0800, changbin...@intel.com wrote: > > From: "Du, Changbin" > > > > This is a reworked patch based on reverted commit d8f00cd685f5 ("usb: > > hub: do not clear BOS field during reset device"). > > > > The privious one caused double

[PATCH v2 1/1] usbip: safe completion against unbind operation

This patch adds a code fragment to ignore completing URBs in closing connection. Regarding this patch, 2 execution contexts are related. 1) stub_tx.c: stub_complete() which is called from USB core 1-1) add to unlink list and free URB or 1-2) move to tx list 2) stub_dev.c:

Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface

Hi, On 04/26/2016 06:23 PM, Mark Brown wrote: > On Tue, Apr 26, 2016 at 10:24:56AM +0800, Lu Baolu wrote: > >> The GPIO name might be different in different use cases. For my case, >> it is "vbus_en", but other cases should use the different name. >> On ACPI compatible platforms, GPIO resources

Re: [PATCH] usb: core: buffer: avoid NULL pointer dereferrence

Hi, On Tue, 2016-04-26 at 16:11 -0700, Greg Kroah-Hartman wrote: > On Fri, Apr 08, 2016 at 11:21:05AM -0400, Alan Stern wrote: > > On Fri, 8 Apr 2016, Greg Kroah-Hartman wrote: > > > > > On Fri, Apr 08, 2016 at 05:08:03PM +0800, Chunfeng Yun wrote: > > > > NULL pointer dereferrence will happen

RE: [PATCH v1 1/1] usbip: safe completion against unbind operation

> Why spam the kernel log for this? What can a user do with this information? > Why not make it just a debug statement? No need to be 'info' level. It was my mistake. I will change it to 'debug' and send v2. Thank you for reviewing, nobuo.iwata // > -Original Message- > From: Greg KH

Re: [PATCH] usb: core: buffer: avoid NULL pointer dereferrence

On Fri, Apr 08, 2016 at 11:21:05AM -0400, Alan Stern wrote: > On Fri, 8 Apr 2016, Greg Kroah-Hartman wrote: > > > On Fri, Apr 08, 2016 at 05:08:03PM +0800, Chunfeng Yun wrote: > > > NULL pointer dereferrence will happen when class driver > > > wants to allocate zero length buffer and pool_max[0]

Re: [PATCH 0/7] usb: host: add support for threaded IRQs

On Mon, Apr 11, 2016 at 04:35:37PM +0300, Felipe Balbi wrote: > Felipe Balbi writes: > > > Hi guys, > > > > this patchset introduces support for threaded IRQs > > for host controllers drivers to use. Right now, only > > XHCI has been converted, but more drivers

Re: [PATCH 00/12] Add USB Device Controller for USB/IP protocol

On Tue, Mar 08, 2016 at 09:48:55PM +0100, Krzysztof Opasiak wrote: > Hi, > > This series extends USB/IP support in Kernel by adding an emulated > USB Device Controller. This allows to virtually connect USB gadget > created on a server to some remote machine as if it would be a fully > functional

Re: [PATCH 08/12] usbip: vudc: Add SysFS infrastructure for VUDC

On Tue, Mar 08, 2016 at 09:49:03PM +0100, Krzysztof Opasiak wrote: > From: Igor Kotrasinski > > Add sysfs attributes to allow controlling vudc from usbip tools. > > dev_desc - device descriptor of current gadget. This is required to >be consisten with current

Re: [PATCH] usb: hub: fix panic caused by NULL bos pointer during reset device

On Tue, Mar 08, 2016 at 05:15:17PM +0800, changbin...@intel.com wrote: > From: "Du, Changbin" > > This is a reworked patch based on reverted commit d8f00cd685f5 ("usb: > hub: do not clear BOS field during reset device"). > > The privious one caused double mem-free if run

Re: [PATCH v1 1/1] usbip: safe completion against unbind operation

On Tue, Mar 22, 2016 at 04:33:29PM +0900, Nobuo Iwata wrote: > This patch adds a code fragment to ignore completing URBs in closing > connection. > > Regarding this patch, 2 execution contexts are related. > > 1) stub_tx.c: stub_complete() which is called from USB core > 1-1) add to unlink list

Re: [PATCH 0/2] musb fixes for v4.6-rc5

On Mon, Apr 18, 2016 at 11:38:23AM -0500, Bin Liu wrote: > Hi Greg, > > Here are a couple fixes for musb for v4.6-rc5. Sorry for the delay, I picked these up with the request for 4.6-rc6, right? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the

Re: USB gadgets with configfs hang reboot

On 26.04.2016 19:49, Tony Lindgren wrote: * Ivaylo Dimitrov [160426 09:46]: On 26.04.2016 18:03, Alan Stern wrote: On Tue, 26 Apr 2016, Felipe Balbi wrote: Is there a reason why a process (pnatd in this particular case) doesn't get killed on reboot? there

Re: USB gadgets with configfs hang reboot

On 26.04.2016 18:03, Alan Stern wrote: On Tue, 26 Apr 2016, Felipe Balbi wrote: Is there a reason why a process (pnatd in this particular case) doesn't get killed on reboot? there might be, and that's probably the bug we're trying to figure out. But so far, no idea. One possible reason

Re: USB gadgets with configfs hang reboot

* Ivaylo Dimitrov [160426 09:46]: > > > On 26.04.2016 18:03, Alan Stern wrote: > >On Tue, 26 Apr 2016, Felipe Balbi wrote: > > > >>>Is there a reason why a process (pnatd in this particular case) doesn't > >>>get killed on reboot? > >> > >>there might be, and that's

Re: USB gadgets with configfs hang reboot

On Tue, 26 Apr 2016, Felipe Balbi wrote: > > Is there a reason why a process (pnatd in this particular case) doesn't > > get killed on reboot? > > there might be, and that's probably the bug we're trying to figure > out. But so far, no idea. One possible reason is that the process is in an

Re: [PATCH] usb: ehci-platform: add reset controller number in struct ehci_platform_priv

On Tue, 26 Apr 2016, Jiancheng Xue wrote: > > If an error occurs here... > > > Sorry. It's really a problem. I'll modify it in v2 like below: > > err = reset_control_deassert(priv->rsts[rst]); > if(err) { > reset_control_put(priv->rsts[rst]); > goto err_reset; > } Yes, that would

Re: [PATCH] musb_host: fix lockup on rxcsr_h_error

Hello. On 4/26/2016 9:45 AM, Max Uvarov wrote: Fix soft lockup when resetting remote device attached to usb host. Configuration: pppd -> musb hub -> usb-serial -> gms modem When gsm modem resets, musb rolls in incoming rx interrupts which does not give any time to other application as result

Re: [PATCH v10 4/9] phy: Add Tegra XUSB pad controller support

On Mon, Apr 18, 2016 at 1:43 PM, Thierry Reding wrote: > On Fri, Mar 04, 2016 at 05:19:34PM +0100, Thierry Reding wrote: >> -MODULE_LICENSE("GPL v2"); >> +EXPORT_SYMBOL_GPL(tegra_xusb_padctl_legacy_remove); > > Since this merely implements the binding change, does your

[RESEND PATCH v2 3/7] usb: xhci: plat: Fix suspend/resume when the optional usb_phy exists

Commit 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support") adds the usb_phy for usb3, but it forgets to shutdown/init the usb_phy in the suspend/resume path. This patch fixes this issue by adding missing usb_phy related calls. Signed-off-by: Jisheng Zhang ---

[RESEND PATCH v2 6/7] usb: xhci: plat: add generic PHY support

Marvell BG4CT SoC needs two phy: one for usb2 and another for usb3. Add the calls to retrieve generic PHY to xhci plat in order to support this. Signed-off-by: Jisheng Zhang --- drivers/usb/host/xhci-plat.c | 87 ++-- 1 file changed,

[RESEND PATCH v2 2/7] usb: xhci: plat: attach the usb_phy to the correct hcd

Commit 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support") adds the usb_phy for usb3, but it attached the usb_phy to incorrect hcd. The xhci->shared_hcd is the hcd for usb3, this patch fixes this issue by attach the usb_phy to the xhci->shared_hcd. Signed-off-by: Jisheng Zhang

[RESEND PATCH v2 5/7] usb: xhci: plat: Remove checks for optional clock in error/remove path

Commit 63589e92c2d9 ("clk: Ignore error and NULL pointers passed to clk_{unprepare, disable}()") allows NULL or error pointer to be passed unconditionally. This patch is to simplify probe error and remove code paths. Signed-off-by: Jisheng Zhang ---

[RESEND PATCH v2 4/7] usb: xhci: plat: sort the headers in alphabetic order

Sorting the headers in alphabetic order will help to reduce the conflict when adding new headers later. Signed-off-by: Jisheng Zhang --- drivers/usb/host/xhci-plat.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/xhci-plat.c

[RESEND PATCH v2 0/7] usb: xhci-plat: support generic PHY and vbus regulator

The Marvell BG4CT has xhci controller. This controller has two phys: one for usb2 and another for usb3. BG4CT boards have board level vbus control through gpio. I plan to add the xhci support in two steps: first of all, add generic PHY and vbus regulator control support to the xhci-plat driver.

[RESEND PATCH v2 1/7] usb: xhci: plat: Fix suspend/resume when the optional clk exists

Commit 4718c1774051 ("usb: host: xhci-plat: add clock support") adds optional clk support, but it forgets to prepare/disable and enable/unprepare the clk in the resume/suspend path. This path fixes this issue by adding missing clk related calls. Signed-off-by: Jisheng Zhang

Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface

On Tue, Apr 26, 2016 at 10:24:56AM +0800, Lu Baolu wrote: > The GPIO name might be different in different use cases. For my case, > it is "vbus_en", but other cases should use the different name. > On ACPI compatible platforms, GPIO resources are reported via ACPI > tables and (devm_)gpiod_get()

RE: [PATCH] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

Hi Geert-san, > From: Geert Uytterhoeven > Sent: Monday, April 25, 2016 11:57 PM > > Hi Shimoda-san, > > On Thu, Apr 21, 2016 at 2:57 PM, Geert Uytterhoeven > wrote: > > On Thu, Apr 21, 2016 at 12:27 PM, Yoshihiro Shimoda > > wrote: >

Re: [PATCH RFT] usb: chipidea: host: disable io watchdog

On Tue, Apr 26, 2016 at 11:27:17AM +0200, Lucas Stach wrote: > Am Dienstag, den 26.04.2016, 09:58 +0800 schrieb Peter Chen: > > On Mon, Apr 25, 2016 at 12:55:42PM +0200, Lucas Stach wrote: > > > The Chipidea EHCI core seems to behave sanely and doesn't need > > > the IO watchdog. This kills off 10

Re: [PATCH RFT] usb: chipidea: host: disable io watchdog

Am Dienstag, den 26.04.2016, 09:58 +0800 schrieb Peter Chen: > On Mon, Apr 25, 2016 at 12:55:42PM +0200, Lucas Stach wrote: > > The Chipidea EHCI core seems to behave sanely and doesn't need > > the IO watchdog. This kills off 10 non-deferrable wakeup events > > per second when the controller is

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

On 2016年04月25日 20:01, Felipe Balbi wrote: * PGP Signed by an unknown key Is this happening on set_config() ? If that's the case, why is gadget->speed set to USB_SPEED_SUPER to start with ? Your controller should already have negotiated highspeed which means function_descriptors() should

[PATCH v2 0/4] usb: chipidea: Add usb charger detection support

Some usb module soc implementations can support usb charger type detection, which can be used by usb charger framework to control the charging current. User can define the charge detection api of the platform data if want to enable it. There are 2 api and one flag used for it, if the usb hardware

[PATCH v2 4/4] doc: usb: ci-hdrc-usb2: add property usb-charger-detection

Set this property if your usb module has usb charger detect function and you want to use it. Signed-off-by: Li Jun --- Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v2 3/4] usb: chipidea: imx: add usb charger detection for imx7d

Adds imx7d usb charger detection implementation, which needs pull up DP line before do secondary detection and pull down DP afterwards. Signed-off-by: Li Jun --- drivers/usb/chipidea/ci_hdrc_imx.c | 3 +- drivers/usb/chipidea/usbmisc_imx.c | 161

[PATCH v2 1/4] usb: chipidea: add usb charger detection support

Some usb module implementations have functionality of detect usb charger type, it can be used by usb charger framework to report max current drawn from charger in different situations. Signed-off-by: Li Jun --- drivers/usb/chipidea/udc.c | 40

[PATCH v2 2/4] usb: chipidea: imx: add usb charger dectection for imx platforms

Some imx usb charger dectection need software implement the whole process, during which, pull up DP line via chipidea usb core is required. Signed-off-by: Li Jun --- drivers/usb/chipidea/ci_hdrc_imx.c | 44 ++

Re: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

On Tue, Apr 26, 2016 at 07:00:22AM +, Jun Li wrote: > Hi > > > -Original Message- > > From: Peter Chen [mailto:hzpeterc...@gmail.com] > > Sent: Tuesday, April 26, 2016 2:28 PM > > To: Jun Li > > Cc: Roger Quadros ; st...@rowland.harvard.edu; > >

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

On 04/26/2016 09:17 AM, Felipe Balbi wrote: > > Hi, > > Grygorii Strashko writes: >> Now not all DMA paremters configured properly for "xhci-hcd" platform >> device which is created manually. For example: dma_pfn_offset, dam_ops >> and iommu configuration will not

Re: [EXT] Re: [PATCH RESEND 3/5] USB: serial: cp210x: Added comments to CRTSCT flag code.

On Mon, Apr 25, 2016 at 06:09:01PM +, Konstantin Shkolnyy wrote: > I was planning to define all these bits in a separate future patch. > Would you rather prefer the magic numbers defined before fixing the bugs? Fixing the RTS bug (patch 1), which is the only "real" bug, should be done before

RE: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

Hi > -Original Message- > From: Peter Chen [mailto:hzpeterc...@gmail.com] > Sent: Tuesday, April 26, 2016 2:28 PM > To: Jun Li > Cc: Roger Quadros ; st...@rowland.harvard.edu; > ba...@kernel.org; gre...@linuxfoundation.org; peter.c...@freescale.com; >

[PATCH] musb_host: fix lockup on rxcsr_h_error

Fix soft lockup when resetting remote device attached to usb host. Configuration: pppd -> musb hub -> usb-serial -> gms modem When gsm modem resets, musb rolls in incoming rx interrupts which does not give any time to other application as result it totally lock ups. Solution is to keep original

Re: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

On Tue, Apr 26, 2016 at 05:11:36AM +, Jun Li wrote: > Hi > > > -Original Message- > > From: Peter Chen [mailto:hzpeterc...@gmail.com] > > Sent: Tuesday, April 26, 2016 11:47 AM > > To: Jun Li > > Cc: Roger Quadros ; st...@rowland.harvard.edu; > >

Re: USB gadgets with configfs hang reboot

Hi, Ivaylo Dimitrov writes: > Looks like there's some issue with the USB gadgets and configfs. > > I'm seeing rmmod of the UDC driver cause a warning and then reboot > hangs the system. This happens at least with v4.4, and I've reproduced > it

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

Hi, Grygorii Strashko writes: > Now not all DMA paremters configured properly for "xhci-hcd" platform > device which is created manually. For example: dma_pfn_offset, dam_ops > and iommu configuration will not corresponds "dwc3" devices > configuration. As result, this

Re: [PATCH v2 2/2] phy: Group vendor specific phy drivers

Hi Kishon, On Wed, Apr 6, 2016 at 7:37 PM, Vivek Gautam wrote: > Adding vendor specific directories in phy to group > phy drivers under their respective vendor umbrella. > > Also updated the MAINTAINERS file to reflect the correct > directory structure for phy drivers.