[PATCH 1/1] usb: chipidea: Kconfig: improve Kconfig help text

2016-06-20 Thread Peter Chen
Chipidea driver has been updated a lot, and more functions are supported, update Kconfig help text accordingly. Signed-off-by: Peter Chen --- drivers/usb/chipidea/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/Kconfig

[GIT PULL] USB OTG FSM Fix for v4.7-rc5

2016-06-20 Thread Peter Chen
The following changes since commit e4600d56323ed119469fdcb21564f7544e1e6b3c: Merge tag 'phy-for-4.7-rc' of git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy into usb-linus (2016-06-10 23:06:21 -0700) are available in the git repository at:

Re: [PATCH 07/12] power: pwrseq: rename file name for generic driver

2016-06-20 Thread Peter Chen
On Mon, Jun 20, 2016 at 02:48:20PM +0200, Krzysztof Kozlowski wrote: > On 06/17/2016 12:09 PM, Peter Chen wrote: > > The individual driver file name is better to contain module name. > > > > Signed-off-by: Peter Chen > > --- > > .../power/pwrseq/{pwrseq-simple.txt =>

RE: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

2016-06-20 Thread Yoshihiro Shimoda
Hi Roger, > From: Roger Quadros > Sent: Monday, June 20, 2016 7:13 PM > > Hi, > > On 20/06/16 10:45, Felipe Balbi wrote: < snip > > >> diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h > >> index f4fc0aa..1d74fb8 100644 > >> --- a/include/linux/usb/gadget.h > >> +++

Re: [PATCH 08/12] doc: binding: pwrseq-usb-generic: add binding doc for generic usb power sequence driver

2016-06-20 Thread Peter Chen
On Mon, Jun 20, 2016 at 08:29:55PM +0800, Chen-Yu Tsai wrote: > Hi, > > On Mon, Jun 20, 2016 at 7:26 PM, Peter Chen wrote: > > On Fri, Jun 17, 2016 at 12:16:48PM -0500, Rob Herring wrote: > >> On Fri, Jun 17, 2016 at 5:09 AM, Peter Chen wrote: > >> >

Re: [PATCH 08/12] doc: binding: pwrseq-usb-generic: add binding doc for generic usb power sequence driver

2016-06-20 Thread Peter Chen
On Mon, Jun 20, 2016 at 11:16:07AM -0500, Rob Herring wrote: > On Mon, Jun 20, 2016 at 07:26:51PM +0800, Peter Chen wrote: > > On Fri, Jun 17, 2016 at 12:16:48PM -0500, Rob Herring wrote: > > > On Fri, Jun 17, 2016 at 5:09 AM, Peter Chen wrote: > > > > Add binding doc for

[PATCH v4] usb: ohci-at91: Forcibly suspend ports while USB suspend

2016-06-20 Thread Wenyou Yang
In order to save power consumption, as a workaround, forcibly suspend the USB PORTA/B/C via setting the SUSPEND_A/B/C bits of OHCI Interrupt Configuration Register in the SFR while OHCI USB suspend. This suspend operation must be done before the USB clock is disabled, resume after the USB clock

Re: [balbi-usb:testing/next 64/67] otg.c:undefined reference to `usb_gadget_vbus_disconnect'

2016-06-20 Thread Sebastian Reichel
Hi Felipe, On Mon, Jun 13, 2016 at 09:01:55AM +0300, Felipe Balbi wrote: > From d45bdfafc3143dc7acc9d71131807d3e30ab7bcd Mon Sep 17 00:00:00 2001 > From: Felipe Balbi > Date: Tue, 31 May 2016 13:07:47 +0300 > Subject: [PATCH] usb: gadget: move gadget API functions

Re: [PATCH 08/12] doc: binding: pwrseq-usb-generic: add binding doc for generic usb power sequence driver

2016-06-20 Thread Mark Brown
On Mon, Jun 20, 2016 at 11:16:07AM -0500, Rob Herring wrote: > On Mon, Jun 20, 2016 at 07:26:51PM +0800, Peter Chen wrote: > > If the node has property "power-sequence", the pwrseq core will create > > related platform device, and the driver under pwrseq driver will handle > > power sequence

Re: [PATCH 2/2] dt-bindings: phy: Add qcom,usb-hsic-phy bindings

2016-06-20 Thread Rob Herring
On Fri, Jun 17, 2016 at 12:25:19PM +0200, Neil Armstrong wrote: > Signed-off-by: Neil Armstrong > --- > .../devicetree/bindings/phy/qcom,usb-hsic-phy.txt | 95 > ++ > 1 file changed, 95 insertions(+) > create mode 100644 >

Re: [PATCH 08/12] doc: binding: pwrseq-usb-generic: add binding doc for generic usb power sequence driver

2016-06-20 Thread Rob Herring
On Mon, Jun 20, 2016 at 07:26:51PM +0800, Peter Chen wrote: > On Fri, Jun 17, 2016 at 12:16:48PM -0500, Rob Herring wrote: > > On Fri, Jun 17, 2016 at 5:09 AM, Peter Chen wrote: > > > Add binding doc for generic usb power sequence driver, and update > > > generic usb device

Re: [PATCH] usb: xhci: handle uPD720201 and uPD720202 w/o ROM

2016-06-20 Thread Christian Lamparter
On Wednesday, June 08, 2016 12:14:57 AM Christian Lamparter wrote: > This patch adds a firmware check for the uPD720201K8-711-BAC-A > and uPD720202K8-711-BAA-A variant. Both of these chips are listed > in Renesas' R19UH0078EJ0500 Rev.5.00 "User's Manual: Hardware" as > devices which need a

Re: Use of USB_CTRL_SET_TIMEOUT & USB_CTRL_GET_TIMEOUT

2016-06-20 Thread Muni Sekhar
On Mon, Jun 20, 2016 at 7:57 PM, Felipe Balbi wrote: > > Hi, > > Muni Sekhar writes: >> #define USB_CTRL_GET_TIMEOUT5000 >> >> #define USB_CTRL_SET_TIMEOUT5000 >> >> >> >> >> >> Does the above

Re: Use of USB_CTRL_SET_TIMEOUT & USB_CTRL_GET_TIMEOUT

2016-06-20 Thread Felipe Balbi
Hi, Muni Sekhar writes: > #define USB_CTRL_GET_TIMEOUT5000 > > #define USB_CTRL_SET_TIMEOUT5000 > > > > > > Does the above mentioned timeouts will vary based on the packet length > of control transfers (8, 16, 32 or 64

Re: [PATCH v4 5/5] usb: dwc3: rockchip: add devicetree bindings documentation

2016-06-20 Thread Heiko Stübner
Hi William, Am Freitag, 17. Juni 2016, 17:18:59 schrieb William Wu: > On 06/17/2016 07:15 AM, Heiko Stübner wrote: > > Am Donnerstag, 2. Juni 2016, 20:34:56 schrieb William Wu: > >> This patch adds the devicetree documentation required for Rockchip > >> USB3.0 core wrapper consisting of USB3.0 IP

Re: Use of USB_CTRL_SET_TIMEOUT & USB_CTRL_GET_TIMEOUT

2016-06-20 Thread Muni Sekhar
On Mon, Jun 20, 2016 at 7:19 PM, Felipe Balbi wrote: > > Hi, > > Muni Sekhar writes: >>> Muni Sekhar writes: Hi All, Usb.h file is having the below mentioned USB_CTRL_SET_TIMEOUT &

Re: Use of USB_CTRL_SET_TIMEOUT & USB_CTRL_GET_TIMEOUT

2016-06-20 Thread Muni Sekhar
On Mon, Jun 20, 2016 at 6:22 PM, Felipe Balbi wrote: > > Hi, > > Muni Sekhar writes: >> Hi All, >> >> Usb.h file is having the below mentioned USB_CTRL_SET_TIMEOUT & >> USB_CTRL_GET_TIMEOUT macros. >> >> >> >> /* >> >> * timeouts, in

Re: Use of USB_CTRL_SET_TIMEOUT & USB_CTRL_GET_TIMEOUT

2016-06-20 Thread Felipe Balbi
Hi, Muni Sekhar writes: >> Muni Sekhar writes: >>> Hi All, >>> >>> Usb.h file is having the below mentioned USB_CTRL_SET_TIMEOUT & >>> USB_CTRL_GET_TIMEOUT macros. >>> >>> >>> >>> /* >>> >>> * timeouts, in milliseconds, used for

Re: Fwd: [PATCH] usb: gadget: pch_udc: reorder spin_[un]lock to avoid deadlock

2016-06-20 Thread Felipe Balbi
Hi, Iago Abal writes: > Hi, > > This patch basically undoes d3cb25a12138 so, if applied, the problem > reported by Pengyu may need a different fix. > > I can't reproduce the deadlocks, but looking at the code they seem > feasible, let me know otherwise. I can't take

Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

2016-06-20 Thread Felipe Balbi
Hi, Roger Quadros writes: > diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig > index 8689dcb..ed596ec 100644 > --- a/drivers/usb/Kconfig > +++ b/drivers/usb/Kconfig > @@ -32,6 +32,23 @@ if USB_SUPPORT > config USB_COMMON > tristate >

Re: Use of USB_CTRL_SET_TIMEOUT & USB_CTRL_GET_TIMEOUT

2016-06-20 Thread Felipe Balbi
Hi, Muni Sekhar writes: > Hi All, > > Usb.h file is having the below mentioned USB_CTRL_SET_TIMEOUT & > USB_CTRL_GET_TIMEOUT macros. > > > > /* > > * timeouts, in milliseconds, used for sending/receiving control messages > > * they typically complete within a few

Re: [PATCH 07/12] power: pwrseq: rename file name for generic driver

2016-06-20 Thread Krzysztof Kozlowski
On 06/17/2016 12:09 PM, Peter Chen wrote: > The individual driver file name is better to contain module name. > > Signed-off-by: Peter Chen > --- > .../power/pwrseq/{pwrseq-simple.txt => mmc-pwrseq-simple.txt} | 0 > drivers/power/pwrseq/Makefile

Re: Use of USB_CTRL_SET_TIMEOUT & USB_CTRL_GET_TIMEOUT

2016-06-20 Thread Oliver Neukum
On Mon, 2016-06-20 at 17:10 +0530, Muni Sekhar wrote: > #define USB_CTRL_GET_TIMEOUT5000 > > #define USB_CTRL_SET_TIMEOUT5000 > > > > > > Does the above mentioned timeouts will vary based on the packet length > of control transfers (8, 16, 32 or 64 bytes)? Those timeouts are for

Re: [PATCH 08/12] doc: binding: pwrseq-usb-generic: add binding doc for generic usb power sequence driver

2016-06-20 Thread Chen-Yu Tsai
Hi, On Mon, Jun 20, 2016 at 7:26 PM, Peter Chen wrote: > On Fri, Jun 17, 2016 at 12:16:48PM -0500, Rob Herring wrote: >> On Fri, Jun 17, 2016 at 5:09 AM, Peter Chen wrote: >> > Add binding doc for generic usb power sequence driver, and update >> >

Re: [PATCH v7 1/4] usb: dwc3: core.h: add some register definitions

2016-06-20 Thread Felipe Balbi
Hi, Roger Quadros writes: >> Roger Quadros writes: >>> Add OTG and GHWPARAMS6 register definitions >>> >>> Signed-off-by: Roger Quadros >>> --- >>> drivers/usb/dwc3/core.h | 84 >>> - >>> 1 file

Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

2016-06-20 Thread Roger Quadros
On 20/06/16 15:03, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>> Roger Quadros writes: It provides APIs for the following tasks - Registering an OTG/dual-role capable controller - Registering Host and Gadget controllers to OTG core

Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

2016-06-20 Thread Felipe Balbi
Hi, Roger Quadros writes: >> Roger Quadros writes: >>> It provides APIs for the following tasks >>> >>> - Registering an OTG/dual-role capable controller >>> - Registering Host and Gadget controllers to OTG core >>> - Providing inputs to and kicking the OTG state

Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

2016-06-20 Thread Felipe Balbi
Hi, Peter Chen writes: >> Roger Quadros writes: >> > It provides APIs for the following tasks >> > >> > - Registering an OTG/dual-role capable controller >> > - Registering Host and Gadget controllers to OTG core >> > - Providing inputs to and kicking the

Re: [PATCH 1/7] reset: Reorder inline reset_control_get*() wrappers

2016-06-20 Thread Philipp Zabel
Am Montag, den 06.06.2016, 16:56 +0100 schrieb Lee Jones: > We're about to split the current API into two, where consumers will > be forced to be explicit when requesting reset lines. The choice > will be to either the call the *_exclusive or *_shared variant > depending on whether they can

Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

2016-06-20 Thread Peter Chen
On Mon, Jun 20, 2016 at 10:45:31AM +0300, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: > > It provides APIs for the following tasks > > > > - Registering an OTG/dual-role capable controller > > - Registering Host and Gadget controllers to OTG core > > - Providing inputs

Re: [PATCH v7 1/4] usb: dwc3: core.h: add some register definitions

2016-06-20 Thread Roger Quadros
On 20/06/16 12:28, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> Add OTG and GHWPARAMS6 register definitions >> >> Signed-off-by: Roger Quadros >> --- >> drivers/usb/dwc3/core.h | 84 >> - >> 1 file

Use of USB_CTRL_SET_TIMEOUT & USB_CTRL_GET_TIMEOUT

2016-06-20 Thread Muni Sekhar
Hi All, Usb.h file is having the below mentioned USB_CTRL_SET_TIMEOUT & USB_CTRL_GET_TIMEOUT macros. /* * timeouts, in milliseconds, used for sending/receiving control messages * they typically complete within a few frames (msec) after they're issued * USB identifies 5 second timeouts,

Re: [PATCH 00/12] power: add generic power sequence framework

2016-06-20 Thread Peter Chen
On Sat, Jun 18, 2016 at 01:29:05AM +0200, Maciej S. Szmigiero wrote: > Hi Peter, > > On 17.06.2016 12:09, Peter Chen wrote: > > Hi all, > > > > We have an well-known problem that the device needs to do some power > > sequence before it can be recognized by related host, the typical > > example

Re: [PATCH 08/12] doc: binding: pwrseq-usb-generic: add binding doc for generic usb power sequence driver

2016-06-20 Thread Peter Chen
On Fri, Jun 17, 2016 at 12:16:48PM -0500, Rob Herring wrote: > On Fri, Jun 17, 2016 at 5:09 AM, Peter Chen wrote: > > Add binding doc for generic usb power sequence driver, and update > > generic usb device binding-doc accordingly. > > > > Signed-off-by: Peter Chen

RE: [PATCH] HID: fix noderef.cocci warnings

2016-06-20 Thread Masaki Ota
Hi, fengguang, ret = hid_hw_raw_request(hdev, U1_FEATURE_REPORT_ID, input, - sizeof(input), HID_FEATURE_REPORT, HID_REQ_SET_REPORT); + sizeof(*input), HID_FEATURE_REPORT, + HID_REQ_SET_REPORT); I tested this code, but our

RE: [PATCH] HID: fix noderef.cocci warnings

2016-06-20 Thread Jiri Kosina
On Mon, 20 Jun 2016, Masaki Ota wrote: > Hi, fengguang, > > ret = hid_hw_raw_request(hdev, U1_FEATURE_REPORT_ID, input, > - sizeof(input), HID_FEATURE_REPORT, HID_REQ_SET_REPORT); > + sizeof(*input), HID_FEATURE_REPORT, > +

Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

2016-06-20 Thread Roger Quadros
Hi, On 20/06/16 10:45, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> It provides APIs for the following tasks >> >> - Registering an OTG/dual-role capable controller >> - Registering Host and Gadget controllers to OTG core >> - Providing inputs to and kicking the OTG

Re: [PATCH] HID: fix noderef.cocci warnings

2016-06-20 Thread Fengguang Wu
Hi Masaki, On Mon, Jun 20, 2016 at 09:45:02AM +, Masaki Ota wrote: > Hi, fengguang, > > ret = hid_hw_raw_request(hdev, U1_FEATURE_REPORT_ID, input, > - sizeof(input), HID_FEATURE_REPORT, HID_REQ_SET_REPORT); > + sizeof(*input),

Re: [PATCH v10 06/14] usb: gadget.h: Add OTG to gadget interface

2016-06-20 Thread Roger Quadros
On 20/06/16 12:24, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: > Roger Quadros writes: >> The OTG core will use struct otg_gadget_ops to >> start/stop the gadget controller. >> >> The main purpose of this interface is to avoid

Re: [PATCH v7 1/4] usb: dwc3: core.h: add some register definitions

2016-06-20 Thread Felipe Balbi
Hi, Roger Quadros writes: > Add OTG and GHWPARAMS6 register definitions > > Signed-off-by: Roger Quadros > --- > drivers/usb/dwc3/core.h | 84 > - > 1 file changed, 83 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH v10 06/14] usb: gadget.h: Add OTG to gadget interface

2016-06-20 Thread Felipe Balbi
Hi, Roger Quadros writes: Roger Quadros writes: > The OTG core will use struct otg_gadget_ops to > start/stop the gadget controller. > > The main purpose of this interface is to avoid directly > calling usb_gadget_start/stop() from the OTG

Re: [PATCH 0/2] usb: phy: Add support for the Qualcomm HSIC USB PHY

2016-06-20 Thread Neil Armstrong
On 06/17/2016 06:39 PM, Stephen Boyd wrote: > On 06/17/2016 03:25 AM, Neil Armstrong wrote: >> In order to support the Qualcomm MDM9615 in the Sierra Wireless WP8548 >> Modules, add the Qualcomm HSIC USB PHY used inside the MDM9615 SoC. >> >> This patchset is part of a global SoC + Module + Board

Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend

2016-06-20 Thread Nicolas Ferre
Le 20/06/2016 10:52, Alexandre Belloni a écrit : > On 20/06/2016 at 08:46:02 +, Yang, Wenyou wrote : >> Hi Alexandre & Nicolas, >> >>> -Original Message- >>> From: Alexandre Belloni [mailto:alexandre.bell...@free-electrons.com] >>> Sent: 2016年6月20日 16:04 >>> To: Yang, Wenyou

Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend

2016-06-20 Thread Alexandre Belloni
On 20/06/2016 at 08:46:02 +, Yang, Wenyou wrote : > Hi Alexandre & Nicolas, > > > -Original Message- > > From: Alexandre Belloni [mailto:alexandre.bell...@free-electrons.com] > > Sent: 2016年6月20日 16:04 > > To: Yang, Wenyou > > Cc: Rob Herring ;

RE: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend

2016-06-20 Thread Yang, Wenyou
Hi Alexandre & Nicolas, > -Original Message- > From: Alexandre Belloni [mailto:alexandre.bell...@free-electrons.com] > Sent: 2016年6月20日 16:04 > To: Yang, Wenyou > Cc: Rob Herring ; Alan Stern ; > Greg Kroah-Hartman

Re: [PATCH v10 06/14] usb: gadget.h: Add OTG to gadget interface

2016-06-20 Thread Roger Quadros
On 20/06/16 11:13, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> [ Unknown signature status ] >> On 20/06/16 10:21, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Roger Quadros writes: The OTG core will use struct otg_gadget_ops to start/stop the

Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend

2016-06-20 Thread Alexandre Belloni
On 20/06/2016 at 03:16:35 +, Yang, Wenyou wrote : > > Sure, what I mean is that you can try to get the regmap for the SFR in > > every case. > > Depending on whether you were able to get it, you can decide to call > > ohci_at91_port_suspend/resume or not (just test for sfr_regmap != NULL). >

[PATCH v2] usb: dwc3: gadget: Add the suspend state checking when stopping gadget

2016-06-20 Thread Baolin Wang
It will be crash to stop gadget when the dwc3 device had been into suspend state, thus we need to check if the dwc3 device had been into suspend state when UDC try to stop gadget. Signed-off-by: Baolin Wang --- drivers/usb/dwc3/gadget.c |3 +++ 1 file changed, 3

Re: [PATCH] usb: dwc3: gadget: Add the suspend state checking when stopping gadget

2016-06-20 Thread Baolin Wang
On 20 June 2016 at 16:15, Felipe Balbi wrote: > Baolin Wang writes: > >> It will be crash to stop gadget when the dwc3 device had been into suspend >> state, thus we need to check if the dwc3 device had been into suspend state >> when UDC try to stop

Re: [PATCH v10 06/14] usb: gadget.h: Add OTG to gadget interface

2016-06-20 Thread Felipe Balbi
Hi, Roger Quadros writes: > [ Unknown signature status ] > On 20/06/16 10:21, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros writes: >>> The OTG core will use struct otg_gadget_ops to >>> start/stop the gadget controller. >>> >>> The main purpose of this

Re: [PATCH] usb: dwc3: gadget: Add the suspend state checking when stopping gadget

2016-06-20 Thread Felipe Balbi
Baolin Wang writes: > It will be crash to stop gadget when the dwc3 device had been into suspend > state, thus we need to check if the dwc3 device had been into suspend state > when UDC try to stop gadget. > > By the way I have rebased on your 'testing/next' branch. do

RE: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend

2016-06-20 Thread Yang, Wenyou
> -Original Message- > From: Ferre, Nicolas > Sent: 2016年6月8日 18:46 > To: Yang, Wenyou ; Alan Stern > ; Greg Kroah-Hartman > ; Rob Herring ; Alexandre > Belloni

Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

2016-06-20 Thread Felipe Balbi
Hi, Roger Quadros writes: > It provides APIs for the following tasks > > - Registering an OTG/dual-role capable controller > - Registering Host and Gadget controllers to OTG core > - Providing inputs to and kicking the OTG state machine I think I have already mentioned this, but

RE: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend

2016-06-20 Thread Yang, Wenyou
Hi Rob, > -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: 2016年6月9日 4:27 > To: Yang, Wenyou > Cc: Alan Stern ; Greg Kroah-Hartman > ; Ferre, Nicolas ; > Pawel

Re: [PATCH v10 06/14] usb: gadget.h: Add OTG to gadget interface

2016-06-20 Thread Roger Quadros
On 20/06/16 10:21, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> The OTG core will use struct otg_gadget_ops to >> start/stop the gadget controller. >> >> The main purpose of this interface is to avoid directly >> calling usb_gadget_start/stop() from the OTG core as

Re: [PATCH v10 06/14] usb: gadget.h: Add OTG to gadget interface

2016-06-20 Thread Felipe Balbi
Hi, Roger Quadros writes: > The OTG core will use struct otg_gadget_ops to > start/stop the gadget controller. > > The main purpose of this interface is to avoid directly > calling usb_gadget_start/stop() from the OTG core as they > wouldn't be defined in the built-in symbol