[PATCH v2] usb3: Fixed usb3 device is not detected in s0 when hotplug usb3 disk under S3

2016-08-16 Thread Huang, Huki
When end user inserts a usb3 device and put dut to s3. Then hotplug the usb3 disk under s3. The device will be lost upon resuming from s3. There is a corner case that the hub->change_bits for the usb3 port is not set when usb port change event happens. This will cause hub driver ignore the device

[PATCH v2] usb3: Fixed usb3 device is not detected in s0 when hotplug usb3 disk under S3

2016-08-16 Thread Huang, Huki
When end user inserts a usb3 device and put dut to s3. Then hotplug the usb3 disk under s3. The device will be lost upon resuming from s3. There is a corner case that the hub->change_bits for the usb3 port is not set when usb port change event happens. This will cause hub driver ignore the device

[PATCH v2] usb3: Fixed usb3 device is not detected in s0 when hotplug usb3 disk under S3

2016-08-16 Thread Huang, Huki
When end user inserts a usb3 device and put dut to s3. Then hotplug the usb3 disk under s3. The device will be lost upon resuming from s3. There is a corner case that the hub->change_bits for the usb3 port is not set when usb port change event happens. This will cause hub driver ignore the device

Re: [PATCH] usb: phy: mxs: Add DT bindings to configure TX settings

2016-08-16 Thread Peter Chen
On Tue, Aug 16, 2016 at 06:31:48PM -0400, Jaret Cantu wrote: > The TX settings can be calibrated for particular hardware. The > phy is reset by Linux, so this cannot be handled by the bootloader. > > The TRM mentions that the maximum resistance should be used for the > DN/DP calibration in order

[PATCH v2] usb3: Fixed usb3 device is not detected in s0 when hotplug usb3 disk under S3

2016-08-16 Thread Huang, Huki
When end user inserts a usb3 device and put dut to s3. Then hotplug the usb3 disk under s3. The device will be lost upon resuming from s3. There is a corner case that the hub->change_bits for the usb3 port is not set when usb port change event happens. This will cause hub driver ignore the device

[PATCH] usb: phy: mxs: Add DT bindings to configure TX settings

2016-08-16 Thread Jaret Cantu
The TX settings can be calibrated for particular hardware. The phy is reset by Linux, so this cannot be handled by the bootloader. The TRM mentions that the maximum resistance should be used for the DN/DP calibration in order to pass USB certification. The values for the TX registers are poorly

Re: [PATCH V2 RFC 6/6] ARM: dts: bcm2835: Add Raspberry Pi Zero

2016-08-16 Thread John Youn
On 8/16/2016 12:58 PM, Stefan Wahren wrote: > Hi John, > >> John Youn hat am 16. August 2016 um 21:30 >> geschrieben: >> >> >> On 7/26/2016 11:54 AM, Stefan Wahren wrote: >> ... >>> +/* >>> + * Settings for otg >>> + * >>> + dr_mode = "otg"; >>> + h-rx-fifo-size =

Re: [PATCH] USB: core: of: Check device_node before parsing in usb_of_get_child_node()

2016-08-16 Thread Vaibhav Hiremath
On Monday 15 August 2016 06:33 PM, Peter Chen wrote: On Mon, Aug 15, 2016 at 11:31:10AM -0700, Vaibhav Hiremath wrote: In case of HUB devices connected to USB ports, we may not have DT node representing it inside USB, and when devices connected to hub gets enumerated, call to

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

2016-08-16 Thread Rafał Miłecki
On 29 July 2016 at 09:09, Rafał Miłecki wrote: > HI Rob, > > I got problems following your objections, so it took me some time to > go back to this. > > On 21 July 2016 at 22:42, Rob Herring wrote: >> On Wed, Jul 20, 2016 at 10:06:23AM +0200, Rafał Miłecki

Re: [PATCH v2 2/3] usb: gadget: f_uac2: split out audio core

2016-08-16 Thread Ruslan Bilovol
On Tue, Aug 16, 2016 at 9:20 PM, kbuild test robot <l...@intel.com> wrote: > Hi Ruslan, > > [auto build test ERROR on balbi-usb/next] > [also build test ERROR on v4.8-rc2 next-20160816] > [if your patch is applied to the wrong git tree, please drop us a note to > help imp

Re: [PATCH v2 0/3] USB Audio Gadget refactoring

2016-08-16 Thread Ruslan Bilovol
On Tue, Aug 16, 2016 at 12:16 PM, Peter Chen wrote: > On Sun, Aug 14, 2016 at 01:21:21AM +0300, Ruslan Bilovol wrote: >> I came to this patch series when wanted to do two things: >> - use UAC1 as virtual ALSA sound card on gadget side, >>just like UAC2 is used so it's

Re: [PATCH v2 3/3] usb: gadget: add f_uac1 variant based on new u_audio api

2016-08-16 Thread Ruslan Bilovol
On Tue, Aug 16, 2016 at 5:52 AM, Peter Chen wrote: > On Sun, Aug 14, 2016 at 01:21:24AM +0300, Ruslan Bilovol wrote: >> This patch adds new function f_uac1_newapi that >> uses recently created u_audio api. This makes >> f_uac1_newapi implementation much simpler by >>

Re: [PATCH v2 4/7] phy-sun4i-usb: Add support for phy_set_mode

2016-08-16 Thread Hans de Goede
Hi, On 08/16/2016 03:48 PM, Sergei Shtylyov wrote: Hello. On 08/15/2016 10:21 PM, Hans de Goede wrote: Together with some musb sunxi glue changes this allows run-time dr_mode switching support via the "mode" musb sysfs attribute. Signed-off-by: Hans de Goede ---

Re: [PATCH V2 RFC 1/6] usb: dwc2: core: Avoid nonsense error in gadget mode

2016-08-16 Thread Stefan Wahren
Hi John, > John Youn hat am 16. August 2016 um 21:20 > geschrieben: > > > On 8/16/2016 9:44 AM, Stefan Wahren wrote: > > Hi John, > > > >> John Youn hat am 16. August 2016 um 03:30 > ... > > [2.476378] dwc2 2098.usb:

Re: [PATCH V2 RFC 6/6] ARM: dts: bcm2835: Add Raspberry Pi Zero

2016-08-16 Thread John Youn
On 7/26/2016 11:54 AM, Stefan Wahren wrote: > The Raspberry Pi Zero is a minified version of model A+. It's > notable there is no PWR LED and the ACT LED is inverted. > > Signed-off-by: Stefan Wahren > --- > arch/arm/boot/dts/Makefile |3 +- >

Re: [PATCH V2 RFC 1/6] usb: dwc2: core: Avoid nonsense error in gadget mode

2016-08-16 Thread John Youn
On 8/16/2016 9:44 AM, Stefan Wahren wrote: > Hi John, > >> John Youn hat am 16. August 2016 um 03:30 >> geschrieben: >> >> >> On 7/26/2016 11:54 AM, Stefan Wahren wrote: >>> In gadget mode On bcm2835 platform the host tx fifo size could be zero. >>> So add zero to range

Re: [PATCH v2 2/3] usb: gadget: f_uac2: split out audio core

2016-08-16 Thread kbuild test robot
Hi Ruslan, [auto build test ERROR on balbi-usb/next] [also build test ERROR on v4.8-rc2 next-20160816] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ruslan-Bilovol/USB-Audio-Gadget-refactoring

Re: [PATCH V2 RFC 1/6] usb: dwc2: core: Avoid nonsense error in gadget mode

2016-08-16 Thread Stefan Wahren
Hi John, > John Youn hat am 16. August 2016 um 03:30 > geschrieben: > > > On 7/26/2016 11:54 AM, Stefan Wahren wrote: > > In gadget mode On bcm2835 platform the host tx fifo size could be zero. > > So add zero to range and avoid such nonsense errors: > > > > dwc2

Re: [PATCH v4 1/2] mfd: ti-smusbdig: Add support for the TI SM-USB-DIG

2016-08-16 Thread Andrew F. Davis
On 08/09/2016 10:27 AM, Lee Jones wrote: > On Tue, 09 Aug 2016, Andrew F. Davis wrote: > >> The TI SM-USB-DIG is a USB to SPI/I2C/1Wire/GPIO adapter. >> Add MFD core support. >> >> Signed-off-by: Andrew F. Davis >> --- >> drivers/mfd/Kconfig | 9 +++ >>

Re: [PATCHv4 0/2] USB Type-C Connector class

2016-08-16 Thread Guenter Roeck
On Tue, Aug 16, 2016 at 10:38:26AM +0300, Heikki Krogerus wrote: > Hi guys, > > Sorry for the long silence. I just returned from paternal leave. > > On Wed, Aug 10, 2016 at 10:19:25AM +0200, Oliver Neukum wrote: > > On Tue, 2016-08-09 at 09:23 -0700, Guenter Roeck wrote: > > > > I'm not going to

Re: [PATCH] phy: rockchip-inno-usb2: add COMMON_CLK dependency

2016-08-16 Thread Guenter Roeck
On Tue, Aug 16, 2016 at 02:02:00PM +0800, Frank Wang wrote: > On kernel builds without COMMON_CLK, the newly added rockchip-inno-usb2 > driver fails to build: > > drivers/phy/phy-rockchip-inno-usb2.c:124:16: error: field 'clk480m_hw' > has incomplete type >struct clk_hw clk480m_hw; > > In

Re: [PATCH V2 RFC 1/6] usb: dwc2: core: Avoid nonsense error in gadget mode

2016-08-16 Thread Eric Anholt
John Youn writes: > On 7/26/2016 11:54 AM, Stefan Wahren wrote: >> In gadget mode On bcm2835 platform the host tx fifo size could be zero. >> So add zero to range and avoid such nonsense errors: >> >> dwc2 2098.usb: 0 invalid for host_nperio_tx_fifo_size. >> dwc2

[PATCH v3 2/8] usb: ulpi: add new api functions, {read|write}_dev()

2016-08-16 Thread Tal Shorer
Add these two new api callbacks to struct ulpi_ops. These are different than read, write in that they pass the parent device directly instead of via the ops argument. They are intended to replace the old api functions. If the new api callbacks are missing, revert to calling the old ones as

[PATCH v3 0/8] usb: ulpi: remove "dev" field from struct ulpi_ops

2016-08-16 Thread Tal Shorer
struct ulpi_ops is defined as follows: struct ulpi_ops { struct device *dev; int (*read)(struct ulpi_ops *ops, u8 addr); int (*write)(struct ulpi_ops *ops, u8 addr, u8 val); }; Upon calling ulpi_register_interface(), the struct device argument is put inside the struct

[PATCH v3 7/8] usb: ulpi: make ops struct constant

2016-08-16 Thread Tal Shorer
None of the core ulpi functions perform any changes to the operations struct, and logically as a struct that contains function pointers there's no reason it shouldn't be constant. Signed-off-by: Tal Shorer --- drivers/usb/common/ulpi.c | 3 ++-

[PATCH v3 5/8] usb: ulpi: rename operations {read|write}_dev to simply {read|write}

2016-08-16 Thread Tal Shorer
With the removal of the old {read|write} operations, we can now safely rename the new api operations {read|write}_dev to use the shorter and clearer names {read|write}, respectively. Signed-off-by: Tal Shorer --- drivers/usb/common/ulpi.c | 4 ++--

[PATCH v3 4/8] usb: ulpi: remove calls to old api callbacks

2016-08-16 Thread Tal Shorer
Now that all users use the new api callbacks, remove the old api callbacks and force new interface drivers to use the new api. Signed-off-by: Tal Shorer --- drivers/usb/common/ulpi.c | 4 include/linux/ulpi/interface.h | 2 -- 2 files changed, 6 deletions(-)

[PATCH v3 8/8] usb: dwc3: ulpi: make dwc3_ulpi_ops constant

2016-08-16 Thread Tal Shorer
ulpi_register_interface() accepts a const struct ulpi_ops and dwc3 doesn't perform any changes to this struct at runtime, so there's no reason it shouldn't be constant. Signed-off-by: Tal Shorer --- drivers/usb/dwc3/ulpi.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v3 3/8] usb: dwc3: ulpi: use new api

2016-08-16 Thread Tal Shorer
The old read, write callbacks in struct ulpi_ops have been deprecated in favor of new callbacks that pass the parent device directly. Replace the used callbacks in dwc3's ulpi component with the new api. Signed-off-by: Tal Shorer --- drivers/usb/dwc3/ulpi.c | 12

[PATCH v3 6/8] usb: ulpi: remove "dev" field from struct ulpi_ops

2016-08-16 Thread Tal Shorer
Operations now use ulpi->dev.parent directly instead of via the ulpi_ops struct, making this field unused. Remove it. Signed-off-by: Tal Shorer --- drivers/usb/common/ulpi.c | 1 - include/linux/ulpi/interface.h | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-)

[PATCH v3 1/8] usb: ulpi: move setting of ulpi->dev parent up in ulpi_register()

2016-08-16 Thread Tal Shorer
Once ulpi operations use the parent device directly, this will be needed during the operations used in ulpi_register() itself, so set the parent field before calling any ulpi operations. Signed-off-by: Tal Shorer --- drivers/usb/common/ulpi.c | 3 ++- 1 file changed, 2

Re: [Umap2][9/11][05c5:0002] NULL pointer dereference

2016-08-16 Thread Binyamin Sharet
On 08/16/2016 06:04 PM, Johan Hovold wrote: > On Tue, Aug 16, 2016 at 10:47:44AM -0400, Alan Stern wrote: >> On Tue, 16 Aug 2016, Binyamin Sharet wrote: >> >>> Kernel version: raspberrypi 4.4.6-v7+ #871 >>> Driver source file: drivers/usb/serial/digi_acceleport.c >>> Umap2 command line:

Re: [PATCH 2/2] usb: gadget: f_ncm: add support for scatter/gather SKB to enable GSO

2016-08-16 Thread Jussi Kivilinna
Hello, 16.08.2016, 13:56, Felipe Balbi kirjoitti: > Jussi Kivilinna writes: >>> Jussi Kivilinna writes: Enabling SG allows enabling GSO (generic segmentation offload) feature of linux networking layer. This increases TCP

Re: Potential vulnerabilities in USB host stack/drivers

2016-08-16 Thread Binyamin Sharet
On 08/16/2016 05:51 PM, Greg KH wrote: > On Tue, Aug 16, 2016 at 04:40:43PM +0300, Binyamin Sharet wrote: >> Hi, >> >> We are using Umap2 to scan USB hosts for vendor-specific device support. >> e.g. whether appropriate drivers are loaded when a device with a specific >> VID/PID is inserted. >>

Re: [Umap2][1/11][0aa8:8001] USB stack hang

2016-08-16 Thread Binyamin Sharet
On 08/16/2016 05:49 PM, Greg KH wrote: > On Tue, Aug 16, 2016 at 04:42:23PM +0300, Binyamin Sharet wrote: >> Kernel version: raspberrypi 4.4.6-v7+ #871 >> Kernel version: 4.4.0-24-generic #43-Ubuntu SMP >> Driver source file: drivers/staging/media/lirc/lirc_imon.c >> Umap2 command line:

Re: [Umap2][9/11][05c5:0002] NULL pointer dereference

2016-08-16 Thread Johan Hovold
On Tue, Aug 16, 2016 at 10:47:44AM -0400, Alan Stern wrote: > On Tue, 16 Aug 2016, Binyamin Sharet wrote: > > > Kernel version: raspberrypi 4.4.6-v7+ #871 > > Driver source file: drivers/usb/serial/digi_acceleport.c > > Umap2 command line: umap2vsscan -P -s 05c5:0002 > > > > After connecting

Re: [Umap2][4/11][0557:2002] NULL pointer dereference

2016-08-16 Thread Alan Stern
On Tue, 16 Aug 2016, Binyamin Sharet wrote: > Kernel version: raspberrypi 4.4.6-v7+ #871 > Driver source file: drivers/net/usb/kaweth.c > Umap2 command line: umap2vsscan -P -s 0557:2002 > > After connecting such a device, NULL pointer dereference in the kernel > and USB stops responding. > >

Re: Potential vulnerabilities in USB host stack/drivers

2016-08-16 Thread Greg KH
On Tue, Aug 16, 2016 at 04:40:43PM +0300, Binyamin Sharet wrote: > Hi, > > We are using Umap2 to scan USB hosts for vendor-specific device support. > e.g. whether appropriate drivers are loaded when a device with a specific > VID/PID is inserted. > > In our configuration, we connect multiple

Re: [Umap2][1/11][0aa8:8001] USB stack hang

2016-08-16 Thread Greg KH
On Tue, Aug 16, 2016 at 04:42:23PM +0300, Binyamin Sharet wrote: > Kernel version: raspberrypi 4.4.6-v7+ #871 > Kernel version: 4.4.0-24-generic #43-Ubuntu SMP > Driver source file: drivers/staging/media/lirc/lirc_imon.c > Umap2 command line: umap2vsscan -P -s 0aa8:8001 > > After connecting such

[PATCH v11 5/5] usb: dwc3: rockchip: add devicetree bindings documentation

2016-08-16 Thread William Wu
This patch adds the devicetree documentation required for Rockchip USB3.0 core wrapper consisting of USB3.0 IP from Synopsys. It supports DRD mode, and could operate in device mode (SS, HS, FS) and host mode (SS, HS, FS, LS). Signed-off-by: William Wu Acked-by: Rob

Re: [Umap2][9/11][05c5:0002] NULL pointer dereference

2016-08-16 Thread Alan Stern
On Tue, 16 Aug 2016, Binyamin Sharet wrote: > Kernel version: raspberrypi 4.4.6-v7+ #871 > Driver source file: drivers/usb/serial/digi_acceleport.c > Umap2 command line: umap2vsscan -P -s 05c5:0002 > > After connecting such a device, NULL pointer dereference in the kernel. > > Binyamin Sharet

[PATCH v11 0/5] support rockchip dwc3 driver

2016-08-16 Thread William Wu
This series add support for rockchip DWC3 driver, and add additional optional properties for specific platforms (e.g., rockchip rk3399 platform). The DesignWare USB3 integrated in rockchip SoCs is a configurable IP Core which can be instantiated as Dual-Role Device (DRD), Host Only (XHCI) and

[PATCH v11 2/5] usb: dwc3: add dis_u2_freeclk_exists_quirk

2016-08-16 Thread William Wu
Add a quirk to clear the GUSB2PHYCFG.U2_FREECLK_EXISTS bit, which specifies whether the USB2.0 PHY provides a free-running PHY clock, which is active when the clock control input is active. Signed-off-by: William Wu Acked-by: Rob Herring --- Changes

[PATCH v11 4/5] usb: dwc3: add dis_del_phy_power_chg_quirk

2016-08-16 Thread William Wu
Add a quirk to clear the GUSB3PIPECTL.DELAYP1TRANS bit, which specifies whether disable delay PHY power change from P0 to P1/P2/P3 when link state changing from U0 to U1/U2/U3 respectively. Signed-off-by: William Wu Acked-by: Rob Herring --- Changes

[PATCH v11 3/5] usb: dwc3: make usb2 phy utmi interface configurable

2016-08-16 Thread William Wu
Support to configure the UTMI+ PHY with an 8- or 16-bit interface via DT. The UTMI+ PHY interface is a hardware capability, and it's platform dependent. Normally, the PHYIF can be configured during coreconsultant. But for some specific USB cores(e.g. rk3399 SoC DWC3), the default PHYIF

[PATCH v11 1/5] usb: dwc3: of-simple: add compatible for rockchip rk3399

2016-08-16 Thread William Wu
Rockchip platform merely enable usb3 clocks and populate its children. So we can use this generic glue layer to support Rockchip dwc3. Signed-off-by: William Wu --- Changes in v11: - add compatible in dwc3-of-simple.c, and remove dwc3-rockchip.c (balbi) Changes in

Re: [Umap2][3/11][0471:0602] NULL pointer dereference

2016-08-16 Thread Alan Stern
On Tue, 16 Aug 2016, Binyamin Sharet wrote: > Kernel version: raspberrypi 4.4.6-v7+ #871 > Driver source file: drivers/input/misc/ati_remote2.c > Umap2 command line: umap2vsscan -P -s 0471:0602 > > After connecting such a device, NULL pointer dereference in the kernel > and USB stops

Re: [Umap2][1/11][0aa8:8001] USB stack hang

2016-08-16 Thread Greg KH
On Tue, Aug 16, 2016 at 04:42:23PM +0300, Binyamin Sharet wrote: > Kernel version: raspberrypi 4.4.6-v7+ #871 > Kernel version: 4.4.0-24-generic #43-Ubuntu SMP That's really old (like 30,000+ patches ago.) And we have no idea what's in a ubuntu kernel image, do you ? Can you test these on

Re: musb: am3358: having problem with high-speed on usb1 at peripheral

2016-08-16 Thread ayaka
On 08/16/2016 04:31 PM, Felipe Balbi wrote: Hi, Ayaka writes: ayaka writes: On 08/13/2016 01:44 AM, Greg KH wrote: On Sat, Aug 13, 2016 at 12:38:46AM +0800, ayaka wrote: On 08/12/2016 03:40 PM, Greg KH wrote: On Fri, Aug 12, 2016 at 10:23:15AM

[Umap2][11/11][9022:d483] kernel is unable to handle paging address

2016-08-16 Thread Binyamin Sharet
Kernel version: raspberrypi 4.4.6-v7+ #871 Driver source file: drivers/media/usb/dvb-usb/dw2102.c Umap2 command line: umap2vsscan -P -s 9022:d483 After connecting such a device, kernel oops: kernel is unable to handle paging address. Also happens with 9022:d484. Binyamin Sharet Cisco, STARE-C

[Umap2][10/11][1a0a:0102] USB host stops communicating

2016-08-16 Thread Binyamin Sharet
Kernel version: raspberrypi 4.4.6-v7+ #871 Umap2 command line: umap2vsscan -P -s 1a0a:0102 After connecting such a device, the USB host stops communicating. >From dmesg: [ 5924.751650] usb 1-1.4: new high-speed USB device number 103 using dwc_otg [ 5924.866112] usb 1-1.4: New USB device found,

[Umap2][9/11][05c5:0002] NULL pointer dereference

2016-08-16 Thread Binyamin Sharet
Kernel version: raspberrypi 4.4.6-v7+ #871 Driver source file: drivers/usb/serial/digi_acceleport.c Umap2 command line: umap2vsscan -P -s 05c5:0002 After connecting such a device, NULL pointer dereference in the kernel. Binyamin Sharet Cisco, STARE-C << Attached: 05c5_0002_dmesg.log >> [

[Umap2][2/11][10cf:5500] NULL pointer dereference

2016-08-16 Thread Binyamin Sharet
Kernel version: 4.4.0-24-generic #43-Ubuntu SMP Driver source file: drivers/staging/comedi/drivers/vmk80xx.c Umap2 command line: umap2vsscan -P -s 10cf:5500 After connecting such a device, there's oops due to NULL pointer dereference. Binyamin Sharet Cisco, STARE-C << Attached:

[Umap2][8/11][076d:0006] NULL pointer dereference

2016-08-16 Thread Binyamin Sharet
Kernel version: raspberrypi 4.4.6-v7+ #871 Driver source file: drivers/staging/vt6656/main_usb.c Umap2 command line: umap2vsscan -P -s 076d:0006 After connecting such a device, NULL pointer dereference in the kernel. Binyamin Sharet Cisco, STARE-C << Attached: 076d_0006_dmesg.log >> [

[Umap2][3/11][0471:0602] NULL pointer dereference

2016-08-16 Thread Binyamin Sharet
Kernel version: raspberrypi 4.4.6-v7+ #871 Driver source file: drivers/input/misc/ati_remote2.c Umap2 command line: umap2vsscan -P -s 0471:0602 After connecting such a device, NULL pointer dereference in the kernel and USB stops responding. Binyamin Sharet Cisco, STARE-C << Attached:

[Umap2][7/11][160a:3184] NULL pointer dereference

2016-08-16 Thread Binyamin Sharet
Kernel version: raspberrypi 4.4.6-v7+ #871 Driver source file: drivers/staging/vt6656/main_usb.c Related file: drivers/staging/comedi/drivers/usbduxsigma.c Umap2 command line: umap2vsscan -P -s 160a:3184 After connecting such a device, NULL pointer dereference in the kernel. You may need to

Re: [PATCH v2 4/7] phy-sun4i-usb: Add support for phy_set_mode

2016-08-16 Thread Sergei Shtylyov
Hello. On 08/15/2016 10:21 PM, Hans de Goede wrote: Together with some musb sunxi glue changes this allows run-time dr_mode switching support via the "mode" musb sysfs attribute. Signed-off-by: Hans de Goede --- drivers/phy/phy-sun4i-usb.c | 24

[Umap2][1/11][0aa8:8001] USB stack hang

2016-08-16 Thread Binyamin Sharet
Kernel version: raspberrypi 4.4.6-v7+ #871 Kernel version: 4.4.0-24-generic #43-Ubuntu SMP Driver source file: drivers/staging/media/lirc/lirc_imon.c Umap2 command line: umap2vsscan -P -s 0aa8:8001 After connecting such a device, the host usb stack became unresponsive. Please see attached dmesg

Potential vulnerabilities in USB host stack/drivers

2016-08-16 Thread Binyamin Sharet
Hi, We are using Umap2 to scan USB hosts for vendor-specific device support. e.g. whether appropriate drivers are loaded when a device with a specific VID/PID is inserted. In our configuration, we connect multiple times to the host, each time providing different VID/PID in the device descriptor,

[Umap2][4/11][0557:2002] NULL pointer dereference

2016-08-16 Thread Binyamin Sharet
Kernel version: raspberrypi 4.4.6-v7+ #871 Driver source file: drivers/net/usb/kaweth.c Umap2 command line: umap2vsscan -P -s 0557:2002 After connecting such a device, NULL pointer dereference in the kernel and USB stops responding. This issue was reproduced with other VID/PIDs that use this

[Umap2][5/11][22b8:2d93] NULL pointer dereference

2016-08-16 Thread Binyamin Sharet
Kernel version: raspberrypi 4.4.6-v7+ #871 Driver source file: drivers/usb/class/cdc-acm.c Umap2 command line: umap2vsscan -P -s 22b8:2d93 After connecting such a device, NULL pointer dereference in the kernel and USB stops responding. Binyamin Sharet Cisco, STARE-C << Attached:

[PATCH] cdc-wdm: add terminating newline

2016-08-16 Thread Oliver Neukum
Debug messages should be properly terminated. Signed-off-by: Oliver Neukum --- drivers/usb/class/cdc-wdm.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c index

Re: Gadgetfs - adding support for delegation of setup requests

2016-08-16 Thread Greg KH
On Tue, Aug 16, 2016 at 03:20:41PM +0300, Binyamin Sharet wrote: > Many USB host implementations, including at least older versions of Linux, We can't go back in time and fix code, sorry :) > have bugs in the enumeration phase. While I cannot pinpoint a ToC/ToU > vulnerability in the

Re: How can I tell who created my usb0 network device?

2016-08-16 Thread Patrick Doyle
Hello balbi , Thank you for your reply. Yes, my system is an Edison board. It is embedded in a larger system and is hardwired to a hub which is hardwired to another (custom) embedded board based on an Atmel SAMA5 device. I had been trying (and finally succeeded) to convince the two boards to

[PATCH] scsi: introduce a quirk for false cache reporting

2016-08-16 Thread Oliver Neukum
Some SATA to USB bridges fail to cooperate with some drives resulting in no cache being present being reported to the host. That causes the host to skip sending a command to synchronize caches. That causes data loss when the drive is powered down. Signed-off-by: Oliver Neukum

Re: [PATCH v10 5/5] usb: dwc3: add rockchip specific glue layer

2016-08-16 Thread Felipe Balbi
Hi, "William.wu" writes: >> "William.wu" writes: William Wu writes: > Add rockchip specific glue layer to support USB3 Peripheral mode > and Host mode on rockchip platforms (e.g. rk3399). > >

Re: [PATCH v10 5/5] usb: dwc3: add rockchip specific glue layer

2016-08-16 Thread William.wu
Dear Balbi, On 2016/8/16 18:43, Felipe Balbi wrote: Hi, "William.wu" writes: William Wu writes: Add rockchip specific glue layer to support USB3 Peripheral mode and Host mode on rockchip platforms (e.g. rk3399). The DesignWare USB3

[PATCH v2] usb: chipidea: udc: don't touch DP when controller is in host mode

2016-08-16 Thread Li Jun
When the controller is configured to be dual role and it's in host mode, if bind udc and gadgt driver, those gadget operations will do gadget disconnect and finally pull down DP line, which will break host function. Cc: # 4.1+ Signed-off-by: Li Jun ---

Re: [PATCH 2/2] usb: gadget: f_ncm: add support for scatter/gather SKB to enable GSO

2016-08-16 Thread Felipe Balbi
Hi again, Felipe Balbi writes: Enabling SG allows enabling GSO (generic segmentation offload) feature of linux networking layer. This increases TCP throughput with NCM on Cortex-A15+USB3380 based device from 300 Mbit/s to 1.1 Gbit/s. Signed-off-by:

Re: [PATCH 1/1] usb: Kconfig: move ulpi bus support out of host

2016-08-16 Thread Heikki Krogerus
On Tue, Aug 16, 2016 at 05:33:25PM +0800, Peter Chen wrote: > The ULPI bus is not only for host, but for device mode too, so move > it out from host's Kconfig. > > Cc: Heikki Krogerus Acked-by: Heikki Krogerus Thanks, --

Re: [PATCH v2 08/10] usb: ulpi: remove "dev" field from struct ulpi_ops

2016-08-16 Thread Heikki Krogerus
On Mon, Aug 01, 2016 at 09:15:56PM +0300, Tal Shorer wrote: > /** > * struct ulpi_ops - ULPI register access > @@ -12,7 +13,6 @@ struct ulpi; > * @write: write operation for ULPI register access > */ > struct ulpi_ops { > - struct device *dev; Fix also the comment above (remove the

Re: [PATCH 2/2] usb: gadget: f_ncm: add support for scatter/gather SKB to enable GSO

2016-08-16 Thread Felipe Balbi
Hi Jussi, Jussi Kivilinna writes: >> Jussi Kivilinna writes: >>> Enabling SG allows enabling GSO (generic segmentation offload) feature >>> of linux networking layer. This increases TCP throughput with NCM >>> on Cortex-A15+USB3380

Re: [PATCH v2 06/10] usb: ulpi: remove old api callbacks from struct ulpi_ops

2016-08-16 Thread Heikki Krogerus
On Mon, Aug 01, 2016 at 09:15:54PM +0300, Tal Shorer wrote: > The old api callbacks, read() and write(), are not referenced anywhere. > Remove them. > > Signed-off-by: Tal Shorer > --- > include/linux/ulpi/interface.h | 2 -- > 1 file changed, 2 deletions(-) > > diff

Re: [PATCH v2 03/10] usb: ulpi: use new api functions if available

2016-08-16 Thread Heikki Krogerus
Hi, On Mon, Aug 01, 2016 at 09:15:51PM +0300, Tal Shorer wrote: > If the registered has the new api callbacks {read|write}_dev, call > these instead of the deprecated read, write functions. If the > registered does not support the new callbacks, revert to calling the > old ones as before. > >

Re: Gadgetfs - adding support for delegation of setup requests

2016-08-16 Thread Felipe Balbi
Hi, Binyamin Sharet writes: >>> 2. At least in my case, where I wan't to use gadgetfs for fuzzing >>> other USB hosts, I >>> can't really fuzz various stages of the enumeration phase, >>> specifically in the case of >>> descriptors that are usually requested at least twice

Re: [PATCH 2/2] usb: gadget: f_ncm: add support for scatter/gather SKB to enable GSO

2016-08-16 Thread Jussi Kivilinna
Hello, 16.08.2016, 10:41, Felipe Balbi kirjoitti: > > Hi, > > Jussi Kivilinna writes: >> Enabling SG allows enabling GSO (generic segmentation offload) feature >> of linux networking layer. This increases TCP throughput with NCM >> on Cortex-A15+USB3380 based

Re: [PATCH v10 5/5] usb: dwc3: add rockchip specific glue layer

2016-08-16 Thread Felipe Balbi
Hi, "William.wu" writes: >> William Wu writes: >>> Add rockchip specific glue layer to support USB3 Peripheral mode >>> and Host mode on rockchip platforms (e.g. rk3399). >>> >>> The DesignWare USB3 integrated in rockchip SoCs is a

Re: Gadgetfs - adding support for delegation of setup requests

2016-08-16 Thread Greg KH
On Tue, Aug 16, 2016 at 12:37:07PM +0300, Binyamin Sharet wrote: > Hi, > > On Tue, Aug 16, 2016 at 11:36 AM, Felipe Balbi > wrote: > > > > Hi, > > > > Binyamin Sharet writes: > >>> Alan Stern writes: > > I'm

Re: [PATCH] scsi: introduce a quirk for false cache reporting

2016-08-16 Thread Oliver Neukum
On Tue, 2016-08-16 at 00:44 -0400, Martin K. Petersen wrote: > > "Oliver" == Oliver Neukum writes: > > Oliver, > > Oliver> wce_default_on controls the default if the device provides no > Oliver> indication. The problem here is that the indication the device > Oliver>

Re: [PATCH v10 5/5] usb: dwc3: add rockchip specific glue layer

2016-08-16 Thread William.wu
Dear Balbi, On 2016/8/16 15:19, Felipe Balbi wrote: Hi, William Wu writes: Add rockchip specific glue layer to support USB3 Peripheral mode and Host mode on rockchip platforms (e.g. rk3399). The DesignWare USB3 integrated in rockchip SoCs is a configurable IP

Re: [PATCH v2 0/3] USB Audio Gadget refactoring

2016-08-16 Thread Clemens Ladisch
Peter Chen wrote: > On Tue, Aug 16, 2016 at 11:32:55AM +0200, Clemens Ladisch wrote: >> Windows does not have UAC2 support. > > Thanks, before windows7 or all windows versions have no UAC2 support? So far, no version has it. Regards, Clemens -- To unsubscribe from this list: send the line

Re: [PATCH v2 0/3] USB Audio Gadget refactoring

2016-08-16 Thread Peter Chen
On Tue, Aug 16, 2016 at 11:32:55AM +0200, Clemens Ladisch wrote: > Peter Chen wrote: > > I find UAC2 (UAC1 is ok) support is not well with the latest mainline > > kernel w/o your patch set. The windows7 can't install the driver > > successfully > > Windows does not have UAC2 support. > Thanks,

[PATCH 1/1] usb: Kconfig: move ulpi bus support out of host

2016-08-16 Thread Peter Chen
The ULPI bus is not only for host, but for device mode too, so move it out from host's Kconfig. Cc: Heikki Krogerus Signed-off-by: Peter Chen --- drivers/usb/Kconfig | 20 drivers/usb/core/Kconfig | 20

Re: Gadgetfs - adding support for delegation of setup requests

2016-08-16 Thread Binyamin Sharet
Hi, On Tue, Aug 16, 2016 at 11:36 AM, Felipe Balbi wrote: > > Hi, > > Binyamin Sharet writes: >>> Alan Stern writes: > I'm using GadgetFs for USB host fuzzing (using umap2), > and part of the fuzzing session

Re: [PATCH v2 0/3] USB Audio Gadget refactoring

2016-08-16 Thread Clemens Ladisch
Peter Chen wrote: > I find UAC2 (UAC1 is ok) support is not well with the latest mainline > kernel w/o your patch set. The windows7 can't install the driver > successfully Windows does not have UAC2 support. > and the playback shows underrun (using local codec) > using Linux host. > # arecord

Re: [PATCH] usb: remove redundant dependency on USB_SUPPORT

2016-08-16 Thread Masahiro Yamada
2016-08-16 16:29 GMT+09:00 Felipe Balbi : > > Hi, > > Masahiro Yamada writes: >> The whole Kconfig entries of the USB subsystem are surrounded with >> "if USB_SUPPORT" ... "endif", so CONFIG_USB_SUPPORT=y is surely met >> when these two Kconfig

Re: [PATCH v2 0/3] USB Audio Gadget refactoring

2016-08-16 Thread Peter Chen
On Sun, Aug 14, 2016 at 01:21:21AM +0300, Ruslan Bilovol wrote: > I came to this patch series when wanted to do two things: > - use UAC1 as virtual ALSA sound card on gadget side, >just like UAC2 is used so it's possible to do rate >resampling > - have both playback/capture support in

[PATCH v2] usb: dwc3: gadget: don't rely on jiffies while holding spinlock

2016-08-16 Thread Nicolas Saenz Julienne
From: Nicolas Saenz Julienne __dwc3_gadget_wakeup() is called while holding a spinlock, then depends on jiffies in order to timeout while polling the USB core for a link state update. In the case the wakeup failed, the timeout will never happen and will also cause the

RE: [PATCH v5] usb: ohci-at91: Forcibly suspend ports while USB suspend

2016-08-16 Thread Wenyou.Yang
Hi Alan, As you saw, I think the version 4 is better than this, can we take the version 4? Best Regards, Wenyou Yang > -Original Message- > From: wenyou.y...@microchip.com [mailto:wenyou.y...@microchip.com] > Sent: 2016年8月5日 11:46 > To: st...@rowland.harvard.edu; wenyou.y...@atmel.com

Re: Gadgetfs - adding support for delegation of setup requests

2016-08-16 Thread Felipe Balbi
Hi, Binyamin Sharet writes: >> Alan Stern writes: I'm using GadgetFs for USB host fuzzing (using umap2), and part of the fuzzing session is to send invalid descriptors at various stages. However, some requests are not

Re: musb: am3358: having problem with high-speed on usb1 at peripheral

2016-08-16 Thread Felipe Balbi
Hi, Ayaka writes: >> ayaka writes: On 08/13/2016 01:44 AM, Greg KH wrote: > On Sat, Aug 13, 2016 at 12:38:46AM +0800, ayaka wrote: > >> On 08/12/2016 03:40 PM, Greg KH wrote: >>> On Fri, Aug 12, 2016 at 10:23:15AM +0800, ayaka wrote:

Re: musb: am3358: having problem with high-speed on usb1 at peripheral

2016-08-16 Thread Ayaka
從我的 iPad 傳送 > Felipe Balbi 於 2016年8月16日 下午3:10 寫道: > > > Hi, > > ayaka writes: >>> On 08/13/2016 01:44 AM, Greg KH wrote: On Sat, Aug 13, 2016 at 12:38:46AM +0800, ayaka wrote: > On 08/12/2016 03:40 PM, Greg KH wrote: >>

Re: Gadgetfs - adding support for delegation of setup requests

2016-08-16 Thread Binyamin Sharet
Hi, On Tue, Aug 16, 2016 at 10:23 AM, Felipe Balbi wrote: > > Hi, > > Alan Stern writes: >>> I'm using GadgetFs for USB host fuzzing (using umap2), >>> and part of the fuzzing session is to send invalid descriptors at >>> various stages.

Re: [PATCH 2/2] usb: gadget: f_ncm: add support for scatter/gather SKB to enable GSO

2016-08-16 Thread Felipe Balbi
Hi, Jussi Kivilinna writes: > Enabling SG allows enabling GSO (generic segmentation offload) feature > of linux networking layer. This increases TCP throughput with NCM > on Cortex-A15+USB3380 based device from 300 Mbit/s to 1.1 Gbit/s. > > Signed-off-by: Jussi

Re: [PATCH v2 1/2] usb: gadget: legacy: Add udc module param to all legacy gadgets

2016-08-16 Thread Felipe Balbi
Hi, Krzysztof Opasiak writes: > Add new module parameter called "udc" to all legacy gadgets. > By using this parameter user can choose a controller towhich > this gadget should be bound. we've added configfs exactly so we can bind gadgets to specific UDCs. Sorry, I'm not

Re: [PATCHv4 0/2] USB Type-C Connector class

2016-08-16 Thread Heikki Krogerus
Hi guys, Sorry for the long silence. I just returned from paternal leave. On Wed, Aug 10, 2016 at 10:19:25AM +0200, Oliver Neukum wrote: > On Tue, 2016-08-09 at 09:23 -0700, Guenter Roeck wrote: > > > I'm not going to take this series until everyone agrees on it, > > sorry. > > > I'll wait for

Re: [PATCH 2/2] usb: Kconfig: move ulpi bus to common

2016-08-16 Thread Heikki Krogerus
On Tue, Aug 16, 2016 at 09:14:41AM +0800, Peter Chen wrote: > > Once you resend, please re-add the dependency once you move the config > > to drivers/usb/common/Kconfig. > > > > But Greg doesn't agree with move configurations from drivers/usb/Kconfig to > drivers/usb/common/Kconfig, I move it

Re: [PATCH] usb: remove redundant dependency on USB_SUPPORT

2016-08-16 Thread Felipe Balbi
Hi, Masahiro Yamada writes: > The whole Kconfig entries of the USB subsystem are surrounded with > "if USB_SUPPORT" ... "endif", so CONFIG_USB_SUPPORT=y is surely met > when these two Kconfig options are visible. > > Signed-off-by: Masahiro Yamada

Re: Gadgetfs - adding support for delegation of setup requests

2016-08-16 Thread Felipe Balbi
Hi, Alan Stern writes: >> I'm using GadgetFs for USB host fuzzing (using umap2), >> and part of the fuzzing session is to send invalid descriptors at >> various stages. >> >> However, some requests are not delegated to user-land (see gadgetfs_setup() >> in

Re: [PATCH v10 5/5] usb: dwc3: add rockchip specific glue layer

2016-08-16 Thread Felipe Balbi
Hi, William Wu writes: > Add rockchip specific glue layer to support USB3 Peripheral mode > and Host mode on rockchip platforms (e.g. rk3399). > > The DesignWare USB3 integrated in rockchip SoCs is a configurable > IP Core which can be instantiated as Dual-Role Device

  1   2   >