Re: [PATCH] usb-storage: block runtime suspend when the host is added

2016-09-21 Thread Greg KH
On Wed, Sep 21, 2016 at 01:07:55PM -0400, Alan Stern wrote: > On Wed, 21 Sep 2016, Greg KH wrote: > > > On Wed, Sep 21, 2016 at 11:25:37AM -0400, Alan Stern wrote: > > > A warning message that was recently added to the PM core has alerted > > > us to a potential problem in usb-storage. Although

Re: [PATCH 2/2] musb: sunxi: Force session end on babble errors in host-mode

2016-09-21 Thread Bin Liu
Hi, On Sun, Sep 18, 2016 at 06:50:18PM +0200, Hans de Goede wrote: > The sunxi musb has a bug where sometimes it will generate a babble > error on device disconnect instead of a disconnect irq. When this > happens the musb-controller switches from host mode to device mode > (it clears

Re: [PATCH 1/2] phy-sun4i-usb: Add sun4i_usb_phy_force_session_end() function

2016-09-21 Thread Bin Liu
Hi, On Wed, Sep 21, 2016 at 11:05:33AM +0300, Hans de Goede wrote: > Hi, > > On 09/20/2016 07:45 AM, Kishon Vijay Abraham I wrote: > >Hi, > > > >On Sunday 18 September 2016 10:20 PM, Hans de Goede wrote: > >>The sunxi musb has a bug where sometimes it will generate a babble > >>error on device

[PATCH] usb: dwc2: add USBTrdTim to initial value

2016-09-21 Thread Pengcheng Li
After dwc2_core_reset,register is to the initial value, and the USBTrdTim vale is 0x5. If hsotg->phyif = GUSBCFG_PHYIF8, after the dwc2_writel,the value is 0xd.So we need to set the USBTrdTim to 0. Signed-off-by: Pengcheng Li --- drivers/usb/dwc2/gadget.c | 4 ++-- 1 file

Re: [PATCH v2] musb: Export musb_root_disconnect for use in modules

2016-09-21 Thread Bin Liu
Hi, On Sat, Sep 17, 2016 at 12:08:10PM +0200, Hans de Goede wrote: > Export musb_root_disconnect for use in modules, so that musb glue > code build as module can use it. > > This fixes the buildbot errors for -next in arm64-allmodconfig > and arm-allmodconfig. > > Fixes: 7cba17ec9adc8cf ("musb:

Re: [PATCH] usb: musb: fix error handling message in probe

2016-09-21 Thread Bin Liu
Hi, On Sat, Sep 17, 2016 at 12:21:25AM +0200, Arnd Bergmann wrote: > We print an error message when platform_device_register_full() > fails, but the initialization of the argument has been removed, > as shown in this warning: > > drivers/usb/musb/da8xx.c: In function 'da8xx_probe': >

Re: [PATCH] usb-storage: block runtime suspend when the host is added

2016-09-21 Thread Carsten Mattner
On Wed, Sep 21, 2016 at 7:07 PM, Alan Stern wrote: > On Wed, 21 Sep 2016, Greg KH wrote: > > > On Wed, Sep 21, 2016 at 11:25:37AM -0400, Alan Stern wrote: > > > A warning message that was recently added to the PM core has alerted > > > us to a potential problem in

Re: 4.8-rc: runtime PM trying to activate child device host6 but parent (2-1.2:1.0) is not active

2016-09-21 Thread Carsten Mattner
On Wed, Sep 21, 2016 at 5:23 PM, Alan Stern wrote: > On Tue, 20 Sep 2016, Carsten Mattner wrote: > >> On Tue, Sep 20, 2016 at 9:49 PM, Alan Stern >> wrote: >> > On Tue, 20 Sep 2016, Carsten Mattner wrote: >> > >> > > On Tue, Sep 20, 2016 at

Re: [PATCH 0/2] Few PM fixes for MUSB for v4.9 merge window

2016-09-21 Thread Bin Liu
Hi, On Thu, Sep 15, 2016 at 09:29:12AM -0700, Tony Lindgren wrote: > Hi, > > I noticed few corner cases we're not handling properly with the > musb hardware session bit based PM runtime heading for v4.9. > > Probably the disconnect after unconfigure PM issue has always > been there, but fixing

Re: [Umap2][7/11][160a:3184] NULL pointer dereference

2016-09-21 Thread Malcolm Priestley
On 21/09/16 17:44, Greg KH wrote: On Wed, Sep 21, 2016 at 06:34:03PM +0200, Oliver Neukum wrote: On Thu, 2016-08-18 at 13:50 +0300, Binyamin Sharet wrote: On 08/18/2016 01:31 PM, Oliver Neukum wrote: On Wed, 2016-08-17 at 14:34 +0300, Binyamin Sharet wrote: After connecting such a device,

Re: [PATCH v2 2/6] Documentation: dt-bindings: Add documentation for the Meson USB2 PHYs

2016-09-21 Thread Kevin Hilman
Rob Herring writes: > On Sun, Sep 11, 2016 at 03:41:07PM +0200, Martin Blumenstingl wrote: >> Add the documentation for the bindings for the Meson8b and GXBB USB2 >> PHYs. >> >> Signed-off-by: Martin Blumenstingl >> --- >>

Re: XHCI: USB 2.0 device unresponsive on 3.0 controller

2016-09-21 Thread Ben
As an update on information! It happens with my mouse too, very seldom, but sometimes. There are not as many consecutive inputs from a user that can really get messed up on a USB 2.0 drives, but when I get home from work today I can try that and see if the file transfer stays intact. I will

Re: [PATCH] usb: xhci: Fix the patch inherit dma configuration from

2016-09-21 Thread kbuild test robot
Hi Sriram, [auto build test ERROR on usb/usb-testing] [also build test ERROR on v4.8-rc7 next-20160921] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience) to rec

[peter.chen-usb:peter-usb-dev 45/57] drivers/usb/Kconfig:39:error: recursive dependency detected!

2016-09-21 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git peter-usb-dev head: 559e1f160d721bd3e1c2311096d463176c67877f commit: 60b2ae6dc9900dc67801db287fa7fc757922d5aa [45/57] usb: chipidea: msm: Add reset controller for PHY POR bit config: avr32-atngw100_defconfig (attached

Re: [PATCH] usb-storage: block runtime suspend when the host is added

2016-09-21 Thread Alan Stern
On Wed, 21 Sep 2016, Greg KH wrote: > On Wed, Sep 21, 2016 at 11:25:37AM -0400, Alan Stern wrote: > > A warning message that was recently added to the PM core has alerted > > us to a potential problem in usb-storage. Although the USB interface > > is in the runtime active state when the probe

Re: [Umap2][7/11][160a:3184] NULL pointer dereference

2016-09-21 Thread Greg KH
On Wed, Sep 21, 2016 at 06:34:03PM +0200, Oliver Neukum wrote: > On Thu, 2016-08-18 at 13:50 +0300, Binyamin Sharet wrote: > > On 08/18/2016 01:31 PM, Oliver Neukum wrote: > > > On Wed, 2016-08-17 at 14:34 +0300, Binyamin Sharet wrote: > > >>> After connecting such a device, NULL pointer

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-09-21 Thread Wim Osterholt
On Wed, Sep 21, 2016 at 02:21:17PM +0200, Oliver Neukum wrote: > in sysfs. Google pointed me to /sys/bus/usb/drivers/usb/* where I find all kinds of 'bConfigurationValue'. Now is the problem to find which one you could mean. Under /sys/bus/usb/drivers/usb/7-1 I find manufacturer which reads

Re: [Umap2][7/11][160a:3184] NULL pointer dereference

2016-09-21 Thread Oliver Neukum
On Thu, 2016-08-18 at 13:50 +0300, Binyamin Sharet wrote: > On 08/18/2016 01:31 PM, Oliver Neukum wrote: > > On Wed, 2016-08-17 at 14:34 +0300, Binyamin Sharet wrote: > >>> After connecting such a device, NULL pointer dereference in the > >> kernel. > >>> You may need to connect another device or

Re: [PATCH] usb-storage: block runtime suspend when the host is added

2016-09-21 Thread Greg KH
On Wed, Sep 21, 2016 at 11:25:37AM -0400, Alan Stern wrote: > A warning message that was recently added to the PM core has alerted > us to a potential problem in usb-storage. Although the USB interface > is in the runtime active state when the probe routine starts, until > the runtime-PM usage

Re: [PATCH] usb: misc: legousbtower: Fix NULL pointer deference

2016-09-21 Thread Greg KH
On Mon, Sep 19, 2016 at 07:09:51PM +0100, James wrote: > From: Greg Kroah-Hartman > > This patch fixes a NULL pointer dereference caused by a race codition in the > probe function of the legousbtower driver. It re-structures the probe > function to only register the

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-09-21 Thread Wim Osterholt
On Wed, Sep 21, 2016 at 02:21:17PM +0200, Oliver Neukum wrote: > On Tue, 2016-09-20 at 17:45 +0200, Wim Osterholt wrote: > > Anyway, which of its configurations is used? > Please look up the bConfigurationValue for your device > in sysfs. And what might that be? 'locate sysfs' gives one hit at

[PATCH] USB: bcma: drop Northstar PHY 2.0 initialization code

2016-09-21 Thread Rafał Miłecki
From: Rafał Miłecki This driver should initialize controller only, PHY initialization should be handled by separated PHY driver. We already have phy-bcm-ns-usb2 in place so let it makes its duty. Signed-off-by: Rafał Miłecki --- drivers/usb/host/bcma-hcd.c

[PATCH] usb-storage: block runtime suspend when the host is added

2016-09-21 Thread Alan Stern
A warning message that was recently added to the PM core has alerted us to a potential problem in usb-storage. Although the USB interface is in the runtime active state when the probe routine starts, until the runtime-PM usage count is incremented nothing forces it to remain active. The

Re: 4.8-rc: runtime PM trying to activate child device host6 but parent (2-1.2:1.0) is not active

2016-09-21 Thread Alan Stern
On Tue, 20 Sep 2016, Carsten Mattner wrote: > On Tue, Sep 20, 2016 at 9:49 PM, Alan Stern wrote: > > On Tue, 20 Sep 2016, Carsten Mattner wrote: > > > > > On Tue, Sep 20, 2016 at 5:41 PM, Alan Stern > > > wrote: > > > > > > > I suspect the

RE: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-21 Thread Sriram Dash
>From: Arnd Bergmann [mailto:a...@arndb.de] >On Wednesday, September 21, 2016 11:06:47 AM CEST Sriram Dash wrote: >> >> Hello Arnd, >> >> We tried this patch on NXP platforms (ls2085 and ls1043) which use >> dwc3 controller without any glue layer. On first go, this did not >> work. But after

Re: VL805 USB 3.0 does not see connected devices (only on x86_64) (x86 is ok)

2016-09-21 Thread c400
02:00.0 USB controller: VIA Technologies, Inc. VL805 USB 3.0 Host Controller (rev 01) (prog-if 30 [XHCI]) Subsystem: VIA Technologies, Inc. VL805 USB 3.0 Host Controller Flags: bus master, fast devsel, latency 0, IRQ 41 Memory at fbb0 (64-bit, non-prefetchable)

Re: g_webcam Isoch high bandwidth transfer

2016-09-21 Thread Bin Liu
On Wed, Sep 21, 2016 at 08:27:02AM -0500, Bin Liu wrote: > On Wed, Sep 21, 2016 at 11:01:21AM +0300, Felipe Balbi wrote: > > > > Hi, > > > > Bin Liu writes: > > > Hi, > > > > > > I am trying to check Isoch high bandwidth transfer with g_webcam.ko in > > > high-speed connection. >

Re: VL805 USB 3.0 does not see connected devices (only on x86_64) (x86 is ok)

2016-09-21 Thread Alan Stern
On Wed, 21 Sep 2016, c400 wrote: > >Maybe you can put the quirk in /etc/modprobe.d so it will be used > >automatically. Add a line to /etc/modprobe.d/local.conf saying: > > >options xhci_hcd quirks=0x00800090 > > i`ve done and it works Congratulations! Can you post the "lspci -v

Re: [PATCH] mmc: rtsx_usb_sdmmc: Handle runtime PM while changing led

2016-09-21 Thread Alan Stern
On Wed, 21 Sep 2016, Ulf Hansson wrote: > > > My concern is also 2s autosuspend timeout which is set for the usb > > > device. Somehow I feel we need to be able "share" more information > > > between a parent-child relationship, in this case between the sdmmc > > > device and the usb device. > >

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

2016-09-21 Thread Alan Stern
On Wed, 21 Sep 2016, Ritesh Raj Sarraf wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Hi Alan, > > On Tue, 2016-09-20 at 10:16 -0400, Alan Stern wrote: > > This is a lot better.  No more I/O errors. > > > > We still have irregular suspends and resumes, but that's to be  > >

Re: [PATCH] mmc: rtsx_usb_sdmmc: Handle runtime PM while changing led

2016-09-21 Thread Alan Stern
On Wed, 21 Sep 2016, Oliver Neukum wrote: > On Tue, 2016-09-20 at 10:12 -0400, Alan Stern wrote: > > On Tue, 20 Sep 2016, Oliver Neukum wrote: > > > That shouldn't be an issue in this case, at least, not with the current > > code. The sdmmc and memstick drivers block autosuspend if media is >

Re: XHCI: USB 2.0 device unresponsive on 3.0 controller

2016-09-21 Thread Greg KH
On Wed, Sep 21, 2016 at 08:19:54AM -0500, Ben wrote: > Good afternoon everyone, > > My coolermaster Quickfire Rapid keyboard (ID: 2516:0004) has been acting up > since I installed arch linux for the first time last week. System overview in > attachment. > > Bios is set for EHCI hand-off:

Re: g_webcam Isoch high bandwidth transfer

2016-09-21 Thread Bin Liu
On Wed, Sep 21, 2016 at 11:01:21AM +0300, Felipe Balbi wrote: > > Hi, > > Bin Liu writes: > > Hi, > > > > I am trying to check Isoch high bandwidth transfer with g_webcam.ko in > > high-speed connection. > > > > First I hacked webcam.c as follows to enable 640x480@30fps mode. > >

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-21 Thread Arnd Bergmann
On Wednesday, September 21, 2016 11:43:59 AM CEST Sriram Dash wrote: > >From: Arnd Bergmann [mailto:a...@arndb.de] > >On Wednesday, September 21, 2016 11:06:47 AM CEST Sriram Dash wrote: > > == > From

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-09-21 Thread Oliver Neukum
On Tue, 2016-09-20 at 17:45 +0200, Wim Osterholt wrote: > On Tue, Sep 20, 2016 at 03:05:14PM +0200, Oliver Neukum wrote: > > > > I cannot replicate it. Could you please provide "lsusb -v"? > > > > Regards > > Oliver > > It concerns these type of modems: >

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

2016-09-21 Thread Ritesh Raj Sarraf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello Ulf, On Wed, 2016-09-21 at 13:17 +0200, Ulf Hansson wrote: > > I am pretty sure the memstick driver causes additional access to the > usb device without first calling pm_runtime_get_sync(). To eliminate > those cases from causing the issues,

RE: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-21 Thread Sriram Dash
>From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] >On Wednesday, September 7, 2016 1:24:07 PM CEST Felipe Balbi wrote: >> >> Hi, >> >> Arnd Bergmann writes: >> >> [...] >> >> > Regarding the DMA configuration that you mention in >> >

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-21 Thread Arnd Bergmann
On Wednesday, September 21, 2016 11:06:47 AM CEST Sriram Dash wrote: > > Hello Arnd, > > We tried this patch on NXP platforms (ls2085 and ls1043) which use dwc3 > controller without any glue layer. On first go, this did not work. But after > minimal reworks mention snippet below, we are able to

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

2016-09-21 Thread Ulf Hansson
On 21 September 2016 at 13:10, Ritesh Raj Sarraf wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Hi Alan, > > On Tue, 2016-09-20 at 10:16 -0400, Alan Stern wrote: >> This is a lot better. No more I/O errors. >> >> We still have irregular suspends and resumes,

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

2016-09-21 Thread Ritesh Raj Sarraf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi Alan, On Tue, 2016-09-20 at 10:16 -0400, Alan Stern wrote: > This is a lot better.  No more I/O errors. > > We still have irregular suspends and resumes, but that's to be  > expected.  More worrying are the spontaneous disconnects.  They don't 

Re: [PATCH] mmc: rtsx_usb_sdmmc: Handle runtime PM while changing led

2016-09-21 Thread Ulf Hansson
On 20 September 2016 at 16:09, Alan Stern wrote: > > On Tue, 20 Sep 2016, Ulf Hansson wrote: > > > >> I am wondering what you think would be a good autosuspend timeout in > > >> this case? It seems to me that the only thing the rtsx driver really > > >> care about is to

Re: [PATCH] mmc: rtsx_usb_sdmmc: Handle runtime PM while changing led

2016-09-21 Thread Oliver Neukum
On Tue, 2016-09-20 at 10:12 -0400, Alan Stern wrote: > On Tue, 20 Sep 2016, Oliver Neukum wrote: > That shouldn't be an issue in this case, at least, not with the current > code. The sdmmc and memstick drivers block autosuspend if media is > present. Good. > > > > Which means that

[PATCH v5 1/2] usb: chipidea: imx: configure imx for ULPI phy

2016-09-21 Thread Fabien Lahoudere
In order to use ULPI phy with usb host 2 and 3, we need to configure controller register to enable ULPI features. Each USB controller have different behaviour, so in order to avoid to have several "swicth(data->index)" and lock/unlock, we prefer to get the index switch and then test for features

[PATCH v5 2/2] usb: chipidea: imx: Add binding to disable USB 60Mhz clock

2016-09-21 Thread Fabien Lahoudere
This binding allow to disable the internal 60Mhz clock for USB host2 or host3. Signed-off-by: Fabien Lahoudere --- Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 + drivers/usb/chipidea/ci_hdrc_imx.c | 2 ++

[PATCH v5 0/2] usb: chipidea: imx: Add USB configuration for imx53

2016-09-21 Thread Fabien Lahoudere
Changes in V2: - Patches sent to early with bad contents Changes in V3: - Change subject - Split "configure imx for ULPI phy" for disable-oc code Changes in V4: - Fix "Change switch order" commit message - Indent switch/case (set case on the same column as

Re: [PATCH 1/2] phy-sun4i-usb: Add sun4i_usb_phy_force_session_end() function

2016-09-21 Thread Hans de Goede
Hi, On 09/20/2016 07:45 AM, Kishon Vijay Abraham I wrote: Hi, On Sunday 18 September 2016 10:20 PM, Hans de Goede wrote: The sunxi musb has a bug where sometimes it will generate a babble error on device disconnect instead of a disconnect irq. When this happens the musb-controller switches

Re: g_webcam Isoch high bandwidth transfer

2016-09-21 Thread Felipe Balbi
Hi, Bin Liu writes: > Hi, > > I am trying to check Isoch high bandwidth transfer with g_webcam.ko in > high-speed connection. > > First I hacked webcam.c as follows to enable 640x480@30fps mode. > > diff --git a/drivers/usb/gadget/legacy/webcam.c >

Re: UAS and f_tcm -- is anyone using it?

2016-09-21 Thread Felipe Balbi
Hi, John Youn writes: Just from the code it seems there will be some fundamental issues with it, such as the value of maxpacket size and some alt-interface stuff. At least when used with DWC3. >>> >>> such as? >> >> I'll see if

Re: [PATCH v4 2/3] usb: chipidea: imx: configure imx for ULPI phy

2016-09-21 Thread Fabien Lahoudere
Hi, On 21/09/16 09:12, Peter Chen wrote: On Mon, Sep 19, 2016 at 01:45:39PM +0200, Fabien Lahoudere wrote: In order to use ULPI phy with usb host 2 and 3, we need to configure controller register to enable ULPI features. Signed-off-by: Fabien Lahoudere ---

Re: [PATCH v4 1/3] usb: chipidea: imx: Change switch order

2016-09-21 Thread Fabien Lahoudere
Hi, On 21/09/16 08:57, Peter Chen wrote: On Mon, Sep 19, 2016 at 01:45:38PM +0200, Fabien Lahoudere wrote: Each USB controller have different behaviour, so in order to avoid to have several "swicth(data->index)" and lock/unlock, we prefer to get the index switch and then test for features if

Re: [PATCH v4 3/3] usb: chipidea: imx: Add binding to disable USB 60Mhz clock

2016-09-21 Thread Peter Chen
On Mon, Sep 19, 2016 at 01:45:40PM +0200, Fabien Lahoudere wrote: > This binding allow to disable the internal 60Mhz clock for USB host2 and > host3. > > Signed-off-by: Fabien Lahoudere > --- > drivers/usb/chipidea/ci_hdrc_imx.c | 2 ++ >

Re: [PATCH v4 2/3] usb: chipidea: imx: configure imx for ULPI phy

2016-09-21 Thread Peter Chen
On Mon, Sep 19, 2016 at 01:45:39PM +0200, Fabien Lahoudere wrote: > In order to use ULPI phy with usb host 2 and 3, we need to configure > controller register to enable ULPI features. > > Signed-off-by: Fabien Lahoudere > --- >

Re: [PATCH v4 1/3] usb: chipidea: imx: Change switch order

2016-09-21 Thread Peter Chen
On Mon, Sep 19, 2016 at 01:45:38PM +0200, Fabien Lahoudere wrote: > Each USB controller have different behaviour, so in order to avoid to have > several "swicth(data->index)" and lock/unlock, we prefer to get the index > switch and then test for features if they exist for this index. > This patch

Re: [PATCH 2/2] usb: chipidea: otg: fix reading otgsc register

2016-09-21 Thread Peter Chen
On Mon, Sep 19, 2016 at 01:44:36PM +0200, Sascha Hauer wrote: > When switching from gadget to host the driver waits for VBUS It should be switching from host to gadget > to disappear before doing the actual switch. This waiting is > done by letting hw_wait_reg() poll the OTGSC register. This is

Re: [RESEND PATCH 0/4] usb: early: add support for early printk through USB3 debug port

2016-09-21 Thread Lu Baolu
Hi, On 09/20/2016 10:06 PM, Mathias Nyman wrote: > On 29.08.2016 08:26, Lu Baolu wrote: >> xHCI debug capability (DbC) is an optional but standalone >> functionality provided by an xHCI host controller. With DbC >> hardware initialized, the system will present a debug device >> through the USB3

Re: [RESEND PATCH 1/4] usb: dbc: early driver for xhci debug capability

2016-09-21 Thread Lu Baolu
Hi, On 09/20/2016 09:54 PM, Mathias Nyman wrote: > On 29.08.2016 08:26, Lu Baolu wrote: >> xHCI debug capability (DbC) is an optional but standalone >> functionality provided by an xHCI host controller. Software >> learns this capability by walking through the extended >> capability list of the