Re: [PATCH 2/2] usb: gadget: uac2: add req_number as parameter

2017-01-15 Thread Peter Chen
On Wed, Jan 04, 2017 at 10:19:23AM +0800, Peter Chen wrote: > There are only two requests for uac2, it may not be enough at high > loading system which usb interrupt handler can't be serviced on > time, then the data will be lost since it is isoc transfer for audio. > > In this patch, we

Re: [PATCH 1/2] usb: gadget: f_uac2: improve error handling

2017-01-15 Thread Peter Chen
On Wed, Jan 04, 2017 at 10:19:22AM +0800, Peter Chen wrote: > If it is out of memory, we should return -ENOMEM; > > Signed-off-by: Peter Chen > --- > drivers/usb/gadget/function/f_uac2.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH 35/37] usb: host: xhci: remove newline from tracer

2017-01-15 Thread Lu Baolu
Hi, On 12/29/2016 07:01 PM, Felipe Balbi wrote: > If we add that newline, the output will like like the following: > > kworker/2:1-42[002] 169.811435: xhci_address_ctx: > ctx_64=0, ctx_type=2, ctx_dma=@153fbd000, ctx_va=@880153fbd000 > > We would rather have that in a single

[PATCH v3] usb: gadget: udc-core: Rescan pending list on driver unbind

2017-01-15 Thread Krzysztof Opasiak
Since: commit 855ed04a3758 ("usb: gadget: udc-core: independent registration of gadgets and gadget drivers") if we load gadget module but there is no free udc available then it will be stored on a pending gadgets list. $ modprobe g_zero.ko $ modprobe g_ether.ko [] udc-core: couldn't find an

RE: [PATCH v1 1/1] usbip: auto retry for concurrent attach

2017-01-15 Thread fx IWATA NOBUO
> copy-paste in error path. Could you please fix this to use goto as only > for this single function usbip_vhci_driver_close() is called in 3 > different places. OK. I will fix in next version. Sorry for making you to wite same kind of comment, Nobuo Iwata // > -Original Message- >

Re: [PATCH 30/37] usb: host: xhci: make a generic TRB tracer

2017-01-15 Thread Lu Baolu
Hi, On 01/16/2017 03:03 PM, Felipe Balbi wrote: > Hi, > > Lu Baolu writes: >> On 12/29/2016 07:01 PM, Felipe Balbi wrote: >>> instead of having a tracer that can only trace command completions, >>> let's promote this tracer so it can trace and decode any TRB. >>> >>>

Re: [PATCH v2 RESEND] usb: gadget: udc-core: Rescan pending list on driver unbind

2017-01-15 Thread Krzysztof Opasiak
On 12/27/2016 12:18 PM, Felipe Balbi wrote: > > Hi, > > Krzysztof Opasiak writes: >> Since: >> >> commit 855ed04a3758 ("usb: gadget: udc-core: independent registration >> of gadgets and gadget drivers") >> >> if we load gadget module but there is no free udc available

Re: [PATCH V2] usb: xhci: add support for performing fake doorbell

2017-01-15 Thread Rafał Miłecki
On 21 November 2016 at 16:31, Mathias Nyman wrote: > On 21.11.2016 09:57, Rafał Miłecki wrote: >> >> Hi Mathias, >> >> On 17 October 2016 at 22:30, Rafał Miłecki wrote: >>> >>> From: Rafał Miłecki >>> >>> Broadcom's Northstar

Re: [PATCH] tools: usb usbip - update README USB/IP driver location

2017-01-15 Thread Krzysztof Opasiak
On 01/14/2017 12:38 AM, Shuah Khan wrote: > Update USB/IP driver location in README. > > Signed-off-by: Shuah Khan Reviewed-by: Krzysztof Opasiak Best regards, -- Krzysztof Opasiak Samsung R Institute Poland Samsung Electronics -- To

Re: functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-15 Thread Felipe Balbi
Hi, Vincent Pelletier writes: >> > What happens when you run your test with dummy-hcd? >> >> this is a good idea too. > > Tested (on the edison, as it was the most convenient place to build > that module and debian kernel on host does not have it), the whole > test

Re: functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-15 Thread Felipe Balbi
Hi, Vincent Pelletier writes: >> Vincent, can you compile my xhci-cleanup branch from my usb.org tree >> (see MAINTAINERS file for the URL. Hint, it's on git.kernel.org) and run >> it on your xHCI side and *also* capture tracepoints from xHCI? > > Given that the USB

Re: [PATCH 31/37] usb: host: xhci: add urb_enqueue/dequeue/giveback tracers

2017-01-15 Thread Lu Baolu
Hi, On 12/29/2016 07:01 PM, Felipe Balbi wrote: > These three new tracers will help us tie TRBs into URBs by *also* > looking into URB lifetime. I didn't see anything related to TRBs in the patch. Anything I missed? > > Signed-off-by: Felipe Balbi > --- >

Re: [PATCH 30/37] usb: host: xhci: make a generic TRB tracer

2017-01-15 Thread Felipe Balbi
Hi, Lu Baolu writes: > On 12/29/2016 07:01 PM, Felipe Balbi wrote: >> instead of having a tracer that can only trace command completions, >> let's promote this tracer so it can trace and decode any TRB. >> >> With that, it will be easier to extrapolate the lifetime of

Re: [PATCH] usb: host: xhci: plat: check hcc_params after add hcd

2017-01-15 Thread wlf
Hi Roger, 在 2017年01月13日 19:02, Roger Quadros 写道: Hi, On 13/01/17 05:18, William Wu wrote: From: William wu The commit 4ac53087d6d4 ("usb: xhci: plat: Create both HCDs before adding them") move add hcd to the end of probe, this cause hcc_params uninitiated, because

Re: [PATCH 30/37] usb: host: xhci: make a generic TRB tracer

2017-01-15 Thread Lu Baolu
Hi, On 12/29/2016 07:01 PM, Felipe Balbi wrote: > instead of having a tracer that can only trace command completions, > let's promote this tracer so it can trace and decode any TRB. > > With that, it will be easier to extrapolate the lifetime of any TRB > which might help debugging certain

Re: [PATCH v6 23/25] usb: chipidea: Pullup D+ in device mode via phy APIs

2017-01-15 Thread Peter Chen
On Fri, Jan 13, 2017 at 12:03:00PM -0800, Stephen Boyd wrote: > Quoting Peter Chen (2017-01-12 19:35:36) > > On Thu, Jan 12, 2017 at 02:49:51PM -0800, Stephen Boyd wrote: > > > > > > With the boards I have, vbus is not routed to the phy. Instead, there's > > > a vbus comparator on the PMIC where

Re: Standard USB Descriptor question

2017-01-15 Thread bruce m beach
On 1/13/17, Greg KH wrote: > On Fri, Jan 13, 2017 at 07:24:10PM -0800, bruce m beach wrote: >> Hello everybody >> >> I have been stuck for ages trying to figure out something >> in the Standard USB Descriptor during the enumeration. It >> looks like it should should

[v2 3/3] dt-bindings: Document the STM32 USB OTG DWC2 core binding

2017-01-15 Thread Bruno Herrera
This patch adds the documentation for STM32F4x9 USB OTG FS/HS compatible strings. Signed-off-by: Bruno Herrera --- Documentation/devicetree/bindings/usb/dwc2.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt

[v2 1/3] usb: dwc2: Add support for STM32F429/439/469 USB OTG HS/FS in FS mode (internal PHY)

2017-01-15 Thread Bruno Herrera
This patch introduces a new parameter to activate USB OTG HS/FS core embedded phy transciver. The STM32F4x9 SoC uses the GGPIO register to enable the transciver. Signed-off-by: Bruno Herrera --- drivers/usb/dwc2/core.h | 4 drivers/usb/dwc2/hcd.c| 21

Re: functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-15 Thread Vincent Pelletier
On Mon, 16 Jan 2017 00:07:27 +, Vincent Pelletier wrote: > Sometimes, ep0 just gets stuck during SET_CONFIGURATION, but then does > work for test's part which involves it. EP1 & above do not work. I should mention that re-trying SET_CONFIGURATION from host.py times out

Re: functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-15 Thread Vincent Pelletier
On Sun, 15 Jan 2017 23:23:59 +0200, Felipe Balbi wrote: > (it's always a good idea to Cc maintainers of drivers you're having > trouble with :) Noted, I was worried I was CC'ing you too much lately with my patches :) . > Alan Stern

Re: functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-15 Thread Felipe Balbi
Hi, (it's always a good idea to Cc maintainers of drivers you're having trouble with :) Alan Stern writes: > On Sun, 15 Jan 2017, Vincent Pelletier wrote: > >> > An endpoint can not work in both directions, that's not how USB >> > endpoints work at all. I think you

[PATCH] usb: dwc2: fix "iomem 0x00000000" message by setting iomem parameters in usb_hcd

2017-01-15 Thread Heiner Kallweit
Set the iomem parameters in the usb_hcd to fix this misleading message during driver load: dwc2 c910.usb: irq 22, io mem 0x Signed-off-by: Heiner Kallweit --- drivers/usb/dwc2/core.h | 3 ++- drivers/usb/dwc2/hcd.c | 5 - drivers/usb/dwc2/hcd.h

Re: functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-15 Thread Alan Stern
On Sun, 15 Jan 2017, Vincent Pelletier wrote: > > An endpoint can not work in both directions, that's not how USB > > endpoints work at all. I think you are confusing the hardware with your > > configuration :) > > I do agree that I have never noticed in the wild a device using a > non-zero

Re: functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-15 Thread Vincent Pelletier
On Sun, 15 Jan 2017 12:11:08 +0100, Greg KH wrote: > What are you doing on the host to talk to these endpoints? https://github.com/vpelletier/python-functionfs/tree/master/functionfs/tests device.py is the device half and host.py the host part, of course. The committed tests

[GIT PULL] USB driver fixes for 4.10-rc4

2017-01-15 Thread Greg KH
The following changes since commit a121103c922847ba5010819a3f250f1f7fc84ab8: Linux 4.10-rc3 (2017-01-08 14:18:17 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.10-rc4 for you to fetch changes up to

[PATCH v2] Documentation: usb: fix wrong documentation paths

2017-01-15 Thread Yegor Yefremov
Fixes wrong spelled "pinctrl-bindings.txt" and "qcom-dwc3-usb-phy.txt" file names as also wrong specified "mt8173-mtu3.txt" file name. Signed-off-by: Yegor Yefremov --- Changes: v1 -> v2: add changelog text (Greg Kroah-Hartman)

Re: [PATCH] Documentation: usb: fix wrong documentation paths

2017-01-15 Thread Greg KH
On Sun, Jan 15, 2017 at 01:04:56PM +0100, Yegor Yefremov wrote: > Signed-off-by: Yegor Yefremov I never take patches without any changelog text, and I doubt that other maintainers do either :( thanks, greg k-h -- To unsubscribe from this list: send the line

[PATCH] Documentation: usb: fix wrong documentation paths

2017-01-15 Thread Yegor Yefremov
Signed-off-by: Yegor Yefremov --- Documentation/devicetree/bindings/usb/dwc3-st.txt | 4 ++-- Documentation/devicetree/bindings/usb/ehci-st.txt | 2 +- Documentation/devicetree/bindings/usb/mt8173-mtu3.txt | 2 +-

[PATCH] usb: musb: constify dev_pm_ops structures

2017-01-15 Thread Bhumika Goyal
Declare dev_pm_ops structures as const as they are only stored in the pm field of a device_driver structure. This field is of type const, so dev_pm_ops structures having similar properties can be declared const too. Size details after cross compiling the .o file for arm architecture. File size

[PATCH] usb: host: constify dev_pm_ops structures

2017-01-15 Thread Bhumika Goyal
Declare dev_pm_ops structures as const as they are only stored in the pm field of a device_driver structure. This field is of type const, so dev_pm_ops structures having similar properties can be declared const too. Size details after cross compiling the .o file for powerpc architecture. File

Re: functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-15 Thread Greg KH
On Sun, Jan 15, 2017 at 10:06:52AM +, Vincent Pelletier wrote: > Hello, > > Using configfs and functionfs I configured a 3-endpoints gadget the > following way: > - OUT f_fs ep: 1 real ep: 1 | OUT (0x01) > - IN f_fs ep: 2 real ep: 1 | IN (0x81) > - IN f_fs ep: 3 real ep: 2 | IN (0x82) >

functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-15 Thread Vincent Pelletier
Hello, Using configfs and functionfs I configured a 3-endpoints gadget the following way: - OUT f_fs ep: 1 real ep: 1 | OUT (0x01) - IN f_fs ep: 2 real ep: 1 | IN (0x81) - IN f_fs ep: 3 real ep: 2 | IN (0x82) When connected to host: - Real ep 0x01 works. - Real ep 0x81 is silent (all URBs