Re: [RFC PATCH 10/13] mm: Introduce first class virtual address spaces

Hi Vineet, On Mon, 13 Mar 2017, Vineet Gupta wrote: > I've not looked at the patches closely (or read the references paper fully > yet), > but at first glance it seems on ARC architecture, we can can potentially > use/leverage this mechanism to implement the shared TLB entries. Before anyone >

Re: [PATCH] usb-core: Add MS_INTR_BINTERVAL USB quirk

Thank you for your very helpful answer. I really do appreciate it. It's possible that this device is using high speed because it offers a feature to transfer its internal clipboard to the host, and it allows that clipboard to contain lots of data. Interestingly, though, hidden within a usage

Re: [PATCH] usbnet: smsc95xx: Reduce logging noise

On 03/13/2017 03:32 PM, David Miller wrote: From: Guenter Roeck Date: Fri, 10 Mar 2017 17:45:21 -0800 An insert/remove stress test generated the following log message sequence. ... Use netdev_dbg() instead of netdev_warn() for the repeating messages to reduce logging

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

On 14 March 2017 at 09:10, Jun Li wrote: > Hi, > >> -Original Message- >> From: Baolin Wang [mailto:baolin.w...@linaro.org] >> Sent: Monday, March 13, 2017 4:44 PM >> To: Jun Li >> Cc: NeilBrown ; Felipe Balbi ; Greg KH >>

Re: [PATCH v2 0/2] usb: host: [eo]hci-plat: set hcd->phy to avoid phy_get_() in usb_add_hcd()

On Mon, 13 Mar 2017, Yoshihiro Shimoda wrote: > The usb_add_hcd() will call phy_{get,init,power_on}() if hcd->phy is not set. > After the usb_add_hcd() call phy_power_on(), it keeps until usb_remove_hcd(). > And then, even if the system turns suspend, the usb core keeps the phy power. > I think

Re: [PATCH] usb-core: Add MS_INTR_BINTERVAL USB quirk

On Mon, 13 Mar 2017, Samuel Thibault wrote: > Alan Stern, on dim. 12 mars 2017 21:40:33 -0400, wrote: > > On Sun, 12 Mar 2017, Dave Mielke wrote: > > > [quoted lines by Alan Stern on 2017/03/12 at 21:31 -0400] > > > > > > >A device's speed is only partially related to its USB version. A > > >

Re: [PATCH] usb-core: Add MS_INTR_BINTERVAL USB quirk

On Sun, 12 Mar 2017, Dave Mielke wrote: > [quoted lines by Alan Stern on 2017/03/12 at 21:40 -0400] > > >No, I was wondering why an HID device would run at high speed. Both > >you and Samuel implied that this was because it was a USB-2 device. > >But that is not an adequate answer, because it

Re: [RFC PATCH 10/13] mm: Introduce first class virtual address spaces

+CC Ingo, tglx Hi Till, On 03/13/2017 03:14 PM, Till Smejkal wrote: > Introduce a different type of address spaces which are first class citizens > in the OS. That means that the kernel now handles two types of AS, those > which are closely coupled with a process and those which aren't. While

Re: Killing process causing USB bulk transfer transaction loss?

On Mon, 13 Mar 2017, Charles Manning wrote: > On Mon, Mar 13, 2017 at 2:38 PM, Alan Stern > wrote: > > > On Mon, 13 Mar 2017, Charles Manning wrote: > > > > > Hello > > > > > > I have an issue where the first 512-byte high speed bulk transfer > > > between a custom

RE: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

Hi, > -Original Message- > From: Baolin Wang [mailto:baolin.w...@linaro.org] > Sent: Monday, March 13, 2017 4:44 PM > To: Jun Li > Cc: NeilBrown ; Felipe Balbi ; Greg KH > ; Sebastian Reichel ;

Re: Neophyte questions about PCIe

On Mon, Mar 13, 2017 at 10:57:48PM +0100, Mason wrote: > On 13/03/2017 22:40, Bjorn Helgaas wrote: > > > On Sat, Mar 11, 2017 at 11:57:56AM +0100, Mason wrote: > > > >> On 10/03/2017 18:49, Mason wrote: > >> > >>> static void tango_pcie_bar_quirk(struct pci_dev *dev) > >>> { > >>> struct

Re: [PATCH] usbnet: smsc95xx: Reduce logging noise

From: Guenter Roeck Date: Fri, 10 Mar 2017 17:45:21 -0800 > An insert/remove stress test generated the following log message sequence. ... > Use netdev_dbg() instead of netdev_warn() for the repeating messages > to reduce logging noise. > > Signed-off-by: Guenter Roeck

Re: [PATCH] net: usb: asix88179_178a: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Sun, 12 Mar 2017 18:02:36 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH] net: usb: catc: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Sun, 12 Mar 2017 22:08:26 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH] net: usb: r8152: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Sun, 12 Mar 2017 22:41:58 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

[PATCH] [for 4.11]xhci: plat: Register shutdown for xhci_plat

Shutdown should be called for xhci_plat devices especially for situations where kexec might be used by stopping DMA transactions. Signed-off-by: Adam Wallis --- drivers/usb/host/xhci-plat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/xhci-plat.c

Re: Neophyte questions about PCIe

On 13/03/2017 22:40, Bjorn Helgaas wrote: > On Sat, Mar 11, 2017 at 11:57:56AM +0100, Mason wrote: > >> On 10/03/2017 18:49, Mason wrote: >> >>> static void tango_pcie_bar_quirk(struct pci_dev *dev) >>> { >>> struct pci_bus *bus = dev->bus; >>> >>> printk("%s: bus=%d devfn=%d\n",

Re: [PATCH] [for 4.11]xhci: plat: Register shutdown for xhci_plat

On Mon, Mar 13, 2017 at 05:21:14PM -0400, Adam Wallis wrote: > Shutdown should be called for xhci_plat devices especially for > situations where kexec might be used by stopping DMA > transactions. > > Signed-off-by: Adam Wallis > --- > drivers/usb/host/xhci-plat.c | 1 +

Re: Neophyte questions about PCIe

On Sat, Mar 11, 2017 at 11:57:56AM +0100, Mason wrote: > On 10/03/2017 18:49, Mason wrote: > > static void tango_pcie_bar_quirk(struct pci_dev *dev) > > { > > struct pci_bus *bus = dev->bus; > > > > printk("%s: bus=%d devfn=%d\n", __func__, bus->number, dev->devfn); > > > >

[PATCH] [for 4.11]xhci: plat: Register shutdown for xhci_plat

Shutdown should be called for xhci_plat devices especially for situations where kexec might be used by stopping DMA transactions. Signed-off-by: Adam Wallis --- drivers/usb/host/xhci-plat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/xhci-plat.c

[PATCHv3] usb-core: Add LINEAR_FRAME_INTR_BINTERVAL USB quirk

Some USB 2.0 devices erroneously report millisecond values in bInterval. The generic config code manages to catch most of them, but in some cases it's not completely enough. The case at stake here is a USB 2.0 braille device, which wants to announce 10ms and thus sets bInterval to 10, but with

Re: [PATCH] net: wimax/i2400m: fix NULL-deref at probe

From: Johan Hovold Date: Mon, 13 Mar 2017 13:42:03 +0100 > Make sure to check the number of endpoints to avoid dereferencing a > NULL-pointer or accessing memory beyond the endpoint array should a > malicious device lack the expected endpoints. > > The endpoints are

Re: [PATCH] isdn/gigaset: fix NULL-deref at probe

From: Johan Hovold Date: Mon, 13 Mar 2017 13:39:01 +0100 > Make sure to check the number of endpoints to avoid dereferencing a > NULL-pointer should a malicious device lack endpoints. > > Fixes: cf7776dc05b8 ("[PATCH] isdn4linux: Siemens Gigaset drivers - > direct USB

Re: [PATCH] net: usb: asix88179_178a: use new api ethtool_{get|set}_link_ksettings

I have tested this patch on the Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller (Vendor=04b4 ProdID=3610) and the device still functions properly with the patch applied. Feel free to add my name / email to the tested-by portion of the patch. Chris On 2017-03-12 11:02 AM, Philippe

Re: [PATCH] watchdog: pcwd_usb: fix NULL-deref at probe

On Mon, Mar 13, 2017 at 03:17:39PM +0100, Johan Hovold wrote: > [ Adding linux-usb which I forgot to CC for this one ] > > On Mon, Mar 13, 2017 at 06:42:45AM -0700, Guenter Roeck wrote: > > On 03/13/2017 05:49 AM, Johan Hovold wrote: > > > Make sure to check the number of endpoints to avoid

Re: [PATCH v2 0/5] USB: serial: ftdi_sio: latency timer and other stuff

On Wed, Mar 08, 2017 at 04:02:56PM +, Ian Abbott wrote: > Some patches to skip accessing the FTDI latency timer on chips that > don't support it, detect "BM" chips with iSerialNumber bug, validate > written device attribute values, and allow hex and octal "event_char" > values. > > This is v2

Re: [PATCH 0/7] Input: fix NULL-derefs at probe

On Mon, Mar 13, 2017 at 04:15:18PM +0100, Oliver Neukum wrote: > Am Montag, den 13.03.2017, 13:35 +0100 schrieb Johan Hovold: > > This series fixes a number of NULL-pointer dereferences due to > > missing > > endpoint sanity checks that can be triggered by a malicious USB > > device. > > At the

Re: [PATCH 0/7] Input: fix NULL-derefs at probe

Am Montag, den 13.03.2017, 13:35 +0100 schrieb Johan Hovold: > This series fixes a number of NULL-pointer dereferences due to > missing > endpoint sanity checks that can be triggered by a malicious USB > device. >  At the risk of repeating myself, doesn't the sheer number of fixes demonstrate the

Re: [PATCH] net: usb: rtl8150: use new api ethtool_{get|set}_link_ksettings

On 17-03-12 23:16:25, Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if someone may test this > patch. I've got some old adapters around and will drop you

Re: [PATCH v3 1/2] usb: dwc3: refactor gadget endpoint count calculation

On 13/03/17 11:56, Felipe Balbi wrote: Bryan O'Donoghue writes: On 10/03/17 12:14, Felipe Balbi wrote: return 0; I can change your patch locally, if you want. I can also drop your patches and wait for replacements. No strong feelings. I'll resend

[PATCH] usb: dwc3: gadget: delay unmap of bounced requests

From: Janusz Dziedzic In the case of bounced ep0 requests, we must delay DMA operation until after ->complete() otherwise we might overwrite contents of req->buf. This caused problems with RNDIS gadget. Signed-off-by: Janusz Dziedzic

Re: [PATCH] watchdog: pcwd_usb: fix NULL-deref at probe

[ Adding linux-usb which I forgot to CC for this one ] On Mon, Mar 13, 2017 at 06:42:45AM -0700, Guenter Roeck wrote: > On 03/13/2017 05:49 AM, Johan Hovold wrote: > > Make sure to check the number of endpoints to avoid dereferencing a > > NULL-pointer should a malicious device lack endpoints. >

[PATCH 5/6] uwb: hwa-rc: fix NULL-deref at probe

Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer should a malicious device lack endpoints. Note that the dereference happens in the start callback which is called during probe. Fixes: de520b8bd552 ("uwb: add HWA radio controller driver") Cc: stable

[PATCH 1/6] USB: idmouse: fix NULL-deref at probe

Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer should a malicious device lack endpoints. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/misc/idmouse.c | 3 +++ 1 file

[PATCH 6/6] uwb: i1480-dfu: fix NULL-deref at probe

Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer should a malicious device lack endpoints. Note that the dereference happens in the cmd and wait_init_done callbacks which are called during probe. Fixes: 1ba47da52712 ("uwb: add the i1480 DFU driver") Cc: stable

[PATCH 3/6] USB: uss720: fix NULL-deref at probe

Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer or accessing memory beyond the endpoint array should a malicious device lack the expected endpoints. Note that the endpoint access that causes the NULL-deref is currently only used for debugging purposes during probe

[PATCH 2/6] USB: lvtest: fix NULL-deref at probe

Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer should the probed device lack endpoints. Note that this driver does not bind to any devices by default. Fixes: ce21bfe603b3 ("USB: Add LVS Test device driver") Cc: stable # 3.17 Cc:

[PATCH 4/6] USB: wusbcore: fix NULL-deref at probe

Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer or accessing memory beyond the endpoint array should a malicious device lack the expected endpoints. This specifically fixes the NULL-pointer dereference when probing HWA HC devices. Fixes: df3654236e31 ("wusb: add

[PATCH 0/6] USB: fix missing endpoint sanity checks

This series fixes a number of NULL-pointer dereferences due to missing endpoint sanity checks that can be triggered by a malicious device. Johan Johan Hovold (6): USB: idmouse: fix NULL-deref at probe USB: lvtest: fix NULL-deref at probe USB: uss720: fix NULL-deref at probe USB:

[PATCH 2/2] wireless: zd1211rw: fix NULL-deref at probe

Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer or accessing memory beyond the endpoint array should a malicious device lack the expected endpoints. Fixes: a1030e92c150 ("[PATCH] zd1211rw: Convert installer CDROM device into WLAN device") Cc: Daniel Drake

[PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe

Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer or accessing memory beyond the endpoint array should a malicious device lack the expected endpoints. Fixes: 36bcce430657 ("ath9k_htc: Handle storage devices") Cc: Sujith Manoharan

[PATCH] net: wimax/i2400m: fix NULL-deref at probe

Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer or accessing memory beyond the endpoint array should a malicious device lack the expected endpoints. The endpoints are specifically dereferenced in the i2400m_bootrom_init path during probe (e.g. in

[PATCH] mmc: ushc: fix NULL-deref at probe

Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer should a malicious device lack endpoints. Fixes: 53f3a9e26ed5 ("mmc: USB SD Host Controller (USHC) driver") Cc: stable # 2.6.37 Cc: David Vrabel Signed-off-by:

[PATCH] isdn/gigaset: fix NULL-deref at probe

Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer should a malicious device lack endpoints. Fixes: cf7776dc05b8 ("[PATCH] isdn4linux: Siemens Gigaset drivers - direct USB connection") Cc: stable # 2.6.17 Cc: Hansjoerg Lipp

[PATCH 1/7] Input: iforce - fix NULL-deref at probe

Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer or accessing memory that lie beyond the end of the endpoint array should a malicious device lack the expected endpoints. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Signed-off-by:

[PATCH 7/7] Input: sur40 - fix NULL-deref at probe

Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer or accessing memory that lie beyond the end of the endpoint array should a malicious device lack the expected endpoints. Fixes: bdb5c57f209c ("Input: add sur40 driver for Samsung SUR40 (aka MS Surface

[PATCH 3/7] Input: ims-pcu - fix NULL-deref at probe

Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer should a malicious device lack control-interface endpoints. Fixes: 628329d52474 ("Input: add IMS Passenger Control Unit driver") Cc: stable # 3.10 Cc: Dmitry Torokhov

[PATCH 6/7] Input: kbtab - fix NULL-deref at probe

Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer should a malicious device lack endpoints. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Signed-off-by: Johan Hovold --- drivers/input/tablet/kbtab.c | 3 +++ 1 file

[PATCH 4/7] Input: yealink - fix NULL-deref at probe

Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer should a malicious device lack endpoints. Fixes: aca951a22a1d ("[PATCH] input-driver-yealink-P1K-usb-phone") Cc: stable # 2.6.14 Cc: Henk Signed-off-by: Johan

[PATCH 5/7] Input: hanwang - fix NULL-deref at probe

Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer should a malicious device lack endpoints. Fixes: bba5394ad3bd ("Input: add support for Hanwang tablets") Cc: stable # 2.6.37 Cc: Xing Wei Cc: Jiri Kosina

[PATCH 2/7] Input: cm109 - fix NULL-deref at probe

Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer should a malicious device lack endpoints. Fixes: c04148f915e5 ("Input: add driver for USB VoIP phones with CM109 chipset") Cc: stable # 2.6.28 Cc: Alfred E. Heggestad

[PATCH 0/7] Input: fix NULL-derefs at probe

This series fixes a number of NULL-pointer dereferences due to missing endpoint sanity checks that can be triggered by a malicious USB device. Johan Johan Hovold (7): Input: iforce - fix NULL-deref at probe Input: cm109 - fix NULL-deref at probe Input: ims-pcu - fix NULL-deref at probe

Problem with expresscard renesas 720202 resuming from s3

hi guys, I'm not a developer, but need help to understand a problem... I've an expresscard usb 3.0 controller with renesas/nec 720202 chip and when I connect an external drive it works fine but gives me some problem on suspend to ram (s3): on resume from s3 the drive is not mounted anymore and

Re: [PATCH v3 1/2] usb: dwc3: refactor gadget endpoint count calculation

Bryan O'Donoghue writes: > On 10/03/17 12:14, Felipe Balbi wrote: > >> >> return 0; >> >> I can change your patch locally, if you want. I can also drop your >> patches and wait for replacements. No strong feelings. >> > > I'll resend Felipe. thank you,

[PATCH] usb: xhci: fix HCSPARAMS 3 debug message

Signed-off-by: Yoichi Yuasa --- drivers/usb/host/xhci-dbg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-dbg.c b/drivers/usb/host/xhci-dbg.c index 2b4a00f..20ee337 100644 --- a/drivers/usb/host/xhci-dbg.c +++

Re: [PATCH] usb-core: Add MS_INTR_BINTERVAL USB quirk

[quoted lines by Alan Stern on 2017/03/12 at 21:40 -0400] >No, I was wondering why an HID device would run at high speed. Both >you and Samuel implied that this was because it was a USB-2 device. >But that is not an adequate answer, because it is perfectly valid for a >USB-2 device to run at

RE: [PATCH] net: usb: r8152: use new api ethtool_{get|set}_link_ksettings

Philippe Reynes [mailto:trem...@gmail.com] > Sent: Monday, March 13, 2017 5:42 AM > Subject: [PATCH] net: usb: r8152: use new api ethtool_{get|set}_link_ksettings > > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

On 13 March 2017 at 09:09, Jun Li wrote: > Hi, > >> -Original Message- >> From: Baolin Wang [mailto:baolin.w...@linaro.org] >> Sent: Friday, March 10, 2017 6:52 PM >> To: Jun Li >> Cc: NeilBrown ; Felipe Balbi ; Greg KH >>

Re: [PATCH v2] usb: xhci: bInterval quirk for TI TUSB73x0

Hello! On 3/13/2017 11:11 AM, Roger Quadros wrote: As per [1] issue #4, "The periodic EP scheduler always tries to schedule the EPs that have large intervals (interval equal to or greater than 128 microframes) into different microframes. So it maintains an internal counter and increments for

Re: [PATCH v3 1/2] usb: dwc3: refactor gadget endpoint count calculation

On 10/03/17 12:14, Felipe Balbi wrote: return 0; I can change your patch locally, if you want. I can also drop your patches and wait for replacements. No strong feelings. I'll resend Felipe. Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the

Re: [PATCH v2 0/4] usb: dwc3: dual-role support

Felipe, On 16/02/17 15:06, Roger Quadros wrote: > Hi, > > We rely on the OTG controller block or Extcon to provide us with > VBUS and ID line status via an interrupt. > > This is then used to switch the controller between host, peripheral > and idle roles based on the following table. > >

[PATCH v2] usb: xhci: bInterval quirk for TI TUSB73x0

As per [1] issue #4, "The periodic EP scheduler always tries to schedule the EPs that have large intervals (interval equal to or greater than 128 microframes) into different microframes. So it maintains an internal counter and increments for each large interval EP added. When the counter is

Re: [PATCH] net: usb: asix88179_178a: use new api ethtool_{get|set}_link_ksettings

Hi Chris, On 3/13/17, Chris Roth wrote: > I can test it tomorrow. I'll pull a clean copy of 4.10.2, or do you > suggest a different version than that? I think that 4.10.2 is fine, there are no change on this driver between 4.10 and git (net-next). Thanks a lot for the

Re: [PATCH] usb-core: Add MS_INTR_BINTERVAL USB quirk

Alan Stern, on dim. 12 mars 2017 21:40:33 -0400, wrote: > On Sun, 12 Mar 2017, Dave Mielke wrote: > > [quoted lines by Alan Stern on 2017/03/12 at 21:31 -0400] > > > > >A device's speed is only partially related to its USB version. A > > >USB-1.1 device can run at low speed or full speed. A

[PATCH v2 1/2] usb: host: ehci-platform: set hcd->phy to avoid phy_get() in usb_add_hcd()

This patch sets hcd->phy from own phy context to avoid phy_get() in usb_add_hcd(). Since core/hcd.c manages the phy only in usb_add_hcd() and usb_remove_hcd(), there is difficult to manage the phy in suspend/resume. Signed-off-by: Yoshihiro Shimoda ---

[PATCH v2 0/2] usb: host: [eo]hci-plat: set hcd->phy to avoid phy_get_() in usb_add_hcd()

The usb_add_hcd() will call phy_{get,init,power_on}() if hcd->phy is not set. After the usb_add_hcd() call phy_power_on(), it keeps until usb_remove_hcd(). And then, even if the system turns suspend, the usb core keeps the phy power. I think that each host driver should handle the phy power. So,

[PATCH v2 2/2] usb: host: ohci-platform: set hcd->phy to avoid phy_get() in usb_add_hcd()

This patch sets hcd->phy from own phy context to avoid phy_get() in usb_add_hcd(). Since core/hcd.c manages the phy only in usb_add_hcd() and usb_remove_hcd(), there is difficult to manage the phy in suspend/resume. Signed-off-by: Yoshihiro Shimoda ---