Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-11 Thread David Ahern
On 8/11/17 6:25 PM, Wei Wang wrote: > By "a patch to fix that" do you mean after your patch, for every rt6, > rt6->rt6i_idev will be the same as rt6->dst.dev? FIB entries should have them the same device with my patch. The copies done (ip6_rt_cache_alloc and ip6_rt_pcpu_alloc) will have to set

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-11 Thread John Stultz
On Fri, Aug 11, 2017 at 5:31 PM, John Stultz wrote: > On Fri, Aug 11, 2017 at 5:10 PM, Wei Wang wrote: >>> If after Cong's fix, the issue still happens, could you help try the >>> patch attached and collect all logs when you try the reproduce the >>>

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-11 Thread Wei Wang
> So yes, sorry I haven't been able to get back quicker on the other > patches sent, was mucking about in other work. > > So yea, this patch (potential fix for unregister_netdevice()) seems > to avoid the issue. > > I'm going to do some further testing, but its looking good so far. > Great.

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-11 Thread John Stultz
On Fri, Aug 11, 2017 at 5:10 PM, Wei Wang wrote: >> If after Cong's fix, the issue still happens, could you help try the >> patch attached and collect all logs when you try the reproduce the >> issue? It would be great to have logs for both success case and the >> failure case.

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-11 Thread Wei Wang
On Fri, Aug 11, 2017 at 5:19 PM, David Ahern wrote: > On 8/11/17 6:10 PM, Wei Wang wrote: >> I think we have a potential fix for this issue. >> Martin and I found that when addrconf_dst_alloc() creates a rt6, it is >> possible that rt6->dst.dev points to loopback device while

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-11 Thread David Ahern
On 8/11/17 6:10 PM, Wei Wang wrote: > I think we have a potential fix for this issue. > Martin and I found that when addrconf_dst_alloc() creates a rt6, it is > possible that rt6->dst.dev points to loopback device while > rt6->rt6i_idev->dev points to a real device. > When the real device goes

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-11 Thread Wei Wang
> If after Cong's fix, the issue still happens, could you help try the > patch attached and collect all logs when you try the reproduce the > issue? It would be great to have logs for both success case and the > failure case. > > Thanks so much for your help. > I think we have a potential fix for

[PATCH] usb: gadget: f_fs: Pass along set_halt errors.

2017-08-11 Thread Jerry Zhang
Users can apply i/o in the wrong direction on an endpoint to stall it. In case there is an error that does not allow the endpoint to be stalled, we want the user to know. An operation to stall the endpoint will return EBADMSG if successful, EAGAIN if there are still queued requests, and other

Re: [PATCH v2 2/3] usb: chipidea: Hook into mux framework to toggle usb switch

2017-08-11 Thread Stephen Boyd
Quoting Peter Rosin (2017-08-08 05:46:30) > On 2017-08-08 03:51, Stephen Boyd wrote: > > > It looked like we paired the start/stop ops with > > each other so that the mux is properly managed across these ops. > > Yes, it *looks* ok... > > >

Re: device registration callback for usb-serial

2017-08-11 Thread Samuel Thibault
Okash Khawaja, on ven. 11 août 2017 22:38:14 +0100, wrote: > On Thu, Aug 10, 2017 at 10:27:31AM +0200, Samuel Thibault wrote: > > Oliver Neukum, on jeu. 10 ao??t 2017 10:03:51 +0200, wrote: > > > You cannot make assumptions about driver load. Your driver was loaded. > > > End of story. Register it

Re: device registration callback for usb-serial

2017-08-11 Thread Okash Khawaja
On Thu, Aug 10, 2017 at 10:27:31AM +0200, Samuel Thibault wrote: > Oliver Neukum, on jeu. 10 ao??t 2017 10:03:51 +0200, wrote: > > You cannot make assumptions about driver load. Your driver was loaded. > > End of story. Register it with the proper subsystem. > > The subsystem in question is a

Re: [PATCH] USB: core: Avoid race of async_completed() w/ usbdev_release()

2017-08-11 Thread Alan Stern
On Thu, 10 Aug 2017, Douglas Anderson wrote: > While running reboot tests w/ a specific set of USB devices (and > slub_debug enabled), I found that once every few hours my device would > be crashed with a stack that looked like this: > > [ 14.012445] BUG: spinlock bad magic on CPU#0,

RE: [linux-devel] [PATCH 1/3] dts: usb3: Add configure-gfladj property to USB3 nod

2017-08-11 Thread Sriram Dash
>From: linux-devel-boun...@gforge.freescale.net [mailto:linux-devel- >boun...@gforge.freescale.net] On Behalf Of yinbo@nxp.com >Subject: [linux-devel] [PATCH 1/3] dts: usb3: Add configure-gfladj property to >USB3 >nod > >From: "yinbo.zhu" > >Signed-off-by: yinbo.zhu

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-11 Thread Wei Wang
On Fri, Aug 11, 2017 at 9:48 AM, Cong Wang wrote: > Hi, > > On Thu, Aug 10, 2017 at 11:12 AM, John Stultz wrote: >> On Wed, Aug 9, 2017 at 10:41 PM, Wei Wang wrote: >>> Hi John, >>> >>> Is it possible to try the attached

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-11 Thread Cong Wang
Hi, On Thu, Aug 10, 2017 at 11:12 AM, John Stultz wrote: > On Wed, Aug 9, 2017 at 10:41 PM, Wei Wang wrote: >> Hi John, >> >> Is it possible to try the attached patch? > > Thanks so much for the quick turn around! > > So I dropped all the reverts you

RE: [linux-devel] [PATCH 3/3] core-arm: add a member about dma_map_ops in dev_archdata struct

2017-08-11 Thread Leo Li
> -Original Message- > From: linux-devel-boun...@gforge.freescale.net [mailto:linux-devel- > boun...@gforge.freescale.net] On Behalf Of yinbo@nxp.com > Sent: Friday, August 11, 2017 5:01 AM > To: linux-de...@gforge.freescale.net; Yinbo Zhu ; Rob > Herring

RE: [linux-devel] [PATCH 1/3] dts: usb3: Add configure-gfladj property to USB3 nod

2017-08-11 Thread Leo Li
> -Original Message- > From: linux-devel-boun...@gforge.freescale.net [mailto:linux-devel- > boun...@gforge.freescale.net] On Behalf Of yinbo@nxp.com > Sent: Friday, August 11, 2017 4:30 AM > To: linux-de...@gforge.freescale.net; Yinbo Zhu ; Rob > Herring

RE: [linux-devel] [PATCH 2/3] usb: dwc3 : Add support for USB snooping

2017-08-11 Thread Leo Li
> -Original Message- > From: linux-devel-boun...@gforge.freescale.net [mailto:linux-devel- > boun...@gforge.freescale.net] On Behalf Of yinbo@nxp.com > Sent: Friday, August 11, 2017 5:00 AM > To: linux-de...@gforge.freescale.net; Yinbo Zhu ; Rob > Herring

Runtime PM enabled USB port no longer responses to hotplug after commit dec08194ff

2017-08-11 Thread Kai-Heng Feng
Hi, My ASUS PRIME B350M-A uses this XHCI chip: 03:00.0 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] USB 3.1 XHCI Controller [1022:43bb] (rev 02) ...which matches to the PCI_DEVICE_ID_AMD_PROMONTORYA_2. Revert commit dec08194ffeccfa1cf085906b53d301930eae18f ("xhci: Limit USB2 port

[PATCH] usb: gadget: allow serial gadget console on other configs

2017-08-11 Thread Thadeu Lima de Souza Cascardo
From: Thadeu Lima de Souza Cascardo USB gadget serial console works on functions other than the legacy configurations. Let the user enable it when using any function that uses the serial utilities. Signed-off-by: Thadeu Lima de Souza Cascardo

Re: [PATCH 1/3] dts: usb3: Add configure-gfladj property to USB3 nod

2017-08-11 Thread Felipe Balbi
Hi, yinbo@nxp.com writes: > From: "yinbo.zhu" > > Signed-off-by: yinbo.zhu > --- > arch/arm/boot/dts/ls1021a.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi > index

Re: [PATCH 2/3] usb: dwc3 : Add support for USB snooping

2017-08-11 Thread Felipe Balbi
Hi, yinbo@nxp.com writes: > From: Rajesh Bhagat > > Add support for USB3 snooping by asserting bits > in register DWC3_GSBUSCFG0 for data and descriptor you're doing WAAY more than that. Also, you don't tell me WHY you want/need snooping to be enabled, or

[PATCH 3/3] core-arm: add a member about dma_map_ops in dev_archdata struct

2017-08-11 Thread yinbo.zhu
From: "yinbo.zhu" Signed-off-by: yinbo.zhu --- arch/arm/include/asm/device.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/include/asm/device.h b/arch/arm/include/asm/device.h index 220ba20..c93d3df 100644 --- a/arch/arm/include/asm/device.h

[PATCH 2/3] usb: dwc3 : Add support for USB snooping

2017-08-11 Thread yinbo.zhu
From: Rajesh Bhagat Add support for USB3 snooping by asserting bits in register DWC3_GSBUSCFG0 for data and descriptor Signed-off-by: Nikhil Badola Signed-off-by: Rajesh Bhagat Signed-off-by: yinbo.zhu

[PATCH 1/3] dts: usb3: Add configure-gfladj property to USB3 nod

2017-08-11 Thread yinbo.zhu
From: "yinbo.zhu" Signed-off-by: yinbo.zhu --- arch/arm/boot/dts/ls1021a.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi index ffbf3cf..f525297 100644 ---

Re: [PATCH 4/4] dt-bindings: mt8173-xhci: add generic compatible and rename file

2017-08-11 Thread Chunfeng Yun
On Thu, 2017-08-10 at 21:56 -0500, Rob Herring wrote: > On Tue, Aug 08, 2017 at 01:42:52PM +0800, Chunfeng Yun wrote: > > The mt8173-xhci.txt actually holds the bindings for all mediatek > > SoCs with xHCI controller, so add a generic compatible and change > > the name to xhci-mtk.txt to reflect

Re: [PATCH 3/4] dt-bindings: mt8173-mtu3: add generic compatible and rename file

2017-08-11 Thread Chunfeng Yun
On Thu, 2017-08-10 at 21:54 -0500, Rob Herring wrote: > On Tue, Aug 08, 2017 at 01:42:51PM +0800, Chunfeng Yun wrote: > > The mt8173-mtu3.txt actually holds the bindings for all mediatek > > SoCs with usb3 DRD IP, so add a generic compatible and change the > > name to mtu3.txt. > > > >

Re: [PATCH v3] dma-mapping: skip USB devices when configuring DMA during probe

2017-08-11 Thread Stefan Wahren
Hi Robin, Am 08.08.2017 um 20:03 schrieb Johan Hovold: > On Sat, Aug 05, 2017 at 10:38:07AM +0200, Christoph Hellwig wrote: >> I think the root problem is that the code added by >> " of/acpi: Configure dma operations at probe time for platform/amba/pci bus >> devices" >> >> is completely bogus