Re: [PATCH v2] usb: dwc2: Remove unnecessary debug prints

2017-12-07 Thread Razmik Karapetyan
On 12/7/2017 11:18 PM, Joe Perches wrote: > On Thu, 2017-12-07 at 11:17 -0800, Joe Perches wrote: >> On Wed, 2017-12-06 at 17:57 +0400, Razmik Karapetyan wrote: >>> Removed unnecessary debug prints about DMA mode for host side >>> from dwc2_gahbcfg_init() function. >> >> What other functionality

Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()

2017-12-07 Thread Geert Uytterhoeven
Hi Alan, On Thu, Dec 7, 2017 at 10:26 PM, Alan Stern wrote: > On Thu, 7 Dec 2017, Dan Carpenter wrote: >> The standard is to treat them like errors and try press forward in a >> degraded mode but don't print a message. Checkpatch.pl complains if you >> print a warning

Re: [PATCH 0/4] USB over IP Secuurity fixes

2017-12-07 Thread Greg KH
On Thu, Dec 07, 2017 at 02:16:46PM -0700, Shuah Khan wrote: > Jakub Jirasek from Secunia Research at Flexera reported security > vulnerabilities in the USB over IP driver. This patch series all > the 4 reported problems. Nice! These should also all go to the stable kernels, right? thanks, greg

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-07 Thread Dave Chinner
On Fri, Dec 08, 2017 at 01:45:52PM +0900, Byungchul Park wrote: > On Fri, Dec 08, 2017 at 09:22:16AM +1100, Dave Chinner wrote: > > On Thu, Dec 07, 2017 at 11:06:34AM -0500, Theodore Ts'o wrote: > > > On Wed, Dec 06, 2017 at 06:06:48AM -0800, Matthew Wilcox wrote: > > > > > Unfortunately for you,

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-07 Thread Byungchul Park
On Fri, Dec 08, 2017 at 09:22:16AM +1100, Dave Chinner wrote: > On Thu, Dec 07, 2017 at 11:06:34AM -0500, Theodore Ts'o wrote: > > On Wed, Dec 06, 2017 at 06:06:48AM -0800, Matthew Wilcox wrote: > > > > Unfortunately for you, I don't find arguments along the lines of > > > > "lockdep will save us"

Re: [PATCH 4.4 13/49] usb: dwc2: Fix UDC state tracking

2017-12-07 Thread Ben Hutchings
On Thu, 2017-12-07 at 14:07 +0100, Greg Kroah-Hartman wrote: > 4.4-stable review patch.  If anyone has any objections, please let me > know. > > -- > > From: John Stultz > > > [ Upstream commit ce2b21a4e5ce042c0a42c9db8fa9e0f849427d5e ] > > It has been

Re: Lockdep is less useful than it was

2017-12-07 Thread Dave Chinner
On Thu, Dec 07, 2017 at 02:38:03PM -0800, Matthew Wilcox wrote: > On Thu, Dec 07, 2017 at 11:06:34AM -0500, Theodore Ts'o wrote: > > The problem is that if it has too many false positives --- and it's > > gotten *way* worse with the completion callback "feature", people will > > just stop using

Re: RFC: FT232H based FPGA configuration adapter drivers

2017-12-07 Thread Anatolij Gustschin
On Thu, 7 Dec 2017 14:24:57 -0600 Alan Tull at...@kernel.org wrote: ... >> Instead of MFD part as in previous version I intend to add an USB misc >> driver for our FPGA configuration adapters under drivers/usb/misc. >> When probing for VID/PID assigned to FIFO-FPP adapter type, this >> driver will

Re: Lockdep is less useful than it was

2017-12-07 Thread Matthew Wilcox
On Thu, Dec 07, 2017 at 02:38:03PM -0800, Matthew Wilcox wrote: > You need to get LOCKDEP_CROSSRELEASE off. I'd revert patches > e26f34a407aec9c65bce2bc0c838fabe4f051fc6 and > b483cf3bc249d7af706390efa63d6671e80d1c09 Oops. I meant to revert 2dcd5adfb7401b762ddbe4b86dcacc2f3de6b97b. Or you could

Lockdep is less useful than it was

2017-12-07 Thread Matthew Wilcox
On Thu, Dec 07, 2017 at 11:06:34AM -0500, Theodore Ts'o wrote: > The problem is that if it has too many false positives --- and it's > gotten *way* worse with the completion callback "feature", people will > just stop using Lockdep as being too annyoing and a waste of developer > time when trying

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-07 Thread Dave Chinner
On Thu, Dec 07, 2017 at 11:06:34AM -0500, Theodore Ts'o wrote: > On Wed, Dec 06, 2017 at 06:06:48AM -0800, Matthew Wilcox wrote: > > > Unfortunately for you, I don't find arguments along the lines of > > > "lockdep will save us" at all convincing. lockdep already throws > > > too many false

Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()

2017-12-07 Thread Alan Stern
On Thu, 7 Dec 2017, Dan Carpenter wrote: > On Thu, Dec 07, 2017 at 10:12:27AM -0500, Alan Stern wrote: > > The real problem is that the kernel development community doesn't have > > a fixed policy on how to handle memory allocation errors. There are > > several possibilities: > > > > Ignore

[PATCH 1/4] usbip: fix stub_rx: get_pipe() to validate endpoint number

2017-12-07 Thread Shuah Khan
get_pipe() routine doesn't validate the input endpoint number and uses to reference ep_in and ep_out arrays. Invalid endpoint number can trigger BUG(). Range check the epnum and returning error instead of calling BUG(). Change caller stub_recv_cmd_submit() to handle the get_pipe() error return.

[PATCH 0/4] USB over IP Secuurity fixes

2017-12-07 Thread Shuah Khan
Jakub Jirasek from Secunia Research at Flexera reported security vulnerabilities in the USB over IP driver. This patch series all the 4 reported problems. Jakub, could you please suggest an email address I can use for the Reported-by tag? Shuah Khan (4): usbip: fix stub_rx: get_pipe() to

[PATCH 2/4] usbip: fix stub_rx: harden CMD_SUBMIT path to handle malicious input

2017-12-07 Thread Shuah Khan
Harden CMD_SUBMIT path to handle malicious input that could trigger large memory allocations. Add checks to validate transfer_buffer_length and number_of_packets to protect against bad input requesting for unbounded memory allocations. Validate early in get_pipe() and return failure.

[PATCH 4/4] usbip: fix stub_send_ret_submit() vulnerability to null transfer_buffer

2017-12-07 Thread Shuah Khan
stub_send_ret_submit() handles urb with a potential null transfer_buffer, when it replays a packet with potential malicious data that could contain a null buffer. Add a check for the condition when actual_length > 0 and transfer_buffer is null. Signed-off-by: Shuah Khan

[PATCH 3/4] usbip: prevent vhci_hcd driver from leaking a socket pointer address

2017-12-07 Thread Shuah Khan
When a client has a USB device attached over IP, the vhci_hcd driver is locally leaking a socket pointer address via the /sys/devices/platform/vhci_hcd/status file (world-readable) and in debug output when "usbip --debug port" is run. Fix it to not leak. The socket pointer address is not used at

Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()

2017-12-07 Thread Dan Carpenter
On Thu, Dec 07, 2017 at 10:12:27AM -0500, Alan Stern wrote: > The real problem is that the kernel development community doesn't have > a fixed policy on how to handle memory allocation errors. There are > several possibilities: > > Ignore them on the grounds that they will never happen. >

Re: RFC: FT232H based FPGA configuration adapter drivers

2017-12-07 Thread Alan Tull
On Thu, Dec 7, 2017 at 8:31 AM, Anatolij Gustschin wrote: > Hi, > > I have to rework drivers for custom FT232H based FPGA configuration > adapters to make them suitable for including in mainline kernel. These > adapters should be usable via low-level drivers for FPGA Manager >

Re: [PATCH v2 0/8] lsusb: Add initial support for USB Audio Class 3

2017-12-07 Thread Greg KH
On Thu, Dec 07, 2017 at 07:24:35PM +, Michael Drake wrote: > On 07/12/17 17:26, Greg KH wrote: > > On Thu, Dec 07, 2017 at 05:14:10PM +, Michael Drake wrote: > > > On 07/12/17 15:16, Greg KH wrote: > > > > On Thu, Dec 07, 2017 at 04:01:23PM +0100, Greg KH wrote: > > > > > Oops, I should

Re: [PATCH v1 1/1] lsusb: Fix array entry count for variable sized entries.

2017-12-07 Thread Greg KH
On Thu, Dec 07, 2017 at 07:18:39PM +, Michael Drake wrote: > This fixes a divide by zero which happened when an array, > without an explicit entry count (ultimately calculated from > the value in the descriptor data's bLength field) was used > on field with a variable size. > > The solultion

Re: [PATCH] usbnet: fix alignment for frames with no ethernet header

2017-12-07 Thread David Miller
From: Bjørn Mork Date: Thu, 07 Dec 2017 20:01:16 +0100 > David Miller writes: > >> From: Bjørn Mork >> Date: Wed, 6 Dec 2017 20:21:24 +0100 >> >>> The qmi_wwan minidriver support a 'raw-ip' mode where frames are >>> received without any

Re: [PATCH v2 0/8] lsusb: Add initial support for USB Audio Class 3

2017-12-07 Thread Michael Drake
On 07/12/17 17:26, Greg KH wrote: On Thu, Dec 07, 2017 at 05:14:10PM +, Michael Drake wrote: On 07/12/17 15:16, Greg KH wrote: On Thu, Dec 07, 2017 at 04:01:23PM +0100, Greg KH wrote: Oops, I should have tested the code, it now crashes for me with the following error: Floating

[PATCH v1 1/1] lsusb: Fix array entry count for variable sized entries.

2017-12-07 Thread Michael Drake
This fixes a divide by zero which happened when an array, without an explicit entry count (ultimately calculated from the value in the descriptor data's bLength field) was used on field with a variable size. The solultion is to use the get_entry_size() function on the array entry, which can get

[PATCH v1 0/1] lsusb: Fix potential floating point exception.

2017-12-07 Thread Michael Drake
This fixes the likely cause of a crash found by Greg. Michael Drake (1): lsusb: Fix array entry count for variable sized entries. desc-dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body

Re: [PATCH v2] usb: dwc2: Remove unnecessary debug prints

2017-12-07 Thread Joe Perches
On Thu, 2017-12-07 at 11:17 -0800, Joe Perches wrote: > On Wed, 2017-12-06 at 17:57 +0400, Razmik Karapetyan wrote: > > Removed unnecessary debug prints about DMA mode for host side > > from dwc2_gahbcfg_init() function. > > What other functionality makes these unnecessary? > If any, it's nice to

Re: [PATCH v2] usb: dwc2: Remove unnecessary debug prints

2017-12-07 Thread Joe Perches
On Wed, 2017-12-06 at 17:57 +0400, Razmik Karapetyan wrote: > Removed unnecessary debug prints about DMA mode for host side > from dwc2_gahbcfg_init() function. What other functionality makes these unnecessary? If any, it's nice to de -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v2 0/8] lsusb: Add initial support for USB Audio Class 3

2017-12-07 Thread Greg KH
On Thu, Dec 07, 2017 at 06:26:30PM +0100, Greg KH wrote: > On Thu, Dec 07, 2017 at 05:14:10PM +, Michael Drake wrote: > > > > > > On 07/12/17 15:16, Greg KH wrote: > > > On Thu, Dec 07, 2017 at 04:01:23PM +0100, Greg KH wrote: > > > > On Thu, Dec 07, 2017 at 04:00:36PM +0100, Greg KH wrote:

Re: [PATCH] usbnet: fix alignment for frames with no ethernet header

2017-12-07 Thread Bjørn Mork
David Miller writes: > From: Bjørn Mork > Date: Wed, 6 Dec 2017 20:21:24 +0100 > >> The qmi_wwan minidriver support a 'raw-ip' mode where frames are >> received without any ethernet header. This causes alignment issues >> because the skbs allocated by usbnet

Re: [PATCH v2 0/8] lsusb: Add initial support for USB Audio Class 3

2017-12-07 Thread Greg KH
On Thu, Dec 07, 2017 at 05:14:10PM +, Michael Drake wrote: > > > On 07/12/17 15:16, Greg KH wrote: > > On Thu, Dec 07, 2017 at 04:01:23PM +0100, Greg KH wrote: > > > On Thu, Dec 07, 2017 at 04:00:36PM +0100, Greg KH wrote: > > > > On Thu, Dec 07, 2017 at 10:26:21AM +, Michael Drake

Re: [PATCH v2 0/8] lsusb: Add initial support for USB Audio Class 3

2017-12-07 Thread Greg KH
On Thu, Dec 07, 2017 at 05:11:58PM +, Michael Drake wrote: > > > On 07/12/17 15:00, Greg KH wrote: > > On Thu, Dec 07, 2017 at 10:26:21AM +, Michael Drake wrote: > > > This adds a new way of dumping descriptors, which splits the knowledge > > > of how to interpret descriptor data from

Re: [PATCH] tools/usbip: fixes potential (minor) "buffer overflow" (detected on recent gcc with -Werror)

2017-12-07 Thread Shuah Khan
On 12/05/2017 08:09 AM, julien.boibes...@free.fr wrote: > From: Julien BOIBESSOT > > Fixes following build error: > vhci_driver.c: In function 'refresh_imported_device_list': > vhci_driver.c:118:37: error: 'snprintf' output may be truncated before > the last

Re: [PATCH v1 0/2] lsusb: Squash warnings from UAC3 merge.

2017-12-07 Thread Greg KH
On Thu, Dec 07, 2017 at 05:07:17PM +, Michael Drake wrote: > This series is to fix some warnings reported by Greg. Thanks, all applied. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] usb: dwc2: hcd: Fix host channel halt flow

2017-12-07 Thread Stefan Wahren
Hi Minas, Am 07.12.2017 um 18:08 schrieb Stefan Wahren: > According databook in Buffer and External DMA mode > non-split periodic channels can't be halted. do you know of any consequences not having this patch applied? > > Signed-off-by: Minas Harutyunyan Please add a

Re: [PATCH v2 0/8] lsusb: Add initial support for USB Audio Class 3

2017-12-07 Thread Michael Drake
On 07/12/17 15:16, Greg KH wrote: On Thu, Dec 07, 2017 at 04:01:23PM +0100, Greg KH wrote: On Thu, Dec 07, 2017 at 04:00:36PM +0100, Greg KH wrote: On Thu, Dec 07, 2017 at 10:26:21AM +, Michael Drake wrote: This adds a new way of dumping descriptors, which splits the knowledge of how to

Re: [PATCH v2 0/8] lsusb: Add initial support for USB Audio Class 3

2017-12-07 Thread Michael Drake
On 07/12/17 15:00, Greg KH wrote: On Thu, Dec 07, 2017 at 10:26:21AM +, Michael Drake wrote: This adds a new way of dumping descriptors, which splits the knowledge of how to interpret descriptor data from the actual dumping. This has two advantages: 1. It is easy to add support for new

[PATCH v1 1/2] lsusb: Squash Wpointer-compare warning.

2017-12-07 Thread Michael Drake
This squashes "warning: comparison between pointer and zero character" This was an empty string check that was checking the pointer rather than the first character. The check was done correctly before the string was used, so here we yank the correct check up, to the upper level, replacing the

[PATCH v1 2/2] lsusb: Remove unused function.

2017-12-07 Thread Michael Drake
The get_audioterminal_string() function is now unused. Signed-off-by: Michael Drake --- lsusb.c | 12 1 file changed, 12 deletions(-) diff --git a/lsusb.c b/lsusb.c index a1b7f8d..1650016 100644 --- a/lsusb.c +++ b/lsusb.c @@ -217,18 +217,6 @@ static

[PATCH v1 0/2] lsusb: Squash warnings from UAC3 merge.

2017-12-07 Thread Michael Drake
This series is to fix some warnings reported by Greg. Michael Drake (2): lsusb: Squash Wpointer-compare warning. lsusb: Remove unused function. desc-dump.c | 7 +++ lsusb.c | 12 2 files changed, 3 insertions(+), 16 deletions(-) -- 2.11.0 -- To unsubscribe from this

Re: [PATCH] usb: dwc2: host: Setting TOUTCAL and USBTRDTIM fields in host mode

2017-12-07 Thread Stefan Wahren
Hi Minas, Am 07.12.2017 um 17:56 schrieb Stefan Wahren: > Added missing GUSBCFG programming in host mode. > > These fields even if was programmed in device mode (in function > dwc2_hsotg_core_init_disconnected()) will be resetting to POR values > after core soft reset applied. > So, each time

Re: [PATCH] usb: dwc2: Change TxFIFO and RxFIFO flushing flow

2017-12-07 Thread Stefan Wahren
Hi Minas, Am 07.12.2017 um 09:40 schrieb Stefan Wahren: > Before flushing fifos required to check AHB master state and > flush when AHB master is in IDLE state. > > Signed-off-by: Minas Harutyunyan > --- > drivers/usb/dwc2/core.c | 27 +++ > 1 file

Re: [RFC PATCH 0/2] usb: typec: alternate mode bus

2017-12-07 Thread Hans de Goede
Hi, On 07-12-17 16:00, Heikki Krogerus wrote: Hi Hans, On Tue, Dec 05, 2017 at 03:56:05PM +0100, Hans de Goede wrote: Hi, On 01-12-17 09:38, Heikki Krogerus wrote: Hi, Thanks for taking a look at this.. On Sun, Nov 26, 2017 at 12:23:31PM +0100, Hans de Goede wrote: Hi Heiko, On 28-09-17

Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()

2017-12-07 Thread Joe Perches
On Thu, 2017-12-07 at 10:12 -0500, Alan Stern wrote: > The real problem is that the kernel development community doesn't have > a fixed policy on how to handle memory allocation errors. [] > If there was one agreed-upon policy, then we could definitively point > to old code and say "That's wrong,

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-07 Thread Theodore Ts'o
On Wed, Dec 06, 2017 at 06:06:48AM -0800, Matthew Wilcox wrote: > > Unfortunately for you, I don't find arguments along the lines of > > "lockdep will save us" at all convincing. lockdep already throws > > too many false positives to be useful as a tool that reliably and > > accurately points out

Re: [PATCH v2 0/8] lsusb: Add initial support for USB Audio Class 3

2017-12-07 Thread Greg KH
On Thu, Dec 07, 2017 at 04:01:23PM +0100, Greg KH wrote: > On Thu, Dec 07, 2017 at 04:00:36PM +0100, Greg KH wrote: > > On Thu, Dec 07, 2017 at 10:26:21AM +, Michael Drake wrote: > > > This adds a new way of dumping descriptors, which splits the knowledge > > > of how to interpret descriptor

Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()

2017-12-07 Thread Alan Stern
On Thu, 7 Dec 2017, Geert Uytterhoeven wrote: > Hi Alan, > > On Wed, Dec 6, 2017 at 11:02 PM, Alan Stern wrote: > > On Wed, 6 Dec 2017, SF Markus Elfring wrote: > >> >>> Does the existing memory allocation error message include the > >> >>> >dev device name and driver

Re: [PATCH v2 0/8] lsusb: Add initial support for USB Audio Class 3

2017-12-07 Thread Greg KH
On Thu, Dec 07, 2017 at 04:00:36PM +0100, Greg KH wrote: > On Thu, Dec 07, 2017 at 10:26:21AM +, Michael Drake wrote: > > This adds a new way of dumping descriptors, which splits the knowledge > > of how to interpret descriptor data from the actual dumping. This has > > two advantages: > > >

Re: [PATCH v2 0/8] lsusb: Add initial support for USB Audio Class 3

2017-12-07 Thread Greg KH
On Thu, Dec 07, 2017 at 10:26:21AM +, Michael Drake wrote: > This adds a new way of dumping descriptors, which splits the knowledge > of how to interpret descriptor data from the actual dumping. This has > two advantages: > > 1. It is easy to add support for new descriptors, since they are

Re: [RFC PATCH 0/2] usb: typec: alternate mode bus

2017-12-07 Thread Heikki Krogerus
Hi Hans, On Tue, Dec 05, 2017 at 03:56:05PM +0100, Hans de Goede wrote: > Hi, > > On 01-12-17 09:38, Heikki Krogerus wrote: > > Hi, > > > > Thanks for taking a look at this.. > > > > On Sun, Nov 26, 2017 at 12:23:31PM +0100, Hans de Goede wrote: > > > Hi Heiko, > > > > > > On 28-09-17 13:35,

Re: [PATCH] Do not create and install usbutils.pc

2017-12-07 Thread Greg Kroah-Hartman
On Thu, Dec 07, 2017 at 03:44:15PM +0100, Greg Kroah-Hartman wrote: > On Sat, Nov 25, 2017 at 08:59:12PM +0100, Aurelien Jarno wrote: > > The usbutils pkgconfig file defines where the usb.ids database is > > installed. Given usbutils does not ship with usb.ids and does not > > install it anymore,

Re: [PATCH] usbreset.c: add missing include

2017-12-07 Thread Greg Kroah-Hartman
On Sat, Nov 25, 2017 at 10:48:13PM +0100, Aurelien Jarno wrote: > Without it one gets: > > $ gcc -o usbreset usbreset.c > usbreset.c: In function 'parse_devlist': > usbreset.c:68:17: warning: implicit declaration of function 'strtoul'; did > you mean 'strtok'?

Re: [PATCH] Do not create and install usbutils.pc

2017-12-07 Thread Greg Kroah-Hartman
On Sat, Nov 25, 2017 at 08:59:12PM +0100, Aurelien Jarno wrote: > The usbutils pkgconfig file defines where the usb.ids database is > installed. Given usbutils does not ship with usb.ids and does not > install it anymore, it makes no sense to install such a pkgconfig > anymore. Remove it. > >

I NEED YOUR HELP URGENT

2017-12-07 Thread Emily Alba
I NEED YOUR HELP URGENT It's my pleasure to have contact with you,based on the critical condition I find mine self,though, it's not financial problem, but my health,you might have know that cancer is not what to talk home about,though I don't know you,and my contact with you was not by mistake,

RFC: FT232H based FPGA configuration adapter drivers

2017-12-07 Thread Anatolij Gustschin
Hi, I have to rework drivers for custom FT232H based FPGA configuration adapters to make them suitable for including in mainline kernel. These adapters should be usable via low-level drivers for FPGA Manager framework. Two required low-level FPGA Manager drivers (for PS-SPI and CvP

[PATCH 4.9 023/109] usb: dwc2: Error out of dwc2_hsotg_ep_disable() if were in host mode

2017-12-07 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: John Stultz [ Upstream commit 9b481092c2a31a6b630aff9c28f0145bf6683787 ] We've found that while in host mode, using Android, if one runs the command: stop adbd The

[PATCH 4.9 022/109] usb: dwc2: Fix UDC state tracking

2017-12-07 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: John Stultz [ Upstream commit ce2b21a4e5ce042c0a42c9db8fa9e0f849427d5e ] It has been noticed that the dwc2 udc state reporting doesn't seem to work (at least on HiKey

[PATCH 4.4 13/49] usb: dwc2: Fix UDC state tracking

2017-12-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: John Stultz [ Upstream commit ce2b21a4e5ce042c0a42c9db8fa9e0f849427d5e ] It has been noticed that the dwc2 udc state reporting doesn't seem to work (at least on HiKey

[PATCH 4.4 14/49] usb: dwc2: Error out of dwc2_hsotg_ep_disable() if were in host mode

2017-12-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: John Stultz [ Upstream commit 9b481092c2a31a6b630aff9c28f0145bf6683787 ] We've found that while in host mode, using Android, if one runs the command: stop adbd The

Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()

2017-12-07 Thread SF Markus Elfring
OOM does a dump_stack() so this function's call tree is shown. >>> >>> A call stack doesn't tell you which device was being handled. >> >> Do you find a default Linux allocation failure report insufficient then? >> >> Would you like to to achieve that the requested information can be

[PATCH 4.14 32/75] usb: dwc2: Fix UDC state tracking

2017-12-07 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: John Stultz [ Upstream commit ce2b21a4e5ce042c0a42c9db8fa9e0f849427d5e ] It has been noticed that the dwc2 udc state reporting doesn't seem to work (at least on HiKey

[PATCH 4.14 33/75] usb: dwc2: Error out of dwc2_hsotg_ep_disable() if were in host mode

2017-12-07 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: John Stultz [ Upstream commit 9b481092c2a31a6b630aff9c28f0145bf6683787 ] We've found that while in host mode, using Android, if one runs the command: stop adbd The

Re: [PATCH] usb-core: Fix potential null pointer dereference in xhci-debugfs.c

2017-12-07 Thread Mathias Nyman
On 07.12.2017 11:26, Alexander Kappner wrote: Date: Wed, 6 Dec 2017 15:28:37 -0800 Subject: [PATCH] usb-core: Fix potential null pointer dereference in xhci-debugfs.c (Added this as reply subject, please remember to send mail with proper subject) My kernel crashed just after resuming from

[PATCH 2/3] phy: phy-mtk-tphy: make shared banks optional for V1 TPHY

2017-12-07 Thread Chunfeng Yun
V1 TPHY for SATA doesn't have shared banks if it isn't shared with PCIe or USB, so make it optional. Signed-off-by: Chunfeng Yun --- drivers/phy/mediatek/phy-mtk-tphy.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 3/3] phy: phy-mtk-tphy: use of_device_get_match_data()

2017-12-07 Thread Chunfeng Yun
reduce the boilerplate code to get the specific data Signed-off-by: Chunfeng Yun --- drivers/phy/mediatek/phy-mtk-tphy.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/phy/mediatek/phy-mtk-tphy.c

[PATCH 1/3] phy: phy-mtk-tphy: use auto instead of force to bypass utmi signals

2017-12-07 Thread Chunfeng Yun
When system is running, if usb2 phy is forced to bypass utmi signals, all PLL will be turned off, and it can't detect device connection anymore, so replace force mode with auto mode which can bypass utmi signals automatically if no device attached for normal flow. But keep the force mode to fix RX

Re: [PATCH 0/1] USB Audio Device Class 3.0 Gadget support

2017-12-07 Thread Ruslan Bilovol
Hi Felipe, On Mon, Dec 4, 2017 at 1:36 PM, Felipe Balbi wrote: > > Hi, > > Ruslan Bilovol writes: >> On Tue, Nov 7, 2017 at 3:52 AM, Ruslan Bilovol >> wrote: >>> Hi, >>> >>> This patch adds USB Audio Device Class 3.0 [1]

[PATCH] usb: dwc3: of-simple: fix missing clk_disable_unprepare

2017-12-07 Thread Andreas Platschek
If of_clk_get() fails, the clean-up of already initialized clocks should be the same as when clk_prepare_enable() fails. Thus a clk_disable_unprepare() for each clock should be called before the clk_put(). Found by Linux Driver Verification project (linuxtesting.org). Fixes: 16adc674d0d6 ("usb:

Re: your mail

2017-12-07 Thread Greg Kroah-Hartman
On Thu, Dec 07, 2017 at 01:26:14AM -0800, Alexander Kappner wrote: > Date: Wed, 6 Dec 2017 15:28:37 -0800 > Subject: [PATCH] usb-core: Fix potential null pointer dereference in > xhci-debugfs.c Something went wrong here, resulting in an email with no subject. Can you fix this up and resend?

[PATCH v2 8/8] lsusb: Dump USB3 BOS Configuration Summary Descriptor.

2017-12-07 Thread Michael Drake
Add support for dumping the configuration summary device capability descriptor to the verbose output of lsusb. Signed-off-by: Michael Drake --- lsusb.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lsusb.c b/lsusb.c index e3eb423..c7a237e 100644 ---

[PATCH v2 7/8] lsusb: Add descriptor definition for USB3 BOS Configuration Summary.

2017-12-07 Thread Michael Drake
Add definition of the BOS configuration summary descriptor, as specified by the USB 3 standard, to the descriptor definitions for lsusb. Signed-off-by: Michael Drake --- desc-defs.c | 15 +++ desc-defs.h | 3 +++ 2 files changed, 18 insertions(+)

[PATCH v2 5/8] lsusb: Add descriptor definitions for UAC3.

2017-12-07 Thread Michael Drake
These descriptor definitions descibe how raw descriptor data should be interpreted. Signed-off-by: Michael Drake --- desc-defs.c | 338 desc-defs.h | 3 + desc-dump.c | 5 + 3 files changed, 303

[PATCH v2 3/8] lsusb: Add code to dump descriptor data using descriptor definition.

2017-12-07 Thread Michael Drake
This adds a new way of dumping descriptors. It takes the descriptor data to be dumped, and a descriptor definition as input. The descriptor definition takes the form of a NULL terminated array of descriptor field definitions. These definitions describe how the raw descriptor data buffer should

[PATCH v2 4/8] lsusb: Switch to descriptor-definition based dump for UAC1 and UAC2.

2017-12-07 Thread Michael Drake
This gives us more consistency in handling of incorrect descriptor buffer lengths, and improves whitespace/alignment consistency. Signed-off-by: Michael Drake --- Makefile.am | 2 + lsusb.c | 751

[PATCH v2 2/8] lsusb: Add declarative definitions for UAC1 and UAC2 descriptors.

2017-12-07 Thread Michael Drake
These descriptor definitions descibe how raw descriptor data should be interpreted. Signed-off-by: Michael Drake --- desc-defs.c | 728 desc-defs.h | 153 + 2 files changed, 881 insertions(+)

[PATCH v2 0/8] lsusb: Add initial support for USB Audio Class 3

2017-12-07 Thread Michael Drake
This adds a new way of dumping descriptors, which splits the knowledge of how to interpret descriptor data from the actual dumping. This has two advantages: 1. It is easy to add support for new descriptors, since they are now simple definitions that resemble the tables in the USB

[PATCH v2 1/8] lsusb: Split subtype mapping out of AudioControl interface handling.

2017-12-07 Thread Michael Drake
UAC1 and UAC2 have different different meanings for the same subtype value. This splits the subtype mapping out. Signed-off-by: Michael Drake --- lsusb.c | 128 +++- 1 file changed, 94 insertions(+), 34

[PATCH v2 6/8] lsusb: Add initial support for USB Audio Device Class 3.

2017-12-07 Thread Michael Drake
Make lsusb display verbose descriptor output for USB Audio Devide Class 3 devices. The descriptors have changed for version 3 of the protocol. Signed-off-by: Michael Drake --- lsusb.c | 52 ++-- 1 file changed, 34

Re: [PATCH v2] HID: add quirk for another PIXART OEM mouse used by HP

2017-12-07 Thread Jiri Kosina
On Fri, 1 Dec 2017, Dave Young wrote: > This mouse keep disconnecting in runleve 3 like below, add it needs the > quirk to mute the anoying messages. > > [ 111.230555] usb 2-2: USB disconnect, device number 6 > [ 112.718156] usb 2-2: new low-speed USB device number 7 using xhci_hcd > [

Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()

2017-12-07 Thread Dan Carpenter
On Thu, Dec 07, 2017 at 09:45:38AM +0100, Geert Uytterhoeven wrote: > > > > Small allocations never fail in the current kernel. > > A few comments (this is in response to a patch from Markus, so there have > to be lots of questions and uncertainties ;-) > 1. In the current kernel. What about the

[no subject]

2017-12-07 Thread Alexander Kappner
Date: Wed, 6 Dec 2017 15:28:37 -0800 Subject: [PATCH] usb-core: Fix potential null pointer dereference in xhci-debugfs.c My kernel crashed just after resuming from hibernate and starting usbmuxd (a user-space daemon for iOS device pairing) with several USB devices connected (dmesg attached).

musb-hdrc: can't add more than 2 functions to composite gadget

2017-12-07 Thread Nuno Gonçalves
Linux: 4.14.0 and 4.15-rc2 SOC: H3 Driver: sun8i-h3-musb I am trying to add 3 functions to a composite gadget and it fails. [4.664742] configfs-gadget gadget: acm/23b5a59a: can't bind, err -19 [4.671227] configfs-gadget musb-hdrc.1.auto: failed to start g1: -19 The same configuration

Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()

2017-12-07 Thread Oliver Neukum
Am Donnerstag, den 07.12.2017, 09:56 +0100 schrieb Greg Kroah-Hartman: > On Thu, Dec 07, 2017 at 09:45:38AM +0100, Geert Uytterhoeven wrote: > > > > A few comments (this is in response to a patch from Markus, so there have > > to be lots of questions and uncertainties ;-) > > Note, because of

Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()

2017-12-07 Thread Greg Kroah-Hartman
On Thu, Dec 07, 2017 at 09:45:38AM +0100, Geert Uytterhoeven wrote: > A few comments (this is in response to a patch from Markus, so there have > to be lots of questions and uncertainties ;-) Note, because of the patch author, I'm not applying it no matter what, so this discussion is really going

Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()

2017-12-07 Thread Geert Uytterhoeven
Hi Dan, On Thu, Dec 7, 2017 at 9:35 AM, Dan Carpenter wrote: > On Thu, Dec 07, 2017 at 08:40:07AM +0100, Geert Uytterhoeven wrote: >> On Wed, Dec 6, 2017 at 11:02 PM, Alan Stern >> wrote: >> > On Wed, 6 Dec 2017, SF Markus Elfring wrote: >>

Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()

2017-12-07 Thread Dan Carpenter
On Thu, Dec 07, 2017 at 08:40:07AM +0100, Geert Uytterhoeven wrote: > Hi Alan, > > On Wed, Dec 6, 2017 at 11:02 PM, Alan Stern wrote: > > On Wed, 6 Dec 2017, SF Markus Elfring wrote: > >> >>> Does the existing memory allocation error message include the > >> >>> >dev