Re: [PATCH 1/7] soc: mediatek: Add USB wakeup driver

2017-12-20 Thread Chunfeng Yun
On Fri, 2017-12-15 at 14:55 -0600, Rob Herring wrote: > On Sat, Dec 09, 2017 at 04:45:30PM +0800, Chunfeng Yun wrote: > > This driver is used to support usb wakeup which is controlled by > > the glue layer between SSUSB and SPM. Usually the glue layer is put > > into a system controller, such as

Re: [PATCH 0/7] Add USB remote wakeup driver

2017-12-20 Thread Chunfeng Yun
On Fri, 2017-12-15 at 14:55 -0600, Rob Herring wrote: > On Sat, Dec 09, 2017 at 04:45:29PM +0800, Chunfeng Yun wrote: > > These patches introduce the SSUSB and SPM glue layer driver which is > > used to support usb remote wakeup. Usually the glue layer is put into > > a system controller, such

[PATCH] usb: gadget: core: Fix use-after-free of usb_request

2017-12-20 Thread Manu Gautam
Driver is tracing usb_request after freeing it. Fix it by changing the order. Signed-off-by: Manu Gautam --- drivers/usb/gadget/udc/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c

RE: [PATCH v1] usb: chipidea: tegra: Use aligned DMA on Tegra30

2017-12-20 Thread Peter Chen
> On Tue, Dec 19, 2017 at 05:58:07AM +0300, Dmitry Osipenko wrote: > > USB Ethernet gadget now works on Tegra30. > > > > Signed-off-by: Dmitry Osipenko > > --- > > drivers/usb/chipidea/ci_hdrc_tegra.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Acked-by:

Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2017-12-20 Thread Zhang Rui
On Tue, 2017-12-19 at 10:15 -0800, Joe Perches wrote: > Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible. > > Done with perl script: > > $ git grep -w --name-only DEVICE_ATTR | \ >   xargs perl -i -e 'local $/; while (<>) { >

[PATCH] USB: serial: ftdi_sio: add id for Airbus DS P8GR

2017-12-20 Thread Max Schulze
Add AIRBUS_DS_P8GR device IDs to ftdi_sio driver. Signed-off-by: Max Schulze --- The device allows a simple AT style modem command set. Tested up to the advertised maximum of 115200 baud. Bus 001 Device 013: ID 1e8e:6001 Device Descriptor: bLength18

Re: [PATCH v1] usb: chipidea: tegra: Use aligned DMA on Tegra30

2017-12-20 Thread Thierry Reding
On Tue, Dec 19, 2017 at 05:58:07AM +0300, Dmitry Osipenko wrote: > USB Ethernet gadget now works on Tegra30. > > Signed-off-by: Dmitry Osipenko > --- > drivers/usb/chipidea/ci_hdrc_tegra.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Thierry Reding

Re: [PATCH 1/2] Revert "Bluetooth: btusb: fix QCA Rome suspend/resume"

2017-12-20 Thread Brian Norris
On Wed, Dec 20, 2017 at 07:00:07PM +0800, Kai-Heng Feng wrote: > This reverts commit fd865802c66bc451dc515ed89360f84376ce1a56. > > This commit causes a regression on some QCA ROME chips. The USB device > reset happens in btusb_open(), hence firmware loading gets interrupted. Oh, did you really

Re: [PATCH v3 6/7] typec: tcpm: Represent source supply through power_supply class

2017-12-20 Thread kbuild test robot
the system] url: https://github.com/0day-ci/linux/commits/Adam-Thomson/typec-tcpm-Add-sink-side-support-for-PPS/20171220-205656 coccinelle warnings: (new ones prefixed by >>) >> drivers/usb/typec/tcpm.c:4396:1-3: WARNING: PTR_ERR_OR_ZERO can be used Please review and possibly fold the fo

[PATCH] typec: tcpm: fix ptr_ret.cocci warnings

2017-12-20 Thread kbuild test robot
From: Fengguang Wu drivers/usb/typec/tcpm.c:4396:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 91886adfce05 ("typec: tcpm: Represent source supply through

Re: [PATCH v2 3/4] usb: phy: Add Kconfig entry for Tegra PHY driver

2017-12-20 Thread Dmitry Osipenko
On 20.12.2017 16:17, kbuild test robot wrote: > Hi Dmitry, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on balbi-usb/next] > [also build test ERROR on v4.15-rc4 next-20171220] > [if your patch is applied to the wrong git tree, please drop

Re: [PATCH v3 1/7] typec: tcpm: Add PD Rev 3.0 definitions to PD header

2017-12-20 Thread kbuild test robot
to help improve the system] url: https://github.com/0day-ci/linux/commits/Adam-Thomson/typec-tcpm-Add-sink-side-support-for-PPS/20171220-205656 config: i386-randconfig-x016-201751 (attached as .config) compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025 reproduce: # save the attached .config

Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2017-12-20 Thread Julia Lawall
On Wed, 20 Dec 2017, Joe Perches wrote: > On Wed, 2017-12-20 at 10:59 +0100, Greg Kroah-Hartman wrote: > > > > Why you didn't send that patch to the sysfs maintainer is a bit odd... > > > > :) > > > > > > So here's an opportunity for you: > > > > > > The sysfs maintainer hasn't added

Re: [PATCH v2 3/4] usb: phy: Add Kconfig entry for Tegra PHY driver

2017-12-20 Thread kbuild test robot
Hi Dmitry, Thank you for the patch! Yet something to improve: [auto build test ERROR on balbi-usb/next] [also build test ERROR on v4.15-rc4 next-20171220] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

[PATCH 1/2] Revert "Bluetooth: btusb: fix QCA Rome suspend/resume"

2017-12-20 Thread Kai-Heng Feng
This reverts commit fd865802c66bc451dc515ed89360f84376ce1a56. This commit causes a regression on some QCA ROME chips. The USB device reset happens in btusb_open(), hence firmware loading gets interrupted. Furthermore, this commit stops working after commit

[PATCH 2/2] usb: quirks: Add reset-resume quirk for Dell DW1820 QCA Rome Bluetooth

2017-12-20 Thread Kai-Heng Feng
Commit ("fd865802c66bc451dc515ed89360f84376ce1a56 Bluetooth: btusb: fix QCA Rome suspend/resume") enables reset_resume in btusb_probe(). This makes the device resets during btusb_open(), firmware loading gets interrupted as a result. We still want to reset the device to solve the original issue,

Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2017-12-20 Thread Jarkko Nikula
On Wed, Dec 20, 2017 at 10:32:11AM +0100, Greg Kroah-Hartman wrote: > On Wed, Dec 20, 2017 at 01:24:44AM -0800, Joe Perches wrote: > > On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote: > > > On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote: > > > > Convert DEVICE_ATTR uses to

Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2017-12-20 Thread Joe Perches
On Wed, 2017-12-20 at 10:59 +0100, Greg Kroah-Hartman wrote: > > > Why you didn't send that patch to the sysfs maintainer is a bit odd... :) > > > > So here's an opportunity for you: > > > > The sysfs maintainer hasn't added include/linux/sysfs.h to > > the list of maintained files... > > > >

Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2017-12-20 Thread Greg Kroah-Hartman
On Wed, Dec 20, 2017 at 01:54:41AM -0800, Joe Perches wrote: > On Wed, 2017-12-20 at 10:32 +0100, Greg Kroah-Hartman wrote: > > On Wed, Dec 20, 2017 at 01:24:44AM -0800, Joe Perches wrote: > > > On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote: > > > > On Tue, Dec 19, 2017 at 10:15:07AM

Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2017-12-20 Thread Joe Perches
On Wed, 2017-12-20 at 10:32 +0100, Greg Kroah-Hartman wrote: > On Wed, Dec 20, 2017 at 01:24:44AM -0800, Joe Perches wrote: > > On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote: > > > On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote: > > > > Convert DEVICE_ATTR uses to

Re: [-next PATCH 0/4] sysfs and DEVICE_ATTR_

2017-12-20 Thread Felipe Balbi
Hi, Joe Perches writes: > drivers/usb/phy/phy-tahvo.c| 2 +- Acked-by: Felipe Balbi -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org

Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2017-12-20 Thread Greg Kroah-Hartman
On Wed, Dec 20, 2017 at 01:24:44AM -0800, Joe Perches wrote: > On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote: > > On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote: > > > Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible. > [] > > > diff --git a/sound/soc/omap/mcbsp.c

Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2017-12-20 Thread Joe Perches
On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote: > On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote: > > Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible. [] > > diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c [] > > @@ -854,7 +854,7 @@ static ssize_t

Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2017-12-20 Thread Jarkko Nikula
On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote: > Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible. > ... > diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c > index 7a54e3083203..79d4dc785e5c 100644 > --- a/sound/soc/omap/mcbsp.c > +++ b/sound/soc/omap/mcbsp.c

Re: [PATCH v3 14/16] phy: Add notify_speed callback

2017-12-20 Thread Manu Gautam
Hi On 12/20/2017 12:47 PM, Kishon Vijay Abraham I wrote: > Hi, > [snip] >>> Why not use a notification mechanism instead of adding new APIs in phy-core. >>> This will only bloat phy-core with APIs for a particular platform. >> Do you mean notifier_chains ? >> When we have multiple instances of